[edk2-devel] [PATCH v2 2/2] MdeModulePkg/Bus/Pci/UhciDxe: Fix FORWARD_NULL Coverity issues

From: Ranbir Singh The function UsbHcGetPciAddressForHostMem has ASSERT ((Block != NULL)); and and the function UsbHcFreeMem has ASSERT (Block != NULL); statement after for loop, but these are applicable only in DEBUG mode. In RELEASE mode, if for whatever reasons there is no match

[edk2-devel] [PATCH v2 1/2] MdeModulePkg/Bus/Pci/UhciDxe: Fix BAD_SHIFT Coverity issue

From: Ranbir Singh The function UhciConvertPollRate has a check ASSERT (Interval != 0); but this comes into play only in DEBUG mode. In Release mode, there is no handling if the Interval parameter value is ZERO. To avoid shifting by a negative amount later in the code flow in this

[edk2-devel] [PATCH v2 0/2] MdeModulePkg/Bus/Pci/UhciDxe: Fix issues pointed by Coverity

v1 -> v2: - Update patch wrt BAD_SHIFT changes as per review comments Ranbir Singh (2): MdeModulePkg/Bus/Pci/UhciDxe: Fix BAD_SHIFT Coverity issue MdeModulePkg/Bus/Pci/UhciDxe: Fix FORWARD_NULL Coverity issues MdeModulePkg/Bus/Pci/UhciDxe/UhciSched.c | 10 +-

Re: [edk2-devel] [PATCH 1/1] RedfishPkg/RedfishPlatformConfigDxe: Fix unused variable

[AMD Official Use Only - General] Reviewed-by: Abner Chang > -Original Message- > From: Nhi Pham > Sent: Wednesday, August 16, 2023 12:31 PM > To: devel@edk2.groups.io > Cc: Nhi Pham ; Nickle Wang > ; Chang, Abner ; Igor > Kulchytskyy ; Nick Ramirez > Subject: [PATCH 1/1]

[edk2-devel] [PATCH 1/1] RedfishPkg/RedfishPlatformConfigDxe: Fix unused variable

This fixes an unused variable 'Index' error in release build. Cc: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez Signed-off-by: Nhi Pham --- PR: https://github.com/tianocore/edk2/pull/4742 RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigImpl.c | 3 ++- 1 file

[edk2-devel] How to report bugs in the Intel GigUndiDxe driver?

Intel has been releasing the EDK2/UEFI source code for their network drivers (https://www.intel.com/content/www/us/en/download/15755/intel-ethernet-connections-boot-utility-preboot-images-and-efi-drivers.html) but I've found a few problems with it. The first issue I ran into is that

Re: [edk2-devel] [PATCH v2 7/7] AlderlakeSiliconPkg/SystemAgent: Add library and driver modules

Reviewed-by: Rosen Chuang < rosen.chu...@intel.com> -Original Message- From: Kasbekar, Saloni Sent: Saturday, August 5, 2023 1:38 AM To: devel@edk2.groups.io Cc: Kasbekar, Saloni ; Chaganty, Rangasai V ; Desimone, Nathaniel L ; Oram, Isaac W ; Chuang, Rosen Subject: [PATCH v2 7/7]

Re: [edk2-devel] [PATCH v2 6/7] AlderlakeSiliconPkg/SystemAgent: Add include headers

Reviewed-by: Rosen Chuang < rosen.chu...@intel.com> -Original Message- From: Kasbekar, Saloni Sent: Saturday, August 5, 2023 1:38 AM To: devel@edk2.groups.io Cc: Kasbekar, Saloni ; Chaganty, Rangasai V ; Desimone, Nathaniel L ; Oram, Isaac W ; Chuang, Rosen Subject: [PATCH v2 6/7]

Re: [edk2-devel] [PATCH v2 2/7] AlderlakeSiliconPkg: Add Cpu modules

Reviewed-by: Rosen Chuang < rosen.chu...@intel.com> -Original Message- From: Kasbekar, Saloni Sent: Saturday, August 5, 2023 1:38 AM To: devel@edk2.groups.io Cc: Kasbekar, Saloni ; Chaganty, Rangasai V ; Desimone, Nathaniel L ; Oram, Isaac W ; Chuang, Rosen Subject: [PATCH v2 2/7]

Re: [edk2-devel] [PATCH v2 3/7] AlderlakeSiliconPkg/Pch: Add include headers

Reviewed-by: Rosen Chuang < rosen.chu...@intel.com> -Original Message- From: Kasbekar, Saloni Sent: Saturday, August 5, 2023 1:38 AM To: devel@edk2.groups.io Cc: Kasbekar, Saloni ; Chaganty, Rangasai V ; Desimone, Nathaniel L ; Oram, Isaac W ; Chuang, Rosen Subject: [PATCH v2 3/7]

Re: [edk2-devel] [PATCH v2 4/7] AlderlakeSiliconPkg/Pch: Add libraries

Reviewed-by: Rosen Chuang < rosen.chu...@intel.com> Thanks, Rosen -Original Message- From: Kasbekar, Saloni Sent: Saturday, August 5, 2023 1:38 AM To: devel@edk2.groups.io Cc: Kasbekar, Saloni ; Chaganty, Rangasai V ; Desimone, Nathaniel L ; Oram, Isaac W ; Chuang, Rosen Subject:

Re: [edk2-devel] [PATCH v2 1/7] AlderlakeSiliconPkg: Add package and library instances

Reviewed-by: Rosen Chuang < rosen.chu...@intel.com> Thanks, Rosen -Original Message- From: Kasbekar, Saloni Sent: Saturday, August 5, 2023 1:38 AM To: devel@edk2.groups.io Cc: Kasbekar, Saloni ; Chaganty, Rangasai V ; Desimone, Nathaniel L ; Oram, Isaac W ; Chuang, Rosen Subject:

回复: edk2-stable202308 Re: [edk2-devel][PATCH v1 1/1] MdeModulePkg: HeapGuard: Don't Assume Pool Head Allocated In First Page

Oliver: This change reverts the changes done in AdjustPoolHeadA(). It matches the allocation logic. I think this change is good. Reviewed-by: Liming Gao I am also OK to merge this change for the stable tag 202308. Besides, AdjustPoolHeadA() implementation has the extra logic " Size =

Re: [edk2-devel] [PATCH V2 2/2] ShellPkg: Add ProcessorUpgradeSocket definitions from SMBIOS 3.7.0

Reviewed-by: Star Zeng -Original Message- From: devel@edk2.groups.io On Behalf Of Eduardo Cuevas Farfan Sent: Friday, August 11, 2023 12:32 AM To: devel@edk2.groups.io Cc: Cuevas Farfan, Eduardo Subject: [edk2-devel] [PATCH V2 2/2] ShellPkg: Add ProcessorUpgradeSocket definitions

Re: [edk2-devel] [PATCH V2 1/2] MdePkg: Add ProcessorUpgradeSocket definitions from SMBIOS 3.7.0

Reviewed-by: Star Zeng -Original Message- From: devel@edk2.groups.io On Behalf Of Eduardo Cuevas Farfan Sent: Friday, August 11, 2023 12:32 AM To: devel@edk2.groups.io Cc: Cuevas Farfan, Eduardo Subject: [edk2-devel] [PATCH V2 1/2] MdePkg: Add ProcessorUpgradeSocket definitions from

[edk2-devel] 回复: [PATCH v1 1/1] MdeModulePkg: Memory Bin Range Update Accounts for Guard Page

Reviewed-by: Liming Gao > -邮件原件- > 发件人: Taylor Beebe > 发送时间: 2023年8月11日 2:07 > 收件人: devel@edk2.groups.io > 抄送: Jian J Wang ; Liming Gao > ; Dandan Bi > 主题: [PATCH v1 1/1] MdeModulePkg: Memory Bin Range Update Accounts > for Guard Page > > From: Taylor Beebe > > When finding a free

Re: [edk2-devel] [PATCH v1] UefiCpuPkg/SmmCpu: Refine semaphore sync between BSP and AP

+Mike for this review. > -Original Message- > From: devel@edk2.groups.io On Behalf Of Wu, > Jiaxin > Sent: Wednesday, August 9, 2023 5:04 PM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Ni, Ray ; Zeng, Star > ; Kumar, Rahul R ; Gerd > Hoffmann > Subject: [edk2-devel] [PATCH v1]

Re: [edk2-devel] About EDK2 supports Self Modifying Code

> On Aug 15, 2023, at 11:48 AM, Ard Biesheuvel wrote: > > On Tue, 15 Aug 2023 at 18:31, Andrew Fish via groups.io > mailto:afish=apple@groups.io>> wrote: >> >> >> >>> On Aug 15, 2023, at 8:39 AM, Pedro Falcato wrote: >>> >>> On Tue, Aug 15, 2023 at 4:05 PM Andrew

Re: [edk2-devel] About EDK2 supports Self Modifying Code

On Tue, 15 Aug 2023 at 18:31, Andrew Fish via groups.io wrote: > > > > > On Aug 15, 2023, at 8:39 AM, Pedro Falcato wrote: > > > > On Tue, Aug 15, 2023 at 4:05 PM Andrew Fish via groups.io > > wrote: > >> > >> Chao, > >> > >> From a quick google it looks like CSR* is used to access banks of >

Re: [edk2-devel] About EDK2 supports Self Modifying Code

> On Aug 15, 2023, at 8:39 AM, Pedro Falcato wrote: > > On Tue, Aug 15, 2023 at 4:05 PM Andrew Fish via groups.io > wrote: >> >> Chao, >> >> From a quick google it looks like CSR* is used to access banks of registers >> that relate to things like performance counters and debug

[edk2-devel] [PATCH v1 1/1] SecurityPkg/Tpm2DeviceLibTcg2: Make mTcg2Protocol static

From: Michael Kubacki The global variable has a common name that can conflict with other TCG modules. For example, Tcg2Dxe has a similarly named global that is of type EFI_TCG2_PROTOCOL instead of EFI_TCG2_PROTOCOL*. Cc: Jiewen Yao Cc: Jian J Wang Signed-off-by: Michael Kubacki ---

Re: [edk2-devel] About EDK2 supports Self Modifying Code

On Tue, Aug 15, 2023 at 4:05 PM Andrew Fish via groups.io wrote: > > Chao, > > From a quick google it looks like CSR* is used to access banks of registers > that relate to things like performance counters and debug infrastructure and > the number of banks of these register sets is likely

Re: [edk2-devel] About EDK2 supports Self Modifying Code

On Tue, Aug 15, 2023 at 9:20 AM Chao Li wrote: > > Hi Andrew, > > Yes, you are right, I also think that SMC is a bit flawed in terms of > security, but can we use some security mechanism to protect the SMC, like > encryption and decryption? Sorry, I'm not consider mature enough about SMC >

Re: [edk2-devel] About EDK2 supports Self Modifying Code

Chao, >From a quick google it looks like CSR* is used to access banks of registers >that relate to things like performance counters and debug infrastructure and >the number of banks of these register sets is likely implementation defined. >Seems like we could introduce some Fixed At Build PCD

edk2-stable202308 Re: [edk2-devel][PATCH v1 1/1] MdeModulePkg: HeapGuard: Don't Assume Pool Head Allocated In First Page

On 2023-08-09 22:51, Ard Biesheuvel wrote: On Wed, 9 Aug 2023 at 23:35, Oliver Smith-Denny wrote: Currently, HeapGuard, when in the GuardAlignedToTail mode, assumes that the pool head has been allocated in the first page of memory that was allocated. This is not the case for ARM64 platforms

Re: [edk2-devel] About EDK2 supports Self Modifying Code

Hi Ard, Ok, I see, thanks for you suggestion. Thanks, Chao 在 2023/8/15 16:28, Ard Biesheuvel 写道: On Tue, 15 Aug 2023 at 10:20, Chao Li wrote: Hi Andrew, Yes, you are right, I also think that SMC is a bit flawed in terms of security, but can we use some security mechanism to protect the

Re: [edk2-devel] About EDK2 supports Self Modifying Code

On Tue, 15 Aug 2023 at 10:20, Chao Li wrote: > > Hi Andrew, > > Yes, you are right, I also think that SMC is a bit flawed in terms of > security, but can we use some security mechanism to protect the SMC, like > encryption and decryption? Sorry, I'm not consider mature enough about SMC >

Re: [edk2-devel] About EDK2 supports Self Modifying Code

Hi Andrew, Yes, you are right, I also think that SMC is a bit flawed in terms of security, but can we use some security mechanism to protect the SMC, like encryption and decryption? Sorry, I'm not consider mature enough about SMC security. I can tell you real problem, there are some CSR

Re: [edk2-devel] [PATCH v1 1/1] OvmfPkg/Bhyve: build platform info HOB

On Mon, 14 Aug 2023 at 10:15, Corvin Köhne wrote: > > On Thu, 2023-08-10 at 15:54 -0400, Michael Kubacki wrote: > > I'm not sure why test results are not being reported that may be a > > larger issue. > > > > I pulled the branch locally, run uncrustify, and it automatically > > fixed > > the code