Re: [edk2-devel] [PATCH v2] OvmfPkg: RiscVVirt: Fix network drivers not be built

2024-01-14 Thread Sunil V L
On Fri, Jan 12, 2024 at 05:05:26PM -0800, Tuan Phan wrote: > Only need to include Network.dsc.inc to have all network > drivers/components be built. Otherwise, there were missing definition > that prevent them from be built for RiscVVirt platform. > > Signed-off-by: Tuan Phan > --- > v2: > -

Re: [edk2-devel] RFC: Folder layout change in UefiCpuPkg

2024-01-14 Thread Sunil V L
On Mon, Jan 15, 2024 at 02:17:09PM +0800, Chao Li wrote: > Ray and Sunil, > > I plan send two example PRs to github to  show how to deal the INFs, one to > adjust current INF, and another PR to move the libraris to the current > folders. I hope after these two PRs are sent we can decide what to

Re: [edk2-devel] RFC: Folder layout change in UefiCpuPkg

2024-01-14 Thread Chao Li
Ray and Sunil, I plan send two example PRs to github to  show how to deal the INFs, one to adjust current INF, and another PR to move the libraris to the current folders. I hope after these two PRs are sent we can decide what to do with the INF. What do you think of this plan? Thanks, Chao

Re: [edk2-devel] RFC: Folder layout change in UefiCpuPkg

2024-01-14 Thread Ni, Ray
That will be great! Thanks, Ray > -Original Message- > From: Sunil V L > Sent: Monday, January 15, 2024 12:44 PM > To: Ni, Ray > Cc: devel@edk2.groups.io; lic...@loongson.cn; Kinney, Michael D > ; Laszlo Ersek ; Gerd > Hoffmann > Subject: Re: RFC: Folder layout change in UefiCpuPkg >

Re: [edk2-devel] [PATCH v2] NetworkPkg: Triger regularly scan only if not connect to AP

2024-01-14 Thread Heng Luo
Thank Liming! > -Original Message- > From: devel@edk2.groups.io On Behalf Of > gaoliming via groups.io > Sent: Monday, January 15, 2024 1:02 PM > To: Luo, Heng ; devel@edk2.groups.io; Kasbekar, Saloni > ; Clark-williams, Zachary willi...@intel.com>; Kinney, Michael D > Subject: 回复:

Re: [edk2-devel] [PATCH v2] RedfishPkg/RedfishCrtLib: handle floating point number in JSON

2024-01-14 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Reviewed-by: Abner Chang > -Original Message- > From: Nickle Wang > Sent: Sunday, January 14, 2024 10:14 PM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Igor Kulchytskyy > ; Nick Ramirez > Subject: [PATCH v2] RedfishPkg/RedfishCrtLib: handle

回复: [edk2-devel] [PATCH v2] NetworkPkg: Triger regularly scan only if not connect to AP

2024-01-14 Thread gaoliming via groups.io
Heng: This one has been merged. Thanks Liming > -邮件原件- > 发件人: Luo, Heng > 发送时间: 2024年1月15日 11:08 > 收件人: devel@edk2.groups.io; Luo, Heng ; Gao, > Liming ; Kasbekar, Saloni > ; Clark-williams, Zachary > ; Kinney, Michael D > > 主题: RE: [edk2-devel] [PATCH v2] NetworkPkg: Triger

Re: [edk2-devel] RFC: Folder layout change in UefiCpuPkg

2024-01-14 Thread Sunil V L
On Mon, Jan 15, 2024 at 01:13:03AM +, Ni, Ray wrote: > Sunil, > I am glad that you don't have concern about the direction. > > "RiscV" is good to me. > > Thanks!, Ray. So, shall I send patches to reorganize this? Thanks, Sunil -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all

Re: [edk2-devel] [PATCH v2 1/1] Sophgo/SG2042Pkg: Override Sstc extension

2024-01-14 Thread Sunil V L
On Sat, Jan 13, 2024 at 10:39:16AM +0800, caiyuqing...@163.com wrote: > From: caiyuqing379 > > Override Sstc extension and use SBI calls itself by default for RISC-V > Sophgo SG2042 platform. > Since the change disables CMO also (BIT 0) which is expected, could you update the commit message to

Re: [edk2-devel] [PATCH v2] OvmfPkg: RiscVVirt: Fix network drivers not be built

2024-01-14 Thread Sunil V L
On Fri, Jan 12, 2024 at 05:05:26PM -0800, Tuan Phan wrote: > Only need to include Network.dsc.inc to have all network > drivers/components be built. Otherwise, there were missing definition > that prevent them from be built for RiscVVirt platform. > > Signed-off-by: Tuan Phan > --- > v2: > -

Re: [edk2-devel] [PATCH v2] NetworkPkg: Triger regularly scan only if not connect to AP

2024-01-14 Thread Heng Luo
Hi Liming & Mike, Could you please help to merge PR https://github.com/tianocore/edk2/pull/5075 ? Thanks, Heng > -Original Message- > From: devel@edk2.groups.io On Behalf Of Heng Luo > Sent: Tuesday, January 9, 2024 11:17 AM > To: Gao, Liming ; devel@edk2.groups.io; > Kasbekar, Saloni ;

Re: [edk2-devel] [PATCH] UefiCpuPkg: Fix issue that IsModified is wrongly set in PageTableMap

2024-01-14 Thread Zhiguang Liu
Hi Laszlo, I don't think it is a good idea to explicitly mask out the Accessed/Dirty bit. We can't assume Accessed/Dirty bit are only changed by hardware, because the caller also can change the Accessed/Dirty bit. For API PageTableMap, the IsModified is already set as False in the beginning

Re: [edk2-devel] [PATCH 1/1] MdePkg: Update the comments of HiiConfigAccess ExtractConfig

2024-01-14 Thread Ren, Suqiang
Hi Liming, Could you help to merge below patches which all your reviewed-by? Thanks! https://github.com/tianocore/edk2/pull/5170 https://github.com/tianocore/edk2/pull/5186 https://github.com/tianocore/edk2/pull/5190 Thanks Ren, Suqiang -Original

Re: [edk2-devel] [PATCH v2] MdePkg/BaseLib:Fix boot DxeCore hang on riscv platform

2024-01-14 Thread WangYang
> -原始邮件- > 发件人: "Sunil V L" > 发送时间: 2024-01-11 23:21:21 (星期四) > 收件人: devel@edk2.groups.io, andrei.warken...@intel.com > 抄送: "Yang Wang" , "Ran Wang" , > "Bamvor Jian ZHANG" , "Gao, Liming" > , "Kinney, Michael D" , > "Liu, Zhiguang" > 主题: Re: [edk2-devel] [PATCH v2]

Re: [edk2-devel] [PATCH V2 0/2] Update keybaord map based on UEFI spec 2.10

2024-01-14 Thread Li, Yi
Hi Liming, Could you help merge below patches which got your reviewed-by? Thanks! https://github.com/tianocore/edk2/pull/5210 https://github.com/tianocore/edk2/pull/5187 Regards, Yi -Original Message- From: gaoliming Sent: Monday, January 8, 2024 9:16 AM To: Li, Yi1 ;

Re: [edk2-devel] RFC: Folder layout change in UefiCpuPkg

2024-01-14 Thread Ni, Ray
Sunil, I am glad that you don't have concern about the direction. "RiscV" is good to me. Thanks, Ray > -Original Message- > From: Sunil V L > Sent: Friday, January 12, 2024 6:19 PM > To: Ni, Ray > Cc: devel@edk2.groups.io; lic...@loongson.cn; Kinney, Michael D > ; Laszlo Ersek ; Gerd

[edk2-devel] Event: Tools, CI, Code base construction meeting series - Monday, January 15, 2024 #cal-reminder

2024-01-14 Thread Group Notification
*Reminder: Tools, CI, Code base construction meeting series* *When:* Monday, January 15, 2024 4:30pm to 5:30pm (UTC-08:00) America/Los Angeles *Where:*

Re: [edk2-devel] [PATCH] RedfishPkg/RedfishCrtLib: handle floating point number in JSON

2024-01-14 Thread Nickle Wang via groups.io
Thanks Abner. I found an issue in this patch and resolved it in version 2 here: https://edk2.groups.io/g/devel/message/113780 Could you please help me to review it again? Regards, Nickle > -Original Message- > From: Chang, Abner > Sent: Saturday, January 13, 2024 10:19 PM > To: Nickle

[edk2-devel] [PATCH v2] RedfishPkg/RedfishCrtLib: handle floating point number in JSON

2024-01-14 Thread Nickle Wang via groups.io
When the value type is defined as number in Redfish schema, floating point number is allowed. RedfishCrtLib raises assert without handling this case now. Follow the way in EDK2 to call AsciiStrDecimalToUintnS and handle the floating point number. Only the integer value is returned. Signed-off-by: