Reviewed-by: Zhichao Gao
Thanks,
Zhichao
> -Original Message-
> From: Lou, Yun
> Sent: Sunday, April 14, 2024 11:24 PM
> To: devel@edk2.groups.io
> Cc: Lou, Yun ; Liu, Zhiguang ;
> Bi, Dandan ; Zeng, Star ; Gao,
> Zhichao ; Lin, Benny ; Guo,
> Gua ; Kinney, Michael D
> ; Liming Gao
>
Hi Liming,
Please help to review this patch and include Smbios 3.7.0 spec update changes.
Thanks,
sainadh.
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117753): https://edk2.groups.io/g/devel/message/117753
Mute This Topic:
+ Rebecca and Mike,
Would you be able to review this PR?
Regards,
JP
-Original Message-
From: devel@edk2.groups.io On Behalf Of Jayaprakash, N
Sent: Wednesday, April 10, 2024 11:49 AM
To: devel@edk2.groups.io
Cc: Jayaprakash, N ; Rebecca Cran ;
Kinney, Michael D
Subject: [edk2-devel]
Hi Liming,
But we met some issues that system will stuck for 5-7 minutes because of USB
transaction error with some USB device.
And check the XHCI spec, it shows need reset endpoint when USB transaction.
Thanks,
Xianglei
From: gaoliming
Sent: Monday, April 15, 2024 1:23 PM
To: Ni, Ray
Cc:
Reviewed-by: Liming Gao
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Qingyu
> 发送时间: 2024年4月2日 11:56
> 收件人: devel@edk2.groups.io
> 抄送: Dandan Bi ; Liming Gao
>
> 主题: [edk2-devel] [edk2-platforms][PATCH] VirtualKeyboardFeaturePkg:
> Update the comments of ReadKeyStroke and ReadKeyStrokeEx -
Xianglei:
Now, UEFI spec doesn’t define EFI_USB_ERR_TRANSACTION. So, we can’t
update UsbIo.h now.
EFI_USB_ERR_TRANSACTION is only used in XhciDxe for error condition check.
I suggest to add comments for current code, don’t need code update.
Thanks
Liming
发件人: Ni, Ray
发送时间:
I suggest to define this PCD in MdeModulePkg instead of MdePkg. This PCD is
only consumed by MdeModulePkg XhciDxe module.
Thanks
Liming
发件人: Cai, Xianglei
发送时间: 2024年4月12日 9:54
收件人: Lewandowski, Krzysztof ;
devel@edk2.groups.io; Ni, Ray ; Liming Gao
抄送: Huang, Jenny ; Shih, More
; Chiu,
Thanks for your update. Reviewed-by: Liming Gao
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Taylor Beebe
> 发送时间: 2024年4月10日 3:43
> 收件人: devel@edk2.groups.io; gaolim...@byosoft.com.cn
> 抄送: 'Rebecca Cran' ; 'Bob Feng'
> ; 'Yuwei Chen'
> 主题: Re: 回复: 回复: [edk2-devel] [PATCH v2 0/2] Update
Reviewed-by: Liming Gao for this patch set.
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Jason Lou
> 发送时间: 2024年4月14日 23:24
> 收件人: devel@edk2.groups.io
> 抄送: Jason Lou ; Zhiguang Liu
;
> Dandan Bi ; Star Zeng ; Zhichao
> Gao ; Benny Lin ; Gua Guo
> ; Michael D Kinney ;
> Liming Gao
> 主题:
Liming,
Can you give a R-B?
Thanks,
Ray
From: Cai, Xianglei
Sent: Friday, April 12, 2024 9:53
To: Lewandowski, Krzysztof ;
devel@edk2.groups.io ; Ni, Ray ; Liming
Gao
Cc: Huang, Jenny ; Shih, More
Subject: RE: [PATCH 1/1] MdeModulePkg/XhciDxe: Reset endpoint
Chao,
I've replied all of your patches.
Only for patch "[edk2-devel] [PATCH v3 10/13] UefiCpuPkg: Add a new GUID to
store the processors resource", I have one comment. Others look good to me.
Thanks,
Ray
From: Chao Li
Sent: Friday, April 12, 2024 15:32
To:
Reviewed-by: Ray Ni
Thanks,
Ray
From: Chao Li
Sent: Friday, April 12, 2024 15:34
To: devel@edk2.groups.io
Cc: Ni, Ray ; Kumar, Rahul R ; Gerd
Hoffmann
Subject: [PATCH v3 13/13] UefiCpuPkg/UefiCpuPkg.dsc: Add CpuMmio2Dxe.inf to
LoongArch64 field
LoongArch64
Acked-by: Ray Ni
Thanks,
Ray
From: Chao Li
Sent: Friday, April 12, 2024 15:34
To: devel@edk2.groups.io
Cc: Ni, Ray ; Kumar, Rahul R ; Gerd
Hoffmann ; Baoqi Zhang ; Dongyan
Qian ; Xianglai Li ; Bibo Mao
Subject: [PATCH v3 09/13] UefiCpuPkg: Add CpuMmuLib to
Reviewed-by: Ray Ni
Thanks,
Ray
From: Chao Li
Sent: Friday, April 12, 2024 15:34
To: devel@edk2.groups.io
Cc: Ni, Ray ; Kumar, Rahul R ; Gerd
Hoffmann
Subject: [PATCH v3 08/13] UefiCpuPkg: Added a new PCD named
PcdLoongArchExceptionVectorBaseAddress
Added
Reviewed-by: Ray Ni
Thanks,
Ray
From: Chao Li
Sent: Friday, April 12, 2024 15:34
To: devel@edk2.groups.io
Cc: Ni, Ray ; Kumar, Rahul R ; Gerd
Hoffmann ; Leif Lindholm ; Ard
Biesheuvel ; Sami Mujawar ;
Sunil V L ; Warkentin, Andrei
Subject: [PATCH v3 07/13]
+
+typedef struct {
+ UINT32NumberOfProcessor;
+ UINTN *ApicId;
[Ray] How about "UINTN ApicId[]"? The difference between the two is your
version contains an 8-byte pointer pointing to somewhere else. My version
implies the APIC ID array is just after "NumberOfProcessor".
Hi Mike,
I have submitted PATCH v3, which updated the Readme.rst for libspdm submodule
license. And I have added Leif.
Please review the PATCH v3.
For your second feedback, I have investigate the situation.
If we use 'git submodule update --init' to clone the submodule, the
libspdm is submodule, which will be used in DeviceSecurity.
Cc: Andrew Fish
Cc: Michael D Kinney
Cc: Michael D Kinney
Cc: Jiewen Yao
Signed-off-by: Wenxing Hou
---
.gitmodules| 3 +++
SecurityPkg/DeviceSecurity/SpdmLib/libspdm | 1 +
2 files changed, 4
This patch add libspdm submodule license.
Cc: Andrew Fish
Cc: Leif Lindholm
Cc: Michael D Kinney
Signed-off-by: Wenxing Hou
---
ReadMe.rst | 1 +
1 file changed, 1 insertion(+)
diff --git a/ReadMe.rst b/ReadMe.rst
index 808ccd37af..cfd522fdbd 100644
--- a/ReadMe.rst
+++ b/ReadMe.rst
@@
libspdm is submodule to support DeviceSecurity feature.
Cc: Jiewen Yao
Signed-off-by: Wenxing Hou
---
SecurityPkg/DeviceSecurity/SpdmLib/libspdm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/SecurityPkg/DeviceSecurity/SpdmLib/libspdm
Add new api Tpm2ExtendNvIndex.
It is uesd in HashCompleteAndExtend when PcrIndex > MAX_PCR_INDEX.
Cc: Jiewen Yao
Cc: Rahul Kumar
Signed-off-by: Wenxing Hou
---
SecurityPkg/Include/Library/Tpm2CommandLib.h | 23 +++-
.../HashLibBaseCryptoRouterDxe.c | 88 +++--
Add DeviceSecurity submodule libspdm.
Cc: Sean Brogan
Cc: Joey Vagedes
Cc: Michael D Kinney
Cc: Liming Gao
Signed-off-by: Wenxing Hou
Reviewed-by: Joey Vagedes
---
.pytool/CISettings.py | 2 ++
1 file changed, 2 insertions(+)
diff --git a/.pytool/CISettings.py b/.pytool/CISettings.py
According to UEFI 2.10 spec 3.3 Globally Defined Variables section,
add devAuthBoot GlobalVariable.
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhiguang Liu
Cc: Jiewen Yao
Signed-off-by: Wenxing Hou
Reviewed-by: Liming Gao
---
MdePkg/Include/Guid/GlobalVariable.h | 8 +++-
Add support for
TCG PC Client Platform Firmware Profile Specification 1.06.
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhiguang Liu
Cc: Jiewen Yao
Signed-off-by: Wenxing Hou
---
MdePkg/Include/IndustryStandard/Spdm.h| 4 +-
.../IndustryStandard/UefiTcgPlatform.h| 186
Add EV_EFI_SPDM_DEVICE_POLICY support for MeasureVariable.
Cc: Liming Gao
Cc: Jiewen Yao
Signed-off-by: Wenxing Hou
---
MdeModulePkg/MdeModulePkg.dec | 5 +++
.../Variable/RuntimeDxe/Measurement.c | 38 ---
.../RuntimeDxe/VariableRuntimeDxe.inf
Update Spdm.h to support 1.2 new features, such as:
Authentication and measurement. It wil be used in DeviceSecurity.
The DeviceSecurity feature is from
TCG PC Client Platform Firmware Profile Specification 1.06.
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhiguang Liu
Cc: Jiewen Yao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2479
In PFP spec 1.06, platform firmware records the device certificate and device
measurement for each SPDM responder.
This PATCH set implement the DeviceSecurityLib to support spdm device
Authentication and Measurement.
Libspdm as submodule
On Thursday, April 11, 2024 4:13 PM, Gerd Hoffmann wrote:
>
> On my end the state of affairs is unchanged. Our builds have the patch
> included and there are zero problems so far, the issue reported by Min
> doesn't reproduce and it is still unclear what is going on.
>
> Min, any update?
>
Hi,
*Reminder: Tools, CI, Code base construction meeting series*
*When:*
Monday, April 15, 2024
4:30pm to 5:30pm
(UTC-07:00) America/Los Angeles
*Where:*
From: Jason Lou
The patch adds new ProcessorUpgrade definitions for SMBIOS Type4 based
on SMBIOS 3.8.0.
Signed-off-by: Jason Lou
Cc: Zhiguang Liu
Cc: Dandan Bi
Cc: Star Zeng
Cc: Zhichao Gao
Cc: Benny Lin
Cc: Gua Guo
Cc: Michael D Kinney
Cc: Liming Gao
---
From: Jason Lou
The patch updates SmbiosView to support new ProcessorUpgrade for SMBIOS
Type4 based on SMBIOS 3.8.0.
Signed-off-by: Jason Lou
Cc: Liming Gao
Cc: Star Zeng
Cc: Zhichao Gao
---
ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c | 30
+++-
1
Hi Taylor,
For your mentioned: "In this case, because the memory type of the buffer is
EfiRuntimeServicesCode, shouldn't the final pages be EFI_MEMORY_RO?"
After print the attributes, the attribute are not set to EFI_MEMORY_RO, nearly
all of the NewRecord->Attribute are set to 0 in SplitRecord
32 matches
Mail list logo
