Re: [edk2-devel] [PATCH 1/1] MdeModulePkg: Load Serial driver in early DXE

2024-05-09 Thread Ni, Ray
Mike did not recommend the approach used by the patch. Your patch exposes a new pattern that's anti-driver-model, IMO. If you want to avoid code duplication, solve that problem in a way that does not introduce such a pattern. Please be aware that any one piece of code introduced in edk2, could

Re: [edk2-devel] [PATCH v1 02/14] EmulatorPkg: : Add Hash2DxeCrypto to EmulatorPkg

2024-05-09 Thread Ni, Ray
Reviewed-by: Ray Ni Thanks, Ray From: Doug Flick Sent: Wednesday, May 8, 2024 23:29 To: devel@edk2.groups.io Cc: Andrew Fish ; Ni, Ray Subject: [PATCH v1 02/14] EmulatorPkg: : Add Hash2DxeCrypto to EmulatorPkg From: Doug Flick This patch adds

Re: [edk2-devel] [PATCH v2 01/13] EmulatorPkg: : Add RngDxe to EmulatorPkg

2024-05-09 Thread Ni, Ray
Reviewed-by: Ray Ni Thanks, Ray From: devel@edk2.groups.io on behalf of Doug Flick via groups.io Sent: Thursday, May 9, 2024 13:56 To: devel@edk2.groups.io Cc: Andrew Fish ; Ni, Ray Subject: [edk2-devel] [PATCH v2 01/13] EmulatorPkg: : Add RngDxe to

Re: [edk2-devel] edk2-test Release candidate 2: edk2-test-rc2_202405 // RE: [PATCH v2 0/4] TCG2 protocol clean up

2024-05-09 Thread Chao Li
Hi Edhay, Do I need to retest based on the edk2-test-rc2_202405 tag? Thanks, Chao On 2024/5/10 10:43, G Edhaya Chandran wrote: Thank you, David. The results are well received. With Warm Regards, Edhay *From:*David Wright *Sent:* Thursday, May 9, 2024 3:23 PM *To:* G Edhaya Chandran ;

Re: [edk2-devel] [PATCH] MdeModulePkg: Update GCD attribute conversion to support SP attribute

2024-05-09 Thread Ni, Ray
Reviewed-by: Ray Ni Thanks, Ray From: Lin, Du Sent: Thursday, May 9, 2024 12:04 To: devel@edk2.groups.io Cc: Lin, Du ; Liming Gao ; Ni, Ray Subject: [PATCH] MdeModulePkg: Update GCD attribute conversion to support SP attribute Add a new entry into GCD

Re: [edk2-devel] edk2-test Release candidate 2: edk2-test-rc2_202405 // RE: [PATCH v2 0/4] TCG2 protocol clean up

2024-05-09 Thread G Edhaya Chandran
Thank you, David. The results are well received. With Warm Regards, Edhay From: David Wright Sent: Thursday, May 9, 2024 3:23 PM To: G Edhaya Chandran ; Heinrich Schuchardt Cc: Alex Fox ; lic...@loongson.cn; Stuart Yoder ; devel@edk2.groups.io; gao...@byosoft.com.cn Subject: RE: edk2-test

[edk2-devel] [PATCH v1 0/1] MinPlatformPkg: Fix DxePhatAcpiLib.inf path

2024-05-09 Thread VivianNK
REF: https://github.com/VivianNK/edk2-platforms/tree/remove_unused_inf Bug fix. When building MinPlatformPkg, a build error occured because the inf was not found. The path was incorrect -- DxePhatAcpiLib folder doesn't exist, PhatAcpiLib does. Cc: Chasel Chiu Cc: Nate DeSimone Signed-off-by:

[edk2-devel] [PATCH v1 1/1] MinPlatformPkg: Fix DxePhatAcpiLib.inf path in dsc

2024-05-09 Thread VivianNK
When building MinPlatformPkg, a build error occured because the inf was not found. The path was incorrect -- DxePhatAcpiLib folder doesn't exist, PhatAcpiLib does. Cc: Chasel Chiu Cc: Nate DeSimone Signed-off-by: Vivian Nowka-Keane --- Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc | 4 ++--

Re: [edk2-devel] [edk2-platforms] [PATCH v1 1/2] MinPlatform: Add MpInfo2HobPei

2024-05-09 Thread Chaganty, Rangasai V
Hi Nate, Looks good. In addition to optimization suggested by Chasel to save unnecessary call to locate PPI, you might also want to consider checking for checking "no error" status for locate PPI and perhaps avoid a "goto" label. With that, Reviewed-by: Sai Chaganty for the whole patch

回复: [edk2-devel] [PATCH v2 03/13] OvmfPkg:PlatformCI: Support virtio-rng-pci

2024-05-09 Thread gaoliming via groups.io
Doug: From the compatibility point, may PcdEnforceSecureRngAlgorithms default value be set to FALSE? Thanks Liming 发件人: devel@edk2.groups.io 代表 Doug Flick via groups.io 发送时间: 2024年5月10日 2:21 收件人: Ard Biesheuvel ; devel@edk2.groups.io 主题: Re: [edk2-devel] [PATCH v2 03/13]

回复: [edk2-devel] [PATCH v7 0/5] Adding support for veborse UEFI Table dumping to Dmem.c

2024-05-09 Thread gaoliming via groups.io
Sam: Please help create PR. Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Sam Kaynor > 发送时间: 2024年5月10日 4:51 > 收件人: gaoliming ; devel@edk2.groups.io > 抄送: 'Ray Ni' ; 'Zhichao Gao' ; > 'Michael D Kinney' ; 'Zhiguang Liu' > ; Stuart Yoder > 主题: Re: [edk2-devel] [PATCH v7 0/5]

回复: [edk2-devel] 回复: [PATCH v4 1/1] MdePkg: Added new SPCR table Revision 4 structure

2024-05-09 Thread gaoliming via groups.io
It has been merged. Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Praveen Sankar > N via groups.io > 发送时间: 2024年5月9日 14:33 > 收件人: gaoliming ; devel@edk2.groups.io > 抄送: Srinivasan Mani ; Sundaresan S > ; michael.d.kin...@intel.com; zhiguang@intel.com; > Felix Polyudov ;

Re: [edk2-devel] 回复: [PATCH v4 1/1] MdePkg: Added new SPCR table Revision 4 structure

2024-05-09 Thread Praveen Sankar N via groups.io
Hi Liming, Pull request is done and pipelines are built successfully and the patch is ready to push to the master. Thanks, Praveen Sankar -Original Message- From: gaoliming Sent: Monday, May 6, 2024 7:53 AM To: Praveen Sankar N ; devel@edk2.groups.io Cc: Srinivasan Mani ;

Re: [edk2-devel] edk2-test Release candidate 2: edk2-test-rc2_202405 // RE: [PATCH v2 0/4] TCG2 protocol clean up

2024-05-09 Thread David Wright
Hi all, Phoenix has completed testing on edk2-test-rc2_202405 Results have been uploaded to their respective folders. [cid:image001.png@01DAA213.C980F100] Thanks, David Wright QA Team Leader david_wri...@phoenix.com 503-730-4537 Tel

Re: [edk2-devel] 回复: [PATCH v4 1/1] MdePkg: Added new SPCR table Revision 4 structure

2024-05-09 Thread Praveen Sankar N via groups.io
Liming, Please refer the below link for reference to view the pipelines results. https://github.com/tianocore/edk2/pull/5641 Thanks, Praveen Sankar -Original Message- From: Praveen Sankar N Sent: Thursday, May 9, 2024 12:03 PM To: 'gaoliming' ; devel@edk2.groups.io Cc: Srinivasan Mani ;

Re: [edk2-devel] [edk2-platforms] [PATCH v1 1/2] MinPlatform: Add MpInfo2HobPei

2024-05-09 Thread Chiu, Chasel
Hi Nate, Change looks good. Reviewed-by: Chasel Chiu Just one minor optimization you might consider in below inline when merging this patch series. Thanks, Chasel > -Original Message- > From: Desimone, Nathaniel L > Sent: Wednesday, May 8, 2024 5:09 PM > To: devel@edk2.groups.io

Re: [edk2-devel][edk2-stable202405] [PATCH v3 00/11] Add more crypt APIs based on Mbedtls

2024-05-09 Thread Wenxing Hou
Hi all, Do you have any feedback? The current Patch Set status is: This patch set was submitted before soft feature freeze. Some reviewd-by was added before soft feature freeze starts. Some reviewd-by was added after soft feature freeze starts. And the Patch set

Re: [edk2-devel] [PATCH v7 0/5] Adding support for veborse UEFI Table dumping to Dmem.c

2024-05-09 Thread Sam Kaynor
Liming, I have not made a Pull Request for this patch set, should I make one? Thanks, Sam -Original Message- From: gaoliming Sent: Sunday, May 5, 2024 9:49 PM To: Sam Kaynor ; devel@edk2.groups.io Cc: 'Ray Ni' ; 'Zhichao Gao' ; 'Michael D Kinney' ; 'Zhiguang Liu' ; Stuart Yoder

Re: [edk2-devel] [PATCH v1] MinPlatformPkg/Test: Fix DumpAcpiMadt infinite loop

2024-05-09 Thread Nate DeSimone
Pushed as 3f89df4 > -Original Message- > From: Abdul Lateef Attar > Sent: Monday, April 22, 2024 7:04 AM > To: devel@edk2.groups.io > Cc: Abdul Lateef Attar ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Liming Gao ; > Dong, Eric > Subject: [PATCH v1] MinPlatformPkg/Test: Fix DumpAcpiMadt

Re: [edk2-devel] [PATCH v1] MinPlatformPkg/Test: Fix DumpAcpiMadt infinite loop

2024-05-09 Thread Nate DeSimone
Reviewed-by: Nate DeSimone > -Original Message- > From: Abdul Lateef Attar > Sent: Monday, April 22, 2024 7:04 AM > To: devel@edk2.groups.io > Cc: Abdul Lateef Attar ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Liming Gao ; > Dong, Eric > Subject: [PATCH v1] MinPlatformPkg/Test: Fix

Re: [edk2-devel] 回复: [edk2-devel][edk2-stable202405] [PATCH v2 00/13] NetworkPkg: CVE-2023-45236 and CVE-2023-45237

2024-05-09 Thread Doug Flick via groups.io
>From the two CVE patches there should be no functional differences to a >platform assuming the platform provides them with a RNG implementation and >HASH2 implementation. The "NetworkPkg:: SECURITY PATCH CVE-2023-45237" change simply get's it's random numbers from outside of the NetworkPkg

Re: [edk2-devel] [PATCH v2 03/13] OvmfPkg:PlatformCI: Support virtio-rng-pci

2024-05-09 Thread Doug Flick via groups.io
> > So this patch is necessary as otherwise, QEMU fails to boot due to a > missing source of randomness in the network drivers, right? > So I added this based on your initial suggestion to get the ArmVirtPkg working - running it locally (and against the pipelines) shows this isn't necessary. So

Re: 回复: 回复: [edk2-devel] [edk2-stable202405 RESEND PATCH v2 1/1] DynamicTablesPkg: Adds integer to the AML package node

2024-05-09 Thread Abdul Lateef Attar via groups.io
Thanks Sami and Liming for quick response and creating the PR. PR looks good : https://github.com/tianocore/edk2/pull/5647/ Thanks AbduL On 09-05-2024 18:06, gaoliming wrote: Caution: This message originated from an External Source. Use proper caution when opening attachments,

Re: [edk2-devel] [edk2-redfish-client][PATCH] Tool/Redfish-Profile-Simulator: fix Werkzeug security issue

2024-05-09 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Reviewed-by: Abner Chang > -Original Message- > From: Nickle Wang > Sent: Wednesday, May 8, 2024 4:09 PM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Igor Kulchytskyy > ; Nick Ramirez > Subject: [edk2-redfish-client][PATCH]

回复: 回复: [edk2-devel] [edk2-stable202405 RESEND PATCH v2 1/1] DynamicTablesPkg: Adds integer to the AML package node

2024-05-09 Thread gaoliming via groups.io
Sami: Thanks for your update. I agree Pierre reviewed this patch before the soft feature freeze. So, this patch can be merged for this stable tag 202405. Thanks Liming 发件人: devel@edk2.groups.io 代表 Sami Mujawar 发送时间: 2024年5月9日 18:18 收件人: devel@edk2.groups.io; gaolim...@byosoft.com.cn;

回复: [edk2-devel][edk2-stable202405] [PATCH v3 00/11] Add more crypt APIs based on Mbedtls

2024-05-09 Thread gaoliming via groups.io
Include more people for feedback. > -邮件原件- > 发件人: Hou, Wenxing > 发送时间: 2024年5月9日 17:35 > 收件人: devel@edk2.groups.io; gaolim...@byosoft.com.cn; Li, Yi1 > > 抄送: Yao, Jiewen > 主题: RE: [edk2-devel] [PATCH v3 00/11] Add more crypt APIs based on Mbedtls > > Hi Liming, > Thanks for your

Re: 回复: [edk2-devel] [edk2-stable202405 RESEND PATCH v2 1/1] DynamicTablesPkg: Adds integer to the AML package node

2024-05-09 Thread Sami Mujawar
Hi Liming, If the decision is to merge this patch, I have created a pull request at https://github.com/tianocore/edk2/pull/5647 Regards, Sami Mujawar From: on behalf of "Sami Mujawar via groups.io" Reply to: "devel@edk2.groups.io" , Sami Mujawar Date: Thursday 9 May 2024 at 11:18 To:

Re: 回复: [edk2-devel] [edk2-stable202405 RESEND PATCH v2 1/1] DynamicTablesPkg: Adds integer to the AML package node

2024-05-09 Thread Sami Mujawar
Hi Liming, > What’s your comments for this patch? The patch was reviewed by Pierre at https://edk2.groups.io/g/devel/message/118589 before the feature freeze email was sent out. Pierre had some minor recommendations that Abdul has addressed in the V2 patch. Ideally Pierre’s the r-b tag could

回复: [edk2-devel][edk2-stable202405] [PATCH v2 00/13] NetworkPkg: CVE-2023-45236 and CVE-2023-45237

2024-05-09 Thread gaoliming via groups.io
Doug: Is there any functionality impact by these two CVE fixes? Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Doug Flick via > groups.io > 发送时间: 2024年5月9日 13:56 > 收件人: devel@edk2.groups.io > 抄送: Liming Gao > 主题: [edk2-devel] [PATCH v2 00/13] NetworkPkg: CVE-2023-45236 and >

Re: [edk2-devel] [PATCH v3 00/11] Add more crypt APIs based on Mbedtls

2024-05-09 Thread Wenxing Hou
Hi Liming, Thanks for your suggestion. Hi all, The current Patch Set status is: This patch set was submitted before soft feature freeze. It passed code review after soft feature freeze starts. And the Patch set is: Acked-by: Jiewen Yao

回复: 回复:[Internet]Re: [edk2-devel] [PATCH] Added support for ACPI related data structures for RISC_V64 platform

2024-05-09 Thread gaoliming via groups.io
MdePkg includes the definitions from the public specification. Those definitions are the implement related definition. So, they should be added into RISC-V platform package instead of MdePkg. Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Sunil V L > 发送时间: 2024年5月9日 16:36 >

回复: [edk2-devel] [edk2-stable202405 RESEND PATCH v2 1/1] DynamicTablesPkg: Adds integer to the AML package node

2024-05-09 Thread gaoliming via groups.io
Sami and Pierre: What’s your comments for this patch? Is this a required bug fix or new feature? Thanks Liming 发件人: Attar, AbdulLateef (Abdul Lateef) 发送时间: 2024年5月9日 16:39 收件人: gaoliming ; devel@edk2.groups.io 抄送: 'Pierre Gondois' ; 'Sami Mujawar' 主题: Re: [edk2-devel]

回复: [edk2-devel] [PATCH v3 00/11] Add more crypt APIs based on Mbedtls

2024-05-09 Thread gaoliming via groups.io
Seemly, this change is new feature to add more crypt APIs based on Mbedtls. This patch set was submitted before soft feature freeze. But, it passed code review after soft feature freeze starts. Based on current rule, this patch set is not allowed to be merged for this stable tag 202405. If

Re: [edk2-devel] [PATCH v3 00/11] Add more crypt APIs based on Mbedtls

2024-05-09 Thread Yao, Jiewen
Acked-by: Jiewen Yao > -Original Message- > From: Li, Yi1 > Sent: Thursday, May 9, 2024 4:33 PM > To: Hou, Wenxing ; gaoliming > ; devel@edk2.groups.io > Cc: Yao, Jiewen > Subject: RE: [PATCH v3 00/11] Add more crypt APIs based on Mbedtls > > This patch set was submitted before soft

Re: [edk2-devel] [PATCH v2 03/13] OvmfPkg:PlatformCI: Support virtio-rng-pci

2024-05-09 Thread Ard Biesheuvel
Apologies, I meant this as a reply to the ArmVirtPkg change, not the OVMF one. On Thu, 9 May 2024 at 10:45, Ard Biesheuvel wrote: > > So this patch is necessary as otherwise, QEMU fails to boot due to a > missing source of randomness in the network drivers, right? > > Does this imply that all

Re: [edk2-devel] [PATCH v2 03/13] OvmfPkg:PlatformCI: Support virtio-rng-pci

2024-05-09 Thread Ard Biesheuvel
So this patch is necessary as otherwise, QEMU fails to boot due to a missing source of randomness in the network drivers, right? Does this imply that all QEMU deployments that rely on the bundled firmware images (e.g., for micro-VMs and container use cases) will now fail to boot if the

Re: [edk2-devel] [edk2-stable202405 RESEND PATCH v2 1/1] DynamicTablesPkg: Adds integer to the AML package node

2024-05-09 Thread Abdul Lateef Attar via groups.io
[AMD Official Use Only - General] Hi Liming, This patch provides an API to add integer value to AML package node. Using this API user can create CXL device with two PNPID. Without this API user has to rely on static ASL files. This patch is required for platform who uses DynamicTablesPkg to

Re: 回复:[Internet]Re: [edk2-devel] [PATCH] Added support for ACPI related data structures for RISC_V64 platform

2024-05-09 Thread Sunil V L
On Mon, May 06, 2024 at 10:54:45AM +0800, dylanlhdu(杜林恒) wrote: > Hi Sunil, > > > > We mainly want to use UEFI+ACPI mode to start RISCV64 server. However, during > the development process, we found that ACPI(6.5) in the current version of > UEFI does not support riscv for the time being. In

Re: [edk2-devel] [PATCH v3 00/11] Add more crypt APIs based on Mbedtls

2024-05-09 Thread Li, Yi
This patch set was submitted before soft freeze and will not affect other existed codes, I am OK to merge it. Hi Liming, Do you have any comments? I will merge it if no objections. Thanks, Yi -Original Message- From: Hou, Wenxing Sent: Thursday, May 9, 2024 4:29 PM To: Li, Yi1 ;

Re: [edk2-devel] [PATCH v3 00/11] Add more crypt APIs based on Mbedtls

2024-05-09 Thread Wenxing Hou
Hi, Thanks for your feedback. The new PR is: https://github.com/tianocore/edk2/pull/5645 Could Li Yi help me merge the PR? Thanks, Wenxing -Original Message- From: Li, Yi1 Sent: Thursday, May 9, 2024 2:54 PM To: Hou, Wenxing ; devel@edk2.groups.io Cc: Yao, Jiewen Subject: RE: [PATCH

Re: [edk2-devel] [PATCH v4 00/14] Add SmmRelocationLib

2024-05-09 Thread Ard Biesheuvel
Thanks Liming. On Thu, 9 May 2024 at 09:36, gaoliming via groups.io wrote: > > Ard: > Gerd is the reviewer of OvmfPkg. He gave Acked-by before soft feature > freeze. So, this patch set can be merged for this stable tag 202405. > > And, this patch set has been merged. > > Thanks > Liming > >

回复: [edk2-devel] [edk2-stable202405 RESEND PATCH v2 1/1] DynamicTablesPkg: Adds integer to the AML package node

2024-05-09 Thread gaoliming via groups.io
Abdul: Can you give more information why this change is required for this stable tag 202405? Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Abdul Lateef > Attar via groups.io > 发送时间: 2024年5月9日 12:49 > 收件人: devel@edk2.groups.io > 抄送: Abdul Lateef Attar ; Pierre Gondois > ; Sami

回复: [edk2-devel] [PATCH v4 00/14] Add SmmRelocationLib

2024-05-09 Thread gaoliming via groups.io
Ard: Gerd is the reviewer of OvmfPkg. He gave Acked-by before soft feature freeze. So, this patch set can be merged for this stable tag 202405. And, this patch set has been merged. Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Ard Biesheuvel > 发送时间: 2024年5月9日 0:44 > 收件人:

回复: [edk2-devel][edk2-stable202405][PATCH] MdeModulePkg: Potential UINT32 overflow in S3 ResumeCount

2024-05-09 Thread gaoliming via groups.io
Reviewed-by: Liming Gao This is a security fix. So, I think it should catch this stable tag 202405 Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Pakkirisamy > ShanmugavelX > 发送时间: 2024年5月6日 17:53 > 收件人: devel@edk2.groups.io > 抄送: Shanmugavel Pakkirisamy ; > Zhiguang Liu ;

回复: [edk2-devel] pr for stable tag

2024-05-09 Thread gaoliming via groups.io
Ard: I am OK to merge this regression bug fix for stable tag 202405. If no other comments, I will merge it. Thanks Liming > -邮件原件- > 发件人: Ard Biesheuvel > 发送时间: 2024年5月9日 0:15 > 收件人: devel@edk2.groups.io; gaolim...@byosoft.com.cn > 抄送: Michael Kinney ; Leif Lindholm > ; Peter Batard

Re: [edk2-devel] [PATCH v3 00/11] Add more crypt APIs based on Mbedtls

2024-05-09 Thread Li, Yi
For this patch set: Looks good to me. Reviewed-by: Yi Li -Original Message- From: Hou, Wenxing Sent: Thursday, May 9, 2024 2:27 PM To: devel@edk2.groups.io Cc: Yao, Jiewen ; Li, Yi1 Subject: [PATCH v3 00/11] Add more crypt APIs based on Mbedtls REF:

[edk2-devel] [PATCH v3 11/11] Add SHA3/SM3 functions with openssl for Mbedtls

2024-05-09 Thread Wenxing Hou
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4177 Because the Mbedlts 3.3.0 doesn't have SHA3 and Sm3, the SHA3 and Sm3 implementaion based on Openssl. Cc: Jiewen Yao Cc: Yi Li Signed-off-by: Wenxing Hou --- .../Library/BaseCryptLibMbedTls/BaseCryptLib.inf | 11 +++

[edk2-devel] [PATCH v3 07/11] CryptoPkg: Add more RSA related functions based on Mbedtls

2024-05-09 Thread Wenxing Hou
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4177 Implement more RSA functions such as RsaPkcs1Sign based Mbedlts. Cc: Jiewen Yao Cc: Yi Li Signed-off-by: Wenxing Hou --- .../BaseCryptLibMbedTls/Pk/CryptPkcs1Oaep.c | 278 ++ .../BaseCryptLibMbedTls/Pk/CryptRsaExt.c

[edk2-devel] [PATCH v3 10/11] CryptoPkg: Update *.inf in BaseCryptLibMbedTls

2024-05-09 Thread Wenxing Hou
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4177 Update all *.inf in BaseCryptLibMbedTls based on new implementation. Cc: Jiewen Yao Cc: Yi Li Signed-off-by: Wenxing Hou --- .../BaseCryptLibMbedTls/BaseCryptLib.inf | 42 ++-

[edk2-devel] [PATCH v3 09/11] CryptoPkg: Add ImageTimestampVerify based on Mbedtls

2024-05-09 Thread Wenxing Hou
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4177 Timestamp Countersignature Verification implementaion based on Mbedtls. Cc: Jiewen Yao Cc: Yi Li Signed-off-by: Wenxing Hou --- .../Library/BaseCryptLibMbedTls/Pk/CryptTs.c | 381 ++ 1 file changed, 381 insertions(+)

[edk2-devel] [PATCH v3 08/11] CryptoPkg: Add AuthenticodeVerify based on Mbedtls

2024-05-09 Thread Wenxing Hou
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4177 Implement AuthenticodeVerify based on Mbedtls. Cc: Jiewen Yao Cc: Yi Li Signed-off-by: Wenxing Hou --- .../Pk/CryptAuthenticode.c| 214 ++ 1 file changed, 214 insertions(+) create mode 100644

[edk2-devel] [PATCH v3 04/11] CryptoPkg: Add X509 functions based on Mbedtls

2024-05-09 Thread Wenxing Hou
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4177 X.509 Certificate Handler Wrapper Implementation over MbedTLS. Cc: Jiewen Yao Cc: Yi Li Signed-off-by: Wenxing Hou --- .../BaseCryptLibMbedTls/Pk/CryptX509.c| 1940 + 1 file changed, 1940 insertions(+) create

[edk2-devel] [PATCH v3 06/11] CryptoPkg: Add Pkcs5 functions based on Mbedtls

2024-05-09 Thread Wenxing Hou
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4177 PBKDF2 Key Derivation Function Wrapper Implementation over MbedTLS. Cc: Jiewen Yao Cc: Yi Li Signed-off-by: Wenxing Hou --- .../BaseCryptLibMbedTls/Pk/CryptPkcs5Pbkdf2.c | 100 ++ 1 file changed, 100 insertions(+)

[edk2-devel] [PATCH v3 05/11] CryptoPkg: Add Pkcs7 related functions based on Mbedtls

2024-05-09 Thread Wenxing Hou
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4177 Because the current Mbedlts pkcs7 library doesn't support authenticatedAttributes: Mbed-TLS/mbedtls@bb82ab7 and only support 0 or 1 certificates in Signed data: tianocore/edk2-staging@9c5b26b The patch implement Pkcs7 by low Mbedtls Api.

[edk2-devel] [PATCH v3 03/11] CryptoPkg: Add Pem APIs based on Mbedtls

2024-05-09 Thread Wenxing Hou
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4177 Implement Pem API based on Mbedtls. Cc: Jiewen Yao Cc: Yi Li Signed-off-by: Wenxing Hou --- .../BaseCryptLibMbedTls/Pem/CryptPem.c| 138 ++ 1 file changed, 138 insertions(+) create mode 100644

[edk2-devel] [PATCH v3 02/11] CryptoPkg: Add rand function for BaseCryptLibMbedTls

2024-05-09 Thread Wenxing Hou
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4177 Add rand function for BaseCryptLibMbedTls. Cc: Jiewen Yao Cc: Yi Li Signed-off-by: Wenxing Hou --- CryptoPkg/Include/Library/BaseCryptLib.h | 2 + .../BaseCryptLibMbedTls/InternalCryptLib.h| 16 +++

[edk2-devel] [PATCH v3 01/11] CryptoPkg: Add AeadAesGcm based on Mbedtls

2024-05-09 Thread Wenxing Hou
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4177 AeadAesGcm implementation based on Mbedtls. Cc: Jiewen Yao Cc: Yi Li Signed-off-by: Wenxing Hou --- .../Cipher/CryptAeadAesGcm.c | 227 ++ 1 file changed, 227 insertions(+) create mode 100644

[edk2-devel] [PATCH v3 00/11] Add more crypt APIs based on Mbedtls

2024-05-09 Thread Wenxing Hou
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4177 Add AeadAesGcm/Pem(only RSA)/X509(only RSA)/More RSA/PKCS5/pKCS7/Authenticode/Timestamp implementation based on Mbedtls. The patch has passed the EDKII CI check: https://github.com/tianocore/edk2/pull/5552 And the patch has passed

Re: [edk2-devel] [PATCH RESEND edk2-platforms][PATCH V2 12/14] Platform/ARM: Add CadenceQspiNorFlashDeviceLib for NorFlashDxe

2024-05-09 Thread sahil
Hi Pierre, Thanks for reviewing the patchset. Please find my comment inline below. On Thu, 2 May 2024 at 18:47, PierreGondois via groups.io wrote: > > Hello Sahil, > > On 4/23/24 07:56, Sahil Kaushal via groups.io wrote: > > From: sahil > > > > In N1Sdp platform, the SoC is connected to IOFPGA