[edk2-devel] [PATCH v8] IntelFsp2Pkg: Support Multi-Phase SiInit and debug handlers.

2020-05-13 Thread Chiu, Chasel
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2698 To enhance FSP silicon initialization flexibility an optional Multi-Phase API is introduced and FSP header needs update for new API offset. Also new SecCore module created for FspMultiPhaseSiInit API New ARCH_UPD introduced for enhancing

Re: [edk2-devel] [PATCH] IntelSiliconPkg/Include/Library:Add ConfigBlockLib.h

2020-03-16 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Chen, TinaX Y > Sent: Monday, March 16, 2020 10:41 PM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Chaganty, Rangasai V > ; Chiu, Chasel ; > Tsao, Ethan > Subject: [PATCH] IntelSiliconPkg/Include/Libr

Re: [edk2-devel] [edk2-platforms:PATCH] CoffeelakeSiliconPkg:Redirect ConfigBlockLib path

2020-03-17 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: devel@edk2.groups.io On Behalf Of TinaX Y > Chen > Sent: Tuesday, March 17, 2020 11:02 AM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Chaganty, Rangasai V > ; Chiu, Chasel ; > Tsao, Ethan >

Re: [edk2-devel] [PATCH] IntelSiliconPkg/Include/Library:Add ConfigBlockLib.h

2020-03-16 Thread Chiu, Chasel
Sorry Tina, the commit message and code review subject format were wrong, please refer to other edk2-platform patches and re-send again. Thanks, Chasel > -Original Message- > From: Chiu, Chasel > Sent: Tuesday, March 17, 2020 8:08 AM > To: Chen, TinaX Y ; devel@edk2.gr

[edk2-devel] [edk2-platforms: PATCH v4] IntelFsp2Pkg: Support Multi-Phase SiInit and debug handlers.

2020-05-07 Thread Chiu, Chasel
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2698 To enhance FSP silicon initialization flexibility an optional Multi-Phase API is introduced and FSP header needs update for new API offset. Also new SecCore module created for FspMultiPhaseSiInit API New ARCH_UPD introduced for enhancing

Re: [edk2-devel] Patch List for 202005 stable tag

2020-05-20 Thread Chiu, Chasel
Hi Liming, I would like to include https://edk2.groups.io/g/devel/message/59921 to 202005 stable tag. We missed something in previous FSP enhancement commit (https://edk2.groups.io/g/devel/message/59438) and this patch fixed the bug. Thanks, Chasel From: devel@edk2.groups.io On Behalf Of

Re: [edk2-devel] [PATCH] IntelFsp2Pkg: Add FunctionParametePtr to FspGlobalData.

2020-05-20 Thread Chiu, Chasel
Change pushed: 3f89db869028fa65a37756fd7f391cbd69f4579c Thanks, Chasel > -Original Message- > From: devel@edk2.groups.io On Behalf Of Chiu, > Chasel > Sent: Wednesday, May 20, 2020 11:34 AM > To: devel@edk2.groups.io > Cc: Ma, Maurice ; Desimone, Nathaniel L > ;

Re: [edk2-devel] [Patch V1 1/1] Maintainers.txt: Update CometlakeOpenBoardPkg maintainer

2020-05-19 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: devel@edk2.groups.io On Behalf Of > Kathappan Esakkithevar > Sent: Tuesday, May 12, 2020 11:45 PM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Kethi Red

[edk2-devel] [PATCH] IntelFsp2Pkg: Add FunctionParametePtr to FspGlobalData.

2020-05-19 Thread Chiu, Chasel
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2726 When FSP switching stack and calling bootloader functions, the function parameter in stack may not be accessible easily. We can store the function parameter pointer to FspGlobalData and retrieve it after stack switched. Also need to add

Re: [edk2-devel] [edk2-non-osi] [PATCH V1 0/2] Add CometlakeSiliconBinPkg

2020-09-02 Thread Chiu, Chasel
For this series, Reviewed-by: Chasel Chiu > -Original Message- > From: Desimone, Nathaniel L > Sent: Wednesday, September 2, 2020 3:11 PM > To: devel@edk2.groups.io > Cc: Esakkithevar, Kathappan ; Chaganty, > Rangasai V ; Chiu, Chasel > > Subject: [edk2-non

Re: [edk2-devel] [edk2-platforms] [PATCH V1] CometlakeOpenBoardPkg: Add usage of CometlakeSiliconBinPkg

2020-09-02 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Desimone, Nathaniel L > Sent: Wednesday, September 2, 2020 3:15 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Chaganty, Rangasai V > ; Kethi Reddy, Deepika > ; Esakkithevar, Kathappan > > Subject:

Re: [edk2-devel] [PATCH] IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec: add FspMeasurementLib.h

2020-08-30 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Zhang, Qi1 > Sent: Monday, August 31, 2020 10:07 AM > To: devel@edk2.groups.io > Cc: Zhang, Qi1 ; Chiu, Chasel ; > Desimone, Nathaniel L ; Liming Gao > ; Dong, Eric > Subject: [PATCH] IntelFsp2WrapperPkg

[edk2-devel] [PATCH] UefiCpuPkg/RegisterCpuFeaturesLib: Support MpServices2 only case.

2020-09-10 Thread Chiu, Chasel
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2883 MpServices Ppi can be replaced by MpServices2 Ppi and MpServices2 Ppi is mandatory for RegisterCpuFeaturesLib functionality, basing on this we can drop MpServices Ppi usage from the library and the constraint that both Ppis must be

Re: [edk2-devel] [PATCH 1/2] IntelFsp2WrapperPkg: remove gPeiTpmInitializationDonePpiGuid from Depex

2020-09-15 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Zhang, Qi1 > Sent: Tuesday, September 15, 2020 2:21 PM > To: devel@edk2.groups.io > Cc: Zhang, Qi1 ; Chiu, Chasel ; > Desimone, Nathaniel L ; Zeng, Star > ; Yao, Jiewen > Subject: [PATCH 1/2] Int

Re: [edk2-devel] [PATCH v2] UefiCpuPkg/RegisterCpuFeaturesLib: Support MpServices2 only case.

2020-09-14 Thread Chiu, Chasel
Change pushed: 1b461403ee723dab01d5828714cca0b9396a6b3c Thanks, Chasel > -Original Message- > From: Ni, Ray > Sent: Monday, September 14, 2020 11:46 AM > To: Chiu, Chasel ; devel@edk2.groups.io > Cc: Chiu, Chasel ; Dong, Eric ; > Laszlo Ersek ; Kumar, Rahul1 > ;

[edk2-devel] [PATCH v2] UefiCpuPkg/RegisterCpuFeaturesLib: Support MpServices2 only case.

2020-09-13 Thread Chiu, Chasel
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2883 MpServices Ppi can be replaced by MpServices2 Ppi and MpServices2 Ppi is mandatory for RegisterCpuFeaturesLib functionality, basing on this we can drop MpServices Ppi usage from the library and the constraint that both Ppis must be

Re: [edk2-devel] [PATCH] UefiCpuPkg/RegisterCpuFeaturesLib: Support MpServices2 only case.

2020-09-13 Thread Chiu, Chasel
Thanks Ray. This is good catch and it was no issue because both MpServices and MpServices2 at the same time. I will update INF. Thanks, Chasel From: Ni, Ray Sent: Saturday, September 12, 2020 2:37 AM To: Dong, Eric ; Chiu, Chasel ; devel@edk2.groups.io Cc: Chiu, Chasel ; Laszlo Ersek

Re: [edk2-devel] [PATCH v3 8/8] IntelFsp2WrapperPkg/dsc: add HashLib, Tpm2CommandLib and Tpm2DeviceLib

2020-08-17 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Zhang, Qi1 > Sent: Friday, August 14, 2020 2:32 PM > To: devel@edk2.groups.io > Cc: Zhang, Qi1 ; Yao, Jiewen ; > Chiu, Chasel ; Desimone, Nathaniel L > ; Zeng, Star > Subject: [PATCH v3 8/8] IntelFsp2Wra

Re: [edk2-devel] [PATCH v3 4/8] IntelFsp2WraperPkg/Fsp{m|s}WrapperPeim: Add FspBin measurement.

2020-08-17 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Zhang, Qi1 > Sent: Friday, August 14, 2020 2:32 PM > To: devel@edk2.groups.io > Cc: Yao, Jiewen ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Zeng, Star ; Zhang, > Qi1 > Subject: [PATCH v3 4/8]

Re: [edk2-devel] [PATCH v3 3/8] IntelFsp2WrapperPkg/FspMeasurementLib: Add BaseFspMeasurementLib.

2020-08-17 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Zhang, Qi1 > Sent: Friday, August 14, 2020 2:32 PM > To: devel@edk2.groups.io > Cc: Yao, Jiewen ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Zeng, Star ; Zhang, > Qi1 > Subject: [PATCH v3 3/8] IntelFsp2W

Re: [edk2-devel] [PATCH v4 3/8] IntelFsp2WrapperPkg/FspMeasurementLib: Add BaseFspMeasurementLib.

2020-08-18 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Zhang, Qi1 > Sent: Tuesday, August 18, 2020 2:26 PM > To: devel@edk2.groups.io > Cc: Yao, Jiewen ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Zeng, Star ; Zhang, > Qi1 > Subject: [PATCH

Re: [edk2-devel] [PATCH v4 6/8] IntelFsp2Wrapper/dsc: Add FspTpmMeasurementLib and PcdFspMeasurementConfig.

2020-08-18 Thread Chiu, Chasel
Copyright year of IntelFsp2WrapperPkg.dec can be extend to 2020 when pushing. Reviewed-by: Chasel Chiu > -Original Message- > From: Zhang, Qi1 > Sent: Tuesday, August 18, 2020 2:26 PM > To: devel@edk2.groups.io > Cc: Yao, Jiewen ; Chiu, Chasel > ; Desimone, Nathanie

Re: [edk2-devel] [PATCH v4 2/8] IntelFsp2WrapperPkg/FspMeasurementLib: Add header file.

2020-08-18 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Zhang, Qi1 > Sent: Tuesday, August 18, 2020 2:26 PM > To: devel@edk2.groups.io > Cc: Yao, Jiewen ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Zeng, Star ; Zhang, > Qi1 > Subject: [PATCH

Re: [edk2-devel] [PATCH v4 4/8] IntelFsp2WraperPkg/Fsp{m|s}WrapperPeim: Add FspBin measurement.

2020-08-18 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Zhang, Qi1 > Sent: Tuesday, August 18, 2020 2:26 PM > To: devel@edk2.groups.io > Cc: Yao, Jiewen ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Zeng, Star ; Zhang, > Qi1 > Subject: [PATCH v4 4/8]

Re: [edk2-devel] [PATCH v4 8/8] IntelFsp2WrapperPkg/dsc: add HashLib, Tpm2CommandLib and Tpm2DeviceLib

2020-08-18 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Zhang, Qi1 > Sent: Tuesday, August 18, 2020 2:26 PM > To: devel@edk2.groups.io > Cc: Zhang, Qi1 ; Yao, Jiewen ; > Chiu, Chasel ; Desimone, Nathaniel L > ; Zeng, Star > Subject: [PATCH v4 8/8] IntelFsp2Wra

Re: [edk2-devel] [PATCH 1/3] Platform/Intel/CometlakeOpenBoardPkg: add ibrary for Fsp measurement.

2020-08-28 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Zhang, Qi1 > Sent: Friday, August 28, 2020 2:33 PM > To: devel@edk2.groups.io > Cc: Zhang, Qi1 ; Chiu, Chasel ; > Desimone, Nathaniel L ; Chaganty, > Rangasai V ; Kethi Reddy, Deepika > ; Esakkithevar, Kathap

Re: [edk2-devel] [PATCH 3/3] Platform/Intel/WhiskeylakeOpenBoardPkg: add ibrary for Fsp measurement.

2020-08-28 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Zhang, Qi1 > Sent: Friday, August 28, 2020 2:33 PM > To: devel@edk2.groups.io > Cc: Zhang, Qi1 ; Chiu, Chasel ; > Desimone, Nathaniel L > Subject: [PATCH 3/3] Platform/Intel/WhiskeylakeOpenBoardPkg:

Re: [edk2-devel] [PATCH 2/3] Platform/Intel/KabylakeOpenBoardPkg: add ibrary for Fsp measurement.

2020-08-28 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Zhang, Qi1 > Sent: Friday, August 28, 2020 2:33 PM > To: devel@edk2.groups.io > Cc: Zhang, Qi1 ; Chiu, Chasel ; > Desimone, Nathaniel L ; Jeremy Soller > > Subject: [PATCH 2/3] Platform/Intel/Kabylake

Re: [edk2-devel] [PATCH v2] Platform/Intel/MinPlatformPkg: add Fsp measurement lib to dsc

2020-08-28 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: devel@edk2.groups.io On Behalf Of Qi Zhang > Sent: Friday, August 28, 2020 4:38 PM > To: devel@edk2.groups.io > Cc: Zhang, Qi1 ; Chiu, Chasel ; > Desimone, Nathaniel L ; Liming Gao > ; Dong, Eric > Subject

[edk2-devel] [PATCH] IntelFsp2Pkg/GenCfgOpt: skip unnecessarily header/BSF recreating.

2020-09-30 Thread Chiu, Chasel
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2967 When no change in FSP UPD DSC files, GenCfgOpt.py should skip recreating UPD header and BSF files. This patch added a check to handle this case. Cc: Maurice Ma Cc: Nate DeSimone Cc: Star Zeng Signed-off-by: Chasel Chiu ---

Re: [edk2-devel] [edk2-platforms] [PATCH V1 2/2] MinPlatformPkg: Coding style cleanups in CompressLib

2020-10-01 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Nate DeSimone > Sent: Wednesday, September 30, 2020 8:15 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Liming Gao > ; Dong, Eric > Subject: [edk2-platforms] [PATCH V1 2/2] MinPlatformPkg: Co

Re: [edk2-devel] [edk2-platforms] [PATCH V1 1/2] MinPlatformPkg: Add missing bounds checks to CompressLib

2020-10-01 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Nate DeSimone > Sent: Wednesday, September 30, 2020 8:15 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Liming Gao > ; Dong, Eric > Subject: [edk2-platforms] [PATCH V1 1/2] MinPlatformPkg: Add mi

Re: [edk2-devel] [PATCH] IntelFsp2Pkg: Add FunctionParametePtr to FspGlobalData.

2020-05-19 Thread Chiu, Chasel
Yes, thanks for good catch! I will correct it. > -Original Message- > From: Zeng, Star > Sent: Wednesday, May 20, 2020 12:21 PM > To: Desimone, Nathaniel L ; Chiu, Chasel > ; devel@edk2.groups.io > Cc: Ma, Maurice ; Zeng, Star > Subject: RE: [PAT

Re: [edk2-devel] [PATCH] IntelFsp2Pkg: Add FunctionParametePtr to FspGlobalData.

2020-05-20 Thread Chiu, Chasel
Thanks! > -Original Message- > From: Zeng, Star > Sent: Wednesday, May 20, 2020 12:34 PM > To: Chiu, Chasel ; Desimone, Nathaniel L > ; devel@edk2.groups.io > Cc: Ma, Maurice ; Zeng, Star > Subject: RE: [PATCH] IntelFsp2Pkg: Add FunctionParametePtr to > Fsp

Re: [edk2-devel] [PATCH] IntelFsp2Pkg GenCfgOpt.py: Initialize IncLines as empty list

2020-09-16 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: devel@edk2.groups.io On Behalf Of > gaoliming > Sent: Wednesday, September 16, 2020 5:58 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Zeng, Star > Subject: [edk2-dev

Re: [edk2-devel] [edk2-platforms: PATCH V1] MinPlatformPkg/PlatformInitPei:

2020-07-17 Thread Chiu, Chasel
Hi Chandana, Please see my question below. Thanks, Chasel > -Original Message- > From: Kumar, Chandana C > Sent: Wednesday, July 15, 2020 6:49 PM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Chiu, Chasel > ; Desimone, Nathaniel L > > Subject: [

Re: [edk2-devel] [PATCH 1/1] Platform/Intel: Add VmgExitLib to required DSC files

2020-08-10 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Gao, Liming > Sent: Tuesday, August 11, 2020 8:02 AM > To: Tom Lendacky ; devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Dong, Eric ; > Kinney, Michael D ; Agyeman, Prince > ; Qian, Yi

Re: [edk2-devel] [PATCH v2 6/9] IntelFsp2WrapperPkg/FspMeasurementLib: Add BaseFspMeasurementLib.

2020-08-05 Thread Chiu, Chasel
Hi Qi, Please see my comments below inline. Thanks, Chasel > -Original Message- > From: Zhang, Qi1 > Sent: Thursday, August 6, 2020 8:34 AM > To: devel@edk2.groups.io > Cc: Yao, Jiewen ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Zeng, Star ; Zhang, > Qi1

[edk2-devel] [PATCH v2 1/2] IntelFsp2Pkg: Add FSP*_ARCH_UPD.

2020-06-18 Thread Chiu, Chasel
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2781 Introduce FSPT_ARCH_UPD and FSPS_ARCH_UPD to support debug events and multi-phase silicon initialization. For backward compatibility the original structures are kept and new ARCH_UPD structures will be included only when UPD header revision

[edk2-devel] [PATCH v2 0/2] IntelFsp2Pkg: Add FSP*_ARCH_UPD.

2020-06-18 Thread Chiu, Chasel
when UPD header revision equal or greater than 2. GenCfgOpt script also updated to prevent from generating duplicate FSPT_ARCH_UPD and FSPS_ARCH_UPD typedef structures. Cc: Maurice Ma Cc: Nate DeSimone Cc: Star Zeng Signed-off-by: Chasel Chiu Chasel Chiu (2): IntelFsp2Pkg: Add FSP*_ARCH_UPD

[edk2-devel] [PATCH v2 2/2] IntelFsp2WrapperPkg: Add FSP*_ARCH_UPD.

2020-06-18 Thread Chiu, Chasel
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2781 Provides sample code to include FSPT_ARCH_UPD initial values with UPD header revision set to 2. Cc: Maurice Ma Cc: Nate DeSimone Cc: Star Zeng Signed-off-by: Chasel Chiu ---

Re: [edk2-devel] [Patch] MinPlatformPkg PciSegmentInfoLibSimple: Update GetPciSegmentInfo() API

2020-06-24 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Gao, Liming > Sent: Wednesday, June 24, 2020 10:22 PM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Chiu, Chasel ; > Desimone, Nathaniel L ; Dong, Eric > > Subject: [Patch] MinPlatformPkg PciSegm

Re: [edk2-devel] [PATCH 1/1] IntelFsp2Pkg/Tools/GenCfgOpt.py: Fix a bug about parse macro

2020-06-28 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Tan, Ming > Sent: Sunday, June 28, 2020 2:54 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Zeng, Star > Subject: [PATCH 1/1] IntelFsp2Pkg/Tools/GenCfgOpt.py: Fix a bug about p

Re: [edk2-devel] [PATCH] IntelFsp2Pkg/FspSecCore: Use UefiCpuLib.

2020-06-28 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Dong, Eric > Sent: Saturday, June 27, 2020 9:52 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Zeng, Star > Subject: [PATCH] IntelFsp2Pkg/FspSecCore: Use UefiCp

Re: [edk2-devel] [edk2-staging/EdkRepo-Manifest] [PATCH] Intel-MinPlatform: Update FSP repo URL

2020-06-10 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Desimone, Nathaniel L > Sent: Tuesday, June 9, 2020 9:49 AM > To: devel@edk2.groups.io > Cc: Desimone, Ashley E ; Chiu, Chasel > ; Chaganty, Rangasai V > ; Oram, Isaac W ; > Gao, Liming ; Ni, Ray ; Agyeman,

[edk2-devel] [PATCH] IntelFsp2Pkg: Add Fsp22SecCoreS.inf to Dsc.

2020-06-09 Thread Chiu, Chasel
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2788 DSC is incomplete according to the established CI policies. Fsp22SecCoreS.inf needs to be added to the Components section for completeness. Cc: Maurice Ma Cc: Nate DeSimone Cc: Star Zeng Signed-off-by: Chasel Chiu ---

Re: [edk2-devel] [PATCH] IntelFsp2Pkg: Add Fsp22SecCoreS.inf to Dsc.

2020-06-10 Thread Chiu, Chasel
Thanks Sean and I will correct the copyright typo. We will evaluate Core CI enabling. > -Original Message- > From: devel@edk2.groups.io On Behalf Of Sean > Sent: Wednesday, June 10, 2020 2:55 PM > To: devel@edk2.groups.io; Chiu, Chasel > Cc: Ma, Maurice ; Desimone, Natha

Re: [edk2-devel] [edk2-platforms] [PATCH] KabyLakeSiliconPkg: Bitmask comparison logic bug

2020-06-11 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Desimone, Nathaniel L > Sent: Wednesday, June 10, 2020 8:31 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Chaganty, Rangasai V > > Subject: [edk2-platforms] [PATCH] KabyLakeSiliconPkg: Bitmask c

Re: [edk2-devel] [PATCH 2/5] Platform/Intel/WhiskeylakeOpenBoardPkg: Change some PCDs type

2020-06-11 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Tan, Ming > Sent: Tuesday, June 9, 2020 7:24 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > > Subject: [PATCH 2/5] Platform/Intel/WhiskeylakeOpenBoardPkg: Change > some P

Re: [edk2-devel] [PATCH 3/5] Platform/Intel/CometlakeOpenBoardPkg: Change some PCDs type

2020-06-11 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Tan, Ming > Sent: Tuesday, June 9, 2020 7:24 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Chaganty, Rangasai V > > Subject: [PATCH 3/5] Platform/Intel/CometlakeOpenBoardPkg:

Re: [edk2-devel] [PATCH 4/5] Platform/Intel/KabylakeOpenBoardPkg: Change some PCDs type

2020-06-11 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Tan, Ming > Sent: Tuesday, June 9, 2020 7:24 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > > Subject: [PATCH 4/5] Platform/Intel/KabylakeOpenBoardPkg: Change some > P

[edk2-devel] [PATCH] IntelFsp2Pkg: Add FSP*_ARCH_UPD.

2020-06-04 Thread Chiu, Chasel
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2781 Introduce FSPT_ARCH_UPD and FSPS_ARCH_UPD to support debug events and multi-phase silicon initialization. Cc: Maurice Ma Cc: Nate DeSimone Cc: Star Zeng Signed-off-by: Chasel Chiu --- IntelFsp2Pkg/Include/FspEas/FspApi.h | 55

Re: [edk2-devel] [edk2-platforms] [PATCH v6 2/6] Platform/Intel/CometlakeOpenBoardPkg: Add ReportCpuHobLib.

2020-07-20 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: devel@edk2.groups.io On Behalf Of IanX Kuo > Sent: Tuesday, July 21, 2020 8:36 AM > To: devel@edk2.groups.io > Cc: Lu, James ; Kumar, Chandana C > ; Prabhala, Varalakshmi A > ; Kuo, IanX ; > Chaganty, R

Re: [edk2-devel] [edk2-platforms] [PATCH v6 4/6] Platform/Intel/SimicsOpenBoardPkg: Add ReportCpuHobLib.

2020-07-20 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: devel@edk2.groups.io On Behalf Of IanX Kuo > Sent: Tuesday, July 21, 2020 8:36 AM > To: devel@edk2.groups.io > Cc: Lu, James ; Kumar, Chandana C > ; Prabhala, Varalakshmi A > ; Kuo, IanX ; > Chaganty, R

Re: [edk2-devel] [edk2-platforms] [PATCH v6 6/6] Platform/Intel/MinPlatformPkg: Add ReportCpuHobLib.

2020-07-20 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Kuo, IanX > Sent: Tuesday, July 21, 2020 8:37 AM > To: devel@edk2.groups.io > Cc: Lu, James ; Kumar, Chandana C > ; Prabhala, Varalakshmi A > ; Kuo, IanX ; > Chaganty, Rangasai V ; Chiu, Chasel > > Su

Re: [edk2-devel] [edk2-platforms] [PATCH v6 3/6] Platform/Intel/KabylakeOpenBoardPkg: Add ReportCpuHobLib.

2020-07-20 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Kuo, IanX > Sent: Tuesday, July 21, 2020 8:36 AM > To: devel@edk2.groups.io > Cc: Lu, James ; Kumar, Chandana C > ; Prabhala, Varalakshmi A > ; Kuo, IanX ; > Chaganty, Rangasai V ; Chiu, Chasel > > Su

Re: [edk2-devel] [edk2-platforms] [PATCH v6 5/6] Platform/Intel/WhiskeylakeOpenBoardPkg: Add ReportCpuHobLib.

2020-07-20 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Kuo, IanX > Sent: Tuesday, July 21, 2020 8:36 AM > To: devel@edk2.groups.io > Cc: Lu, James ; Kumar, Chandana C > ; Prabhala, Varalakshmi A > ; Kuo, IanX ; > Chaganty, Rangasai V ; Chiu, Chasel > > Su

Re: [edk2-devel] [edk2-platforms] [PATCH v6 1/6] Platform/Intel/MinPlatformPkg: Fix build error

2020-07-20 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Kuo, IanX > Sent: Tuesday, July 21, 2020 8:35 AM > To: devel@edk2.groups.io > Cc: Lu, James ; Kumar, Chandana C > ; Prabhala, Varalakshmi A > ; Kuo, IanX ; > Chaganty, Rangasai V ; Chiu, Chasel > > Su

Re: [edk2-devel] [edk2-platforms] [PATCH v8 0/6] Create a Library instance of ReportCpuHobLib

2020-07-21 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Kuo, IanX > Sent: Tuesday, July 21, 2020 3:29 PM > To: devel@edk2.groups.io > Cc: Lu, James ; Kumar, Chandana C > ; Prabhala, Varalakshmi A > ; Gao, Liming ; > Kuo, IanX ; Chaganty, Rangasai V > ; Chi

Re: [edk2-devel] [PATCH] IntelFsp2Pkg: Add YAML file generation support

2021-02-03 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Loo Tung Lun > Sent: Wednesday, February 3, 2021 8:36 AM > To: devel@edk2.groups.io > Cc: Loo, Tung Lun ; Ma, Maurice > ; Desimone, Nathaniel L > ; Zeng, Star ; Chiu, > Chasel > Subject: [PATCH]

Re: [edk2-devel] [edk2-platforms][Patch 1/3] CoffeelakeSiliconPkg/BaseSmbusLib: Fix SmBusSendByte value

2021-06-10 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Kinney, Michael D > Sent: Friday, June 11, 2021 6:46 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Chaganty, Rangasai V > > Subject: [edk2-platforms][Patch 1/3] CoffeelakeSiliconPkg/BaseSmbusLib: Fix

Re: [edk2-devel] [edk2-platforms][Patch 2/3] KabylakeSiliconPkg/BaseSmbusLib: Fix SmBusSendByte value

2021-06-10 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Kinney, Michael D > Sent: Friday, June 11, 2021 6:46 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > > Subject: [edk2-platforms][Patch 2/3] KabylakeSiliconPkg/BaseSmbusLib: Fix

Re: [edk2-devel] [edk2-platforms][PATCH v3 32/41] CoffeelakeSiliconPkg: Remove PCH SPI PPI and Protocol from package

2021-06-18 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: mikub...@linux.microsoft.com > Sent: Friday, June 18, 2021 10:07 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Chaganty, Rangasai V > ; Desimone, Nathaniel L > > Subject: [edk2-platforms][PATCH v3 32/

Re: [edk2-devel] [edk2-platforms][PATCH v3 39/41] KabylakeSiliconPkg: Identify flash regions by GUID

2021-06-18 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: mikub...@linux.microsoft.com > Sent: Friday, June 18, 2021 10:07 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Chaganty, Rangasai V > ; Desimone, Nathaniel L > > Subject: [edk2-platforms][PATCH v3 3

Re: [edk2-devel] [edk2-platforms][PATCH v3 27/41] KabylakeSiliconPkg: Remove SmmSpiFlashCommonLib

2021-06-18 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: mikub...@linux.microsoft.com > Sent: Friday, June 18, 2021 10:07 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Chaganty, Rangasai V > ; Desimone, Nathaniel L > > Subject: [edk2-platforms][PATCH v3 2

Re: [edk2-devel] [edk2-platforms][PATCH v3 33/41] KabylakeSiliconPkg: Remove PCH SPI PPI and Protocol from package

2021-06-18 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: mikub...@linux.microsoft.com > Sent: Friday, June 18, 2021 10:07 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Chaganty, Rangasai V > ; Desimone, Nathaniel L > > Subject: [edk2-platforms][PATCH v3 3

Re: [edk2-devel] [edk2-platforms][PATCH v3 38/41] CoffeelakeSiliconPkg/BasePchSpiCommonLib: Identify flash regions by GUID

2021-06-18 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: mikub...@linux.microsoft.com > Sent: Friday, June 18, 2021 10:07 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Chaganty, Rangasai V > ; Desimone, Nathaniel L > > Subject: [edk2-p

Re: [edk2-devel][PATCH v5 3/7] SimicsOpenBoard: Move ReportCpuHob library path

2021-05-11 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Chuang, SofiaX > Sent: Tuesday, May 11, 2021 3:54 AM > To: devel@edk2.groups.io > Cc: Chuang, SofiaX ; Agyeman, Prince > ; Chiu, Chasel > Subject: [edk2-devel][PATCH v5 3/7] > SimicsOpenBoard: Move R

Re: [edk2-devel][PATCH v5 4/7] KabylakeOpenBoard: Move ReportCpuHob library path

2021-05-11 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Chuang, SofiaX > Sent: Tuesday, May 11, 2021 3:54 AM > To: devel@edk2.groups.io > Cc: Chuang, SofiaX ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Jeremy Soller > Subject: [edk2-devel][PATCH v5 4/7] &

Re: [edk2-devel][PATCH v5 5/7] WhiskeylakeOpenBoard: Move library path

2021-05-11 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Chuang, SofiaX > Sent: Tuesday, May 11, 2021 3:54 AM > To: devel@edk2.groups.io > Cc: Chuang, SofiaX ; Chiu, Chasel > ; Desimone, Nathaniel L > > Subject: [edk2-devel][PATCH v5 5/7] WhiskeylakeOpenBoard: Mov

Re: [edk2-devel][PATCH v5 6/7] MiniPlatformPkg: Move ReportCpuHob library path

2021-05-11 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Chuang, SofiaX > Sent: Tuesday, May 11, 2021 3:54 AM > To: devel@edk2.groups.io > Cc: Chuang, SofiaX ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Liming Gao ; > Dong, Eric > Subject: [edk2-devel][PATC

Re: [edk2-devel] [PATCH v3] IntelFsp2Pkg: YAML script bug fix

2021-05-17 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Loo, Tung Lun > Sent: Monday, May 17, 2021 12:04 PM > To: devel@edk2.groups.io > Cc: Loo, Tung Lun ; Ma, Maurice > ; Desimone, Nathaniel L > ; Zeng, Star ; Chiu, > Chasel > Subject: [PATCH v3] IntelF

Re: [edk2-devel] [edk2-platforms][PATCH v2 01/35] CometlakeOpenBoardPkg: Remove redundant IntelSiliconPkg.dec entry

2021-05-19 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: mikub...@linux.microsoft.com > Sent: Wednesday, May 19, 2021 11:59 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Chaganty, Rangasai V > ; Kethi Reddy, Deepika > ; Esakkithevar

Re: [edk2-devel] [edk2-platforms][PATCH v2 20/35] CometlakeOpenBoardPkg: Update SpiFvbService & SpiFlashCommonLib

2021-05-19 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: mikub...@linux.microsoft.com > Sent: Wednesday, May 19, 2021 12:00 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Chaganty, Rangasai V > ; Kethi Reddy, Deepika > ; Esakkithevar

Re: [edk2-devel] [edk2-platforms][PATCH v2 33/35] KabylakeSiliconPkg: Remove PCH SPI PPI and Protocol from package

2021-05-19 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: mikub...@linux.microsoft.com > Sent: Wednesday, May 19, 2021 12:00 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Chaganty, Rangasai V > > Subject: [edk2-platforms][PATCH v2 33/35] KabylakeSiliconPkg:

Re: [edk2-devel] [edk2-platforms][PATCH v2 31/35] KabylakeOpenBoardPkg/PeiSerialPortLibSpiFlash: Add IntelSiliconPkg.dec

2021-05-19 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: mikub...@linux.microsoft.com > Sent: Wednesday, May 19, 2021 12:00 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > > Subject: [edk2-platforms][PATCH v2 31/35] &

Re: [edk2-devel] [edk2-platforms][PATCH v2 30/35] MinPlatformPkg: Remove SpiFlashCommonLibNull

2021-05-19 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: mikub...@linux.microsoft.com > Sent: Wednesday, May 19, 2021 12:00 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Liming Gao ; > Dong, Eric > Subject: [edk2-platforms][PATCH

Re: [edk2-devel] [edk2-platforms][PATCH v2 21/35] KabylakeOpenBoardPkg: Update SpiFvbService & SpiFlashCommonLib

2021-05-19 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: devel@edk2.groups.io On Behalf Of Michael > Kubacki > Sent: Wednesday, May 19, 2021 12:00 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Jeremy Soller > Subject: [edk2-devel] [

Re: [edk2-devel] [edk2-platforms][PATCH v2 25/35] MinPlatformPkg: Remove SpiFvbService modules

2021-05-19 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: mikub...@linux.microsoft.com > Sent: Wednesday, May 19, 2021 12:00 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Liming Gao ; > Dong, Eric > Subject: [edk2-platforms][PATCH

Re: [edk2-devel] [edk2-platforms][PATCH v2 03/35] CometlakeOpenBoardPkg/PeiPolicyUpdateLib: Add missing GUID to INF

2021-05-19 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: mikub...@linux.microsoft.com > Sent: Wednesday, May 19, 2021 11:59 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Chaganty, Rangasai V > ; Kethi Reddy, Deepika > ; Esakkithevar

Re: [edk2-devel] [edk2-platforms][PATCH v2 24/35] WhiskeylakeOpenBoardPkg: Update SpiFvbService & SpiFlashCommonLib

2021-05-19 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: mikub...@linux.microsoft.com > Sent: Wednesday, May 19, 2021 12:00 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > > Subject: [edk2-platforms][PATCH v2 24/35] Whiskeylak

Re: [edk2-devel] [PATCH v3] IntelFsp2Pkg: YAML script bug fix

2021-05-17 Thread Chiu, Chasel
Pushed: 1fbf5e30ae8eb725f4e10984f7b0a208f78abbd0 Thanks, Chasel > -Original Message- > From: Loo, Tung Lun > Sent: Monday, May 17, 2021 12:04 PM > To: devel@edk2.groups.io > Cc: Loo, Tung Lun ; Ma, Maurice > ; Desimone, Nathaniel L > ; Zeng, Star ; Chiu, > C

Re: [edk2-devel] [PATCH v1] IntelFsp2WrapperPkg: Remove microcode PCDs

2021-05-24 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: devel@edk2.groups.io On Behalf Of Jason Lou > Sent: Wednesday, April 14, 2021 10:34 AM > To: devel@edk2.groups.io > Cc: Lou, Yun ; Ni, Ray > Subject: [edk2-devel] [PATCH v1] IntelFsp2WrapperPkg: Remove microcode > PCDs > > REF:

Re: [edk2-devel] [PATCH v4] MinPlatformPkg: Rebase fail when python tools path exist whitespace exist whitespace REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3412

2021-05-30 Thread Chiu, Chasel
Patch has pushed: 86984c17d562fc60a6dabbc3a479d79163656a0c > -Original Message- > From: Kuo, IanX > Sent: Monday, May 24, 2021 6:49 AM > To: devel@edk2.groups.io > Cc: Kuo, IanX ; Chiu, Chasel ; > Desimone, Nathaniel L > Subject: [PATCH v4] MinPlatformPkg: Re

Re: [edk2-devel] [PATCH v3] MinPlatformPkg/Fsp: Rebase fail when python tools path exist whitespace REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3412

2021-05-24 Thread Chiu, Chasel
With subject format correction, Reviewed-by: Chasel Chiu > -Original Message- > From: Kuo, IanX > Sent: Monday, May 24, 2021 6:38 AM > To: devel@edk2.groups.io > Cc: Kuo, IanX ; Chiu, Chasel ; > Desimone, Nathaniel L > Subject: [PATCH v3] MinPlatformPkg/Fsp: Re

Re: [edk2-devel] [PATCH v2] IntelFsp2WrapperPkg: Remove microcode related PCDs

2021-05-30 Thread Chiu, Chasel
Patch pushed: fe5da0927aad98f3c005088197fa30c1b8f9d3e8 > -Original Message- > From: Lou, Yun > Sent: Thursday, April 15, 2021 2:49 PM > To: devel@edk2.groups.io > Cc: Lou, Yun ; Chiu, Chasel ; > Desimone, Nathaniel L ; Zeng, Star > ; Ni, Ray > Subject: [PATCH

Re: [edk2-devel] [PATCH] IntelFsp2Pkg: PatchFv parseInfFile function modification

2021-07-04 Thread Chiu, Chasel
Thanks Ashraf. Adding my comments below inline. > -Original Message- > From: S, Ashraf Ali > Sent: Sunday, July 4, 2021 7:23 PM > To: devel@edk2.groups.io > Cc: S, Ashraf Ali ; Ni, Ray ; Chiu, > Chasel ; Desimone, Nathaniel L > ; Zeng, Star > Subject: [PATC

Re: [edk2-devel] [PATCH v3] IntelFsp2Pkg: PatchFv parseInfFile function modification

2021-07-08 Thread Chiu, Chasel
Patch pushed: b560e9d9b67450d3baea56d0e211066722643c57 Thanks, Chasel > -Original Message- > From: S, Ashraf Ali > Sent: Wednesday, July 7, 2021 2:42 AM > To: devel@edk2.groups.io > Cc: S, Ashraf Ali ; Ni, Ray ; Chiu, > Chasel ; Desimone, Nathaniel L > ; Zeng, St

[edk2-devel] [edk2-platforms: PATCH 2/2] AdvancedFeaturePkg: Fail to build this package.

2021-07-08 Thread Chiu, Chasel
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3484 Fixed the build failure of this package. Cc: Nate DeSimone Cc: Sai Chaganty Cc: Liming Gao Cc: Isaac Oram Signed-off-by: Chasel Chiu --- Features/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc | 19 +-- 1 file

[edk2-devel] [edk2-platforms: PATCH 0/2] Fail to build Intel/AdvancedFeaturePkg.

2021-07-08 Thread Chiu, Chasel
AdvancedFeaturePkg building failure caused by IpmiFeaturePkg code. This patch series fixed the issue. Cc: Nate DeSimone Cc: Sai Chaganty Cc: Liming Gao Cc: Isaac Oram Signed-off-by: Chasel Chiu Chasel Chiu (2): IpmiFeaturePkg: Fail to build this package. AdvancedFeaturePkg: Fail

[edk2-devel] [edk2-platforms: PATCH 1/2] IpmiFeaturePkg: Fail to build this package.

2021-07-08 Thread Chiu, Chasel
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3484 Fixed the build failure of this package. Cc: Nate DeSimone Cc: Sai Chaganty Cc: Liming Gao Cc: Isaac Oram Signed-off-by: Chasel Chiu --- Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Pei/PeiGenericIpmi.inf | 1 +

Re: [edk2-devel] [PATCH] IntelFsp2Pkg: BaseCacheLib EfiProgramMtrr MtrrNumber Should be UINT32

2021-07-09 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: S, Ashraf Ali > Sent: Friday, July 9, 2021 3:33 PM > To: devel@edk2.groups.io > Cc: S, Ashraf Ali ; Ni, Ray ; Chiu, > Chasel ; Desimone, Nathaniel L > ; Zeng, Star ; > Solanki, Digant H ; V, Sangee

Re: [edk2-devel] [PATCH v3] IntelFsp2Pkg: PatchFv parseInfFile function modification

2021-07-06 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: S, Ashraf Ali > Sent: Wednesday, July 7, 2021 2:42 AM > To: devel@edk2.groups.io > Cc: S, Ashraf Ali ; Ni, Ray ; Chiu, > Chasel ; Desimone, Nathaniel L > ; Zeng, Star > Subject: [PATCH v3] IntelFsp2P

Re: [edk2-devel] [PATCH v2] IntelFsp2Pkg: PatchFv parseInfFile function modification

2021-07-05 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: S, Ashraf Ali > Sent: Monday, July 5, 2021 4:11 PM > To: devel@edk2.groups.io > Cc: S, Ashraf Ali ; Ni, Ray ; Chiu, > Chasel ; Desimone, Nathaniel L > ; Zeng, Star > Subject: [PATCH v2] IntelFsp2Pkg: Patch

Re: [edk2-devel] [edk2-platforms: PATCH 1/2] IpmiFeaturePkg: Fail to build this package.

2021-07-09 Thread Chiu, Chasel
Change pushed: 8cb431b46a0888a8ee8e442dc3ea50d7de79e473 107af998afe1a34c7b6aff5240abd9918e51b073 Thanks, Chasel > -Original Message- > From: Chaganty, Rangasai V > Sent: Friday, July 9, 2021 2:33 PM > To: Chiu, Chasel ; devel@edk2.groups.io > Cc: Desimone, Nathaniel

Re: [edk2-devel] [edk2-platforms: PATCH 1/2] IpmiFeaturePkg: Fail to build this package.

2021-07-09 Thread Chiu, Chasel
Hi Sai, We will fix the build failure first and macro naming convention will be checked separately later. Thanks, Chasel > -Original Message- > From: Chaganty, Rangasai V > Sent: Friday, July 9, 2021 10:25 AM > To: Chiu, Chasel ; devel@edk2.groups.io > Cc: Desimo

Re: [edk2-devel] [edk2-platforms][PATCH v4 27/41] KabylakeSiliconPkg: Remove SmmSpiFlashCommonLib

2021-06-27 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: mikub...@linux.microsoft.com > Sent: Saturday, June 26, 2021 5:21 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Chaganty, Rangasai V > ; Desimone, Nathaniel L > > Subject: [edk2-platforms][PATCH v4 2

Re: [edk2-devel] [edk2-platforms][PATCH v4 21/41] KabylakeOpenBoardPkg: Update SpiFvbService & SpiFlashCommonLib

2021-06-27 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: mikub...@linux.microsoft.com > Sent: Saturday, June 26, 2021 5:21 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Jeremy Soller > Subject: [edk2-platforms][PATCH v4 21/41] Kabylak

Re: [edk2-devel] [edk2-platforms][PATCH v4 20/41] CometlakeOpenBoardPkg: Update SpiFvbService & SpiFlashCommonLib

2021-06-27 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: mikub...@linux.microsoft.com > Sent: Saturday, June 26, 2021 5:21 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Chaganty, Rangasai V > ; Kethi Reddy, Deepika > ; Esakkithevar

Re: [edk2-devel] [edk2-platforms][PATCH v4 25/41] MinPlatformPkg: Remove SpiFvbService modules

2021-06-27 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: devel@edk2.groups.io On Behalf Of Michael > Kubacki > Sent: Saturday, June 26, 2021 5:21 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Liming Gao ; > Dong, Eric >

<    1   2   3   4   5   6   7   8   9   10   >