Thanks for cleaner implementation Ted!
Reviewed-by: Chasel Chiu
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Kuo,
> Ted
> Sent: Wednesday, November 9, 2022 3:31 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
> ; Zen
k2.groups.io
> Cc: S, Ashraf Ali ; Chiu, Chasel
> ;
> Desimone, Nathaniel L ; Chaganty, Rangasai
> V ; Zeng, Star
> Subject: [PATCH] [IntelFsp2Pkg]: Fix GCC Compiler warning
>
> Function defination should match with declaration.
> [-Wlto-type-mismatch]
>
> Cc: C
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4377
Fix below warnings generated by NASM X64 build:
/X64/FspHelper.iii:26: warning: signed dword value exceeds bounds
/X64/FspHelper.iii:35: warning: signed dword value exceeds bounds
/X64/FspApiEntryT.iii:320: warning: dword data exceeds
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4377
Fix below warnings generated by NASM X64 build:
/X64/FspHelper.iii:26: warning: signed dword value exceeds bounds
/X64/FspHelper.iii:35: warning: signed dword value exceeds bounds
/X64/FspApiEntryT.iii:320: warning: dword data exceeds
Patch merged:
https://github.com/tianocore/edk2/commit/f6bd3286edfbe5eb6b50946cc8bb89e5c60b9388
Thanks,
Chasel
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Chiu, Chasel
> Sent: Tuesday, March 21, 2023 5:14 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Ch
Thanks for fixing this bug!
Reviewed-by: Chasel Chiu
> -Original Message-
> From: S, Ashraf Ali
> Sent: Thursday, March 9, 2023 8:06 AM
> To: devel@edk2.groups.io
> Cc: S, Ashraf Ali ; Chiu, Chasel
> ;
> Desimone, Nathaniel L ; Chaganty, Rangasai
> V
Reviewed-by: Chasel Chiu
Thanks,
Chasel
> -Original Message-
> From: Chen, Aryeh
> Sent: Tuesday, February 28, 2023 10:37 PM
> To: devel@edk2.groups.io
> Cc: Chen, Aryeh ; Chiu, Chasel
> ; Desimone, Nathaniel L
> ; Oram, Isaac W ;
> Gao, Liming ; Dong, Er
Hi Aryeh,
Please see below inline for comments.
Thanks,
Chasel
> -Original Message-
> From: Chen, Aryeh
> Sent: Wednesday, April 12, 2023 4:20 AM
> To: devel@edk2.groups.io
> Cc: Chen, Aryeh ; Chiu, Chasel
> ; Desimone, Nathaniel L
> ; Oram, Isaac W ;
>
Reviewed-by: Chasel Chiu
Thanks,
Chasel
> -Original Message-
> From: Chen, Aryeh
> Sent: Wednesday, April 12, 2023 9:27 AM
> To: devel@edk2.groups.io
> Cc: Chen, Aryeh ; Chiu, Chasel
> ; Desimone, Nathaniel L
> ; Oram, Isaac W ;
> Gao, Liming ; Dong, Er
Reviewed-by: Chasel Chiu
Thanks,
Chasel
> -Original Message-
> From: Duggapu, Chinni B
> Sent: Sunday, April 16, 2023 9:23 PM
> To: devel@edk2.groups.io
> Cc: Duggapu, Chinni B ; Chiu, Chasel
> ; Desimone, Nathaniel L
> ; Zeng, Star ; Kuo, Ted
>
> Subje
Hi Mike,
Thanks for bringing this good point!
We would like to document that all FDT structure data are in *big endian*
format and remove those SwapBytes MACROs from FdtLib.h
It makes sense to handle this from library consumer side (consumer can define
their own MACROs) because we cannot
Add more maintainers and reviewers for these 2 packages.
Cc: Nate DeSimone
Cc: Duggapu Chinni B
Cc: Ray Han Lim Ng
Cc: Chen Gang C
Cc: Star Zeng
Cc: Ted Kuo
Cc: Ashraf Ali S
Cc: Susovan Mohapatra
Signed-off-by: Chasel Chiu
---
Maintainers.txt | 10 ++
1 file changed, 10
Hello,
Since platform may also define other FDT structures, this EDK2 library may not
be able to convert all the FDT structures to little endian.
We might define a generic MACRO in library like
CONVERT_FDT_DATA_TO_LITTLE_ENDIAN which can be used for all structure data, but
it will be almost
Patch merged:
https://github.com/tianocore/edk2/commit/b16284e2a0011489f6e16dfcc6af7623c3cbaf0b
Thanks,
Chasel
> -Original Message-
> From: Duggapu, Chinni B
> Sent: Sunday, April 16, 2023 9:23 PM
> To: devel@edk2.groups.io
> Cc: Duggapu, Chinni B ; Chiu, Chas
Hi Leif,
Would you please share your ideas and respond Mike's question too?
Thanks,
Chasel
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Chiu, Chasel
> Sent: Tuesday, April 25, 2023 10:22 PM
> To: devel@edk2.groups.io; Kinney, Michael D ;
> Leif Lind
Patch merged:
https://github.com/tianocore/edk2-platforms/commit/3b7f82b61b552f5bdd415f1bf4ba2866a09ceac0
Thanks,
Chasel
> -Original Message-
> From: Chen, Aryeh
> Sent: Wednesday, April 12, 2023 9:27 AM
> To: devel@edk2.groups.io
> Cc: Chen, Aryeh ; Chiu, Chas
Hi Chinni,
Please help to correct patch format and make sure it can pass verification by
BaseTools/Scripts/PatchCheck.py
Thanks,
Chasel
> -Original Message-
> From: Duggapu, Chinni B
> Sent: Friday, April 14, 2023 1:34 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Ch
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4391
FSP should support the scenario that CPU microcode already loaded
before calling LoadMicrocodeDefault(), in this case it should return
directly without spending more time.
Also the LoadMicrocodeDefault() should only attempt to load one
Thanks for reviewing Ray!
Please see my reply below inline.
> -Original Message-
> From: Ni, Ray
> Sent: Wednesday, March 29, 2023 10:31 PM
> To: Chiu, Chasel ; devel@edk2.groups.io
> Cc: Desimone, Nathaniel L ; Zeng, Star
>
> Subject: RE: [P
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4391
FSP should support the scenario that CPU microcode already loaded
before calling LoadMicrocodeDefault(), in this case it should return
directly without spending more time.
Also the LoadMicrocodeDefault() should only attempt to load one
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4395
FSP specification defines the TempRamInit API preserved register list
which including EBX/RBX, however current implementation unexpectedly
overriding EBX/RBX register that should be fixed.
Cc: Nate DeSimone
Cc: Star Zeng
Signed-off-by:
ess the step #3 is unnecessary because step #1 guarantees that step #3
> would not go to Done.
> Can you please confirm?
>
>
> > -Original Message-
> > From: devel@edk2.groups.io On Behalf Of Chiu,
> > Chasel
> > Sent: Saturday, April 1, 2023 6:57 AM
> > T
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4391
FSP should support the scenario that CPU microcode already loaded
before calling LoadMicrocodeDefault(), in this case it should return
directly without spending more time.
Also the LoadMicrocodeDefault() should only attempt to load one
Patch merged:
https://github.com/tianocore/edk2/commit/af98f1fb0311d8e3cc52ab9fc544a8c8ff8f7546
Thanks,
Chasel
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Chiu, Chasel
> Sent: Friday, March 31, 2023 4:16 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Ch
Patch merged:
https://github.com/tianocore/edk2/commit/7df447930c42addaf2cc0d32916141d95ded677e
Thanks,
Chasel
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Chiu, Chasel
> Sent: Monday, April 3, 2023 11:34 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Ch
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4391
FSP should support the scenario that CPU microcode already loaded
before calling LoadMicrocodeDefault(), in this case it should return
directly without spending more time.
Also the LoadMicrocodeDefault() should only attempt to load one
Reviewed-by: Chasel Chiu
Thanks,
Chasel
> -Original Message-
> From: Tan, Dun
> Sent: Monday, March 27, 2023 7:43 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
> ; Zeng, Star ; Ni, Ray
>
> Subject: [PATCH 3/9] IntelFsp2Pkg: Add
Reviewed-by: Chasel Chiu
Thanks,
Chasel
> -Original Message-
> From: Liu, Zhiguang
> Sent: Tuesday, April 4, 2023 12:56 AM
> To: devel@edk2.groups.io
> Cc: Liu, Zhiguang ; Chiu, Chasel
> ; Desimone, Nathaniel L
> ; Oram, Isaac W ;
> Gao, Liming ; Dong, Eri
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4377
Fix below warnings generated by NASM X64 build:
/X64/FspHelper.iii:26: warning: signed dword value exceeds bounds
/X64/FspHelper.iii:35: warning: signed dword value exceeds bounds
/X64/FspApiEntryT.iii:320: warning: dword data exceeds
3 4:05 PM
> To: Pedro Falcato ; devel@edk2.groups.io; Ni, Ray
>
> Cc: Chiu, Chasel ; Zeng, Star
> Subject: RE: [edk2-devel] [PATCH v2] IntelFsp2Pkg: Fix NASM X64 build
> warnings.
>
> Reviewing this code in more detail... I think clearing the upper 32-bits is a
> bu
When invalid VariableStore FV header detected, current SpiFvbService
will erase both FV and VariableStore headers from flash, however,
it will only rewrite FV header back and cause invalid VariableStore
header.
This patch adding the support for rewriting both FV header and
VariableStore header
Thanks for the good catch Ashraf!
I have sent V2 patch for addressing your feedbacks, please help to review again.
Thanks,
Chasel
> -Original Message-
> From: S, Ashraf Ali
> Sent: Saturday, February 4, 2023 8:03 AM
> To: Chiu, Chasel ; devel@edk2.groups.io
> Cc
Thanks Michael! I will apply the change during merging!
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Michael
> Kubacki
> Sent: Wednesday, February 8, 2023 4:41 PM
> To: devel@edk2.groups.io; Chiu, Chasel
> Cc: S, Ashraf Ali ; Oram, Isaac W
> ;
Thanks for reviewing Michael.
Please see my reply below inline and help to review V4 patch again.
Thanks,
Chasel
> -Original Message-
> From: Michael Kubacki
> Sent: Tuesday, February 7, 2023 12:22 PM
> To: devel@edk2.groups.io; Chiu, Chasel
> Cc: S, Ashraf Ali
When invalid VariableStore FV header detected, current SpiFvbService
will erase both FV and VariableStore headers from flash, however,
it will only rewrite FV header back and cause invalid VariableStore
header.
This patch adding the support for rewriting both FV header and
VariableStore header
Bug fix patch has been merged:
https://github.com/tianocore/edk2-platforms/commit/e95c7988994c73918ffa282e2d2f5af11f8addc4
Thanks,
Chasel
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Chiu, Chasel
> Sent: Wednesday, February 8, 2023 2:17 PM
> To
Thanks Isaac!
> -Original Message-
> From: Oram, Isaac W
> Sent: Wednesday, February 8, 2023 5:39 PM
> To: devel@edk2.groups.io; mikub...@linux.microsoft.com; Chiu, Chasel
>
> Cc: S, Ashraf Ali ; Chaganty, Rangasai V
> ; Ni, Ray ; Kubacki,
> Michael
> Subj
Platform may implement Other NVS variable region following Regular
variable region and in this case SpiFvbService should include both
region size when calculating the total NVS region size.
One usage model is EventLog NVS region and there could be others.
Cc: Ashraf Ali S
Cc: Isaac Oram
Cc:
Hello,
Another V4 patch sent for applying more comment/commit message feedbacks form
Isaac.
Please help to review again.
Thanks,
Chasel
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Chiu, Chasel
> Sent: Thursday, February 9, 2023 9:26 AM
> To: devel@ed
, 2023 10:34 AM
> To: Chiu, Chasel ; devel@edk2.groups.io
> Cc: S, Ashraf Ali ; Chaganty, Rangasai V
> ; Ni, Ray ; Kubacki,
> Michael
> Subject: RE: [edk2-platforms: PATCH v4] IntelSiliconPkg/SpiFvbServiceSmm:
> Support Additional NVS region.
>
> Reviewed-by: Isaac
Platform may implement an additional NVS region following
Regular variable region and in this case SpiFvbService should include
both region size when calculating the total NVS region size.
One usage model is EventLog NVS region and there could be others.
Example NVS flash map for such usage
To: devel@edk2.groups.io; Oram, Isaac W ; Chiu,
> Chasel
> Cc: S, Ashraf Ali ; Chaganty, Rangasai V
> ; Ni, Ray ; Kubacki,
> Michael
> Subject: Re: [edk2-devel] [edk2-platforms: PATCH]
> IntelSiliconPkg/SpiFvbServiceSmm: Support Other NVS variable region.
>
> Thanks, that's
Platform may implement an additional NVS region following
Regular variable region and in this case SpiFvbService should include
both region size when calculating the total NVS region size.
The PcdFlashNvStorageAdditionalSize is for compatible with legacy
usages that should be deprecated. The new
Platform may implement an additional NVS region following
Regular variable region and in this case SpiFvbService should include
both region size when calculating the total NVS region size.
One usage model is EventLog NVS region and there could be others.
Example NVS flash map for such usage
When invalid VariableStore FV header detected, current SpiFvbService
will erase both FV and VariableStore headers from flash, however,
it will only rewrite FV header back and cause invalid VariableStore
header.
This patch adding the support for rewriting both FV header and
VariableStore header
Hello,
I have sent a V3 patch to remove Uncrustify coding style changes. We will do
coding style changes separately later.
Please help to review V3 patch.
Thanks,
Chasel
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Chiu, Chasel
> Sent: Monday, February 6
When invalid VariableStore FV header detected, current SpiFvbService
will erase both FV and VariableStore headers from flash, however,
it will only rewrite FV header back and cause invalid VariableStore
header.
This patch adding the support for rewriting both FV header and
VariableStore header
Reviewed-by: Chasel Chiu
Thanks,
Chasel
> -Original Message-
> From: mikub...@linux.microsoft.com
> Sent: Thursday, February 9, 2023 4:52 PM
> To: devel@edk2.groups.io
> Cc: S, Ashraf Ali ; Oram, Isaac W
> ; Chaganty, Rangasai V
> ; Ni, Ray ; Chiu, Chase
: S, Ashraf Ali ; Oram, Isaac W
> ; Chaganty, Rangasai V
> ; Ni, Ray ; Chiu, Chasel
>
> Subject: [edk2-platforms][PATCH v1 1/1] SpiFvbServiceStandaloneMm: Add
> changes for rewrite varstore header
>
> From: Michael Kubacki
>
> Updates the Standalone MM module
Reviewed-by: Chasel Chiu
Thanks,
Chasel
> -Original Message-
> From: Oram, Isaac W
> Sent: Wednesday, March 15, 2023 6:18 AM
> To: devel@edk2.groups.io
> Cc: Oram, Isaac W ; Chiu, Chasel
> ; Desimone, Nathaniel L
> ; Gao, Liming ;
> Dong, Eric
> Subject:
Reviewed-by: Chasel Chiu
Thanks,
Chasel
> -Original Message-
> From: Oram, Isaac W
> Sent: Tuesday, March 7, 2023 4:16 PM
> To: devel@edk2.groups.io
> Cc: Oram, Isaac W ; Desimone, Nathaniel L
> ; Chiu, Chasel
> Subject: [edk2-devel][edk2-pl
> Cc: Aishwarya, KurugoduMelmatamX
> ; Chiu, Chasel
> ; Desimone, Nathaniel L
> ; Duggapu, Chinni B
> ; Chen, Gang C ; Zeng,
> Star ; Kuo, Ted ; S, Ashraf Ali
> ; Mohapatra, Susovan
>
> Subject: [PATCH] Get HobListPtr before calling the Multiphase FSPS
>
> REF : htt
Hi Ted,
One question below inline.
Another minor feedback is the commit/patch subject format should be "Package:
title"
Thanks,
Chasel
> -Original Message-
> From: Kuo, Ted
> Sent: Tuesday, July 18, 2023 7:16 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chase
devel@edk2.groups.io; rsi...@ventanamicro.com
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
> ; Zeng, Star ; Ranbir
> Singh
> Subject: Re: [edk2-devel] [PATCH 1/1] IntelFsp2Pkg/Library/BaseFspCommonLib:
> Fix OVERRUN Coverity issue
>
> On Thu, May 18, 2023 at 4:16 PM Ranbir Singh
> wro
Patch merged:
https://github.com/tianocore/edk2/commit/69e10f02111bf7e719237f05233abff4e50016fa
Thanks,
Chasel
> -Original Message-
> From: Tan, Ming
> Sent: Sunday, May 21, 2023 11:13 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Duggapu, Chinni B
>
Patch merged:
https://github.com/tianocore/edk2/commit/48c53994e649d51a388dc414944c9a9b717a1c3c
Thanks,
Chasel
> -Original Message-
> From: Ranbir Singh
> Sent: Wednesday, May 17, 2023 11:29 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
Patch merged:
https://github.com/tianocore/edk2-platforms/commit/ce9ea07a8b56dc12165ca4f7e975d3b2f798881e
Thanks,
Chasel
> -Original Message-
> From: Ni, Ray
> Sent: Wednesday, May 31, 2023 2:18 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
Patch merged:
https://github.com/tianocore/edk2-platforms/commit/1a7bd150d39007bfb72c4727feda3184c23efe96
Thanks,
Chasel
> -Original Message-
> From: Ke, VincentX
> Sent: Tuesday, May 30, 2023 7:48 PM
> To: devel@edk2.groups.io
> Cc: Ke, VincentX ; Chiu, Chas
Reviewed-by: Chasel Chiu
Thanks,
Chasel
> -Original Message-
> From: Ni, Ray
> Sent: Wednesday, May 31, 2023 2:18 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
> ; Oram, Isaac W ;
> Gao, Liming ; Dong, Eric
> Subject:
Reviewed-by: Chasel Chiu
Thanks,
Chasel
> -Original Message-
> From: Ni, Ray
> Sent: Wednesday, May 24, 2023 5:29 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
> ; Oram, Isaac W ;
> Gao, Liming ; Dong, Eric
> Subject:
Patch merged:
https://github.com/tianocore/edk2-platforms/commit/b71f2bda9e4fc183068eef5d1d90a631181a2506
Thanks,
Chasel
> -Original Message-
> From: Shindo, Miki
> Sent: Tuesday, May 23, 2023 5:44 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nath
Reviewed-by: Chasel Chiu
Thanks,
Chasel
> -Original Message-
> From: Aishwarya, KurugoduMelmatamX
>
> Sent: Sunday, June 11, 2023 10:24 PM
> To: devel@edk2.groups.io
> Cc: Aishwarya, KurugoduMelmatamX
> ; Chiu, Chasel
> ; Desimone, Nathaniel L
> ; Duggapu
k2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
> ; Oram, Isaac W ;
> Gao, Liming ; Dong, Eric
> Subject: RE: [PATCH v9] MinPlatformPkg: Update HWSignature field in FACS
>
> Reviewed-by: Ankit Sinha
>
> Thank you,
> Ankit
>
> > -Original Message-
Reviewed-by: Chasel Chiu mailto:chasel.c...@intel.com>>
Thanks,
Chasel
From: Desimone, Nathaniel L
Sent: Tuesday, May 23, 2023 5:59 PM
To: Shindo, Miki ; devel@edk2.groups.io
Cc: Chiu, Chasel ; Gao, Liming
; Dong, Eric ; Zhang, Xiaoqiang
Subject: Re: [edk2-platforms:PA
Reviewed-by: Chasel Chiu
Thanks,
Chasel
> -Original Message-
> From: Tan, Ming
> Sent: Sunday, May 21, 2023 11:13 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Duggapu, Chinni B
>
> Subject: [PATCH] IntelFsp2WrapperPkg: Fix ASSERT when FSP-S/M use
Reviewed-by: Chasel Chiu
Thanks,
Chasel
> -Original Message-
> From: Hsueh, DoraX
> Sent: Monday, July 24, 2023 2:43 AM
> To: devel@edk2.groups.io
> Cc: Hsueh, DoraX ; Chiu, Chasel
> ; Desimone, Nathaniel L
> ; Oram, Isaac W ;
> Gao, Liming ; Dong, Eric ;
&g
Looks good to me. Thanks Ted!
Reviewed-by: Chasel Chiu
> -Original Message-
> From: Kuo, Ted
> Sent: Thursday, July 20, 2023 3:20 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
> ; Zeng, Star ; S, Ashraf
> Ali ; Duggapu, Chinni
Hello, edk2 stewards,
Could you please help this case?
Thanks,
Chasel
From: devel@edk2.groups.io On Behalf Of cbduggap
Sent: Sunday, June 18, 2023 10:28 PM
To: devel@edk2.groups.io
Subject: [edk2-devel] Need help to add me to the edk-ii-maintainers and
edk-ii-reviewers team
HI All
I signed
Patch merged:
https://github.com/tianocore/edk2/commit/ac33eee8b83999ba591af04fe22e773cf8fc8193
Thanks,
Chasel
> -Original Message-
> From: Aishwarya, KurugoduMelmatamX
>
> Sent: Sunday, June 11, 2023 10:24 PM
> To: devel@edk2.groups.io
> Cc: Aishwarya, Kurugodu
t; ; devel@edk2.groups.io; Kinney, Michael D
> ; Chiu, Chasel
> Cc: Desimone, Nathaniel L ; Kubacki, Michael
> ; Chaganty, Rangasai V
>
> Subject: Re: [edk2-devel] [edk2-platforms:PATCH V1]
> MinPlatformPkg/SaveMemoryConfig: Support NVS Data compression.
>
> Thanks for
backi via groups.io
> Sent: Tuesday, May 9, 2023 12:18 PM
> To: Chiu, Chasel ; Michael Kubacki
> ; Gudla, Raghava ;
> Oram, Isaac W ; devel@edk2.groups.io; Kinney,
> Michael D
> Cc: Desimone, Nathaniel L ; Chaganty,
> Rangasai V
> Subject: Re: [edk2-devel] [edk2-pla
Hi Michael,
Please also add CompressLib to CoreCommonLib.dsc to prevent build failure from
open source platforms.
Thanks,
Chasel
> -Original Message-
> From: Chiu, Chasel
> Sent: Tuesday, May 9, 2023 12:30 PM
> To: devel@edk2.groups.io; Kubacki, Michael ;
> Michael
Reviewed-by: Chasel Chiu
Thanks,
Chasel
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Michael
> Kubacki
> Sent: Tuesday, May 9, 2023 8:21 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
> ; Oram, Isaac W ;
>
t; FspNvsBuffer compression option
>
>
> Reviewed-by: Chasel Chiu
>
> Thanks,
> Chasel
>
>
>
> > -Original Message-
> > From: devel@edk2.groups.io On Behalf Of Michael
> > Kubacki
> > Sent: Tuesday, May 9, 2023 8:21 PM
> > To: d
: Oram, Isaac W
> Sent: Monday, May 8, 2023 12:15 PM
> To: Gudla, Raghava ; devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
> ; Kubacki, Michael
> ; Chaganty, Rangasai V
>
> Subject: RE: [edk2-platforms:PATCH V1] MinPlatformPkg/SaveMemoryConfig:
>
Reviewed-by: Chasel Chiu
Thanks,
Chasel
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Michael
> Kubacki
> Sent: Wednesday, May 10, 2023 8:02 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
> ; Oram, Isaac W ;
>
Thanks a lot Mike for your detail reviewing and providing better implementation
suggestions!
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Michael D
> Kinney
> Sent: Wednesday, May 10, 2023 9:00 AM
> To: Guo, Gua ; devel@edk2.groups.io; Gao, Liming
>
> Cc: Kinney,
Patch merged:
https://github.com/tianocore/edk2-platforms/commit/dbd802cd273ad1b51be46ca09a58a15e4b70863f
Thanks,
Chasel
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Michael
> Kubacki
> Sent: Wednesday, May 10, 2023 8:02 AM
> To: devel@edk2.group
Hello Andrew Fish,
Sorry that we seem to miss you from previous patch CC list mistakenly, please
help to review this series about new submodule we are adding and let us know if
any feedbacks.
Thanks,
Chasel
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Guo, Gua
>
Thanks Liming!
> -Original Message-
> From: gaoliming
> Sent: Sunday, May 14, 2023 6:01 PM
> To: devel@edk2.groups.io; Chiu, Chasel ; Guo, Gua
>
> Cc: 'Andrew Fish' ; 'Leif Lindholm'
> ; Kinney, Michael D
> Subject: 回复: [edk2-devel] [PATCH v1 0/1] Maintaine
Patch merged:
https://github.com/tianocore/edk2-platforms/commit/3c8ea51b1285c983fa81806d75a924d87cc7e732
Thanks,
Chasel
> -Original Message-
> From: Chen, Aryeh
> Sent: Wednesday, May 10, 2023 8:58 PM
> To: devel@edk2.groups.io
> Cc: Chen, Aryeh ; Chiu, Chas
Thanks Liming!
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of gaoliming
> via groups.io
> Sent: Thursday, May 11, 2023 7:45 PM
> To: Chiu, Chasel ; devel@edk2.groups.io; Guo, Gua
>
> Cc: 'Andrew Fish' ; 'Leif Lindholm'
> ; Kinney, Michael D
&g
Hi Liming,
PR has been updated with all RB:
https://github.com/tianocore/edk2/pull/4389/commits
Thanks,
Chasel
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Chiu, Chasel
> Sent: Friday, May 12, 2023 12:11 AM
> To: devel@edk2.groups.io; Gao, Liming ; Guo,
Hi Liming,
We are considering this is a missing when merging FdtLib support earlier.
Do we need to wait for Stewards approval for adding maintainers?
Thanks,
Chasel
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Guo, Gua
> Sent: Thursday, May 11, 2023 7:31 PM
> To:
Reviewed-by: Chasel Chiu
Thanks,
Chasel
> -Original Message-
> From: Guo, Gua
> Sent: Thursday, May 11, 2023 7:11 PM
> To: devel@edk2.groups.io
> Cc: Guo, Gua ; Kinney, Michael D
> ; Andrew Fish ; Leif Lindholm
> ; Lin, Benny ; Chiu, Chasel
> ; Lu, James
Reviewed-by: Chasel Chiu
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Guo, Gua
> Sent: Thursday, May 11, 2023 7:11 PM
> To: devel@edk2.groups.io
> Cc: Guo, Gua
> Subject: [edk2-devel] [PATCH v1 0/1] Maintainers.txt: Update reviewers and
> maintainer for FdtLib
>
>
) SwapBytes64 (x)
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Leif
> Lindholm
> Sent: Tuesday, May 2, 2023 4:42 AM
> To: devel@edk2.groups.io; Chiu, Chasel ; Kinney,
> Michael D
> Cc: Lin, Benny ; Gao, Liming
> ; Liu, Zhiguang ; Pedro
> Fa
Reviewed-by: Chasel Chiu
Thanks,
Chasel
> -Original Message-
> From: Chen, Aryeh
> Sent: Thursday, May 4, 2023 10:11 AM
> To: devel@edk2.groups.io
> Cc: Chen, Aryeh ; Chiu, Chasel
> ; Desimone, Nathaniel L
> ; Oram, Isaac W ;
> Gao, Liming ; Dong, Eric ;
Hi Mike,
Please see my reply below inline.
Thanks,
Chasel
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Michael D
> Kinney
> Sent: Thursday, May 4, 2023 11:02 AM
> To: Lin, Benny ; devel@edk2.groups.io
> Cc: Gao, Liming ; Liu, Zhiguang
> ; Pedro Falcato ; Kinney,
>
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4392
Add FDT support in EDK2 by submodule 3rd party libfdt
(https://github.com/devicetree-org/pylibfdt/tree/main/libfdt)
and refer to LibcLib implementation by Pedro.
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhiguang Liu
Cc: Sean Brogan
Cc:
From: Benny Lin
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4392
Add FDT support in EDK2 by submodule 3rd party libfdt
(https://github.com/devicetree-org/pylibfdt/tree/main/libfdt)
Add submodule libfdt and update ReadMe for the licence.
Reviewed-by: Leif Lindholm
Reviewed-by: Michael
From: Benny Lin
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4392
Add FDT support in EDK2 by submodule 3rd party libfdt
(https://github.com/devicetree-org/pylibfdt/tree/main/libfdt)
Add RequiredSubmodule object for CI setting.
Reviewed-by: Michael D Kinney
Cc: Sean Brogan
Cc: Michael
From: Benny Lin
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4392
Add FDT support in EDK2 by submodule 3rd party libfdt
(https://github.com/devicetree-org/pylibfdt/tree/main/libfdt)
and refer to LibcLib implementation by Pedro.
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhiguang Liu
Patch merged:
https://github.com/tianocore/edk2/commit/d992a05ade3d1bebc6e7a81aaf700286e0e217c8
Thanks,
Chasel
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Chiu, Chasel
> Sent: Monday, April 24, 2023 11:21 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Ch
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Chiu, Chasel
> Sent: Thursday, May 4, 2023 4:48 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Kinney, Michael D
> ; Gao, Liming ; Liu,
> Zhiguang ; Sean Brogan
> ; Michael Kubacki
> ; Pedro Falcato ;
>
This fix looks good to me! Thanks Ranbir!
Reviewed-by: Chasel Chiu
> -Original Message-
> From: Ranbir Singh
> Sent: Wednesday, May 17, 2023 11:29 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
> ; Zeng, Star ; Ranbir
> Singh
hael D
> Sent: Tuesday, May 2, 2023 10:39 PM
> To: Chiu, Chasel ; devel@edk2.groups.io;
> quic_llind...@quicinc.com
> Cc: Lin, Benny ; Gao, Liming
> ; Liu, Zhiguang ; Pedro
> Falcato ; Kinney, Michael D
>
> Subject: RE: [edk2-devel] [PATCH v3 2/3] MdePkg: Support FDT library.
Reviewed-by: Chasel Chiu
Thanks,
Chasel
> -Original Message-
> From: Haller, Nathaniel D
> Sent: Friday, February 16, 2024 5:47 PM
> To: devel@edk2.groups.io
> Cc: Desimone, Nathaniel L ; Chiu, Chasel
>
> Subject: [PATCH 1/2] Add maintainers for Eag
Reviewed-by: Chasel Chiu
Thanks,
Chasel
> -Original Message-
> From: Haller, Nathaniel D
> Sent: Friday, February 16, 2024 5:48 PM
> To: devel@edk2.groups.io
> Cc: Desimone, Nathaniel L ; Chiu, Chasel
>
> Subject: [PATCH 2/2] Update Maintainers for Intel
e-
> From: Clark-williams, Zachary
> Sent: Tuesday, February 20, 2024 1:42 PM
> To: devel@edk2.groups.io
> Cc: Clark-williams, Zachary ; Chiu, Chasel
> ; Desimone, Nathaniel L
> ; Liming Gao ;
> Dong, Eric
> Subject: [PATCH] MinPlatformPkg/DxePhatLib: Add to CoreCommon
801 - 900 of 934 matches
Mail list logo
