dule in the build scheduler and the module build fails if cache miss
>happen.
>
>Cc: Liming Gao
>Cc: Bob Feng
>Cc: Christian Rodriguez
>Signed-off-by: Steven Shi
>---
> BaseTools/Source/Python/build/build.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
&
ebuild which
>is very time-consuming. This patch is to entend the binary
>cache to support library.
>
>Cc: Liming Gao
>Cc: Bob Feng
>Cc: Christian Rodriguez
>Signed-off-by: Steven Shi
>---
> BaseTools/Source/Python/AutoGen/AutoGen.py | 17 ++---
> BaseTools/So
ra IO time is needed.
Christian Rodriguez (2):
BaseTools: Add a checking for Sources section in INF file
BaseTools: Refactor hash tracking after checking for Sources section
BaseTools/Source/Python/AutoGen/AutoGen.py | 6 +-
BaseTools/Source/Python/AutoGen/GenMake.py | 44 +
on that library or module.
Signed-off-by: Christian Rodriguez
Cc: Bob Feng
Cc: Liming Gao
Cc: Yonghong Zhu
---
BaseTools/Source/Python/AutoGen/AutoGen.py | 6 +-
BaseTools/Source/Python/AutoGen/GenMake.py | 6 ++
BaseTools/Source/Python/Common/GlobalData.py | 3 +-
BaseTools/Source/Python/build
cached in memory. No extra IO time is needed.
Signed-off-by: Christian Rodriguez
Cc: Bob Feng
Cc: Liming Gao
Cc: Yonghong Zhu
---
BaseTools/Source/Python/AutoGen/GenMake.py | 38
1 file changed, 38 insertions(+)
diff --git a/BaseTools/Source/Python/AutoGen/GenMake.py
b
Hey Leif,
I thought I'd help Bob and gather those BZs for each thread:
[Patch V4 1/2] BaseTools: Add a checking for Sources section in INF file
[Patch V4 2/2] BaseTools: Refactor hash tracking after checking for Sources
section
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1804
[PATCH v3
Please review. Bump.
>-Original Message-
>From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
>Christian Rodriguez
>Sent: Friday, May 24, 2019 7:40 AM
>To: devel@edk2.groups.io
>Cc: Feng, Bob C ; Gao, Liming
>; Zhu, Yonghong
>Subject: [e
Please review. Bump.
>-Original Message-
>From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
>Christian Rodriguez
>Sent: Friday, May 24, 2019 7:40 AM
>To: devel@edk2.groups.io
>Cc: Feng, Bob C ; Gao, Liming
>; Zhu, Yonghong
>Subject: [e
Hi Xiaoyu,
For your comment (1), I don't see a way to rule out headers using configdata. I
was already using configdata to get the include directories, but configdata
doesn't list the specific header files that will be used for compilation.
We can ignore things with a common name or specific
See below.
>-Original Message-
>From: Leif Lindholm [mailto:leif.lindh...@linaro.org]
>Sent: Thursday, May 30, 2019 9:38 AM
>To: Feng, Bob C
>Cc: Rodriguez, Christian ; Andrew Fish
>; Laszlo Ersek ; Kinney, Michael D
>; devel@edk2.groups.io; Gao, Liming
>; Shi, Steven ; Fan, ZhijuX
>
is why the Basetool can only store one arch cache
> >for
> >library.
> >This patch avoid to use the set() as the container to save the library and
> >module objects because the objects might have same __hash__ value.
> >
> >Cc: Liming Gao mailto:liming@intel.c
users of the
hash feature to be UEFI spec complaint.
What do you guys think; Laszlo and Felix?
I'll update the BZ when I get your input.
Thanks,
Christian Rodriguez
>-Original Message-
>From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
>Felix Polyudov
>Sent:
correctly
though the hashing system didn't know about it before.
Signed-off-by: Christian Rodriguez
Cc: Bob Feng
Cc: Liming Gao
Cc: Yonghong Zhu
---
BaseTools/Source/Python/AutoGen/AutoGen.py | 24
1 file changed, 24 insertions(+)
diff --git a/BaseTools/Source/Python
om this
>feature to cause the build to break when the hash feature is enabled. This
>would force users of the hash feature to be UEFI spec complaint.
>>
>> What do you guys think; Laszlo and Felix?
>>
>> I'll update the BZ when I get your input.
>>
>> T
>>>> After talking to my colleagues about this, the direction seems to be
>>>> to fundamentally change this BZ. Instead of building this sort of
>>>> workaround feature, we should use the information gathered from this
>>> feature to cause the build to brea
>>>> to fundamentally change this BZ. Instead of building this sort of
>>>> workaround feature, we should use the information gathered from this
>>> feature to cause the build to break when the hash feature is enabled.
>>> This would force users of t
Gao, Liming
>; Zhu, Yonghong
>Subject: Re: [edk2-devel] [PATCH] BaseTools: Include headers not mentioned
>in inf are not hashed
>
>On 05/13/19 20:53, Christian Rodriguez wrote:
>> I think a warning would be reasonable.
>>
>> I only mention the spec because it r
l@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
>Christian Rodriguez
>Sent: Monday, May 13, 2019 11:54 AM
>To: Laszlo Ersek ; devel@edk2.groups.io;
>fel...@ami.com
>Cc: Feng, Bob C ; Gao, Liming
>; Zhu, Yonghong
>Subject: Re: [edk2-devel] [PATCH] BaseTools: Include he
; (3) I think it's better to separate this patch into two.
>>Patch1. process_files.pl
>>Patch2. OpensslLib[Crypto].conf
>>
>>> -Original Message-
>>> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
>>> Christian Rodriguez
ink the condition of this check
>should be removed.
>Would you show the build time to see what's the performance impact if we
>always do this check?
>
>Thanks,
>Bob
>
>-Original Message-
>From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
>Chri
,
Christian
>-Original Message-
>From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
>Christian Rodriguez
>Sent: Thursday, May 23, 2019 9:06 AM
>To: devel@edk2.groups.io
>Cc: Feng, Bob C ; Gao, Liming
>; Zhu, Yonghong
>Subject: [edk2-devel] [Patch V2] B
ource" type files of a module. Performance
impact should be minimal with this patch since information is already
being fetched for Makefile purposes. All other information is already
cached in memory. No extra IO time is needed.
Signed-off-by: Christian Rodriguez
Cc: Bob Feng
Cc: Liming Gao
Cc
All other information is already
cached in memory. No extra IO time is needed.
Christian Rodriguez (2):
BaseTools: Add a checking for Sources section in INF file [Part 1/2]
BaseTools: Add a checking for Sources section in INF file [Part 2/2]
BaseTools/Source/Python/AutoGen/AutoGen.py | 6 +-
is hashing update.
Signed-off-by: Christian Rodriguez
Cc: Bob Feng
Cc: Liming Gao
Cc: Yonghong Zhu
---
BaseTools/Source/Python/AutoGen/AutoGen.py | 6 +-
BaseTools/Source/Python/AutoGen/GenMake.py | 6 ++
BaseTools/Source/Python/Common/GlobalData.py | 3 +-
BaseTools/Source/Python/buil
is checker only.
Signed-off-by: Christian Rodriguez
Cc: Bob Feng
Cc: Liming Gao
Cc: Yonghong Zhu
---
BaseTools/Source/Python/AutoGen/GenMake.py | 38
1 file changed, 38 insertions(+)
diff --git a/BaseTools/Source/Python/AutoGen/GenMake.py
b/BaseTools/Source/Python/AutoGen/
.
Added early escape as optimization, if hash already exists in memory.
Signed-off-by: Christian Rodriguez
Cc: Bob Feng
Cc: Liming Gao
Cc: Yonghong Zhu
---
BaseTools/Source/Python/AutoGen/AutoGen.py | 53
-
BaseTools/Source/Python/Common
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1680
Respect artifact location within directory structure.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Christian Rodriguez
Cc: Bob Feng
Cc: Liming Gao
Cc: Yonghong Zhu
---
BaseTools/Source/Python/AutoGen
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1680
Consider modules with .inc source files as Binary Modules
and do not Skip by hash.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Christian Rodriguez
Cc: Bob Feng
Cc: Liming Gao
Cc: Yonghong Zhu
---
BaseTools
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1680
Re-order hashing operations so we don't do redundant hashes.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Christian Rodriguez
Cc: Bob Feng
Cc: Liming Gao
Cc: Yonghong Zhu
---
BaseTools/Source/Python/AutoGen
.
Christian Rodriguez (4):
BaseTools: Fix corner-cases of --hash feature
BaseTools: Fix corner-cases of --hash feature
BaseTools: Fix corner-cases of --hash feature
BaseTools: Fix corner-cases of --hash feature
BaseTools/Source/Python/AutoGen/AutoGen.py | 47 +-
BaseTools/Source
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1692
Add error handling to the --hash feature so that hash files
are invalidated when a build error occurs.
Signed-off-by: Christian Rodriguez
Cc: Bob Feng
Cc: Liming Gao
Cc: Yonghong Zhu
---
BaseTools/Source/Python/Common/GlobalData.py
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1692
Change part of the hash error handling to invalidate hashes in the
cache destination not the cache source.
Signed-off-by: Christian Rodriguez
Cc: Bob Feng
Cc: Liming Gao
Cc: Yonghong Zhu
---
BaseTools/Source/Python/build/build.py | 4
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1726
V2: Added the platform name to the path
Add more level sub-directories in the database to support save
the cache for multiple platforms with multiple tool-chains and
targets, just like edk2 Build output.
Signed-off-by: Christian Rodriguez
.groups.io] On Behalf Of Christian
Rodriguez
Sent: Tuesday, April 16, 2019 12:41 PM
To: devel@edk2.groups.io
Cc: Feng, Bob C ; Gao, Liming ;
Zhu, Yonghong
Subject: [edk2-devel] [PATCH] BaseTools: Hash false success.. minor change in
hash invalidation
BZ: https://bugzilla.tianocore.org/show_bug.cgi
rs not mentioned
>in inf are not hashed
>
>Some questions inline.
>
>> -Original Message-
>> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
>> Christian Rodriguez
>> Sent: Thursday, May 09, 2019 2:27 PM
>> To: devel@edk2.groups.io
>
be minimal with this patch since information is already
being fetched for Makefile purposes. All other information is already
cached in memory. No extra IO time is needed.
Signed-off-by: Christian Rodriguez
Cc: Bob Feng
Cc: Liming Gao
Cc: Yonghong Zhu
---
BaseTools/Source/Python/AutoGen/AutoGen
compilance
of Edk2 INF Spec 3.9, which states, All HII Unicode format files
must be listed in [Sources] section. Not functional issue, just compilance.
Signed-off-by: Christian Rodriguez
Cc: Jian Wang
Cc: Ting Ye
Cc: Yonghong Zhu
---
CryptoPkg/Library/OpensslLib/OpensslLib.inf | 174
OpensslLib.inf and
OpensslLibCrypto.inf using the updated script. Enforce compilance
of Edk2 INF Spec 3.9, which states, All HII Unicode format files
must be listed in [Sources] section. Not functional issue, just compilance.
Signed-off-by: Christian Rodriguez
Cc: Jian Wang
Cc: Ting Ye
Cc: Yonghong
. So on a clean build, we now
generate the .hash after the library dependencies are complete.
Added early escape as optimization, if hash already exists in memory.
Signed-off-by: Christian Rodriguez
Cc: Bob Feng
Cc: Liming Gao
Cc: Yonghong Zhu
---
BaseTools/Source/Python/AutoGen/AutoGen.py
-by: Christian Rodriguez
Cc: Bob Feng
Cc: Liming Gao
Cc: Yonghong Zhu
---
BaseTools/Source/Python/AutoGen/AutoGen.py | 52
+++-
BaseTools/Source/Python/Common/GlobalData.py | 6 ++
BaseTools/Source/Python/build/build.py | 7 ++-
3 files
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1804
The check to see if [Sources] section lists all the header type
files of a module is missing the exclusion of source files that
fall under the scope of Package includes. This change adds the
exclusions.
Signed-off-by: Christian Rodriguez
For all 5 patches in patch set: Acked-by: Christian Rodriguez
>-Original Message-
>From: Shi, Steven
>Sent: Wednesday, August 14, 2019 11:11 AM
>To: devel@edk2.groups.io
>Cc: Gao, Liming ; Feng, Bob C
>; Rodriguez, Christian
>; Johnson, Michael
>; Shi, Steven
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1804
The check to see if [Sources] section lists all the header type
files of a module is missing the exclusion of source files that
fall under the scope of Package includes. This change adds the
exclusions.
Signed-off-by: Christian Rodriguez
anks,
>Bob
>
>
>-Original Message-
>From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
>Christian Rodriguez
>Sent: Thursday, August 1, 2019 11:33 PM
>To: devel@edk2.groups.io
>Cc: Feng, Bob C ; Gao, Liming
>
>Subject: [edk2-devel]
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1804
The check to see if [Sources] section lists all the header type
files of a module is missing the exclusion of source files that
fall under the scope of Package includes. This change adds the
exclusions.
Signed-off-by: Christian Rodriguez
45 matches
Mail list logo
