A Wu
Cc: Dandan Bi
Cc: Liming Gao
Cc: Debkumar De
Cc: Harry Han
Cc: Catharine West
Signed-off-by: Guomin Jiang
---
MdeModulePkg/Core/Pei/Dispatcher/Dispatcher.c | 15 +
MdeModulePkg/Core/Pei/PeiMain.h | 1 +
MdeModulePkg/Core/Pei/PeiMain.inf | 1
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1614
Introduces new changes to PeiCore to move the contents of temporary
RAM visible to the PeiCore to permanent memory. This expands on
pre-existing shadowing support in the PeiCore to perform the following
additional
From: Jian J Wang
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1614
Cc: Jian J Wang
Cc: Hao A Wu
Cc: Dandan Bi
Cc: Liming Gao
Signed-off-by: Jian J Wang
---
MdeModulePkg/Core/DxeIplPeim/DxeIpl.inf | 3 +++
MdeModulePkg/Core/DxeIplPeim/DxeLoad.c | 2 +-
2 files changed, 4
Ersek
Cc: Rahul Kumar
Cc: Jiewen Yao
Cc: Chao Zhang
Cc: Qi Zhang
Guomin Jiang (5):
MdeModulePkg/Core: Create Migrated FV Info Hob for calculating hash
(CVE-2019-11098)
SecurityPkg/Tcg2Pei: Use Migrated FV Info Hob for calculating hash
(CVE-2019-11098)
MdeModulePkg/Core: Add
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1614
Adds a PEIM that republishes structures produced in SEC. This
is done because SEC modules may not be shadowed in some platforms
due to space constraints or special alignment requirements. The
SecMigrationPei module
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1614
To avoid the TOCTOU, enable paging and set Not Present flag so when
access any code in the flash range, it will trigger #NP exception.
Cc: Eric Dong
Cc: Ray Ni
Cc: Laszlo Ersek
Cc: Rahul Kumar
Signed-off-by: Guomin Jiang
the hash and it use the Migrated FV Info.
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Chao Zhang
Cc: Qi Zhang
Cc: Rahul Kumar
Signed-off-by: Guomin Jiang
---
SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c | 31 ++---
SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.inf | 1 +
2 files changed, 29 insertions
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1614
Moves the GDT and IDT to permanent memory in a memory discovered
callback. This is done to ensure the GDT and IDT authenticated in
pre-memory is not fetched from outside a verified location after
the permanent memory
De
Cc: Harry Han
Cc: Catharine West
Signed-off-by: Guomin Jiang
---
MdeModulePkg/Core/Pei/PeiMain.inf | 1 +
MdeModulePkg/Core/Pei/PeiMain/PeiMain.c | 5 +++--
MdeModulePkg/MdeModulePkg.dec | 5 +
3 files changed, 9 insertions(+), 2 deletions(-)
diff --git a/MdeModulePkg
Hi everybody,
I am sorry for bothering you, I just want to reminder you that I want catch
those change up next stable tag.
So I hope that you can give me some comments or reviewed-by.
Appreciate it.
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Guomin
> Jia
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1614
SecMigrationPei create RepublishSecPpi, if the TOCTOU switch is off,
the Ppi is meaningless, so relate it with TOCTOU switch to avoid
producing useless PPI.
Cc: Eric Dong
Cc: Ray Ni
Cc: Laszlo Ersek
Cc: Rahul Kumar
Signed-off-by: Guomin
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1614
Adds a PEIM that republishes structures produced in SEC. This
is done because SEC modules may not be shadowed in some platforms
due to space constraints or special alignment requirements. The
SecMigrationPei module
Correct some typos.
Cc: Eric Dong
Cc: Ray Ni
Cc: Laszlo Ersek
Cc: Rahul Kumar
Signed-off-by: Guomin Jiang
---
UefiCpuPkg/CpuMpPei/CpuMpPei.h| 2 +-
.../Library/CpuExceptionHandlerLib/CpuExceptionCommon.h | 4 ++--
UefiCpuPkg/CpuMpPei/CpuPaging.c
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1614
Introduces new changes to PeiCore to move the contents of temporary
RAM visible to the PeiCore to permanent memory. This expands on
pre-existing shadowing support in the PeiCore to perform the following
additional
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1614
To avoid the TOCTOU, enable paging and set Not Present flag so when
access any code in the flash range, it will trigger #NP exception.
Cc: Eric Dong
Cc: Ray Ni
Cc: Laszlo Ersek
Cc: Rahul Kumar
Signed-off-by: Guomin Jiang
Acked
-by: Guomin Jiang
Acked-by: Laszlo Ersek
---
MdeModulePkg/MdeModulePkg.dec | 7 +++
MdeModulePkg/MdeModulePkg.uni | 6 ++
2 files changed, 13 insertions(+)
diff --git a/MdeModulePkg/MdeModulePkg.dec b/MdeModulePkg/MdeModulePkg.dec
index 843e963ad34b..16db17d0a873 100644
the hash and it use the Migrated FV Info.
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Chao Zhang
Cc: Qi Zhang
Cc: Rahul Kumar
Signed-off-by: Guomin Jiang
---
SecurityPkg/Tcg/TcgPei/TcgPei.inf | 1 +
SecurityPkg/Tcg/TcgPei/TcgPei.c | 29 +++--
2 files changed, 28 insertions(+), 2
the hash and it use the Migrated FV Info.
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Chao Zhang
Cc: Qi Zhang
Cc: Rahul Kumar
Signed-off-by: Guomin Jiang
---
SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.inf | 1 +
SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c | 31 ++---
2 files changed, 29 insertions
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1614
Moves the GDT and IDT to permanent memory in a memory discovered
callback. This is done to ensure the GDT and IDT authenticated in
pre-memory is not fetched from outside a verified location after
the permanent memory
will never produce when
PcdMigrateTemporaryRamFirmwareVolumes is FALSE, because the PCD control
the total feature.
Cc: Jian J Wang
Cc: Hao A Wu
Cc: Dandan Bi
Cc: Liming Gao
Cc: Debkumar De
Cc: Harry Han
Cc: Catharine West
Signed-off-by: Guomin Jiang
Acked-by: Laszlo Ersek
---
MdeModulePkg
Cc: Debkumar De
Cc: Harry Han
Cc: Catharine West
Cc: Eric Dong
Cc: Ray Ni
Cc: Jordan Justen
Cc: Andrew Fish
Cc: Laszlo Ersek
Cc: Ard Biesheuvel
Cc: Anthony Perard
Cc: Julien Grall
Cc: Leif Lindholm
Cc: Rahul Kumar
Cc: Jiewen Yao
Cc: Chao Zhang
Cc: Qi Zhang
Guomin Jiang (6
Upgrade openssl to 1.1.1g. the directory have been reorganized,
openssl moved crypto/include/internal to include/crypto folder.
So we change directory to match the re-organization.
Cc: Jian J Wang
Cc: Xiaoyu Lu
Signed-off-by: GuoMinJ
---
CryptoPkg/CryptoPkg.dec | 1 -
Hi Bret,
I plan to review it and give feedback before 7/31.
Thanks and Sorry for inconveniences.
Best Regards.
From: devel@edk2.groups.io On Behalf Of Bret Barkelew
via groups.io
Sent: Tuesday, June 9, 2020 1:52 PM
To: devel@edk2.groups.io; b...@corthon.com
Cc: Yao, Jiewen ; Zhang, Chao B ;
Hi Garrett,
Thanks for report quickly and it work and the 'Mac format issue disappear'.
But another build error occur 'error LNK2005: _InitializeFloatingPointUnits
already defined in FspSecCoreT.lib(InitializeFpu.obj)'
It seem that result by ApicLib who depend UefiCpuLib now.
I want to know
Hi Ard,
When build MinPlatform, it will show
Edk2Platforms/Platform/Intel/MinPlatformPkg/Pci/Library/PciSegmentInfoLibSimple/PciSegmentInfoLibSimple.c:34:1:
error: conflicting types for ‘GetPciSegmentInfo’
Could you confirm it?
Thanks
Guomin
> -Original Message-
> From:
Good work.
Reviewed-by: Guomin Jiang
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Zhang,
> Shenglei
> Sent: Monday, June 15, 2020 4:49 PM
> To: devel@edk2.groups.io
> Cc: Gao, Liming ; Kinney, Michael D
>
> Subject: [edk2-devel] [PATCH
Good work.
Reviewed-by: Guomin Jiang
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Zhang,
> Shenglei
> Sent: Monday, June 15, 2020 4:49 PM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J ; Lu, XiaoyuX
>
> Subject: [edk2-devel] [P
Good work.
Reviewed-by: Guomin Jiang
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Zhang,
> Shenglei
> Sent: Monday, June 15, 2020 4:49 PM
> To: devel@edk2.groups.io
> Cc: Ni, Ray
> Subject: [edk2-devel] [PATCH v4 08/17] FatPkg/FatPkg.ci.yaml
I think it have some vulnerability, the case as below.
1. Untrusted End User enroll the new DB key -> sign the untrusted device
firmware -> flash the untrusted device firmware -> the system will become
unsafe.
I think the end user is untrusted and we need to make sure only few person can
have
Good work.
Reviewed-by: Guomin Jiang
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Zhang,
> Shenglei
> Sent: Monday, June 15, 2020 4:49 PM
> To: devel@edk2.groups.io
> Cc: Ni, Ray
> Subject: [edk2-devel] [PATCH v4 13/17]
> PcAtChipsetPkg/PcA
Hi Huang,
Could you send the normal patch rather than RFC?
Best Regards
Guomin
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Ming
> Huang
> Sent: Monday, May 25, 2020 7:34 PM
> To: devel@edk2.groups.io; Wang, Jian J ; Wu, Hao A
> ; Gao, Liming
> Cc:
Hi Garrett,
I encounter below error when build
UefiCpuPkg\Library\BaseUefiCpuLib\BaseUefiCpuLib.c: warning C4335: Mac file
format detected: please convert the source file to either DOS or UNIX format'
I encounter the issue ever, it result by mail encoding.
To resolve this issue, you can run
Laszlo Ersek
> Sent: Tuesday, June 23, 2020 7:16 PM
> To: devel@edk2.groups.io; Jiang, Guomin ;
> garrett.kirkend...@amd.com
> Cc: Ni, Ray ; Dong, Eric
> Subject: Re: [edk2-devel] [PATCH v6 1/4] PcAtChipsetPkg:
> PcAtChipsetPkg.dsc add UefiCpuLib LibraryClass
>
> On 06/2
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1614
Moves the GDT to permanent memory in a memory discovered
callback. This is done to ensure the GDT authenticated in
pre-memory is not fetched from outside a verified location
after the permanent memory transition.
Cc:
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1614
To avoid the TOCTOU, enable paging and set Not Present flag so when
access any code in the flash range, it will trigger #PF exception.
Cc: Eric Dong
Cc: Ray Ni
Cc: Laszlo Ersek
Cc: Rahul Kumar
Signed-off-by: Guomin Jiang
Acked
will never produce when
PcdMigrateTemporaryRamFirmwareVolumes is FALSE, because the PCD control
the total feature.
Cc: Jian J Wang
Cc: Hao A Wu
Cc: Dandan Bi
Cc: Liming Gao
Cc: Debkumar De
Cc: Harry Han
Cc: Catharine West
Signed-off-by: Guomin Jiang
Acked-by: Laszlo Ersek
Reviewed-by: Jian J
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1614
Introduces new changes to PeiCore to move the contents of temporary
RAM visible to the PeiCore to permanent memory. This expands on
pre-existing shadowing support in the PeiCore to perform the following
additional
Correct some typos.
Cc: Eric Dong
Cc: Ray Ni
Cc: Laszlo Ersek
Cc: Rahul Kumar
Signed-off-by: Guomin Jiang
Reviewed-by: Laszlo Ersek
---
UefiCpuPkg/CpuMpPei/CpuMpPei.h| 2 +-
.../Library/CpuExceptionHandlerLib/CpuExceptionCommon.h | 4 ++--
UefiCpuPkg
the hash and it use the Migrated FV Info.
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Chao Zhang
Cc: Qi Zhang
Cc: Rahul Kumar
Signed-off-by: Guomin Jiang
Reviewed-by: Jian J Wang
Reviewed-by: Qi Zhang
---
SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.inf | 1 +
SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c | 31
the hash and it use the Migrated FV Info.
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Chao Zhang
Cc: Qi Zhang
Cc: Rahul Kumar
Signed-off-by: Guomin Jiang
Reviewed-by: Jian J Wang
Reviewed-by: Qi Zhang
---
SecurityPkg/Tcg/TcgPei/TcgPei.inf | 1 +
SecurityPkg/Tcg/TcgPei/TcgPei.c | 29
the PcdMigrateTemporaryRamFirmwareVolumes, always shadow
all PEIMs no matter the condition of PcdShadowPeimOnBoot or
PcdShadowPeimOnS3Boot.
Cc: Jian J Wang
Cc: Hao A Wu
Signed-off-by: Guomin Jiang
---
MdeModulePkg/MdeModulePkg.dec | 9 +
MdeModulePkg/MdeModulePkg.uni | 6 ++
2 files changed, 15 insertions
:
Change patch 10/10 to enhance the logic.
v8:
Drop the patch#10 added in v6 and v7, the optimization will be considered
future.
Guomin Jiang (6):
MdeModulePkg: Add new PCD to control the evacuate temporary memory
feature (CVE-2019-11098)
MdeModulePkg/Core: Create Migrated FV Info Hob
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1614
Adds a PEIM that republishes structures produced in SEC. This
is done because SEC modules may not be shadowed in some platforms
due to space constraints or special alignment requirements. The
SecMigrationPei module
> detects its missing.
>
>
> Thanks,
>
>
>
> >
> > Best Regards
> > Guomin
> >> -Original Message-
> >> From: Jeremy Linton
> >> Sent: Wednesday, July 15, 2020 8:19 AM
> >> To: Jiang, Guomin ; devel@edk2.groups.io
Add comments inline
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of
> Matthew Carlson
> Sent: Tuesday, July 28, 2020 9:53 AM
> To: devel@edk2.groups.io
> Cc: Yao, Jiewen ; Wang, Jian J
> ; Lu, XiaoyuX ; Matthew
> Carlson
> Subject: [edk2-devel] [PATCH v1 1/2] CryptoPkg:
Add myself as reviewer for CryptoPkg/ and *Capsule* and FmpDevicePkg/.
Signed-off-by: Guomin Jiang
Cc: Andrew Fish
Cc: Laszlo Ersek
Cc: Leif Lindholm
Cc: Michael D Kinney
---
Maintainers.txt | 3 +++
1 file changed, 3 insertions(+)
diff --git a/Maintainers.txt b/Maintainers.txt
index
lLib: Upgrade OpenSSL to
> 1.1.1g
>
> On 07/17/20 03:36, Guomin Jiang wrote:
> > Upgrade openssl to 1.1.1g. the directory have been reorganized,
> > openssl moved crypto/include/internal to include/crypto folder.
> > So we change directory to match the re-organization.
> &g
pts: Ignore the CRLF check when
> upgrade submodule.
>
> If the submodule is upgraded, skip the CRLF check as it isn't change for file.
>
> Signed-off-by: Guomin Jiang
> Cc: Bob Feng
> Cc: Liming Gao
> ---
> BaseTools/Scripts/PatchCheck.py | 2 +-
> 1 file changed, 1 insertion(
I would like that add BaseTols/Scripts/ to the PATH.
Usually, I use ```set PATH=%PATH%;%WORKSPACE%\BaseTools\Scripts``` to add new
directory to the environment variable.
But I suggest that we should judge if the last character in PATH variable is
';' character and then add new directory.
Let
I think the better subject is "Add configuration for avoiding License Conflict".
Anyway, it's good to me.
Reviewed-by: Guomin Jiang
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Zhang,
> Shenglei
> Sent: Monday, July 20, 2020 4:37 PM
> To:
I think the better subject is "Add configuration for avoiding License Conflict".
Anyway, it's good to me.
Reviewed-by: Guomin Jiang
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Zhang,
> Shenglei
> Sent: Monday, July 20, 2020 4:37 PM
> To:
When i upgrade openssl to 1.1.1g, error occurred when run PatchCheck.py.
The reason is that the submodule will end with LF, but it will check
based on file rule, it make no sense and need ignore the check.
Signed-off-by: Guomin Jiang
Cc: Bob Feng
Cc: Liming Gao
---
BaseTools/Scripts
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1614
Moves the GDT to permanent memory in a memory discovered
callback. This is done to ensure the GDT authenticated in
pre-memory is not fetched from outside a verified location
after the permanent memory transition.
Cc:
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1614
Introduces new changes to PeiCore to move the contents of temporary
RAM visible to the PeiCore to permanent memory. This expands on
pre-existing shadowing support in the PeiCore to perform the following
additional
Cc: Chao Zhang
Cc: Qi Zhang
Guomin Jiang (7):
MdeModulePkg: Add new PCD to control the evacuate temporary memory
feature (CVE-2019-11098)
MdeModulePkg/Core: Create Migrated FV Info Hob for calculating hash
(CVE-2019-11098)
SecurityPkg/Tcg2Pei: Use Migrated FV Info Hob
the hash and it use the Migrated FV Info.
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Chao Zhang
Cc: Qi Zhang
Cc: Rahul Kumar
Signed-off-by: Guomin Jiang
Reviewed-by: Jian J Wang
---
SecurityPkg/Tcg/TcgPei/TcgPei.inf | 1 +
SecurityPkg/Tcg/TcgPei/TcgPei.c | 29 +++--
2 files
valid
choice is to enable PcdMigrateTemporaryRamFirmwareVolumes and disable
PcdShadowPeimOnBoot.
Signed-off-by: Guomin Jiang
Cc: Jian J Wang
Cc: Hao A Wu
Cc: Dandan Bi
Cc: Liming Gao
Cc: Debkumar De
Cc: Harry Han
Cc: Catharine West
---
MdeModulePkg/Core/Pei/Dispatcher/Dispatcher.c | 11
Correct some typos.
Cc: Eric Dong
Cc: Ray Ni
Cc: Laszlo Ersek
Cc: Rahul Kumar
Signed-off-by: Guomin Jiang
Reviewed-by: Laszlo Ersek
---
UefiCpuPkg/CpuMpPei/CpuMpPei.h| 2 +-
.../Library/CpuExceptionHandlerLib/CpuExceptionCommon.h | 4 ++--
UefiCpuPkg
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1614
Adds a PEIM that republishes structures produced in SEC. This
is done because SEC modules may not be shadowed in some platforms
due to space constraints or special alignment requirements. The
SecMigrationPei module
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1614
To avoid the TOCTOU, enable paging and set Not Present flag so when
access any code in the flash range, it will trigger #PF exception.
Cc: Eric Dong
Cc: Ray Ni
Cc: Laszlo Ersek
Cc: Rahul Kumar
Signed-off-by: Guomin Jiang
Acked
will never produce when
PcdMigrateTemporaryRamFirmwareVolumes is FALSE, because the PCD control
the total feature.
Cc: Jian J Wang
Cc: Hao A Wu
Cc: Dandan Bi
Cc: Liming Gao
Cc: Debkumar De
Cc: Harry Han
Cc: Catharine West
Signed-off-by: Guomin Jiang
Acked-by: Laszlo Ersek
---
MdeModulePkg
the hash and it use the Migrated FV Info.
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Chao Zhang
Cc: Qi Zhang
Cc: Rahul Kumar
Signed-off-by: Guomin Jiang
Reviewed-by: Jian J Wang
---
SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.inf | 1 +
SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c | 31 ++---
2 files
-by: Guomin Jiang
Acked-by: Laszlo Ersek
Reviewed-by: Jian J Wang
---
MdeModulePkg/MdeModulePkg.dec | 8
MdeModulePkg/MdeModulePkg.uni | 6 ++
2 files changed, 14 insertions(+)
diff --git a/MdeModulePkg/MdeModulePkg.dec b/MdeModulePkg/MdeModulePkg.dec
index 843e963ad34b
: Feng, Bob C ; Gao, Liming
>
> Subject: [PATCH 1/1] BaseTools/Scripts: Ignore the CRLF check when upgrade
> submodule.
>
> When i upgrade openssl to 1.1.1g, error occurred when run PatchCheck.py.
> The reason is that the submodule will end with LF, but it will check based on
&g
practice it directly.
2. It seem that you just send the wiki for review and it will merge into
github.io wiki eventually, am I right?
Anyway, it's very good.
Tested-by: Guomin Jiang
Acked-by: Guomin Jiang
> -Original Message-
> From: Michael Kubacki
> Sent: Thursday, July 30, 202
Can you explain the -Wno-error=format? I haven't search the switch from google.
Appreciate it.
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Abner
> Chang
> Sent: Thursday, July 16, 2020 10:55 PM
> To: devel@edk2.groups.io
> Cc: abner.ch...@hpe.com; Wang, Jian J ; Lu,
>
v2:
Change the process_files.pl to convert the EOL automatically so the
generated file will be CRLF format.
Cc: Jian J Wang
Cc: Xiaoyu Lu
Guomin Jiang (1):
CryptoPkg/OpensslLib: Upgrade OpenSSL to 1.1.1g
CryptoPkg/CryptoPkg.dec | 1 -
CryptoPkg/Library/OpensslLib
automatically.
Cc: Jian J Wang
Cc: Xiaoyu Lu
Signed-off-by: Guomin Jiang
Reviewed-by: Laszlo Ersek
Tested-by: Laszlo Ersek
---
CryptoPkg/CryptoPkg.dec | 1 -
CryptoPkg/Library/OpensslLib/OpensslLib.inf | 58 +--
.../Library/OpensslLib/OpensslLibCrypto.inf | 50
It seem that you use some PCD directly but haven't declare it in DEC file as
below error.
File
"/home/git/sw-edkII/edkII/BaseTools/Source/Python/Workspace/DecBuildData.py",
line 468, in _GetPcd
EdkLogger.error("build", PCD_STRUCTURE_PCD_ERROR, "The structure Pcd %s.%s
header file is not
-by: Guomin Jiang
Cc: Eric Dong
Cc: Ray Ni
Cc: Laszlo Ersek
Cc: Rahul Kumar
Cc: Debkumar De
Cc: Harry Han
Cc: Catharine West
---
UefiCpuPkg/SecCore/SecCore.inf | 1 +
UefiCpuPkg/CpuMpPei/CpuMpPei.c | 37 ---
UefiCpuPkg/CpuMpPei/CpuPaging.c | 8 --
UefiCpuPkg
-by: Guomin Jiang
Cc: Eric Dong
Cc: Ray Ni
Cc: Laszlo Ersek
Cc: Rahul Kumar
Cc: Debkumar De
Cc: Harry Han
Cc: Catharine West
---
UefiCpuPkg/CpuMpPei/CpuMpPei.inf | 1 -
UefiCpuPkg/SecCore/SecCore.inf | 1 +
UefiCpuPkg/CpuMpPei/CpuMpPei.c | 37 --
UefiCpuPkg
Reviewed-by: Guomin Jiang
> -Original Message-
> From: Kuo, IanX
> Sent: Monday, October 18, 2021 12:21 PM
> To: devel@edk2.groups.io
> Cc: Chan, Amy ; Ni, Ray ; Kuo,
> IanX ; Yao, Jiewen ; Wang,
> Jian J ; Lu, XiaoyuX ; Jiang,
> Guomin
> Subject: [PATCH v6 2
.
Signed-off-by: Guomin Jiang
Cc: Jiewen Yao
Cc: Jian J Wang
---
SecurityPkg/FvReportPei/FvReportPei.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/SecurityPkg/FvReportPei/FvReportPei.c
b/SecurityPkg/FvReportPei/FvReportPei.c
index 9f3ebd8ed174..6dce3298e3a2 100644
.
Signed-off-by: Guomin Jiang
Cc: Jiewen Yao
Cc: Jian J Wang
---
SecurityPkg/FvReportPei/FvReportPei.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/SecurityPkg/FvReportPei/FvReportPei.c
b/SecurityPkg/FvReportPei/FvReportPei.c
index 9f3ebd8ed174..6dce3298e3a2 100644
Always install the SmmAccessPpi without checking S3 boot mode.
The caller can add the S3 check to decide if it is need to install the
Ppi
Signed-off-by: Guomin Jiang
Cc: Ray Ni
Cc: Rangasai V Chaganty
---
.../PeiSmmAccessLib/PeiSmmAccessLib.inf | 40 ---
.../Library
by DxeCore to install
LoadedImage.
4. So it will create the mismatched ModuleInfo for DxeCore.
Changes:
1. When found the ModuleInfo, update it with DxeCore Info only.
2. Create new ModuleInfo if found no ModuleInfo.
Signed-off-by: Guomin Jiang
Cc: Guo Dong
Cc: Ray Ni
Cc: Maurice Ma
Cc
the ModuleInfo from the DxeIpl to avoid
the mismatched ModuleInfo for DxeCore.
Changes:
1. Use function IsHobNeed to check if the HOB should be added
2. Add the ModuleInfo check logic in IsHobNeed function
Signed-off-by: Guomin Jiang
Cc: Guo Dong
Cc: Ray Ni
Cc: Maurice Ma
Cc: Benjamin You
Reviewed-by: Guomin Jiang
Guomin
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of
> Zhiguang Liu
> Sent: Monday, January 10, 2022 11:26 AM
> To: devel@edk2.groups.io
> Cc: Gao, Liming
> Subject: [edk2-devel] [PATCH] Wiki: Add optional steps for devel
From: GuoMinJ
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2368
Remove All UGA Support in MdeModulePkg, first remove from library.
Remove the PcdConOutGopSupport definition.
Signed-off-by: Guomin Jiang
Cc: Jian J Wang
Cc: Liming Gao
Cc: Zhichao Gao
Cc: Ray Ni
Cc: Hao A Wu
From: GuoMinJ
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2368
Remove all UGA support in BaseTools package.
Signed-off-by: Guomin Jiang
Cc: Bob Feng
Cc: Liming Gao
Cc: Yuwei Chen
---
.../Source/C/Include/Protocol/HiiFramework.h | 53 +-
BaseTools/Source/C/Include/Protocol
From: GuoMinJ
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2368
Remove All UGA Support in MdePkg.
Signed-off-by: Guomin Jiang
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhiguang Liu
---
MdePkg/MdePkg.dec| 12 --
MdePkg/MdePkg.dsc| 3
From: GuoMinJ
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2368
Remove the PcdConOutGopSupport, it is unnecessary any more.
Remove All UGA Support in ConSplitterDxe component.
Signed-off-by: Guomin Jiang
Cc: Jian J Wang
Cc: Liming Gao
Cc: Zhichao Gao
Cc: Ray Ni
---
.../Console
From: GuoMinJ
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2368
Remove All UGA Support in GraphicsConsoleDxe, remove comment about UGA
in HiiDatabaseDxe.
Signed-off-by: Guomin Jiang
Cc: Jian J Wang
Cc: Liming Gao
Cc: Zhichao Gao
Cc: Ray Ni
Cc: Dandan Bi
Cc: Eric Dong
From: GuoMinJ
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2368
Remove All UGA Support in EmulatorPkg.
Signed-off-by: Guomin Jiang
Cc: Andrew Fish
Cc: Ray Ni
---
EmulatorPkg/EmuGopDxe/Gop.h | 10 +--
EmulatorPkg/Include/Protocol/EmuFileSystem.h | 24
From: GuoMinJ
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2368
Remove All UGA Support in ShellPkg.
Signed-off-by: Guomin Jiang
Cc: Ray Ni
Cc: Zhichao Gao
---
.../Library/UefiHandleParsingLib/UefiHandleParsingLib.inf | 4 +---
ShellPkg/Library/UefiHandleParsingLib
From: GuoMinJ
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2368
Delete PcdConOutGopSupport, it is unnecessary any more.
Signed-off-by: Guomin Jiang
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Jordan Justen
Cc: Gerd Hoffmann
Cc: Anthony Perard
Cc: Julien Grall
---
OvmfPkg/AmdSev
From: GuoMinJ
REF: https//bugzilla.tianocore.org/show_bug.cgi?id=2368
Remove PcdConOutGopSupport, it is unnecessary any more.
Remove All UGA Support in UefiPayloadPkg.
Signed-off-by: Guomin Jiang
Cc: Guo Dong
Cc: Ray Ni
Cc: Maurice Ma
Cc: Benjamin You
---
UefiPayloadPkg
REF: https//bugzilla.tianocore.org/show_bug.cgi?id=2368
Remove UGA protocol support and only support GOP protocol
GOP is modern graphic protocol of EDK2 and UGA is deprecated in fact.
GuoMinJ (11):
UefiPayloadPkg: Remove All UGA Support
ArmVirtPkg: Remove All UGA Support
ArmPkg: Remove All
From: GuoMinJ
REF: https//bugzilla.tianocore.org/show_bug.cgi?id=2368
Remove PcdConOutGopSupport, it is unnecessary any more.
Remove All UGA Support in ArmVirtPkg
Signed-off-by: Guomin Jiang
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Cc: Sami Mujawar
Cc: Gerd Hoffmann
---
ArmVirtPkg
From: GuoMinJ
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2368
Remove All UGA Support in ArmPkg.
Signed-off-by: Guomin Jiang
Cc: Leif Lindholm
Cc: Ard Biesheuvel
---
.../Library/PlatformBootManagerLib/PlatformBootManagerLib.inf | 3 ---
ArmPkg/Library/PlatformBootManagerLib
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2368
Remove all UGA support in PurleyOpenBoardPkg
Cc: Nate DeSimone
Cc: Chasel Chiu
Signed-off-by: Guomin Jiang
---
.../Library/BoardBdsHookLib/BoardBdsHook.h| 70 +--
1 file changed, 33 insertions(+), 37 deletions
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2368
Remove all UGA support
Cc: Eric Dong
Cc: Liming Gao
Signed-off-by: Guomin Jiang
---
.../Library/BoardBdsHookLib/BoardBdsHook.h| 70 +--
1 file changed, 33 insertions(+), 37 deletions(-)
diff --git
a/Platform/Intel
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2368
Remove all UGA support
Cc: Ray Ni
Signed-off-by: Guomin Jiang
---
.../CirrusLogic5430Dxe/CirrusLogic5430.c | 522 +++---
.../CirrusLogic5430Dxe/CirrusLogic5430.h | 136 ++---
.../CirrusLogic5430Dxe
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2368
Remove all UGA support
Cc: Nate DeSimone
Cc: Chasel Chiu
Cc: Eric Dong
Cc: Liming Gao
Cc: Ray Ni
Guomin Jiang (3):
PurleyOpenBoardPkg: Remove All UGA support
BoardModulePkg: Remove all UGA support
OptionRomPkg: Remove all UGA
Hi Kinney, Liming, Zhiguang,
Can you give comments on this patch
Thanks
Guomin
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Guomin
> Jiang
> Sent: Friday, February 18, 2022 10:30 AM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D ; Gao, Liming
Hi Liming, Jian, Zhichao, Ray,
Can you help review it?
Thanks
Guomin
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Guomin
> Jiang
> Sent: Tuesday, February 22, 2022 11:41 AM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J ; Gao, Liming
> ; Gao
Hi Fish and Ray,
Can you help review it?
Thanks
Guomin
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Guomin
> Jiang
> Sent: Tuesday, February 22, 2022 11:41 AM
> To: devel@edk2.groups.io
> Cc: Andrew Fish ; Ni, Ray
> Subject: [edk2-devel] [P
uild when file path is long 2. We
> hope can reduce the size but not impact the debug capability 3. If only use
> filename, we can search the filename to locate file. It
>can save many size meanwhile.
>
> Cc: Bob Feng
> Cc: Liming Gao
> Cc: Yuwei Chen
> Signed-off-by:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2668
WindowOpen will fail in some case. for example, without XServer.
Shouldn't set ModeInfo in this case to avoid the caller use it
incorrectly
Cc: Andrew Fish
Cc: Ray Ni
Signed-off-by: Guomin Jiang
---
EmulatorPkg/EmuGopDxe/GopScreen.c
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2668
Correct the logic to handle the case that XServer not present to avoid
Segmentation fault
V2:
Fix typo error.
Guomin Jiang (2):
MdeModulePkg/GraphicsConsoleDxe: Check status to make sure no error
EmulatorPkg/EmuGopDxe: Set ModeInfo
201 - 300 of 341 matches
Mail list logo
