[edk2-devel] [PATCH 2/2] Platform/Intel: Cleanup temporary build workaround related code

2020-04-23 Thread Heng Luo
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2688 Use AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc instead of AdvancedFeaturePkg/TemporaryBuildWorkaround/TemporaryBuildWorkaround.dsc Cc: Michael Kubacki Cc: Liming Gao Cc: Eric Dong Cc: Ray Ni Signed-off-by: Heng Luo

Re: [edk2-devel] [PATCH] Platform/Intel/Tools: Add scripts to set PACKAGES_PATH environment

2020-04-14 Thread Heng Luo
kagesPath.sh, these scripts > > call GetPackagesPath.py to collect all package paths under specified > > directories and append them to PACKAGES_PATH environment variable. > > > > Cc: Ray Ni > > Cc: Eric Dong

[edk2-devel] [PATCH] Platform/Intel/Tools: Add scripts to set PACKAGES_PATH environment

2020-04-09 Thread Heng Luo
, these scripts call GetPackagesPath.py to collect all package paths under specified directories and append them to PACKAGES_PATH environment variable. Cc: Ray Ni Cc: Eric Dong Cc: Liming Gao Cc: Bob Feng Cc: Amy Chan Signed-off-by: Heng Luo --- Platform/Intel/Tools/AppendPackagesPath

[edk2-devel] [PATCH] BaseTools/Scripts: Add scripts to set PACKAGES_PATH environment

2020-04-02 Thread Heng Luo
, these scripts call GetPackagesPath.py to collect all package paths under specified directories and append them to PACKAGES_PATH environment variable. Cc: Ray Ni Cc: Eric Dong Cc: Liming Gao Cc: Bob Feng Cc: Amy Chan Signed-off-by: Heng Luo --- BaseTools/Scripts/GetPackagesPath.py | 94

[edk2-devel] [Patch V2 0/3] Fix build error of OpenBoard

2020-03-30 Thread Heng Luo
*** BLURB HERE *** Heng Luo (3): Platform/Intel: Add all pathes of feature domains to package path Features/Intel: Add LogoFeaturePkg to TemporaryBuildWorkaround Features/Intel: Correct wrong codes and remove unnecessary codes Features/Intel/AdvancedFeaturePkg/TemporaryBuildWorkaround

[edk2-devel] [Patch V2 1/3] Platform/Intel: Add all pathes of feature domains to package path

2020-03-30 Thread Heng Luo
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2644 Add all pathes of feature domains to package path in build_bios.py. Cc: Dandan Bi Cc: Liming Gao Cc: Eric Dong Cc: Ray Ni Signed-off-by: Heng Luo --- Notes: v2: - Skip adding folders that contains package contents

[edk2-devel] [Patch V2 3/3] Features/Intel: Correct wrong codes and remove unnecessary codes

2020-03-30 Thread Heng Luo
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2644 Correct wrong codes and remove unnecessary codes in LogoFeaturePkg. Cc: Dandan Bi Cc: Liming Gao Cc: Eric Dong Cc: Ray Ni Signed-off-by: Heng Luo --- Features/Intel/UserInterface/LogoFeaturePkg/Include/LogoFeature.dsc | 9

[edk2-devel] [Patch V2 2/3] Features/Intel: Add LogoFeaturePkg to TemporaryBuildWorkaround

2020-03-30 Thread Heng Luo
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2644 Need to add LogoFeaturePkg to TemporaryBuildWorkaround because OpenBoard still includes TemporaryBuildWorkaround for building BIOS. Cc: Dandan Bi Cc: Liming Gao Cc: Eric Dong Cc: Ray Ni Signed-off-by: Heng Luo --- Features/Intel

Re: [edk2-devel] [PATCH 1/3] Platform/Intel: Add all pathes of feature domains to package path

2020-03-30 Thread Heng Luo
OK, it means we just need to check dec file Best Regards Heng > -Original Message- > From: Gao, Liming > Sent: Tuesday, March 31, 2020 10:52 AM > To: Luo, Heng ; Ni, Ray ; > devel@edk2.groups.io > Cc: Bi, Dandan ; Dong, Eric > Subject: RE: [PATCH 1/3] Platform/Intel: Add all pathes of

Re: [edk2-devel] [PATCH 1/3] Platform/Intel: Add all pathes of feature domains to package path

2020-03-30 Thread Heng Luo
Hi Liming, I will apply the change below if you agree to we treat a folder that contains ".dec" and "dsc" files as a package directory: diff --git a/Platform/Intel/build_bios.py b/Platform/Intel/build_bios.py index b9ad980510..bb25699ed8 100644 --- a/Platform/Intel/build_bios.py +++

[edk2-devel] [PATCH 2/3] Features/Intel: Add LogoFeaturePkg to TemporaryBuildWorkaround

2020-03-30 Thread Heng Luo
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2644 Need to add LogoFeaturePkg to TemporaryBuildWorkaround because OpenBoard still includes TemporaryBuildWorkaround for building BIOS. Cc: Dandan Bi Cc: Liming Gao Cc: Eric Dong Cc: Ray Ni Signed-off-by: Heng Luo --- Features/Intel

[edk2-devel] [PATCH 1/3] Platform/Intel: Add all pathes of feature domains to package path

2020-03-30 Thread Heng Luo
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2644 Add all pathes of feature domains to package path in build_bios.py. Cc: Dandan Bi Cc: Liming Gao Cc: Eric Dong Cc: Ray Ni Signed-off-by: Heng Luo --- Platform/Intel/build_bios.py | 7 ++- 1 file changed, 6 insertions(+), 1

[edk2-devel] [PATCH 0/3] Fix build error of OpenBoard

2020-03-30 Thread Heng Luo
*** BLURB HERE *** Heng Luo (3): Platform/Intel: Add all pathes of feature domains to package path Features/Intel: Add LogoFeaturePkg to TemporaryBuildWorkaround Features/Intel: Correct wrong codes and remove unnecessary codes Features/Intel/AdvancedFeaturePkg/TemporaryBuildWorkaround

[edk2-devel] [PATCH 3/3] Features/Intel: Correct wrong codes and remove unnecessary codes

2020-03-30 Thread Heng Luo
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2644 Correct wrong codes and remove unnecessary codes in LogoFeaturePkg. Cc: Dandan Bi Cc: Liming Gao Cc: Eric Dong Cc: Ray Ni Signed-off-by: Heng Luo --- Features/Intel/UserInterface/LogoFeaturePkg/Include/LogoFeature.dsc | 9

Re: [edk2-devel] [PATCH] Fix build error of OpenBoard caused by change of AdvancedFeaturePkg

2020-03-29 Thread Heng Luo
gt; > > > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2644 > > > > 1. Add all pathes of feature domains to package path. > > 2. Add LogoFeaturePkg to TemporaryBuildWorkaround. > > 3. Correct wrong codes and remove unnecessary codes in LogoFeaturePkg > > >

[edk2-devel] [PATCH] Fix build error of OpenBoard caused by change of AdvancedFeaturePkg

2020-03-29 Thread Heng Luo
-off-by: Heng Luo --- Features/Intel/AdvancedFeaturePkg/TemporaryBuildWorkaround/TemporaryBuildWorkaround.dsc | 4 +++- Features/Intel/AdvancedFeaturePkg/TemporaryBuildWorkaround/TemporaryBuildWorkaround.inf | 5 - Features/Intel/UserInterface/LogoFeaturePkg/Include/LogoFeature.dsc

[edk2-devel] [Patch V3] Features/Intel: Add LogoFeaturePkg to provide logo images and drivers

2020-03-25 Thread Heng Luo
EFI_HII_IMAGE_DECODER_PROTOCOL to decode the Jpeg file and provide the image via EDKII_PLATFORM_LOGO_PROTOCOL. Cc: Dandan Bi Cc: Liming Gao Cc: Eric Dong Cc: Ray Ni Signed-off-by: Heng Luo --- Notes: v3: - Remove the feature-domain prefix "UserInterface" from all paths inside DSC/FDF/IN

Re: [edk2-devel] [Patch V2] Features/Intel: Add LogoFeaturePkg to provide logo images and drivers

2020-03-25 Thread Heng Luo
; Heng, > > > Can you please remove the prefix from all paths inside > > > DSC/FDF/INF? > > > > > > We expect PACKAGES_PATH is set to include "edk2- > platforms/Features/Intel" > > > and all sub folders inside "edk2-platforms/Feature

Re: [edk2-devel] [Patch V2] Features/Intel: Add LogoFeaturePkg to provide logo images and drivers

2020-03-25 Thread Heng Luo
x from all paths inside > DSC/FDF/INF? > > We expect PACKAGES_PATH is set to include "edk2-platforms/Features/Intel" > and all sub folders inside "edk2-platforms/Features/Intel/". > > Thanks, > Ray > > > > -Original Message- > >

[edk2-devel] [Patch V2] Features/Intel: Add LogoFeaturePkg to provide logo images and drivers

2020-03-24 Thread Heng Luo
EFI_HII_IMAGE_DECODER_PROTOCOL to decode the Jpeg file and provide the image via EDKII_PLATFORM_LOGO_PROTOCOL. Cc: Dandan Bi Cc: Liming Gao Cc: Eric Dong Signed-off-by: Heng Luo --- Notes: v2: - Add Cc and Remove Change-Id in commit message Features/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc

Re: [edk2-devel] [PATCH] Features/Intel: Add LogoFeaturePkg to provide logo images and drivers

2020-03-24 Thread Heng Luo
with > VS2015 & GCC5? > > Thanks > Liming > > -Original Message----- > > From: devel@edk2.groups.io On Behalf Of Heng > Luo > > Sent: Thursday, March 19, 2020 11:04 AM > > To: devel@edk2.groups.io > > Subject: [edk2-devel] [PATCH] Features

[edk2-devel] [PATCH] Features/Intel: Add LogoFeaturePkg to provide logo images and drivers

2020-03-18 Thread Heng Luo
EFI_HII_IMAGE_DECODER_PROTOCOL to decode the Jpeg file and provide the image via EDKII_PLATFORM_LOGO_PROTOCOL. Change-Id: Ie7b91d34c31b09a86f02634d3a1aa4d39637bb54 Signed-off-by: Heng Luo --- .../AdvancedFeaturePkg/AdvancedFeaturePkg.dsc | 4 +- .../Include/AdvancedFeatures.dsc | 6

[edk2-devel] [PATCH] MdeModulePkg: Perform test only if not ignore memory test

2020-01-14 Thread Heng Luo
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2463 Perform Data and Address line test only if not ignore memory test. Signed-off-by: Heng Luo --- .../MemoryTest/GenericMemoryTestDxe/LightMemoryTest.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git

<    1   2   3