-platforms.git/tree/Platform/QemuVirt/PlatformStandaloneMm.dsc?h=stmm_reloc_combined
[4]
https://git.linaro.org/people/ilias.apalodimas/edk2-platforms.git/tree/Silicon/QemuVirt/Drivers/OpTeeRpmbFv/OpTeeRpmbFv.c?h=stmm_reloc_combined
Signed-off-by: Ilias Apalodimas
---
StandaloneMmPkg/Core/Scripts/StMM
erform the runtime relocation, we need to remap the
> header page writable and non-executable as well.
>
> The remaining patches are optimizations and fixes I picked up along
> the way.
>
> Cc: Michael D Kinney
> Cc: Liming Gao
> Cc: Jiewen Yao
> Cc: Sami Mujawar
&
ks for the pointers!
/Ilias
>
> Thank you
> Yao Jiewen
>
>
> > -Original Message-
> > From: Ilias Apalodimas
> > Sent: Saturday, June 6, 2020 4:52 PM
> > To: ard.biesheu...@arm.com; sami.muja...@arm.com; Yao, Jiewen
> > ; supreeth.venkat...@arm.c
Hi Sami,
[...]
> > +STATIC
> > +EFI_STATUS
> > +ReadWriteRpmb (
> > + UINTN SvcAct,
> > + UINTN Addr,
> > + UINTN NumBytes,
> > + UINTN Offset
> > + )
> > +{
> > + ARM_SVC_ARGS SvcArgs;
> > + EFI_STATUSStatus;
> > +
> > + ZeroMem (, sizeof (SvcArgs));
> > +
> > + SvcArgs.Arg0 =
ked [SAMI].
>
> Regards,
>
> Sami Mujawar
>
> -Original Message-
> From: Sughosh Ganu
> Sent: 16 December 2020 11:09 AM
> To: devel@edk2.groups.io
> Cc: Sami Mujawar ; Ard Biesheuvel
> ; Leif Lindholm ; Sahil Malhotra
> ; Ilias Apalodimas
> Subject: [PATC
; Reviewed-by: Sami Mujawar
>
> Regards,
>
> Sami Mujawar
>
> -Original Message-
> From: Sughosh Ganu
> Sent: 16 December 2020 11:09 AM
> To: devel@edk2.groups.io
> Cc: Sami Mujawar ; Ard Biesheuvel
> ; Leif Lindholm ; Sahil Malhotra
> ; Ilias Apalodimas
Hi Sami,
Inlining some additional info on my explanation.
> > >
[...]
> > > I actually picked up the error handling from the previous non-FFA code.
> > > I'll check what's on Sughosh latest patches and fix it if there are
> > > any differences.
> > > Looking at it again EFI_BAD_BUFFER_SIZE can
Hi Sami,
On Tue, Feb 02, 2021 at 10:40:32AM +, Sami Mujawar wrote:
> Hi Ilias,
>
> Please see my response inline marked [SAMI].
>
> Regards,
>
> Sami Mujawar
>
> -Original Message-----
> From: Ilias Apalodimas
> Sent: 01 February 2021 02:01 PM
>
Hi Sami,
On Tue, 2 Feb 2021 at 17:13, Sami Mujawar wrote:
>
> Hi Ilias,
>
> Please see my response inline marked [SAMI].
>
> Regards,
>
> Sami Mujawar
>
> -Original Message-
> From: Ilias Apalodimas
> Sent: 02 February 2021 02:50 PM
> To: Sami M
Changes since V2:
- Allocate a dynamic number of pages based on the Pcd values instead
of a static number
- Clean up unused structs in header file
- Added checks in OpTeeRpmbFvbGetBlockSize and handle NumLba=0
Changes since V1:
Some enhancements made by Ilias to the Optee Rpmb driver
Ilias
and patches the PCDs, while syncing the
memory/hardware on read/write callbacks.
Signed-off-by: Ilias Apalodimas
---
Drivers/OpTeeRpmb/FixupPcd.c | 84 +++
Drivers/OpTeeRpmb/FixupPcd.inf| 44 ++
Drivers/OpTeeRpmb/OpTeeRpmbFv.inf | 58 +++
Drivers/OpTeeRpmb/OpTeeRpmbFvb.c | 822
://u-boot.10912.n7.nabble.com/PATCH-0-7-v4-EFI-variable-support-via-OP-TEE-td412499.html
[3] https://git.linaro.org/people/ilias.apalodimas/efi_optee_variables.git/
Reviewed-by: Sami Mujawar
Signed-off-by: Ilias Apalodimas
---
Platform/StMMRpmb/PlatformStandaloneMm.dsc | 165
flag -fno-stack-protector
> added. The stack protection code bring
> GOT dependencies we prefer avoid when StMM runs in OP-TEE.
>
> Cc: Ard Biesheuvel
> Cc: Ilias Apalodimas
> Cc: Leif Lindholm
> Cc: Sami Mujawar
> Signed-off-by: Etienne Carriere
> ---
> Cha
;
> Cc: Ard Biesheuvel
> Cc: Ilias Apalodimas
> Cc: Leif Lindholm
> Cc: Sami Mujawar
> Cc: Sughosh Ganu
> Cc: Thomas Abraham
> Signed-off-by: Etienne Carriere
> ---
> Changes since v1:
> - split change in 3: this change relates to StandaloneMm pa
se architecture agnostic macro
> ARM_SVC_ID_FFA_MSG_SEND_DIRECT_REQ for 32b and 64b support.
>
> Cc: Ard Biesheuvel
> Cc: Ilias Apalodimas
> Cc: Leif Lindholm
> Cc: Sami Mujawar
> Signed-off-by: Etienne Carriere
> ---
> Changes since v1:
> - Use _AARCH64 (res
On Mon, May 17, 2021 at 07:50:46AM +0200, Etienne Carriere wrote:
> Use (UINTN) cast to cast physical or virtual address values to the
> pointer size before casting from/to a pointer value.
>
> Cc: Ard Biesheuvel
> Cc: Ilias Apalodimas
> Cc: Leif Lindholm
> Cc: Sami
address cast build warning issue in 32b mode
> > Platform/StandaloneMm: build StandaloneMmRpmb for 32bit architectures
> >
>
> This looks fine to me
>
> Acked-by: Ard Biesheuvel
>
> I'll pick these up once the EDK2 side is merged.
>
Acked-by: Ilias Apalo
for
RegisterFilterLibNull which will be consumed by IoLib and BaseLib.
Signed-off-by: Ilias Apalodimas
---
.../PlatformStandaloneMmPkg/PlatformStandaloneMmRpmb.dsc| 2 ++
1 file changed, 2 insertions(+)
diff --git
a/Platform/StandaloneMm/PlatformStandaloneMmPkg/PlatformStandaloneMmRpmb.dsc
>
> I think this change may have been covered in
> https://edk2.groups.io/g/devel/topic/82880299#75180. However, this is an
> independent fix that is needed to the current code (before the 32-bit support
> is merged).
>
>
>
> Reviewed-by: Sami Mujawar
>
>
>
&g
On Sun, Mar 28, 2021 at 10:52:19AM +, Sami Mujawar wrote:
> Hi ilias,
>
> Thank you for this series.
>
> Pushed as afb0ce7e9756..89f6170d6686
>
Thanks Sami!
> Regards,
>
> Sami Mujawar
>
>
> From: Ilias Apalodimas
> Date: Saturday, 13 March 2
On Sat, Mar 27, 2021 at 01:25:41PM -0700, Sami Mujawar wrote:
> Hi Ilias,
>
> On Sat, Mar 13, 2021 at 10:31 AM, Ilias Apalodimas wrote:
>
> >
> > + NumBytes =3D NumLba * Instance->BlockSize;=0D
> > + Base =3D (VOID *)Instance->MemBaseAddress + Start * Instanc
(+cc Achin)
On Wed, 10 Mar 2021 at 14:45, Ilias Apalodimas via groups.io
wrote:
> Hi Pierre,
>
> On Wed, Mar 10, 2021 at 09:58:19AM +, Pierre wrote:
> > Hi Ilias,
> > Just minor coding style nit picking:
> >
> > * Drivers/OpTee/OpteeRpmbPkg/
Hi Pierre,
On Wed, Mar 10, 2021 at 09:58:19AM +, Pierre wrote:
> Hi Ilias,
> Just minor coding style nit picking:
>
> * Drivers/OpTee/OpteeRpmbPkg/FixupPcd.c:FixPcdMemory() I think the
>error codes are missing in the function header
Ah you mean the return values of locate protocol?
>
and patches the PCDs, while syncing the
memory/hardware on read/write callbacks.
Signed-off-by: Ilias Apalodimas
---
Drivers/OpTee/OpteeRpmbPkg/FixupPcd.c | 80 ++
Drivers/OpTee/OpteeRpmbPkg/FixupPcd.inf| 43 +
Drivers/OpTee/OpteeRpmbPkg/OpTeeRpmbFv.inf | 58 ++
Drivers/OpTee
of a static number
- Clean up unused structs in header file
- Added checks in OpTeeRpmbFvbGetBlockSize and handle NumLba=0
Changes since V1:
Some enhancements made by Ilias to the Optee Rpmb driver
[1]
https://edk2.groups.io/g/devel/message/66483?p=,,,20,0,0,0::Created,,ilias+apalodimas
I just noticed I somehow managed to remove OptionRomPkg from the list.
I'll wait in case anyone has more remarks on the v6 and I'll send a v7
fixing this.
Sorry for the noise.
On Tue, 9 Mar 2021 at 16:01, Ilias Apalodimas via groups.io
wrote:
>
> Add Sami and myself as maintainers for t
://u-boot.10912.n7.nabble.com/PATCH-0-7-v4-EFI-variable-support-via-OP-TEE-td412499.html
[3] https://git.linaro.org/people/ilias.apalodimas/efi_optee_variables.git/
Reviewed-by: Sami Mujawar
Signed-off-by: Ilias Apalodimas
---
.../PlatformStandaloneMmRpmb.dsc | 162
Add Sami and myself as maintainers for the new StandAlonemmPkg
and the relevant RPMB driver that can be used in OP-TEE
Signed-off-by: Ilias Apalodimas
---
Maintainers.txt | 15 ++-
1 file changed, 10 insertions(+), 5 deletions(-)
diff --git a/Maintainers.txt b/Maintainers.txt
index
and patches the PCDs, while syncing the
memory/hardware on read/write callbacks.
Signed-off-by: Ilias Apalodimas
---
Drivers/OpTee/OpteeRpmbPkg/FixupPcd.c | 81 ++
Drivers/OpTee/OpteeRpmbPkg/FixupPcd.inf| 43 +
Drivers/OpTee/OpteeRpmbPkg/OpTeeRpmbFv.inf | 58 ++
Drivers/OpTee
://u-boot.10912.n7.nabble.com/PATCH-0-7-v4-EFI-variable-support-via-OP-TEE-td412499.html
[3] https://git.linaro.org/people/ilias.apalodimas/efi_optee_variables.git/
Reviewed-by: Sami Mujawar
Signed-off-by: Ilias Apalodimas
---
.../PlatformStandaloneMmRpmb.dsc | 162
]
https://edk2.groups.io/g/devel/message/66483?p=,,,20,0,0,0::Created,,ilias+apalodimas,20,2,0,77703661
Ilias Apalodimas (3):
Drivers/OpTeeRpmb: Add an OP-TEE backed RPMB driver
StMMRpmb: Add support for building StandaloneMm image for OP-TEE
Maintainers: Add maintainers for StandAloneMM and RPMB
Add Sami and myself as maintainers for the new StandAlonemmPkg
and the relevant RPMB driver that can be used in OP-TEE
Signed-off-by: Ilias Apalodimas
---
Maintainers.txt | 10 ++
1 file changed, 10 insertions(+)
diff --git a/Maintainers.txt b/Maintainers.txt
index 56e16fc48cb4
Hi Pierre,
On Wed, Mar 03, 2021 at 10:18:57AM +, Pierre wrote:
> Hello Ilias,
>
> I would have some (inlined) remarks about your patch,
>
> Regards,
>
> Pierre
>
> On 3/2/21 3:35 PM, Pierre Gondois wrote:
> > + PLATFORM_NAME = MmStandaloneRpmb
[...]
> >
> > +
Hi Pierre,
On Wed, Mar 03, 2021 at 10:20:17AM +, Pierre wrote:
> Hello Ilias,
>
> My review is mostly about coding style, but I would have some (inlined)
> remarks about your patch,
>
> Regards,
>
> Pierre
>
> On 3/2/21 3:35 PM, Pierre Gondois wrote:
>
> >
> >
[...]
> > + offer
On Fri, 5 Mar 2021 at 20:07, PierreGondois wrote:
>
> Hi Ilias,
> Thanks for the answer.
> Is it necessary to have the 'COMPRESSION_TOOL_GUID' define ? I could not find
> any use of it. If this is coming from StandaloneMmPkg/StandaloneMmPkg.dsc we
> might want to remove it there aswel.
>
Ok,
On Fri, Mar 05, 2021 at 05:58:49PM +, Pierre wrote:
> Hi Ilias,
> Here is the rest of the review. Sorry to do it in 2 times.
No worries, I'll try to pick up all the comments.
>
> Regards,
>
> Pierre
>
>
> >
> > +/**
> >
> > + Fixup the Pcd values for variable storage
> >
> > +
> >
> > +
MB_FVB_H_' in
> Drivers/OpTeeRpmb/OpTeeRpmbFvb.h
>
> Regards,
>
> Sami Mujawar
>
> -Original Message-
> From: Ilias Apalodimas
> Sent: 12 February 2021 01:38 PM
> To: Sami Mujawar
> Cc: devel@edk2.groups.io; ard+tianoc...@kernel.org; sughosh.g...@linaro.or
Hi Sami,
On Fri, Feb 12, 2021 at 01:11:10PM +, Sami Mujawar wrote:
> Hi Ilias,
>
> Apologies for the delay in reviewing this patch.
>
No worries, thanks for the comments
> Please find my response inline marked [SAMI].
> There are some coding standard issues remaining. I believe these are
::Created,,ilias+apalodimas,20,2,0,77703661
Ilias Apalodimas (2):
Drivers/OpTeeRpmb: Add an OP-TEE backed RPMB driver
StMMRpmb: Add support for building StandaloneMm image for OP-TEE
Drivers/OpTeeRpmb/FixupPcd.c | 89 ++
Drivers/OpTeeRpmb/FixupPcd.inf | 43 +
Drivers
://u-boot.10912.n7.nabble.com/PATCH-0-7-v4-EFI-variable-support-via-OP-TEE-td412499.html
[3] https://git.linaro.org/people/ilias.apalodimas/efi_optee_variables.git/
Reviewed-by: Sami Mujawar
Signed-off-by: Ilias Apalodimas
---
Platform/StMMRpmb/PlatformStandaloneMm.dsc | 165
and patches the PCDs, while syncing the
memory/hardware on read/write callbacks.
Signed-off-by: Ilias Apalodimas
---
Drivers/OpTeeRpmb/FixupPcd.c | 89 +++
Drivers/OpTeeRpmb/FixupPcd.inf| 43 ++
Drivers/OpTeeRpmb/OpTeeRpmbFv.inf | 58 ++
Drivers/OpTeeRpmb/OpTeeRpmbFvb.c | 920
8761...@groups.io
> > 代表 Sughosh Ganu
> > 发送时间: 2021年2月17日 19:27
> > 收件人: devel@edk2.groups.io
> > 抄送: Sami Mujawar ; Ilias Apalodimas
> > ; Ard Biesheuvel
> > 主题: [edk2-devel] [PATCH v4 13/14] MdeModulePkg/VariableStandaloneMm:
> > Set PcdFlashNvStorageVaria
gt; allow the new variable driver to build that has a dependency on
> > this library class and does not require any further platform
> > changes.
> >
> > Cc: Sami Mujawar
> > Cc: Ilias Apalodimas
> > Signed-off-by: Michael Kubacki
> > ---
>
Hi all,
Sorry for being late to the party. Ard cc'ed me in a prior mail, but that
got lost along the way
On Wed, Sep 21, 2022 at 05:41:14PM +0200, Ard Biesheuvel wrote:
> On Wed, 21 Sept 2022 at 14:27, Gerd Hoffmann wrote:
> >
> > On Wed, Sep 21, 2022 at 11:24:11AM +, Lu, Ken wrote:
> > >
me flag was probably copied
> > from this first configuration in:
> > commit bd5071cfbde01 ("StMMRpmb: Add support for building StandaloneMm
> > image for OP-TEE")
> >
> > As the flag is removed for PlatformStandaloneMm.dsc in the previous
> > patch, also remo
45 matches
Mail list logo
