Re: [edk2-devel] [edk2-test][PATCH V2 2/3] Adding FMP to IHVSCT.

2019-08-06 Thread Jeff Booher-Kaeding
Reviewed-by: Jeff Booher-Kaeding On Thu, 2019-08-01 at 12:33 +0530, shrishail wrote: > From: Shrishail Patil > > Adding Firmware Management Protocol to IHVSCT. > This patch contains the changes to build/compilation Changes. > > Contributed-under: TianoCore Contribution Agre

Re: [edk2-devel] [edk2-test][PATCH V2 2/3] Adding HII to IHVSCT

2019-08-06 Thread Jeff Booher-Kaeding
Reviewed-by: Jeff Booher-Kaeding On Thu, 2019-08-01 at 12:33 +0530, shrishail wrote: > From: Shrishail Patil > > Adding HII Config Access Protocol to IHVSCT > This patch contains the changes to build/compilation Changes. > Contributed-under: TianoCore Contribution Agreement 1

Re: [edk2-devel] [edk2-test][PATCH V2 3/3] Adding HII to IHVSCT.

2019-08-06 Thread Jeff Booher-Kaeding
Reviewed-by: Jeff Booher-Kaeding On Thu, 2019-08-01 at 12:33 +0530, shrishail wrote: > From: Shrishail Patil > > Adding HII Config Access Protocol to IHVSCT. > This patch includes the Image information. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-of

Re: [edk2-devel] [edk2-test][PATCH V2 3/3] Adding FMP to IHVSCT.

2019-08-06 Thread Jeff Booher-Kaeding
Reviewed-by: Jeff Booher-Kaeding On Thu, 2019-08-01 at 12:33 +0530, shrishail wrote: > From: Shrishail Patil > > Adding Firmware Management Protocol to IHVSCT. > This patch includes the Image information. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Sig

Re: [edk2-devel] [edk2-test][PATCH V2 1/3] Adding HII Config Access Protocol

2019-08-06 Thread Jeff Booher-Kaeding
My comments are inline, and my review is condtional upon fixing them Reviewed-by: Jeff Booher-Kaeding On Thu, 2019-08-01 at 12:33 +0530, shrishail wrote: > From: Shrishail Patil > > Adding HII Config Access Protocol to IHVSCT > This patch contains source code which is copied fr

[edk2-devel] [PATCH v1 1/1] Platform/RaspberryPi/ConfigDxe: Fix JTAG Pinout for Pi3/4

2020-09-14 Thread Jeff Booher-Kaeding
Updated the pinout to match the Pi4 datasheet, tested with the RPi4, Pi3 Datasheet has same pinout. Signed-off-by: Jeff Booher-Kaeding Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Pete Batard --- Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c | 6 +++--- 1 file changed, 3 insertions(+), 3

Re: [edk2-devel] [PATCH V2 00/10] Platform/RaspberryPi: Utilize SPI flash for EFI variables

2022-02-10 Thread Jeff Booher-Kaeding
Patches applied cleanly & built with no issues. No issues spotted in functional testing & passes the SCT tests required by SBBR. -Jeff On Sat, Jan 1, 2022 at 09:49 PM, Jeremy Linton wrote: > > The RPi4 has a SPI flash with unused capacity. This set detects if > that capacity is sufficient for