On Wed, May 15, 2019 at 04:56:52PM +0800, Zhang, Shenglei wrote:
> This patch updates the platform DSC/FDF files to use the include fragment
> files provided by NetworkPkg.
>
> Signed-off-by: Shenglei Zhang
Reviewed-by: Leif Lindholm
> ---
> Platform/Hisilicon/HiKey960
On Wed, May 15, 2019 at 04:56:55PM +0800, Zhang, Shenglei wrote:
> This patch updates the platform DSC/FDF files to use the include fragment
> files provided by NetworkPkg.
>
> Signed-off-by: Shenglei Zhang
> ---
> .../SynQuacerEvalBoard/SynQuacerEvalBoard.dsc | 35 +--
>
On Wed, May 15, 2019 at 04:56:53PM +0800, Zhang, Shenglei wrote:
> This patch updates the platform DSC/FDF files to use the include fragment
> files provided by NetworkPkg.
>
> Signed-off-by: Shenglei Zhang
Reviewed-by: Leif Lindholm
> ---
> Platform/LeMaker/CelloBoard/C
On Wed, May 15, 2019 at 04:56:57PM +0800, Zhang, Shenglei wrote:
> This patch updates the platform DSC/FDF files to use the include fragment
> files provided by NetworkPkg.
>
> Signed-off-by: Shenglei Zhang
> ---
> Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc | 26 +++
>
Hi Shenglei,
I have now reviewed the patches that are mine to review.
Many thanks for this bit of cleanup/standardisation.
I would just like to raise one warning flag:
These patches have been submitted without the Contributed-under tag.
That means the series needs to either be held back until an
On Wed, May 15, 2019 at 04:56:56PM +0800, Zhang, Shenglei wrote:
> This patch updates the platform DSC/FDF files to use the include fragment
> files provided by NetworkPkg.
>
> Signed-off-by: Shenglei Zhang
Reviewed-by: Leif Lindholm
> ---
> .../Overdrive1000Board/Overdrive
dsc
> @@ -33,8 +33,15 @@
># Defines for default states. These can be changed on the command line.
># -D FLAG=VALUE
>#
> - DEFINE SECURE_BOOT_ENABLE = TRUE
This whitespace change seems unnecessary to me.
If you leave this line in the state it was befor
message needs rewording.
/
Leif
> Cc: Ard Biesheuvel
> Cc: Leif Lindholm
> Cc: Michael D Kinney
> Signed-off-by: Hao A Wu
> ---
> Silicon/Hisilicon/Hisilicon.dsc.inc | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/Silicon
> the IntelFrameworkModulePkg modules with the MdeModulePkg ones, so we can
> decrease our dependency on IntelFrameworkModulePkg.
I would like to have Ard's opinion on this (and he should be back
Friday), and probably testing on the platforms. I say this because I
intend to push the trivial
Hi,
For patches 1,3-5,7-8,10-13,15:
Reviewed-by: Leif Lindholm
However, since we have not yet changed the license for edk2-platforms,
I still need Contributed-under on all of these before I push.
I have a branch prepared, so all I need is a confirmation by an email
to the list that the set
ccident:
This is inaccurate - there are non-trivial differences which could
definitely impact runtime behaviour. This patch definitely needs
testing, and the message needs rewording.
/
Leif
> Cc: Ard Biesheuvel
> Cc: Leif Lindholm
> Cc: Michael D Kinney
> Signed-off-by: Hao A Wu
>
d
definitely impact runtime behaviour. This patch definitely needs
testing, and the message needs rewording.
/
Leif
> Cc: Ard Biesheuvel
> Cc: Leif Lindholm
> Cc: Michael D Kinney
> Signed-off-by: Hao A Wu
> ---
> Platform/LeMaker/CelloBoard/CelloBoard.dsc | 8
&g
On Fri, May 17, 2019 at 04:50:35PM +0800, Liming Gao wrote:
> Signed-off-by: Liming Gao
> Cc: Leif Lindholm
> Cc: Ard Biesheuvel
Reviewed-by: Leif Lindholm
> ---
> EmbeddedPkg/EmbeddedPkg.dsc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
On Fri, May 17, 2019 at 12:57:35PM +0800, Ray Ni wrote:
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ray Ni
> Cc: Liming Gao
> Cc: Andrew Fish
> Cc: Laszlo Ersek
> Cc: Leif Lindholm
> Cc: Michael D Kinney
Reviewed-by: Leif Lindholm
>
it out explicitly in the commit message.
(Conversations about relicensing the 3-clause files are happening in
the background.)
Other than that, looks good to me.
/
Leif
> Cc: Leif Lindholm
> Cc: Ard Biesheuvel
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-
t that this was always intended to be
2-clause?
Regards,
Leif
> Cc: Leif Lindholm
> Cc: Ard Biesheuvel
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Michael D Kinney
> ---
> Platform/RaspberryPi/RPi3/AcpiTables/AcpiTables.h| 8 +-
Hi Mike,
Many thanks for this.
For all of the patches you wanted my R-b on apart from the ones I have
commented on individually:
Reviewed-by: Leif Lindholm
/
Leif
On Wed, May 15, 2019 at 04:09:41PM -0700, Michael D Kinney wrote:
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1
the list that this was always intended to be
2-clause?
Regards,
Leif
> Cc: Leif Lindholm
> Cc: Ard Biesheuvel
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Michael D Kinney
> ---
> Silicon/Broadcom/Bcm283x/Bcm2
ere intended to be contributed with a 2-clause BSD license and under
TianoCore Contribution Agreement 1.1?
Other than that, looks good to me.
/
Leif
> Cc: Leif Lindholm
> Cc: Ard Biesheuvel
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Michael D
ail.
> Sorry that I missed your "Reviewed-by".
>
> Thanks,
> Ray
>
> > -Original Message-
> > From: Leif Lindholm
> > Sent: Friday, May 17, 2019 4:44 PM
> > To: Ni, Ray
> > Cc: devel@edk2.groups.io; Gao, Liming ; Andre
there is no functional impact for this commit.
> >
> > Cc: Ard Biesheuvel
> > Cc: Leif Lindholm
> > Cc: Michael D Kinney
> > Signed-off-by: Hao A Wu
>
> This platform does not have a status code router, so should we not
> simply switch to BaseReportStatu
there is no functional impact for this commit.
> >
> > Cc: Ard Biesheuvel
> > Cc: Leif Lindholm
> > Cc: Michael D Kinney
> > Signed-off-by: Hao A Wu
>
> This platform does not have a status code router, so should we not
> simply switch to BaseReportStatu
On Fri, May 17, 2019 at 09:58:27AM +0200, Marcin Wojtas wrote:
> Fill in the basic requirements of the SMBIOS specification by specifying
> the minimum required structures. The basic fixup is performed.
> CPU/DRAM frequency is obtained via SampleAtResetlib and the DRAM size
> is calculated from
there is no functional impact for this commit.
> >
> > Cc: Ard Biesheuvel
> > Cc: Leif Lindholm
> > Cc: Michael D Kinney
> > Signed-off-by: Hao A Wu
>
> This platform does not have a status code router, so should we not
> simply switch to B
On Fri, May 17, 2019 at 06:18:55PM +0200, Ard Biesheuvel wrote:
> The status code reporting functionality in PrePiLib is never invoked
> so let's just remove it.
>
> Signed-off-by: Ard Biesheuvel
Reviewed-by: Leif Lindholm
*however* - I don't think this constitutes a bugfix, so pr
The devel mailing list has moved from 01.org to groups.io - update
the mailing list information to reflect this.
Signed-off-by: Leif Lindholm
---
Maintainers.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Maintainers.txt b/Maintainers.txt
index aaabe2b52d..f3ce5edd8a
On Fri, May 17, 2019 at 11:50:06AM +0100, Leif Lindholm wrote:
> On Wed, May 15, 2019 at 04:10:08PM -0700, Michael D Kinney wrote:
> > https://bugzilla.tianocore.org/show_bug.cgi?id=1373
> >
> > Replace BSD 2-Clause License with BSD+Patent License. This change is
>
Marcin is the author of the majority of the Marvell platform support in
the tree, so clarify that he should be cc:d on patches to Marvell Armada
SoC/Boards and MacchiatoBIN.
Cc: Marcin Wojtas
Signed-off-by: Leif Lindholm
---
Maintainers.txt | 9 +
1 file changed, 9 insertions(+)
diff
Hi Rebecca,
On Mon, May 27, 2019 at 05:34:08PM -0600, rebe...@bluestop.org wrote:
> I've been working with the MACCHIATObin board, and noticed settings for
> HTTP and TLS in Platform/SolidRun/Armada80x0McBin/Armada80x0McBin.dsc in
> the repo
>
On Mon, Jun 03, 2019 at 08:18:03AM +, Gao, Zhichao wrote:
>
>
> > -Original Message-
> > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> > Leif Lindholm
> > Sent: Saturday, June 1, 2019 12:44 AM
> > To: devel@edk2.groups.io;
On Tue, Jun 04, 2019 at 10:10:59PM +0800, Liming Gao wrote:
> MdeModulePkg/Universal/Network has been moved to NetworkPkg. So,
> MdeModulePkg/Universal/Network can be removed in Maintainers.txt.
>
> Signed-off-by: Liming Gao
> Cc: Andrew Fish
> Cc: Laszlo Ersek
> Cc
On Tue, Jun 04, 2019 at 10:12:48AM -0700, Michael D Kinney wrote:
> * Remove refrences EdkCompatibilityPkg
> * Update link to OpenSSL to https://github.com/openssl/openssl
> * Add link to https://github.com/ucb-bar/berkeley-softfloat-3
> for ArmSoftFloatLib
Bikeshed warning:
> Signed-off-by:
20190604
> >
> > Looking forward to your comments.
>
> Thanks for fixing this! Looks good on my machine now. I don't see any
> obvious issues so:
>
> Tested-by: Jeremy Linton
>
> and if you would like I also took a look at the code and it looks fine to me
> as we
sage-
> > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io]
> > On Behalf Of Leif Lindholm
> > Sent: Tuesday, June 4, 2019 11:00 AM
> > To: devel@edk2.groups.io; Kinney, Michael D
> >
> > Subject: Re: [edk2-devel] [Patch] edk2: Update
> >
On Mon, Jun 03, 2019 at 02:56:42PM +0200, Laszlo Ersek wrote:
> On 05/30/19 17:59, Leif Lindholm wrote:
> > Patch contribution and review is greatly simplified by following the
> > steps described in "Laszlo's unkempt guide":
> > https://github.com/tianocore/ti
On Mon, Jun 03, 2019 at 02:43:23PM +0200, Laszlo Ersek wrote:
> On 05/30/19 17:59, Leif Lindholm wrote:
> > Before adding the git environment initialization script, add the
> > following files that will be pointed to after running said script:
> >
> > - BaseTools/Conf
On Fri, May 31, 2019 at 02:49:53PM +0200, Ard Biesheuvel wrote:
> diff --git a/ArmPkg/Library/ArmSoftFloatLib/ArmSoftFloatLib.inf
> b/ArmPkg/Library/ArmSoftFloatLib/ArmSoftFloatLib.inf
> index cbb49f49ade6..4d0c94df83db 100644
> --- a/ArmPkg/Library/ArmSoftFloatLib/ArmSoftFloatLib.inf
> +++
On Fri, May 31, 2019 at 03:39:33PM +0200, Ard Biesheuvel wrote:
> On Fri, 31 May 2019 at 15:26, Leif Lindholm wrote:
> >
> > On Fri, May 31, 2019 at 03:22:25PM +0200, Ard Biesheuvel wrote:
> > > > > + GCC:*_*_*_CC_FLAGS = -fno-lto -ffreestanding -Wno-unused-labe
On Thu, May 30, 2019 at 05:34:23AM +, Loh, Tien Hock wrote:
> > Also, we should look into having the DT provided by the firmware
> > instead of passed on the command line.
> >
> > And manually specifying console is very 2014 - use stdout-path in
> > the DT.
>
> Yeah I'll be looking into it.
, and add RVCT droppage to
commit message for this one?
If so, for series:
Reviewed-by: Leif Lindholm
/
Leif
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#41746): https://edk2.groups.io/g/devel/message/41746
Mute This Topic: htt
ap.c:44:12:
> note: initialize the variable 'ret' to silence this warning
> int ret;
>^
> = 0
> 1 error generated.
>
> This appears to be a regression in the OpenSSL upstream code (commit
> 25eb9299cec), which no longer initializes ret
gt;
> > Regards,
> >
> > Leif
> >
> > > And I also make some minor changes on it.
> > >
> > > Thanks,
> > > Zhichao
> > >
> > > > -Original Message-
> > > > From: Leif Lindholm [mailto:leif.lindh.
On Fri, May 31, 2019 at 06:20:19PM +0200, Marcin Wojtas wrote:
> Fill in the basic requirements of the SMBIOS specification by specifying
> the minimum required structures. The basic fixup is performed.
> CPU/DRAM frequency is obtained via SampleAtResetlib and the DRAM size
> is calculated from
ay, May 31, 2019 9:00 AM
> > To: edk2-devel-groups-io ; Leif
> > Lindholm
> > Cc: Laszlo Ersek ; Gao, Liming
> > ; Wang, Jian J
> > ; Kinney, Michael D
> >
> > Subject: Re: [edk2-devel] [PATCH v3 0/7] update
> > ArmSoftFloatLib to latest upstream version
>
zlo Ersek
> Cc: "Gao, Liming"
> Cc: "Wang, Jian J"
> Cc: Leif Lindholm
> Cc: Michael D Kinney
> Signed-off-by: Ard Biesheuvel
Reviewed-by: Leif Lindholm
> ---
> ArmPkg/Library/ArmSoftFloatLib/platform.h | 2 +-
> 1 file changed, 1 insertion(+)
Hi Bob,
On Thu, May 30, 2019 at 06:39:59AM +, Feng, Bob C wrote:
> Hi,
>
> Currently, we have 5 Basetools patches which are ready to
> push. Since we are in the soft-freeze phase, I'd like to ask for
> your opinions if those patches can be pushed to edk2 master.
To save me the time of
On Tue, 28 May 2019 at 11:24, Marcin Wojtas wrote:
>
> Hi Leif,
>
> wt., 28 maj 2019 o 12:20 Leif Lindholm
napisał(a):
> >
> > Marcin is the author of the majority of the Marvell platform support in
> > the tree, so clarify that he should be cc:d on patches to
On Wed, May 29, 2019 at 08:45:55AM +0800, Gao, Zhichao wrote:
> From: Bret Barkelew
If this code is from Microsoft...
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1853
>
> Sperate the capsule check function from GetCapsuleDescriptors
> and name it to AreCapsulesStaged.
> Rename
On Tue, May 28, 2019 at 02:03:26PM +0200, Laszlo Ersek wrote:
> On 05/28/19 12:22, Leif Lindholm wrote:
> > The devel mailing list has moved from 01.org to groups.io - update
> > the mailing list information to reflect this.
> >
> > Signed-off-by: Leif Lindholm
>
)
> Signed-off-by: Jeremy Linton
Reviewed-by: Leif Lindholm
However, the patch is garbled (lines broken and '=20' all over the
place). Could you have a look at your email setup or point me at a
(public) remote tree?
(It's possible your mail server will stop playing silly if you strip
the C
On Wed, May 29, 2019 at 09:46:54AM +0800, Steven Shi wrote:
> V2 change:
> Simplify the library cache implementation and remove
> CacheRestored flag based filter. Use the current
> CanSkipbyHash() filter in AddDependency() instead.
>
> V1 change:
Please don't put change notices in the commit
Thanks,
> Zhichao
>
> > -Original Message-
> > From: Leif Lindholm [mailto:leif.lindh...@linaro.org]
> > Sent: Wednesday, May 29, 2019 7:12 PM
> > To: devel@edk2.groups.io; Gao, Zhichao
> > Cc: Bret Barkelew ; Wang, Jian J
> > ; Wu, Hao A ; Ni, Ray
> >
need
this tag any longer...
> Cc: Ard Biesheuvel
> Cc: Leif Lindholm
> Cc: Michael D Kinney
>
> --
> v4
> - Removed LibC
> - Added NOOPT to BUILD_TARGETS
> - Removed ARM from SUPPORTED_ARCHITECTURE
> v3
> - Updated Pcd with updated name
> v2
> - Updates
On Wed, May 29, 2019 at 03:14:48PM +0200, Ard Biesheuvel wrote:
> On Wed, 29 May 2019 at 15:06, Leif Lindholm wrote:
> >
> > On Wed, May 29, 2019 at 02:50:19PM +0200, Ard Biesheuvel wrote:
> > > As opposed to the Secure96's I2C peripherals, whose bus addres
> [CryptoPkg/Library/OpensslLib/openssl](CryptoPkg/Library/OpensslLib/openssl/LICENSE)
> +*
> [ArmPkg/Library/ArmSoftFloatLib/SoftFloat-3e](ArmPkg/Library/ArmSoftFloatLib/SoftFloat-3e/COPYING.txt)
>
> Thanks
> Liming
> > -Original Message-
> > From: devel@edk2.gr
On Wed, May 29, 2019 at 02:50:19PM +0200, Ard Biesheuvel wrote:
> As opposed to the Secure96's I2C peripherals, whose bus addresses are
> properties of the peripherals themselves, the SPI CS address of the
> TPM is a property of the platform that incorporates the LS connector.
>
> So tweak the
e, so here is a
python script that configures all options I am aware of
*for the repository the script is executed from*.
Signed-off-by: Leif Lindholm
---
BaseTools/Scripts/SetupGit.py | 187 ++
1 file changed, 187 insertions(+)
create mode 100644 BaseToo
Before adding the git environment initialization script, add the
following files that will be pointed to after running said script:
- BaseTools/Conf/diff.order
- BaseTools/Conf/gitattributes
Signed-off-by: Leif Lindholm
---
BaseTools/Conf/diff.order| 8
BaseTools/Conf
bal settings (name,
email, mail server config...).
Leif Lindholm (2):
BaseTools: add centralized location for git config files
BaseTools: add script to configure local git options
BaseTools/Conf/diff.order | 8 ++
BaseTools/Conf/gitattributes | 14
BaseTools/Scripts/SetupGit.py |
opposed to
being available from master the day after the tag is made?
Best Regards,
Leif
>
>
> Thanks,
> Bob
>
> -Original Message-
> From: Rodriguez, Christian
> Sent: Thursday, May 30, 2019 10:26 PM
> To: Leif Lindholm ; Feng, Bob C
>
> Cc: Andr
On Tue, May 28, 2019 at 01:28:21PM +0200, Ard Biesheuvel wrote:
> > > diff --git
> > > a/ArmPkg/Library/ArmSoftFloatLib/SoftFloat-3e/build/Linux-ARM-VFPv2-GCC/platform.h
> > >
> > > b/ArmPkg/Library/ArmSoftFloatLib/SoftFloat-3e/build/Linux-ARM-VFPv2-GCC/platform.h
> > > index
ailto:ard.biesheu...@linaro.org]
> > >Sent: Tuesday, May 28, 2019 4:52 AM
> > >To: devel@edk2.groups.io
> > >Cc: Ard Biesheuvel ; Laszlo Ersek
> > >; Gao, Liming ; Wang, Jian J
> > >; Leif Lindholm ; Kinney,
> > >Michael D
> > >Subject:
This file was based on an old version of the edk2 Maintainers.txt,
predating both d75b8ac278b and c9e1e28b619. Bring this up to date.
Signed-off-by: Leif Lindholm
---
Maintainers.txt | 5 +
1 file changed, 5 insertions(+)
diff --git a/Maintainers.txt b/Maintainers.txt
index 76feecceb7
The devel mailing list has moved from 01.org to groups.io - update
the mailing list information to reflect this.
Signed-off-by: Leif Lindholm
---
Maintainers.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Maintainers.txt b/Maintainers.txt
index 85e8dc7fd4..778eec6fed
Hi stewards, and other interested people.
Readme.md lists a few licenses acceptable but not preferred (this text
used to live in Contributions.txt before the bsd+patent relicensing
effort). However, it does not explicitly state anything about the gap
that was left by the dropping of the TianoCore
substantially.
For the series (pending patent grant consensus):
Reviewed-by: Leif Lindholm
/
Leif
On Mon, May 27, 2019 at 10:51:34PM +0200, Ard Biesheuvel wrote:
> Currently, our move to OpenSSL 1.1.1b is being blocked by an issue in
> the ARM software floating point library, which lack
's add the same flags
> there as well.
>
> Cc: Jian J Wang
> Cc: Ting Ye
> Cc: Xiaoyu Lu
> Signed-off-by: Ard Biesheuvel
Reviewed-by: Leif Lindholm
> ---
> CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf| 1 +
> CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf
On Mon, Jun 03, 2019 at 11:42:02PM +0800, Zhichao Gao wrote:
> From: Bret Barkelew
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1853
>
> Change form Mu repo:
> https://github.com/microsoft/mu_basecore/blob/release/201903/
> MdeModulePkg/Universal/CapsulePei/UefiCapsule.c#L801
>
>
this script, it
> reported "Unknown upstream ".
>
> The script works well if the git url is https://github.com/tianocore/edk2.git
>
> So would you update the script to support the url with or without the ".git"
> suffix?
>
>
> Th
f
> Cc: Jian J Wang
> Cc: Hao A Wu
> Cc: Ray Ni
> Cc: Star Zeng
> Cc: Liming Gao
> Cc: Sean Brogan
> Cc: Michael Turner
> Cc: Bret Barkelew
> Cc: Leif Lindholm
> Signed-off-by: Zhichao gao
> ---
> .../Universal/CapsulePei/UefiCapsule.c| 103 +++
nt 1.1
> Signed-off-by: Jeremy Linton
> Reviewed-by: Marcin Wojtas
That one worked much better:
Reviewed-by: Leif Lindholm
Pushed as 6784b55292.
(Also, *giggle* @ mammon.)
/
Leif
> ---
> Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc | 3 +++
> Silicon/Marvell/Armada7k8k/
lds/linux/blob/v5.0/arch/x86/kernel/apic/apic.c#L854
>
> *
>
> GARRETT KIRKENDALL
> SMTS Firmware Engineer | CTE
> 7171 Southwest Parkway, Austin, TX 78735 USA
> AMD facebook | amd.com
>
> -Original Message-
> From: devel@edk2.gr
ould not expect
> data
>
> Signed-off-by: "Tien Hock, Loh"
> Cc: Leif Lindholm
> Cc: Ard Biesheuvel
>
> --
> v2:
> - Move IsACmd as a local static variable in function
> - Fix some coding standard issue with spacing
> ---
> EmbeddedPkg/Drivers/DwEmmcDxe/Dw
ed-off-by: Tien Hock, Loh
> Cc: Leif Lindholm
> Cc: Ard Biesheuvel
>
> --
> v2
> - Change IsEmmc to EFI_MMC_HOST_CARD_TYPE
Version information goes below ---.
Never type this manually - sooner or later you will leave out a like
above and accidentally have it included in t
On Mon, May 27, 2019 at 05:30:28PM +0800, tien.hock@intel.com wrote:
> From: "Tien Hock, Loh"
>
> Add support for reading data that is less than DWEMMC_BLOCK_SIZE,
> otherwise it would read bigger data than requested and cause errors
>
> Signed-off-by: "Tie
On Mon, May 27, 2019 at 05:30:24PM +0800, tien.hock@intel.com wrote:
> From: "Tien Hock, Loh"
>
> Send command when MMC ask for response in DwEmmcReceiveResponse, and
> command is a pending command (eg. DMA needs to be set up first)
>
> Signed-off-by: "Tie
On Mon, May 27, 2019 at 05:30:25PM +0800, tien.hock@intel.com wrote:
> From: "Tien Hock, Loh"
>
> Do not send CRC response check if the MMC command does not support CRC
> response
>
> Signed-off-by: Tien Hock, Loh
> Cc: Leif Lindholm
> Cc: Ard Biesh
eset to 0
>
> Signed-off-by: "Tien Hock, Loh"
> Cc: Leif Lindholm
> Cc: Ard Biesheuvel
Reviewed-by: Leif Lindholm
> ---
> EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/EmbeddedPkg/Drivers/DwEmmcDxe/DwEm
rom: "Tien Hock, Loh"
>
> Change SendCommand polling mode to remove unnecessary delay, and check
> for transfer done only when block data is to be read/write. This would
> also increase performance slightly.
>
> Signed-off-by: "Tien Hock, Loh"
The migration of OptionRomPkg to edk2-platforms broke the HiKey build.
Update the paths in .dsc/.fdf to restore.
Signed-off-by: Leif Lindholm
---
Platform/Hisilicon/HiKey/HiKey.dsc | 2 +-
Platform/Hisilicon/HiKey/HiKey.fdf | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git
On Thu, Jun 13, 2019 at 01:42:29PM +0200, Ard Biesheuvel wrote:
> On Thu, 13 Jun 2019 at 13:41, Leif Lindholm wrote:
> >
> > The migration of OptionRomPkg to edk2-platforms broke the HiKey build.
> > Update the paths in .dsc/.fdf to restore.
> >
> > Signed-
On Wed, Jun 12, 2019 at 10:18:24AM +0200, Laszlo Ersek wrote:
> > In this instance, we explicitly don't care about the submodule for
> > that other project (and I really hope this is the norm) - so we
> > shouldn't be documenting steps that rely on that additional
> > submodule existing.
>
> Yes;
.
Also tag all files in top directory as maintained by the stewards.
Signed-off-by: Leif Lindholm
---
Maintainers.txt | 50 ++
1 file changed, 50 insertions(+)
diff --git a/Maintainers.txt b/Maintainers.txt
index 762a68465979..cd32f9b00170 100644
Add a new script GetMaintainer.py that uses the new Maintainer.txt format
to determine which addresses to cc on patch submission.
Signed-off-by: Leif Lindholm
---
BaseTools/Scripts/GetMaintainer.py | 181 +
1 file changed, 181 insertions(+)
create mode
not cover subdirectories
- Added support for X: tag
- Added support for magic '' pathname
- Also prints mailing list addresses for matching L: tags
Leif Lindholm (3):
Maintainers.txt: update for filesystem area descriptions
Maintainers.txt: add wildcard path association for Arm/AArch64
BaseTools
Add Ard and Leif as responsible for any path matching
F: */Arm/
F: */AArch64/
Signed-off-by: Leif Lindholm
---
Maintainers.txt | 8
1 file changed, 8 insertions(+)
diff --git a/Maintainers.txt b/Maintainers.txt
index cd32f9b00170..e415f51468d5 100644
--- a/Maintainers.txt
+++ b
knowledge is incomplete.
Signed-off-by: Leif Lindholm
---
BaseTools/Scripts/GetMaintainer.py | 131 +
Maintainers.txt| 38 +++
2 files changed, 169 insertions(+)
create mode 100644 BaseTools/Scripts/GetMaintainer.py
diff --git
Hi Wu Hao,
I am working on a proposal (and proof-of-concept) machine readable
Maintainers.txt format, and a GetMaintainer.py script, based on the
format used by QEMU.
One of the key features of that format is the F: tag, which specifes a
filesytem path (with wildcard support).
While this is
Leif
On Tue, Jun 11, 2019 at 05:25:58AM +, Feng, Bob C wrote:
> Hi Leif,
>
> These 2 new file have no license header, need to add?
>
> Thanks,
> Bob
>
> -Original Message-----
> From: Leif Lindholm [mailto:leif.lindh...@linaro.org]
> Sent: Monday, June 10,
; > From: Loh, Tien Hock
> > Sent: Thursday, May 30, 2019 3:56 PM
> > To: Haojian Zhuang ; Leif Lindholm
> >
> > Cc: devel@edk2.groups.io; thlo...@gmail.com; Ard Biesheuvel
> >
> > Subject: RE: [PATCH v2 6/7] EmbeddedPkg: Fix DwEmmc SendCommand
> > pollin
message/41419
> > > (Thanks a lot for the validation effort.)
> > >
> > > Do you have remaining concerns for review this series?
> > > Thanks in advance.
> > >
> > > Best Regards,
> > > Hao Wu
> > >
> > >
> > > >
separate logical
components before pushing.
For the series:
Reviewed-by: Leif Lindholm
Pushed as 5752f09f7e..cf5d0a48c1.
Thanks!
> Pete Batard (2):
> RaspberryPi/RPi3: Enable RAM Disk
> RaspberryPi/RPi3: Update DSC/FDF to use NetworkPkg DSC/FDF
>
> Platform/Raspbe
emain two bytes for the first
> parameter to set the null- terminate. So remove this change
> in Mu.
>
> Cc: Jian J Wang
> Cc: Hao A Wu
> Cc: Ray Ni
> Cc: Star Zeng
> Cc: Liming Gao
> Cc: Sean Brogan
> Cc: Michael Turner
> Cc: Bret Barkelew
> Cc
Before adding the git environment initialization script, add the
following files that will be pointed to after running said script:
- BaseTools/Conf/diff.order
- BaseTools/Conf/gitattributes
Signed-off-by: Leif Lindholm
Reviewed-by: Laszlo Ersek
---
BaseTools/Conf/diff.order| 8
bal settings (name,
email, mail server config...).
New in v1 (from RFC):
- Script matches on both .git and no extension repo URLs
- Fixed typo and stale comment pointed out.
- Added Laszlo's R-b and Ack.
Leif Lindholm (2):
BaseTools: add centralized location for git config files
BaseTools:
e, so here is a
python script that configures all options I am aware of
*for the repository the script is executed from*.
Signed-off-by: Leif Lindholm
Acked-by: Laszlo Ersek
---
BaseTools/Scripts/SetupGit.py | 204 ++
1 file changed, 204 insertions(+)
c
On Thu, Jun 13, 2019 at 06:21:31PM +0200, Philippe Mathieu-Daudé wrote:
> On 6/13/19 6:18 PM, Leif Lindholm wrote:
> > TimeBaseLib EfiTimeToEpoch returns a UINTN, meaning its behaviour differs
> > between architectures. This upsets VS2017 when building for 32-bit ARM
> &
also describes the cache and
> processor topology in Juno (all revisions).
>
> Signed-off-by: Krzysztof Koch
Reviewed-by: Leif Lindholm
Pushed as 2ff8f1bf36.
> ---
>
> Changes can be seen at:
> https://github.com/KrzysztofKoch1/edk2-platforms/tree/392_dynamic_pptt_juno_
Hi Liming,
On Wed, Jun 12, 2019 at 01:30:23PM +, Gao, Liming wrote:
> > > What I am saying is:
> > > - We should have a policy (i.e., a section in toplevel Readme.md)
> > > regarding submodules.
> > > - That policy *should* include the requirement to not permit
> > > submodules
-by: Leif Lindholm
---
EmbeddedPkg/Include/Library/TimeBaseLib.h | 4 ++--
EmbeddedPkg/Library/TimeBaseLib/TimeBaseLib.c | 18 +-
2 files changed, 11 insertions(+), 11 deletions(-)
diff --git a/EmbeddedPkg/Include/Library/TimeBaseLib.h
b/EmbeddedPkg/Include/Library/TimeBaseLib.h
1 - 100 of 1854 matches
Mail list logo
