Reviewed-by: Liming Gao
>-Original Message-
>From: Ni, Ray
>Sent: Thursday, August 01, 2019 5:58 PM
>To: devel@edk2.groups.io
>Cc: Kinney, Michael D ; Gao, Liming
>; Dong, Eric ; Laszlo Ersek
>
>Subject: [PATCH v4 5/8] MdePkg/Cpuid.h: Move Cpuid.h from UefiCpuPkg
Reviewed-by: Liming Gao
>-Original Message-
>From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
>Zhang, Shenglei
>Sent: Tuesday, August 06, 2019 10:17 AM
>To: devel@edk2.groups.io
>Cc: Kinney, Michael D ; Gao, Liming
>
>Subject: [ed
PatchCheck reports Trailing whitespace. Please fix it when you push the change.
* Trailing whitespace found
File: MdeModulePkg/MdeModulePkg.dec
Line: # @Prompt Enable 5-Level Paging support in long mode.
* Trailing whitespace found
File: MdeModulePkg/MdeModulePkg.uni
Line:
Thanks
Eric:
I review this patch set. I think patch 14 can be merged into patch 4, patch
13 can be merged into patch 5.
And, patch 2 introduces new APIs in FmpDeviceLib. I see edk2-platform
Platform\Intel\Vlv2TbltDevicePkg\Feature\Capsule\Library\FmpDeviceLib
is the FmpDeviceLib library
Marc:
The change is good. Reviewed-by: Liming Gao
Besides, I see BZ also mention to remove the one in MdeModulePkg. Have you
the following patches for the change in MdeModulePkg?
Thanks
Liming
>-Original Message-
>From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On
Ashraf:
For new files, please use license: SPDX-License-Identifier:
BSD-2-Clause-Patent.
Other change is good. Reviewed-by: Liming Gao
Thanks
Liming
>-Original Message-
>From: Javeed, Ashraf
>Sent: Monday, July 29, 2019 2:52 PM
>To: devel@edk2.groups.io
>Cc: Ki
Michael D ; Gao, Liming
>; Ni, Ray
>Subject: [PATCH] MdePkg: Add PI 1.5 SmramMemoryReserve HOB file
>
>This is a special GUID extension Hob to describe SMRAM memory regions
>
>Cc: Michael D Kinney
>Cc: Liming Gao
>Cc: Ray Ni
>Ref: https://bugzilla.tianocore.org/show_b
The patch is good. Reviewed-by: Liming Gao
>-Original Message-
>From: Javeed, Ashraf
>Sent: Monday, July 29, 2019 11:51 AM
>To: devel@edk2.groups.io
>Cc: Kinney, Michael D ; Gao, Liming
>; Ni, Ray ; Wu, Hao A
>
>Subject: [Patch V2] MdePkg/PciExpress21.h: Fix t
Kinney, Michael D ; Gao, Liming
>; Ni, Ray
>Subject: [edk2-devel] [PATCH V2] MdePkg: Add PI 1.5 SmramMemoryReserve
>HOB file
>
>This is a special GUID extension Hob to describe SMRAM memory regions
>
>Cc: Michael D Kinney
>Cc: Liming Gao
>Cc: Ray Ni
>Ref: htt
Reviewed-by: Liming Gao
>-Original Message-
>From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
>Kubacki, Michael A
>Sent: Wednesday, August 07, 2019 4:34 AM
>To: devel@edk2.groups.io
>Cc: Chiu, Chasel ; Desimone, Nathaniel L
>; Gao, Liming
Reviewed-by: Liming Gao
>-Original Message-
>From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
>Zhang, Shenglei
>Sent: Tuesday, August 06, 2019 10:17 AM
>To: devel@edk2.groups.io
>Cc: Kinney, Michael D ; Gao, Liming
>
>Subject: [ed
Bob:
I have no comments for this patch set. I am OK to add it for 201908 stable
tag.
Ack-by: Liming Gao
Thanks
Liming
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Laszlo
> Ersek
> Sent: Friday, August 9, 2019 7:29 A
Leif:
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Leif
> Lindholm
> Sent: Friday, August 9, 2019 9:29 PM
> To: Laszlo Ersek
> Cc: Feng, Bob C ; Gao, Liming ;
> devel@edk2.groups.io; Andrew Fish ;
> Kinney, Michael D
> Subject: Re:
s it feasible to convert this to a git submodule for future updates?
>
I will submit one BZ for it. This need to contribute some change back to
Oniguruma project for EDK2.
Thanks
Liming
> Best Regards,
>
> Leif
>
> > Thanks
> > Liming
> > >-Original M
push@ 83d6207f99021ac9b2990fc9d66bab3cb3ae5f26
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Liming
> Gao
> Sent: Friday, August 2, 2019 12:13 AM
> To: Carsey, Jaben ; devel@edk2.groups.io; Feng, Bob C
>
> Subject: Re
gt;
> Add extra debugging to improve error identification.
> Error while processing file if the file is read incorrectly
>
> This patch is going to fix that issue.
>
> Cc: Bob Feng
> Cc: Liming Gao
> Signed-off-by: Zhiju.Fan
> ---
> BaseTools/Source/Python/AutoGen/S
Reviewed-by: Liming Gao
> -Original Message-
> From: Carsey, Jaben
> Sent: Thursday, August 1, 2019 10:45 PM
> To: devel@edk2.groups.io; Feng, Bob C
> Cc: Gao, Liming
> Subject: RE: [edk2-devel] [Patch] BaseTools: Fixed a typo in Trim.py
>
> Reviewed-by: J
.
Thanks
Liming
>-Original Message-
>From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
>Liming Gao
>Sent: Thursday, August 08, 2019 9:31 PM
>To: devel@edk2.groups.io
>Cc: Wang, Jian J ; Wu, Hao A ;
>Cinnamon Shia
>Subject: [edk2-dev
Leif:
>-Original Message-
>From: Leif Lindholm [mailto:leif.lindh...@linaro.org]
>Sent: Thursday, August 08, 2019 5:55 PM
>To: devel@edk2.groups.io; Zhang, Shenglei
>Cc: Feng, Bob C ; Gao, Liming
>; Ard Biesheuvel ;
>Eugene Cohen
>Subject: Re: [edk2-devel] [PATCH 1/1] BaseTools: Remove
Mike:
Yes. I will update this wiki page.
Thanks
Liming
> -Original Message-
> From: Kinney, Michael D
> Sent: Friday, July 19, 2019 11:51 PM
> To: Gao, Liming ; devel@edk2.groups.io; Kinney, Michael
> D
> Cc: Sun, Zailiang ; Qian, Yi ;
> Gary Lin
> Subject: RE: [edk2-devel]
he '/' or
> 'F' or 'o' on the left of CmdSign. This is not expected.
>
> This patch is going to fix such issue.
>
> Cc: Liming Gao
> Signed-off-by: Bob Feng
> ---
> BaseTools/Source/Python/AutoGen/GenMake.py | 2 +-
> BaseTools/Source/Python/GenFds/GenFdsGlob
Leif:
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Leif
> Lindholm
> Sent: Tuesday, July 23, 2019 8:20 PM
> To: Laszlo Ersek
> Cc: devel@edk2.groups.io; Kinney, Michael D ; Ard
> Biesheuvel ; Wang, Jian J
> ; Ye, Ting
> Subject: Re:
Laszlo:
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Wednesday, July 17, 2019 6:22 PM
> To: Gao, Liming ; Leif Lindholm
>
> Cc: devel@edk2.groups.io; Rebecca Cran ; Feng, Bob C
> ; Kinney, Michael D
> ; af...@apple.com
> Subject: Re: [PATCH 1/1]
Laszlo:
Yes. Patch 1 & Patch 2 in MdePkg are both good to me. I have no other
comments. Reviewed-by: Liming Gao
Thanks
Liming
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Laszlo
> Ersek
> Sent: Tuesday, July 16, 2019 6
Reviewed-by: Liming Gao
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Wu, Hao
> A
> Sent: Thursday, July 18, 2019 9:19 AM
> To: devel@edk2.groups.io
> Cc: Wu, Hao A ; Andrew Fish ; Laszlo
> Ersek ; Leif Lindholm
Leif:
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Leif
> Lindholm
> Sent: Thursday, July 18, 2019 6:37 AM
> To: Gao, Liming
> Cc: Laszlo Ersek ; devel@edk2.groups.io; Rebecca Cran
> ; Feng, Bob C ;
> Kinney, Michael D ; af...@apple.com
>
Reviewed-by: Liming Gao
>-Original Message-
>From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
>Bob Feng
>Sent: Friday, July 19, 2019 10:24 AM
>To: devel@edk2.groups.io
>Cc: Feng, Bob C ; Kinney, Michael D
>; Gao, Liming
>Subject: [e
Mike:
Yes. Wiki https://github.com/lgao4/edk2/wiki/StructurePcd-Enable-Steps shows
the usage of the different default store.
>-Original Message-
>From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
>Michael D Kinney
>Sent: Friday, July 19, 2019 2:05 PM
>To: Gao,
Mike:
The update patch is good. Reviewed-by: Liming Gao for
Patch 2.
Thanks
Liming
>-Original Message-
>From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
>Michael D Kinney
>Sent: Friday, July 19, 2019 2:03 PM
>To: devel@edk2.groups.io
>Subject:
Leif:
> -Original Message-
> From: Leif Lindholm [mailto:leif.lindh...@linaro.org]
> Sent: Friday, July 19, 2019 1:56 AM
> To: Gao, Liming
> Cc: devel@edk2.groups.io; Laszlo Ersek ; Rebecca Cran
> ; Feng, Bob C ;
> Kinney, Michael D ; af...@apple.com
> Subject: Re: [edk2-devel] [PATCH
Sorry, I miss this mail. I am OK for this change.
Ack-by: Liming Gao
Thanks
Liming
> -Original Message-
> From: Leif Lindholm [mailto:leif.lindh...@linaro.org]
> Sent: Friday, July 19, 2019 5:57 AM
> To: Laszlo Ersek
> Cc: edk2-devel-groups-io ; Andrew Fish
> ;
Leif:
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Leif
> Lindholm
> Sent: Tuesday, July 23, 2019 9:26 PM
> To: Gao, Liming
> Cc: devel@edk2.groups.io; Laszlo Ersek ; Kinney, Michael D
> ; Ard Biesheuvel
> ; Wang, Jian J ; Ye, Ting
>
>
Leif:
> -Original Message-
> From: Leif Lindholm [mailto:leif.lindh...@linaro.org]
> Sent: Tuesday, July 23, 2019 5:45 PM
> To: Gao, Liming
> Cc: devel@edk2.groups.io; Laszlo Ersek ; Rebecca Cran
> ; Feng, Bob C ;
> Kinney, Michael D ; af...@apple.com
> Subject: Re: [edk2-devel] [PATCH
Rebecca:
The change is good. Reviewed-by: Liming Gao for 1-4,
and 6.
For patch 5, I see Leif sends another version update. I will give the
comments on his change.
Thanks
Liming
> -Original Message-
> From: Rebecca Cran [mailto:rebe...@bsdio.com]
> Sent: Wednesday, July
Leif:
I agree to discuss the behavior first, then review the code logic in detail.
I add my comments below.
> -Original Message-
> From: Leif Lindholm [mailto:leif.lindh...@linaro.org]
> Sent: Wednesday, July 17, 2019 6:05 AM
> To: Laszlo Ersek
> Cc: devel@edk2.groups.io; Rebecca
module is being emitted for multiple archs.
>
>This patch is going to Added arch output
>
>Cc: Bob Feng
>Cc: Liming Gao
>Signed-off-by: Zhiju.Fan
>---
> BaseTools/Source/Python/build/BuildReport.py | 2 ++
> 1 file changed, 2 insertions(+)
>
>diff --git a/BaseTool
(CTO).
> New source files added with enhanced definitions are in:
> MdePkg/Include/Protocol/PciPlatform2.h,
> MdePkg/Include/Protocol/PciOverride2.h
>
> Repository: https://github.com/ashrafj/edk2-staging/tree/UEFI_PCI_ENHANCE-2
>
> Signed-off-by: Ashraf Javeed
> Cc: Michael D Kinney
Thanks for your fix. The patch set is good.
Reviewed-by: Liming Gao
>-Original Message-
>From: Xu, Wei6
>Sent: Friday, July 26, 2019 11:11 AM
>To: devel@edk2.groups.io
>Cc: Kinney, Michael D ; Gao, Liming
>
>Subject: [edk2-devel][Patch 0/3] Add destructor to Clo
ing and also the 10b Extended Tag enabling.
> > >
> > > Needs macro definitions for all the ranges of Maximum Payload Sizes
> > > and Maximum Read Request Sizes defined
> > >
> > > Needs macro definitions for all the ranges of Completion Timeout ran
t; The PCIe Device capability register #2
> > > > > (PCI_REG_PCIE_DEVICE_CAPABILITY2) needs to be upgraded for the
> > > > > PCI features like - LN system CLS, 10b Tag completer/requester
> > > > > registe
nce, can you clarify please?
>
Like MdeModulePkg.dsc, it will build the same driver for the different ARCHs.
Thanks
Liming
>>
>> Cc: Bob Feng
>> Cc: Liming Gao
>> Signed-off-by: Zhiju.Fan
>> ---
>> BaseTools/Source/Python/build/BuildReport.py | 2 ++
>&g
i?id=2014
>>
>> Add extra debugging to improve error identification.
>> Error while processing file if the file is read incorrectly
>>
>> This patch is going to fix that issue.
>>
>> Cc: Bob Feng
>> Cc: Liming Gao
>> Signed-off-by: Zhiju.Fa
Reviewed-by: Liming Gao
>-Original Message-
>From: Fan, ZhijuX
>Sent: Friday, July 26, 2019 10:30 AM
>To: devel@edk2.groups.io
>Cc: Gao, Liming ; Feng, Bob C
>Subject: [PATCH] Build Spec:Add Module Arch to BuildRebuild Module Section
>
>BZ:https://bugzilla.tiano
inese
>quotation mark with unicode "
>
>On 7/25/19 5:00 AM, Fan, ZhijuX wrote:
>> From: Sean Brogan
>>
>> BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=2013
>>
>> chinese quotation mark are used in the file
>> This patch is going to fix that is
Reviewed-by: Liming Gao
>-Original Message-
>From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Fan,
>ZhijuX
>Sent: Thursday, July 25, 2019 11:03 AM
>To: devel@edk2.groups.io
>Cc: Feng, Bob C ; Gao, Liming
>; Fan, ZhijuX
>Subject
; Maximum Read Request Sizes defined
>
> Needs macro definitions for all the ranges of Completion Timeout range
> needs to be defined.
>
> Signed-off-by: Ashraf Javeed
> Cc: Michael D Kinney
> Cc: Liming Gao
> Cc: Ray Ni
> Cc: Hao A Wu
> ---
> MdePkg/Include/In
ded Tags, Relax Order, No-Snoop, Active State
> > > Power Management (ASPM),Latency Time Reporting (LTR), AtomicOp,
> > > Reference Clock Configuration, Extended SYNCH, PTM support, and
> > Completion Timeout (CTO).
> > > New source files added with enhanced definitions are in:
>
0.h. If the existing structure is
> > > > > > extended, they can be kept in
> > > > PciExpress21.h.
> > > > > >
> > > > > > Thanks
> > > > > > Liming
> > > > > > > -Original Message-
> >
ded with enhanced definitions are in:
> MdePkg/Include/Protocol/PciPlatform2.h,
> MdePkg/Include/Protocol/PciOverride2.h
>
> Signed-off-by: Ashraf Javeed
> Cc: Michael D Kinney
> Cc: Liming Gao
> Cc: Ray Ni
> ---
> MdePkg/Include/Protocol/PciOverride2.h | 3 ---
Ok. Make sense.
Reviewed-by: Liming Gao
> -Original Message-
> From: Feng, Bob C
> Sent: Monday, July 22, 2019 8:48 AM
> To: Gao, Liming ; devel@edk2.groups.io
> Subject: RE: [edk2-devel] [Patch] BaseTools: Fixed the mis-using strip()
> function issue.
>
>
C tools are compiled first. Their generation files .o/.obj/.d/.pdb should be
ignored.
Signed-off-by: Liming Gao
Cc: Bob Feng
---
Silicon/Intel/Tools/.gitignore | 4
1 file changed, 4 insertions(+)
create mode 100644 Silicon/Intel/Tools/.gitignore
diff --git a/Silicon/Intel/Tools
the
quarter stable tag.
> 2) If Zhichao is now responsible for this, should Jaben and Ray still
>be listed?
>
I think Jaben and Ray can be removed.
Thanks
Liming
> Best Regards,
>
> Leif
>
> On Thu, Sep 19, 2019 at 05:58:16AM +, Gao, Liming wrote:
> > Reviewed-by:
Leif:
For this special case of the single patch to include the changes in cross
packages, I include Laszlo, Fish and Mike for the discussion.
Thanks
Liming
> -Original Message-
> From: Leif Lindholm [mailto:leif.lindh...@linaro.org]
> Sent: Thursday, September 19, 2019 5:45 PM
> To:
hes
>
> From: "Zhang, Shenglei"
>
> As is requested in the BZ 2077, add two switches to support setting
> compression mode and dictionary size.
> (https://bugzilla.tianocore.org/show_bug.cgi?id=2077)
>
> Cc: Bob Feng
> Cc: Liming Gao
> Signe
aintainers.txt.
I will send another patch for this change.
Thanks
Liming
>
> Best Regards,
>
> Leif
>
> > > 2) If Zhichao is now responsible for this, should Jaben and Ray still
> > >be listed?
> > >
> > I think Jaben and Ray can be removed.
>
e header file via
> re.findall in the whole header file.
>
> This patch is to pre-process the header file and
> to feed the shorter string to re.findall.
>
> This patch is to improve GetDependencyList() efficiency
>
> Cc: Liming Gao
> Signed-off-by: Bob Feng
Reviewed-by: Liming Gao for the changes in BaseTools.
>-Original Message-
>From: Leif Lindholm [mailto:leif.lindh...@linaro.org]
>Sent: Thursday, September 19, 2019 6:43 AM
>To: devel@edk2.groups.io
>Cc: Alexei Fedorov ; Ard Biesheuvel
>; Feng, Bob C ; Wu,
>Jiaxin
gt;It should be based on the OS type.
>
>Cc: Liming Gao
>Signed-off-by: Bob Feng
>---
> BaseTools/Source/Python/GenFds/GenFdsGlobalVariable.py | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>diff --git a/BaseTools/Source/Python/GenFds/GenFdsGlobalVariable.py
>
I have no other comments. Reviewed-by: Liming Gao
>-Original Message-
>From: Wu, Hao A
>Sent: Sunday, September 29, 2019 3:31 PM
>To: devel@edk2.groups.io; Zurcher, Christopher J
>; Gao, Liming
>Cc: Kinney, Michael D ; Yao, Jiewen
>; Wang, Jian J
>Subject: RE:
Reviewed-by: Liming Gao
>-Original Message-
>From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
>Bob Feng
>Sent: Friday, September 27, 2019 7:35 PM
>To: devel@edk2.groups.io
>Cc: Gao, Liming ; dann frazier
>; Feng, Bob C
>Subject: [edk2-deve
Tien Hock:
The image is correct. It can be decompressed by lzma.
When FD is loaded into 0x5, I suspect that the image data can't fully
read. Then, the decompress will failure.
FD image last valid byte offset is 0xC1B8F. Its value is 0x83. When FD base
address is 0x5, this
This change is good to me. I also verify it in Emulator platform.
Reviewed-by: Liming Gao
Thanks
Liming
>-Original Message-
>From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
>Laszlo Ersek
>Sent: Friday, September 27, 2019 3:30 AM
>To: devel@ed
Reviewed-by: Liming Gao
> -Original Message-
> From: Fan, ZhijuX
> Sent: Thursday, September 19, 2019 3:45 PM
> To: devel@edk2.groups.io
> Cc: Gao, Liming ; Feng, Bob C
> Subject: [PATCH] BaseTools:"--exclude" don't apply if parameter ends with
Reviewed-by: Liming Gao
>-Original Message-
>From: Philippe Mathieu-Daude [mailto:phi...@redhat.com]
>Sent: Thursday, September 26, 2019 8:05 PM
>To: devel@edk2.groups.io
>Cc: Philippe Mathieu-Daude ; Wang, Jian J
>; Wu, Hao A ; Bi, Dandan
>; Gao, Liming
Can you share the generated FD image? I can help check whether it is generated
correctly with compression.
Thanks
Liming
>-Original Message-
>From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
>Laszlo Ersek
>Sent: Friday, September 27, 2019 3:22 AM
>To:
ShellBinPkg is generated for each edk2 stable tag release.
Cc: Andrew Fish
Cc: Laszlo Ersek
Cc: Leif Lindholm
Cc: Michael D Kinney
Signed-off-by: Liming Gao
---
In v2, use real URL for edk2 release
Maintainers.txt | 15 ---
1 file changed, 8 insertions(+), 7 deletions(-)
diff
Reviewed-by: Liming Gao
>-Original Message-
>From: Leif Lindholm [mailto:leif.lindh...@linaro.org]
>Sent: Friday, September 27, 2019 3:28 AM
>To: devel@edk2.groups.io
>Cc: Ard Biesheuvel ; Feng, Bob C
>; Gao, Liming ; Laszlo Ersek
>
>Subject: [PATCH 1/1] BaseToo
Cc: Michael D Kinney
Liming Gao (12):
BaseTools tools_def.template: Remove unnecessary $(DEST_DIR_DEBUG)
path
BaseTools tools_def: Add CLANG9 tool chain to directly generate PE
image
BaseTools GenFw: Fix the issue to update the wrong size as SectionSize
MdePkg Base.h: Add
Signed-off-by: Liming Gao
---
BaseTools/Conf/build_rule.template | 26 +--
BaseTools/Conf/tools_def.template | 102
+
2 files changed, 118 insertions(+), 10 deletions(-)
diff --git a/BaseTools/Conf/build_rule.template
b
1. Append CLANG CC and LINK flags to generate windows HOST.
2. Modify WinHost to move PCD getting in the late position
Signed-off-by: Liming Gao
---
EmulatorPkg/Win/Host/WinHost.c | 11 +++
EmulatorPkg/EmulatorPkg.dsc | 8 ++--
EmulatorPkg/EmulatorPkg.fdf | 2
Signed-off-by: Liming Gao
---
BaseTools/Source/C/GenFw/GenFw.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/BaseTools/Source/C/GenFw/GenFw.c b/BaseTools/Source/C/GenFw/GenFw.c
index c99782b78e..d8d3360c24 100644
--- a/BaseTools/Source/C/GenFw/GenFw.c
+++ b
Disable warning reported from CLANG9.
Signed-off-by: Liming Gao
---
CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf| 1 +
CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf | 1 +
CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf | 1 +
CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf
Define the same macro in the different OS. It can make CLANG generate the same
image in the different host OS.
Signed-off-by: Liming Gao
---
MdeModulePkg/Library/LzmaCustomDecompressLib/Sdk/C/7zTypes.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MdeModulePkg/Library
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2024
Signed-off-by: Liming Gao
---
OvmfPkg/Sec/SecMain.inf | 4
1 file changed, 4 insertions(+)
diff --git a/OvmfPkg/Sec/SecMain.inf b/OvmfPkg/Sec/SecMain.inf
index 63ba4cb555..cd765cac25 100644
--- a/OvmfPkg/Sec/SecMain.inf
+++ b/OvmfPkg
With this change, global variable _fltused will not be removed by LTO
Signed-off-by: Liming Gao
---
CryptoPkg/Library/IntrinsicLib/MemoryIntrinsics.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/CryptoPkg/Library/IntrinsicLib/MemoryIntrinsics.c
b/CryptoPkg
__inline__ attribute will make the functions not be exposed as the
library interface. It will cause CLANG9 compiler fail.
Signed-off-by: Liming Gao
---
MdePkg/Library/BaseIoLibIntrinsic/IoLibGcc.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/MdePkg/Library/BaseIoLibIntrinsic
$(DEST_DIR_DEBUG) path is in Include directory.
It is not required to be specified again.
Signed-off-by: Liming Gao
---
BaseTools/Conf/tools_def.template | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/BaseTools/Conf/tools_def.template
b/BaseTools
CLANG9 tool chain defines __clang__ macro only,
doesn't define __GNUC__ macro. But, it uses some same definitions with GCC.
So, update base definition for CLANG9 tool chain.
Signed-off-by: Liming Gao
---
MdePkg/Include/Base.h | 6 +++---
MdePkg/Include/Ia32/ProcessorBind.h | 4
Signed-off-by: Liming Gao
---
MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf | 3 +++
1 file changed, 3 insertions(+)
diff --git
a/MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf
b/MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf
send ESC [A through to ESC [D. Add this
>> support for the new introduced terminal type.
>>
>> Cc: Jian J Wang
>> Cc: Hao A Wu
>> Cc: Ray Ni
>> Cc: Liming Gao
>> Signed-off-by: Zhichao Gao
>> ---
>> .../Universal/Console/Termina
1. Apply CLANG9 Linker option.
2. Add -mno-mmx -mno-sse compiler option
Signed-off-by: Liming Gao
---
OvmfPkg/OvmfPkgIa32.dsc| 4 +++-
OvmfPkg/OvmfPkgIa32X64.dsc | 4 +++-
OvmfPkg/OvmfPkgX64.dsc | 4 +++-
3 files changed, 9 insertions(+), 3 deletions(-)
diff --git a/OvmfPkg/OvmfPkgIa32
Reviewed-by: Liming Gao
> -Original Message-
> From: Feng, Bob C
> Sent: Thursday, September 19, 2019 10:57 AM
> To: devel@edk2.groups.io
> Cc: Gao, Liming ; Shi, Steven ;
> Feng, Bob C
> Subject: [Patch] BaseTools: init DependencyHeaderFileSet for each MakeF
EBC compiler doesn't support C11 static_assert macro.
So, define STATIC_ASSERT as empty to pass EBC arch build.
STATIC_ASSERT macro is introduced @204ae9da230ecbf0910c21acac7aa5d5e8cbb8d0
Cc: Michael D Kinney
Signed-off-by: Liming Gao
---
MdePkg/Include/Base.h | 5 -
1 file changed, 4
Mike:
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Michael D
> Kinney
> Sent: Tuesday, September 24, 2019 1:44 AM
> To: Sean Brogan ; devel@edk2.groups.io;
> r...@edk2.groups.io; Kinney, Michael D
>
> Cc: Bret Barkelew
> Subject: Re: [edk2-devel] [RFC] EDK II
t; Subject: Re: [edk2-devel] [Patch] Maintainers.txt: Move ShellBin maintainers
> to EDK II Releases section
>
> Hi Liming,
>
> On 9/24/19 3:19 AM, Liming Gao wrote:
> > ShellBinPkg is generated for each edk2 stable tag release.
> >
> > Cc: Andrew Fish
> >
day, September 24, 2019 6:41 PM
> >> To: devel@edk2.groups.io; Gao, Liming ; Leif
> >> Lindholm
> >> Cc: Andrew Fish ; Laszlo Ersek ;
> >> Kinney, Michael D
> >> Subject: Re: [edk2-devel] [Patch] Maintainers.txt: Move ShellBin
> >> mai
This reverts commit bc9e4194cf3edaf9524c83098ba3f72008c70190.
This change causes the dependent header files are missing in Makefile.
It makes the incremental build not work. So, revert this change.
Cc: Bob Feng
Signed-off-by: Liming Gao
---
BaseTools/Source/Python/AutoGen/GenMake.py | 29
This version is good. Reviewed-by: Liming Gao
> -Original Message-
> From: Zhang, Shenglei
> Sent: Friday, September 20, 2019 10:29 AM
> To: devel@edk2.groups.io
> Cc: Zhang, Shenglei ; Feng, Bob C
> ; Gao, Liming
> Subject: [PATCH v4] BaseTools/LzmaCompress: Add t
I just push @d7bf973e43ad949706f936f61cd6be8e63ce136f
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Gao,
> Zhichao
> Sent: Friday, September 20, 2019 2:11 PM
> To: Ni, Ray ; Carsey, Jaben ;
> devel@edk2.groups.io
> Cc: Kinney, Michael D ;
Reviewed-by: Liming Gao
>-Original Message-
>From: Zhang, Shenglei
>Sent: Monday, September 30, 2019 11:52 AM
>To: devel@edk2.groups.io
>Cc: Feng, Bob C ; Gao, Liming
>Subject: [PATCH] BaseTools/LzmaCompress: Fix the option "d" dictionary size
>
>The ra
Reviewed-by: Liming Gao
>-Original Message-
>From: Yao, Jiewen
>Sent: Sunday, September 29, 2019 2:16 PM
>To: devel@edk2.groups.io
>Cc: Kinney, Michael D ; Gao, Liming
>
>Subject: [PATCH 1/3] MdePkg/Include: correct Lasa in Tpm2Acpi.
>
>Correct Lasa accord
Hi, all
Some Edk2 package maintainers are in China. We will take Chinese National
Holiday (Oct.1 ~ Oct.7).
In this period, Michael D Kinney will be the backup maintainers for those Edk2
packages. Thanks for Mike great support.
Thanks
Liming
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive
ShellBinPkg is generated for each edk2 stable tag release.
Cc: Andrew Fish
Cc: Laszlo Ersek
Cc: Leif Lindholm
Cc: Michael D Kinney
Signed-off-by: Liming Gao
---
Maintainers.txt | 13 ++---
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/Maintainers.txt b
Leif:
>-Original Message-
>From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Leif
>Lindholm
>Sent: Friday, September 20, 2019 4:27 AM
>To: Laszlo Ersek
>Cc: devel@edk2.groups.io; Gao, Liming ; Baptiste
>Gerondeau ; ard.biesheu...@linaro.org;
>Kinney, Michael D ;
Push
6b80310f34199d1f62e45e40fa902734735091fa..670c903a68f214463f12c0c9619c162a0f342518
You can update BZ 2182 and close it.
Thanks
Liming
>-Original Message-
>From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
>Cheng, Ching JenX
>Sent: Thursday, September 19, 2019
So, this is just indentation update. There is no functionality impact. What
test have you done?
Thanks
Liming
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> rebe...@bluestop.org
> Sent: Thursday, June 27, 2019 12:55 AM
> To:
Push
@03835a8c7325d5ddd0b03ee412a8a08d88258128..080981d72dcbb782ad73716c439639324b0aa4dd
If you meet with the issue, please let me know.
Thanks
Liming
>-Original Message-
>From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
>Liming Gao
>Sent: Monday, Jul
Reviewed-by: Liming Gao
>-Original Message-
>From: Zhang, Shenglei
>Sent: Friday, July 05, 2019 10:40 PM
>To: devel@edk2.groups.io
>Cc: Feng, Bob C ; Gao, Liming
>Subject: [PATCH 0/3] BaseTools: Change FMMT,BfmLib and FCE script type in
>PosixLike
>
>The e
, Jiewen
>Subject: [PATCH v1 1/1] BaseTools: Add HOST_APPLICATION module type.
>
>From: Jiewen Yao
>
>It can be used to indicate a module can be build to run
>as OS application and run in OS environment.
>
>Cc: Bob Feng
>Cc: Liming Gao
>Cc: Jiewen Yao
er of these approaches currently works
>
>This patch is going to fix that issue.
>
>Cc: Liming Gao
>Cc: Bob Feng
>Signed-off-by: Zhiju.Fan
>---
>keep original behavior on
>--exclude for the directory name or file name.
>
> BaseTools/Scripts/FormatDosFiles.py |
501 - 600 of 1272 matches
Mail list logo