Re: [edk2-devel] [Patch] GenBiosId: Fixed a regression bug introduced by 8b72f720d53e

2019-12-22 Thread Liming Gao
Reviewed-by: Liming Gao > -Original Message- > From: Feng, Bob C > Sent: Friday, December 20, 2019 4:42 PM > To: devel@edk2.groups.io > Cc: Gao, Liming ; Kilian Kegel > > Subject: [Patch] GenBiosId: Fixed a regression bug introduced by 8b72f720d53e > &

Re: [edk2-devel] [PATCH] MdePkg/Spdm: fix Nonce structure error.

2019-12-18 Thread Liming Gao
Jiewen: The change is good. Have you found any impact in the existing code? Reviewed-by: Liming Gao Thanks Liming > -Original Message- > From: Yao, Jiewen > Sent: Wednesday, December 18, 2019 11:00 AM > To: devel@edk2.groups.io > Cc: Kinney, Michael D ; Gao, Limin

Re: [edk2-devel] ASAP Issue in PciExpress21.h

2019-12-18 Thread Liming Gao
I just send the patch mail to the mail list https://edk2.groups.io/g/devel/message/52350. Please review this one. Thanks Liming From: Banaszek, Daniel Pawel Sent: Wednesday, December 18, 2019 4:37 PM To: devel@edk2.groups.io Cc: Gao, Liming ; Ni, Ray Subject: RE: ASAP Issue in PciExpress21.h

[edk2-devel] [Patch] MdePkg PciExpress21: PCI_REG_PCIE_DEVICE_CONTROL2 struct has 17 bits

2019-12-18 Thread Liming Gao
From: Daniel Pawel Banaszek Device Control 2 Structure have an issue. LtrMechanism - there is 2 bits instead of 1. Signed-off-by: Daniel Pawel Banaszek Reviewed-by: Liming Gao Cc: Ray Ni --- MdePkg/Include/IndustryStandard/PciExpress21.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion

Re: [edk2-devel] [Patch] MdePkg PciExpress21: PCI_REG_PCIE_DEVICE_CONTROL2 struct has 17 bits

2019-12-18 Thread Liming Gao
Yes. We keep the same name to avoid the incompatible issue. Thanks Liming From: devel@edk2.groups.io On Behalf Of Javeed, Ashraf Sent: Wednesday, December 18, 2019 10:55 PM To: Javeed; Javeed, Ashraf ; devel@edk2.groups.io Subject: Re: [edk2-devel] [Patch] MdePkg PciExpress21:

Re: [edk2-devel] [PATCH] MdePkg/Tcg: Add new definition in TCG PFP spec.

2019-12-19 Thread Liming Gao
That's good. Reviewed-by: Liming Gao >-Original Message- >From: Yao, Jiewen >Sent: Thursday, December 19, 2019 10:54 PM >To: Gao, Liming >Cc: devel@edk2.groups.io; Kinney, Michael D >Subject: Re: [edk2-devel] [PATCH] MdePkg/Tcg: Add new definition in TCG >P

Re: [edk2-devel] [PATCH v1] MdePkg: Use __builtin_offset with CLANGPDB toolchain

2019-12-19 Thread Liming Gao
merge@796b380ca7d263ca504b82fe5317a78d3546d537 >-Original Message- >From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >Liming Gao >Sent: Wednesday, December 18, 2019 10:07 AM >To: devel@edk2.groups.io; Gao, Liming ; Alex James > >Cc: Kinney, Mich

Re: [edk2-devel] [Patch 1/1] BaseTools: Remove PCD_TOKEN define for FixedAtBuild PCD

2019-12-17 Thread Liming Gao
en.c and Autogen.h but there is no code use that Macro, >so this patch is going to remove this Macro from autogen files. > >This change can improve incremental build function. > >Cc: Liming Gao >Cc: Steven Shi >Signed-off-by: Bob Feng >--- > BaseTools/Source/Pyth

Re: [edk2-devel] [PATCH v1] MdePkg: Use __builtin_offset with CLANGPDB toolchain

2019-12-17 Thread Liming Gao
Alex has verified this change on OVMF boot to shell. I have no other comment for it. Reviewed-by: Liming Gao Thanks Liming >-Original Message- >From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >Liming Gao >Sent: Tuesday, December 10, 2019 8:50 AM >

Re: [edk2-devel] [Patch 1/1] BaseTools: Resolve a issue of Incremental build

2019-12-17 Thread Liming Gao
Reviewed-by: Liming Gao >-Original Message- >From: Feng, Bob C >Sent: Tuesday, December 17, 2019 9:55 AM >To: devel@edk2.groups.io >Cc: Gao, Liming ; Shi, Steven ; >Kinney, Michael D >Subject: [Patch 1/1] BaseTools: Resolve a issue of Increment

Re: [edk2-devel] [PATCH] MdePkg/Spdm: fix Nonce structure error.

2019-12-18 Thread Liming Gao
ney, Michael D >> Subject: RE: [PATCH] MdePkg/Spdm: fix Nonce structure error. >> >> Jiewen: >> The change is good. Have you found any impact in the existing code? >> >> Reviewed-by: Liming Gao >> >> Thanks >> Liming >> > -Origi

Re: [edk2-devel] Public-Service-Announcement: send-email issues with Git 2.22.0+

2019-12-03 Thread Liming Gao
Nate: Thanks for your sharing. I apply this command in my development machine. Thanks Liming >-Original Message- >From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >Nate DeSimone >Sent: Wednesday, December 04, 2019 12:31 PM >To: devel@edk2.groups.io >Subject:

Re: [edk2-devel] [PATCH v2 1/1] MdePkg: Add PCCT table signature definition

2020-02-13 Thread Liming Gao
Push @a67efa3b22113cc9b52f8e56e50466d6da0ab11e > -Original Message- > From: devel@edk2.groups.io On Behalf Of Liming Gao > Sent: Thursday, February 13, 2020 8:59 AM > To: Krzysztof Koch ; devel@edk2.groups.io > Cc: Kinney, Michael D ; matteo.carl...@arm.com; > sami.

Re: [edk2-devel] PCD Migration issue

2020-02-11 Thread Liming Gao
Andrew: Current implementation requires PEI PcdDB and DXE PcdDB match. This is like a new request for PCD DataBase. It requests PCD DB binary format and Dynamic PCD token assignment be compatible in the different version. Thanks Liming > -Original Message- > From: devel@edk2.groups.io

Re: [edk2-devel] [PATCH] MdePkg: Add PCI Express 5.0 Header File

2020-02-11 Thread Liming Gao
Reviewed-by: Liming Gao PR https://github.com/tianocore/edk2/pull/366 > -Original Message- > From: Felix Polyudov > Sent: Wednesday, February 12, 2020 6:35 AM > To: Gao, Liming ; 'devel@edk2.groups.io' > > Subject: RE: [PATCH] MdePkg: Add PCI Express 5.0 Heade

Re: [edk2-devel] [PATCH] BaseTools: remove -DNO_MSABI_VA_FUNCS option in CLANGPDB tool chain

2020-02-11 Thread Liming Gao
Reviewed-by: Liming Gao > -Original Message- > From: Liu, Zhiguang > Sent: Wednesday, February 12, 2020 9:40 AM > To: devel@edk2.groups.io > Cc: Feng, Bob C ; Gao, Liming > Subject: [PATCH] BaseTools: remove -DNO_MSABI_VA_FUNCS option in CLANGPDB > tool

Re: [edk2-devel] [PATCH 1/1] BaseTools: Switch to GNU mode for CLANGPDB

2020-02-10 Thread Liming Gao
Vitaly: Can you update this patch based on the latest edk2 trunk? I will catch it for edk2 Q1 stable tag. Thanks Liming From: devel@edk2.groups.io On Behalf Of Liming Gao Sent: Tuesday, February 11, 2020 1:34 PM To: vit9696 ; devel@edk2.groups.io Subject: Re: [edk2-devel] [PATCH 1/1

Re: [edk2-devel] [PATCH 1/1] BaseTools: Switch to GNU mode for CLANGPDB

2020-02-10 Thread Liming Gao
Reviewed-by: Liming Gao From: vit9696 Sent: Tuesday, February 11, 2020 3:23 AM To: Gao, Liming ; devel@edk2.groups.io Subject: RE: [edk2-devel] [PATCH 1/1] BaseTools: Switch to GNU mode for CLANGPDB Liming, We did run several of our projects based on EDK II in X64 mode, DEBUG, RELEASE, NOOPT

Re: [edk2-devel] [PATCH v2] Add support for Diagnostics ACM in FitGen tool

2020-02-10 Thread Liming Gao
Push @ 8864a1ad2f090e8f71bb4a5da873baf903f5e053 > -Original Message- > From: devel@edk2.groups.io On Behalf Of Liming Gao > Sent: Monday, February 10, 2020 10:10 PM > To: Agrawal, Sachin ; devel@edk2.groups.io > Cc: Feng, Bob C > Subject: Re: [edk2-devel] [PAT

Re: [edk2-devel] [PATCH 1/1] BaseTools: Switch to GNU mode for CLANGPDB

2020-02-12 Thread Liming Gao
ing From: devel@edk2.groups.io<mailto:devel@edk2.groups.io> mailto:devel@edk2.groups.io>> On Behalf Of Liming Gao Sent: Tuesday, February 11, 2020 1:34 PM To: vit9696 mailto:vit9...@protonmail.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io> Subject: Re: [edk2-devel] [PA

Re: [edk2-devel] PCD Migration issue

2020-02-12 Thread Liming Gao
o freeze Dynamic PCD usage in > your common core? > > Thanks, > > Andrew Fish > > > On Feb 11, 2020, at 7:54 PM, Liming Gao wrote: > > > > Andrew: > > Current implementation requires PEI PcdDB and DXE PcdDB match. This is > > like a n

Re: [edk2-devel] [PATCH v1 1/1] MdePkg: Add PCCT table signature definition

2020-02-12 Thread Liming Gao
Krzysztof: Sorry to miss this patch. I see PCCT table is added since ACPI 5.0. So, I think its table signature definition should also be added into Acpi50.h, Acpi51.h, Acpi60.h, Acpi61.h and Acpi62.h. Thanks Liming > -Original Message- > From: Krzysztof Koch > Sent: Wednesday,

Re: [edk2-devel] [Patch] IntelSiliconPkg: Declare zero array explicitly to avoid compiler error.

2020-02-25 Thread Liming Gao
Reviewed-by: Liming Gao > -Original Message- > From: devel@edk2.groups.io On Behalf Of Siyuan, Fu > Sent: Wednesday, February 26, 2020 9:08 AM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Chaganty, Rangasai V > > Subject: [edk2-devel] [Patch] IntelSiliconPk

Re: [edk2-devel] [PATCH 0/2] UefiCpuPkg/Library: Fix bug in MpInitLib

2020-02-26 Thread Liming Gao
Leo: Now, we enter into Hard Feature Freeze phase until edk2-stable202002 tag is created at 2020-02-28. Only critical bug fix is still allowed. Do you request to catch this fix into this stable tag? If yes, please work closely with UefiCpuPkg maintainers to catch the stable tag release

Re: [edk2-devel] [Patch] IntelSiliconPkg/ShadowMicrocodePei: Fix GCC build error.

2020-02-26 Thread Liming Gao
elSiliconPkg/ShadowMicrocodePei: Fix GCC build > > > > error. > > > > > > > > > > What compiler does not like the flexible array > > > > > member syntax []. > > > > > > > > > > Mike > > > > > &

Re: [edk2-devel] [PATCH] IntelSiliconPkg: Issue reported by ECC in edk2-platforms.

2020-03-04 Thread Liming Gao
This patch is for [edk2-platform]. So, please generate the patch with it. Below command can be used. git format-patch -1 --subject-prefix="edk2-platform][patch" > -Original Message- > From: devel@edk2.groups.io On Behalf Of Zhang, Shenglei > Sent: Thursday, March 5, 2020 1:05 PM > To:

Re: [edk2-announce] [edk2-devel] EDK II Stable Tag release edk2-stable202002 completed

2020-03-04 Thread Liming Gao
> annou...@edk2.groups.io > Cc: Guptha, Soumya K ; Kinney, Michael D > ; af...@apple.com; > l...@nuviainc.com; Ard Biesheuvel ; Liran Alon > ; Nikita Leshenko > > Subject: Re: [edk2-announce] [edk2-devel] EDK II Stable Tag release > edk2-stable202002 completed > > Hi Lim

Re: [edk2-devel] [PATCH v2 3/3] MdeModulePkg: Use CopyMem instead of GUID assignment

2020-03-02 Thread Liming Gao
Daniel: I agree this fix. But, I don't meet with this failure with GCC on IA32/X64 arch. So, I don't fix it early. Reviewed-by: Liming Gao Thanks Liming > -Original Message- > From: devel@edk2.groups.io On Behalf Of Daniel Schaefer > Sent: Monday, March 2, 2020 6:33 PM &g

Re: [edk2-devel] [PATCH v1] ShellPkg: Fix 'ping' command Ip4 receive flow.

2020-03-02 Thread Liming Gao
w. > >> > >> Laszlo, > >> > >> Thanks for the detailed response on the patch. Always happy to learn > >> about stuff from the past. > >> > >> Liming, > >> > >> I am currently the maintainer of NetworkPkg :) If you require add

Re: [edk2-devel] [PATCH v2 2/3] MdeModulePkg: Set PcdDxeIplSwitchToLongMode false on non-x86

2020-03-02 Thread Liming Gao
her architectures. > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2548 > > Signed-off-by: Daniel Schaefer > Cc: Abner Chang > Cc: Gilbert Chen > Cc: Leif Lindholm > Cc: Dandan Bi > Cc: Liming Gao > --- > MdeModulePkg/MdeModulePkg.dec | 3 +++

Re: [edk2-devel] [PATCH v2 01/16] MdeModulePkg/PiSmmCore: log SMM image start failure

2020-03-02 Thread Liming Gao
Laszlo: The change refers to the same logic in DxeMain logic. So, it makes sense. Reviewed-by: Liming Gao Thanks Liming > -Original Message- > From: devel@edk2.groups.io On Behalf Of Laszlo Ersek > Sent: Monday, March 2, 2020 8:47 PM > To: Dong, Eric ; Wu, Hao A ; Wan

Re: [edk2-devel] [PATCH v2 1/3] MdeModulePkg: Restrict libraries using SMM to x86

2020-03-02 Thread Liming Gao
6. > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2549 > > Signed-off-by: Daniel Schaefer > Cc: Abner Chang > Cc: Gilbert Chen > Cc: Leif Lindholm > Cc: Eric Dong > Cc: Ray Ni > Cc: Hao A Wu > Cc: Dandan Bi > Cc: Liming Gao > --- > >

[edk2-devel] EDK II Stable Tag edk2-stable202002 will be created based on commit 4c0f6e349d32cf27a7104ddd3e729d6ebc88ea70

2020-03-03 Thread Liming Gao
Hi, all edk2-stable202002 tag will be created on Mar 4th (UTC-8 00:00:00). It will base on current edk2 trunk (the latest commit https://github.com/tianocore/edk2/commit/4c0f6e349d32cf27a7104ddd3e729d6ebc88ea70 UefiCpuPkg/MpInitLib: Skip reading PlatformId on AMD processors). If you have any

Re: [edk2-devel] [PATCH v3 0/1] Add PCD to disable safe string constraint assertions

2020-03-03 Thread Liming Gao
; vit9696 ; Gao, Liming ; Gao, Zhichao ; Laszlo Ersek Subject: Re: [edk2-devel] [PATCH v3 0/1] Add PCD to disable safe string constraint assertions Good day, Unfortunately, this discussion has died again. This is fine by me, I'm also fine with the already proposed patch and mostly shared different

[edk2-devel] EDK II Stable Tag release edk2-stable202002 completed

2020-03-04 Thread Liming Gao
Hi, all The tag edk2-stable202002 has been created. https://github.com/tianocore/edk2/releases/tag/edk2-stable202002 git clone -b edk2-stable202002 https://github.com/tianocore/edk2.git The tag edk2-stable202002 has been added into the main EDK II Wiki page.

Re: [edk2-devel] [PATCH v1] ShellPkg: Fix 'ping' command Ip4 receive flow.

2020-02-27 Thread Liming Gao
Also include NetworkPkg reviewer to collect the feedback for this change. Thanks Liming > -Original Message- > From: Laszlo Ersek > Sent: Friday, February 28, 2020 1:40 AM > To: devel@edk2.groups.io; maciej.rab...@linux.intel.com; Gao, Liming > ; Kinney, Michael D > ; Andrew Fish ;

Re: [edk2-devel] Patch List for 202002 stable tag

2020-02-27 Thread Liming Gao
olm wrote: > > Hi Liming, > > > > On Thu, Feb 27, 2020 at 16:06:22 +, Liming Gao wrote: > >> Stewards: > >> I update the patch lists and status. Based on current information, > >> only one patch (item 5) needs catch this stable tag. Its fix is > >

Re: [edk2-devel] [Patch] IntelSiliconPkg/ShadowMicrocodePei: Fix GCC build error.

2020-02-26 Thread Liming Gao
> error. > > > > This patch fixes compiler error introduced by commit > > b0099a39bd. > > > > BZ: > > https://tianocore.acgmultimedia.com/show_bug.cgi?id=244 > > 9 > > Cc: Ray Ni > > Cc: Rangasai V Chaganty > > Cc: Liming Gao > > Signed-off-b

Re: [edk2-devel] [Patch] IntelSiliconPkg/ShadowMicrocodePei: Fix GCC build error.

2020-02-26 Thread Liming Gao
k2.groups.io > > > > Cc: Ni, Ray ; Chaganty, Rangasai > > V > > > > ; Gao, Liming > > > > > > > > Subject: [edk2-devel] [Patch] > > > > IntelSiliconPkg/ShadowMicrocodePei: Fix GCC build > > > > error. > > > > > >

Re: [edk2-devel] [Patch] IntelSiliconPkg/ShadowMicrocodePei: Fix GCC build error.

2020-02-26 Thread Liming Gao
Reviewed-by: Liming Gao > -Original Message- > From: Fu, Siyuan > Sent: Thursday, February 27, 2020 9:58 AM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Chaganty, Rangasai V > ; Gao, Liming > Subject: [Patch] IntelSiliconPkg/ShadowMicrocodePei: Fix GCC build error.

Re: [edk2-devel] [PATCH v1] ShellPkg: Fix 'ping' command Ip4 receive flow.

2020-02-28 Thread Liming Gao
ently the maintainer of NetworkPkg :) If you require additional > feedback from Siyuan or/and Jiaxin, that's ok. > Please let me know if any corrections to the patch (like CVE note) are > required from your point of view. > > Thanks, > Maciej > > On 28-Feb-20 03:59, Liming

Re: [edk2-devel] [PATCH v3 5/6] MdeModulePkg/DxeCore: defer PE/COFF emulator registration to StartImage

2020-02-28 Thread Liming Gao
Ard: I think this change is OK. Ack-by: Liming Gao Thanks Liming > -Original Message- > From: devel@edk2.groups.io On Behalf Of Ard Biesheuvel > Sent: Friday, February 28, 2020 1:11 AM > To: edk2-devel-groups-io ; Wu, Hao A > ; Wang, Jian J ; Gao, > Zhichao ; Ni,

Re: [edk2-devel] [Patch 1/1][edk2-stable202002]BaseTools: Fixed a regression issue in Makefile for incremental build

2020-02-27 Thread Liming Gao
g the incremental build with this > > fix. > > There is no impact on the clean build. > > > > Cc: Andrew Fish > > Cc: Laszlo Ersek > > Cc: Leif Lindholm > > Cc: Michael D Kinney > > Cc: Pierre Gondois > > Signed-off-by: Bob Feng >

Re: [edk2-devel] [Patch] BaseTools: Remove invalid leading space before !INCLUDE in Makefile

2020-02-27 Thread Liming Gao
Reviewed-by: Liming Gao Tested-by: Liming Gao -Original Message- > From: devel@edk2.groups.io On Behalf Of Bob Feng > Sent: Thursday, February 27, 2020 10:25 PM > To: devel@edk2.groups.io > Cc: Andrew Fish ; Laszlo Ersek ; Leif > Lindholm ; Kinney, Michael D >

[edk2-devel] Extend Hard Feature Freeze by a few days for edk2-stable202002

2020-02-28 Thread Liming Gao
Hi, all Yesterday, one critical issue was reported. Its fix required more time to be reviewed and verified. Here is the discussion https://edk2.groups.io/g/devel/message/55047. So, two stewards suggested to extend Hard Feature Freeze by a few days. Now, we are still in Hard Feature Freeze

Re: [edk2-devel] Patch List for 202002 stable tag

2020-02-27 Thread Liming Gao
Of Liming Gao Sent: Friday, February 21, 2020 4:23 PM To: devel@edk2.groups.io; Gao, Liming ; Ni, Ray ; vit9696 ; gaurav.j...@nxp.com Cc: Kinney, Michael D ; Laszlo Ersek ; Guptha, Soumya K ; l...@nuviainc.com; af...@apple.com; Marvin Häuser ; Gao, Zhichao ; 'ard.biesheu...@linaro.org' ; Wu, Hao

Re: [edk2-devel] [PATCH edk2-stable202002] OvmfPkg/QemuVideoDxe: unbreak "secondary-vga" and "bochs-display" support

2020-02-25 Thread Liming Gao
Laszlo: Seemly, this is a regression issue. I am ok to catch it into stable tag edk2-stable202002. Thanks Liming > -Original Message- > From: devel@edk2.groups.io On Behalf Of Ard Biesheuvel > Sent: Tuesday, February 25, 2020 1:21 AM > To: Laszlo Ersek > Cc: edk2-devel-groups-io ;

Re: [edk2-devel] Extend Hard Feature Freeze by a few days for edk2-stable202002

2020-03-02 Thread Liming Gao
.groups.io On Behalf Of Liming Gao Sent: 2020年2月28日 16:23 To: annou...@edk2.groups.io; devel@edk2.groups.io Cc: Guptha, Soumya K ; Kinney, Michael D ; af...@apple.com; Laszlo Ersek ; l...@nuviainc.com Subject: [edk2-announce] Extend Hard Feature Freeze by a few days for edk2-stable202002 Hi, all

Re: [edk2-devel] Patch List for 202002 stable tag

2020-03-03 Thread Liming Gao
Hi, Stewards and all: Below three patches status are updated. If you have no other comments, I will create edk2-stable202002 tomorrow and send the announcement. https://edk2.groups.io/g/devel/message/55105 [PATCH 0/2] UefiCpuPkg/Library: Fix bug in MpInitLib (BZ: 2556) [Liming 2020-02-28]

Re: [edk2-devel] [PATCH 0/1] Use _MSC_VER to determine MSVC compiler

2020-02-06 Thread Liming Gao
Vitaly: We also find _MSC_VER is defined in Windows, but not in Linux. Your analysis explains it. When use i686-unknown-windows-gnu option, __GNUC__ macro will be defined. If so, we don’t need to append the check for defined (__clang__) in Base.h. And, this change can remove

Re: [edk2-devel] [PATCH] BaseTools: Enhance call stack unwindability for CLANGPDB x64 binary

2020-02-06 Thread Liming Gao
Reviewed-by: Liming Gao > -Original Message- > From: Shi, Steven > Sent: Tuesday, February 4, 2020 3:49 PM > To: Gao, Liming ; devel@edk2.groups.io > Cc: Feng, Bob C > Subject: RE: [PATCH] BaseTools: Enhance call stack unwindability for CLANGPDB > x64 b

Re: [edk2-devel] [edk2-platforms][PATCH V1 1/1] Maintainers.txt: Remove Intel maintainer

2020-01-31 Thread Liming Gao
Reviewed-by: Liming Gao > -Original Message- > From: devel@edk2.groups.io On Behalf Of Kubacki, > Michael A > Sent: Friday, January 31, 2020 12:41 PM > To: devel@edk2.groups.io > Cc: Agyeman, Prince ; Chaganty, Rangasai V > ; Chiu, Chasel > ; Desimone, Nath

Re: [edk2-devel] [Patch] BaseTools/Build: Fix Structured PCD app host env issues

2020-01-31 Thread Liming Gao
tag. > > Also reduce the build dependencies for the Structured PCD > application to increase compiler compatibility. > > Cc: Bob Feng > Cc: Liming Gao > Signed-off-by: Michael D Kinney > --- > .../Source/Python/Workspace/DscBuildData.py | 35 +++ > 1

Re: [edk2-devel] [PATCH v2] BaseTools/Conf/gitattributes: fix "--function-context" for C source code

2020-01-31 Thread Liming Gao
Laszlo: I am back. This change is good. Reviewed-by: Liming Gao Thanks Liming > -Original Message- > From: devel@edk2.groups.io On Behalf Of Laszlo Ersek > Sent: Friday, January 31, 2020 4:34 PM > To: Kinney, Michael D > Cc: edk2-devel-groups-io ; Feng, Bob C &g

Re: [edk2-devel] [Patch] BaseTools/DscBuildData: Fix PCD autogen include file conflict

2020-02-02 Thread Liming Gao
> > support > > > building Open SSL. The Library/Include path is > > listed as a > > > private include path in CryptoPkg.dec. Without this > > change, the > > > standard include files designed to support build > > OpenSLL are > > >

[edk2-devel] [Patch] MdePkg Base.h: Use correct style to check macro _MSC_VER value

2020-02-03 Thread Liming Gao
Signed-off-by: Zhiguang Liu Reviewed-by: Liming Gao --- MdePkg/Include/Base.h | 2 +- MdePkg/Include/Ia32/ProcessorBind.h | 2 +- MdePkg/Include/X64/ProcessorBind.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/MdePkg/Include/Base.h b/MdePkg/Include

Re: [edk2-devel] [PATCH 0/1] Use _MSC_VER to determine MSVC compiler

2020-02-03 Thread Liming Gao
Vitaly: This change will cause CryptoPkg openssl build failure, because OpensslLib.inf undefines _MSC_VER macro to make sure openssl source code be built in edk2 project without using MS VS functions. Now, I have no good solution to fix this issue. One way is to use

Re: [edk2-devel] [PATCH v2 1/1] BaseTools: Script for converting .aml to .hex

2020-02-03 Thread Liming Gao
Pierre: Sorry for late response. I have one comment. Why only allows "DSDT" or "SSDT" in Signature? Thanks Liming > -Original Message- > From: Pierre Gondois > Sent: Thursday, January 23, 2020 1:32 AM > To: Pierre Gondois ; devel@edk2.groups.io > Cc: ard.biesheu...@linaro.org; Feng,

Re: [edk2-devel] [PATCH v1 1/1] BaseTools: Rationalise makefile generation

2020-02-03 Thread Liming Gao
Pierre: Thanks for your contribution. Do you verify below configurations? And, how do you verify Windows host + GCC make? 1. Windows Host + VS nmake 2. Windows Host + GCC make 3. Linux Host + GCC make. Thanks Liming > -Original Message- > From: Pierre Gondois > Sent: Thursday, January

Re: [edk2-devel] [PATCH 2/2] MdePkg: Use the same VA function for both CLANGPDB and CLANG38

2020-02-03 Thread Liming Gao
Reviewed-by: Liming Gao > -Original Message- > From: Liu, Zhiguang > Sent: Monday, February 3, 2020 4:15 PM > To: devel@edk2.groups.io > Cc: Kinney, Michael D ; Gao, Liming > > Subject: [PATCH 2/2] MdePkg: Use the same VA function for both CLANGPDB and >

Re: [edk2-devel] [PATCH 1/2] BaseTools: append -DNO_MSABI_VA_FUNCS option in CLANGPDB tool chain

2020-02-03 Thread Liming Gao
Reviewed-by: Liming Gao > -Original Message- > From: Liu, Zhiguang > Sent: Monday, February 3, 2020 4:15 PM > To: devel@edk2.groups.io > Cc: Feng, Bob C ; Gao, Liming > Subject: [PATCH 1/2] BaseTools: append -DNO_MSABI_VA_FUNCS option in CLANGPDB > tool

Re: [edk2-devel] [PATCH v2 1/1] BaseTools: Script for converting .aml to .hex

2020-02-03 Thread Liming Gao
s. We don't need to generate a ".hex" file for > other ACPI tables or any other file since we would like to parse AML bytecode. > However this is only a safety check and this can be removed if desired. > > Regards, > Pierre > > -----Original Message- > From:

[edk2-devel] [Patch] BaseTools tools_def.template: Add back -fno-pie option in GCC49 tool chain

2020-02-03 Thread Liming Gao
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2502 This option is required to make GCC49 tool chain work with the high version GCC compiler. Cc: Bob Feng Signed-off-by: Liming Gao --- BaseTools/Conf/tools_def.template | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [edk2-devel] [PATCH 2/5] MdePkg: Allow PcdFSBClock to by Dynamic

2020-02-03 Thread Liming Gao
Thanks for your data. Seemly, those data is acceptable on OvmfXen. For this patch, Reviewed-by: Liming Gao Thanks Liming > -Original Message- > From: devel@edk2.groups.io On Behalf Of Anthony PERARD > Sent: Tuesday, February 4, 2020 1:26 AM > To: Gao, Liming > Cc: Laszl

Re: [edk2-devel] [PATCH 0/1] Use _MSC_VER to determine MSVC compiler

2020-02-03 Thread Liming Gao
Vitaly: Yes. I think we should have better solution in OpenSSL to support EDK2 usage. But, this is a long term solution. For now, I will try the solution to remove -fms-compatibility option in CLANGPDB tool chain. Thanks Liming From: vit9696 Sent: Monday, February 3, 2020 7:29 PM To: Gao,

[edk2-devel] [edk2-platform][patch v2] FitGen: Fix the issue to run in X64 linux machine

2020-02-04 Thread Liming Gao
: Bob Feng Cc: Isaac Oram Signed-off-by: Liming Gao --- In V2, add the detail commit message. Silicon/Intel/Tools/FitGen/FitGen.c | 31 --- Silicon/Intel/Tools/FitGen/FitGen.h | 2 +- 2 files changed, 21 insertions(+), 12 deletions(-) diff --git a/Silicon/Intel/Tools

Re: [edk2-devel] [Patch V2 1/2] BaseTools: append -DNO_MSABI_VA_FUNCS option in CLANGPDB tool chain

2020-02-03 Thread Liming Gao
Reviewed-by: Liming Gao > -Original Message- > From: Liu, Zhiguang > Sent: Tuesday, February 4, 2020 10:21 AM > To: devel@edk2.groups.io > Cc: Feng, Bob C ; Gao, Liming > Subject: [Patch V2 1/2] BaseTools: append -DNO_MSABI_VA_FUNCS option in > CLANGPDB tool

Re: [edk2-devel] [Patch V2 2/2] MdePkg: Avoid using __clang__ to specify CLANGPDB

2020-02-03 Thread Liming Gao
Reviewed-by: Liming Gao > -Original Message- > From: Liu, Zhiguang > Sent: Tuesday, February 4, 2020 10:21 AM > To: devel@edk2.groups.io > Cc: Kinney, Michael D ; Gao, Liming > > Subject: [Patch V2 2/2] MdePkg: Avoid using __clang__ to specify CL

Re: [edk2-devel] [PATCH] BaseTools: Enhance call stack unwindability for CLANGPDB x64 binary

2020-02-03 Thread Liming Gao
me. > Enhance the build options to force emit the unwind tables and > keep the data of pdata and xdata sections correct in the binary. > > Signed-off-by: Steven Shi > Cc: Liming Gao > Cc: Bob Feng > --- > BaseTools/Conf/tools_def.template | 16 +

Re: [edk2-devel] [Patch] BaseTools/DscBuildData: Fix PCD autogen include file conflict

2020-02-03 Thread Liming Gao
Mike: If we document this assumption in build specification, I agree this patch. Can you enter one BZ for build spec update? For this patch, Reviewed-by: Liming Gao Thanks Liming > -Original Message- > From: Kinney, Michael D > Sent: Tuesday, February 4, 2020 1:52 AM

Re: [edk2-devel] [Patch] BaseTools/DscBuildData: Fix PCD autogen include file conflict

2020-02-02 Thread Liming Gao
subset of the standard C lib will run into this same issue > if they also define and use a Structured PCD. So this issue > is not limited to the CryptoPkg. > > Cc: Bob Feng > Cc: Liming Gao > Signed-off-by: Michael D Kinney > --- > .../Source/Python/Workspace/DscBuildDa

Re: [edk2-devel] [PATCH 2/5] MdePkg: Allow PcdFSBClock to by Dynamic

2020-02-02 Thread Liming Gao
t; Signed-off-by: Anthony PERARD > > --- > > CC: Bob Feng > > CC: Liming Gao > > --- > > MdePkg/MdePkg.dec | 8 > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec > >

Re: [edk2-devel] [PATCH v2] MdeModulePkg/Capsule: Remove RT restriction in UpdateCapsule service.

2020-02-06 Thread Liming Gao
Reviewed-by: Liming Gao > -Original Message- > From: devel@edk2.groups.io On Behalf Of Siyuan, Fu > Sent: Friday, February 7, 2020 2:39 PM > To: devel@edk2.groups.io > Cc: Wu, Hao A ; Gao, Liming > Subject: [edk2-devel] [PATCH v2] MdeModulePkg/Capsule: Rem

Re: [edk2-devel] [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH] MdePkg/Protocols: Code correction - removal of reserved member

2020-02-06 Thread Liming Gao
Reviewed-by: Liming Gao > -Original Message- > From: Javeed, Ashraf > Sent: Thursday, February 6, 2020 6:38 PM > To: devel@edk2.groups.io > Cc: Kinney, Michael D ; Gao, Liming > ; Ni, Ray > Subject: [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH] MdePkg/Protocols: Code &

Re: [edk2-devel] [PATCH] MdePkg/SmBios.h: Add two additional DWORD for smbios 3.3.0 type17

2020-02-06 Thread Liming Gao
gt; Configured Memory Speed". The lack of these field may cause strange > error i some operating systems. Seemly, this is typo. It should be in some operating systems > > Cc: Michael D Kinney > Cc: Liming Gao > Signed-off-by: Zhichao Gao > --- > MdePkg/Include/Industry

Re: [edk2-devel] [PATCH] MdePkg: Add PCI Express 5.0 Header File

2020-02-06 Thread Liming Gao
Felix: The patch is good. Is any test for the header file, such as build? Thanks Liming > -Original Message- > From: Felix Polyudov > Sent: Wednesday, February 5, 2020 5:30 AM > To: devel@edk2.groups.io > Cc: Kinney, Michael D ; Gao, Liming > ; manickavasak...@ami.com > Subject:

Re: [edk2-devel] [Patch] MdeModulePkg/Capsule: Remove RT restriction in UpdateCapsule service.

2020-02-06 Thread Liming Gao
k a > platform CapsuleLib from implementing ProcessCapsuleImage() with runtime > capsule processing capability. This patch removes this restriction. > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2501 > > Cc: Hao A Wu > Cc: Liming Gao > Signed-off-by: Siyuan Fu > --- >

Re: [edk2-devel] [Patch 1/1] BaseTools: Fixed a Incremental build issue

2020-02-07 Thread Liming Gao
Reviewed-by: Liming Gao > -Original Message- > From: Feng, Bob C > Sent: Friday, February 7, 2020 4:42 PM > To: edk2-de...@lists.01.org; devel@edk2.groups.io > Cc: Feng, Bob C ; Dong, Guo ; Gao, > Liming > Subject: [Patch 1/1] BaseTools: Fixed a Incremental build

Re: [edk2-devel] [Patch] BaseTools tools_def.template: Add back -fno-pie option in GCC49 tool chain

2020-02-05 Thread Liming Gao
d > host libs when building the POSIX host application. > > [BuildOptions] > GCC:*_*_*_CC_FLAGS = -fno-pie > > I think with the proposed change below, I could remove > this. Do you agree? > > Thanks, > > Mike > > > > -Original Message- >

[edk2-devel] [edk2-platform][patch v3] FitGen: Fix the issue to run in X64 linux machine

2020-02-05 Thread Liming Gao
: Bob Feng Cc: Isaac Oram Signed-off-by: Liming Gao --- In v2: update the commit message. In v3: correct Index to access OptionalModule field Silicon/Intel/Tools/FitGen/FitGen.c | 31 --- Silicon/Intel/Tools/FitGen/FitGen.h | 2 +- 2 files changed, 21 insertions

[edk2-devel] [edk2-platform] FitGen: Support FV with the extension header

2020-02-05 Thread Liming Gao
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2086 To find Microcode FILE in FV image, need to skip FV header and FV extension header, then find the first RAW FFS file. Cc: Bob Feng Signed-off-by: Liming Gao --- Silicon/Intel/Tools/FitGen/FitGen.c | 40

Re: [edk2-devel] [PATCH v2 1/1] BaseTools: Rationalise makefile generation

2020-02-04 Thread Liming Gao
Pierre: I think below three configurations are common. With this patch, they can work fine, right? And, do you mean Windows - GCC- GNUmake is still blocked by the change "0c3e8e9947a6c13b4327dd11b20acb95441701cf BaseTools: Enhance Basetool for incremental build"? > Windows - GCC-

Re: [edk2-devel] [PATCH v2 1/1] BaseTools: Build ASL files before C files

2020-02-04 Thread Liming Gao
Pierre: I see you use ':' to describe the dependency between the different source file. This is makefile syntax for the dependency. If one file depends on more than one files, other files will list after this file with the separator space ' '. So, I think the example should be like below. >

Re: [edk2-devel] [Patch] BaseTools tools_def.template: Add back -fno-pie option in GCC49 tool chain

2020-02-04 Thread Liming Gao
tion in GCC49 tool chain > > (+Ard) > > On 02/04/20 05:54, Liming Gao wrote: > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2502 > > This option is required to make GCC49 tool chain work with the high > > version GCC compiler. > > > > Cc: Bo

Re: [edk2-devel] [Patch] BaseTools/Build: Fix Structured PCD app host env issues

2020-02-02 Thread Liming Gao
d=2495 > > > https://bugzilla.tianocore.org/show_bug.cgi?id=2496 > > > > > > Structured PCD processing requires a host POSIX build > > > environment. If the Structure PCD application can > > not > > > be built using the default environment und

Re: [edk2-devel] [Patch] BaseTools/DscBuildData: Fix PCD autogen include file conflict

2020-02-02 Thread Liming Gao
gt; a subset of the standard C lib will run into this same issue > if they also define and use a Structured PCD. So this issue > is not limited to the CryptoPkg. > > Cc: Bob Feng > Cc: Liming Gao > Signed-off-by: Michael D Kinney > --- > .../Source/Python/Workspace/

Re: [edk2-devel] [PATCH v1 1/1] ShellPkg: acpiview: Prevent infinite loop if structure length is 0

2020-02-17 Thread Liming Gao
Krzysztof: Is there one BZ for this issue? Does this patch catch to this edk2 stable tag 202002? Thanks Liming > -Original Message- > From: devel@edk2.groups.io On Behalf Of Krzysztof Koch > Sent: Friday, February 14, 2020 9:59 PM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Gao,

Re: [edk2-devel] [PATCH v1 1/1] ShellPkg: acpiview: Prevent infinite loop if structure length is 0

2020-02-17 Thread Liming Gao
tag. > > Over the last few months I added some security features to acpiview. They > make this debug tool less sensitive to exploits from ACPI > tables. This patch completes my efforts in making the tool more reliable. > > Kind regards, > Krzysztof > > -Original M

Re: [edk2-devel] [PATCH v3] NetworkPkg/Ip4Dxe: Check the received package length (CVE-2019-14559).

2020-02-18 Thread Liming Gao
Siyuan and Maciej: Can you help review this patch? I would like to make CVE fix catch this stable tag edk2 202002. Thanks Liming > -Original Message- > From: devel@edk2.groups.io On Behalf Of Wu, Jiaxin > Sent: Tuesday, February 18, 2020 1:52 PM > To: devel@edk2.groups.io > Cc: Fu,

Re: [edk2-devel] [PATCH v2 1/1] EmbeddedPkg: Fixed Asserts in SCT Runtime Services test.

2020-02-19 Thread Liming Gao
Gaurav: Does this patch catch to edk2 stable tag 202002? Thanks Liming > -Original Message- > From: devel@edk2.groups.io On Behalf Of Gaurav Jain > Sent: Tuesday, February 18, 2020 8:24 PM > To: devel@edk2.groups.io > Cc: Leif Lindholm ; Ard Biesheuvel > ; Pankaj Bansal ; Gaurav >

Re: [edk2-devel] [edk2-staging/FceFmmt][PATCH] BaseTools/FCE: Fix multiple FVs with SEC module issue

2020-02-19 Thread Liming Gao
Reviewed-by: Liming Gao > -Original Message- > From: Feng, YunhuaX > Sent: Friday, February 14, 2020 5:15 PM > To: devel@edk2.groups.io > Cc: Gao, Liming ; Feng, Bob C ; > Zhang, Hongbin1 > Subject: [edk2-staging/FceFmmt][PATCH] BaseTools/FCE: Fix multiple FVs wit

Re: [edk2-devel] [PATCH] [edk2-staging/FceFmmt]BaseTools: Support no UI section FFS

2020-02-19 Thread Liming Gao
Reviewed-by: Liming Gao > -Original Message- > From: Feng, YunhuaX > Sent: Wednesday, February 12, 2020 2:24 PM > To: devel@edk2.groups.io > Cc: Gao, Liming ; Feng, Bob C > Subject: [PATCH] [edk2-staging/FceFmmt]BaseTools: Support no UI section F

Re: [edk2-devel] Patch List for 202002 stable tag

2020-02-19 Thread Liming Gao
Mike and Laszlo: Thanks for your comments. Vitaly: You request below two patches to catch 202002 stable tag. I agree with Mike and Laszlo comments. They are not ready to catch this stable tag. The first one is under discussion. The second one is like the enhancement or feature instead of

Re: [edk2-devel] [PATCH] Tools/FitGen: Check the input file path before open it

2020-02-19 Thread Liming Gao
Reviewed-by: Liming Gao > -Original Message- > From: Feng, YunhuaX > Sent: Wednesday, February 19, 2020 8:13 PM > To: devel@edk2.groups.io > Cc: Gao, Liming ; Feng, Bob C > Subject: [PATCH] Tools/FitGen: Check the input file path before open it > > REF: https:

Re: [edk2-devel] [PATCH] MdeModulePkg/SetupBrowserDxe: Fix IsZeroGuid() ASSERT.

2020-02-20 Thread Liming Gao
Do you request to catch this fix into this edk2 stable tag 202002? > -Original Message- > From: Wang, Nickle (HPS SW) > Sent: Friday, February 21, 2020 10:21 AM > To: Gao, Liming ; devel@edk2.groups.io; Bi, Dandan > > Subject: RE: [edk2-devel] [PATCH] MdeModulePkg/SetupBrowserDxe: Fix

Re: [edk2-devel] Patch List for 202002 stable tag

2020-02-21 Thread Liming Gao
support for input with separately reported modifiers [Liming] There is no agreement now. The discussion is in BZ https://bugzilla.tianocore.org/show_bug.cgi?id=2510. So, it may not catch this table tag. Thanks Liming From: devel@edk2.groups.io On Behalf Of Liming Gao Sent: Thursday, February 20

[edk2-devel] Hard Feature Freeze starts now for edk2-stable202002

2020-02-21 Thread Liming Gao
Hi, all Today, we enter into Hard Feature Freeze phase until edk2-stable202002 tag is created at 2020-02-28. In this phase, there is no feature to be pushed. The critical bug fix is still allowed. If the patch is sent after Hard Feature Freeze, and plans to catch this stable tag, please

Re: [edk2-devel] [PATCH V2 1/1] BaseTools: Switch to GNU mode for CLANGPDB

2020-02-11 Thread Liming Gao
Reviewed-by: Liming Gao > -Original Message- > From: devel@edk2.groups.io On Behalf Of Vitaly > Cheptsov via Groups.Io > Sent: Tuesday, February 11, 2020 2:53 PM > To: devel@edk2.groups.io > Subject: [edk2-devel] [PATCH V2 1/1] BaseTools: Switch to GNU mode for &

Re: [edk2-devel] [PATCH v2 2/2] MdePkg: Remove FIT table industry standard header file.

2020-02-11 Thread Liming Gao
Reviewed-by: Liming Gao > -Original Message- > From: Fu, Siyuan > Sent: Tuesday, February 11, 2020 9:37 PM > To: devel@edk2.groups.io > Cc: Kinney, Michael D ; Gao, Liming > > Subject: [PATCH v2 2/2] MdePkg: Remove FIT table industry standard header > f

Re: [edk2-devel] [PATCH 1/1] BaseTools: Switch to GNU mode for CLANGPDB

2020-02-10 Thread Liming Gao
Vitaly: This change is good. Can you your test for it? I verify this patch for Ovmf platform on Windows. It can make ovmf pass build with CLANGPDB. Thanks Liming > -Original Message- > From: devel@edk2.groups.io On Behalf Of Vitaly > Cheptsov via Groups.Io > Sent: Monday, February

<    4   5   6   7   8   9   10   11   12   13   >