Reviewed-by: Liming Gao
> -Original Message-
> From: Agrawal, Sachin
> Sent: Saturday, February 8, 2020 6:32 AM
> To: devel@edk2.groups.io
> Cc: Feng, Bob C ; Gao, Liming
> Subject: [PATCH v2] Add support for Diagnostics ACM in FitGen tool
>
> From: "Agr
> have listed the Boot Guard one.
>
> Thanks,
> Tim Lewis
> CTO, Insyde Software
> www.insyde.com
>
> -Original Message-
> From: annou...@edk2.groups.io On Behalf Of Liming
> Gao
> Sent: Friday, February 14, 2020 12:19 AM
> To: devel@edk2.groups.io; an
Gaurav:
Does this patch catch to edk2 stable tag 202002?
Thanks
Liming
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Gaurav Jain
> Sent: Monday, February 17, 2020 3:18 PM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J ; Wu, Hao A ; Ni,
> Ray ; Pankaj Bansal
>
>
Another minor comment. Ip4Dxe is moved into NetworkPkg. So, the patch title
should be NetworkPkg/Ip4Dxe.
Thanks
Liming
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Laszlo Ersek
> Sent: Monday, February 17, 2020 6:40 PM
> To: devel@edk2.groups.io; Wu, Jiaxin
> Cc: Fu,
Reviewed-by: Liming Gao
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of GuoMinJ
> Sent: Thursday, February 13, 2020 4:34 PM
> To: devel@edk2.groups.io
> Cc: GuoMinJ
> Subject: [edk2-devel] [PATCH 2/3] MdeModulePkg: Issues reported by ECC in
Felix:
I always pull the latest edk2 and edk2-platform, then build it.
Thanks
Liming
From: devel@edk2.groups.io On Behalf Of Felix Polyudov
Sent: Friday, February 14, 2020 7:11 AM
To: devel@edk2.groups.io
Cc: Kubacki, Michael A
Subject: [edk2-devel] [edk2-platforms] Building a platform: which
Hi, all
We will enter into Soft Feature Freeze phase. In this phase, the feature
under review will not be allowed to be pushed. The patch review can continue
without break in edk2 community.
If the patch is sent before Soft Feature Freeze, and plans to catch this
stable tag, the patch
Zurcher:
Seemly, this is like an enhancement in OpensslLib. Please submit one BZ
(https://bugzilla.tianocore.org/) for this change.
And today, edk2 enters into the soft feature freeze for edk2-stable202002
stable tag. So, this change may not catch this stable tag.
Thanks
Liming
>
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2483
Signed-off-by: Liming Gao
Cc: Bob Feng
Cc: Paul Lohr
---
Silicon/Intel/Tools/FitGen/FitGen.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Silicon/Intel/Tools/FitGen/FitGen.c
b/Silicon/Intel/Tools/FitGen/FitGen.c
Gaurav:
Got it.
Lefi and Ard:
Can you review this patch for stable tag 202002?
Thanks
Liming
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Gaurav Jain
> Sent: Thursday, February 20, 2020 1:19 PM
> To: Gao, Liming ; devel@edk2.groups.io
> Cc: Leif Lindholm ; Ard
Vitaly:
I add my comments.
Zhichao and Ray:
Can you give your opinion for BZ
https://bugzilla.tianocore.org/show_bug.cgi?id=2510? Is it a bug fix or feature
enhancement?
Thanks
Liming
From: vit9696
Sent: Thursday, February 20, 2020 2:09 AM
To: Gao, Liming
Cc: Kinney, Michael D ; Laszlo
Hi Stewards and all:
I collect current patch lists in devel mail list. Those patch contributors
request to add them for 201902 stable tag. Because we have enter into Soft
Feature Freeze, I want to collect your feedback for them. If any patches are
missing, please reply this mail to add them.
This patch is for BZ https://bugzilla.tianocore.org/show_bug.cgi?id=2031
So, please add this line into the commit message. This can be done when submit
this patch. Don't need to send the patch again.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2031
Thanks
Liming
> -Original
Ray, Zhichao and Vitaly:
Thanks. BZ is the good place to catch all discussion. Because we are close to
edk2 stable tag 202002, can you make the agreement soon for BZ 2510?
Thanks
Liming
From: Ni, Ray
Sent: Thursday, February 20, 2020 11:13 AM
To: Gao, Liming ; vit9696
Cc: Kinney, Michael D ;
Reviewed-by: Liming Gao
> -Original Message-
> From: Kinney, Michael D
> Sent: Thursday, February 13, 2020 6:45 AM
> To: devel@edk2.groups.io
> Cc: Gao, Liming ; Sean Brogan
> ; Bret Barkelew
> Subject: [Patch] MdePkg/BaseSafeIntLib: Fix VS20xx IA32 lin
Reviewed-by: Liming Gao
> -Original Message-
> From: Krzysztof Koch
> Sent: Thursday, February 13, 2020 1:28 AM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D ; Gao, Liming
> ; matteo.carl...@arm.com;
> sami.muja...@arm.com; n...@arm.com
> Subject: [PATCH
Jian, Jiewen and Chao:
Does this patch catch to edk2 Q1 stable tag? If yes, can this patch be
reviewed this week, because Q1 stable tag soft feature freeze is 2020-02-14.
Thanks
Liming
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Wang, Jian J
> Sent: Thursday,
Its solution is changed. This feature is moving to Q2 Stable tag.
Signed-off-by: Liming Gao
---
EDK-II-Release-Planning.md | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/EDK-II-Release-Planning.md b/EDK-II-Release-Planning.md
index a1866d2..32488de 100644
--- a/EDK-II
Reviewed-by: Liming Gao
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of GuoMinJ
> Sent: Thursday, February 13, 2020 4:34 PM
> To: devel@edk2.groups.io
> Cc: GuoMinJ
> Subject: [edk2-devel] [PATCH 1/3] FmpDevicePkg/FmpDxe: Issues reported by ECC
>
microcode update according to FIT microcode entries if
it's present, otherwise it will fallback to original logic (by PCD).
Patch 1/2: Add FIT header file to MdePkg.
Patch 2/2: Update microcode loader to shadow microcode according to FIT.
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Eric Dong
Cc: Ray Ni
ichael D ; Dong, Eric
> ; Ni, Ray ; ler...@redhat.com
> Subject: RE: [PATCH v2 1/2] MdePkg: Add header file for Firmware
> Interface Table specification.
>
> Reviewed-by: Liming Gao
>
> > -Original Message-
> > From: Fu, Siyuan
> > Sent: Thursday, Ja
Please remove Contributed-under: TianoCore Contribution Agreement 1.1 in the
commit message, this is not required now.
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Vladimir
> Olovyannikov via Groups.Io
> Sent: Friday, January 10, 2020 6:07 AM
> To:
def.txt contains hard-coded path to mtoc
>
> BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=2030
>
> Change MTOC PATH to reference $PATH to find mtoc.
>
> The Patch is going to fix this issue
>
> Signed-off-by: Lan-chinX Hsu
>
> Cc: Liming Gao
> Cc: Bo
Cc: Isaac Oram
Signed-off-by: Liming Gao
---
Silicon/Intel/Tools/FitGen/FitGen.c | 29 +++--
Silicon/Intel/Tools/FitGen/FitGen.h | 2 +-
2 files changed, 20 insertions(+), 11 deletions(-)
diff --git a/Silicon/Intel/Tools/FitGen/FitGen.c
b/Silicon/Intel/Tools/FitGen
Yes. Does it catch EDK2 2020 Q1 stable tag?
> -Original Message-
> From: Sukerkar, Amol N
> Sent: Thursday, January 16, 2020 7:02 AM
> To: Gao, Liming ; devel@edk2.groups.io; Wang, Jian J
>
> Cc: Kinney, Michael D ; Yao, Jiewen
> ; Agrawal, Sachin
> ; Musti, Srinivas ;
> Sukerkar,
I add my comments.
Thanks
Liming
> -Original Message-
> From: PierreGondois
> Sent: Wednesday, January 15, 2020 2:29 AM
> To: devel@edk2.groups.io
> Cc: Pierre Gondois ; ard.biesheu...@linaro.org; Feng,
> Bob C ; Gao, Liming
> ; sami.muja...@arm.com; n...@arm.com
> Subject: [PATCH v1
> Unified Hash Calculation API
>
> Thanks, Liming! How do I find out if it catches EDK 2020 Q1 stable tag?
>
> ~ Amol
>
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Liming Gao
> Sent: Wednesday, January 15, 2020 8:39 PM
> To: Sukerkar,
#if MACRO is not good style. It should be changed to
#ifdef MACRO style or #if defined (MACRO) style.
Signed-off-by: Zhiguang Liu
Reviewed-by: Liming Gao
---
MdePkg/Include/Base.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/MdePkg/Include/Base.h b/MdePkg/Include
5 PM
> > To: devel@edk2.groups.io; Xu, Wei6
> > Subject: RE: [edk2-devel][PATCH 0/3] Fmp Capsule Dependency implementation.
> >
> > Wei:
> > The code change looks good. Reviewed-by: Liming Gao
> >
> > Please share which test have been done.
> >
>
Brian:
This time is Chinese New Year Holiday. Most Chinese people will not join this
meeting. How about cancel this week meeting?
Thanks
Liming
From: devel@edk2.groups.io
Sent: 2020年1月19日 9:00
To: devel@edk2.groups.io
Subject: [edk2-devel] Upcoming Event: TianoCore Bug Triage - APAC / NAMO -
Heng:
The change is good to me. Reviewed-by: Liming Gao
Thanks
Liming
-Original Message-
From: devel@edk2.groups.io On Behalf Of Heng Luo
Sent: 2020年1月14日 16:54
To: devel@edk2.groups.io
Subject: [edk2-devel] [PATCH] MdeModulePkg: Perform test only if not ignore
memory test
REF
Laszlo:
I also agree to handle those file type specified in build_rule.txt.
Thanks
Liming
-Original Message-
From: Leif Lindholm
Sent: 2020年1月18日 3:37
To: Laszlo Ersek
Cc: Gao, Liming ; devel@edk2.groups.io; Feng, Bob C
Subject: Re: [PATCH] BaseTools/Conf/gitattributes: fix
Phil:
Ray talks leave for Chinese New year holiday. I can take back up for him. For
those changes, I agree them.
Acked-by: Liming Gao
Thanks
Liming
-Original Message-
From: devel@edk2.groups.io On Behalf Of Philippe
Mathieu-Daudé
Sent: 2020年1月18日 1:14
To: devel@edk2.groups.io
Bob:
This patch fixes the incremental build issue for the header file removement.
Please update the commit message with the detail solution. The code change is
good. Reviewed-by: Liming Gao
Thanks
Liming
-Original Message-
From: Feng, Bob C
Sent: 2020年1月17日 11:28
To: devel@edk2
Amol:
This is new feature. Please submit BZ (https://bugzilla.tianocore.org/) to
track it. If this feature catches edk2 2020 Q1 stable tag, I will add it into
edk2 feature planning.
Thanks
Liming
-Original Message-
From: devel@edk2.groups.io On Behalf Of Wang, Jian J
Sent:
Hi, all
Due to Chinese New Year Holiday, Kinney, Michael D will be as the back up
package reviewers for those edk2 packages with Chinese people as maintainer or
reviewers. Thanks for Mike help.
Thanks
Liming
From: devel@edk2.groups.io On Behalf Of Brian Richardson
Sent: Wednesday, January
ually using properly
> C-aware diff by default. And thank you for the perfect level of background.
>
> However, if doing this change, would we want to apply it to all source code
> types supported by BaseTools (i.e. referenced in build_rule.template)?
>
> That would mean:
>
want to apply it to all source code
types supported by BaseTools (i.e. referenced in build_rule.template)?
That would mean:
.c
.cc
.C
.CC
.cpp
.Cpp
.CPP
.h
.H
and possibly
.act
.aslc
.vfr
.Vfr
.VFR
/
Leif
>
> Cc: Bob Feng
> Cc: Leif Lindholm
> Cc: Liming Gao
> Signed-off-
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2466
-Original Message-
From: devel@edk2.groups.io On Behalf Of Liming Gao
Sent: 2020年1月16日 15:11
To: devel@edk2.groups.io
Cc: Oram, Isaac W
Subject: [edk2-devel] [edk2-platform] FitGen: Fix the issue to run in X64 linux
machine
Cc
Wei:
Is there Wiki page to introduce how to enable Capsule Dependency and how to
verify Capsule with Dependency?
Thanks
Liming
-Original Message-
From: devel@edk2.groups.io On Behalf Of Liming Gao
Sent: 2020年1月16日 21:55
To: Xu, Wei6 ; devel@edk2.groups.io
Subject: Re: [edk2-devel
> Thanks, Liming! How do I find out if it catches EDK 2020 Q1 stable tag?
>
> ~ Amol
>
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Liming
> Gao
> Sent: Wednesday, January 15, 2020 8:39 PM
> To: Sukerkar, Amol N ;
> devel@edk2.groups.io; Wang,
Wei:
The code change looks good. Reviewed-by: Liming Gao
Please share which test have been done.
Thanks
Liming
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Xu, Wei6
> Sent: Friday, January 10, 2020 1:35 PM
> To: devel@edk2.groups.io
> Subje
Reviewed-by: Liming Gao
> -Original Message-
> From: Fu, Siyuan
> Sent: Thursday, January 9, 2020 10:14 AM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D ; Gao, Liming
> ; Dong, Eric ; Ni, Ray
> ; ler...@redhat.com
> Subject: [PATCH v2 1/2] MdePkg: Add
upport
> > 12. CTO support
> > 13. CPM
> > 14. L1 PM Substates
> >
> > New source files with unique definitions are:
> > MdePkg/Include/Protocol/PciExpressPlatform.h,
> > MdePkg/Include/Protocol/PciExpressOverride.h
> >
>
Reviewed-by: Liming Gao
-Original Message-
From: Zhang, Shenglei
Sent: 2019年12月31日 14:18
To: Chen, Marc W ; devel@edk2.groups.io
Cc: Kubacki, Michael A ; Chaganty, Rangasai V
; Gao, Liming
Subject: RE: [edk2-devel][edk2-platforms][PATCH]
IntelSiliconPkg/Feature/SmmAccess/*: Fix
Reviewed-by: Liming Gao
-Original Message-
From: devel@edk2.groups.io On Behalf Of Philippe
Mathieu-Daudé
Sent: 2020年1月3日 3:23
To: devel@edk2.groups.io
Cc: Leif Lindholm ; Kinney, Michael D
; Andrew Fish ; Laszlo Ersek
; Philippe Mathieu-Daude ; Gao, Liming
Subject: [edk2-devel
becomes:
Initialize memory -> install SEC PPIs -> Call libraries' constructors
Signed-off-by: Pankaj Bansal
Cc: Dandan Bi
Cc: Liming Gao
---
MdeModulePkg/Core/Pei/PeiMain/PeiMain.c | 24 ---
1 file changed, 13 insertions(+), 11 deletions(-)
diff --git a/MdeModulePk
Jiewen:
Seemly, this is a new feature. Dose it need to catch 2020 Q1 stable tag? If
yes, I will add it into the feature planning.
Thanks
Liming
-Original Message-
From: devel@edk2.groups.io On Behalf Of Yao, Jiewen
Sent: 2019年12月31日 14:44
To: devel@edk2.groups.io
Cc: Wang, Jian J ;
From: "Pavana.K"
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2389
Currently RSA signing scheme support is available for MD5, SHA-1 or
SHA-256 algorithms.The fix is to extend this support for SHA384 and
SHA512.
Cc: Liming Gao
Cc: Jian J Wang
Cc: Bob Feng
Signed-off-by
dk2.groups.io
> > > > > > > Cc: Kinney, Michael D ; Gao,
> > > > > > > Liming ; Vitaly Cheptsov
> > > > > > >
> > > > > > > Subject: [edk2-devel] [PATCH V3 0/2] *MdePkg/UefiDevicePathLib:
> > > &
From: Jason Voelz
Jason Voelz (2):
MdePkg BaseLib.h: Update IA32_CR4 strut to include all public fields
UefiCpuPkg/CpuCommonFeaturesLib: SMXE bit of CR4 should set
UefiCpuPkg/Library/CpuCommonFeaturesLib/FeatureControl.c | 9 +
MdePkg/Include/Library/BaseLib.h
From: Jason Voelz
Add code to set SMXE in CR4 in the SmxInitialize flow when SMX is enabled.
Signed-off-by: Jason Voelz
Cc: Ray Ni
---
UefiCpuPkg/Library/CpuCommonFeaturesLib/FeatureControl.c | 9 +
1 file changed, 9 insertions(+)
diff --git
Reviewed-by: Liming Gao
-Original Message-
From: Philippe Mathieu-Daude
Sent: 2020年1月3日 17:07
To: devel@edk2.groups.io
Cc: Antoine Coeur ; Kinney, Michael D
; Gao, Liming ; Philippe
Mathieu-Daude
Subject: [PATCH v2 28/78] MdePkg/Register: Fix various typos
From: Antoine Coeur
Fix
Reviewed-by: Liming Gao
-Original Message-
From: devel@edk2.groups.io On Behalf Of Philippe
Mathieu-Daudé
Sent: 2020年1月3日 17:07
To: devel@edk2.groups.io
Cc: Antoine Coeur ; Kinney, Michael D
; Gao, Liming ; Philippe
Mathieu-Daude
Subject: [edk2-devel] [PATCH v2 27/78] MdePkg/Ppi
Cc: Michael D Kinney
> Cc: Leif Lindholm
> Cc: Liming Gao
> Cc: Hao A Wu
> Cc: Eric Dong
> Cc: Ray Ni
> Cc: Achin Gupta
> Cc: Jiewen Yao
>
Ping?
> Ard Biesheuvel (7):
> MdePkg: introduce MM communicate 2 protocol
> MdeModulePkg/SmmIpl: expose MM communicate
Reviewed-by: Liming Gao
-Original Message-
From: Philippe Mathieu-Daude
Sent: 2020年1月3日 17:07
To: devel@edk2.groups.io
Cc: Antoine Coeur ; Kinney, Michael D
; Gao, Liming ; Philippe
Mathieu-Daude
Subject: [PATCH v2 26/78] MdePkg/Library/Smm: Fix various typos
From: Antoine Coeur
Reviewed-by: Liming Gao
-Original Message-
From: Philippe Mathieu-Daude
Sent: 2020年1月3日 17:07
To: devel@edk2.groups.io
Cc: Antoine Coeur ; Kinney, Michael D
; Gao, Liming ; Philippe
Mathieu-Daude
Subject: [PATCH v2 24/78] MdePkg/Library/Dxe: Fix various typos
From: Antoine Coeur
Reviewed-by: Liming Gao
-Original Message-
From: devel@edk2.groups.io On Behalf Of Philippe
Mathieu-Daudé
Sent: 2020年1月3日 17:07
To: devel@edk2.groups.io
Cc: Antoine Coeur ; Kinney, Michael D
; Gao, Liming ; Philippe
Mathieu-Daude
Subject: [edk2-devel] [PATCH v2 25/78] MdePkg/Library
Reviewed-by: Liming Gao
-Original Message-
From: Philippe Mathieu-Daude
Sent: 2020年1月3日 17:07
To: devel@edk2.groups.io
Cc: Antoine Coeur ; Kinney, Michael D
; Gao, Liming ; Philippe
Mathieu-Daude
Subject: [PATCH v2 23/78] MdePkg/IndustryStandard: Fix various typos
From: Antoine
Reviewed-by: Liming Gao
-Original Message-
From: Liu, Zhiguang
Sent: 2019年12月20日 16:32
To: devel@edk2.groups.io
Cc: Gao, Liming ; Ni, Ray ; Laszlo
Ersek
Subject: [Patch V2] edksetup.bat: Simplify the step to use CLANGPDB
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2404
Set
This change has no functionality impact. I agree to make this change in MdePkg
library for the module development support in EFI1.10/UEFI2.7/PI1.7.
With this change, you also need to remove gEfiEventExitBootServicesGuid or
gEfiEventVirtualAddressChangeGuid from module INF file if they are not
Reviewed-by: Liming Gao
-Original Message-
From: devel@edk2.groups.io On Behalf Of Vitaly Cheptsov
via Groups.Io
Sent: 2020年1月7日 18:51
To: devel@edk2.groups.io
Subject: [edk2-devel] [PATCH v2 1/1] MdePkg: Do not use CreateEventEx unless
required
REF: https://bugzilla.tianocore.org
.
> Then, specify it in platform.dsc [BuildOptions] to override the default one
> in tools_def.txt.
>
> *_*_*_LZMA_PATH = LzmaCompressPlatform
>
> This override tool will be used. But, its name is not specified in the
> generated GuidedSectionTools.txt.
>
> Signed-o
Sean:
We mostly use Emulator to verify and debug the code change in the common
module, such as BDS, HII, DxeCore, PeiCore. Compared to the real platform,
Emulator and OVMF are more easier to be built and verified. So, I request to
add Open CI build test for Ovmf and Emulator (BZ 2570). Later,
Edk2 spec are listed in
https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Specifications
This change requires to update INF/DEC/DSC/FDF/Build spec. You can find their
github repo in the above link. Then, create git patch for the change.
Thanks
Liming
-Original Message-
Reviewed-by: Liming Gao
-Original Message-
From: Zhang, Shenglei
Sent: 2020年3月9日 14:32
To: devel@edk2.groups.io
Cc: Gao, Liming ; Wang, Jian J ;
Wu, Hao A ; Feng, Bob C
Subject: [PATCH v2 0/2] Use submodule way to access brotli
Currently brotli is used and customized by edk2
warning C4244: '=': conversion from 'UINTN' to 'UINT32', possible loss of data
With this fix, OvmfIa32, OvmfX64 and OvmfIa32X64 can pass build.
Cc: Laszlo Ersek
Cc: Ard Biesheuvel
Signed-off-by: Liming Gao
---
OvmfPkg/Library/X86QemuLoadImageLib/X86QemuLoadImageLib.c | 2 +-
1 file changed, 1
warning C4244: '=': conversion from 'UINT64' to 'UINTN', possible loss of data
With this fix, OvmfIa32, OvmfX64 and OvmfIa32X64 can pass build.
Cc: Laszlo Ersek
Cc: Ard Biesheuvel
Signed-off-by: Liming Gao
---
OvmfPkg/Library/X86QemuLoadImageLib/X86QemuLoadImageLib.c | 2
Reviewed-by: Liming Gao
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Fan, ZhijuX
> Sent: Wednesday, March 11, 2020 5:51 PM
> To: devel@edk2.groups.io
> Cc: Gao, Liming ; Feng, Bob C ;
> Fan, ZhijuX
> Subject: [edk2-devel] [PATCH V4] Base
Hi, all
Recently, regular TianoCore Bug Triage meeting has no enough time to review
and discuss the existing bugzillas. I would propose to extend this meeting from
0.5 hour to 1 hour. Now, Bug Triage, Tiano Design and Community meeting are all
in one day. I have met some conflict to those
ttps://bugzilla.tianocore.org/show_bug.cgi?id=2559
>
> Cc: Liming Gao
> Cc: Jian J Wang
> Cc: Hao A Wu
> Cc: Bob Feng
> Shenglei Zhang (2):
> MdeModulePkg/BrotliCustomDecompressLib: Make brotli a submodule
> BaseTools: Make brotli a submodule
>
> .../C/B
the conflict, it should copy this file to its output directory,
> If so, PcdValueCommon.obj file will be private for PcdValueInit
>
> Cc: Liming Gao
> Cc: Bob Feng
> Signed-off-by: Zhiju.Fan
> ---
> BaseTools/Source/Python/Workspace/DscBuildData.py | 9 +++--
>
Reviewed-by: Liming Gao
> -Original Message-
> From: Liu, Zhiguang
> Sent: Friday, April 10, 2020 9:44 AM
> To: devel@edk2.groups.io; pierre.gond...@arm.com
> Cc: Kinney, Michael D ; Gao, Liming
> ; sami.muja...@arm.com; n...@arm.com
> Subject: RE: [edk2-devel]
Ard:
What's purpose for this change? Only code clean up? Is there any other
benefit?
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Ard Biesheuvel
> Sent: Friday, April 10, 2020 12:10 AM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J ; Wu, Hao A ; Ard
> Biesheuvel
>
Yes. It is stopped. Please see https://edk2.groups.io/g/devel/message/29436
> -Original Message-
> From: Rebecca Cran
> Sent: Monday, April 13, 2020 12:22 PM
> To: devel@edk2.groups.io
> Cc: Feng, Bob C ; Gao, Liming
> Subject: BaseTools Win32 binaries repo hasn't been updated for over
Reviewed-by: Liming Gao
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Michael Kubacki
> Sent: Friday, April 3, 2020 1:05 AM
> To: devel@edk2.groups.io
> Cc: Feng, Bob C ; Gao, Liming
> Subject: [edk2-devel] [PATCH v1 1/1] BaseTools: Update Edk2Tools
] [PATCH v1 1/1] MdePkg: Add AML FieldList OpCode
definitions
Hello everyone,
Just to push the patch forward a bit: the patch has received reviewed-by from
Liming Gao, Zhiguang Liu and Sami Mujawar,
Regards,
Pierre
-Original Message-
From: devel@edk2.groups.io On Behalf Of Liming Gao via
Reviewed-by: Liming Gao
-Original Message-
From: Chiu, Chasel
Sent: 2020年4月21日 8:53
To: devel@edk2.groups.io
Cc: Desimone, Nathaniel L ; Gao, Liming
Subject: [edk2-platforms: PATCH] Revert "MinPlatformPkg/PlatformInitPei:
ReportCpuHobLib."
The patch broke all OpenBoardPk
For this change, I suggest to separate it to three patches. One is for
tools_def.template, another is for Build Python, last one is for BaseTools C
tool.
-Original Message-
From: devel@edk2.groups.io On Behalf Of Chang, Abner
(HPS SW/FW Technologist)
Sent: 2020年4月10日 15:47
To:
Reviewed-by: Liming Gao for this patch set.
-Original Message-
From: Michael Kubacki
Sent: 2020年4月16日 1:10
To: devel@edk2.groups.io; Zhang, Chao B ; Bi, Dandan
; Wu, Hao A ; Wang, Jian J
; Gao, Liming
Cc: Kinney, Michael D ; Ni, Ray ;
Sean Brogan
Subject: Re: [PATCH v2 0/7] Add
Abner:
Here is my minor comments.
1. For RISC-V processor related definitions, have they been defined in public
definitions?
2. For MdePkg/BaseSynchronizationLib, why name file SynchronizationAsm.S? Can
it name to Synchronization.S?
Thanks
Liming
-Original Message-
From:
for "MdeModulePkg: ACPI modules", but
>> technically speaking, "MdeModulePkg.dec" needs an ACK from either Jian or
>> Hao.
>>
>> Content-wise, your approval looks sufficient, but I don't want to assume.
>> Please confirm.
>>
>> Thank
>
Guomin:
I find this parameter name doesn't match the one in function description. Can
you make them be same? With this change, Reviewed-by: Liming Gao
@param File A pointer to the device path of the file that is
being dispatched. This will optionally
Sean:
I see some comments on Ovmf. If you make the change in Ovmf, please also
update EmulatorPkg. I would like to keep the consistent style in
EmulatorPkg/OvmfPkg.
This change is good to me. Reviewed-by: Liming Gao
Ray:
If you have no comment, can you give Ack-by for this change
Zhiju:
With this improvement, Reviewed-by: Liming Gao
> -Original Message-
> From: Fan, ZhijuX
> Sent: Monday, April 20, 2020 9:17 AM
> To: Gao, Liming ; devel@edk2.groups.io
> Cc: Feng, Bob C
> Subject: RE: [PATCH V6] BaseTools:Add the spare space FV image si
e.
> If FV doesn't meet with the size requirement,
> Build tool will report error message to say there is no
> enough spare space.
>
> Cc: Liming Gao
> Cc: Bob Feng
> Signed-off-by: Zhiju.Fan
> ---
> changed the error message
>
> BaseTools/Source/Python/Common/B
Reviewed-by: Liming Gao
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Zhang, Shenglei
> Sent: Tuesday, April 7, 2020 2:48 PM
> To: devel@edk2.groups.io
> Cc: Sean Brogan ; Bret Barkelew
> ; Kinney, Michael D
> ; Gao, Liming
> Subject:
Reviewed-by: Liming Gao
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Zhang, Shenglei
> Sent: Tuesday, April 7, 2020 2:48 PM
> To: devel@edk2.groups.io
> Cc: Sean Brogan ; Bret Barkelew
> ; Kinney, Michael D
> ; Gao, Liming
> Subj
Kevin:
Thanks for your comments. If no other objection, I will start TianoCore Bug
Triage - APAC / NAMO Meeting on Wednesday morning 9:30AM ~ 10:30AM (UTC +8)
since this week.
Thanks
Liming
From: devel@edk2.groups.io On Behalf Of Kevin@Insyde
Sent: 2020年3月13日 2:59
To: Gao, Liming
Cc:
ect: Re: [patch v2] OvmfPkg: Fix build failure with VS2015 tool chain
>
> Hello Liming,
>
> (adding Michael)
>
> On 03/12/20 05:30, Liming Gao wrote:
> > warning C4244: '=': conversion from 'UINTN' to 'UINT32', possible loss of
> > data
> > With this
Bret
From: Shenglei Zhang<mailto:shenglei.zh...@intel.com>
Sent: Thursday, March 26, 2020 12:04 AM
To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>
Cc: Sean Brogan<mailto:sean.bro...@microsoft.com>; Bret
Barkelew<mailto:bret.barke...@microsoft.com>; Kinney, Michael
D<m
Reviewed-by: Liming Gao
-Original Message-
From: devel@edk2.groups.io On Behalf Of Abner Chang
Sent: 2020年3月6日 13:36
To: devel@edk2.groups.io
Cc: abner.ch...@hpe.com; Gao, Liming ; Kinney, Michael D
; Leif Lindholm ; Gilbert Chen
; Daniel Schaefer
Subject: [edk2-devel] [edk2/master
Reviewed-by: Liming Gao
-Original Message-
From: Abner Chang
Sent: 2020年3月6日 13:36
To: devel@edk2.groups.io
Cc: abner.ch...@hpe.com; Gilbert Chen ; Leif Lindholm
; Kinney, Michael D ; Gao,
Liming
Subject: [edk2/master PATCH RISC-V CI Code Changes v1 10/11]
MdePkg/DxeServicesLib
Reviewed-by: Liming Gao
-Original Message-
From: Luo, Heng
Sent: 2020年3月25日 16:01
To: devel@edk2.groups.io
Cc: Bi, Dandan ; Gao, Liming ; Dong,
Eric ; Ni, Ray
Subject: [Patch V3] Features/Intel: Add LogoFeaturePkg to provide logo images
and drivers
REF: https
Reviewed-by: Liming Gao
-Original Message-
From: Javeed, Ashraf
Sent: 2020年3月31日 10:03
To: devel@edk2.groups.io
Cc: Kinney, Michael D ; Gao, Liming
Subject: [PATCH V3 1/2] MdePkg-IndustryStandard: CXL 1.1 Base Specification
registers
BZ: https://bugzilla.tianocore.org/show_bug.cgi
Reviewed-by: Liming Gao
-Original Message-
From: devel@edk2.groups.io On Behalf Of Javeed, Ashraf
Sent: 2020年3月31日 10:03
To: devel@edk2.groups.io
Cc: Kinney, Michael D ; Gao, Liming
Subject: [edk2-devel] [PATCH V3 2/2] MdePkg-IndustryStandard: Main header for
all versions of CXL
Reviewed-by: Liming Gao
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Zhang, Shenglei
> Sent: Wednesday, April 1, 2020 4:25 PM
> To: devel@edk2.groups.io
> Cc: Sean Brogan ; Bret Barkelew
> ; Kinney, Michael D
> ; Gao, Liming
> Subj
Reviewed-by: Liming Gao
> -Original Message-
> From: Zhang, Shenglei
> Sent: Wednesday, April 1, 2020 4:32 PM
> To: devel@edk2.groups.io
> Cc: Gao, Liming ; Wang, Jian J ;
> Wu, Hao A ; Feng, Bob C
>
> Subject: [PATCH v2 0/2] Use submodule way to access brot
Reviewed-by: Liming Gao
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Zhang, Shenglei
> Sent: Thursday, April 2, 2020 3:17 PM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J ; Wu, Hao A ;
> Gao, Liming
> Subject: [edk2-devel] [PATCH v2] MdeModulePkg
Ray:
Package has dec file in its root directory. Package DSC file is optional.
Thanks
Liming
-Original Message-
From: Luo, Heng
Sent: 2020年3月31日 9:25
To: Ni, Ray ; devel@edk2.groups.io
Cc: Bi, Dandan ; Gao, Liming ; Dong,
Eric
Subject: RE: [PATCH 1/3] Platform/Intel: Add all pathes
901 - 1000 of 1272 matches
Mail list logo
