Re: [edk2-devel] Maintainers.txt: update UEFI payload information

2019-05-30 Thread Ma, Maurice
Reviewed-by: Maurice Ma Regards, Maurice > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Guo > Dong > Sent: Thursday, May 30, 2019 3:07 > To: devel@edk2.groups.io > Cc: Ma, Maurice ; You, Benjamin > ; Dong, Guo ; Agyeman

Re: [edk2-devel] UefiPayloadPkg: Remove legacy PIC 8259 driver

2019-05-30 Thread Ma, Maurice
Reviewed-by: Maurice Ma Regards, Maurice > -Original Message- > From: Dong, Guo > Sent: Thursday, May 30, 2019 2:52 > To: devel@edk2.groups.io > Cc: Ma, Maurice ; You, Benjamin > ; Dong, Guo > Subject: [edk2-devel] UefiPayloadPkg: Remove legacy PIC 8259 driver

Re: [edk2-devel] [PATCH v2 0/4] Define EDKII_SERIAL_PORT_LIB_VENDOR_GUID

2019-06-13 Thread Ma, Maurice
Hi, Laszlo Thank you for the reminder. Reviewed patch #4 just now. Regards, Maurice > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Thursday, June 13, 2019 8:32 > To: Ard Biesheuvel ; Leif Lindholm > ; Ma, Maurice ; Dong, > Guo ; You, Be

Re: [edk2-devel] [PATCH v2 4/4] UefiPayloadPkg/PlatformBootManagerLib: Use EDKII_SERIAL_PORT_LIB_VENDOR_GUID from MdeModulePkg

2019-06-13 Thread Ma, Maurice
Reviewed-by: Maurice Ma Regards, Maurice > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Anthony PERARD > Sent: Thursday, June 6, 2019 6:15 > To: devel@edk2.groups.io > Cc: Ni, Ray ; Julien Grall ; Ard > Biesheuvel ; Leif Lindholm > ;

Re: [edk2-devel] [edk2] [PATCH V3] Change EDK II to BSD+Patent License

2019-04-04 Thread Ma, Maurice
Reviewed changes for CorebootPayloadPkg and CorebootModulePkg.  And they look good to me. Reviewed-by: Maurice Ma < maurice...@intel.com > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#38589): https://edk2.groups.io/g/devel/m

Re: [edk2-devel] [PATCH v2 1/2] CorebootModulePkg: Fix non - CRLF line endings

2019-04-09 Thread Ma, Maurice
This patch series looks good to me. Reviewed-by: Maurice Ma Regards, Maurice > -Original Message- > From: Agyeman, Prince > Sent: Thursday, April 4, 2019 8:32 > To: devel@edk2.groups.io > Cc: Ma, Maurice ; You, Benjamin > > Subject: [PATCH v2 1/2] CorebootModulePkg

Re: Commit Partitioning - Re: [edk2-devel] [edk2] [PATCH V2] UefiPayloadPkg: Enhance UEFI payload for coreboot and Slim Bootloader

2019-04-15 Thread Ma, Maurice
Hi, Jordan That is a good point. Smaller patch will always help the review easier. Thank you for pointing it out. Thanks Maurice > -Original Message- > From: Justen, Jordan L > Sent: Monday, April 15, 2019 15:28 > To: Dong, Guo ; Ma, Maurice > ; devel@edk2.groups.i

Re: [edk2-devel] [PATCH 0/2] Retire CorebootModulePkg and CorebootPayloadPkg

2019-05-08 Thread Ma, Maurice
This patchset looks good me. Reviewed-by: Maurice Ma Regards, Maurice > -Original Message- > From: Dong, Guo > Sent: Tuesday, May 7, 2019 15:27 > To: devel@edk2.groups.io > Cc: Ma, Maurice ; Agyeman, Prince > ; You, Benjamin ; > Dong, Guo > Subject: [edk2-d

Re: [edk2-devel] [PATCH V3 11/15] UefiPayloadPkg: Add ResetUtilityLib to UefiPayloadPkgIa32X64.dsc

2019-08-07 Thread Ma, Maurice
Reviewed-by: Maurice Ma Regards, Maurice > -Original Message- > From: Gao, Zhichao > Sent: Wednesday, August 7, 2019 18:08 > To: devel@edk2.groups.io > Cc: Ma, Maurice ; Dong, Guo > ; You, Benjamin ; Gao, > Liming > Subject: [PATCH V3 11/15] UefiPayload

Re: [edk2-devel] [PATCH V3 10/15] UefiPayloadPkg/UefiPayloadPkgIa32.dsc: Add ResetUtilityLib to dsc file

2019-08-07 Thread Ma, Maurice
Reviewed-by: Maurice Ma Regards, Maurice > -Original Message- > From: Gao, Zhichao > Sent: Wednesday, August 7, 2019 18:08 > To: devel@edk2.groups.io > Cc: Ma, Maurice ; Dong, Guo > ; You, Benjamin ; Gao, > Liming > Subject: [PATCH V3 10/15] UefiPayloadPkg/Uef

Re: [edk2-devel] [PATCH] UefiPayloadPkg/BootManager: Add PS2 keyboard support

2019-12-17 Thread Ma, Maurice
cember 10, 2019 15:09 > To: devel@edk2.groups.io > Cc: Ma, Maurice ; You, Benjamin > ; Dong, Guo ; > u14...@gmail.com > Subject: [edk2-devel] [PATCH] UefiPayloadPkg/BootManager: Add PS2 > keyboard support > > Add PS2 keyboard support by default. > REF:https://bugzill

Re: [edk2-devel] [PATCH v2 057/105] .mailmap: Add an entry for Maurice Ma

2019-12-06 Thread Ma, Maurice
Reviewed-by: Maurice Ma Thanks, -Maurice > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Philippe Mathieu-Daudé > Sent: Friday, December 6, 2019 3:26 > To: devel@edk2.groups.io > Cc: Philippe Mathieu-Daude ; Ma, Maurice &

Re: [edk2-devel] [PATCH V2] UefiPayloadPkg/BootManager: Add PS2 keyboard support

2019-12-18 Thread Ma, Maurice
Reviewed-by: Maurice Ma Thanks, -Maurice > -Original Message- > From: Dong, Guo > Sent: Tuesday, December 17, 2019 16:12 > To: devel@edk2.groups.io > Cc: Ma, Maurice ; You, Benjamin > ; Dong, Guo ; > u14...@gmail.com > Subject: [edk2-devel] [PATCH V2] UefiPayload

Re: [EXTERNAL] Re: [edk2-devel] [PATCH v2 00/12] Add the VariablePolicy feature

2020-05-13 Thread Ma, Maurice
; Wang, Jian J ; Wu, Hao A ; Gao, Liming ; Justen, Jordan L ; Ard Biesheuvel ; Andrew Fish ; Ni, Ray ; Anthony Perard ; Julien Grall ; Ma, Maurice ; Dong, Guo ; You, Benjamin Subject: Re: [EXTERNAL] Re: [edk2-devel] [PATCH v2 00/12] Add the VariablePolicy feature “Not sure about

Re: [edk2-devel] [PATCH 02/18] UefiPayloadPkg: Remove All UGA Support

2020-05-08 Thread Ma, Maurice
Reviewed-by: Maurice Ma > -Original Message- > From: Jiang, Guomin > Sent: Friday, May 8, 2020 1:38 > To: devel@edk2.groups.io > Cc: GuoMinJ ; Ma, Maurice > ; Dong, Guo ; You, Benjamin > > Subject: [PATCH 02/18] UefiPayloadPkg: Remove All UGA Support > >

Re: [edk2-devel] [PATCH 16/18] UefiPayloadPkg: Remove All UGA Support

2020-05-08 Thread Ma, Maurice
Reviewed-by: Maurice Ma > -Original Message- > From: Jiang, Guomin > Sent: Friday, May 8, 2020 1:38 > To: devel@edk2.groups.io > Cc: GuoMinJ ; Ma, Maurice > ; Dong, Guo ; You, Benjamin > > Subject: [PATCH 16/18] UefiPayloadPkg: Remove All UGA Support > >

Re: [edk2-devel] [PATCH v3] IntelFsp2Pkg: Support Multi-Phase SiInit and debug handlers.

2020-05-07 Thread Ma, Maurice
Looks good to me. Reviewed-by: Maurice Ma Thanks Maurice > -Original Message- > From: Chiu, Chasel > Sent: Thursday, May 7, 2020 0:50 > To: devel@edk2.groups.io > Cc: Ma, Maurice ; Desimone, Nathaniel L > ; Zeng, Star > Subject: [PATCH v3] IntelFsp2Pkg: Suppo

Re: [edk2-devel] [PATCH v3 08/14] UefiPayloadPkg: Add VariablePolicy engine to UefiPayloadPkg platform

2020-05-21 Thread Ma, Maurice
Reviewed-by: Maurice Ma > -Original Message- > From: devel@edk2.groups.io On Behalf Of Michael > Kubacki > Sent: Thursday, May 21, 2020 15:43 > To: devel@edk2.groups.io > Cc: Ma, Maurice ; Dong, Guo ; > You, Benjamin ; Bret Barkelew > > Subject: [

Re: [edk2-devel] [PATCH v1 1/1] UefiPayloadPkg: Set default PciBaseSize on Ia32

2020-09-28 Thread Ma, Maurice
Reviewed-by: Maurice Ma > -Original Message- > From: devel@edk2.groups.io On Behalf Of Marcello > Sylvester Bauer > Sent: Thursday, September 24, 2020 4:49 > To: devel@edk2.groups.io > Cc: Marcello Sylvester Bauer ; > patrick.rudo...@9elements.com; Ma, Mauric

Re: [edk2-devel] [PATCH v3 1/3] UefiPayloadPkg: Store the size of the MMCONF window

2020-07-22 Thread Ma, Maurice
Reviewed-by: Maurice Ma > -Original Message- > From: Marcello Sylvester Bauer > Sent: Wednesday, July 22, 2020 6:16 > To: devel@edk2.groups.io > Cc: Patrick Rudolph ; Christian Walter > ; Ma, Maurice ; > Dong, Guo ; You, Benjamin > Subject: [PATCH v3 1/3] UefiPa

Re: [edk2-devel] [PATCH v1 1/1] UefiPayloadPkg: Remove x86 legacy UART defaults

2020-07-08 Thread Ma, Maurice
hristian Walter > ; Ma, Maurice ; > Desimone, Nathaniel L ; Zeng, Star > > Subject: [PATCH v1 1/1] UefiPayloadPkg: Remove x86 legacy UART defaults > > From: Patrick Rudolph > > Signed-off-by: Patrick Rudolph > Signed-off-by: Marcello Sylvester Bauer > Cc: Patrick R

Re: [edk2-devel] [PATCH v1 1/1] UefiPayloadPkg: Remove x86 legacy UART defaults

2020-07-08 Thread Ma, Maurice
BTW, I just noticed that not all package maintainers are on the CC list. For changed under UefiPayloadPkg, please ensure you CC all UefiPayloadPkg maintainers listed in the Maintainers.txt under the root of the EDK2 directory. Thanks Maurice > -Original Message- > From: Ma, M

Re: [edk2-devel] [PATCH v2 1/1] UefiPayloadPkg: Remove x86 legacy UART defaults

2020-07-13 Thread Ma, Maurice
> -Original Message- > From: Marcello Sylvester Bauer > Sent: Monday, July 13, 2020 1:25 > To: devel@edk2.groups.io > Cc: Patrick Rudolph ; Christian Walter > ; Ma, Maurice ; > Desimone, Nathaniel L ; Zeng, Star > > Subject: [PATCH v2 1/1] UefiPayloadPkg: Remove x86 leg

Re: [edk2-devel] [PATCH V3 2/2] UefiPayloadPkg/Pci: Use the PCIE Base Addr stored in AcpiBoardInfo HOB

2020-06-17 Thread Ma, Maurice
Patch V3 addressed all my previous comments. It looks good to me. Reviewed-by: Maurice Ma Regards, Maurice > -Original Message- > From: Ni, Ray > Sent: Wednesday, June 17, 2020 1:41 > To: devel@edk2.groups.io > Cc: Ma, Maurice ; Dong, Guo ; > You, Benjamin > S

Re: [edk2-devel] [PATCH v6 08/14] UefiPayloadPkg: Add VariablePolicy engine to UefiPayloadPkg platform

2020-06-23 Thread Ma, Maurice
Reviewed-by: Maurice Ma > -Original Message- > From: Bret Barkelew > Sent: Monday, June 22, 2020 23:41 > To: devel@edk2.groups.io > Cc: Ma, Maurice ; Dong, Guo ; > You, Benjamin > Subject: [PATCH v6 08/14] UefiPayloadPkg: Add VariablePolicy engine to >

Re: [edk2-devel] [PATCH v2 1/1] UefiPayloadPkg: Make TerminalDxe build time configurable

2020-06-24 Thread Ma, Maurice
Reviewed-by: Maurice Ma > -Original Message- > From: Marcello Sylvester Bauer > Sent: Wednesday, June 24, 2020 2:58 > To: devel@edk2.groups.io > Cc: Patrick Rudolph ; Christian Walter > ; Ma, Maurice ; > Dong, Guo ; You, Benjamin > Subject: [PATCH v2 1

Re: [edk2-devel] [PATCH V1] UefiPayloadPkg:Fix NOOPT build failure

2020-06-22 Thread Ma, Maurice
Reviewed-by: Maurice Ma > -Original Message- > From: Dong, Guo > Sent: Saturday, June 20, 2020 19:15 > To: devel@edk2.groups.io > Cc: Ma, Maurice ; You, Benjamin > ; Dong, Guo > Subject: [edk2-devel] [PATCH V1] UefiPayloadPkg:Fix NOOPT build failure > > Wh

Re: [edk2-devel] [PATCH V2 2/2] UefiPayloadPkg/Pci: Use the PCIE Base Addr stored in AcpiBoardInfo HOB

2020-06-08 Thread Ma, Maurice
into UefiPayloadPkgIa32.dsc as well ? Thanks Maurice > -Original Message- > From: Ni, Ray > Sent: Wednesday, June 3, 2020 20:27 > To: devel@edk2.groups.io > Cc: Ma, Maurice ; Dong, Guo ; > You, Benjamin > Subject: [PATCH V2 2/2] UefiPayloadPkg/Pci: Use the PCIE Base Addr stored i

Re: [edk2-devel] [PATCH v5 08/14] UefiPayloadPkg: Add VariablePolicy engine to UefiPayloadPkg platform

2020-06-03 Thread Ma, Maurice
Reviewed-by: Maurice Ma > -Original Message- > From: Bret Barkelew > Sent: Tuesday, June 2, 2020 23:58 > To: devel@edk2.groups.io > Cc: Ma, Maurice ; Dong, Guo ; > You, Benjamin > Subject: [PATCH v5 08/14] UefiPayloadPkg: Add VariablePolicy engine to >

Re: [edk2-devel] [PATCH 2/2] UefiPayloadPkg/Pci: Use the PCIE Base Addr stored in AcpiBoardInfo HOB

2020-06-03 Thread Ma, Maurice
? Thanks Maurice > -Original Message- > From: Ni, Ray > Sent: Wednesday, June 3, 2020 3:21 > To: devel@edk2.groups.io > Cc: Ma, Maurice ; Dong, Guo ; > You, Benjamin > Subject: [PATCH 2/2] UefiPayloadPkg/Pci: Use the PCIE Base Addr stored in > AcpiBoardInfo HOB >

Re: [edk2-devel] [PATCH 2/2] UefiPayloadPkg/Pci: Use the PCIE Base Addr stored in AcpiBoardInfo HOB

2020-06-04 Thread Ma, Maurice
Hi, Ray, Yes, that addressed my questions. Thank you! Thanks Maurice > -Original Message- > From: Ni, Ray > Sent: Wednesday, June 3, 2020 20:06 > To: Ma, Maurice ; devel@edk2.groups.io > Cc: Dong, Guo ; You, Benjamin > > Subject: RE: [PATCH 2/2] UefiPayloadPkg/P

Re: [edk2-devel] [PATCH v10 10/46] UefiPayloadPkg: Prepare UefiPayloadPkg to use the VmgExitLib library

2020-07-20 Thread Ma, Maurice
; Gao, Liming > ; Kinney, Michael D ; Ni, > Ray ; Ma, Maurice ; Dong, Guo > ; You, Benjamin > Subject: [edk2-devel] [PATCH v10 10/46] UefiPayloadPkg: Prepare > UefiPayloadPkg to use the VmgExitLib library > > From: Tom Lendacky > > BZ: https://bugzilla.tianocore.org/show_

Re: [edk2-devel] [PATCH v2 1/2] UefiPayloadPkg: Store the real size of the MMCONF window

2020-07-20 Thread Ma, Maurice
Hi Marcello, Could you put a little bit more details in the patch commit message ? Thanks Maurice > -Original Message- > From: Marcello Sylvester Bauer > Sent: Thursday, July 16, 2020 4:48 > To: devel@edk2.groups.io > Cc: Patrick Rudolph ; Christian Walter

Re: [edk2-devel] [PATCH v2 2/2] MdePkg: Add support for variable size MMCONF space

2020-07-20 Thread Ma, Maurice
Thursday, July 16, 2020 4:48 > To: devel@edk2.groups.io > Cc: Patrick Rudolph ; Christian Walter > ; Ma, Maurice ; > Desimone, Nathaniel L ; Zeng, Star > ; Kinney, Michael D ; Gao, > Liming > Subject: [PATCH v2 2/2] MdePkg: Add support for variable size MMCONF space > > Fro

Re: [edk2-devel] [PATCH] UefiPayloadPkg/BlSupportDxe: Use EfiSmbiosProtocol to install tables

2021-01-20 Thread Ma, Maurice
the naming convention in EDK2, maybe use BlDxeInstallSmbiosTables instead of BlDxeInstallSMBIOStables(). Thanks Maurice > -Original Message- > From: Patrick Rudolph > Sent: Wednesday, January 20, 2021 8:02 > To: devel@edk2.groups.io > Cc: Ma, Maurice ; Dong, Guo ; > You, B

Re: [edk2-devel] [PATCH] UefiPayloadPkg: Add RNG support

2021-01-20 Thread Ma, Maurice
? Thanks Maurice > -Original Message- > From: Patrick Rudolph > Sent: Wednesday, January 20, 2021 7:52 > To: devel@edk2.groups.io > Cc: Ma, Maurice ; Dong, Guo ; > You, Benjamin > Subject: [PATCH] UefiPayloadPkg: Add RNG support > > Uses the RDRAND instructi

Re: [edk2-devel] [PATCH] UefiPayloadPkg/BlSupportDxe: Use EfiSmbiosProtocol to install tables

2021-01-21 Thread Ma, Maurice
> -Original Message- > From: Patrick Rudolph > Sent: Thursday, January 21, 2021 0:11 > To: Ma, Maurice > Cc: devel@edk2.groups.io; Dong, Guo ; You, Benjamin > > Subject: Re: [PATCH] UefiPayloadPkg/BlSupportDxe: Use EfiSmbiosProtocol to > install tables >

Re: [edk2-devel] [PATCH] UefiPayloadPkg: Add RNG support

2021-01-21 Thread Ma, Maurice
nt: Thursday, January 21, 2021 1:05 > To: Ma, Maurice > Cc: devel@edk2.groups.io; Dong, Guo ; You, Benjamin > > Subject: Re: [edk2-devel] [PATCH] UefiPayloadPkg: Add RNG support > > Hi Maurice, > it's a copy of the MdeModulePkg's BaseRngLib with runtime detection support. > &

Re: [edk2-devel] [PATCH] UefiPayloadPkg: Fix PciLib dependency on BlSupportDxe

2021-01-25 Thread Ma, Maurice
Reviewed-by: Maurice Ma Regards Maurice > -Original Message- > From: Patrick Rudolph > Sent: Monday, January 25, 2021 7:05 > To: devel@edk2.groups.io > Cc: Ma, Maurice ; Dong, Guo > ; You, Benjamin > Subject: [PATCH] UefiPayloadPkg: Fix PciLib depen

Re: [edk2-devel] [Patch V3 1/9] MdeModulePkg: Add Universal Payload general defination header file

2021-06-08 Thread Ma, Maurice
Hi, Ray, Yes, I agree. PLD might cause confusion sometimes. Maybe we just use the full name UNIVERSAL_PAYLOAD instead ? Thanks Maurice > -Original Message- > From: Ni, Ray > Sent: Tuesday, June 8, 2021 19:58 > To: Ma, Maurice ; Dong, Guo > ; Rangarajan, Ravi P &

Re: [edk2-devel] [PATCH v2] UefiPayloadPkg/UefiPayloadEntry: Improve bootloader memrange parsing

2021-06-17 Thread Ma, Maurice
ink we will need to add typecast to fix the build issue. Thanks Maurice > -Original Message- > From: Patrick Rudolph > Sent: Thursday, June 17, 2021 5:25 > To: devel@edk2.groups.io > Cc: Ma, Maurice ; Dong, Guo > ; You, Benjamin > Subject: [PATCH v2] UefiPayloadPk

Re: [edk2-devel] [PATCH] UefiPayloadPkg/UefiPayloadEntry: Improve bootloader memrange parsing

2021-06-17 Thread Ma, Maurice
Hi, Patrick, Thank you, I will take a look on the new patch! Regards Maurice > -Original Message- > From: Patrick Rudolph > Sent: Thursday, June 17, 2021 6:21 > To: Ma, Maurice > Cc: devel@edk2.groups.io; Dong, Guo ; You, > Benjamin > Subject: Re: [

Re: [edk2-devel] [PATCH v3] UefiPayloadPkg/UefiPayloadEntry: Improve bootloader memrange parsing

2021-06-21 Thread Ma, Maurice
Looks good to me. Reviewed-by: Maurice Ma Regards -Maurice > -Original Message- > From: Patrick Rudolph > Sent: Monday, June 21, 2021 1:10 > To: devel@edk2.groups.io > Cc: Ma, Maurice ; Dong, Guo > ; You, Benjamin > Subject: [PATCH v3] UefiPayloadPkg/Uefi

Re: [edk2-devel] [PATCH] UefiPayloadPkg/UefiPayloadEntry: Improve bootloader memrange parsing

2021-06-16 Thread Ma, Maurice
MEM: 1EB74000 0038C000 2 MEM: 1EF0 0010 2 MEM: 1F00 0100 2 Thanks Maurice > -----Original Message- > From: Patrick Rudolph > Sent: Tuesday, June 15, 2021 6:23 > To: devel@edk2.groups.io > Cc: Ma, Maurice ; Dong,

Re: [edk2-devel] [PATCH] UefiPayloadPkg: Fix the build failure

2021-07-01 Thread Ma, Maurice
Reviewed-by: Maurice Ma -Maurice > -Original Message- > From: Dong, Guo > Sent: Wednesday, June 30, 2021 15:51 > To: devel@edk2.groups.io > Cc: Ma, Maurice ; You, Benjamin > > Subject: [edk2-devel] [PATCH] UefiPayloadPkg: Fix the build failure > >

Re: [edk2-devel] [PATCH V2] Maintainers.txt: Update Maintainers and reviewers for UefiPayloadPkg

2021-06-29 Thread Ma, Maurice
Reviewed-by: Maurice Ma -Maurice > -Original Message- > From: Dong, Guo > Sent: Tuesday, June 29, 2021 21:54 > To: devel@edk2.groups.io > Cc: Ma, Maurice ; You, Benjamin > ; Ni, Ray ; Kinney, Michael D > > Subject: [edk2-devel] [PATCH V2] Maintainers

Re: [edk2-devel] [patch V4 26/29] UefiPayloadPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib

2021-03-28 Thread Ma, Maurice
Reviewed-by: Maurice Ma -Maurice > -Original Message- > From: Bi, Dandan > Sent: Sunday, March 28, 2021 5:02 > To: devel@edk2.groups.io > Cc: Ma, Maurice ; Dong, Guo > ; You, Benjamin > Subject: [patch V4 26/29] UefiPayloadPkg: Consume MdeLibs.dsc.inc for > Re

Re: [edk2-devel] [patch V2 26/29] UefiPayloadPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib

2021-03-22 Thread Ma, Maurice
Reviewed-by: Maurice Ma > -Original Message- > From: Bi, Dandan > Sent: Monday, March 22, 2021 1:10 > To: devel@edk2.groups.io > Cc: Ma, Maurice ; Dong, Guo > ; You, Benjamin > Subject: [patch V2 26/29] UefiPayloadPkg: Consume MdeLibs.dsc.inc for > RegisterF

Re: [edk2-devel] [patch 25/28] UefiPayloadPkg: Consume RegisterFilterLibNull instance

2021-03-15 Thread Ma, Maurice
Reviewed-by: Maurice Ma Regards Maurice > -Original Message- > From: Bi, Dandan > Sent: Sunday, March 14, 2021 20:59 > To: devel@edk2.groups.io > Cc: Ma, Maurice ; Dong, Guo > ; You, Benjamin > Subject: [patch 25/28] UefiPayloadPkg: Consume RegisterFilterLibNul

Re: [edk2-devel] [PATCH] UefiPayloadPkg/UefiPayloadEntry: Remove 4GB memory WA

2021-02-22 Thread Ma, Maurice
Sent: Monday, February 22, 2021 21:22 To: devel@edk2.groups.io; fanjianf...@byosoft.com.cn; Ma, Maurice ; Patrick Rudolph ; Dong, Guo ; Dong, Eric Cc: You, Benjamin Subject: RE: [edk2-devel] [PATCH] UefiPayloadPkg/UefiPayloadEntry: Remove 4GB memory WA “But we could allocate room under 4G

Re: [edk2-devel] [PATCH] UefiPayloadPkg/UefiPayloadEntry: Remove 4GB memory WA

2021-02-23 Thread Ma, Maurice
Hi, Ray, Eric and Jeff, Sure, I am OK with that too. Thank you all for looking into it and provide a solution quickly. Regards Maurice From: Ni, Ray Sent: Tuesday, February 23, 2021 1:08 To: Ma, Maurice ; devel@edk2.groups.io; fanjianf...@byosoft.com.cn; Patrick Rudolph ; Dong, Guo ; Dong

Re: [edk2-devel] [PATCH 3/4] UefiPayloadPkg/UefiPayloadPkg.dsc: Consume MicrocodeLib

2021-04-07 Thread Ma, Maurice
Reviewed-by: Maurice Ma -Maurice > -Original Message- > From: Ni, Ray > Sent: Thursday, April 1, 2021 22:58 > To: devel@edk2.groups.io > Cc: Ma, Maurice ; Dong, Guo > ; You, Benjamin > Subject: [PATCH 3/4] UefiPayloadPkg/UefiPayloadPkg.dsc: Consume > Micr

Re: [edk2-devel] [PATCH] Maintainers.txt: Update Maintainers and reviewers for UefiPayloadPkg

2021-02-05 Thread Ma, Maurice
Reviewed-by: Maurice Ma Regards Maurice > -Original Message- > From: Guo Dong > Sent: Sunday, January 24, 2021 9:59 > To: devel@edk2.groups.io > Cc: Ma, Maurice ; You, Benjamin > ; philipp.deppenwi...@9elements.com; Kinney, > Michael D > Subject: [edk2-devel]

Re: [edk2-devel] [PATCH] UefiPayloadPkg/UefiPayloadEntry: Remove 4GB memory WA

2021-02-18 Thread Ma, Maurice
Reviewed-by: Maurice Ma Regards Maurice > -Original Message- > From: Dong, Guo > Sent: Sunday, February 14, 2021 21:13 > To: devel@edk2.groups.io > Cc: Ma, Maurice ; You, Benjamin > > Subject: [edk2-devel] [PATCH] UefiPayloadPkg/UefiPayloadEntry: Remove > 4GB

Re: [edk2-devel] [PATCH] UefiPayloadPkg/UefiPayloadEntry: Remove 4GB memory WA

2021-02-22 Thread Ma, Maurice
; Thanks Maurice > -Original Message- > From: Patrick Rudolph > Sent: Monday, February 22, 2021 7:43 > To: Dong, Guo > Cc: devel@edk2.groups.io; Ma, Maurice ; You, > Benjamin > Subject: Re: [edk2-devel] [PATCH] UefiPayloadPkg/UefiPayloadEntry: > Remove 4GB memory WA

Re: [edk2-devel] [PATCH] UefiPayloadPkg: Remove SystemTableInfo GUID.

2021-10-11 Thread Ma, Maurice
Reviewed-by: Maurice Ma > -Original Message- > From: Kesavan Balakrishnan, ThiyaguX > > Sent: Sunday, October 10, 2021 21:30 > To: devel@edk2.groups.io > Cc: Kesavan Balakrishnan, ThiyaguX > ; Ma, Maurice > ; Dong, Guo ; Ni, Ray > ; You, Benjamin ; Liu, &g

Re: [edk2-devel] [`edk2-devel][PATCH v2] UefiPayloadPkg: Fix ECC reported issues

2021-10-18 Thread Ma, Maurice
Reviewed-by: Maurice Ma > -Original Message- > From: devel@edk2.groups.io On Behalf Of Guo > Dong > Sent: Friday, October 15, 2021 16:35 > To: devel@edk2.groups.io > Cc: Dong, Guo ; Ni, Ray ; Ma, > Maurice ; You, Benjamin > > Subject: [edk2-devel] [`edk2-deve

Re: [edk2-devel] [`edk2-devel][PATCH V2] UefiPayloadPkg: Fix the build issue for coreboot

2021-10-15 Thread Ma, Maurice
There is a typo ' failue' in the commit message. Other than that, looks good. Reviewed-by: Maurice Ma > -Original Message- > From: Dong, Guo > Sent: Thursday, October 14, 2021 22:08 > To: devel@edk2.groups.io > Cc: Dong, Guo ; Ni, Ray ; Ma, > Maurice ; You, Ben

[edk2-devel] [PATCH 1/1] UefiPayloadPkg: Add PCI root bridge info hob support for SBL

2021-09-30 Thread Ma, Maurice
Current UefiPayloadPkg can suport PCI root bridge info HOB provided by bootloader. For UniversalPayload, bootloader can directly provide this HOB for payload consumption. However, for legacy UEFI payload, it is required to migrate the HOB information from bootloader HOB space to UEFI payload HOB

Re: [edk2-devel] [PATCH 1/1] UefiPayloadPkg: Add PCI root bridge info hob support for SBL

2021-09-30 Thread Ma, Maurice
Sorry for the duplicated msg. Please ignore the duplicated one. Thanks, -Maurice > -Original Message- > From: devel@edk2.groups.io On Behalf Of Ma, > Maurice > Sent: Thursday, September 30, 2021 9:59 > To: devel@edk2.groups.io > Cc: Ma, Maurice ; Ni, Ray ; Dong, >

Re: [edk2-devel] [PATCH] UefiPayloadPkg: Add Macro to enable or diable some drivers.

2021-09-20 Thread Ma, Maurice
Reviewed-by: Maurice Ma > -Original Message- > From: Liu, Zhiguang > Sent: Saturday, September 18, 2021 0:49 > To: devel@edk2.groups.io > Cc: Dong, Guo ; Ni, Ray ; Ma, > Maurice ; You, Benjamin > > Subject: [PATCH] UefiPayloadPkg: Add Macro to enable or diable

Re: [edk2-devel] [PATCH] IntelFsp2Pkg/SplitFspBin.py: adopt FSP 2.3 specification.

2021-10-26 Thread Ma, Maurice
Reviewed-by: Maurice Ma > -Original Message- > From: Chiu, Chasel > Sent: Tuesday, October 26, 2021 1:06 > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Ma, Maurice > ; Desimone, Nathaniel L > ; Zeng, Star > Subject: [PATCH] IntelFsp2Pkg/SplitFspBin.py: ado

Re: [edk2-devel] [PATCH V3 10/29] UefiPayloadPkg: PreparePrepare UefiPayloadPkg to use TdxLib

2021-11-01 Thread Ma, Maurice
groups.io > Cc: Xu, Min M ; Dong, Guo ; Ni, > Ray ; Ma, Maurice ; You, > Benjamin ; Yao, Jiewen ; > Gerd Hoffmann > Subject: [PATCH V3 10/29] UefiPayloadPkg: PreparePrepare UefiPayloadPkg > to use TdxLib > > RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 > >

Re: [edk2-devel] [PATCH] UefiPayloadPkg/PayloadEntry: Inherit 4/5-level paging from bootloader

2021-12-02 Thread Ma, Maurice
Reviewed-by: Maurice Ma > -Original Message- > From: Ni, Ray > Sent: Friday, August 6, 2021 1:16 > To: devel@edk2.groups.io > Cc: Dong, Guo ; Ma, Maurice > ; You, Benjamin > Subject: [PATCH] UefiPayloadPkg/PayloadEntry: Inherit 4/5-level paging from > bootloade

Re: [edk2-devel] [edk2-platform][PATCH] UefiPayloadPkg: Fix PciHostBridgeLib

2022-02-16 Thread Ma, Maurice
Reviewed-by: Maurice Ma > -Original Message- > From: Patrick Rudolph > Sent: Monday, February 7, 2022 2:01 > To: devel@edk2.groups.io > Cc: Ni, Ray ; Ma, Maurice ; You, > Benjamin ; Dong, Guo > Subject: [edk2-platform][PATCH] UefiPayloadPkg: Fix PciHostBri

Re: [edk2-devel] [PATCH 1/2] UefiPayloadPkg: Add i801 SMBus controller DXE

2022-02-17 Thread Ma, Maurice
ups.io On Behalf Of Sean > Rhodes > Sent: Thursday, February 17, 2022 9:51 > To: devel@edk2.groups.io > Cc: Dong, Guo ; Patrick Rudolph > ; Ni, Ray ; Ma, > Maurice ; You, Benjamin > > Subject: [edk2-devel] [PATCH 1/2] UefiPayloadPkg: Add i801 SMBus > controller DXE > >

Re: [edk2-devel] [PATCH 2/2] UefiPayloadPkg: Hookup SD Card timeout

2022-02-18 Thread Ma, Maurice
uot; might not be accurate to cover the MMC device. Maybe use "SD_MMC_TIMEOUT" ? Thanks, Maurice > -Original Message- > From: Sean Rhodes > Sent: Thursday, February 17, 2022 23:24 > To: devel@edk2.groups.io > Cc: Dong, Guo ; Rhodes, Sean ; > Ni, Ray ; Ma

Re: [edk2-devel] [PATCH 2/2] UefiPayloadPkg: Hookup SD/MMC timeout

2022-02-18 Thread Ma, Maurice
Reviewed-by: Maurice Ma > -Original Message- > From: Sean Rhodes > Sent: Friday, February 18, 2022 6:52 > To: devel@edk2.groups.io > Cc: Dong, Guo ; Rhodes, Sean ; > Ni, Ray ; Ma, Maurice ; You, > Benjamin > Subject: [PATCH 2/2] UefiPayloadPkg: Hookup

Re: [edk2-devel] [PATCH] IntelFsp2Pkg: BaseFspSwitchStackLib Support for X64 Build

2022-02-22 Thread Ma, Maurice
Several comments as below: 1. Need to ensure sufficient space to save IDT The following will only reserve 8 bytes on stack to save IDT. It is fine for x86, but for x64 mode, the SIDT needs at least 80 bits. So we might want to reserve 16 byte for the changes listed below to void buffer

Re: [edk2-devel] [PATCH 2/2] UefiPayloadPkg: Hook up RNG support

2022-02-23 Thread Ma, Maurice
Reviewed-by: Maurice Ma > -Original Message- > From: devel@edk2.groups.io On Behalf Of Sean > Rhodes > Sent: Wednesday, February 23, 2022 14:44 > To: devel@edk2.groups.io > Cc: Dong, Guo ; Patrick Rudolph > ; Yao, Jiewen ; > Wang, Jian J ; Ni, Ray ; Ma, &

Re: [edk2-devel] [PATCH 1/1] UefiPayloadPkg/PayloadLoaderPeim: Replace Delta type INTN with UINTN

2022-02-01 Thread Ma, Maurice
function RelocateElf64Sections() inside file UefiPayloadPkg\PayloadLoaderPeim\ElfLib\Elf64Lib.c. Thanks Maurice > -Original Message- > From: Jiang, Guomin > Sent: Saturday, January 29, 2022 0:31 > To: devel@edk2.groups.io > Cc: Dong, Guo ; Ni, Ray ; Ma, >

Re: [edk2-devel] [Patch V2 1/1] UefiPayloadPkg/PayloadLoaderPeim: Force UINTN before save Ptr

2022-02-10 Thread Ma, Maurice
Reviewed-by: Maurice Ma > -Original Message- > From: Jiang, Guomin > Sent: Wednesday, February 9, 2022 19:03 > To: devel@edk2.groups.io > Cc: Dong, Guo ; Ni, Ray ; Ma, > Maurice ; You, Benjamin > Subject: [Patch V2 1/1] UefiPayloadPkg/PayloadLoaderPeim: Force UI

Re: [edk2-devel] [PATCH] UefiPayloadPkg: Not use BaseCpuTimerLib by default.

2022-01-14 Thread Ma, Maurice
Reviewed-by: Maurice Ma > -Original Message- > From: Liu, Zhiguang > Sent: Thursday, January 13, 2022 22:15 > To: devel@edk2.groups.io > Cc: Dong, Guo ; Ni, Ray ; Ma, > Maurice ; You, Benjamin > > Subject: [PATCH] UefiPayloadPkg: Not use BaseCpuTimerLib by defa