[edk2-devel] [PATCH 2/2] RedfishPkg/RedfishDiscoverDxe: provide PCD to disable TLS host verify

Introduce PCD PcdRedfishTlsHostVerifyDisabled to RedfishDiscoverDxe driver. Setting this PCD to true will turn off TLS host verify in HTTPS connection between host and BMC. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- RedfishPkg/RedfishPkg.dec

[edk2-devel] [PATCH 1/1] RedfishPkg/RedfishDebugLib: provide Redfish debug functions

Introduce RedfishDebugLib to RedfishPkg. This library provides several debugging functions for Redfish application. Redfish drivers rely on Rest Ex protocol to communicate with BMC and the communication data may be big and complicated. Use RedfishDebugLib in RedfishRestExDxe to simplify debugging

Re: [edk2-devel] [PATCH 1/2] NetworkPkg/HttpDxe: provide function to disable TLS host verify

, Nickle Wang via groups.io wrote: > diff --git a/MdePkg/Include/Protocol/Http.h b/MdePkg/Include/Protocol/Http.h > index 28e6221593..21a782eaac 100644 > --- a/MdePkg/Include/Protocol/Http.h > +++ b/MdePkg/Include/Protocol/Http.h > @@ -6,6 +6,7 @@ > > Copyright (c) 2016 - 20

Re: [edk2-devel] [PATCH V2 2/5] RedfishPkg: Fix condition checking of error status

Thanks for fixing this issue. Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: Minh Nguyen > Sent: Thursday, May 4, 2023 12:20 PM > To: devel@edk2.groups.io > Cc: patc...@amperecomputing.com; abner.ch...@amd.com; Nickle Wang > ; ig...@ami.com;

[edk2-devel] [edk2-redfish-client][PATCH v2 2/3] RedfishClientPkg: Introduce HiiToRedfishBootDxe driver

Add HiiToRedfishBootDxe driver with configure language defined in UNI file in order to demonstrate the use of Redfish Platform Config Protocol. Feature drivers under RedfishClientPkg will work with this driver and provide the REST data to Redfish service. Signed-off-by: Nickle Wang Cc: Abner

[edk2-devel] [edk2-redfish-client][PATCH v2 3/3] RedfishClientPkg: Introduce HiiToRedfishBiosDxe driver

Add HiiToRedfishBiosDxe driver with configure language defined in UNI file in order to demonstrate the use of Redfish Platform Config Protocol. Feature drivers under RedfishClientPkg will work with this driver and provide the REST data to Redfish service. Signed-off-by: Nickle Wang Cc: Abner

[edk2-devel] [edk2-redfish-client][PATCH] RedfishClientPkg/.github: fix uncrustify check error

Only run uncrustify check to c file and h file in script. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy --- .github/workflows/uncrustify-check.sh | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/.github/workflows/uncrustify-check.sh

[edk2-devel] [edk2-redfish-client][PATCH v2 1/3] RedfishClientPkg: Add a sample memory configuration HII driver

This is an HII sample driver of memory configuration. This demonstrates the communication between platform configuration (EDK2/HII) and Redfish service (Memory resource) base on RedfishClientPkg. The language ("x-uef-redfish-*") defined in the Redfish-specific uni file is the connection between

[edk2-devel] [edk2-redfish-client][PATCH v2 0/3] Introduce HII to Redfish sample drivers

V2: Rename "Hii2Redfish" to "HiiToRedfish" for file path, file name and file content. v1: Introduce three sample drivers to demonstrate the way of providing Redfish attributes in HII provider driver. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Nickle Wang (3):

[edk2-devel] [PATCH 2/3] RedfishPkg/RedfishPlatformConfigDxe: hide debug message

Change debug message level of showing ordered list op-code to REDFISH_PLATFORM_CONFIG_DEBUG. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- .../RedfishPlatformConfigDxe.c| 24 +-- 1 file changed, 12 insertions(+), 12

[edk2-devel] [PATCH 3/3] RedfishPkg/JsonLib: add object clear interface

-Add JsonObjectClear() interface for application to clear all elements in JSON object. -Fix typo. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- RedfishPkg/Include/Library/JsonLib.h | 33 +-- RedfishPkg/Library/JsonLib/JsonLib.c | 39

[edk2-devel] [PATCH 1/3] RedfishPkg/RedfishRestExDxe: fix CPU exception in RedfishRestExDxe

RedfishRestExDxe driver failed to uninstall service binding protocol when driver binding stop is called. Application drivers may still use RedfishRestExDxe after it is disconnected in system. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez ---

[edk2-devel] [PATCH] RedfishPkg/RedfishDebugLib: add new interfaces

Introduce DumpHiiStatementValue() and DumpRedfishValue() to RedfishDebugLib. Application uses these functions to debug print the value of HII_STATEMENT_VALUE and EDKII_REDFISH_VALUE. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy ---

[edk2-devel] [PATCH v2 2/3] RedfishPkg/RedfishPlatformConfigDxe: hide debug message

Change debug message level of showing ordered list op-code to REDFISH_PLATFORM_CONFIG_DEBUG. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- .../RedfishPlatformConfigDxe.h| 2 +- .../RedfishPlatformConfigDxe.c| 24

[edk2-devel] [PATCH v2 3/3] RedfishPkg/JsonLib: add object clear interface

-Add JsonObjectClear() interface for application to clear all elements in JSON object. -Fix typo. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez Reviewed-by: Abner Chang --- RedfishPkg/Include/Library/JsonLib.h | 33 +--

[edk2-devel] [PATCH v2 1/3] RedfishPkg/RedfishRestExDxe: fix CPU exception in RedfishRestExDxe

RedfishRestExDxe driver failed to uninstall service binding protocol when driver binding stop is called. Application drivers may still use RedfishRestExDxe after it is disconnected in system. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez Reviewed-by: Abner

Re: [edk2-devel] [PATCH 2/2] NetworkPkg/HttpDxe: fix driver binding start issue.

{ > > HttpCleanService (HttpService, UsingIpv6); > > Status = gBS->UninstallMultipleProtocolInterfaces ( > > , > > , > > >ServiceBinding, > > NULL > >

[edk2-devel] [PATCH] RedfishPkg/RedfishRestExDxe: reset session when TCP timeout happens

Call ResetHttpTslSession() to reset HTTP session when TCP timeout failure happens. So that application can perform retry to the same URI. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- .../RedfishRestExDxe/RedfishRestExInternal.h | 14

Re: [edk2-devel] [PATCH 1/2][edk2-redfish-client] RedfishClientPkg: fix format used for output __func__

Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: Mike Maslenkin > Sent: Tuesday, July 4, 2023 5:38 AM > To: devel@edk2.groups.io > Cc: abner.ch...@amd.com; Nickle Wang ; > ig...@ami.com; Mike Maslenkin > Subject: [PATCH 1/2][edk2-redfish-client]

Re: [edk2-devel] [PATCH 2/2][edk2-redfish-client] Tools: fix script name in README

Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: Mike Maslenkin > Sent: Tuesday, July 4, 2023 5:38 AM > To: devel@edk2.groups.io > Cc: abner.ch...@amd.com; Nickle Wang ; > ig...@ami.com; Mike Maslenkin > Subject: [PATCH 2/2][edk2-redfish-client] Tools: fix

Re: [edk2-devel] [PATCH v2 1/3] RedfishPkg/RedfishRestExDxe: fix CPU exception in RedfishRestExDxe

> RestExSb->RestExChildrenNum. > At first glance it appears this field must be decremented also. But I see no > usage > for RestExChildrenNum at all, may be it can be eliminated? > > Regards, > MIke. > > On Wed, Jul 5, 2023 at 9:56 AM Nickle Wang via groups.io >

Re: [edk2-devel] [PATCH v2 1/3] RedfishPkg/RedfishRestExDxe: fix CPU exception in RedfishRestExDxe

; > > RedfishPkg/RedfishRestExDxe: fix > > CPU > > > exception in RedfishRestExDxe > > > > > > External email: Use caution opening links or attachments > > > > > > > > > Just one note: > > > All manipulations with this list

[edk2-devel] [PATCH] RedfishPkg/RedfishPlatformConfigDxe: fix value type issue.

Fix incorrect value type issue for checked-box op-code. When the variable for checked-box is defined as UINT8 in varstore structure, IFR compiler assign its value type to EFI_IFR_TYPE_NUM_SIZE_8 instead of EFI_IFR_TYPE_BOOLEAN. However, the value type for checked-box is boolean value. Redfish

Re: [edk2-devel] [edk2-platforms][PATCH 1/2] ManageabilityPkg: Replace __FUNCTION__ with __func__

Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: abner.ch...@amd.com > Sent: Tuesday, May 30, 2023 2:33 PM > To: devel@edk2.groups.io > Cc: Isaac Oram ; Abdul Lateef Attar > ; Nickle Wang ; Tinh Nguyen > > Subject: [edk2-platforms][PATCH 1/2] ManageabilityPkg:

Re: [edk2-devel] [PATCH] RedfishPkg: Use DEBUG_MANAGEABILITY

Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: abner.ch...@amd.com > Sent: Tuesday, May 30, 2023 3:09 PM > To: devel@edk2.groups.io > Cc: Nickle Wang ; Igor Kulchytskyy > Subject: [PATCH] RedfishPkg: Use DEBUG_MANAGEABILITY > > External email: Use caution

Re: [edk2-devel] [edk2-platforms][PATCH 2/2] ManageabilityPkg: Use DEBUG_MANAGEABILITY

Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: abner.ch...@amd.com > Sent: Tuesday, May 30, 2023 2:33 PM > To: devel@edk2.groups.io > Cc: Isaac Oram ; Abdul Lateef Attar > ; Nickle Wang ; Tinh Nguyen > > Subject: [edk2-platforms][PATCH 2/2] ManageabilityPkg: Use

Re: [edk2-devel] [edk2-redfish-client][PATCH 2/2] RedfishClientPkg: Use DEBUG_MANAGEABILITY

Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: abner.ch...@amd.com > Sent: Tuesday, May 30, 2023 3:42 PM > To: devel@edk2.groups.io > Cc: Nickle Wang ; Igor Kulchytskyy > Subject: [edk2-redfish-client][PATCH 2/2] RedfishClientPkg: Use > DEBUG_MANAGEABILITY > >

[edk2-devel] [edk2-redfish-client][PATCH] RedfishClientPkg/.github: fix workflows folder location

There is additional ".github" folder in early commit. Move the workflows folder to correct location. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy --- .github/{.github => }/workflows/build.sh| 0 .github/{.github => }/workflows/build.yml | 0

[edk2-devel] [edk2-redfish-client][PATCH 8/9] RedfishClientPkg/MemoryDxe: Fix build error

- Fix "variable set but not used" error. - Fix missing "EFIAPI" error. - Fix typos. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy --- .../Features/Memory/V1_7_1/Dxe/MemoryDxe.c| 19 +++ 1 file changed, 11 insertions(+), 8 deletions(-) diff --git

[edk2-devel] [edk2-redfish-client][PATCH 9/9] RedfishClientPkg/ComputerSystemDxe: Fix build error

- Fix "variable set but not used" error. - Fix missing "EFIAPI" error. - Fix typos. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy --- .../v1_5_0/Dxe/ComputerSystemDxe.c| 19 +++ 1 file changed, 11 insertions(+), 8 deletions(-) diff --git

[edk2-devel] [edk2-redfish-client][PATCH 7/9] RedfishClientPkg/BiosDxe: Fix build error

- Fix "variable set but not used" error. - Fix missing "EFIAPI" error. - Fix typos. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy --- .../Features/Bios/v1_0_9/Dxe/BiosDxe.c| 20 ++- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git

[edk2-devel] [edk2-redfish-client][PATCH 5/9] RedfishClientPkg/RedfishETagDxe: Fix build error

- Fix missing "EFIAPI" build error. - Fix typos. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy --- .../Include/Protocol/EdkIIRedfishETagProtocol.h | 2 +- RedfishClientPkg/RedfishETagDxe/RedfishETagDxe.c| 13 - 2 files changed, 9 insertions(+), 6

[edk2-devel] [edk2-redfish-client][PATCH 4/9] RedfishClientPkg/RedfishFeatureUtilityLib: Fix build error

Follow latest definition of EDKII_REDFISH_VALUE_TYPES and rename all corresponding variable in RedfishFeatureUtilityLib. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy --- .../RedfishFeatureUtilityLib.c| 50 +-- 1 file changed, 25

[edk2-devel] [edk2-redfish-client][PATCH 6/9] RedfishClientPkg/RedfishConfigLangMapDxe: Fix build error

Add missing "EFIAPI" and fix build error Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy --- .../RedfishConfigLangMapDxe/RedfishConfigLangMapDxe.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/RedfishClientPkg/RedfishConfigLangMapDxe/RedfishConfigLangMapDxe.c

[edk2-devel] [edk2-redfish-client][PATCH 3/9] RedfishClientPkg/EdkIIRedfishResourceConfigLib: Fix build error

Remove uncessary parameter and fix build error. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy --- .../EdkIIRedfishResourceConfigLib.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[edk2-devel] [edk2-redfish-client][PATCH 2/9] RedfishClientPkg/RedfishAddendumLib: Fix build error

Rename ProvisioningCallback() to GetData() and OemCallback() to GetOemData() and fix build error Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy --- .../Library/RedfishAddendumLib/RedfishAddendumLib.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[edk2-devel] [PATCH] RedfishPkg: update Readme.md

RedfishClientPkg is moved from edk2-staging repository to edk2-redfish-client repository. Update the link in Readme.md to new location. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy --- RedfishPkg/Readme.md | 22 +++--- 1 file changed, 11 insertions(+), 11

[edk2-devel] [edk2-redfish-client][PATCH 0/9] Fix RedfishClientPkg build errors

Fix RedfishClientPkg build errors and typos. The compiler toolchain is GCC5. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Nickle Wang (9): RedfishClientPkg/ConverterLib: Fix unused-but-set-variable error RedfishClientPkg/RedfishAddendumLib: Fix build error

Re: [edk2-devel] [edk2-rfc] [RFC] Introduce new status code for ManageabilityPkg and Redfish*Pkg

uggests these align > more with the peripheral class errors, but your proposal looks better to me. > > Regards, > Isaac > > From: devel@edk2.groups.io On Behalf Of Nickle Wang > via groups.io > Sent: Wednesday, May 31, 2023 9:23 PM > To: r...@edk2.groups.i

[edk2-devel] [edk2-redfish-client][PATCH] RedfishClientPkg/.github: add build check and uncrustify check

Enable Github Actions to check below items: - RedfishClientPkg build check on push and pull request - Uncrustify check on pull request Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy --- .github/.github/workflows/build.sh| 70 +++

[edk2-devel] [edk2-redfish-client][PATCH] RedfishClientPkg/.github: add patch check

- Run /BaseTools/Scripts/PatchCheck.py to check changes on pull request. - Create main.yml to handle push check on main branch. And show the status of RedfishClientPkg on README.md Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy --- .github/workflows/build.yml | 3 --

[edk2-devel] [RFC] Introduce new status code for ManageabilityPkg and Redfish*Pkg

Hi edk2 community, I like to introduce EFI_COMPUTING_UNIT_MANAGEABILITY status code to PiStatusCode.h. EFI_COMPUTING_UNIT_MANAGEABILITY will be used in edk2 RedfishPkg and edk2-redfish-client RedfishClientPkg to report Redfish operation errors. It will also be used to report errors in

[edk2-devel] [edk2-redfish-client][PATCH 2/3] RedfishClientPkg: Introduce Hii2RedfishBootDxe driver

Add Hii2RedfishBootDxe driver with configure language defined in UNI file in order to demonstrate the use of Redfish Platform Config Protocol. Feature drivers under RedfishClientPkg will work with this driver and provide the REST data to Redfish service. Signed-off-by: Nickle Wang Cc: Abner

[edk2-devel] [edk2-redfish-client][PATCH 3/3] RedfishClientPkg: Introduce Hii2RedfishBiosDxe driver

Add Hii2RedfishBiosDxe driver with configure language defined in UNI file in order to demonstrate the use of Redfish Platform Config Protocol. Feature drivers under RedfishClientPkg will work with this driver and provide the REST data to Redfish service. Signed-off-by: Nickle Wang Cc: Abner

[edk2-devel] [edk2-redfish-client][PATCH 1/3] RedfishClientPkg: Add a sample memory configuration HII driver

This is an HII sample driver of memory configuration. This demonstrates the communication between platform configuration (EDK2/HII) and Redfish service (Memory resource) base on RedfishClientPkg. The language ("x-uef-redfish-*") defined in the Redfish-specific uni file is the connection between

[edk2-devel] [edk2-redfish-client][PATCH 0/3] Introduce HII to Redfish sample drivers

Introduce three sample drivers to demonstrate the way of providing Redfish attributes in HII provider driver. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Nickle Wang (3): RedfishClientPkg: Add a sample memory configuration HII driver RedfishClientPkg: Introduce

[edk2-devel] [edk2-redfish-client][PATCH v2 0/9] Fix RedfishClientPkg build errors

V2: Instead of modifying ConverterLib, use build option in INF file to fix build error V1: Fix RedfishClientPkg build errors and typos. The compiler toolchain is GCC5. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Nickle Wang (9): RedfishClientPkg/ConverterLib: Fix

[edk2-devel] [edk2-redfish-client][PATCH v2 9/9] RedfishClientPkg/ComputerSystemDxe: Fix build error

- Fix "variable set but not used" error. - Fix missing "EFIAPI" error. - Fix typos. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy --- .../v1_5_0/Dxe/ComputerSystemDxe.c| 19 +++ 1 file changed, 11 insertions(+), 8 deletions(-) diff --git

[edk2-devel] [edk2-redfish-client][PATCH v2 8/9] RedfishClientPkg/MemoryDxe: Fix build error

- Fix "variable set but not used" error. - Fix missing "EFIAPI" error. - Fix typos. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy --- .../Features/Memory/V1_7_1/Dxe/MemoryDxe.c| 19 +++ 1 file changed, 11 insertions(+), 8 deletions(-) diff --git

[edk2-devel] [edk2-redfish-client][PATCH v2 4/9] RedfishClientPkg/RedfishFeatureUtilityLib: Fix build error

Follow latest definition of EDKII_REDFISH_VALUE_TYPES and rename all corresponding variable in RedfishFeatureUtilityLib. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy --- .../RedfishFeatureUtilityLib.c| 50 +-- 1 file changed, 25

[edk2-devel] [edk2-redfish-client][PATCH v2 5/9] RedfishClientPkg/RedfishETagDxe: Fix build error

- Fix missing "EFIAPI" build error. - Fix typos. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy --- .../Include/Protocol/EdkIIRedfishETagProtocol.h | 2 +- RedfishClientPkg/RedfishETagDxe/RedfishETagDxe.c| 13 - 2 files changed, 9 insertions(+), 6

[edk2-devel] [edk2-redfish-client][PATCH v2 6/9] RedfishClientPkg/RedfishConfigLangMapDxe: Fix build error

Add missing "EFIAPI" and fix build error Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy --- .../RedfishConfigLangMapDxe/RedfishConfigLangMapDxe.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/RedfishClientPkg/RedfishConfigLangMapDxe/RedfishConfigLangMapDxe.c

[edk2-devel] [edk2-redfish-client][PATCH v2 7/9] RedfishClientPkg/BiosDxe: Fix build error

- Fix "variable set but not used" error. - Fix missing "EFIAPI" error. - Fix typos. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy --- .../Features/Bios/v1_0_9/Dxe/BiosDxe.c| 20 ++- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git

[edk2-devel] [edk2-redfish-client][PATCH v2 1/9] RedfishClientPkg/ConverterLib: Fix unused-but-set-variable error

Add GCC flag "-Wno-unused-but-set-variable" to remove build error because ConverterLib is 3rd party library. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy --- .../edk2library/Bios/v1_0_9/Lib.inf | 102 +-

[edk2-devel] [edk2-redfish-client][PATCH v2 2/9] RedfishClientPkg/RedfishAddendumLib: Fix build error

Rename ProvisioningCallback() to GetData() and OemCallback() to GetOemData() and fix build error Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy --- .../Library/RedfishAddendumLib/RedfishAddendumLib.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[edk2-devel] [edk2-redfish-client][PATCH v2 3/9] RedfishClientPkg/EdkIIRedfishResourceConfigLib: Fix build error

Remove uncessary parameter and fix build error. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy --- .../EdkIIRedfishResourceConfigLib.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[edk2-devel] [edk2-redfish-client][PATCH v2 3/9] RedfishClientPkg/EdkIIRedfishResourceConfigLib: Fix build error

Remove uncessary parameter and fix build error. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy --- .../EdkIIRedfishResourceConfigLib.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [edk2-devel] [PATCH] RedfishPkg/RedfishCrtLib: multiple definitions of strncpy.

ze_t, char *). > I would suggest to remove this declaration at all. > BTW there are duplicated declaration for memcmp, memset, strncmp. > > On Sat, Jul 22, 2023 at 11:18 AM Nickle Wang via groups.io > wrote: > > > > There are two definitions for strncpy() function in Re

Re: [edk2-devel] [PATCH] RedfishPkg/RedfishPlatformConfigDxe: fix can not set one-of option issue.

Hi Igor, Thanks for your review. I think this is feasible. Let me try it and provide version 2 patch. Thanks, Nickle > -Original Message- > From: Igor Kulchytskyy > Sent: Monday, July 24, 2023 9:49 AM > To: Nickle Wang ; devel@edk2.groups.io > Cc: Abner Chang ; Nick Ramirez > >

Re: [edk2-devel] [PATCH] RedfishPkg/RedfishRestExDxe: return HTTP status code to caller.

> Subject: Re: [edk2-devel] [PATCH] RedfishPkg/RedfishRestExDxe: return HTTP > status code to caller. > > External email: Use caution opening links or attachments > > > On Sat, Jul 22, 2023 at 11:18 AM Nickle Wang via groups.io > wrote: > > > > Return unsupported

[edk2-devel] [PATCH] RedfishPkg/RedfishCrtLib: multiple definitions of strncpy.

There are two definitions for strncpy() function in RedfishCrtLib.h Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- RedfishPkg/Include/Library/RedfishCrtLib.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[edk2-devel] [PATCH] RedfishPkg/RedfishRestExDxe: return HTTP status code to caller.

Return unsupported HTTP status code to caller so caller can handle HTTP error status code. Current implementation only return EFI error to caller. Without knowing the HTTP status code, caller has trouble to handle HTTP request failure. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor

[edk2-devel] [PATCH] RedfishPkg/RedfishDiscoverDxe: fix netmask check issue

- Add NTOHL() for coverting IP address from EFI_IPv4_ADDRESS to IP4_ADDR so that IP4_IS_VALID_NETMASK() return correct value. - Add DumpIpv4Address() in RedfishDebugLib and print IP address when invalid IP or subnet mask address is detected. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor

[edk2-devel] [PATCH] RedfishPkg/RedfishPlatformConfigDxe: fix can not set one-of option issue.

StatementValue->Buffer is converted from ASCII to Unicode by caller already so we don't have to convert it again. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- .../RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.c | 6 +- 1 file changed, 5

Re: [edk2-devel] [PATCH 2/2] NetworkPkg/HttpDxe: fix driver binding start issue.

FreePool (HttpService); > } > } > > Thanks, > Saloni > > -Original Message- > From: devel@edk2.groups.io On Behalf Of Nickle Wang > via groups.io > Sent: Tuesday, June 27, 2023 5:56 PM > To: devel@edk2.groups.io; Nickle Wang > Cc: Maciej Rabed

Re: [edk2-devel] [PATCH 2/2] NetworkPkg/HttpDxe: fix driver binding start issue.

May I know if someone can help to review this patch? Thanks, Nickle > -Original Message- > From: devel@edk2.groups.io On Behalf Of Nickle Wang > via groups.io > Sent: Friday, February 10, 2023 8:34 PM > To: devel@edk2.groups.io > Cc: Maciej Rabeda ; Siyuan Fu >

[edk2-devel] [edk2-redfish-client][PATCH 3/4] RedfishClientPkg: Update RedfishLib

RedfishLib has no capability to return HTTP header in response. However, feature driver needs to know the information like "ETag" or "Location" in HTTP response header per Redfish specification. Add corresponding function to return HTTP header in response data. Signed-off-by: Nickle Wang Cc:

[edk2-devel] [edk2-redfish-client][PATCH 2/4] RedfishClientPkg: Update Redfish feature core driver

Update Redfish feature core driver to support Redfish resource with multiple parents. A resource may be presented in different resource and the link in different resource point to the same location. Also add interchange data interface in feature core driver so feature core driver can talk to

[edk2-devel] [edk2-redfish-client][PATCH 1/4] RedfishClientPkg: Update ETag driver

Update ETag driver and use specific variable GUID. Also fix the typo in comment. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy --- RedfishClientPkg/RedfishClientPkg.dec| 2 +- RedfishClientPkg/RedfishETagDxe/RedfishETagDxe.h | 4 ++--

[edk2-devel] [edk2-redfish-client][PATCH 6/6] Tool/Redfish-Profile-Simulator: Update Bios schema version

Update mock-up file and use Bios schema version 1.0.9 in order to support BIOS configuration driver. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy --- .../redfish/v1/Systems/2M220100SL/Bios/index.json | 2 +- .../redfish/v1/Systems/2M220101SL/Bios/index.json

[edk2-devel] [edk2-redfish-client][PATCH 5/6] Tool/Redfish-Profile-Simulator: Add missing module

Add missing module import for conditional, RfCollection, RfResource, RfResourceRaw, hashlib and OrderedDict Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy --- Tools/Redfish-Profile-Simulator/v1sim/redfishURIs.py | 5 - Tools/Redfish-Profile-Simulator/v1sim/resource.py

[edk2-devel] [edk2-redfish-client][PATCH 3/6] Tool/Redfish-Profile-Simulator: Update patch method of computer system

Remove attribute check during patch of computer system and return content-type with JSON format in HTTP header. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy --- .../v1sim/resource.py | 4 ++- .../v1sim/systems.py | 28

[edk2-devel] [edk2-redfish-client][PATCH 2/6] Tool/Redfish-Profile-Simulator: Update computer system schema version

Update mock-up file and use computer system schema version 1.5.0 in order to support Boot.BootOrder attribute. Update UUID of 2M220101SL for working with Redfish Profile Simulator. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy --- .../redfish/v1/Systems/2M220100SL/index.json

[edk2-devel] [edk2-redfish-client][PATCH 1/6] Tool/Redfish-Profile-Simulator: Update requirements.txt

Updates the Python module dependency for Redfish Profile Simulator. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy --- Tools/Redfish-Profile-Simulator/requirements.txt | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Tools/Redfish-Profile-Simulator/requirements.txt

[edk2-devel] [edk2-redfish-client][PATCH 4/6] Tool/Redfish-Profile-Simulator: Add ETag support

Implement ETag support in HTTP header Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy --- .../v1sim/resource.py | 10 +-- .../v1sim/systems.py | 28 +++ 2 files changed, 25 insertions(+), 13 deletions(-)

Re: [edk2-devel] [edk2-platforms][PATCH] ManageabilityPkg/IpmiCommandLib: Add IpmiCommandLib to package

Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: abner.ch...@amd.com > Sent: Friday, May 5, 2023 1:24 PM > To: devel@edk2.groups.io > Cc: Isaac Oram ; Abdul Lateef Attar > ; Nickle Wang ; Tinh Nguyen > > Subject: [edk2-platforms][PATCH]

Re: [edk2-devel] [edk2-platforms][PATCH] ManageabilityPkg/IpmiCommandLib:IPMI Command Library

Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: abner.ch...@amd.com > Sent: Friday, May 5, 2023 1:24 PM > To: devel@edk2.groups.io > Cc: Isaac Oram ; Abdul Lateef Attar > ; Nickle Wang ; Tinh Nguyen > > Subject: [edk2-platforms][PATCH]

[edk2-devel] [edk2-redfish-client][PATCH 4/5] RedfishClientPkg: Introduce Computer System feature driver

Introduce new feature driver to support Computer System version 1.5.0 schema. Update corresponding FDF and DSC file to enable this feature driver. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy --- .../RedfishClientComponents.dsc.inc |7 +-

[edk2-devel] [edk2-redfish-client][PATCH 5/5] RedfishClientPkg: Introduce Bios feature driver

Introduce new feature driver to support Bios version 1.0.9 schema. Update corresponding FDF and DSC file to enable this feature driver. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy --- .../RedfishClientComponents.dsc.inc | 2 +

[edk2-devel] [edk2-redfish-client][PATCH 2/5] RedfishClientPkg: Rename Memory feature driver

Rename Memory driver by removing Redfish prefix. Update memory feature driver and support all properties under Memory schema. Also support "Identify" action in this driver. Corresponding changes are made to honor newly introduced library and protocol. Signed-off-by: Nickle Wang Cc: Abner Chang

[edk2-devel] [edk2-redfish-client][PATCH 3/5] RedfishClientPkg: Introduce Computer System collection driver

Introduce new feature driver to support Computer System Collection schema. Update corresponding FDF and DSC file to enable this feature driver. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy --- .../RedfishClientComponents.dsc.inc | 2 +

[edk2-devel] [edk2-redfish-client][PATCH 1/5] RedfishClientPkg: Rename RedfishMemoryCollection driver

Rename RedfishMemoryCollectionDxe by removing Redfish prefix. Update memory collection driver to support "Identify" action and also have code refactoring to support Redfish operation. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy --- .../RedfishClientComponents.dsc.inc

Re: [edk2-devel] [edk2-redfish-client][PATCH] RedfishClientPkg: Update Redfish converter lib

Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: abner.ch...@amd.com > Sent: Thursday, May 11, 2023 8:58 AM > To: devel@edk2.groups.io > Cc: Nickle Wang ; Igor Kulchytskyy > Subject: [edk2-redfish-client][PATCH] RedfishClientPkg: Update Redfish > converter > lib

[edk2-devel] [PATCH] RedfishPkg/RedfishPlatformConfigDxe: Fix string assert issue

When calling SetValue() with string type input, there is assertion of providing zero string ID to HII string function. Fix this issue by creating string ID for input string buffer. Fix Unicode and Ascii code convert issue together. Add text op-code support Signed-off-by: Nickle Wang Cc: Abner

Re: [edk2-devel] [edk2-redfish-client][PATCH 2/3] RedfishClientPkg: Add Redfish Resource Addendum Library

Thanks for your review comments, Abner! Updated in version 2 patch-set. Regards, Nickle > -Original Message- > From: Chang, Abner > Sent: Monday, May 15, 2023 11:20 AM > To: Nickle Wang ; devel@edk2.groups.io > Cc: Igor Kulchytskyy > Subject: RE: [edk2-redfish-client][PATCH 2/3]

[edk2-devel] [edk2-redfish-client][PATCH v2 3/3] RedfishClientPkg: Utilize RedfishAddendumLib

Bios feature driver utilizes RedfishAddendumLib and get additional data before sending BIOS attributes to Redfish service. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy --- .../Features/Bios/v1_0_9/Dxe/BiosDxe.inf | 2 + .../Include/RedfishResourceCommon.h |

[edk2-devel] [edk2-redfish-client][PATCH v2 1/3] RedfishClientPkg: Add Redfish Resource Addendum Protocol

Introduce Redfish Resource Addendum Protocol to Redfish feature driver. Feature driver uses this protocol to query OEM resource from platform in order to support Redfish OEM property. This protocol is also used to get addendum data that is required by BMC to manage Redfish BIOS service.

[edk2-devel] [edk2-redfish-client][PATCH v2 2/3] RedfishClientPkg: Add Redfish Resource Addendum Library

Implement RedfishAddendumLib to support Redfish Resource Addendum Protocol. Feature driver calls this library to get addendum data before providing data to Redfish service Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy --- RedfishClientPkg/RedfishClientLibs.dsc.inc| 4

[edk2-devel] [edk2-redfish-client][PATCH v2 0/3] Introduce resource addendum protocol

v2: Update protocol and library function description. v1: Introduce EDKII_REDFISH_RESOURCE_ADDENDUM_PROTOCOL to Redfish feature driver. Feature driver uses this protocol to query OEM resource from platform in order to support Redfish OEM property. This protocol is also used to get addendum data

[edk2-devel] [edk2-redfish-client][PATCH 5/8] RedfishClientPkg: Add RedfishLib.h

RedfishLib.h is the header file of RedfishLib library under RedfishClientPkg. RedfishLib is used by EDKII Redfish feature drivers. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy --- .../PrivateInclude/Library/RedfishLib.h | 616 ++ 1 file changed, 616

[edk2-devel] [edk2-redfish-client][PATCH 2/8] RedfishClientPkg: Add EDKII ETag driver

Implement EDKII ETag protocol to manipulate ETag of HTTP content. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy --- .../RedfishETagDxe/RedfishETagDxe.inf | 45 + .../Protocol/EdkIIRedfishETagProtocol.h | 76 ++ .../RedfishETagDxe/RedfishETagDxe.h |

[edk2-devel] [edk2-redfish-client][PATCH 3/8] RedfishClientPkg: Add EDKII ETag driver to build

Add EDKII ETag driver to RedfishClientPkg build. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy --- RedfishClientPkg/RedfishClientPkg.dec| 2 ++ RedfishClientPkg/RedfishClientComponents.dsc.inc | 1 + RedfishClientPkg/RedfishClient.fdf.inc | 1 + 3 files

[edk2-devel] [edk2-redfish-client][PATCH 1/8] RedfishClientPkg: Facilities of EDK2 Redfish Feature driver Env.

Initial common header file and meta files for feature drivers. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy --- RedfishClientPkg/RedfishClientPkg.dec | 5 +- .../Include/Guid/RedfishClientPkgTokenSpace.h | 20 +++ .../EdkIIRedfishResourceConfigProtocol.h |

[edk2-devel] [edk2-redfish-client][PATCH 4/8] RedfishClientPkg: Bug fix on RedfishFeatureCoreDxe

Action in StartupContext is not set properly. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy --- RedfishClientPkg/RedfishFeatureCoreDxe/RedfishFeatureCoreDxe.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[edk2-devel] [edk2-redfish-client][PATCH 7/8] RedfishClientPkg: RedfishLib

(This one is the same as RedfishLib under RedfishPkg. The one under RedfishPkg will be removed because RedfishLib is used by EDKII feature drivers which is belong to EDK2 Redfish client implementation) EDK2 port of DMTF libredfish project. We clone the necessary files from open source project

[edk2-devel] [edk2-redfish-client][PATCH 8/8] RedfishClientPkg: Update RedfishCollectionCommon.h

Update RedfishCollectionCommon.h header file. Remove the "Event" field from REDFISH_COLLECTION_PRIVATE because the feature driver is not started up by the EFI event that is registered by feature driver itself anymore. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy ---

Re: [edk2-devel] [PATCH] ShellPkg: Add a condition to print accurate type0 Bios Size in smbiosview.

Hi @Ray Ni, @Zhichao Gao, Could you please help to review this change? Thanks, Nickle > -Original Message- > From: devel@edk2.groups.io On Behalf Of Thejaswani > Putta via groups.io > Sent: Friday, April 21, 2023 9:00 AM

[edk2-devel] [edk2-redfish-client][PATCH 6/8] RedfishClientPkg: Add Redfish Feature Utility library

This is the helper library for EDKII Redfish feature drivers to manipulate Redfish properties. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy --- RedfishClientPkg/RedfishClientPkg.dec |3 + RedfishClientPkg/RedfishClientLibs.dsc.inc|3 +

[edk2-devel] [edk2-redfish-client][PATCH 1/2] RedfishClientPkg: Add a sample of feature driver

(The feature drivers suppose are tool-generated. We commit the memory one as the sample implementation.) This is the sample EDKII Redfish feature driver for Redfish Memory and Memory collection property. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy ---

[edk2-devel] [edk2-redfish-client][PATCH 2/2] RedfishClientPkg: Add Redfish memory edk2 modules to build

We plan to modify the build tool to pull in the corresponding Redfish resource converters and feature drivers into build according to the "x-uefi-redfish" language that applied on HII options in VFR files. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy ---

<    1   2   3   4   5   6   >