On 5/4/20 1:09 AM, Rebecca Cran wrote:
Add a null implementation library for QemuFwCfgLib, in order to
support building PciHostBridgeLib for bhyve.
Signed-off-by: Rebecca Cran
Cc: Jordan Justen
Cc: Laszlo Ersek
Cc: Ard Biesheuvel
Cc: Philippe Mathieu-Daudé
---
I think I've addressed all
On 5/4/20 1:42 PM, Philippe Mathieu-Daudé wrote:
On 4/30/20 7:16 PM, Ard Biesheuvel wrote:
Incorporate the Lan91x driver from EmbeddedPkg, which is only used
on obsolete ARM development platforms and does not follow the UEFI
driver model. This will allow us to drop if from the core EDK2
On 5/4/20 1:41 PM, Philippe Mathieu-Daudé wrote:
On 4/30/20 7:16 PM, Ard Biesheuvel wrote:
Incorporate the Lan91x driver from EmbeddedPkg, which is only used
on emulated ARM development platforms and does not follow the UEFI
driver model. This will allow us to drop if from the core EDK2
On 5/4/20 1:40 PM, Philippe Mathieu-Daudé wrote:
[...]
Reviewed-by: Philippe Mathieu-Daudé
Oops, without acute on EDK2:
Reviewed-by: Philippe Mathieu-Daude
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#58547): https://edk2
-by: Philippe Mathieu-Daudé
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#58546): https://edk2.groups.io/g/devel/message/58546
Mute This Topic: https://groups.io/mt/73380299/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https
(+), 6 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#58545): https://edk2.groups.io/g/devel/message/58545
Mute This Topic: https://groups.io/mt/73380297/21656
Group Owner: devel+ow...@edk2
.eed5fc57fc22
--- /dev/null
+++ b/Silicon/Synopsys/DesignWare/Drivers/DwEmmcDxe/DwEmmcDxe.c
@@ -0,0 +1,693 @@
+/** @file
+ This file implement the MMC Host Protocol for the DesignWare eMMC.
+
+ Copyright (c) 2014-2017, Linaro Limited. All rights reserved.
+
+ SPDX-License-Identifier: BSD-2-Clause-Pa
"VideoCore: 0x%ll08X (Size 0x%ll08X)\n",
mVideoCoreBase, mVideoCoreSize));
+ DEBUG ((DEBUG_INFO, "Core Freq: %d MHz\n", gSerialLibCoreClockFreq /
100));
ASSERT (mSystemMemoryBase == 0);
ASSERT (VirtualMemoryMap != NULL);
Reviewed-by: Philippe Mathieu-Dau
Hi Ard,
On 4/30/20 10:25 AM, Ard Biesheuvel wrote:
The PL180 SD host controller driver is only used on emulated ARM
platforms, uses an obsolete version of the MMC host protocol and
does not adhere to the UEFI driver model.
Given the above, let's just move it into VExpressPkg where it
belongs.
Hi Laszlo,
On 4/29/20 2:20 AM, Rebecca Cran wrote:
In case you don't mind modifying when applying, I think Rebecca missed
here "Generated mechanically with find/sed."
Personally I'd also add "$ sed -i -e s/EFI_D_INFO/DEBUG_INFO/ $(git grep
-l EFI_D_INFO OvmfPkg/)".
Signed-off-by: Rebecca
PcdSetXX APIs.", 2015-04-10).
Got it, thanks for the pointer!
See also EFI_PCD_PROTOCOL in the Platform Init spec:
<https://uefi.org/specifications>.
Thanks!
Laszlo
Cc: Ard Biesheuvel
Cc: Jordan Justen
Cc: Leif Lindholm
Cc: Per Sundstrom
Cc: Philippe Mathieu-Daudé
Thanks
L
On 4/29/20 2:20 AM, Rebecca Cran wrote:
Generated mechanically with find/sed.
Signed-off-by: Rebecca Cran
^ I suppose this was meant for the patch description, since the
description is empty.
Rebecca Cran (1):
OvmfPkg: replace old EFI_D_ debug levels with new DEBUG_ ones
On 4/28/20 3:38 PM, Rebecca Cran wrote:
On 4/28/20 6:44 AM, Laszlo Ersek wrote:
Rebecca: thanks for the contribution. Personally I'd have preferred a
finer-grained approach here, but Phil removed the review burden on me.
Regarding the git history, edk2 unfortunately alreay carries a bunch of
On 4/28/20 2:44 PM, Laszlo Ersek wrote:
On 04/27/20 10:56, Philippe Mathieu-Daudé wrote:
On 4/25/20 12:17 AM, Rebecca Cran wrote:
Signed-off-by: Rebecca Cran
Cc: Jordan Justen
Cc: Laszlo Ersek
Cc: Ard Biesheuvel
---
OvmfPkg/AcpiPlatformDxe/EntryPoint.c | 8 +-
OvmfPkg
NULL class libraries into UEFI drivers, e.g. in order to set dynamic PCDs.
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Cc: Per Sundstrom
Cc: Philippe Mathieu-Daudé
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2681
Signed-off-by: Laszlo Ersek
---
ArmVirtPkg/Library/QemuFwCfgLib/QemuFwCfgLib.inf
libraries into UEFI drivers, e.g. in order to set
dynamic PCDs.
Cc: Ard Biesheuvel
Cc: Jordan Justen
Cc: Per Sundstrom
Cc: Philippe Mathieu-Daudé
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2681
Signed-off-by: Laszlo Ersek
---
OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgDxeLib.inf | 2 +-
1
On 4/24/20 9:53 AM, Laszlo Ersek wrote:
Port the DSC file changes from the similarly titled OvmfPkg patch in this
series to ArmVirtPkg.
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Cc: Per Sundstrom
Cc: Philippe Mathieu-Daudé
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2681
Signed-off
/org.tianocore" prefix follows the "opt/RFQDN/" recommendation
from QEMU's "docs/specs/fw_cfg.txt".
Cc: Ard Biesheuvel
Cc: Jordan Justen
Cc: Per Sundstrom
Cc: Philippe Mathieu-Daudé
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2681
Signed-off-by: Laszlo Ersek
On 4/27/20 7:33 PM, Rebecca Cran wrote:
On 4/27/20 3:03 AM, Philippe Mathieu-Daudé wrote:
+#include
+#include
+#include
Don't you need ?
Hmm, you're right. I'm not sure where I got
"IndustryStandard/QemuFwCfg.h" from, though I noticed QemuFwCfg.h itself
includes a n
On 4/28/20 7:08 AM, GH Cao wrote:
The original comment incorrectly named the PWM controller as Power Management
Contoller, this commit fixes it.
Signed-off-by: GH Cao
---
Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2836Pwm.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Hi Rebecca,
On 4/24/20 8:29 PM, Rebecca Cran wrote:
Add a null implementation library for QemuFwCfgLib, in order to
support building PciHostBridgeLib for bhyve.
Signed-off-by: Rebecca Cran
---
.../Library/QemuFwCfgLib/QemuFwCfgLibNull.inf | 37
On 4/25/20 12:17 AM, Rebecca Cran wrote:
Signed-off-by: Rebecca Cran
Cc: Jordan Justen
Cc: Laszlo Ersek
Cc: Ard Biesheuvel
---
OvmfPkg/AcpiPlatformDxe/EntryPoint.c | 8 +-
OvmfPkg/AcpiPlatformDxe/PciDecoding.c | 10 +--
OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpi.c | 32
Hi Rebecca,
On 4/25/20 12:55 AM, Rebecca Cran wrote:
This prevents overflow when printing DWORD fields such as the type 17
tables's extended DIMM size.
Similar issue with type 14:
ShellPrintEx(-1,-1,L"ItemType %d: %d\n", Index + 1,
Struct->Type14->Group[Index].ItemType);
Mathieu-Daudé
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2681
Signed-off-by: Laszlo Ersek
---
OvmfPkg/OvmfPkg.dec | 4 +
OvmfPkg/OvmfPkgIa32.dsc | 1 +
OvmfPkg/OvmfPkgIa32X64.dsc
previously.
Cc: Ard Biesheuvel
Cc: Jordan Justen
Cc: Per Sundstrom
Cc: Philippe Mathieu-Daudé
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2681
Signed-off-by: Laszlo Ersek
---
OvmfPkg/PlatformPei/Platform.c | 47 +---
1 file changed, 2 insertions(+), 45 deletions(-)
diff
previously.
Cc: Ard Biesheuvel
Cc: Jordan Justen
Cc: Per Sundstrom
Cc: Philippe Mathieu-Daudé
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2681
Signed-off-by: Laszlo Ersek
---
OvmfPkg/PlatformPei/PlatformPei.inf | 1 +
OvmfPkg/PlatformPei/MemDetect.c | 36
On 4/22/20 5:46 PM, Leif Lindholm wrote:
SetupGit.py sets the git config option diff.orderFile to
{edk2 directory}/BaseTools/Conf/diff.order, to override the default order
in which files are shown in a diff/patch/whatever. This is in imitation
of what is done manually in Laszlo's Unkempt Guide.
On 4/23/20 12:09 PM, Leif Lindholm wrote:
For whatever reason, the function pointer structs (and their retrieval
functions) were split up on data size boundary - separate for 16-bit,
32-bit, and 64-bit.
This makes the already tedious boilerplate require to deal with these
hardware quirks even
On 4/23/20 11:53 AM, Anthony PERARD wrote:
Remove support for DEBUG_ON_SERIAL_PORT because OvmfXen can't be build
with it due to a circular dependency:
DebugLib: BaseDebugLibSerialPort ->
SerialPortLib : XenConsoleSerialPortLib ->
XenHypercallLib : XenHypercallLib ->
On 4/23/20 11:53 AM, Anthony PERARD wrote:
Factor out debug port detection in PlatformDebugLibIoPort.
Signed-off-by: Anthony PERARD
---
.../PlatformDebugLibIoPort.inf| 1 +
.../PlatformRomDebugLibIoPort.inf | 1 +
.../PlatformDebugLibIoPort/DebugLibDetect.h
SC diffing simple.)
Cc: Anthony Perard
Cc: Ard Biesheuvel
Cc: Jordan Justen
Cc: Julien Grall
Cc: Philippe Mathieu-Daudé
Cc: Rebecca Cran
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2675
Signed-off-by: Laszlo Ersek
---
OvmfPkg/OvmfP
On 4/20/20 11:48 AM, Laszlo Ersek wrote:
On 04/17/20 18:19, Philippe Mathieu-Daudé wrote:
On 4/17/20 5:59 PM, Ard Biesheuvel wrote:
On 4/17/20 5:37 PM, Laszlo Ersek wrote:
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2675
Repo: https://pagure.io/lersek/edk2.git
Branch: rsl_cleanup
4+0x5f/0x1a0
? entry_SYSCALL_64_after_hwframe+0x44/0xa9
---[ end trace d5bee708166d198b ]---
efi: efi_reset_system() buggy! Reboot through BIOS
Cc: Anthony Perard
Cc: Ard Biesheuvel
Cc: Jordan Justen
Cc: Julien Grall
Cc: Philippe Mathieu-Daudé
Cc: Rebecca Cran
Ref: https://bugzilla.tianocore.o
t us add a simple bhyve-specific instance (later), and also allows us
to fix a long time dormant bug (now).
Cc: Anthony Perard
Cc: Ard Biesheuvel
Cc: Jordan Justen
Cc: Julien Grall
Cc: Philippe Mathieu-Daudé
Cc: Rebecca Cran
Thanks,
Laszlo
Laszlo Ersek (6):
OvmfPkg/ResetSystemLib: wrap lo
"reset -s" UEFI shell command, on both i440fx and q35.
Cc: Ard Biesheuvel
Cc: Jordan Justen
Cc: Philippe Mathieu-Daudé
Cc: Rebecca Cran
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2675
Signed-off-by: Laszlo Ersek
---
OvmfPkg/Library/ResetSystemLib/ResetSystemLib.inf | 1
", 2019-04-28.)
Cc: Ard Biesheuvel
Cc: Jordan Justen
Cc: Philippe Mathieu-Daudé
Cc: Rebecca Cran
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2675
Signed-off-by: Laszlo Ersek
---
OvmfPkg/Library/ResetSystemLib/ResetSystemLib.c | 6 +++---
1 file changed, 3 insertions(+), 3 de
: Philippe Mathieu-Daudé
Cc: Rebecca Cran
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2675
Signed-off-by: Laszlo Ersek
---
OvmfPkg/Library/ResetSystemLib/ResetSystemLib.inf | 2 ++
OvmfPkg/Library/ResetSystemLib/ResetSystemLib.c | 15 ---
2 files changed, 10 insert
On 4/17/20 5:37 PM, Laszlo Ersek wrote:
Wrap the source code and the INF file at 79 characters.
Cc: Ard Biesheuvel
Cc: Jordan Justen
Cc: Philippe Mathieu-Daudé
Cc: Rebecca Cran
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2675
Signed-off-by: Laszlo Ersek
---
OvmfPkg/Library
e value and the type
remain unchanged (the standard PCI_MAX_BAR macro expands to 0x0006).
"NonDiscoverablePciDeviceIo.h" gets the definition of PCI_MAX_BAR via its
existent #include directive.
Build-tested only.
Cc: Ard Biesheuvel
Cc: Hao A Wu
Cc: Jian J Wang
Cc: Philippe Mathieu
)
- VirtioMmioDeviceLib (one instance: VirtioMmioDeviceLib)
Cc: Ard Biesheuvel
Cc: Jordan Justen
Cc: Philippe Mathieu-Daudé
Cc: Sean Brogan
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2662
Signed-off-by: Laszlo Ersek
Reviewed-by: Philippe Mathieu-Daude
---
Notes:
Repo: https
Cc: Jordan Justen
Cc: Philippe Mathieu-Daudé
Fixes: 7c47d89003a6f8f7f6f0ce8ca7d3e87c630d14cc
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2572
Signed-off-by: Laszlo Ersek
Reviewed-by: Philippe Mathieu-Daude
Tested-by: Philippe Mathieu-Daude
---
Notes:
Ard, if you get to it first,
On 3/5/20 11:46 PM, Andrei Warkentin wrote:
From: Andrei Warkentin
The RPi4 TF-A is much smaller than RPi3 TF-A, and doesn't need
an extra 2MB region.
The note ...:
---vvv---
Note: this depends on the edk2 ArmPlatformPkg/PrePi: fix IS_XIP.
---^^^---
Signed-off-by: Andrei Warkentin
On 3/5/20 12:38 AM, Pete Batard wrote:
On 2020.03.04 22:31, Andrei Warkentin wrote:
The original change*** used positive logic (PcdPi4GBEnabled), while the
upstreamed change uses negative logic (PcdRamLimitTo3GB), which
requires an additional condition, or it blows up on 1GiB and 2GiB boards.
Cc: Ard Biesheuvel
Cc: Jordan Justen
Cc: Leif Lindholm
Cc: Philippe Mathieu-Daudé
Thanks
Laszlo
Laszlo Ersek (2):
OvmfPkg/PlatformBootManagerLib: sync Timeout with
PcdPlatformBootTimeOut
ArmVirtPkg/PlatformBootManagerLib: sync Timeout with
PcdPlatformBootTimeOut
ArmVirtPkg/
On 3/2/20 8:59 PM, Laszlo Ersek wrote:
On 02/26/20 23:11, Laszlo Ersek wrote:
Supersedes: <20200223172537.28464-1-ler...@redhat.com>
Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=1512
Repo: https://github.com/lersek/edk2.git
Branch: vcpu_hotplug_smm_bz_1512_v2
V1 was
block.
Cc: Ard Biesheuvel
Cc: Igor Mammedov
Cc: Jiewen Yao
Cc: Jordan Justen
Cc: Michael Kinney
Cc: Philippe Mathieu-Daudé
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1512
Signed-off-by: Laszlo Ersek
Acked-by: Ard Biesheuvel
---
Notes:
v2:
- Pick up Ard's Acked-by, which
: Jordan Justen
Cc: Michael Kinney
Cc: Philippe Mathieu-Daudé
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1512
Signed-off-by: Laszlo Ersek
Acked-by: Ard Biesheuvel
---
Notes:
v2:
- Pick up Ard's Acked-by, which is conditional on approval from Intel
reviewers on Cc
%r\n"
Do similarly in the SMM Core (update the message slightly).
Cc: Ard Biesheuvel
Cc: Eric Dong
Cc: Hao A Wu
Cc: Igor Mammedov
Cc: Jian J Wang
Cc: Jiewen Yao
Cc: Jordan Justen
Cc: Michael Kinney
Cc: Philippe Mathieu-Daudé
Cc: Ray Ni
Ref: https://bugzilla.tianocore.org/show_bug.c
Justen
Cc: Michael Kinney
Cc: Philippe Mathieu-Daudé
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1512
Signed-off-by: Laszlo Ersek
Acked-by: Ard Biesheuvel
---
Notes:
v2:
- Pick up Ard's Acked-by, which is conditional on approval from Intel
reviewers on Cc. (I'd like t
encounter an internal failure.
Cc: Ard Biesheuvel
Cc: Igor Mammedov
Cc: Jiewen Yao
Cc: Jordan Justen
Cc: Michael Kinney
Cc: Philippe Mathieu-Daudé
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1512
Signed-off-by: Laszlo Ersek
Acked-by: Ard Biesheuvel
---
Notes:
v2:
- Pic
dd a macro for this command value, because we'll need
it later.
At the same time, add a sanity check for the modern hotplug interface to
CpuHotplugSmm.
Cc: Ard Biesheuvel
Cc: Igor Mammedov
Cc: Jiewen Yao
Cc: Jordan Justen
Cc: Michael Kinney
Cc: Philippe Mathieu-Daudé
Ref: https://bugzilla.tia
On 2/28/20 11:38 AM, Pete Batard wrote:
The official BCM2835 ARM Peripherals guide lists the DW USB
controller as standard SoC device.
Treat is as such by adding its base address to Silicon.
Signed-off-by: Pete Batard
---
Platform/RaspberryPi/Drivers/DwUsbHostDxe/DwUsbHostDxe.c| 3 ++-
. The first would increase
inconsistency, the second would make "PatchCheck.py" yell. Convert these
files to CRLF uniformly (and while at it, expand hard TABS, because
"PatchCheck.py" catches those too).
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Cc: Philippe Mathieu-Daudé
Thanks,
Las
On 2/27/20 3:40 PM, Ard Biesheuvel wrote:
We currently include PcdLib.h in PlatformPeiLib, without declaring
this dependency in its .INF description. Since all the PCDs we use
resolve to fixed type in practice, this does not really matter at
the moment, but since we will be adding dynamic PCD
On 2/25/20 11:02 PM, Laszlo Ersek wrote:
On 02/25/20 21:51, Philippe Mathieu-Daudé wrote:
Hi Laszlo,
On 2/24/20 6:17 PM, Laszlo Ersek wrote:
In edk2 commit 333f32ec23dd, QemuVideoDxe gained support for QEMU's
"secondary-vga" device model (originally introduced in QEMU commit
63
6 -- even if
the device wasn't actually VGA compatible.
Restrict the IO Ports requirement to VGA compatible devices.
Cc: Ard Biesheuvel
Cc: Gerd Hoffmann
Cc: Jordan Justen
Cc: Marc W Chen
Cc: Philippe Mathieu-Daudé
Fixes: 662bd0da7fd77e4d2cf9ef4a78015af5cad7d9db
Ref: https://bugzilla.tianocore.o
On 2/13/20 7:29 PM, Philippe Mathieu-Daude wrote:
Math expressions written in terms of SafeIntLib function calls
are easily readable, making review trivial. Convert the truncation
checks added by commit 322ac05f8 to SafeIntLib calls.
Cc: Jian J Wang
Cc: Hao A Wu
Cc: Eric Dong
Suggested-by:
which have pretty readable calls.
This is my try at using it.
Regards,
Phil.
Cc: Jian J Wang
Cc: Hao A Wu
Cc: Eric Dong
Cc: Laszlo Ersek
Philippe Mathieu-Daudé (1):
MdeModulePkg/PiDxeS3BootScriptLib: Use SafeIntLib to avoid truncation
.../DxeS3BootScriptLib.inf
Math expressions written in terms of SafeIntLib function calls
are easily readable, making review trivial. Convert the truncation
checks added by commit 322ac05f8 to SafeIntLib calls.
Cc: Jian J Wang
Cc: Hao A Wu
Cc: Eric Dong
Suggested-by: Laszlo Ersek
Signed-off-by: Philippe Mathieu-Daude
s = gRT->GetVariable (EFI_IMAGE_SECURITY_DATABASE1, , NULL, , (VOID *) Data);
if (EFI_ERROR (Status)) {
-return IsForbidden;
+goto Done;
}
//
Reviewed-by: Philippe Mathieu-Daudé
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online
NT8 *) DbxList +
SiglistHeaderSize);
CertHashCount = (DbxList->SignatureListSize - SiglistHeaderSize) /
DbxList->SignatureSize;
Reviewed-by: Philippe Mathieu-Daudé
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#5436
On 2/10/20 11:54 PM, Laszlo Ersek wrote:
On 02/07/20 11:51, Laszlo Ersek wrote:
On 02/07/20 02:07, Philippe Mathieu-Daude wrote:
Around February of this year, Antoine posted various patches fixing
a huge quantity of typos, over 8000+ lines (such [1]).
This series salvages a third of his work.
On 2/10/20 4:53 AM, Chiu, Chasel wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1706
Issue was: invalid_operation: Invalid operation on
null-like value "Base".
Fixed it by initializing Base to 0 before entering
while loop.
Test:
Compared script output before and after this patch
From: Antoine Coeur
Correctly write 'definitions' in comments and documentation.
Cc: Hao A Wu
Signed-off-by: Antoine Coeur
Reviewed-by: Philippe Mathieu-Daude
Reviewed-by: Hao A Wu
Signed-off-by: Philippe Mathieu-Daude
---
SourceLevelDebugPkg/Include/Ia32/ProcessorContext.h | 2 +-
From: Antoine Coeur
Fix various typos in documentation, comments and debug strings.
Cc: Hao A Wu
Signed-off-by: Antoine Coeur
Reviewed-by: Philippe Mathieu-Daude
Reviewed-by: Hao A Wu
Signed-off-by: Philippe Mathieu-Daude
---
.../DebugAgent/DebugAgentCommon/DebugMp.h | 6 +--
From: Antoine Coeur
Fix various typos in comments and documentation.
Cc: Eric Dong
Cc: Ray Ni
Cc: Laszlo Ersek
Signed-off-by: Antoine Coeur
Reviewed-by: Philippe Mathieu-Daude
Reviewed-by: Laszlo Ersek
Reviewed-by: Eric Dong
Signed-off-by: Philippe Mathieu-Daude
---
From: Antoine Coeur
Fix various typos in comments and documentation.
Cc: Hao A Wu
Signed-off-by: Antoine Coeur
Reviewed-by: Philippe Mathieu-Daude
Reviewed-by: Hao A Wu
Signed-off-by: Philippe Mathieu-Daude
---
.../DebugCommunicationLibSerialPort.inf | 2 +-
From: Antoine Coeur
Fix various typos in comments and documentation.
Cc: Eric Dong
Cc: Ray Ni
Cc: Laszlo Ersek
Signed-off-by: Antoine Coeur
Reviewed-by: Philippe Mathieu-Daude
Reviewed-by: Laszlo Ersek
Reviewed-by: Eric Dong
Signed-off-by: Philippe Mathieu-Daude
---
From: Antoine Coeur
Fix few typos in comments and documentation.
Cc: Eric Dong
Cc: Ray Ni
Cc: Laszlo Ersek
Signed-off-by: Antoine Coeur
Reviewed-by: Philippe Mathieu-Daude
Reviewed-by: Laszlo Ersek
Reviewed-by: Eric Dong
Signed-off-by: Philippe Mathieu-Daude
---
Fix a typo in a comment.
Cc: Achin Gupta
Cc: Jiewen Yao
Cc: Supreeth Venkatesh
Reviewed-by: Jiewen Yao
Signed-off-by: Philippe Mathieu-Daude
---
StandaloneMmPkg/Core/Dispatcher.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/StandaloneMmPkg/Core/Dispatcher.c
From: Antoine Coeur
Fix few typos in comments.
Cc: Achin Gupta
Cc: Jiewen Yao
Cc: Supreeth Venkatesh
Signed-off-by: Antoine Coeur
Reviewed-by: Philippe Mathieu-Daude
Reviewed-by: Jiewen Yao
Signed-off-by: Philippe Mathieu-Daude
---
.../StandaloneMmPeCoffExtraActionLib.inf
From: Antoine Coeur
Fix various typos in documentation, comments and debug strings.
Cc: Jiewen Yao
Cc: Chao Zhang
Signed-off-by: Antoine Coeur
Reviewed-by: Philippe Mathieu-Daude
Reviewed-by: Jiewen Yao
Signed-off-by: Philippe Mathieu-Daude
---
From: Antoine Coeur
Fix various typos in comments and documentation.
Cc: Ray Ni
Cc: Zhichao Gao
Signed-off-by: Antoine Coeur
Reviewed-by: Philippe Mathieu-Daude
Reviewed-by: Zhichao Gao
Signed-off-by: Philippe Mathieu-Daude
---
ShellPkg/Application/Shell/ConsoleLogger.h| 4 +--
From: Antoine Coeur
Fix various typos in comments and documentation.
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Chao Zhang
Signed-off-by: Antoine Coeur
Reviewed-by: Philippe Mathieu-Daude
Reviewed-by: Jiewen Yao
Signed-off-by: Philippe Mathieu-Daude
---
SecurityPkg/Include/Library/TpmCommLib.h
From: Antoine Coeur
Fix various typos in comments and documentation.
Cc: Jiewen Yao
Cc: Chao Zhang
Signed-off-by: Antoine Coeur
Reviewed-by: Philippe Mathieu-Daude
Reviewed-by: Jiewen Yao
Signed-off-by: Philippe Mathieu-Daude
---
SignedCapsulePkg/SignedCapsulePkg.dec | 4 +--
From: Antoine Coeur
Fix various typos in comments and documentation.
Cc: Ray Ni
Cc: Zhichao Gao
Signed-off-by: Antoine Coeur
Reviewed-by: Philippe Mathieu-Daude
Reviewed-by: Zhichao Gao
Signed-off-by: Philippe Mathieu-Daude
---
ShellPkg/DynamicCommand/DpDynamicCommand/Dp.h |
From: Antoine Coeur
Fix various typos in documentation, comments and debug strings.
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Chao Zhang
Signed-off-by: Antoine Coeur
Reviewed-by: Philippe Mathieu-Daude
Reviewed-by: Jiewen Yao
Signed-off-by: Philippe Mathieu-Daude
---
From: Antoine Coeur
Fix few typos in comments and documentation.
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Chao Zhang
Signed-off-by: Antoine Coeur
Reviewed-by: Philippe Mathieu-Daude
Reviewed-by: Jiewen Yao
Signed-off-by: Philippe Mathieu-Daude
---
From: Antoine Coeur
Fix various typos in comments and documentation.
Cc: Jiaxin Wu
Cc: Siyuan Fu
Cc: Maciej Rabeda
Signed-off-by: Antoine Coeur
Reviewed-by: Philippe Mathieu-Daude
Reviewed-by: Maciej Rabeda
Signed-off-by: Philippe Mathieu-Daude
---
NetworkPkg/Ip4Dxe/Ip4Common.h |
From: Antoine Coeur
Fix few typos in comments and documentation.
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Chao Zhang
Signed-off-by: Antoine Coeur
Reviewed-by: Philippe Mathieu-Daude
Reviewed-by: Jiewen Yao
Signed-off-by: Philippe Mathieu-Daude
---
Correctly write 'Initialized'.
Cc: Jiaxin Wu
Cc: Siyuan Fu
Cc: Maciej Rabeda
Reviewed-by: Maciej Rabeda
Signed-off-by: Philippe Mathieu-Daude
---
NetworkPkg/HttpBootDxe/HttpBootConfig.h | 2 +-
NetworkPkg/HttpBootDxe/HttpBootConfig.c | 4 ++--
2 files changed, 3 insertions(+), 3
From: Antoine Coeur
Fix few typos in comments and documentation.
Cc: Jiaxin Wu
Cc: Siyuan Fu
Cc: Maciej Rabeda
Signed-off-by: Antoine Coeur
Reviewed-by: Philippe Mathieu-Daude
Reviewed-by: Maciej Rabeda
Signed-off-by: Philippe Mathieu-Daude
---
NetworkPkg/SnpDxe/Snp.h | 8
From: Antoine Coeur
Fix various typos in comments and documentation.
Cc: Jiaxin Wu
Cc: Siyuan Fu
Cc: Maciej Rabeda
Signed-off-by: Antoine Coeur
Reviewed-by: Philippe Mathieu-Daude
Reviewed-by: Maciej Rabeda
Signed-off-by: Philippe Mathieu-Daude
---
NetworkPkg/HttpBootDxe/HttpBootDhcp4.h
Fix a typo in a comment.
Cc: Jordan Justen
Cc: Laszlo Ersek
Cc: Ard Biesheuvel
Cc: Anthony Perard
Cc: Julien Grall
Acked-by: Anthony PERARD
Reviewed-by: Laszlo Ersek
Signed-off-by: Philippe Mathieu-Daude
---
OvmfPkg/XenBusDxe/GrantTable.h | 2 +-
1 file changed, 1 insertion(+), 1
From: Antoine Coeur
Fix various typos in comments and documentation.
Cc: Jordan Justen
Cc: Laszlo Ersek
Cc: Ard Biesheuvel
Cc: Anthony Perard
Cc: Julien Grall
Signed-off-by: Antoine Coeur
Reviewed-by: Philippe Mathieu-Daude
Acked-by: Anthony PERARD
Acked-by: Laszlo Ersek
Signed-off-by:
From: Antoine Coeur
Fix various typos in comments and documentation.
Cc: Jiaxin Wu
Cc: Siyuan Fu
Cc: Maciej Rabeda
Signed-off-by: Antoine Coeur
Reviewed-by: Philippe Mathieu-Daude
Reviewed-by: Maciej Rabeda
Signed-off-by: Philippe Mathieu-Daude
---
NetworkPkg/Udp6Dxe/Udp6Driver.h | 6
From: Antoine Coeur
Fix few typos in comments and documentation.
Cc: Jiaxin Wu
Cc: Siyuan Fu
Cc: Maciej Rabeda
Signed-off-by: Antoine Coeur
Reviewed-by: Philippe Mathieu-Daude
Reviewed-by: Maciej Rabeda
Signed-off-by: Philippe Mathieu-Daude
---
NetworkPkg/DpcDxe/Dpc.h | 2 +-
From: Antoine Coeur
Fix few typos in comments and documentation.
Cc: Jiaxin Wu
Cc: Siyuan Fu
Cc: Maciej Rabeda
Signed-off-by: Antoine Coeur
Reviewed-by: Philippe Mathieu-Daude
Reviewed-by: Maciej Rabeda
Signed-off-by: Philippe Mathieu-Daude
---
NetworkPkg/TcpDxe/SockImpl.h | 2 +-
From: Antoine Coeur
Fix various typos in comments and documentation.
Cc: Jiaxin Wu
Cc: Siyuan Fu
Cc: Maciej Rabeda
Signed-off-by: Antoine Coeur
Reviewed-by: Philippe Mathieu-Daude
Reviewed-by: Maciej Rabeda
Signed-off-by: Philippe Mathieu-Daude
---
NetworkPkg/Include/Library/HttpLib.h
From: Antoine Coeur
Fix various typos in comments and documentation.
Cc: Jiaxin Wu
Cc: Siyuan Fu
Cc: Maciej Rabeda
Signed-off-by: Antoine Coeur
Reviewed-by: Philippe Mathieu-Daude
Reviewed-by: Maciej Rabeda
Signed-off-by: Philippe Mathieu-Daude
---
NetworkPkg/HttpDxe/HttpDriver.h | 8
Fix a typo in the header documentation.
Reviewed-by: Laszlo Ersek
Signed-off-by: Philippe Mathieu-Daude
---
OvmfPkg/Csm/Include/Protocol/LegacyBios.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/OvmfPkg/Csm/Include/Protocol/LegacyBios.h
From: Antoine Coeur
Fix various typos in documentation, comments and debug strings.
Cc: Jiaxin Wu
Cc: Siyuan Fu
Cc: Maciej Rabeda
Signed-off-by: Antoine Coeur
Reviewed-by: Philippe Mathieu-Daude
Reviewed-by: Maciej Rabeda
Signed-off-by: Philippe Mathieu-Daude
---
From: Antoine Coeur
Fix various typos in comments and documentation.
Cc: Jiaxin Wu
Cc: Siyuan Fu
Cc: Maciej Rabeda
Signed-off-by: Antoine Coeur
Reviewed-by: Philippe Mathieu-Daude
Reviewed-by: Maciej Rabeda
Signed-off-by: Philippe Mathieu-Daude
---
NetworkPkg/UefiPxeBcDxe/PxeBcDhcp4.h
From: Antoine Coeur
Fix various typos in comments and documentation.
Cc: Jiaxin Wu
Cc: Siyuan Fu
Cc: Maciej Rabeda
Signed-off-by: Antoine Coeur
Reviewed-by: Philippe Mathieu-Daude
Reviewed-by: Maciej Rabeda
Signed-off-by: Philippe Mathieu-Daude
---
NetworkPkg/Ip6Dxe/Ip6ConfigImpl.h | 4
From: Antoine Coeur
Fix various typos in documentation, comments and debug strings.
Cc: Jiaxin Wu
Cc: Siyuan Fu
Cc: Maciej Rabeda
Signed-off-by: Antoine Coeur
Reviewed-by: Philippe Mathieu-Daude
Reviewed-by: Maciej Rabeda
Signed-off-by: Philippe Mathieu-Daude
---
From: Antoine Coeur
Fix various typos in documentation, comments and debug strings.
Cc: Jiaxin Wu
Cc: Siyuan Fu
Cc: Maciej Rabeda
Signed-off-by: Antoine Coeur
Reviewed-by: Philippe Mathieu-Daude
Reviewed-by: Maciej Rabeda
Signed-off-by: Philippe Mathieu-Daude
---
From: Antoine Coeur
Fix few typos in documentation, comments and debug strings.
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Chao Zhang
Signed-off-by: Antoine Coeur
Reviewed-by: Philippe Mathieu-Daude
Reviewed-by: Jiewen Yao
Signed-off-by: Philippe Mathieu-Daude
---
From: Antoine Coeur
Fix few typos in comments and documentation.
Cc: Jordan Justen
Cc: Laszlo Ersek
Cc: Ard Biesheuvel
Signed-off-by: Antoine Coeur
Reviewed-by: Philippe Mathieu-Daude
Reviewed-by: Laszlo Ersek
Signed-off-by: Philippe Mathieu-Daude
---
From: Antoine Coeur
Fix various typos in documentation, comments and strings.
Cc: Jordan Justen
Cc: Laszlo Ersek
Cc: Ard Biesheuvel
Signed-off-by: Antoine Coeur
Reviewed-by: Philippe Mathieu-Daude
Reviewed-by: David Woodhouse
Acked-by: Laszlo Ersek
Signed-off-by: Philippe Mathieu-Daude
From: Antoine Coeur
Correctly write 'serial', remove duplicated 'the'.
Cc: Ray Ni
Signed-off-by: Antoine Coeur
Reviewed-by: Philippe Mathieu-Daude
Acked-by: Liming Gao
Signed-off-by: Philippe Mathieu-Daude
---
PcAtChipsetPkg/Library/AcpiTimerLib/AcpiTimerLib.c | 2 +-
201 - 300 of 1005 matches
Mail list logo
