Hi Omkar,
I have a minor suggestion marked inline as [SAMI].
Other than that this patch looks good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 24/08/2021 07:00 AM, Omkar Anand Kulkarni wrote:
Enable the use of HEST table generation protocol, GHES error source
descriptor
Hi Omkar,
Thank you for this patch.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 24/08/2021 07:00 AM, Omkar Anand Kulkarni wrote:
For ACPI tables that are generated dynamically, define the ACPI table
header values that have to be used to build the table header.
Co-authored
Hi Pierre,
This patch looks good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 23/06/2021 12:58 PM, pierre.gond...@arm.com wrote:
From: Pierre Gondois
Add AmlCodeGenNameResourceTemplate() to generate code for a
ResourceTemplate().
AmlCodeGenNameResourceTemplate ("
Hi Pierre,
Thank you for this patch.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 23/06/2021 12:58 PM, pierre.gond...@arm.com wrote:
From: Pierre Gondois
_PRT entries can describe interrupt mapping for Pci devices. The
object is described in ACPI 6.4 s6.2.13 "_PRT (PCI Ro
Hi Pierre,
Please find my feedback marked inline as [SAMI].
Regards,
Sami Mujawar
On 23/06/2021 12:58 PM, pierre.gond...@arm.com wrote:
From: Pierre Gondois
Add helper functions to generate AML Resource Data describing memory
ranges. Memory ranges can be one, double or four words long
Hi Pierre,
Thank you for this patch. These changes look good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 23/06/2021 12:58 PM, pierre.gond...@arm.com wrote:
From: Pierre Gondois
Add AmlCodeGenNamePackage() to generate code for a Package().
AmlCodeGenNamePackage ("
Hi Pierre,
This patch looks good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 23/06/2021 12:58 PM, pierre.gond...@arm.com wrote:
From: Pierre Gondois
Introduce the following CmObj in the ArmNameSpaceObjects:
- CM_ARM_PCI_ADDRESS_MAP_INFO
- CM_ARM_PCI_INTERRUPT_MAP_INFO
Hi Pierre,
Thank you for this patch.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 23/06/2021 12:58 PM, pierre.gond...@arm.com wrote:
From: Pierre Gondois
This function allows to add a node as the last node of a parent node
in an AML tree. For instance,
ASL code corresponding
On Wed, Sep 8, 2021 at 07:08 PM, Gao, Zhichao wrote:
>
> Reviewed-by: Zhichao Gao
>
> Thanks,
> Zhichao
Hi Zhichao,
I was about to merge this patch when I noticed there is possibly a typo in your
r-b.
Can you confirm, please?
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Hi Pierre,
Thank you for this patch.
I have some feedback marked inline as [SAMI].
Regards,
Sami Muajwar
On 23/06/2021 12:58 PM, pierre.gond...@arm.com wrote:
From: Pierre Gondois
This generator allows to generate a SSDT table describing
a Pci express Bus. It uses the following CmObj:
-
Hi Ard,
I will review the series this week.
Regards,
Sami Mujawar
On 22/09/2021, 12:47, "Ard Biesheuvel" wrote:
On Fri, 3 Sept 2021 at 15:39, Omkar Kulkarni wrote:
>
> Gentle reminder, to review this patch series.
>
Sami, would you m
lperLib here, right?
With that changed,
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#80972): https://edk2.groups.io/g/devel/message/80972
Mute This Topic: https://groups.io/mt/83735183
Hi Pierre,
Thank you for this patch.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#80973): https://edk2.groups.io/g/devel/message/80973
Mute This Topic: https://groups.io/mt/83735184
error scenario.
With that changed,
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#80974): https://edk2.groups.io/g/devel/message/80974
Mute This Topic: https://groups.io/mt/83735186/21656
Hi Pierre,
This patch looks good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#80976): https://edk2.groups.io/g/devel/message/80976
Mute This Topic: https://groups.io/mt
en using the older python
> packages containing the BaseTools.
Can you check if the 8003 error needs to be disabled with latest Basetools,
please? If not can you drop this part from the patch.
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to t
to me.
With that changed,
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#80975): https://edk2.groups.io/g/devel/message/80975
Mute This Topic: https://groups.io/mt/83735187/21656
Group Owner:
Hi Pierre,
This change looks good to me.
Reviewed-by: Sami Mujawar
Thanks,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#80977): https://edk2.groups.io/g/devel/message/80977
Mute This Topic: https://groups.io/mt
Hi Pierre,
Thank you for this patch.
These updates look good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#80980): https://edk2.groups.io/g/devel/message/80980
Mute This Topic
near future.
Is it possible to list the deprecated APIs in the commit message, please?
Other than that this patch looks good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#80979): https://ed
Hi Omkar,
Thank you for adding this description. This is really helpful to
understand the framework.
I have a few minor suggestions marked inline as [SAMI].
With those changed,
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 24/08/2021 06:34 AM, Omkar Anand Kulkarni wrote:
Added
Hi Omkar,
Please find my feedback inline marked [SAMI].
Regards,
Sami Mujawar
On 24/08/2021 06:34 AM, Omkar Anand Kulkarni wrote:
Add the protocol definition of the MM_HEST_ERROR_SOURCE_DESC_PROTOCOL
protocol. This protocol can be implemented by MM drivers to publish
error source
Hi Abner,
Thank you for this patch. This change looks good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 04/10/2021 10:29 AM, Abner Chang wrote:
Complaint with BZ: #3665
https://bugzilla.tianocore.org/show_bug.cgi?id=3665
PcdPciIoTranslation PCD is relocated to MdePkg
Hi Omkar,
Please find my feedback inline marked [SAMI].
Regards,
Sami Mujawar
On 24/08/2021 06:33 AM, Omkar Anand Kulkarni wrote:
Introduce the HEST table generation protocol that allows platforms to
build the table with multiple error source descriptors and install the
table. The protocol
Hi Omkar,
Please find my response inline marked [SAMI].
Regards,
Sami Mujawar
On 24/08/2021 06:34 AM, Omkar Anand Kulkarni wrote:
Add a driver that retreives error source descriptors from MM and
populates those into the HEST ACPI table. The error source descriptors
that are available from
Hi Omkar,
This patch looks good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 24/08/2021 06:34 AM, Omkar Anand Kulkarni wrote:
Add helper macros for the generation of the HEST ACPI table. Macros to
initialize the HEST GHESv2 Notification Structure and Error Status
Structure
Hi Omkar,
The subject for this patch series should be fixed. These patches are not
for edk2-platforms.
Regards,
Sami Mujawar
On 24/08/2021 06:33 AM, Omkar Anand Kulkarni wrote:
Changes since v2:
- Addressed the comments given by Sami.
- Added Readme file with all cover letter information
Hi Rebecca,
Thank you for this patch. These changes look good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 04/10/2021 05:22 PM, Rebecca Cran wrote:
According to the SMBIOS specification, the ExtendedBiosSize field should
be zero when the BIOS size is less than 16MB:
"Si
Hi Omkar,
This patch looks good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 24/08/2021 07:00 AM, Omkar Anand Kulkarni wrote:
Allow platforms to define the base address and size of the memory region
that is reserved for MM drivers to populate the GHES generic error
status
Merged as 862e814de403..06a326caf125
Thanks.
Regards,
Sami Mujawar
On 17/08/2021 02:50 PM, Chris Jones wrote:
Bugzilla: 3568 (https://bugzilla.tianocore.org/show_bug.cgi?id=3568)
Update the FADT generator to use Acpi64.h. As the FADT revision tracks
the ACPI revision this updates the minor
Merged as 06a326caf125..942c9bd357d8
Thanks.
Regards,
Sami Mujawar
On 16/08/2021 03:52 PM, Chris Jones wrote:
Bugzilla: 3565 (https://bugzilla.tianocore.org/show_bug.cgi?id=3565)
This patch series updates the Acpiview GTDT parser and DynamicTables
GTDT generator to support ACPI 6.4
Hi Pierre,
I ahve a few minor suggestions marked inline as [SAMI].
With those changed.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 23/06/2021 12:40 PM, pierre.gond...@arm.com wrote:
From: Pierre Gondois
In the GIC interrupt model, logical processors are required to
have
Hi Pierre,
Thank you for this patch.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 23/06/2021 12:40 PM, pierre.gond...@arm.com wrote:
From: Pierre Gondois
Introduce the CM_ARM_LPI_INFO CmObj in the ArmNameSpaceObjects.
This allows to describe LPI state information, as described
Hi Omkar,
Thank you for this patch.
Please find my feedback marked inline as [SAMI].
Regards,
Sami Mujawar
On 24/08/2021 07:00 AM, Omkar Anand Kulkarni wrote:
DMC-620 memory controller improves system reliability by generating
interrupts on detecting ECC errors on the data. Add a initial
Merged as 422e5d2f7f1a..22873f58c40c
Regards,
Sami Mujawar
On 30/09/2021 08:48 AM, pierre.gond...@arm.com wrote:
From: Pierre Gondois
This patch-set aggregates various modifications in the
DynamicTablesPkg:
- Extract an AcpiTableHelperLib from TableHelperLib to remove
the dependency
Hi Pierre,
Thank you for this patch.
I have a minor suggestion marked inline as [SAMI].
With that changed,
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 23/06/2021 12:40 PM, pierre.gond...@arm.com wrote:
From: Pierre Gondois
Add AmlCodeGenRegister() to generate AML code
Hi Pierre,
Thank you for this patch.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 24/11/2021 04:23 PM, pierre.gond...@arm.com wrote:
From: Pierre Gondois
This patch fixes the following Ecc reported error:
'TAB' character is not allowed in source code,
please replace each 'TAB
Hi Pierre,
Thank you for this patch.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 24/11/2021 04:23 PM, pierre.gond...@arm.com wrote:
From: Pierre Gondois
This patch fixes the following Ecc reported error:
There should be no trailing white space in one line.
Signed-off-by: Pierre
Hi Pierre,
Thank you for this patch.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 24/11/2021 04:23 PM, pierre.gond...@arm.com wrote:
From: Pierre Gondois
This patch fixes the following Ecc reported error:
File has invalid Non-ACSII char.
Signed-off-by: Pierre Gondois
Hi Pierre,
Thank you for this patch.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 24/11/2021 04:23 PM, pierre.gond...@arm.com wrote:
From: Pierre Gondois
This patch fixes the following Ecc reported error:
A comparison of any pointer to zero must be done
via the NULL type
Signed
Hi Pierre,
Thank you for this patch.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 24/11/2021 04:23 PM, pierre.gond...@arm.com wrote:
From: Pierre Gondois
The two following packages have the same GUID:
- Platform/ARM/VExpressPkg/ArmVExpressPkg.dec
- edk2/ArmPlatformPkg
This patch series fixes the build breaks in SynQuacerEvalBoard.
Note: I have only tested that the build is fixed. I don't have
a board to test the functionality.
The changes can be seen at:
https://github.com/samimujawar/edk2-platforms/tree/2015_fix_arm_plat_build_break_v1
Sami Mujawar (3
BdsDxe depends on VariablePolicyHelperLib, so move it out from
VariableRuntimeDxe.inf and add it to LibraryClasses.DXE_DRIVER and
LibraryClasses.DXE_RUNTIME_DRIVER.
This is required to fix the build break in SynQuacerEvalBoard.dsc
Signed-off-by: Sami Mujawar
---
Platform/Socionext
EbcDxe is not supported for AArch32 builds of the firmware.
Therefore, move EbcDxe so that it is included only for AArch64
builds of the firmware.
Signed-off-by: Sami Mujawar
---
Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc | 4 +++-
Platform/Socionext/SynQuacerEvalBoard
ArmSoftFloatLib is required for the AARCH32 build of the firmware
for SynQuacerEvalBoard.
Therefore, add the missing ArmSoftFloatLib to SynQuacerEvalBoard.dsc
Signed-off-by: Sami Mujawar
---
Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc | 3 +++
1 file changed, 3 insertions
Hi Pierre,
Thank you for this patch.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 24/11/2021 04:23 PM, pierre.gond...@arm.com wrote:
From: Pierre Gondois
This patch fixes the following Ecc reported error:
Only Doxygen commands '@bug', '@todo', '@example',
'@file', '@attention
Hi Pierre,
Thank you for this patch.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 24/11/2021 04:23 PM, pierre.gond...@arm.com wrote:
From: Pierre Gondois
This patch fixes the following Ecc reported error:
The body of a function should be contained by open
and close braces
Hi Pierre,
Thank you for this patch.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 24/11/2021 04:23 PM, pierre.gond...@arm.com wrote:
From: Pierre Gondois
The two following modules have the same GUID:
- Platform/ARM/Morello/Library/PciHostBridgeLib/
PciHostBridgeLibFvp.inf
Hi Pierre,
Thank you for this patch.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 24/11/2021 04:23 PM, pierre.gond...@arm.com wrote:
From: Pierre Gondois
The two following modules have the same GUID:
- Platform/ARM/VExpressPkg/Library/
ArmVExpressLibRTSM/ArmVExpressLib.inf
Hi Pierre,
Please find my response inline marked [SAMI].
Regards,
Sami Mujawar
On 24/11/2021 04:23 PM, pierre.gond...@arm.com wrote:
From: Pierre Gondois
The two following modules have the same GUID:
- Platform/ARM/VExpressPkg/Library/
ArmVExpressLibRTSM/ArmVExpressLibSec.inf
- Silicon
Hi Leif, Ard, Wenyi,
Is it possible to review and provde feedback for this change, please?
Regards,
Sami Mujawar
On 17/12/2021 02:15 PM, Pierre Gondois wrote:
Hi Sami,
You are correct, as stated in
Silicon/Hisilicon/Library/ArmPlatformLibHisilicon/ArmPlatformLibSec.inf:
"
Hi Ard,
On 17/12/2021, 16:34, "Ard Biesheuvel" wrote:
On Fri, 17 Dec 2021 at 17:30, Sami Mujawar wrote:
>
> Hi Leif, Ard, Wenyi,
>
> Is it possible to review and provde feedback for this change, please?
>
I agree that this should be re
print formatter.
I think introducing ParseAcpiFieldBits() would allow the possibility of
reusing the code as well as adding validations for the field bits.
Please do let me know if you have any queries and I would be happy to help.
Regards,
Sami Mujawar
On 12/11/2021 01:27 PM, Abdul Lateef
The corresponding patch series to update the platforms in edk2-platforms is
submitted at https://edk2.groups.io/g/devel/message/83555
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#83565): https://edk2.groups.io/g/devel/message/83565
of EFI_ACPI_IO_REMAPPING_TABLE_REVISION
macro in the IORT table for RaspberryPi platform to
EFI_ACPI_IO_REMAPPING_TABLE_REV0.
Signed-off-by: Sami Mujawar
---
Platform/RaspberryPi/AcpiTables/Iort.aslc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Platform/RaspberryPi/AcpiTables/Iort.aslc
b/Platform
of EFI_ACPI_IO_REMAPPING_TABLE_REVISION
macro in the IORT table for N1SDP platform to
EFI_ACPI_IO_REMAPPING_TABLE_REV0.
Signed-off-by: Sami Mujawar
---
Platform/ARM/N1Sdp/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
| 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
a/Platform/ARM
of EFI_ACPI_IO_REMAPPING_TABLE_REVISION
macro in the IORT table for Styx platform to
EFI_ACPI_IO_REMAPPING_TABLE_REV0.
Signed-off-by: Sami Mujawar
---
Silicon/AMD/Styx/Drivers/AcpiPlatformDxe/Iort.aslc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Silicon/AMD/Styx/Drivers/AcpiPlatformDxe/Iort.aslc
b
of EFI_ACPI_IO_REMAPPING_TABLE_REVISION
macro in the Configuration Manager for FVP platform to
EFI_ACPI_IO_REMAPPING_TABLE_REV0.
Signed-off-by: Sami Mujawar
---
Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
| 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
support to generate IORT Rev E.b compliant ACPI tables
using Dynamic Tables Framework.
The changes for the v3 series can be seen at:
https://github.com/samimujawar/edk2/tree/1527_iort_rev_eb_v3
Sami Mujawar (8):
MdePkg: IORT header update for IORT Rev E.b spec
ShellPkg: Acpiview: Abbreviate
Range Descriptors.
- add validations to check that the physical range base
and size of the Memory Range Descriptor is 64KB aligned.
- add validation to check that the ID mapping count is
set to 1.
Signed-off-by: Sami Mujawar
Reviewed-by: Zhichao Gao
---
Notes:
v2:
- No code
nodes and Memory Range
descriptors.
- add definition of node type 6 - Reserved Memory Range node.
- add definition for Memory Range Descriptors.
Signed-off-by: Sami Mujawar
Reviewed-by: Pierre Gondois
---
Notes:
v2:
- No code change since v1. Re-sending with v2 series.[SAMI
macro to
EFI_ACPI_IO_REMAPPING_TABLE_REV0.
Signed-off-by: Sami Mujawar
Reviewed-by: Zhichao Gao
---
Notes:
v2:
- Set EFI_ACPI_IO_REMAPPING_TABLE_REVISION to Rev 0 as [SAMI]
setting to Rev 3 will break existing platforms. The
problem is that existing code would
Some field names in the IORT table parser were longer than the
OUTPUT_FIELD_COLUMN_WIDTH plus indentation, resulting in loss of
the output print alignment. Therefore, abbreviate the field names.
Signed-off-by: Sami Mujawar
Reviewed-by: Zhichao Gao
Reviewed-by: Pierre Gondois
---
Notes:
v2
if revision is greater than 2.
- add support to populate Reserved Memory Range nodes and
the Memory range descriptors.
- add validation to check that the Identifier field is
unique.
Signed-off-by: Sami Mujawar
Reviewed-by: Pierre Gondois
---
Notes:
v2:
- The macro
Mapping count is zero rather than populating it with an incorrect
value.
Signed-off-by: Sami Mujawar
Reviewed-by: Pierre Gondois
---
Notes:
v2:
- No code change since v1. Re-sending with v2 series.[SAMI]
v3:
- No code change since v1. Re-sending with v3 series.[SAMI
The IORT generator is populating the reference field for Context and
PMU interrupts even if their count is zero.
Update the IORT generator to set the references only if the interrupt
count is not 0. Also add checks to ensure a valid reference token has
been provided.
Signed-off-by: Sami Mujawar
Add error handling when the IdMappingCount is not zero and the
IdMappingToken is NULL.
Signed-off-by: Sami Mujawar
---
Notes:
v3:
- New patch in this series. Moves error handling code for [SAMI]
IdMappingToken from patch v2 6/8 and v2 8/8 into this
patch.
Ref
ArmSoftFloatLib is required for the AARCH32 build of the firmware
for SynQuacerEvalBoard.
Therefore, add the missing ArmSoftFloatLib to SynQuacerEvalBoard.dsc
Signed-off-by: Sami Mujawar
---
Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc | 3 +++
1 file changed, 3 insertions
BdsDxe depends on VariablePolicyHelperLib, so move it out from
VariableRuntimeDxe.inf and add it to LibraryClasses.DXE_DRIVER and
LibraryClasses.DXE_RUNTIME_DRIVER.
This is required to fix the build break in SynQuacerEvalBoard.dsc
Signed-off-by: Sami Mujawar
---
Platform/Socionext
BdsDxe depends on VariablePolicyHelperLib, so move it out from
VariableRuntimeDxe.inf and add it to LibraryClasses.DXE_DRIVER and
LibraryClasses.DXE_RUNTIME_DRIVER.
This is required to fix the build break in CelloBoard.dsc
Signed-off-by: Sami Mujawar
---
Platform/LeMaker/CelloBoard
forms/tree/1527_iort_rev_eb_platforms_v1
Sami Mujawar (11):
Platform/Socionext: Fix build break for SynQuacerEvalBoard
Platform/LeMaker: Fix build break for CelloBoard
Platform/Socionext/SynQuacerEvalBoard: Add missing ArmSoftFloatLib
Platform/Socionext/SynQuacerEvalBoard: Disable EbcDxe for AArch32
builds
Pl
EbcDxe is not supported for AArch32 builds of the firmware.
Therefore, move EbcDxe so that it is included only for AArch64
builds of the firmware.
Signed-off-by: Sami Mujawar
---
Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc | 4 +++-
Platform/Socionext/SynQuacerEvalBoard
of EFI_ACPI_IO_REMAPPING_TABLE_REVISION
macro in the Configuration Manager for Morello FVP to
EFI_ACPI_IO_REMAPPING_TABLE_REV0.
Signed-off-by: Sami Mujawar
---
Platform/ARM/Morello/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManagerFvp.c
| 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
of EFI_ACPI_IO_REMAPPING_TABLE_REVISION
macro in the IORT table for SGI platforms to
EFI_ACPI_IO_REMAPPING_TABLE_REV0.
Signed-off-by: Sami Mujawar
---
Platform/ARM/SgiPkg/AcpiTables/Iort.aslc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Platform/ARM/SgiPkg/AcpiTables/Iort.aslc
b/Platform/ARM/SgiPkg
of EFI_ACPI_IO_REMAPPING_TABLE_REVISION
macro in the IORT table for SynQuacer platform to
EFI_ACPI_IO_REMAPPING_TABLE_REV0.
Signed-off-by: Sami Mujawar
---
Silicon/Socionext/SynQuacer/AcpiTables/Iort.aslc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Silicon/Socionext/SynQuacer/AcpiTables/Iort.aslc
b
build breaks and update IORT revision macro
(
https://edk2.groups.io/g/devel/topic/patch_edk2_platforms_v1/86954380?p=,,,20,0,0,0::recentpostdate/sticky,,,20,2,0,86954380,previd=1636542218927226425,nextid=1636541757114664345=1636542218927226425=1636541757114664345
)
Regards,
Sami Mujawar
Hi Ard,
Please find my response inline marked [SAMI].
Regards,
Sami Mujawar
On 10/11/2021 11:33 AM, Ard Biesheuvel wrote:
On Wed, 10 Nov 2021 at 12:01, Sami Mujawar wrote:
The first 4 patches in this series fix build breaks in upstream
edk2-platforms code for Socionext, Lemaker
Hi Min,
Thank you for all the updates. This patch series looks good to me.
Regards,
Sami Mujawar
On 11/11/2021, 00:23, "Min Xu" wrote:
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3625
If Confidential Computing (Cc) firmware supports measurement and an
event
Hi Rebecca,
Thank you for the updated patch. These changes look good to me.
The INF file mentions support for IA32 and X64 so it would be got to get
feedback for other architectures and from the MdeModulePkg maintainers.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 05/11/2021 08:31
Bugzilla: 3668 (https://bugzilla.tianocore.org/show_bug.cgi?id=3668)
RawAlgorithm is used to provide access to entropy that is suitable
for cryptographic applications. Therefore, add RawAlgorithm support
that provides access to entropy using the TRNG library interface.
Signed-off-by: Sami
to satisfy
the build dependency.
Therefore, add a NULL instance of the TRNG library.
Signed-off-by: Sami Mujawar
---
Notes:
v2:
- MdePkg\Include\Library\TrngLib.h is base type [LIMING]
library. It can use RETURN_STATUS instead of
EFI_STATUS.
- Replaced EFI_STATUS
an be seen at:
https://github.com/samimujawar/edk2/tree/1829_arm_fw_trng_v2
Sami Mujawar (8):
MdePkg: Definition for TRNG library class interface
ArmPkg: PCD to select conduit for monitor calls
ArmPkg: Add Arm Firmware TRNG library
MdePkg: Add NULL instance of TRNG Library
SecurityP
.
Signed-off-by: Sami Mujawar
---
Notes:
v2:
- MdePkg\Include\Library\TrngLib.h is base type [LIMING]
library. It can use RETURN_STATUS instead of
EFI_STATUS.
- Replaced EFI_STATUS with RETURN_STATUS. [SAMI]
- MdePkg\Include\Library\TrngLib.h API
/architectures may provide access to the entropy
using a firmware interface. In such cases the TRNG library
shall be used to provide an abstraction.
Signed-off-by: Sami Mujawar
---
Notes:
v2:
- MdePkg\Include\Library\TrngLib.h is base type [LIMING]
library. It can use RETURN_STATUS instead
Bugzilla: 3668 (https://bugzilla.tianocore.org/show_bug.cgi?id=3668)
Rename RdRandGenerateEntropy() to GenerateEntropy() to provide a
common interface to generate entropy on other architectures.
Also move the definition to RngDxeInternals.h
Signed-off-by: Sami Mujawar
---
Notes:
v2
selection of HVC conduit to be used
by virtual firmware implementations.
Signed-off-by: Sami Mujawar
---
Notes:
v2:
- No code change since v1. Re-sending with V2 series. [SAMI]
ArmPkg/ArmPkg.dec | 5 +
1 file changed, 5 insertions(+)
diff --git a/ArmPkg/ArmPkg.dec b/ArmPkg/ArmPkg.dec
firmware.
Signed-off-by: Sami Mujawar
---
Notes:
v2:
- No code change since v1. Re-sending with V2 series. [SAMI]
ArmVirtPkg/ArmVirtKvmTool.dsc | 10 ++
ArmVirtPkg/ArmVirtKvmTool.fdf | 5 +
2 files changed, 15 insertions(+)
diff --git a/ArmVirtPkg/ArmVirtKvmTool.dsc b
and RNGAlgorithmList as NULL.
Signed-off-by: Sami Mujawar
---
Notes:
v2:
- No code change since v1. Re-sending with V2 series. [SAMI]
SecurityPkg/RandomNumberGenerator/RngDxe/Rand/RngDxe.c | 6 ++
SecurityPkg/RandomNumberGenerator/RngDxe/RngDxe.c | 11
Hi Mike,
Thank you for this patch.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 23/11/2021 09:21 PM, Michael D Kinney via groups.io wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3749
Update package YAML files to ignore ECC errors that are
already present. These issues
Hi Mike,
Thank you for this patch.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 23/11/2021 09:21 PM, Michael D Kinney via groups.io wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3749
Update package YAML files to ignore ECC errors that are
already present. These issues
Hi Mike,
Thank you for this patch.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 23/11/2021 09:21 PM, Michael D Kinney wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3749
Update package YAML files to ignore ECC errors that are
already present. These issues must be fixed
ding it.
I am trying to undestand how the ExceptionList works. Would Keyword =
HobConstructor ignore the other errors too?
We will look into getting these issues fixed. However, to unblock this
patch can proceed.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Gr
Hi Leif,
Thank you for the feedback.
Please find my response inline marked [SAMI].
Regards,
Sami Mujawar
On 24/11/2021 01:01 PM, Leif Lindholm wrote:
Hi Sami,
On Tue, Nov 16, 2021 at 11:32:55 +, Sami Mujawar wrote:
Bugzilla: 3668 (https://bugzilla.tianocore.org/show_bug.cgi?id=3668
Hi Abdul,
Thank you for this patch series.
This series looks good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 22/11/2021 10:21 AM, Abdul Lateef Attar wrote:
Hi Sami, Zhichao,
Addressed all review comments.
Created two different patches, one for bitfield parser
Hi Abdul,
Thank you for implementing the suggestion.
Pleas find my feedback inline marked [SAMI].
Regards,
Sami Mujawar
On 17/11/2021 12:29 PM, Abdul Lateef Attar wrote:
Adds PrintFormatter function to the FADT flags field.
Prints indivisual flag name along with flag value.
Adds new parser
Hi Min,
Thank you for this patch.
Please find my feedback inline marked [SAMI].
Regards,
Sami Mujawar
On 02/11/2021 02:50 AM, Min Xu wrote:
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3625
DxeTpm2MeasureBootLib supports TPM2 based measure boot. After
CcMeasurementProtocol
Hi Min,
Thank you for this patch.
Please find my feedback inline marked [SAMI].
Regards,
Sami Mujawar
On 02/11/2021 02:50 AM, Min Xu wrote:
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3625
DxeTpmMeasurementLib supports TPM based measurement in DXE phase.
After CcMeasurementProtocol
Hi Min,
Thank you for this patch.
These changes look good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 02/11/2021 02:50 AM, Min Xu wrote:
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3625
CC guest is a Confidential Computing guest. If CC Guest firmware
supports
Hi Rebecca,
Thank you for this patch.
This patch looks good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 18/10/2021 04:39 PM, Rebecca Cran wrote:
Remove the ClusterId and CoreId fields in the ARM_CORE_INFO structure in
favor of a new Mpidr field. Update code in
ArmPlatformPkg
Hi Pierre,
Thank you for this patch.
Please find my feedback inline marked [SAMI].
Regards,
Sami Mujawar
On 23/06/2021 01:38 PM, pierre.gond...@arm.com wrote:
From: Pierre Gondois
FdtHwInfoParserLib is an instance of the HwInfoParser. The
FdtHwInfoParser parses a platform Device Tree
701 - 800 of 1668 matches
Mail list logo
