Hi Khasim,
Thank you for the updated patch series.
These changes look good to me.
For this series,
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 22/01/2022 03:26 PM, Khasim Syed Mohammed wrote:
The patch series removes PciExpressLib and enables CCIX port
as PCIe root on N1SDP.
V6
Pushed as 8eb3b2f8be26..805059812997
Thanks.
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#86016): https://edk2.groups.io/g/devel/message/86016
Mute This Topic: https://groups.io/mt/87284484/21656
Group Owner
Hi Khasim,
Thank you for splitting the patches.
For this series,
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
From: Khasim Mohammed
Date: Monday, 24 January 2022 at 15:56
To: devel@edk2.groups.io
Cc: nd , Sami Mujawar , Pierre Gondois
, Khasim Mohammed
Subject: [PATCH v7 0/6] Enable
Merged as 805059812997..239181acdd45
Regards,
Sami Mujawar
From: devel@edk2.groups.io on behalf of Sami Mujawar via
groups.io
Date: Monday, 24 January 2022 at 18:16
To: Khasim Mohammed , devel@edk2.groups.io
Cc: nd , Pierre Gondois , Khasim Mohammed
Subject: Re: [edk2-devel] [PATCH v7 0
Hi Ming,
I am not sure if this is an issue at my end, but I cannot apply this patch
series, can you check, please?
Also, is it possible to share these patches on a Github branch.
Regards,
Sami Mujawar
On 30/03/2022, 10:37, "Ming Huang" wrote:
Hi,
Any comment about t
Hi Jeshua,
Apologies, I was busy with some other tasks. I will pick this up in this week.
Regards,
Sami Mujawar
From: Jeshua Smith
Date: Monday, 11 September 2023 at 17:58
To: Sami Mujawar , "devel@edk2.groups.io"
Subject: RE: [edk2-devel] [PATCH v1 05/11] DynamicTablesPkg: U
Hi Michael,
I would prefer to have the debug macro checks enabled in DynamicTablesPkg to
catch any issues.
Please do not disable this feature for this package.
Regards,
Sami Mujawar
On 13/09/2023, 18:08, "mikub...@linux.microsoft.com
<mailto:mikub...@linux.microsoft.com>&qu
ot;
EArmObjEtInfo (OPTIONAL)").
[SAMI] I think I will fix this before I merge the series.
Regards,
Sami Mujawar
-Original Message-
From: Sami Mujawar mailto:sami.muja...@arm.com>>
Sent: Wednesday, September 13, 2023 6:50 AM
To: devel@edk2.groups.io <mailto:devel@edk2.
Hi Michael,
Apologies, I initially misunderstood what this patch was trying to do.
As I understand this is an exception for one of the special cases to be handled
differently by the plugin.
Acked-by: Sami Mujawar
Regards,
Sami Mujawar
On 14/09/2023, 09:42, "devel@edk2.grou
depends on the edk2 patch series
at: https://edk2.groups.io/g/devel/message/108591
Updates from v1 patch series:
- Fixed comment in patch 2/3 to specify the TRBE
interrupt as PPI 15.
The changes can be seen at:
https://github.com/samimujawar/edk2-platforms/tree/2620_ete_dev_fvp_v2
Sami
Add support to dynamically generate the CPU nodes in SSDT.
Signed-off-by: Sami Mujawar
---
Notes:
v2:
- No code change from v1 patch series. [SAMI]
Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/AslTables/Dsdt.asl
| 38 +---
Platform
-C cluster1.has_trbe=1
3. Set the ETE plugin for the model
--plugin \libete-plugin.[so|dll]
Signed-off-by: Sami Mujawar
---
Notes:
v2:
- No code change from v1 patch series. [SAMI]
Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe
TRBE
-C cluster0.has_trbe=1 -C cluster1.has_trbe=1
Signed-off-by: Sami Mujawar
---
Notes:
V2:
- Incorrect comment for TRBE interrupt number [Jeshua]
- Fixed comment to specify TRBE interrupt as[Sami]
PPI 15
Ref: https://edk2.groups.io/g/devel/message/107426
require the MADT table revision to be setup to
6 to reflect the ACPI 6.5 specification.
The TRBE field needs to be appropriately setup in the
GICC structure.
Therefore, update the MADT generator to reflect the
above updates required for supporting ACPI 6.5
Signed-off-by: Sami Mujawar
---
Notes
does not describe any memory mapped
registers. However, support for ETM can be
added in the future.
Signed-off-by: Sami Mujawar
---
Notes:
v2:
- No code change from v1 patch series. [SAMI]
DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpuTopologyGenerator.c
| 186
to reflect the addition
of the TRBE interrupt field.
Signed-off-by: Sami Mujawar
---
Notes:
v2:
- No code change from v1 patch series. [SAMI]
DynamicTablesPkg/Include/ArmNameSpaceObjects.h | 7 +++
1 file changed, 7 insertions(+)
diff --git a/DynamicTablesPkg/Include
to the CM_ARM_GICC_INFO
structure in a previous patch.
Therefore, update the Configuration Manager Object Parser to
reflect the addition of the TRBE interrupt field.
Signed-off-by: Sami Mujawar
---
Notes:
v2:
- No code change from v1 patch series. [SAMI]
DynamicTablesPkg/Library/Common
The ACPI 6.5 specification updates the minor revision
of the FADT table to 5. Therefore, update the FADT
generator to setup the minor revision for ACPI 6.5.
Signed-off-by: Sami Mujawar
---
Notes:
v2:
- No code change from v1 patch series. [SAMI]
DynamicTablesPkg/Library/Acpi/Arm
Object parser to add support
for parsing the CM_ARM_ET_INFO object.
Signed-off-by: Sami Mujawar
---
Notes:
v2:
- No code change from v1 patch series. [SAMI]
DynamicTablesPkg/Library/Common/TableHelperLib/ConfigurationManagerObjectParser.c
| 8
1 file changed, 8 insertions
as
specified in ACPI 6.5.
Signed-off-by: Sami Mujawar
---
Notes:
v2:
- No code change from v1 patch series. [SAMI]
MdePkg/Include/IndustryStandard/Acpi65.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/MdePkg/Include/IndustryStandard/Acpi65.h
b/MdePkg/Include
registers.
Since this patch aims to support ETE it does
not describe any memory mapped registers.
However, required support for ETM can be added
in the future.
Signed-off-by: Sami Mujawar
---
Notes:
v2:
- No code change from v1 patch series. [SAMI]
DynamicTablesPkg/Include
The ASWG ECR 2303 introduces a new field 'TRBE
interrupt' to GICC structure in ACPI 6.5.
The Trace Buffer Extension (TRBE) interrupt is a
Processor Private interrupt (PPI) and is used to
specify a platform-specific interrupt to signal
TRBE events.
Signed-off-by: Sami Mujawar
---
Notes:
v2
The CpcToken has been incorrectly referenced in the
CreateTopologyFromGicC() and always points to the
CPC token in the first GICC Info object.
Therefore, fix this by correctly indexing into the
GicCInfo object array.
Signed-off-by: Sami Mujawar
---
Notes:
v2:
- No code change from v1
interrupt field. Also, add
validations to check that the TRBE interrupt is
within the PPI interrupt range.
Signed-off-by: Sami Mujawar
---
Notes:
v2:
- No code change from v1 patch series. [SAMI]
ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Madt/MadtParser.c | 48
n patch 5/11.
The changes can be seen at:
https://github.com/samimujawar/edk2/tree/2620_ete_dev_fvp_v2
Sami Mujawar (11):
MdePkg: MADT: Add Online capable flag in GICC
MdePkg: MADT: Add TRBE interrupt to GICC
DynamicTablesPkg: Add TRBE interrupt to GICC object
DynamicTablesPkg: Add TRBE inter
of this week, I plan to merge this
series along with https://edk2.groups.io/g/devel/topic/99863881#106547
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108258): https://edk2.groups.io/g/devel/message/108258
Mute
re,
update the GICC info object parser to add an entry to parse
the ET reference token. Without this change an assert
stating that the RemainingSize != 0 will be triggered.
Signed-off-by: Sami Mujawar
---
DynamicTablesPkg/Library/Common/TableHelperLib/ConfigurationManagerObjectParser.c
| 3 +
Merged as 4f3ee7fbafc8..a671a14e63fd
Thanks.
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#110318): https://edk2.groups.io/g/devel/message/110318
Mute This Topic: https://groups.io/mt/101522262/21656
Group Owner
Merged as dc8de7cc888f..1ae7cffab740
Thanks.
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#110319): https://edk2.groups.io/g/devel/message/110319
Mute This Topic: https://groups.io/mt/101522378/21656
Group Owner
Hi Jeff,
Thank you for this patch.
Please see my response inline marked [SAMI].
Regards,
Sami Mujawar
On 18/09/2023 04:46 pm, Jeff Brasen wrote:
Add support to add Return objects via AML that pass a single integer
argument to the named method.
Signed-off-by: Jeff Brasen
Hi Jeff,
Thank you for this patch.
Please see my response inline marked [SAMI].
Regards,
Sami Mujawar
On 18/09/2023 04:46 pm, Jeff Brasen wrote:
Add API to add a String to a package created with NamedPackage API.
Signed-off-by: Jeff Brasen
---
.../Include/Library/AmlLib/AmlLib.h
Hi Leif,
Thank you for this patch.
These changes look good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 20/09/2023, 13:39, "Leif Lindholm" mailto:quic_llind...@quicinc.com>> wrote:
Create a helper function to query whether ID_AA64MFR1_EL1 in
Hi Pierre,
Thank you for the review feedback.
Please see my response inline marked [SAMI].
Regards,
Sami Mujawar
On 22/09/2023, 09:53, "Pierre Gondois" mailto:pierre.gond...@arm.com>> wrote:
Hi Sami,
On 9/13/23 14:49, Sami Mujawar wrote:
> The ACPI 6.5 specificati
Hi Pierre,
Thank you for the feedback.
Please see my response inline marked [SAMI].
Regards,
Sami Mujawar
On 22/09/2023, 09:56, "Pierre Gondois" mailto:pierre.gond...@arm.com>> wrote:
Hi Sami,
On 9/13/23 14:52, Sami Mujawar wrote:
> When TRBE is enabled the FVP mo
Hi Tuan,
Thank you for this patch.
Please see my response inline marked [SAMI].
Regards,
Sami Mujawar
On 15/09/2023 12:10 am, Tuan Phan wrote:
Update entry point library for Arm to use the new platform independent
[SAMI] Should this be worded as architecture independent instead
Hi Tuan,
Thank you for this patch.
This change looks good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 15/09/2023 12:10 am, Tuan Phan wrote:
StandaloneMmCpu now can supports more platforms like RISC-V besides
ARM/AARCH64.
Signed-off-by: Tuan Phan
---
.../Drivers
Hi Leif,
Thank you for this patch.
There is a minor typo in the commit message, other than that these
changes look good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 26/09/2023 06:15 pm, Leif Lindholm wrote:
The ARM implementation of of InternalLongJump always returned
Hi Leif,
Thank you for this patch.
These changes look good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 26/09/2023 06:15 pm, Leif Lindholm wrote:
Both in SetJump and in InternalLongJump, 32-bit w register views were
used for the UINTN return value. In SetJump, this did
Reviewed-by: Sami Mujawar
Thanks.
Regards,
Sami Mujawar
On 27/09/2023 12:06 pm, Leif Lindholm wrote:
We added Sami as a reviewer to ArmPkg early last year, and I think it was
always our intention to have him as a reviewer of Arm architectural stuff
in general, but we seem to have missed out
Hi Pierre,
Thank you for this fix.
Unfortunately, this did not get trapped by the edk2 CI as well.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 29/09/2023, 13:30, "pierre.gond...@arm.com <mailto:pierre.gond...@arm.com>"
mailto:pierre.gond...@arm.com>> wrote:
Hi Leif,
Thank you for this patch.
This patch looks good to me.
Just a question, should we also do the same for the AArch32 builds?
In either case,
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 26/09/2023 06:15 pm, Leif Lindholm wrote:
The SetJump comment header states
Hi Leif,
Thank you for this patch.
These changes look good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 26/09/2023 06:15 pm, Leif Lindholm wrote:
Drop redundant comment about IPF (clearly copied across from now deleted
code).
Also change
"Instead is resumes exec
Hi Leif,
Thank you for this patch.
These changes look good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 26/09/2023 06:15 pm, Leif Lindholm wrote:
There may be architectures on which there are benefits to
eor r0, r0(, r0)
but ARM was never one of them. Change to more
Hi Leif,
Thank you for this fix.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 03/10/2023, 11:39, "Leif Lindholm" mailto:quic_llind...@quicinc.com>> wrote:
RO -> R0
Signed-off-by: Leif Lindholm mailto:quic_llind...@quicinc.com>>
Reported-by: Philippe
Hi Jeff,
Thank out for this patch series.
These changes look good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 21/09/2023 09:10 pm, Jeff Brasen wrote:
Use AmlCodeGenRdQWordIo() to generate the I/O range in _CRS instead of
AmlCodeGenRdDWordIo() to cater to the scenarios where
The ASWG ECR 2303 introduces a new field 'TRBE
interrupt' to GICC structure in ACPI 6.5.
The Trace Buffer Extension (TRBE) interrupt is a
Processor Private interrupt (PPI) and is used to
specify a platform-specific interrupt to signal
TRBE events.
Signed-off-by: Sami Mujawar
Reviewed-by: Pierre
interrupt field. Also, add
validations to check that the TRBE interrupt is
within the PPI interrupt range.
Signed-off-by: Sami Mujawar
Reviewed-by: Zhichao Gao
Reviewed-by: Pierre Gondois
---
Notes:
v3:
- No code change from v2 patch series. [SAMI]
- Added rb tag from Zhichao
on in ArmLib to
detect if ETE is supported.
Updates from v1 patch series:
- Fixed issue with setting TRBE interrupt in patch 5/11.
The changes can be seen at:
https://github.com/samimujawar/edk2/tree/2620_ete_dev_fvp_v3
Sami Mujawar (13):
MdePkg: MADT: Add Online capable flag in GICC
MdePk
Object parser to add support
for parsing the CM_ARM_ET_INFO object.
Signed-off-by: Sami Mujawar
Reviewed-by: Pierre Gondois
---
Notes:
v3:
- No code change from v2 patch series. [SAMI]
v2:
- No code change from v1 patch series. [SAMI]
DynamicTablesPkg/Library
The CpcToken has been incorrectly referenced in the
CreateTopologyFromGicC() and always points to the
CPC token in the first GICC Info object.
Therefore, fix this by correctly indexing into the
GicCInfo object array.
Signed-off-by: Sami Mujawar
Reviewed-by: Pierre Gondois
---
Notes:
v3
registers.
Since this patch aims to support ETE it does
not describe any memory mapped registers.
However, required support for ETM can be added
in the future.
Signed-off-by: Sami Mujawar
Reviewed-by: Pierre Gondois
---
Notes:
v3:
- No code change from v2 patch series. [SAMI
The ACPI 6.5 specification updates the minor revision
of the FADT table to 5. Therefore, update the FADT
generator to setup the minor revision for ACPI 6.5.
Signed-off-by: Sami Mujawar
Reviewed-by: Pierre Gondois
---
Notes:
v3:
- No code change from v2 patch series. [SAMI
require the MADT table revision to be setup to
6 to reflect the ACPI 6.5 specification.
The TRBE field needs to be appropriately setup in the
GICC structure.
Therefore, update the MADT generator to reflect the
above updates required for supporting ACPI 6.5
Signed-off-by: Sami Mujawar
---
Notes
as
specified in ACPI 6.5.
Signed-off-by: Sami Mujawar
Reviewed-by: Pierre Gondois
---
Notes:
v3:
- No code change from v2 patch series. [SAMI]
v2:
- No code change from v1 patch series. [SAMI]
MdePkg/Include/IndustryStandard/Acpi65.h | 3 ++-
1 file changed, 2
to reflect the addition
of the TRBE interrupt field.
Signed-off-by: Sami Mujawar
Reviewed-by: Pierre Gondois
---
Notes:
v3:
- No code change from v2 patch series. [SAMI]
v2:
- No code change from v1 patch series. [SAMI]
DynamicTablesPkg/Include/ArmNameSpaceObjects.h
does not describe any memory mapped
registers. However, support for ETM can be
added in the future.
Signed-off-by: Sami Mujawar
Reviewed-by: Pierre Gondois
---
Notes:
v3:
- No code change from v2 patch series. [SAMI]
v2:
- No code change from v1 patch series. [SAMI
to the CM_ARM_GICC_INFO
structure in a previous patch.
Therefore, update the Configuration Manager Object Parser to
reflect the addition of the TRBE interrupt field.
Signed-off-by: Sami Mujawar
Reviewed-by: Pierre Gondois
---
Notes:
v3:
- No code change from v2 patch series. [SAMI]
v2
Create a helper function to query whether ID_AA64MFR1_EL1 indicates
presence of the Embedded Trace Extension (ETE). This feature is only
visible in AARCH64 state.
Signed-off-by: Sami Mujawar
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Cc: Pierre Gondois
---
Notes:
v3:
- New patch
Create a helper function to query whether ID_AA64MFR1_EL1 indicates
presence of the Trace Buffer Extension (TRBE). This feature is only
visible in AARCH64 state.
Signed-off-by: Sami Mujawar
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Cc: Pierre Gondois
---
Notes:
v3:
- New patch
and 13/13 in the edk2
patch series linked above) and using them instead.
Updates from v1 patch series:
- Fixed comment in patch 2/3 to specify the TRBE
interrupt as PPI 15.
The changes can be seen at:
https://github.com/samimujawar/edk2-platforms/tree/2620_ete_dev_fvp_v3
Sami Mujawar (3
Add support to dynamically generate the CPU nodes in SSDT.
Signed-off-by: Sami Mujawar
---
Notes:
v3:
- No code change from v2 patch series. [SAMI]
v2:
- No code change from v1 patch series. [SAMI]
Platform/ARM/VExpressPkg/ConfigurationManager
TRBE
-C cluster0.has_trbe=1 -C cluster1.has_trbe=1
Signed-off-by: Sami Mujawar
---
Notes:
v3:
- Use macros instead of magic numbers in TRBE feature [Pierre]
detection code.
- Implemented helper functions in ArmLib to detect if [Sami]
the TRBE feature is present
-C cluster1.has_trbe=1
3. Set the ETE plugin for the model
--plugin \libete-plugin.[so|dll]
Signed-off-by: Sami Mujawar
---
Notes:
v3:
- Use macros instead of magic numbers in ETE feature [Pierre]
detection code.
- Implemented helper functions in ArmLib
for the patch series (even if some
patches get merged) in future, please? It helps keep track of the review
history.
Other than that this patch looks good to me and I will queue this for
merging.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 22/09/2023 10:40 pm, Swatisri Kantamsetti wrote
Hi Leif,
Please find my response inline marked [SAMI].
Regards,
Sami Mujawar
On 25/09/2023 10:40 am, Leif Lindholm wrote:
On Fri, Sep 22, 2023 at 15:40:38 -0600, Swatisri Kantamsetti via groups.io
wrote:
The IO Remapping Table, Platform Design Document, Revision E.e,
Sept 2022 (https
Hi Tuan,
Thank you for this patch.
These changes look good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 28/09/2023 10:14 pm, Tuan Phan wrote:
Update entry point library for Arm to use the new architecture independent
StandaloneMmCpu driver.
Signed-off-by: Tuan Phan
Reviewed
Hi Laszlo,
Thank you for this patch.
These changes look good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 12/10/2023, 10:27, "devel@edk2.groups.io <mailto:devel@edk2.groups.io> on
behalf of Laszlo Ersek via groups.io" mailto:devel@edk2.groups.io> on beha
Hi Laszlo,
Thank you for this patch.
These changes look good to me.
Reviewed-by: Sami Mujawar
Tested by booting a Linux guest using Kvmtool guest firmware
(ArmVirtPkg/ArmVirtKvmTool.dsc) for AArch64.
Tested-by: Sami Mujawar
Regards,
Sami Mujawar
On 12/10/2023, 10:25, "devel
Adding Tuan.
Regards,
Sami Mujawar
On 12/10/2023, 18:12, "levi.yun" mailto:yeoreum@arm.com>> wrote:
The patch "[PATCH v3 1/2] StandaloneMmPkg: Make StandaloneMmCpu driver
architecture independent" (https://edk2.groups.io/g/devel/message/109178
<https://e
Hi Laszlo,
Please see my response inline marked [SAMI].
Regards,
Sami Mujawar
On 18/10/2023, 14:42, "Laszlo Ersek" mailto:ler...@redhat.com>> wrote:
Hi Sami,
On 10/12/23 14:33, Sami Mujawar wrote:
> Hi Laszlo,
>
> Thank you for this patch.
> These changes lo
Dear Basetool Maintainers,
Is it possible to provide feedback for this patch, please?
This patch fixes an issue that is blocking the patch series at
https://edk2.groups.io/g/devel/message/109178 from being merged.
Regards,
Sami Mujawar
On 13/10/2023, 08:36, "Sami Mujawar" mailto
Hi Jeshua,
Thank you for these fixes.
For this series,
Reviewed-by: Sami Mujawar
I have now queued this up for merging.
Regards,
Sami Mujawar
On 06/10/2023 05:28 pm, Jeshua Smith wrote:
While using the ConfigurationManagerObjectParser to dump objects and debug
adding new objects, I
Merged as c591395f4ab5..ec7f73436646
Thanks.
Regards,
Sami Mujawar
On 23/10/2023 05:55 pm, Sami Mujawar via groups.io wrote:
Hi Jeshua,
Thank you for these fixes.
For this series,
Reviewed-by: Sami Mujawar
I have now queued this up for merging.
Regards,
Sami Mujawar
On 06/10/2023 05
Hi Jeshua,
Thank you for this patch.
These changes look good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 05/10/2023 05:38 pm, Jeshua Smith wrote:
AmlCodeGenRdQWordMemory's and AmlCodeGenRdDWordMemory's Cacheable
and MemoryRangeType parameters treat specific values as having
Dear MdePkg Maintainers,
Can I have your review feedback for the first 2 patches in this series,
please?
- MdePkg: MADT: Add Online capable flag in GICC
- MdePkg: MADT: Add TRBE interrupt to GICC
I plan to merge this series by end of this week.
Regards,
Sami Mujawar
On 23/10/2023 04:30 pm
Hi Jose,
Thank you for this patch.
There was a minor numbering change that I have done before pushing the patch
for merging.
Otherwise this patch looks good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent
I had to add an entry to satisfy the CI spell checker.
With that,
Merged as ec7f73436646..309450db268c
Regards,
Sami Mujawar
On 23/10/2023 06:12 pm, Sami Mujawar via groups.io wrote:
Hi Jeshua,
Thank you for this patch.
These changes look good to me.
Reviewed-by: Sami Mujawar
Regards
Hi Rohit,
Thank you for this patch.
Please find my feedback inline marked [SAMI].
Regards,
Sami Mujawar
On 18/08/2023 12:48 pm, Rohit Mathew wrote:
Add a parser for the MPAM (Memory system resource partitioning and
monitoring) ACPI table. This parser would parse all MPAM related
structures
Hi Rohit,
Thank you for this patch.
These changes look good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 18/08/2023 12:47 pm, Rohit Mathew wrote:
Certain ACPI tables like MPAM has fields which are 16 bytes long.
Routines similar to Dump12Chars but for 16 characters
Hi Rohit,
Thank you for this pach.
These changes look good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 18/08/2023 12:44 pm, Rohit Mathew wrote:
From: Rohit Mathew
Add definitions, macros and types for elements associated with MPAM
ACPI 2.0 specification.
Signed-off
Hi Michael,
Thank you for this patch.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 26/04/2022 03:18 am, mikub...@linux.microsoft.com wrote:
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479
Adds an instance for the library class VariableFlashInfoLib
Hi Michael,
Thank you for this patch.
These changes look good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 12/04/2022 05:29 pm, Michael Kubacki via groups.io wrote:
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479
Adds a new GUID that is used
Hi Michael,
I have a minor suggestion marked inline as [SAMI].
Otherwise this patch looks good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 12/04/2022 05:29 pm, Michael Kubacki via groups.io wrote:
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id
Hi Michael,
Thank you for this patch.
These changes look good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 12/04/2022 05:29 pm, Michael Kubacki via groups.io wrote:
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479
Adds support to the UEFI
Hi Michael,
Thank you for this patch.
These changes look good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 12/04/2022 05:29 pm, Michael Kubacki via groups.io wrote:
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479
Updates VariableRuntimeDxe
Hi Michael,
Thank you for this patch.
These changes look good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 12/04/2022 05:29 pm, mikub...@linux.microsoft.com wrote:
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479
Adds an instance
Hi Michael,
Thank you for this patch.
These changes look good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 20/04/2022 09:44 pm, mikub...@linux.microsoft.com wrote:
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479
Adds an instance
Hi Michael,
There are other platforms in edk2-platforms that would possibly require
similar changes.
e.g. Platform\ARM\VExpressPkg\ArmVExpress-FVP-AArch64.dsc,
Platform\ARM\JunoPkg\ArmJuno.dsc, etc.
Do you plan to submit patches to update these platforms as well?
Regards,
Sami Mujawar
Hi Michael,
Thank you for fixing these issues.
I have a minor suggestion marked inline as [SAMI]. Otherwise, this patch looks
good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 17/05/2022, 17:01, "mikub...@linux.microsoft.com"
wrote:
From: Micha
Hi Michael,
Thank you for this patch. These changes look good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 17/05/2022, 17:01, "mikub...@linux.microsoft.com"
wrote:
From: Michael Kubacki
The SpellCheck plugin began reporting new typos that were previously
Hi Rebecca,
Thank you for this patch.
These changes look good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#89774): https://edk2.groups.io/g/devel/message/89774
Mute This Topic
Hi Min,
Thank you for this patch.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#89775): https://edk2.groups.io/g/devel/message/89775
Mute This Topic: https://groups.io/mt/91135111
Hi Min,
This patch looks good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#89776): https://edk2.groups.io/g/devel/message/89776
Mute This Topic: https://groups.io/mt/91135116
Fixed issues reported by CI and merged as f193b945eac5..5496c763aadd
Thanks,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#91139): https://edk2.groups.io/g/devel/message/91139
Mute This Topic: https://groups.io/mt
Hi Liming,
Thank you for your feedback. Please find my response inline marked [SAMI].
Regards,
Sami Mujawar
On 07/07/2022 02:51 am, gaoliming wrote:
Sami:
I suggest to keep EFI_ACPI_IO_REMAPPING_TABLE_REVISION. Its value can
be EFI_ACPI_IO_REMAPPING_TABLE_REV5, because the structure has
Hi Jon,
Thank you for your feedback. Please see my response inline marked [SAMI].
Regards,
Sami Mujawar
On 07/07/2022 07:05 am, Jon Nettleton wrote:
On Wed, Jul 6, 2022 at 11:57 AM Sami Mujawar wrote:
Bugzilla: 3458 - Add support IORT Rev E.d specification updates
(https
The IORT generator is populating the reference field for Context and
PMU interrupts even if their count is zero.
Update the IORT generator to set the references only if the interrupt
count is not 0. Also add checks to ensure a valid reference token has
been provided.
Signed-off-by: Sami Mujawar
that Git Bisect can work.
Signed-off-by: Sami Mujawar
---
Notes:
v5:
- Change IORT revision macro name to make it similar to [THOMAS]
macro names for other ACPI tables.
- Updated IORT revision macros from [SAMI
Mapping count is zero rather than populating it with an incorrect
value.
Signed-off-by: Sami Mujawar
Reviewed-by: Pierre Gondois
---
Notes:
v5:
- No code change since v1. Re-sending with v5 series.[SAMI]
v4:
- No code change since v1. Re-sending with v4 series.[SAMI
at:
https://github.com/samimujawar/edk2/tree/1527_iort_rev_ed_v5
Sami Mujawar (8):
ShellPkg: Acpiview: Abbreviate field names to preserve alignment
DynamicTablesPkg: Handle error when IdMappingToken is NULL
DynamicTablesPkg: IORT set reference to Id array only if present
DynamicTablesPkg: IORT set
901 - 1000 of 1668 matches
Mail list logo
