[edk2-devel] Build error in CryptoPkg on FreeBSD

2019-06-04 Thread rebecca
rypto/rand/rand_unix.obj] Error 1 -- Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#41905): https://edk2.groups.io/g/devel/message/41905 Mute This Topic: https://groups.io/mt/31933146/21656 Group Owner: devel+ow...@edk2

Re: [edk2-devel] Adding HTTP and TLS support to Armada80x0McBin (from the MarvellEmbeddedProcessors edk2-open-platforms repo)

2019-05-28 Thread rebecca
Thank you! That makes things a whole lot easier. -- Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#41546): https://edk2.groups.io/g/devel/message/41546 Mute This Topic: https://groups.io/mt/31815275/21656 Group Own

Re: [edk2-devel] Adding HTTP and TLS support to Armada80x0McBin (from the MarvellEmbeddedProcessors edk2-open-platforms repo)

2019-05-28 Thread rebecca
le coming back to it might need a bit of a reminder! -- Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#41563): https://edk2.groups.io/g/devel/message/41563 Mute This Topic: https://groups.io/mt/31815275/21656 Group Owner: devel+ow

Re: [edk2-devel] Adding HTTP and TLS support to Armada80x0McBin (from the MarvellEmbeddedProcessors edk2-open-platforms repo)

2019-05-28 Thread rebecca
ada80x0McBin/Armada80x0McBin.dsc(...): error 4000: Instance of library class [TlsLib] is not found     in [/home/bcran/workspace/edk2/NetworkPkg/TlsDxe/TlsDxe.inf] [AARCH64]     consumed by module [/home/bcran/workspace/edk2/NetworkPkg/TlsDxe/TlsDxe.inf] -- Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=- Groups.i

Re: [edk2-devel] Upcoming Event: TianoCore Bug Triage - APAC / NAMO - Thu, 05/30/2019 5:00pm-5:30pm #cal-reminder

2019-05-30 Thread rebecca
And "Please wait for the host to start this meeting" in the Zoom app. Is this the correct link? -- Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#41694): https://edk2.groups.io/g/devel/message/41694

[edk2-devel] Fetching files over HTTPS causes crash on second connection due to corruption of SetSessionData pointer

2019-06-14 Thread rebecca
the following Bugzilla to track progress on debugging/fixing it: https://bugzilla.tianocore.org/show_bug.cgi?id=1917 -- Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#42449): https://edk2.groups.io/g/devel/message/42449

[edk2-devel] edk2-docs hosted on legacy gitbook site - is migration to new version planned?

2019-06-11 Thread rebecca
I noticed the edk2-docs are hosted on the *legacy* gitbook.com site, at https://legacy.gitbook.com/@edk2-docs . Are there any plans to migrate to the new version (https://docs.gitbook.com/getting-started/migrating-from-the-previous-version)? -- Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=- Groups.io

Re: [edk2-devel] [edk2-announce] TianoCore Community Meeting Minutes

2019-06-11 Thread rebecca
[replying to devel@] On 2019-06-10 12:47, Stephano Cetola wrote: > > Documentation > ----- > Rebecca is hosting the Doxygen docs from packages on her server, and > it is probably better if we use a cloud service to host these, or > better yet, our current gitboo

Re: [edk2-devel] [PATCH V2] BaseTools/GenBiosId: Add a new tool GenBiosId

2019-06-17 Thread rebecca
On 2019-06-17 04:54, Fan, ZhijuX wrote: > GenBiosId is a tool to generate the BIOS ID binary file which uses > the data from the configuration file. > https://bugzilla.tianocore.org/show_bug.cgi?id=1846 pylama (https://github.com/klen/pylama) reports the following issues:

Re: [edk2-devel] [PATCH V2] BaseTools/GenBiosId: Add a new tool GenBiosId

2019-06-17 Thread rebecca
e format: need a config section" -- Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#42515): https://edk2.groups.io/g/devel/message/42515 Mute This Topic: https://groups.io/mt/32093449/21656 Group Owner: devel+ow...@edk2.groups.io U

Re: [edk2-devel] Problems using HTTPS boot: Http->Request can't find TLS Service Binding Protocol

2019-06-18 Thread rebecca
l. So it seems the breakage is limited to running OVMF built on FreeBSD, which I'll work on myself to fix. -- Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#42552): https://edk2.groups.io/g/devel/message/42552 Mute This

Re: [edk2-devel] Problems using HTTPS boot: Http->Request can't find TLS Service Binding Protocol

2019-06-18 Thread rebecca
Linux the NOOPT build also doesn't work, while RELEASE does. And on FreeBSD the RELEASE and DEBUG builds work, but just NOOPT doesn't. Could you check if the NOOPT OVMF build works with HTTPS on your system, please? -- Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive

Re: [edk2-devel] [PATCH V2] BaseTools/GenBiosId: Add a new tool GenBiosId

2019-06-18 Thread rebecca
On 2019-06-18 07:26, Liming Gao wrote: > Rebecca: > Thanks for your report. Now, pylama is not the requirement for BaseTools > python script. Patch contributor can base on the report to fix the critical > issue. I know it's not a required tool, but many of these are common

[edk2-devel] Problems using HTTPS boot: Http->Request can't find TLS Service Binding Protocol

2019-06-17 Thread rebecca
t;Request failed: 7   Error: Could not retrieve NBP file size from HTTP server.   Error: Network device error. -- Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#42516): https://edk2.groups.io/g/devel/message/42516 Mute T

Re: [edk2-devel] Problems using HTTPS boot: Http->Request can't find TLS Service Binding Protocol

2019-06-17 Thread rebecca
On 2019-06-17 16:14, rebe...@bluestop.org wrote: > I'm having problems using HTTPS boot in OVMF: Http->Request can't find > the EFI_TLS_SERVICE_BINDING_PROTOCOL. > It appears the OpenSSL update broke it. Revision b739678918 works, but f03859ea6c doesn't. --

Re: FW: [edk2-devel] [PATCH] BaseTools:Linux changes the way the latest version is judged

2019-06-24 Thread rebecca
quot;$b" ]]* *if [ "$a" \< "$b" ]* Note that the "<" needs to be escaped <http://tldp.org/LDP/abs/html/escapingsection.html#ESCP> within a *[ ]* construct. -- Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive

Re: [edk2-devel] [PATCH] CryptoPkg: define DSO_NONE in the OpenSSL build

2019-06-13 Thread rebecca
On 2019-06-13 17:32, Rebecca Cran wrote: > This fixes the build on FreeBSD, where DSO_METHOD_openssl is undefined > since dso_openssl.c only compiles the function if DSO_NONE is defined. Sorry, I just realized this isn't applicable to the OpenSSL we currently pull in: I was testing a

[edk2-devel] [PATCH] CryptoPkg: define DSO_NONE in the OpenSSL build

2019-06-13 Thread rebecca
This fixes the build on FreeBSD, where DSO_METHOD_openssl is undefined since dso_openssl.c only compiles the function if DSO_NONE is defined. Signed-off-by: Rebecca Cran --- CryptoPkg/Library/OpensslLib/OpensslLib.inf | 2 +- CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf | 2 +- 2

Re: [edk2-devel] [PATCH 1/1] CryptoPkg/OpensslLib: disable autoload-config for OpenSSL

2019-06-19 Thread rebecca
On 2019-06-19 01:22, Xiaoyu Lu wrote: > This problem was found by Rebecca Cran . > REF: https://edk2.groups.io/g/devel/topic/32100684 > > OpenSSL will automatically load a system config file which configures > default ssl options. In UEFI, It will cause TlsInitialize f

Re: [edk2-devel] Problems using HTTPS boot: Http->Request can't find TLS Service Binding Protocol

2019-06-19 Thread rebecca
L commit (25eb9299) first introduced in OpenSSL_1_1_1b change > openssl_config_int > function will cause this problem. > > And I made a patch for it. You can find it at > https://edk2.groups.io/g/devel/message/42577 Thanks! That fixed the problem. -- Rebecca Cran -=-=-=-=-=-

Re: [edk2-devel] [RFC] Fine-grained review ownership for MdeModulePkg

2019-06-20 Thread rebecca
, I think this should be CC'd to r...@edk2.groups.io (https://edk2.groups.io/g/rfc)? -- Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#42662): https://edk2.groups.io/g/devel/message/42662 Mute This Topic: https://groups

[edk2-devel] BroxtonPlatformPkg (Atom E3900 etc.) missing from edk2-platforms master

2019-06-22 Thread rebecca
I noticed the BroxtonPlatformPkg, needed for Intel Atom E3900 support, isn't in edk2-platforms master but only in the devel-IntelAtomProcessorE3900 branch. Was that deliberate, or an oversight? -- Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent

Re: [edk2-devel] [PATCH] BaseTools:Linux changes the way the latest version is judged

2019-06-23 Thread rebecca
n > export PYTHON_COMMAND=$python >fi I think using the "-lt" operator might be better (more standard). e.g.: if [ "$origin_version" -lt "$python_version" ]; then -- Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all me

[edk2-devel] Understanding TCP4 Connect() not working after calling Close() and Configure(NULL)

2019-05-10 Thread rebecca
k reports in the debug output that it's sent a SYN packet, but I don't see it in Wireshark, and the connection attempt eventually times out.  I'm only able to reconnect if I call tcp4sb->CreateChild() to get a new instance. -- Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive

Re: [edk2-devel] RFC for Edk2-ToolEnv

2019-05-13 Thread rebecca
t > variable settings, etc.   This provides easy methods for common repos > to share build tools/steps.  > Is there not an existing framework that could be used instead of creating something new? -- Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent

Re: [edk2-devel] RFC for Edk2-ToolEnv

2019-05-14 Thread rebecca
uot; job to Jenkins and collects the results for pre-commit testing, while the same instance also checks for new changesets in the main repo and runs CI builds against them. -- Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#4

Re: [edk2-devel] RFC for Edk2-ToolEnv

2019-05-14 Thread rebecca
lient, that does things like packaging etc., and this proposal will include server-side code too. Also, I don't think there is anything that'll be as nicely integrated as this, so I'm happy with it. -- Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group

Re: [edk2-devel] [PATCH] CryptoPkg: add issetugid declaration to fix openssl build on FreeBSD

2019-04-26 Thread rebecca
On 2019-04-24 13:17, Laszlo Ersek wrote: > > And, again, that's exactly how the sender is displayed to me by > Thunderbird, in my list folder only: > > From: Rebecca via Groups.Io > > Again, in email that I get directly from Rebecca, the From field looks > just fi

Re: [edk2-devel] [PATCH] CryptoPkg: add issetugid declaration to fix openssl build on FreeBSD

2019-04-26 Thread rebecca
On 2019-04-26 14:19, Laszlo Ersek wrote: > > This one looks good -- the From address has changed from > > rebecca via Groups.Io > > to > > rebe...@bluestop.org Oh, it's in their FAQ! :D https://groups.io/static/help#dmarc Why Are Emails From Some People Chan

[edk2-devel] Adding DebugPkg to the main edk2 repo

2019-05-06 Thread rebecca
/reorganized/integrated)? It seems such a useful addition for debugging UEFI code running under OVMF that it would be nice to have it somewhere it has less chance of bitrotting. -- Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online

Re: [edk2-devel] Adding DebugPkg to the main edk2 repo

2019-05-07 Thread rebecca
ve/edk2-stable201903) but it didn't work and I didn't have time to look into why. It might just be because Bhyve's gdb server is fairly basic at the moment. -- Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#40122): htt

Re: FW: [edk2-devel] [PATCH] BaseTools:Linux changes the way the latest version is judged

2019-06-26 Thread rebecca
ng to change it to > > if [[ "$origin_version" < "$python_version" ]]; then > That's fine for now, hopefully it'll keep working as long as it needs to. But once you're comparing for example 3.7 and 3.12: [bcran@photon ~]$ if [[ "3.7&q

[edk2-devel] [PATCH] Fix indentation in edksetup.sh SetupPython3

2019-06-26 Thread rebecca
Signed-off-by: Rebecca Cran --- edksetup.sh | 40 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/edksetup.sh b/edksetup.sh index c7b2e1e201..61e988035f 100755 --- a/edksetup.sh +++ b/edksetup.sh @@ -108,27 +108,27 @@ function SetupEnv

Re: [edk2-devel] [edk2-platforms Patch 01/28] Vlv2TbltDevicePkg/Build_IFWI.sh: Add "set -e" to exit on error

2019-07-11 Thread rebecca
On 2019-07-10 13:04, Michael D Kinney wrote: > +set -e > + Reviewed-by: Rebecca Cran -- Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#43635): https://edk2.groups.io/g/devel/message/43635 Mute This Topic:

Re: [edk2-devel] [edk2-platforms Patch 02/28] Vlv2TbltDevicePkg/Build_IFWI.sh: Change the root directory path

2019-07-11 Thread rebecca
oks like these changes are for getting ready to move the code into master. I've just started working on porting the BroxtonPlatformPkg over to master too, and just wanted to check if you know if anyone's already working on it? If so, I'll stop my work to avoid the duplication of effo

Re: [edk2-devel] [PATCH] Simplify edksetup.sh

2019-07-12 Thread rebecca
On 2019-07-10 15:17, Rebecca Cran wrote: > o Use '$SCRIPTNAME' consistently instead of 'edksetup.sh' > > o Use the bash environment variable $PWD instead of executing the pwd > command. > > o Add quotes around variables to ensure they're evaluated correctly. > >

Re: [edk2-devel] [edk2-platforms Patch 02/28] Vlv2TbltDevicePkg/Build_IFWI.sh: Change the root directory path

2019-07-12 Thread rebecca
On 2019-07-12 10:23, Michael D Kinney wrote: > Hi Rebecca, > > Vlv2 is already in edk2-platforms/master. This patch series is fixing some > Linux/GCC build issues. > > I have a few more queued up after this to make it even better by > removing the use of the FCE tool in t

[edk2-devel] [PATCH edk2-platfoms devel-IntelAtomProcessorE3900] Fix the Core Version string in the Platform Setup

2019-07-12 Thread rebecca
"Core Version: UEFI 2.3.1". -- Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#43670): https://edk2.groups.io/g/devel/message/43670 Mute This Topic: https://groups.io/mt/32445906/21656 Group Owner: devel+ow...@edk2

[edk2-devel] [PATCH] Platform/Intel/Vlv2TbltDevicePkg: fix postbuild scripts

2019-07-12 Thread rebecca
s the GUID string. Signed-off-by: Rebecca Cran --- .../Feature/Capsule/GenerateCapsule/GenCapsuleAll.sh | 10 ++ .../Capsule/GenerateCapsule/GenCapsuleMinnowMax.sh | 2 ++ .../GenerateCapsule/GenCapsuleMinnowMaxRelease.sh | 2 ++ .../Capsule/GenerateCapsule/GenCapsuleSamp

Re: [edk2-devel] [edk2-platforms Patch 23/28] Vlv2TbltDevicePkg: Import TlsLib for HTTPS Boot

2019-07-11 Thread rebecca
Reviewed-by: Rebecca Cran On 7/10/19 1:05 PM, Michael D Kinney wrote: From: Gary Lin When setting NETWORK_TLS_ENABLE to TRUE, we need TlsLib. Cc: Zailiang Sun Cc: Yi Qian Cc: Michael D Kinney Signed-off-by: Gary Lin --- Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgGccIA32.dsc | 3

Re: [edk2-devel] [edk2-platforms Patch 26/28] Vlv2TbltDevicePkg: Clean up all build scripts

2019-07-11 Thread rebecca
bld_vlv.sh should probably have "set -e" at the top, like the change to Build_IFWI.sh See https://bugzilla.tianocore.org/show_bug.cgi?id=1599 ("bld_vlv.sh isn't `set -e` and doesn't check if commands completed successfully"). -- Rebecca Cran On 7/10/19 1:05 PM, Mi

Re: [edk2-devel] [PATCH] Simplify edksetup.sh

2019-07-15 Thread rebecca
t are to single lines. -- Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#43723): https://edk2.groups.io/g/devel/message/43723 Mute This Topic: https://groups.io/mt/32421563/21656 Group Owner: devel+ow...@edk2.groups.io Unsu

Re: [edk2-devel] [PATCH] Simplify edksetup.sh

2019-07-15 Thread rebecca
through review. (And we've had issues with > this in the past in edksetup.sh.) Thanks, I understand now. I'll resubmit the changes as a series. -- Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#43726): https://edk2

[edk2-devel] [PATCH v3 2/6] edksetup.sh: Use $SCRIPTNAME consistently instead of 'edksetup.sh'

2019-07-16 Thread rebecca
Signed-off-by: Rebecca Cran Reviewed-by: Laszlo Ersek --- edksetup.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/edksetup.sh b/edksetup.sh index ab58fe4a6e..752e47e7cb 100755 --- a/edksetup.sh +++ b/edksetup.sh @@ -49,11 +49,11 @@ function SetWorkspace() return

[edk2-devel] [PATCH v3 3/6] edksetup.sh: when executing arithmetic commands, $ isn't needed

2019-07-16 Thread rebecca
Signed-off-by: Rebecca Cran Reviewed-by: Laszlo Ersek --- edksetup.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/edksetup.sh b/edksetup.sh index 752e47e7cb..76c8d7916e 100755 --- a/edksetup.sh +++ b/edksetup.sh @@ -199,7 +199,7 @@ do break ;; esac - I

[edk2-devel] [PATCH v3 1/6] edksetup.sh: Use bash variable $PWD instead of executing pwd command

2019-07-16 Thread rebecca
This is a (very minor) optimization: `pwd` runs the command (even as a built-in), whereas $PWD simply evaluates the value of the variable. ALso, modern scripts should generally use $(...) to run commands, instead of `...`. Signed-off-by: Rebecca Cran Reviewed-by: Laszlo Ersek --- edksetup.sh

[edk2-devel] [PATCH v3 4/6] edksetup.sh: remove redundant -?, -h and --help in options parsing

2019-07-16 Thread rebecca
Signed-off-by: Rebecca Cran Reviewed-by: Laszlo Ersek --- edksetup.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/edksetup.sh b/edksetup.sh index 76c8d7916e..06d2f041e6 100755 --- a/edksetup.sh +++ b/edksetup.sh @@ -194,7 +194,7 @@ do RECONFIG=TRUE shift

[edk2-devel] [PATCH v4 6/6] edksetup.sh: Add quotes and explicit checks in test statements

2019-07-16 Thread rebecca
There are unquoted variables that remain: only the ones considered most important to fix (in terms of potential bugs) were changed in this commit. Signed-off-by: Rebecca Cran Reviewed-by: Laszlo Ersek Reviewed-by: Leif Lindholm --- edksetup.sh | 4 ++-- 1 file changed, 2 insertions(+), 2

[edk2-devel] [PATCH v4 2/6] edksetup.sh: Use $SCRIPTNAME consistently instead of 'edksetup.sh'

2019-07-16 Thread rebecca
Signed-off-by: Rebecca Cran Reviewed-by: Laszlo Ersek Reviewed-by: Leif Lindholm --- edksetup.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/edksetup.sh b/edksetup.sh index ab58fe4a6e..752e47e7cb 100755 --- a/edksetup.sh +++ b/edksetup.sh @@ -49,11 +49,11

[edk2-devel] [PATCH v4 5/6] edksetup.sh: Simplify SetupPython3 and SetupPython functions.

2019-07-16 Thread rebecca
On Linux, "whereis" matches python3, python3.7, as well as man pages, libs etc. While on macOS it only matches the specified name, and so misses python3.7. Improve this by looping over potential version numbers and seeing if such a binary exists and can be executed. Signed-off-by: Re

[edk2-devel] [PATCH v4 1/6] edksetup.sh: Use bash variable $PWD instead of executing pwd command

2019-07-16 Thread rebecca
This is a (very minor) optimization: `pwd` runs the command (even as a built-in), whereas $PWD simply evaluates the value of the variable. ALso, modern scripts should generally use $(...) to run commands, instead of `...`. Signed-off-by: Rebecca Cran Reviewed-by: Laszlo Ersek Reviewed-by: Leif

Re: [edk2-devel] [PATCH] MdePkg/BaseLib: Base64Decode(): don't declare variables in nested blocks

2019-07-16 Thread rebecca
88bf27fecf9fb4 > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1980 > Reported-by: Zhichao Gao > Signed-off-by: Laszlo Ersek Reviewed-by: Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#43824): https://edk2.groups.io/g

Re: [edk2-devel] [edk2-non-osi Patch] Vlv2SocBinPkg: Add initial binaries for Vlv2TbltDevicePkg

2019-06-30 Thread rebecca
ople's inboxes. -- Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#43097): https://edk2.groups.io/g/devel/message/43097 Mute This Topic: https://groups.io/mt/32267733/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe:

Re: [edk2-devel] [PATCH v2] BaseTools/Scripts: Add GetUtcDateTime script.

2019-08-14 Thread rebecca
(' [pycodestyle] BaseTools/Scripts/GetUtcDateTime.py:43:1: E305 expected 2 blank lines after class or function definition, found 1 [pycodestyle] -- Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#45604): https://edk2.gr

Re: [edk2-devel] [PATCH v2 3/3] OvmfPkg/build.sh: remove $ADD_QEMU_HDA

2019-07-29 Thread rebecca
On 2019-07-24 16:56, Jordan Justen wrote: > Reviewed-by: Jordan Justen > > On 2019-07-24 14:44:05, Rebecca Cran wrote: >> $ADD_QEMU_HDA was added because QEMU used to refuse to run without a >> disk. Since newer versions run without any disks, remove it. >> >

Re: Microsoft imports - was Re: [edk2-devel] [PATCH V2] BaseTools:Add extra debugging message

2019-08-02 Thread rebecca
essage, also copied into the BZ. Could we perhaps at _least_ run a tool like pyflakes? That trivially finds the error: bcran@photon:~/workspace/edk2/BaseTools/Source/Python/Trim % pyflakes Trim.py Trim.py:181:12: invalid syntax     expect:    ^ -- Rebecca Cran -=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v2 1/1] MdePkg: Add STATIC_ASSERT macro

2019-08-16 Thread rebecca
kenSpaceGuidCName, Pcd.TokenCName,Pcd.DatumType,Pcd.DefaultValueFromDecInfo[0],Pcd.DefaultValueFromDecInfo[1]) -- Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#45865): https://edk2.groups.io/g/devel/message/45865 Mute This Topic: https://gr

Re: [edk2-devel] [PATCH v2 1/1] MdePkg: Add STATIC_ASSERT macro

2019-08-16 Thread rebecca
): #if defined(_MSC_EXTENSIONS) #define __STATIC_ASSERT static_assert #else #define __STATIC_ASSERT _Static_assert #endif -- Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#45876): https://edk2.groups.io/g/devel/message/45876 Mute T

[edk2-devel] NetworkPkg: sending a second HTTPS request without tearing down instance in-between causes a crash

2019-08-12 Thread rebecca
the crash due to the corruption of the SetSessionDataPointer. -- Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#45486): https://edk2.groups.io/g/devel/message/45486 Mute This Topic: https://groups.io/mt/32848622/21656 Group

Re: [edk2-devel] [PATCH v2 1/1] MdePkg: Add STATIC_ASSERT macro

2019-08-16 Thread rebecca
ng the older toolchains against current/newer revisions of the edk2. For example at work we build a UEFI driver using VS2012, but it's against the UDK2014.SP1 branch, and being for a legacy product we'll never migrate to a newer UDK release or master tag. -- Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=- Gro

Re: [edk2-devel] [PATCH v2 1/1] MdePkg: Add STATIC_ASSERT macro

2019-08-21 Thread rebecca
h anything older than VS2012. From "edksetup.bat -h" ... ForceRebuild    Force a full rebuild of BaseTools binaries. VS2012            Set the env for VS2012 build. VS2013            Set the env for VS2013 build. VS2015            Set the env for VS2015 build. VS2017            Set th

[edk2-devel] [PATCH] Update edksetup.bat etc. to support building BaseTools with VS2008 and VS2010

2019-08-21 Thread rebecca
The parameter to select which version of Visual Studio to use when building BaseTools only goes back to VS2012. Add support for VS2008 and VS2010 and fix the code to avoid selecting a newer version if the user has requested a specific version. Signed-off-by: Rebecca Cran --- BaseTools

Re: [edk2-devel] [edk2-rfc] [RFC] EDK II Continuous Integration Phase 1

2019-08-31 Thread rebecca
On 2019-08-29 14:22, Michael D Kinney wrote: > This is based on work from a number of EDK II community > members that have provide valuable input and evaluations. > > * Rebecca Cran Jenkins evaluation > * Laszlo Ersek GitLab evaluation > * Philippe Mathieu-Daudé GitLab e

Re: [edk2-devel] git submodule update --init --recursive

2019-08-23 Thread rebecca
to clone > the edk2 instructions a bit more obvious. I think we came to the conclusion that "--recursive" isn't needed. But I've found that there are cases where "--force" is required to make sure git checks out a submodule correctly. -- Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-rfc] [edk2-devel] [RFC] EDK II Continuous Integration Phase 1

2019-09-04 Thread rebecca
;) which automates the checks and pushes the changeset. I understand that with Azure Pipelines and how it integrates with Github, along with the fact that this project doesn't use pull requests or any other review automation, means things are probably going to be pretty different to most oth

Re: [edk2-devel] [RFC] EDK II Continuous Integration Phase 1

2019-09-16 Thread rebecca
re to test, not trying to build it locally? -- Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#47337): https://edk2.groups.io/g/devel/message/47337 Mute This Topic: https://groups.io/mt/33072637/21656 Group Owner: devel+ow...@edk2

Re: [edk2-devel] [Patch v2 1/2] UefiCpuPkg/RegisterCpuFeaturesLib: Remove debug message.

2019-08-07 Thread rebecca
Laszlo Ersek I can't find it just now, but I seem to recall there's an associated BZ ticket that we triaged a couple of weeks ago. -- Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#45028): https://edk2.groups.io/g/devel/me

Re: [edk2-devel] [PATCH] OvmfPkg: enable multiprocessor builds when using build.sh

2019-07-22 Thread rebecca
should add a "-j" parameter if we build BaseTools for users (e.g. "make -j4 -C BaseTools")? I've found that it can be pretty slow without it: on my system adding -j4 reduces build time from 55 seconds to 15. Going higher doesn't seem to produce much more benefit: -j32 (on a Threa

[edk2-devel] [PATCH v2] OvmfPkg/build.sh: enable multitheaded build by default

2019-07-22 Thread rebecca
Enable multithreaded builds by default when building OvmfPkg using build.sh. This can drastically reduce build times. For example, on a modern ThreadRipper system the time required to build decreases from 3 minutes to 1 minute. Signed-off-by: Rebecca Cran --- OvmfPkg/build.sh | 2 +- 1 file

Re: [edk2-devel] [PATCH] OvmfPkg: enable multiprocessor builds when using build.sh

2019-07-22 Thread rebecca
I'll send a v2 patch in a while. -- Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#44179): https://edk2.groups.io/g/devel/message/44179 Mute This Topic: https://groups.io/mt/32553200/21656 Group Owner: devel+ow...

Re: [edk2-devel] [PATCH v4 1/6] edksetup.sh: Use bash variable $PWD instead of executing pwd command

2019-07-22 Thread rebecca
On 2019-07-22 16:16, Laszlo Ersek wrote: > > should we push patches #1 through #4 from this series? > > They are independent of python detection (which is still being discussed). I think that's a good idea. -- Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive

Re: [edk2-devel] [PATCH 1/1] edksetup.sh: rework python executable scanning

2019-07-16 Thread rebecca
-shells. There are several reasons to always prefer the $(...) syntax..." And https://wiki.bash-hackers.org/scripting/obsolete "Both the |`COMMANDS`| and |$(COMMANDS)| syntaxes are specified by POSIX, but the latter is _greatly_ preferred, though the former is unfortunately still very p

Re: [edk2-devel] [PATCH v2] edksetup.sh: Simplify SetupPython3 and SetupPython functions.

2019-07-16 Thread rebecca
ink in BaseTools/Bin/FreeBSD-amd64, which is what I've been doing. -- Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#43797): https://edk2.groups.io/g/devel/message/43797 Mute This Topic: https://groups.io/mt/32485955/2

[edk2-devel] [PATCH] OvmfPkg/build.sh: use POSIX 'command -v' instead of 'which'.

2019-07-23 Thread rebecca
Signed-off-by: Rebecca Cran --- OvmfPkg/build.sh | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/OvmfPkg/build.sh b/OvmfPkg/build.sh index e94aa2a37e..1c28e65404 100755 --- a/OvmfPkg/build.sh +++ b/OvmfPkg/build.sh @@ -174,11 +174,11 @@ case $PROCESSOR

[edk2-devel] [PATCH 1/2] OvmfPkg/build.sh: use newer '-drive if=pflash' syntax when running qemu

2019-07-23 Thread rebecca
Specify the firmware to use via the newer '-drive if=pflash' syntax which allows specifying the raw format and readonly parameters. This avoids warnings with newer version of QEMU. Signed-off-by: Rebecca Cran --- OvmfPkg/build.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[edk2-devel] [PATCH 2/2] OvmfPkg/build.sh: use $QEMU_FIRMWARE_DIR as QEMU fat root

2019-07-23 Thread rebecca
The $BUILD_ROOT_ARCH directory has too many files to work as a fat filesystem. QEMU fails with the message: Too many entries in root directory Use the $QEMU_FIRMWARE_DIR as the root directory instead. Signed-off-by: Rebecca Cran --- OvmfPkg/build.sh | 2 +- 1 file changed, 1 insertion(+), 1

Re: [edk2-devel] [PATCH 1/2] OvmfPkg/build.sh: use newer '-drive if=pflash' syntax when running qemu

2019-07-23 Thread rebecca
I tested with QEMU 1.6.2 and it works. I’ll update the patch to make it read-write. — Rebecca Cran > On Jul 23, 2019, at 8:54 PM, Jordan Justen wrote: > >> On 2019-07-23 18:51:00, wrote: >> Specify the firmware to use via the newer '-drive if=pflash' syntax >>

[edk2-devel] [PATCH] OvmfPkg/build.sh: run qemu _after_ building OvmfPkg

2019-07-23 Thread rebecca
Running qemu before building the firmware image doesn't make much sense. Move things so qemu is run after building OvmfPkg. Signed-off-by: Rebecca Cran --- OvmfPkg/build.sh | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/OvmfPkg/build.sh b/OvmfPkg/build.sh index

Re: [edk2-devel] [PATCH] OvmfPkg/build.sh: use POSIX 'command -v' instead of 'which'.

2019-07-24 Thread rebecca
n ]]; > Why add $() ? They're needed when used in a test ([...] or [[...]]) statement. $() replaces the older `` syntax. -- Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#44314): https://edk2.groups.io/g/devel/messa

[edk2-devel] [PATCH 1/6] edksetup.sh: Use bash variable $PWD instead of executing pwd command

2019-07-15 Thread rebecca
Signed-off-by: Rebecca Cran --- edksetup.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/edksetup.sh b/edksetup.sh index 12a3e26a67..ab58fe4a6e 100755 --- a/edksetup.sh +++ b/edksetup.sh @@ -71,7 +71,7 @@ function SetWorkspace() # # Set $WORKSPACE # - export

[edk2-devel] [PATCH 3/6] edksetup.sh: when executing arithmetic commands, $ isn't needed

2019-07-15 Thread rebecca
Signed-off-by: Rebecca Cran --- edksetup.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/edksetup.sh b/edksetup.sh index 752e47e7cb..76c8d7916e 100755 --- a/edksetup.sh +++ b/edksetup.sh @@ -199,7 +199,7 @@ do break ;; esac - I=$(($I - 1)) + I=$((I - 1

[edk2-devel] [PATCH 6/6] edksetup.sh: Add quotes and explicit checks in test statements

2019-07-15 Thread rebecca
Signed-off-by: Rebecca Cran --- edksetup.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/edksetup.sh b/edksetup.sh index e2f116f8bc..ba055d5d5a 100755 --- a/edksetup.sh +++ b/edksetup.sh @@ -118,7 +118,7 @@ function SetupPython3() function SetupPython

[edk2-devel] [PATCH 4/6] edksetup.sh: remove redundant -?, -h and --help in options parsing

2019-07-15 Thread rebecca
Signed-off-by: Rebecca Cran --- edksetup.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/edksetup.sh b/edksetup.sh index 76c8d7916e..06d2f041e6 100755 --- a/edksetup.sh +++ b/edksetup.sh @@ -194,7 +194,7 @@ do RECONFIG=TRUE shift ;; --?|-h|--help

[edk2-devel] [PATCH 2/6] edksetup.sh: Use $SCRIPTNAME consistently instead of 'edksetup.sh'

2019-07-15 Thread rebecca
Signed-off-by: Rebecca Cran --- edksetup.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/edksetup.sh b/edksetup.sh index ab58fe4a6e..752e47e7cb 100755 --- a/edksetup.sh +++ b/edksetup.sh @@ -49,11 +49,11 @@ function SetWorkspace() return 0 fi

[edk2-devel] [PATCH 5/6] edksetup.sh: Simplify SetupPython3 and SetupPython functions.

2019-07-15 Thread rebecca
On Linux, "whereis" matches python3, python3.7, as well as man pages, libs etc. While on macOS it only matches the specified name, and so misses python3.7. Improve this by looping over potential version numbers and seeing if such a binary exists and can be executed. Signed-off-by: Re

Re: [edk2-devel] [PATCH] Simplify edksetup.sh

2019-07-15 Thread rebecca
: *one* goal, of simplifying the script :) Anyway, I've resubmitted the changes as a series. Now back to my day job. -- Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#43749): https://edk2.groups.io/g/devel/message/43749 Mut

Re: [edk2-devel] [PATCH 1/6] edksetup.sh: Use bash variable $PWD instead of executing pwd command

2019-07-15 Thread rebecca
have a different > default behavior". Is that the reason? No, it's mainly as a (very minor) optimization: `pwd` runs the command (even as a built-in), whereas $PWD simply evaluates the value of the variable. Also, modern scripts as I understand it should generally use $(...) to run com

Re: [edk2-devel] [PATCH 6/6] edksetup.sh: Add quotes and explicit checks in test statements

2019-07-15 Thread rebecca
ch to fix the others and further reduce the number of shellcheck warnings. -- Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#43765): https://edk2.groups.io/g/devel/message/43765 Mute This Topic: https://groups.io/mt/32483

Re: [edk2-devel] [PATCH 5/6] edksetup.sh: Simplify SetupPython3 and SetupPython functions.

2019-07-15 Thread rebecca
-v' instead.". -- Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#43766): https://edk2.groups.io/g/devel/message/43766 Mute This Topic: https://groups.io/mt/32483827/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https:

[edk2-devel] [PATCH v2] edksetup.sh: Simplify SetupPython3 and SetupPython functions.

2019-07-15 Thread rebecca
On Linux, "whereis" matches python3, python3.7, as well as man pages, libs etc. While on macOS it only matches the specified name, and so misses python3.7. Improve this by looping over potential version numbers and seeing if such a binary exists and can be executed. Signed-off-by: Re

Re: [edk2-devel] [PATCH 1/2] OvmfPkg/build.sh: use newer '-drive if=pflash' syntax when running qemu

2019-07-24 Thread rebecca
for example RHEL and Debian. But even Debian Jessie has QEMU 2.1 (https://packages.debian.org/jessie/qemu-system). -- Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#44331): https://edk2.groups.io/g/devel/message/44331 Mut

Re: [edk2-devel] [PATCH] OvmfPkg/build.sh: run qemu _after_ building OvmfPkg

2019-07-24 Thread rebecca
e variables across multiple qemu boots. Oh! I thought the use case for having qemu in build.sh was to run it against the newly-built firmware. Since that's not the case, just ignore this patch. -- Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group.

[edk2-devel] [PATCH v2 2/3] OvmfPkg/build.sh: use newer '-drive if=pflash' syntax when running qemu

2019-07-24 Thread rebecca
Specify the firmware to use via the newer '-drive if=pflash' syntax which allows specifying the raw format parameter. This avoids warnings with newer version of QEMU. Signed-off-by: Rebecca Cran --- OvmfPkg/build.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/OvmfPkg

[edk2-devel] [PATCH v2 1/3] OvmfPkg/build.sh: use POSIX 'command -v' instead of 'which'.

2019-07-24 Thread rebecca
Signed-off-by: Rebecca Cran --- OvmfPkg/build.sh | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/OvmfPkg/build.sh b/OvmfPkg/build.sh index e94aa2a37e..1c28e65404 100755 --- a/OvmfPkg/build.sh +++ b/OvmfPkg/build.sh @@ -174,11 +174,11 @@ case $PROCESSOR

[edk2-devel] [PATCH v2 3/3] OvmfPkg/build.sh: remove $ADD_QEMU_HDA

2019-07-24 Thread rebecca
$ADD_QEMU_HDA was added because QEMU used to refuse to run without a disk. Since newer versions run without any disks, remove it. Signed-off-by: Rebecca Cran --- OvmfPkg/build.sh | 14 -- 1 file changed, 14 deletions(-) diff --git a/OvmfPkg/build.sh b/OvmfPkg/build.sh index

Re: [edk2-devel] [PATCH] OvmfPkg/build.sh: use POSIX 'command -v' instead of 'which'.

2019-07-24 Thread rebecca
the v2 series of OvmfPkg/build.sh changes. -- Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#44339): https://edk2.groups.io/g/devel/message/44339 Mute This Topic: https://groups.io/mt/32579615/21656 Group Owner: devel+ow...@

Re: [edk2-devel] [PATCH 1/2] OvmfPkg/build.sh: use newer '-drive if=pflash' syntax when running qemu

2019-07-24 Thread rebecca
just tried navigating the OVMF setup menu under QEMU 1.6.2 and when I tried to enter the "IPv4 Network Configuration" settings I was sent back the initial screen. So we might want to recommend against running older versions just because they don't work as well. -- Rebecca Cran -=-=

[edk2-devel] [PATCH] OvmfPkg/build.sh: remove literal carriage return

2019-07-24 Thread rebecca
Signed-off-by: Rebecca Cran --- OvmfPkg/build.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/OvmfPkg/build.sh b/OvmfPkg/build.sh index 960382f633..78f44e3a96 100755 --- a/OvmfPkg/build.sh +++ b/OvmfPkg/build.sh @@ -40,7 +40,7 @@ ARCH_X64=no BUILDTARGET=DEBUG

Re: [edk2-devel] [PATCH v2 1/3] OvmfPkg/build.sh: use POSIX 'command -v' instead of 'which'.

2019-07-25 Thread rebecca
nd patches using "git send-email". -- Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#44380): https://edk2.groups.io/g/devel/message/44380 Mute This Topic: https://groups.io/mt/32591947/21656 Group Owner:

Re: [edk2-devel] [PATCH 1/2] OvmfPkg/build.sh: use newer '-drive if=pflash' syntax when running qemu

2019-07-25 Thread rebecca
On 2019-07-24 10:53, Michael D Kinney wrote: > Rebecca, > > If you are interested, I prototyped using a python > script and POSTBUILD statement in the DSC file to > support 'run' targets for OVMF in the following > branch. This potentially allows the same code to > be

  1   2   3   4   5   6   7   8   9   10   >