Re: [edk2-devel] [PATCH] BaseTools: Fix an incremental build issue caused by macro in #include

2019-10-16 Thread Bob Feng
I think one of the example would be like this: #include MACRO(xxx.h) I think this patch is good. Thanks for caching and fixing this bug. Reviewed-by: Bob Feng Thanks, Bob -Original Message- From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Philippe Mathieu

Re: [edk2-devel] [Patch v2 03/11] BaseTools GenFw: Fix the issue to update the wrong size as SectionSize

2019-10-16 Thread Bob Feng
Hi Liming, Would you please add more description in commit message? This patch is in the patch set of CLANG9 enabling, but it's hard for me to see the direct relationship between CLANG9 and this fix and why the original code is wrong. Thanks Bob -Original Message- From:

Re: [edk2-devel] [Patch v2 00/11] New Cross OS tool chain CLANG9

2019-10-16 Thread Bob Feng
2X64 RELEASE build generates the same BIOS images on Windows and Linux OS. Cc: Jiewen Yao Cc: Steven Shi Cc: Jordan Justen Cc: Laszlo Ersek Cc: Andrew Fish Cc: Ray Ni Cc: Ard Biesheuvel Cc: Jian J Wang Cc: Hao A Wu Cc: Bob Feng Cc: Michael D Kinney Liming Gao (11): BaseTools tools_def.temp

Re: [edk2-devel] [Patch v2 01/11] BaseTools tools_def.template: Remove unnecessary $(DEST_DIR_DEBUG) path

2019-10-16 Thread Bob Feng
Reviewed-by:  Bob Feng < bob.c.f...@intel.com > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#49080): https://edk2.groups.io/g/devel/message/49080 Mute This Topic: https://groups.io/mt/34540582/21656 Group Owner: devel+ow..

Re: [edk2-devel] [Patch 1/1] BaseTools: Fix a bug of genffs command generation

2019-10-13 Thread Bob Feng
id=2221 > >The command used by multiple thread genffs feature in makefile for >testing if file exist is generated based on the toolchain family. >It should be based on the OS type. > >Cc: Liming Gao >Signed-off-by: Bob Feng >--- > BaseTools/Source/Python/GenFds/GenFdsGlobalVa

Re: [edk2-devel] [PATCH V1 1/1] BaseTools: Fix GenMake multi-workspace failure

2019-10-03 Thread Bob Feng
Pushed at SHA-1: 61af5f249495b18f45ca164376c871081448c0e4 Thanks, Bob -Original Message- From: devel@edk2.groups.io On Behalf Of Bob Feng Sent: Friday, October 4, 2019 11:04 AM To: devel@edk2.groups.io; Kinney, Michael D ; Kubacki, Michael A Cc: Gao, Liming Subject: Re: [edk2-devel

Re: [edk2-devel] [PATCH V1 1/1] BaseTools: Fix GenMake multi-workspace failure

2019-10-03 Thread Bob Feng
Thanks for the fix. I agree. Reviewed-by: Bob Feng -Original Message- From: devel@edk2.groups.io On Behalf Of Michael D Kinney Sent: Friday, October 4, 2019 5:14 AM To: devel@edk2.groups.io; Kubacki, Michael A ; Kinney, Michael D Cc: Feng, Bob C ; Gao, Liming Subject: Re: [edk2

[edk2-devel] [Patch 1/1 V2] BaseTools: Fix a bug of genffs command generation

2019-09-29 Thread Bob Feng
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2221 The command used by multiple thread genffs feature in makefile for testing if file exist is generated based on the toolchain family. It should be based on the make program name. Cc: Liming Gao Signed-off-by: Bob Feng --- BaseTools

[edk2-devel] [Patch 1/1] BaseTools: Fix the lib order in static_library_files.lst

2019-09-27 Thread Bob Feng
: dann frazier Signed-off-by: Bob Feng --- BaseTools/Source/Python/AutoGen/ModuleAutoGen.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/BaseTools/Source/Python/AutoGen/ModuleAutoGen.py b/BaseTools/Source/Python/AutoGen/ModuleAutoGen.py index fad5bab0f24d..f0812b6887be 100755

[edk2-devel] [Patch 1/1] BaseTools: Fix a bug of genffs command generation

2019-09-26 Thread Bob Feng
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2221 The command used by multiple thread genffs feature in makefile for testing if file exist is generated based on the toolchain family. It should be based on the OS type. Cc: Liming Gao Signed-off-by: Bob Feng --- BaseTools/Source/Python

Re: [edk2-devel] [PATCH 1/1] BaseTools: use stdint.h for GCC ProcessorBind.h typedefs

2019-09-26 Thread Bob Feng
Reviewed-by: Bob Feng -Original Message- From: Leif Lindholm [mailto:leif.lindh...@linaro.org] Sent: Friday, September 27, 2019 3:28 AM To: devel@edk2.groups.io Cc: Ard Biesheuvel ; Feng, Bob C ; Gao, Liming ; Laszlo Ersek Subject: [PATCH 1/1] BaseTools: use stdint.h for GCC

Re: [edk2-devel] [Patch 05/10 V8] BaseTools: Enable Multiple Process AutoGen

2019-09-23 Thread Bob Feng
, Bob Feng wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1875 > > Assign the Module AutoGen tasks into multiple sub process. > > Cc: Liming Gao > Signed-off-by: Bob Feng > --- > .../Source/Python/AutoGen/AutoGenWorker.py| 191 ++ &g

Re: [edk2-devel] [Patch] Revert "BaseTools: Improve GetDependencyList function"

2019-09-20 Thread Bob Feng
I agree. Reviewed-by: Bob Feng -Original Message- From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Liming Gao Sent: Friday, September 20, 2019 2:00 PM To: devel@edk2.groups.io Cc: Feng, Bob C Subject: [edk2-devel] [Patch] Revert "BaseTools: Im

Re: [edk2-devel] [PATCH V2] BaseTools:Fix the issue that build report failed

2019-09-19 Thread Bob Feng
Reviewed-by: Bob Feng -Original Message- From: Fan, ZhijuX Sent: Thursday, September 19, 2019 5:04 PM To: devel@edk2.groups.io Cc: Gao, Liming ; Feng, Bob C Subject: [PATCH V2] BaseTools:Fix the issue that build report failed BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=2201

Re: [edk2-devel] [PATCH] BaseTools:Change the way that get some VpdPcd information

2019-09-19 Thread Bob Feng
Zhiju, Please update the patch title, "Change the way that get some VpdPcd information" is not clear for what this patch dose. Thanks, Bob -Original Message- From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Bob Feng Sent: Thursday, September 19, 20

Re: [edk2-devel] [PATCH] BaseTools:Change the way that get some VpdPcd information

2019-09-19 Thread Bob Feng
Reviewed-by: Bob Feng -Original Message- From: Fan, ZhijuX Sent: Wednesday, September 18, 2019 5:43 PM To: devel@edk2.groups.io Cc: Gao, Liming ; Feng, Bob C Subject: [PATCH] BaseTools:Change the way that get some VpdPcd information BZ:https://bugzilla.tianocore.org/show_bug.cgi?id

[edk2-devel] [Patch] BaseTools: init DependencyHeaderFileSet for each MakeFile class

2019-09-18 Thread Bob Feng
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2203 This patch is going to fix a regression issue that build breaks when the custom makefile exist. Cc: Liming Gao Cc: Steven Shi Signed-off-by: Bob Feng --- BaseTools/Source/Python/AutoGen/GenMake.py | 6 +- 1 file changed, 5

Re: [edk2-devel] [PATCH 8/9] BaseTools: correct line endings for ConvertFce Python script

2019-09-18 Thread Bob Feng
Reviewed-by: Bob Feng -Original Message- From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Leif Lindholm Sent: Thursday, September 19, 2019 6:44 AM To: devel@edk2.groups.io Cc: Feng, Bob C ; Gao, Liming Subject: [edk2-devel] [PATCH 8/9] BaseTools: correct line

Re: [edk2-devel] [PATCH 5/9] BaseTools: fix line endings in SetupGit.py Conf files

2019-09-18 Thread Bob Feng
Reviewed-by: Bob Feng -Original Message- From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Leif Lindholm Sent: Thursday, September 19, 2019 6:43 AM To: devel@edk2.groups.io Cc: Feng, Bob C ; Gao, Liming Subject: [edk2-devel] [PATCH 5/9] BaseTools: fix line endings

Re: [edk2-devel] [PATCH 1/9] BaseTools: add missing newlines at end of files

2019-09-18 Thread Bob Feng
Reviewed-by: Bob Feng -Original Message- From: Leif Lindholm [mailto:leif.lindh...@linaro.org] Sent: Thursday, September 19, 2019 6:43 AM To: devel@edk2.groups.io Cc: Feng, Bob C ; Gao, Liming Subject: [PATCH 1/9] BaseTools: add missing newlines at end of files Some scripts in Source

Re: [edk2-devel] [PATCH v2 1/1] BaseTools: Add more parameter checking for CopyFileOnChange()

2019-09-18 Thread Bob Feng
Reviewed-by: Bob Feng -Original Message- From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Steven Shi Sent: Wednesday, September 18, 2019 11:21 AM To: devel@edk2.groups.io Cc: Gao, Liming ; Feng, Bob C Subject: [edk2-devel] [PATCH v2 1/1] BaseTools: Add more

Re: [edk2-devel] [PATCH] BaseTools:change some incorrect parameter defaults

2019-09-15 Thread Bob Feng
Reviewed-by: Bob Feng -Original Message- From: Fan, ZhijuX Sent: Thursday, September 12, 2019 4:18 PM To: devel@edk2.groups.io Cc: Gao, Liming ; Feng, Bob C Subject: [PATCH] BaseTools:change some incorrect parameter defaults BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1858

Re: [edk2-devel] [PATCH] BaseTools:Replace PlatformInfo with PlatformAutoGen for Moudle

2019-09-15 Thread Bob Feng
Reviewed-by: Bob Feng -Original Message- From: Fan, ZhijuX Sent: Thursday, September 12, 2019 4:19 PM To: devel@edk2.groups.io Cc: Gao, Liming ; Feng, Bob C Subject: [PATCH] BaseTools:Replace PlatformInfo with PlatformAutoGen for Moudle BZ:https://bugzilla.tianocore.org/show_bug.cgi

[edk2-devel] [Patch 1/1] BaseTools: Fixed a bug of IgnoreAutoGen

2019-09-11 Thread Bob Feng
to False Cc: Liming Gao Signed-off-by: Bob Feng --- BaseTools/Source/Python/build/build.py | 1 + 1 file changed, 1 insertion(+) diff --git a/BaseTools/Source/Python/build/build.py b/BaseTools/Source/Python/build/build.py index 13be6c33ecd5..a034664dc388 100755 --- a/BaseTools/Source/Python

[edk2-devel] [Patch 0/3] Clean BaseTools code for build performance

2019-09-10 Thread Bob Feng
REF: 1 https://bugzilla.tianocore.org/show_bug.cgi?id=2102 2 https://bugzilla.tianocore.org/show_bug.cgi?id=2101 3 https://bugzilla.tianocore.org/show_bug.cgi?id=2183 By profiling build Ovmf with cProfile: 1. re.findall time reduced: after patch: 0.017 {method 'findall' of '_sre.SRE_Pattern'

[edk2-devel] [Patch 3/3] BaseTools:Remove the unnecessary operation of renaming a file.

2019-09-10 Thread Bob Feng
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2183 This patch is going to remove rename call to reduce unnecessary io operation so that saving build time. Cc: Liming Gao Cc: Bob Feng Signed-off-by: Zhiju.Fan --- BaseTools/Source/Python/Common/Misc.py | 23 +++ 1

[edk2-devel] [Patch 1/3] BaseTools: Improve GetDependencyList function

2019-09-10 Thread Bob Feng
Gao Signed-off-by: Bob Feng --- BaseTools/Source/Python/AutoGen/GenMake.py | 29 -- 1 file changed, 16 insertions(+), 13 deletions(-) diff --git a/BaseTools/Source/Python/AutoGen/GenMake.py b/BaseTools/Source/Python/AutoGen/GenMake.py index 47dae82e1aeb..5d02d9a05694 100755

[edk2-devel] [Patch 2/3] BaseTools: remove unnecessary calls of os.exist

2019-09-10 Thread Bob Feng
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2101 This patch is going to remove unnecessary calls of os.exist() Cc: Liming Gao Signed-off-by: Bob Feng --- .../Source/Python/AutoGen/AutoGenWorker.py| 7 +- BaseTools/Source/Python/AutoGen/GenC.py | 97

Re: [edk2-devel] commit "BaseTools: Improve the cache hit in the edk2 build cache" causes build.py unknown fatal error

2019-09-09 Thread Bob Feng
Pushed at 53e2eaba7a19cda3183b1bb2a2619a2494538e52 Thanks, Bob From: Vladimir Olovyannikov [mailto:vladimir.olovyanni...@broadcom.com] Sent: Tuesday, September 10, 2019 4:15 AM To: Feng, Bob C ; Shi, Steven ; devel@edk2.groups.io Cc: Gao, Liming ; Rodriguez, Christian ; Johnson, Michael

Re: [edk2-devel] [Patch 1/3] BaseTools: Fixed the build fail on Linux with --genfds-multi-thread

2019-09-09 Thread Bob Feng
with --genfds-multi-thread Bob: What case will call GenSec without the exist file? Thanks Liming >-Original Message- >From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >Bob Feng >Sent: Friday, September 06, 2019 9:23 PM >To: devel@edk2.groups.io &

Re: [edk2-devel] [PATCH] BaseTools:ECC need to handle lower case 'static'

2019-09-08 Thread Bob Feng
Reviewed-by: Bob Feng -Original Message- From: Fan, ZhijuX Sent: Wednesday, September 4, 2019 5:54 PM To: devel@edk2.groups.io Cc: Gao, Liming ; Feng, Bob C Subject: [PATCH] BaseTools:ECC need to handle lower case 'static' BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1778 We

Re: [edk2-devel] [PATCH] BaseTools:Ecc handle another copyright format

2019-09-08 Thread Bob Feng
Reviewed-by: Bob Feng -Original Message- From: Fan, ZhijuX Sent: Friday, September 6, 2019 11:30 AM To: devel@edk2.groups.io Cc: Gao, Liming ; Feng, Bob C Subject: [PATCH] BaseTools:Ecc handle another copyright format BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=2057 Ecc can

Re: [edk2-devel] commit "BaseTools: Improve the cache hit in the edk2 build cache" causes build.py unknown fatal error

2019-09-08 Thread Bob Feng
Hi Vladimir and Steven, I checked code and think when the build target are 'clean', 'cleanlib', 'cleanall', 'run' and 'fds', build will fail with the error like you mentioned. I filed a Bugzilla https://bugzilla.tianocore.org/show_bug.cgi?id=2166 And provide a fix in

[edk2-devel] [Patch 1/1] BaseTools: Fixed build clean regression issue

2019-09-08 Thread Bob Feng
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2166 file_lock and cache_lock are used as global data, so move file_lock and cache_lock initialization in Build object __init__ function. Cc: Liming Gao Cc: Steven Shi Signed-off-by: Bob Feng --- BaseTools/Source/Python/build/build.py | 8

[edk2-devel] [Patch 3/3] BaseTools: Fixed the bug of multi-thread genffs for override inf

2019-09-06 Thread Bob Feng
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1302 If there is a inf override, and multi-thread genffs is enabled, build will fail. This patch is going to fix this bug. Cc: Liming Gao Cc: Steven Shi Signed-off-by: Bob Feng --- BaseTools/Source/Python/AutoGen/AutoGenWorker.py | 2

[edk2-devel] [Patch 1/3] BaseTools: Fixed the build fail on Linux with --genfds-multi-thread

2019-09-06 Thread Bob Feng
Signed-off-by: Bob Feng --- BaseTools/Source/Python/GenFds/GenFdsGlobalVariable.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/BaseTools/Source/Python/GenFds/GenFdsGlobalVariable.py b/BaseTools/Source/Python/GenFds/GenFdsGlobalVariable.py index 037828ea1cca..0f691ae52

[edk2-devel] [Patch 0/3 V2]Enable --genfds-multi-thread to default build

2019-09-06 Thread Bob Feng
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1302 Enable --genfds-multi-thread as default build behavior can improve build performance but will not bring nagtive impact. Feng, Bob C (3): BaseTools: Fixed the build fail on Linux with --genfds-multi-thread BaseTools: Enable

[edk2-devel] [Patch 2/3] BaseTools: Enable --genfds-multi-thread to default build

2019-09-06 Thread Bob Feng
Signed-off-by: Bob Feng --- BaseTools/Source/Python/AutoGen/GenMake.py | 4 ++-- BaseTools/Source/Python/AutoGen/WorkspaceAutoGen.py| 3 +-- BaseTools/Source/Python/Common/GlobalData.py | 2 +- BaseTools/Source/Python/Common/buildoptions.py | 3 ++- BaseTools/Source

Re: [edk2-devel] [Patch 1/1] BaseTools: Fixed issue for IgnoreAutoGen

2019-09-05 Thread Bob Feng
Sorry for the incomplete mail. I verified this patch on Ovmf, Emulator, MinPlatforms and Intel Server Platform. Thanks, Bob -Original Message- From: devel@edk2.groups.io On Behalf Of Bob Feng Sent: Thursday, September 5, 2019 10:04 PM To: Gao, Liming ; devel@edk2.groups.io Cc: Shi

Re: [edk2-devel] [Patch 1/1] BaseTools: Fixed issue for IgnoreAutoGen

2019-09-05 Thread Bob Feng
age- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Bob Feng > Sent: Thursday, September 5, 2019 5:05 PM > To: devel@edk2.groups.io > Cc: Gao, Liming ; Shi, Steven > ; Feng, Bob C > Subject: [edk2-devel] [Patch 1/1] BaseTools: Fixed issue for &g

Re: [edk2-devel] [Patch 0/2] Enable --genfds-multi-thread to default build

2019-09-05 Thread Bob Feng
the platform list have been verified with this change? Thanks Liming> -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Bob Feng > Sent: Thursday, September 5, 2019 11:11 AM > To: devel@edk2.groups.io > Subject: [edk2-devel]

[edk2-devel] [Patch 1/1] BaseTools: Fix a bug for Hii Pcd override

2019-09-05 Thread Bob Feng
this bug. Cc: Liming Gao Signed-off-by: Bob Feng --- BaseTools/Source/Python/Workspace/DscBuildData.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/BaseTools/Source/Python/Workspace/DscBuildData.py b/BaseTools/Source/Python/Workspace/DscBuildData.py index d2b5ccbb7a30

[edk2-devel] [Patch 1/1] BaseTools: Fixed issue for IgnoreAutoGen

2019-09-05 Thread Bob Feng
https://bugzilla.tianocore.org/show_bug.cgi?id=2080 This patch is to improve build -u option to re-use GlobalVar__.bin file which is introduced by multiple-process-autogen feature. Cc: Liming Gao Cc: Steven Shi Signed-off-by: Bob Feng --- .../Source/Python/AutoGen/AutoGenWorker.py| 2

Re: [edk2-devel] [edk2] [Patch 32/33] BaseTools: ECC tool Python3 adaption

2019-09-04 Thread Bob Feng
k/git/edk2/BaseTools/Source/Python/Ecc/CParser3/CLexer.py", > > > line 147, in __init__ > > > Lexer.__init__(self, input) > > > File "/usr/lib/python3/dist-packages/antlr3/recognizers.py", line 1039, > > > in __init__ > > > BaseRecognizer.__init__(se

[edk2-devel] [Patch 2/2] BaseTools: Enable --genfds-multi-thread to default build

2019-09-04 Thread Bob Feng
Signed-off-by: Bob Feng --- BaseTools/Source/Python/AutoGen/GenMake.py | 4 ++-- BaseTools/Source/Python/AutoGen/WorkspaceAutoGen.py| 3 +-- BaseTools/Source/Python/Common/GlobalData.py | 2 +- BaseTools/Source/Python/Common/buildoptions.py | 3 ++- BaseTools/Source

[edk2-devel] [Patch 0/2] Enable --genfds-multi-thread to default build

2019-09-04 Thread Bob Feng
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1302 Enable --genfds-multi-thread as default build behavior can improve build performance but will not bring nagtive impact. Feng, Bob C (2): BaseTools: Fixed the build fail on Linux with --genfds-multi-thread BaseTools: Enable

[edk2-devel] [Patch 1/2] BaseTools: Fixed the build fail on Linux with --genfds-multi-thread

2019-09-04 Thread Bob Feng
If GenSec input file not exist, the related command will fail and make will stop on Linux. GenSec input file is allow to be non-existent. This patch is to let "make" continue if gensec input file not exist. Cc: Liming Gao Signed-off-by: Bob Feng --- BaseTools/Source/Pyt

Re: [edk2-devel] [edk2] [Patch 32/33] BaseTools: ECC tool Python3 adaption

2019-09-04 Thread Bob Feng
t; > File "/usr/lib/python3/dist-packages/antlr3/recognizers.py", line 169, in > > __init__ > > .format(self.api_version)) > > RuntimeError: ANTLR version mismatch: The recognizer has been generated > > with API V0, but this runtime does not support this. >

[edk2-devel] [Patch 1/1] BaseTools: Sort Pcd settings to make PcdTokenNumber be fixed

2019-09-04 Thread Bob Feng
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2147 This patch is to sort the Pcd settings so that PcdTokenNumber will not change if the platform's Pcd settings are the same. Signed-off-by: Bob Feng Cc: Liming Gao Cc: Steven Shi --- BaseTools/Source/Python/AutoGen/PlatformAutoGen.py

Re: [edk2-devel] [edk2] [Patch 32/33] BaseTools: ECC tool Python3 adaption

2019-09-03 Thread Bob Feng
are generated by antlr4 and for > > python3 usage. They have python3 specific syntax, for example the > > data type declaration for the arguments of a function. That is not > > compitable with python2. this patch is to remove these syntax. > > > > ECC tool

Re: [edk2-devel] [Patch] BaseTools: Update GenFw tool to support -e -z option together

2019-09-03 Thread Bob Feng
Thanks, with the change, Reviewed-by: Bob Feng -Original Message- From: Gao, Liming Sent: Wednesday, September 4, 2019 9:21 AM To: Feng, Bob C ; devel@edk2.groups.io Subject: RE: [edk2-devel] [Patch] BaseTools: Update GenFw tool to support -e -z option together Yes. Thanks for your

Re: [edk2-devel] [Patch] BaseTools: Update GenFw tool to support -e -z option together

2019-09-03 Thread Bob Feng
zero debug entry. It can be used to check the EFI image in DEBUG build. Signed-off-by: Liming Gao Cc: Bob Feng --- BaseTools/Source/C/GenFw/GenFw.c | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/BaseTools/Source/C/GenFw/GenFw.c b/BaseTools/Source/C/GenFw/Gen

Re: [edk2-devel] [Patch][edk2-stable201908] BaseTools: fix an incremental build issue.

2019-08-28 Thread Bob Feng
apple.com; > Laszlo > > Ersek > > > > (ler...@redhat.com) ; > > leif.lindh...@linaro.org > > > > Subject: RE: [Patch][edk2-stable201908] > BaseTools: > > fix an > > > > incremental build issue. > > > > > > > > Bob:

Re: [edk2-devel] [Patch][edk2-stable201908] BaseTools: Fixed regression issue for building !x86 builds

2019-08-28 Thread Bob Feng
ay, August 28, 2019 10:01 PM > > To: devel@edk2.groups.io; Feng, Bob C > > > Cc: Gao, Liming > > Subject: Re: [edk2-devel] [Patch][edk2-stable201908] > BaseTools: Fixed > > regression issue for building !x86 builds > > > > On Wed, Aug 28, 20

[edk2-devel] [Patch][edk2-stable201908] BaseTools: Fixed regression issue for building !x86 builds

2019-08-28 Thread Bob Feng
of the library class resolutions was not changed. Cc: Liming Gao Signed-off-by: Bob Feng --- .../Source/Python/Workspace/InfBuildData.py | 29 ++- 1 file changed, 16 insertions(+), 13 deletions(-) diff --git a/BaseTools/Source/Python/Workspace/InfBuildData.py b/BaseTools/Source/Python

[edk2-devel] [Patch][edk2-stable201908] BaseTools: fix an incremental build issue.

2019-08-28 Thread Bob Feng
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2137 This patch is going to fix a regression issue of incremental build which was introduced by the commit 94459080c. The changing on INF file will not trigger module rebuild. Signed-off-by: Bob Feng Cc: Liming Gao Cc: Steven Shi

Re: [edk2-devel] [PATCH 1/1] MdeModulePkg: fix !x86 builds (more)

2019-08-27 Thread Bob Feng
I'll work on this Basetools regression issue today. Thanks, Bob -Original Message- From: Kinney, Michael D Sent: Wednesday, August 28, 2019 5:27 AM To: devel@edk2.groups.io; leif.lindh...@linaro.org; Laszlo Ersek ; Kinney, Michael D Cc: Andrew Fish ; Baptiste Gerondeau ; Wang, Jian J

Re: [edk2-devel] [PATCH] [edk2-stable201908] BaseTools: Support long file path in windows for misc functions

2019-08-23 Thread Bob Feng
Pushed at 6dd9aa40193cc905cda5f97d07e30ffbd5299439 -Original Message- From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Bob Feng Sent: Thursday, August 22, 2019 11:14 AM To: devel@edk2.groups.io; Shi, Steven Cc: Gao, Liming Subject: Re: [edk2-devel] [PATCH] [edk2

Re: [edk2-devel] [Patch][edk2-stable201908] BaseTools: Fix incremental build genmake issue

2019-08-23 Thread Bob Feng
-by: Liming Gao > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Bob Feng > Sent: Wednesday, August 21, 2019 5:57 PM > To: devel@edk2.groups.io > Cc: Gao, Liming ; Feng, Bob C > Subject: [edk2-devel] [Patch][edk2-stable201908] BaseTool

Re: [edk2-devel] [Patch V2][edk2-stable201908] BaseTools: Incorrect error message for library instance not found

2019-08-23 Thread Bob Feng
not found > > BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=2099 > This is a regression issue introduced by commit e8449e. > > This patch is to fix this issue. > > Signed-off-by: Bob Feng > Cc: Liming Gao > --- > V2: We need to check if a inf is a Library or a

[edk2-devel] [Patch V2][edk2-stable201908] BaseTools: Incorrect error message for library instance not found

2019-08-21 Thread Bob Feng
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=2099 This is a regression issue introduced by commit e8449e. This patch is to fix this issue. Signed-off-by: Bob Feng Cc: Liming Gao --- V2: We need to check if a inf is a Library or a Module. BaseTools/Source/Python/AutoGen/DataPipe.py

Re: [edk2-devel] [PATCH] [edk2-stable201908] BaseTools: Support long file path in windows for misc functions

2019-08-21 Thread Bob Feng
Patch looks good. Reviewed-by: Bob Feng -Original Message- From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Steven Shi Sent: Thursday, August 22, 2019 10:44 AM To: devel@edk2.groups.io Cc: Gao, Liming ; Feng, Bob C ; Shi, Steven Subject: [edk2-devel] [PATCH

Re: [edk2-devel] [Patch][edk2-stable201908] BaseTools: Incorrect error message for library instance not found

2019-08-21 Thread Bob Feng
Subject: [Patch][edk2-stable201908] BaseTools: Incorrect error message > for library instance not found > > BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=2099 > This is a regression issue introduced by commit e8449e. > > This patch is to fix this issue. > &

[edk2-devel] [Patch][edk2-stable201908] BaseTools: Fix incremental build genmake issue

2019-08-21 Thread Bob Feng
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2090 This is a regression issue introduced by commit e8449e. This patch is going to fix this issue. Cc: Liming Gao Signed-off-by: Bob Feng --- BaseTools/Source/Python/build/build.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion

[edk2-devel] [Patch][edk2-stable201908] BaseTools: Incorrect error message for library instance not found

2019-08-21 Thread Bob Feng
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=2099 This is a regression issue introduced by commit e8449e. This patch is to fix this issue. Signed-off-by: Bob Feng Cc: Liming Gao --- BaseTools/Source/Python/AutoGen/DataPipe.py | 2 +- BaseTools/Source/Python/AutoGen

Re: [edk2-devel] [PATCH V3] [edk2-stable201908] BaseTools: Update incorrect variable name 'DataPile'

2019-08-20 Thread Bob Feng
' > >BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=2093 > >The PlatformAutoGen object has a DataPipe property but no DataPile >property So change the variable name 'DataPile' to 'DataPipe' in >BuildReport.py > >This patch is going to fix that issue. > >Cc: Liming

Re: [edk2-devel] [PATCH v6 0/5] Build cache enhancement

2019-08-20 Thread Bob Feng
Pushed at 0e7e7a264cd80ab71ea0f9e9da2d0617d4b539c4 ... 94459080c118049aba927ec0444ba5b750b7d2c9 Thanks, Bob -Original Message- From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Bob Feng Sent: Friday, August 16, 2019 12:06 PM To: Shi, Steven ; devel@edk2.groups.io

Re: [edk2-devel] [PATCH V3] [edk2-stable201908] BaseTools: Update incorrect variable name 'DataPile'

2019-08-19 Thread Bob Feng
Reviewed-by: Bob Feng -Original Message- From: Fan, ZhijuX Sent: Tuesday, August 20, 2019 8:49 AM To: devel@edk2.groups.io Cc: Gao, Liming ; Feng, Bob C Subject: [PATCH V3] [edk2-stable201908] BaseTools: Update incorrect variable name 'DataPile' BZ:https://bugzilla.tianocore.org

Re: [edk2-devel] [Patch 1/1] BaseTools: Fixed issue of incorrect Module Unique Name

2019-08-16 Thread Bob Feng
This patch is to fix a critical BaseTools regression bug and it need to be merged to edk2 master for the coming stable tag. Thanks, Bob -Original Message- From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Bob Feng Sent: Friday, August 16, 2019 2:38 PM To: devel@edk2

[edk2-devel] [Patch 1/1] BaseTools: Fixed issue of incorrect Module Unique Name

2019-08-16 Thread Bob Feng
https://bugzilla.tianocore.org/show_bug.cgi?id=2088 If there are more than one override instance for a same module, the Module Unique Name is generated incorrectly. Cc: Liming Gao Cc: Steven Shi Signed-off-by: Bob Feng --- BaseTools/Source/Python/AutoGen/ModuleAutoGen.py | 2 +- BaseTools

Re: [edk2-devel] [PATCH v6 0/5] Build cache enhancement

2019-08-15 Thread Bob Feng
For this patch set, Reviewed-by: Bob Feng -Original Message- From: Shi, Steven Sent: Thursday, August 15, 2019 10:26 PM To: devel@edk2.groups.io Cc: Gao, Liming ; Feng, Bob C ; Rodriguez, Christian ; Johnson, Michael ; ler...@redhat.com; leif.lindh...@linaro.org; af...@apple.com

Re: [edk2-devel] [PATCH v2] BaseTools/Scripts: Add GetUtcDateTime script.

2019-08-14 Thread Bob Feng
Reviewed-by: Bob Feng -Original Message- From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Chiu, Chasel Sent: Wednesday, August 14, 2019 6:21 PM To: devel@edk2.groups.io Cc: Feng, Bob C ; Gao, Liming ; Leif Lindholm Subject: [edk2-devel] [PATCH v2] BaseTools

Re: [edk2-devel] [PATCH V2 0/2] Enable Windows Firmware Update Driver Tool

2019-08-13 Thread Bob Feng
For this patch set, Reviewed-by: Bob Feng -Original Message- From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Eric Jin Sent: Monday, August 12, 2019 3:43 PM To: devel@edk2.groups.io Subject: [edk2-devel] [PATCH V2 0/2] Enable Windows Firmware Update Driver Tool REF

Re: [edk2-devel] [Patch V3] BaseTools: Fix checking for Sources section in INF file

2019-08-13 Thread Bob Feng
Reviewed-by: Bob Feng -Original Message- From: Rodriguez, Christian Sent: Monday, August 12, 2019 11:32 PM To: devel@edk2.groups.io Cc: Feng, Bob C ; Gao, Liming Subject: [Patch V3] BaseTools: Fix checking for Sources section in INF file BZ: https://bugzilla.tianocore.org

[edk2-devel] [Patch 1/1] BaseTools: Fix incremental build bug

2019-08-12 Thread Bob Feng
. This patch is to fix this issue. Cc: Liming Gao Signed-off-by: Bob Feng --- BaseTools/Source/Python/AutoGen/ModuleAutoGen.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/BaseTools/Source/Python/AutoGen/ModuleAutoGen.py b/BaseTools/Source/Python/AutoGen/ModuleAutoGen.py index

[edk2-devel] [Patch] BaseTools: Add "-" in a re to parse line in .map file

2019-08-12 Thread Bob Feng
Liming Gao Signed-off-by: Bob Feng --- BaseTools/Source/Python/Common/Misc.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/BaseTools/Source/Python/Common/Misc.py b/BaseTools/Source/Python/Common/Misc.py index 26d149c270..554ec010dd 100644 --- a/BaseTools/Source/Python/Comm

Re: [edk2-devel] [PATCH] BaseTools/Scripts: Add GetUtcDateTimer script.

2019-08-11 Thread Bob Feng
Patch looks good. Reviewed-by: Bob Feng -Original Message- From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Chiu, Chasel Sent: Thursday, August 8, 2019 8:58 PM To: devel@edk2.groups.io Cc: Feng, Bob C ; Gao, Liming Subject: [edk2-devel] [PATCH] BaseTools/Scripts

Re: [edk2-devel] [Patch 00/10 V8] Enable multiple process AutoGen

2019-08-09 Thread Bob Feng
Thanks Leif, I'll push the patches. I file a BZ https://bugzilla.tianocore.org/show_bug.cgi?id=2072 for the --hash issue. Thanks, Bob -Original Message- From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Leif Lindholm Sent: Friday, August 9, 2019 9:29 PM To: Laszlo

Re: [edk2-devel] [Patch 00/10 V8] Enable multiple process AutoGen

2019-08-09 Thread Bob Feng
Sure. Thanks Laszlo for your clarification. -Bob -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Friday, August 9, 2019 8:55 PM To: Feng, Bob C ; Gao, Liming ; devel@edk2.groups.io; leif.lindh...@linaro.org Cc: Andrew Fish ; Kinney, Michael D Subject: Re:

Re: [edk2-devel] [PATCH 0/2] Enable Windows Firmware Update Driver Tool

2019-08-09 Thread Bob Feng
Two patches looks fine for me. For both, Reviewed-by: Bob Feng -Original Message- From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Eric Jin Sent: Wednesday, August 7, 2019 5:08 PM To: devel@edk2.groups.io Subject: [edk2-devel] [PATCH 0/2] Enable Windows Firmware

Re: [edk2-devel] [Patch 00/10 V8] Enable multiple process AutoGen

2019-08-08 Thread Bob Feng
Thanks for your response. I'm going to push this patch set late today, if there is no more comments. Thanks, Bob -Original Message- From: Gao, Liming Sent: Friday, August 9, 2019 8:50 AM To: devel@edk2.groups.io; ler...@redhat.com; Feng, Bob C ; leif.lindh...@linaro.org Cc: Andrew

Re: [edk2-devel] [Patch 00/10 V8] Enable multiple process AutoGen

2019-08-08 Thread Bob Feng
, Aug 08, 2019 at 03:08:22PM +0200, Laszlo Ersek wrote: > (+ Andrew, Leif, Mike; Liming) > > On 08/07/19 06:25, Bob Feng wrote: > (3) In my normal edk2 clone, I cleaned the tree, applied your patches > (again on top of commit 96603b4f02b9), and started a build: > > $ . edks

[edk2-devel] [Patch 01/10 V8] BaseTools: Singleton the object to handle build conf file

2019-08-06 Thread Bob Feng
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1875 The build config files are target.txt, build rule, tooldef During a build, the config is not changed, so the object to handle them need to be singleton. Cc: Liming Gao Signed-off-by: Bob Feng --- BaseTools/Source/Python/AutoGen

[edk2-devel] [Patch 05/10 V8] BaseTools: Enable Multiple Process AutoGen

2019-08-06 Thread Bob Feng
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1875 Assign the Module AutoGen tasks into multiple sub process. Cc: Liming Gao Signed-off-by: Bob Feng --- .../Source/Python/AutoGen/AutoGenWorker.py| 191 ++ BaseTools/Source/Python/AutoGen/DataPipe.py | 17

[edk2-devel] [Patch 09/10 V8] BaseTools: Add the support for python 2

2019-08-06 Thread Bob Feng
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1875 python3 change the module name of Queue to queue. python3 add a new log handler of QueueHandler. This patch is to make Multiple process AutoGen feature work for python2 Cc: Liming Gao Signed-off-by: Bob Feng --- .../Source/Python

[edk2-devel] [Patch 03/10 V8] BaseTools: Add functions to get platform scope build options

2019-08-06 Thread Bob Feng
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1875 These functions are used for get platform scope build options. They will be used in later patches. Cc: Liming Gao Signed-off-by: Bob Feng --- BaseTools/Source/Python/AutoGen/AutoGen.py| 10 +- .../Source/Python/Workspace

[edk2-devel] [Patch 06/10 V8] BaseTools: Add shared data for processes

2019-08-06 Thread Bob Feng
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1875 Add shared data for autogen processes. Cc: Liming Gao Signed-off-by: Bob Feng --- BaseTools/Source/Python/AutoGen/AutoGenWorker.py | 3 ++- BaseTools/Source/Python/build/build.py | 10 ++ 2 files changed, 8 insertions

[edk2-devel] [Patch 02/10 V8] BaseTools: Split WorkspaceAutoGen._InitWorker into multiple functions

2019-08-06 Thread Bob Feng
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1875 The WorkspaceAutoGen.__InitWorker function is too long, it's hard to read and understand. This patch is to separate the __InitWorker into multiple small ones. Cc: Liming Gao Signed-off-by: Bob Feng --- BaseTools/Source/Python/AutoGen

[edk2-devel] [Patch 00/10 V8] Enable multiple process AutoGen

2019-08-06 Thread Bob Feng
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1875 In order to improve the build performance, we implemented multiple-processes AutoGen. This change will reduce 20% time for AutoGen phase. The design document can be got from:

[edk2-devel] [Patch 08/10 V8] BaseTools: Move BuildOption parser out of build.py

2019-08-06 Thread Bob Feng
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1875 Build tool supports user to specify the conf folder. To make the build options be evaluated at the beginning of launching build, extract the buildoption function from build.py to a new .py file. Signed-off-by: Bob Feng Cc: Liming Gao

[edk2-devel] [Patch 10/10 V8] BaseTools: Enable block queue log agent.

2019-08-06 Thread Bob Feng
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1875 To support Ctrl+S and Ctrl+Q, we enable block queue for log. Cc: Liming Gao Signed-off-by: Bob Feng --- .../Source/Python/AutoGen/AutoGenWorker.py| 6 ++- BaseTools/Source/Python/Common/EdkLogger.py | 10 +++-- BaseTools/Source

[edk2-devel] [Patch 07/10 V8] BaseTools: Add LogAgent to support multiple process Autogen

2019-08-06 Thread Bob Feng
-by: Bob Feng --- .../Source/Python/AutoGen/AutoGenWorker.py| 74 +-- BaseTools/Source/Python/AutoGen/DataPipe.py | 2 +- BaseTools/Source/Python/Common/EdkLogger.py | 33 - BaseTools/Source/Python/build/build.py| 27 +-- 4 files changed, 117 insertions

[edk2-devel] [Patch 03/10 V7] BaseTools: Add functions to get platform scope build options

2019-08-06 Thread Bob Feng
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1875 These functions are used for get platform scope build options. They will be used in later patches. Cc: Liming Gao Signed-off-by: Bob Feng --- BaseTools/Source/Python/AutoGen/AutoGen.py| 10 +- .../Source/Python/Workspace

[edk2-devel] [Patch 06/10 V7] BaseTools: Add shared data for processes

2019-08-06 Thread Bob Feng
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1875 Add shared data for autogen processes. Cc: Liming Gao Signed-off-by: Bob Feng --- BaseTools/Source/Python/AutoGen/AutoGenWorker.py | 3 ++- BaseTools/Source/Python/build/build.py | 10 ++ 2 files changed, 8 insertions

[edk2-devel] [Patch 01/10 V7] BaseTools: Singleton the object to handle build conf file

2019-08-06 Thread Bob Feng
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1875 The build config files are target.txt, build rule, tooldef During a build, the config is not changed, so the object to handle them need to be singleton. Cc: Liming Gao Signed-off-by: Bob Feng --- BaseTools/Source/Python/AutoGen

[edk2-devel] [Patch 09/10 V7] BaseTools: Add the support for python 2

2019-08-06 Thread Bob Feng
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1875 python3 change the module name of Queue to queue. python3 add a new log handler of QueueHandler. This patch is to make Multiple process AutoGen feature work for python2 Cc: Liming Gao Signed-off-by: Bob Feng --- .../Source/Python

[edk2-devel] [Patch 05/10 V7] BaseTools: Enable Multiple Process AutoGen

2019-08-06 Thread Bob Feng
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1875 Assign the Module AutoGen tasks into multiple sub process. Cc: Liming Gao Signed-off-by: Bob Feng --- .../Source/Python/AutoGen/AutoGenWorker.py| 191 ++ BaseTools/Source/Python/AutoGen/DataPipe.py | 17

[edk2-devel] [Patch 07/10 V7] BaseTools: Add LogAgent to support multiple process Autogen

2019-08-06 Thread Bob Feng
-by: Bob Feng --- .../Source/Python/AutoGen/AutoGenWorker.py| 74 +-- BaseTools/Source/Python/AutoGen/DataPipe.py | 2 +- BaseTools/Source/Python/Common/EdkLogger.py | 33 - BaseTools/Source/Python/build/build.py| 27 +-- 4 files changed, 117 insertions

[edk2-devel] [Patch 00/10 V7] Enable multiple process AutoGen

2019-08-06 Thread Bob Feng
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1875 In order to improve the build performance, we implemented multiple-processes AutoGen. This change will reduce 20% time for AutoGen phase. The design document can be got from:

[edk2-devel] [Patch 10/10 V7] BaseTools: Enable block queue log agent.

2019-08-06 Thread Bob Feng
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1875 To support Ctrl+S and Ctrl+Q, we enable block queue for log. Cc: Liming Gao Signed-off-by: Bob Feng --- .../Source/Python/AutoGen/AutoGenWorker.py| 6 ++- BaseTools/Source/Python/Common/EdkLogger.py | 10 +++-- BaseTools/Source

  1   2   3   >