Re: [edk2-devel] Question Using edk2-UDK2018 and VS2017
Adding the new maintainers. From: 김서진 Sent: Sunday, August 22, 2021 10:52 PM To: edk2-li...@mc2research.org; Carsey, Jaben Cc: canoni...@naver.com Subject: Question Using edk2-UDK2018 and VS2017 Dear Daryl McDaniel and Jaben Carsey, This is Seojin Kim from South Korea. Currently, I am building a program using edk2-UDK2018 and Visual Studio 2017. But it is impossible to use the program as it is without modifying it because of a few errors, so some parts were modified. Below is a description of the parts I have modified. 1. Error : c:\edk2\StdLib\Include\sys/EfiCdefs.h(342): warning C4117 > I deleted the declaration of "__STDC_HOSTED__". 2. Error : warning C4459, warning C4456 > Warnings occurred because the local variables and the global variables had > the same name, so I changed names of local variables. (c:\edk2\StdLib\EfiSocketLib\Socket.c(2980): warning C4459: 'errno' c:\edk2\StdLib\BsdSocketLib\getnetbyht.c(158): warning C4459: 'net' c:\edk2\StdLib\BsdSocketLib\ns_print.c(214): warning C4456: 't') 3. Error : unresolved external symbol "__fpclassifyd" > I added "fpclassify.c" file to define __fpclassifyd referring to > https://blog.csdn.net/humanof/article/details/118708586 (thanks to google > translation). > Also I modified LibC.inf file to add Main/fpclassify.c in [Source]. (Above description may contain some typos.. I apologize in advance.) After these modifications, I succeeded to build my package. However, I believe that your code is impeccable, so there must be something that I did wrong. I would be very grateful if you could suggest a way to solve thr above problems. Thank you, Seojin Kim -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#79773): https://edk2.groups.io/g/devel/message/79773 Mute This Topic: https://groups.io/mt/85114580/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [edk2-libc Patch] Maintainers.txt: Update maintainers for AppPkg and StdLib*
Reviewed-by: Jaben Carsey -Original Message- From: Kinney, Michael D Sent: Tuesday, August 17, 2021 8:17 AM To: devel@edk2.groups.io Cc: Rebecca Cran ; Daryl McDaniel ; Carsey, Jaben Subject: [edk2-libc Patch] Maintainers.txt: Update maintainers for AppPkg and StdLib* Cc: Rebecca Cran Cc: Daryl McDaniel Cc: Jaben Carsey Signed-off-by: Michael D Kinney --- Maintainers.txt | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Maintainers.txt b/Maintainers.txt index 4e05e8a..d0419be 100644 --- a/Maintainers.txt +++ b/Maintainers.txt @@ -60,10 +60,10 @@ EDK II Packages: AppPkg W: https://github.com/tianocore/tianocore.github.io/wiki/AppPkg -M: Daryl McDaniel -M: Jaben Carsey +M: Rebecca Cran +M: Michael D Kinney StdLib, StdLibPrivateInternalFiles W: https://github.com/tianocore/tianocore.github.io/wiki/StdLib -M: Daryl McDaniel -M: Jaben Carsey +M: Rebecca Cran +M: Michael D Kinney -- 2.32.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#79441): https://edk2.groups.io/g/devel/message/79441 Mute This Topic: https://groups.io/mt/84950066/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH V2 2/2] EdkRepo: Add support for subst drives
Instead of looping over the dictionary, could we convert the target drive and
see if it's in the dictionary?
I am thinking like remove the : from
os.path.splitdrive(workspace_dir)[0].upper() string and see if that's in the
dictionary?
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Nate
> DeSimone
> Sent: Monday, August 31, 2020 12:28 PM
> To: devel@edk2.groups.io
> Cc: Desimone, Ashley E ; Pandya, Puja
> ; Bret Barkelew ;
> Agyeman, Prince ; Bjorge, Erik C
>
> Subject: [edk2-devel] [edk2-staging/EdkRepo] [PATCH V2 2/2] EdkRepo: Add
> support for subst drives
>
> get_workspace_path() now converts a virtual drive path to a real path before
> any git repo operations are done.
>
> Cc: Ashley E Desimone
> Cc: Puja Pandya
> Cc: Bret Barkelew
> Cc: Prince Agyeman
> Cc: Erik Bjorge
> Signed-off-by: Nate DeSimone
> ---
> edkrepo/commands/clone_command.py | 6 ++
> edkrepo/config/config_factory.py | 10 +-
> 2 files changed, 15 insertions(+), 1 deletion(-)
>
> diff --git a/edkrepo/commands/clone_command.py
> b/edkrepo/commands/clone_command.py
> index f638090..be5ad86 100644
> --- a/edkrepo/commands/clone_command.py
> +++ b/edkrepo/commands/clone_command.py
> @@ -20,6 +20,7 @@ from edkrepo.common.edkrepo_exception import
> EdkrepoInvalidParametersException,
> from edkrepo.common.edkrepo_exception import
> EdkrepoManifestNotFoundException from edkrepo.common.humble
> import CLONE_INVALID_WORKSPACE, CLONE_INVALID_PROJECT_ARG,
> CLONE_INVALID_COMBO_ARG from edkrepo.common.humble import
> SPARSE_CHECKOUT, CLONE_INVALID_LOCAL_ROOTS
> +from edkrepo.common.pathfix import get_subst_drive_dict
> from edkrepo.common.workspace_maintenance.workspace_maintenance
> import case_insensitive_single_match from
> edkrepo.common.workspace_maintenance.manifest_repos_maintenance
> import pull_all_manifest_repos, find_project_in_all_indices from
> edkrepo.common.workspace_maintenance.manifest_repos_maintenance
> import list_available_manifest_repos @@ -77,6 +78,11 @@ class
> CloneCommand(EdkrepoCommand):
> workspace_dir = os.getcwd()
> else:
> workspace_dir = os.path.abspath(workspace_dir)
> +subst = get_subst_drive_dict()
> +for drive in subst.keys():
> +if '{}:'.format(drive) ==
> os.path.splitdrive(workspace_dir)[0].upper():
> +workspace_dir = os.path.join(subst[drive],
> os.path.splitdrive(workspace_dir)[1][1:])
> +workspace_dir = os.path.normpath(workspace_dir)
> if os.path.isdir(workspace_dir) and os.listdir(workspace_dir):
> raise
> EdkrepoInvalidParametersException(CLONE_INVALID_WORKSPACE)
> if not os.path.isdir(workspace_dir):
> diff --git a/edkrepo/config/config_factory.py
> b/edkrepo/config/config_factory.py
> index a82a438..1cb6eb7 100644
> --- a/edkrepo/config/config_factory.py
> +++ b/edkrepo/config/config_factory.py
> @@ -11,13 +11,16 @@ import os
> import sys
> import configparser
> import collections
> -from ctypes import *
> +if sys.platform == "win32":
> +from ctypes import oledll, c_void_p, c_uint32, c_wchar_p
> +from ctypes import create_unicode_buffer
>
> import edkrepo.config.humble.config_factory_humble as humble from
> edkrepo.common.edkrepo_exception import
> EdkrepoGlobalConfigNotFoundException, EdkrepoConfigFileInvalidException
> from edkrepo.common.edkrepo_exception import
> EdkrepoWorkspaceInvalidException,
> EdkrepoGlobalDataDirectoryNotFoundException
> from edkrepo.common.edkrepo_exception import
> EdkrepoConfigFileReadOnlyException
> from edkrepo.common.humble import
> MIRROR_PRIMARY_REPOS_MISSING, MIRROR_DECODE_WARNING,
> MAX_PATCH_SET_INVALID
> +from edkrepo.common.pathfix import get_subst_drive_dict
> from edkrepo_manifest_parser import edk_manifest from
> edkrepo.common.pathfix import expanduser
>
> @@ -238,6 +241,11 @@ def get_workspace_path():
> while True:
> if os.path.isdir(os.path.join(path, "repo")):
> if os.path.isfile(os.path.join(os.path.join(path, "repo"),
> "Manifest.xml")):
> +if sys.platform == "win32":
> +subst = get_subst_drive_dict()
> +for drive in subst.keys():
> +if '{}:'.format(drive) ==
> os.path.splitdrive(path)[0].upper():
> +path = os.path.join(subst[drive],
> + os.path.splitdrive(path)[1][1:])
> return path
> if os.path.dirname(path) == path:
> break
> --
> 2.27.0.windows.1
>
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#64923): https://edk2.groups.io/g/devel/message/64923
Mute This Topic: https://groups.io/mt/76541439/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [Patch] BaseTools: Move CreateAsBuiltInf into AutoGenWorker for parallel
Reviewed-by: Jaben Carsey
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Bob
> Feng
> Sent: Tuesday, August 11, 2020 11:09 PM
> To: devel@edk2.groups.io
> Cc: Gao, Liming ; Chen, Christine
>
> Subject: [edk2-devel] [Patch] BaseTools: Move CreateAsBuiltInf into
> AutoGenWorker for parallel
>
> AsBuiltInf can be created during AutoGen phase. Move CreateAsBuiltInf into
> AutoGenWorker to make this step run in parallel.
>
> Signed-off-by: Bob Feng
> Cc: Liming Gao
> Cc: Yuwei Chen
> ---
> BaseTools/Source/Python/AutoGen/AutoGenWorker.py | 2 +-
> BaseTools/Source/Python/build/build.py | 4 +---
> 2 files changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/BaseTools/Source/Python/AutoGen/AutoGenWorker.py
> b/BaseTools/Source/Python/AutoGen/AutoGenWorker.py
> index 017f676399..0425f1ab0b 100755
> --- a/BaseTools/Source/Python/AutoGen/AutoGenWorker.py
> +++ b/BaseTools/Source/Python/AutoGen/AutoGenWorker.py
> @@ -278,11 +278,11 @@ class AutoGenWorkerInProcess(mp.Process):
> else:
> self.cache_q.put((Ma.MetaFile.Path, Ma.Arch,
> "PreMakeCache", False))
>
> Ma.CreateCodeFile(False)
>
> Ma.CreateMakeFile(False,GenFfsList=FfsCmd.get((Ma.MetaFile.Path,
> Ma.Arch),[]))
> -
> +Ma.CreateAsBuiltInf()
> if GlobalData.gBinCacheSource and CommandTarget in [None, "",
> "all"]:
> try:
> CacheResult = Ma.CanSkipbyMakeCache()
> except:
> CacheResult = False diff --git
> a/BaseTools/Source/Python/build/build.py
> b/BaseTools/Source/Python/build/build.py
> index 59ceacfed0..c4cfe38ad9 100755
> --- a/BaseTools/Source/Python/build/build.py
> +++ b/BaseTools/Source/Python/build/build.py
> @@ -871,11 +871,11 @@ class Build():
> if GlobalData.gUseHashCache and not
> GlobalData.gBinCacheDest
> and self.Target in [None, "", "all"]:
> cqueue.put((PcdMa.MetaFile.Path, PcdMa.Arch,
> "PreMakeCache", False))
>
> PcdMa.CreateCodeFile(False)
> PcdMa.CreateMakeFile(False,GenFfsList =
> DataPipe.Get("FfsCommand").get((PcdMa.MetaFile.Path, PcdMa.Arch),[]))
> -
> +PcdMa.CreateAsBuiltInf()
> # Force cache miss for PCD driver
> if GlobalData.gBinCacheSource and self.Target in [None,
> "", "all"]:
> cqueue.put((PcdMa.MetaFile.Path, PcdMa.Arch,
> "MakeCache",
> False))
>
> self.AutoGenMgr.join()
> @@ -1263,11 +1263,10 @@ class Build():
>
> # build modules
> if BuildModule:
> BuildCommand = BuildCommand + [Target]
> LaunchCommand(BuildCommand, AutoGenObject.MakeFileDir)
> -self.CreateAsBuiltInf()
> if GlobalData.gBinCacheDest:
> self.GenDestCache()
> elif GlobalData.gUseHashCache and not GlobalData.gBinCacheSource:
> # Only for --hash
> # Update PreMakeCacheChain files @@ -2274,11 +2273,10 @@
> class
> Build():
> # All modules have been put in build tasks queue. Tell task
> scheduler
> # to exit if all tasks are completed
> #
> ExitFlag.set()
> BuildTask.WaitForComplete()
> -self.CreateAsBuiltInf()
> if GlobalData.gBinCacheDest:
> self.GenDestCache()
> elif GlobalData.gUseHashCache and not
> GlobalData.gBinCacheSource:
> # Only for --hash
> # Update PreMakeCacheChain files
> --
> 2.20.1.windows.1
>
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#64124): https://edk2.groups.io/g/devel/message/64124
Mute This Topic: https://groups.io/mt/76142326/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v5 03/12] OvmfPkg/MptScsiDxe: Report name of driver
I don't remember reviewing this previously (not recently at least), maybe the
RB should be CC?
One comment inline below.
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Nikita
> Leshenko
> Sent: Friday, April 24, 2020 10:59 AM
> To: devel@edk2.groups.io
> Cc: Nikita Leshenko ;
> liran.a...@oracle.com; aaron.yo...@oracle.com; Justen, Jordan L
> ; Laszlo Ersek ; Ard
> Biesheuvel ; Carsey, Jaben
>
> Subject: [edk2-devel] [PATCH v5 03/12] OvmfPkg/MptScsiDxe: Report name
> of driver
>
> Install Component Name protocols to have a nice display name for the driver
> in places such as UEFI shell.
>
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2390
> Signed-off-by: Nikita Leshenko
> Reviewed-by: Laszlo Ersek
> Reviewed-by: Jaben Carsey
> Reviewed-by: Liran Alon
> ---
> OvmfPkg/MptScsiDxe/MptScsi.c | 61
> ++--
> 1 file changed, 59 insertions(+), 2 deletions(-)
>
> diff --git a/OvmfPkg/MptScsiDxe/MptScsi.c b/OvmfPkg/MptScsiDxe/MptScsi.c
> index 581d3909b84d..64949a809022 100644
> --- a/OvmfPkg/MptScsiDxe/MptScsi.c
> +++ b/OvmfPkg/MptScsiDxe/MptScsi.c
> @@ -69,6 +69,63 @@ EFI_DRIVER_BINDING_PROTOCOL
> mMptScsiDriverBinding = {
>NULL, // DriverBindingHandle, filled as well };
>
> +//
> +// Component Name
> +//
> +
> +STATIC
> +EFI_UNICODE_STRING_TABLE mDriverNameTable[] = {
> + { "eng;en", L"LSI Fusion MPT SCSI Driver" },
> + { NULL, NULL }
> +};
> +
> +STATIC
> +EFI_COMPONENT_NAME_PROTOCOL mComponentName;
> +
> +EFI_STATUS
> +EFIAPI
> +MptScsiGetDriverName (
> + IN EFI_COMPONENT_NAME_PROTOCOL *This,
> + IN CHAR8 *Language,
> + OUT CHAR16 **DriverName
> + )
> +{
> + return LookupUnicodeString2 (
> + Language,
> + This->SupportedLanguages,
> + mDriverNameTable,
> + DriverName,
> + (BOOLEAN)(This == ) // Iso639Language
> + );
> +}
> +
> +EFI_STATUS
> +EFIAPI
> +MptScsiGetDeviceName (
> + IN EFI_COMPONENT_NAME_PROTOCOL *This,
> + IN EFI_HANDLE DeviceHandle,
> + IN EFI_HANDLE ChildHandle,
> + IN CHAR8 *Language,
> + OUT CHAR16 **ControllerName
> + )
> +{
> + return EFI_UNSUPPORTED;
> +}
> +
> +STATIC
> +EFI_COMPONENT_NAME_PROTOCOL mComponentName = {
> + ,
> + ,
> + "eng" // SupportedLanguages, ISO 639-2 language codes };
> +
> +STATIC
> +EFI_COMPONENT_NAME2_PROTOCOL mComponentName2 = {
> + (EFI_COMPONENT_NAME2_GET_DRIVER_NAME)
> ,
> + (EFI_COMPONENT_NAME2_GET_CONTROLLER_NAME)
> ,
> + "en" // SupportedLanguages, RFC 4646 language codes };
I think that the }; needs to be outside of the comment for both of these
structures.
> +
> //
> // Entry Point
> //
> @@ -85,7 +142,7 @@ MptScsiEntryPoint (
> SystemTable,
> ,
> ImageHandle, // The handle to install onto
> - NULL, // TODO Component name
> - NULL // TODO Component name
> + ,
> +
> );
> }
> --
> 2.20.1
>
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#58094): https://edk2.groups.io/g/devel/message/58094
Mute This Topic: https://groups.io/mt/73247263/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] Shell feature?
That makes sense. So really what we are missing is a method to associate a file with a command (required to support dynamic commands). We could do that in lots of ways, but the first I think of is to add a new API in the ShellProtocol to perform this association. Do we also need a shell command for a user to view/edit the file associations? Do associations need to maintain over a reboot? -Jaben > -Original Message- > From: devel@edk2.groups.io On Behalf Of Andrew > Fish via Groups.Io > Sent: Tuesday, February 11, 2020 6:08 PM > To: Carsey, Jaben > Cc: devel@edk2.groups.io; jim.dai...@dell.com; tim.le...@insyde.com > Subject: Re: [edk2-devel] Shell feature? > > Jaben, > > My example was confusing, but my use case was to put this code in a library > that adds a command. So after I register the command I’d like to register the > file type to be processed by it. > > Making an alias for an external command could be a different feature? > > On Feb 11, 2020, at 5:30 PM, Carsey, Jaben > wrote: > > > > Andrew > > > > You can already add a command via a driver (including a driver's library). > Check into the Dynamic Commands in the shell spec. > > > > Associating a file type with a command, basically if the first thing on the > command line is a file of that type, then prepend the command and re- > process the line, is very doable. It's almost like the alias feature that > already > exists. > > > > I do agree with Tim that we should do a spec update, but concurrent > development of code and spec seems required to prevent re-doing the spec. > > > > -Jaben > > > >> -Original Message- > >> From: devel@edk2.groups.io On Behalf Of Jim > >> Dailey > >> Sent: Tuesday, February 11, 2020 1:31 PM > >> To: devel@edk2.groups.io > >> Cc: tim.le...@insyde.com; af...@apple.com > >> Subject: Re: [edk2-devel] Shell feature? > >> > >> Andrew, > >> > >> Granted such a feature would be nice, but it seems like it might be a > >> fair amount of trouble just to avoid typing "python3", which could be > >> aliased to something as short a "p". > >> > >> Jim > >> > >> -Original Message- > >> From: devel@edk2.groups.io On Behalf Of Tim > >> Lewis > >> Sent: Tuesday, February 11, 2020 2:28 PM > >> To: devel@edk2.groups.io; af...@apple.com > >> Subject: Re: [edk2-devel] Shell feature? > >> > >> > >> [EXTERNAL EMAIL] > >> > >> Andrew -- > >> > >> I think this is a good idea, but I think this is probably a shell > >> spec issue because I don't want competing, incompatible > implementations. > >> > >> A few other issues: I think there is a persistence issue (similar to > >> shell > >> variables) so that the change could be installed and survive a > >> reboot. I also think there can be a simple shell command that manages > >> extensions (so that they can be installed by a script) > >> > >> Tim > >> > >> -Original Message- > >> From: devel@edk2.groups.io On Behalf Of > Andrew > >> Fish via Groups.Io > >> Sent: Monday, February 10, 2020 12:12 PM > >> To: devel@edk2.groups.io > >> Subject: [edk2-devel] Shell feature? > >> > >> I wanted to start a conversation on the mailing list prior to writing > >> up a BZ, to make sure I'm not missing anything, or in case there is a > >> better way to implement this. > >> > >> I was thinking it would be good to have a Shell API that lets you > >> associate a file type with an internal or external shell command. The > >> Idea would be to pre-pend the internal/external shell command to the > >> file name and also pass the arguments. > >> > >> So this: > >> fs0:>dump.py 1 2 3 > >> > >> Becomes: > >> fs0:>python3.efi dump.py 1 2 3 > >> > >> Basically you just need an API like: > >> > >> ShellAddScriptingLanguage (L".py", L"python3.efi"); > >> > >> Seems like this could just plug into the Shell via a ShellExecute(). > >> So for example you could make Python a UEFI Shell command via a > >> library and that library constructor could also teach the shell that > >> a .py file could be an executable? > >> > >> Thanks, > >> > >> Andrew Fish > >> > >> > >> > >> > >> > >> > >> > >> > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#54255): https://edk2.groups.io/g/devel/message/54255 Mute This Topic: https://groups.io/mt/71147932/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] Shell feature?
Andrew You can already add a command via a driver (including a driver's library). Check into the Dynamic Commands in the shell spec. Associating a file type with a command, basically if the first thing on the command line is a file of that type, then prepend the command and re-process the line, is very doable. It's almost like the alias feature that already exists. I do agree with Tim that we should do a spec update, but concurrent development of code and spec seems required to prevent re-doing the spec. -Jaben > -Original Message- > From: devel@edk2.groups.io On Behalf Of Jim > Dailey > Sent: Tuesday, February 11, 2020 1:31 PM > To: devel@edk2.groups.io > Cc: tim.le...@insyde.com; af...@apple.com > Subject: Re: [edk2-devel] Shell feature? > > Andrew, > > Granted such a feature would be nice, but it seems like it might be a fair > amount of trouble just to avoid typing "python3", which could be aliased to > something as short a "p". > > Jim > > -Original Message- > From: devel@edk2.groups.io On Behalf Of Tim > Lewis > Sent: Tuesday, February 11, 2020 2:28 PM > To: devel@edk2.groups.io; af...@apple.com > Subject: Re: [edk2-devel] Shell feature? > > > [EXTERNAL EMAIL] > > Andrew -- > > I think this is a good idea, but I think this is probably a shell spec issue > because I don't want competing, incompatible implementations. > > A few other issues: I think there is a persistence issue (similar to shell > variables) so that the change could be installed and survive a reboot. I also > think there can be a simple shell command that manages extensions (so that > they can be installed by a script) > > Tim > > -Original Message- > From: devel@edk2.groups.io On Behalf Of Andrew > Fish via Groups.Io > Sent: Monday, February 10, 2020 12:12 PM > To: devel@edk2.groups.io > Subject: [edk2-devel] Shell feature? > > I wanted to start a conversation on the mailing list prior to writing up a > BZ, to > make sure I'm not missing anything, or in case there is a better way to > implement this. > > I was thinking it would be good to have a Shell API that lets you associate a > file type with an internal or external shell command. The Idea would be to > pre-pend the internal/external shell command to the file name and also pass > the arguments. > > So this: > fs0:>dump.py 1 2 3 > > Becomes: > fs0:>python3.efi dump.py 1 2 3 > > Basically you just need an API like: > > ShellAddScriptingLanguage (L".py", L"python3.efi"); > > Seems like this could just plug into the Shell via a ShellExecute(). So for > example you could make Python a UEFI Shell command via a library and that > library constructor could also teach the shell that a .py file could be an > executable? > > Thanks, > > Andrew Fish > > > > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#54241): https://edk2.groups.io/g/devel/message/54241 Mute This Topic: https://groups.io/mt/71147932/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v5 3/3] ShellPkg/UefiShellDebug1CommandsLib: Update to support SmBios 3.3.0
Reviewed-by: Jaben Carsey
Thanks
-Jaben
> -Original Message-
> From: Abner Chang [mailto:abner.ch...@hpe.com]
> Sent: Tuesday, October 08, 2019 1:04 AM
> To: devel@edk2.groups.io
> Cc: abner.ch...@hpe.com; Carsey, Jaben ; Ni,
> Ray ; Gao, Zhichao ; Leif
> Lindholm ; Gilbert Chen
> Subject: [PATCH v5 3/3] ShellPkg/UefiShellDebug1CommandsLib: Update to
> support SmBios 3.3.0
>
> Shell command smbiosview updates for SMBIOS 3.3.0 spec.
>
> Bugzilla link,
> https://bugzilla.tianocore.org/show_bug.cgi?id=2202
>
> Signed-off-by: Abner Chang
>
> Cc: Jaben Carsey
> Cc: Ray Ni
> Cc: Zhichao Gao
> Cc: Leif Lindholm
> Cc: Gilbert Chen
> ---
> .../SmbiosView/PrintInfo.c | 23 +++-
> .../SmbiosView/PrintInfo.h | 13 -
> .../SmbiosView/QueryTable.c| 63
> +-
> .../UefiShellDebug1CommandsLib.uni | 3 +-
> 4 files changed, 98 insertions(+), 4 deletions(-)
>
> diff --git
> a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
> b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
> index cfd7a2b..ff0c1db 100644
> ---
> a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
> +++
> b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
> @@ -3,7 +3,7 @@
>
>Copyright (c) 2005 - 2018, Intel Corporation. All rights reserved.
>(C) Copyright 2014 Hewlett-Packard Development Company, L.P.
> - (C) Copyright 2015-2017 Hewlett Packard Enterprise Development LP
> + (C) Copyright 2015-2019 Hewlett Packard Enterprise Development LP
>SPDX-License-Identifier: BSD-2-Clause-Patent
>
> **/
> @@ -1169,6 +1169,15 @@ SmbiosPrintStructure (
> break;
>
>//
> + // Processor Additional Information (Type 44)
> + //
> + case 44:
> +PRINT_STRUCT_VALUE_H (Struct, Type44, RefHandle);
> +PRINT_STRUCT_VALUE_H (Struct, Type44,
> ProcessorSpecificBlock.ProcessorArchType);
> +ProcessorArchitectureType (Struct->Type44-
> >ProcessorSpecificBlock.ProcessorArchType, Option);
> +break;
> +
> + //
>// Inactive (Type 126)
>//
>case 126:
> @@ -2350,6 +2359,18 @@ DisplayProcessorFamily2 (
>Print (L"Video Processor\n");
>break;
>
> +case 0x200:
> + Print (L"RISC-V RV32\n");
> + break;
> +
> +case 0x201:
> + Print (L"RISC-V RV64\n");
> + break;
> +
> +case 0x202:
> + Print (L"RISC-V RV128\n");
> + break;
> +
> default:
> ShellPrintHiiEx(-1,-1,NULL,STRING_TOKEN
> (STR_SMBIOSVIEW_PRINTINFO_UNDEFINED_PROC_FAMILY),
> gShellDebug1HiiHandle);
>}
> diff --git
> a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.h
> b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.h
> index a8c32ab..22f59d6 100644
> ---
> a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.h
> +++
> b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.h
> @@ -2,7 +2,7 @@
>Module to clarify the element info of the smbios structure.
>
>Copyright (c) 2005 - 2015, Intel Corporation. All rights reserved.
> - (C) Copyright 2017 Hewlett Packard Enterprise Development LP
> + (C) Copyright 2017 - 2019 Hewlett Packard Enterprise Development LP
>SPDX-License-Identifier: BSD-2-Clause-Patent
>
> **/
> @@ -427,4 +427,15 @@ DisplayTpmDeviceCharacteristics (
>IN UINT8 Option
>);
>
> +/**
> + Display Processor Architecture Type (Type 44).
> +
> + @param[in] Type The key of the structure.
> + @param[in] Option The optional information.
> +**/
> +VOID
> +ProcessorArchitectureType (
> + IN UINT8 Type,
> + IN UINT8 Option
> + );
> #endif
> diff --git
> a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.
> c
> b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.
> c
> index bfb7c3b..54e9a52 100644
> ---
> a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.
> c
> +++
> b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.
> c
> @@ -3,7 +3,7 @@
>And give a interface of query a string out of a table.
>
>Copyright (c) 2005 - 2018, Intel Corporation. All rights reserved.
> - (C) Copyright 2016-2017 Hewlett Packard Enterprise Development LP
> + (C) Copyright 2016-2019 Hewlett Packard Enterprise Development LP
>SPDX-License-Identifier: BSD-2-Clause-Patent
>
> **/
> @@ -620,6 +620,10 @@ TABLE_ITEM ProcessorCharacteristicsTable[] = {
>{
&
Re: [edk2-devel] [PATCH 32/35] ShellPkg/UefiShellLib: clarify workaround for unfixable EdkShell bug
Reviewed-by: Jaben Carsey
Given the time gap between now and when this library was originally written, I
think that we should revisit maintaining support for EFI Shell. Do we still
need to have UEFI Applications that can go between EFI and UEFI versions of the
shell? Are there really many EFI Shell instances that currently developed
applications need to maintain support for?
Thanks
-Jaben
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Thursday, September 26, 2019 5:47 AM
> To: Carsey, Jaben ; Ni, Ray ;
> Gao, Zhichao
> Cc: edk2-devel-groups-io
> Subject: Re: [edk2-devel] [PATCH 32/35] ShellPkg/UefiShellLib: clarify
> workaround for unfixable EdkShell bug
>
> Jaben, Ray, Zhichao,
>
> can one of you guys please review this patch?
>
> Thanks
> Laszlo
>
> On 09/17/19 21:49, Laszlo Ersek wrote:
> > The EDK 1 Shell (available at <https://github.com/tianocore/edk-Shell>)
> > has a bug in its EFI_SHELL_ENVIRONMENT2.Execute() implementation that
> > edk2's UefiShellLib has no choice but to work around.
> >
> > Improve the explanation in the code. Also, document the implicit
> > EFI_HANDLE -> (EFI_HANDLE*) conversion, which happens implicitly after
> > dereferencing ParentHandle, with an explicit cast.
> >
> > In practice, this patch is a no-op.
> >
> > Cc: Jaben Carsey
> > Cc: Ray Ni
> > Cc: Zhichao Gao
> > Signed-off-by: Laszlo Ersek
> > ---
> >
> > Notes:
> > build-tested only
> >
> > ShellPkg/Library/UefiShellLib/UefiShellLib.c | 22 ++--
> > 1 file changed, 20 insertions(+), 2 deletions(-)
> >
> > diff --git a/ShellPkg/Library/UefiShellLib/UefiShellLib.c
> b/ShellPkg/Library/UefiShellLib/UefiShellLib.c
> > index 835d0f88ca74..9f07a58eb23d 100644
> > --- a/ShellPkg/Library/UefiShellLib/UefiShellLib.c
> > +++ b/ShellPkg/Library/UefiShellLib/UefiShellLib.c
> > @@ -1291,9 +1291,27 @@ ShellExecute (
> >if (mEfiShellEnvironment2 != NULL) {
> > //
> > // Call EFI Shell version.
> > -// Due to oddity in the EFI shell we want to dereference the
> ParentHandle here
> > //
> > -CmdStatus = (mEfiShellEnvironment2->Execute(*ParentHandle,
> > +// Due to an unfixable bug in the EdkShell implementation, we must
> > +// dereference "ParentHandle" here:
> > +//
> > +// 1. The EFI shell installs the EFI_SHELL_ENVIRONMENT2 protocol,
> > +//identified by gEfiShellEnvironment2Guid.
> > +// 2. The Execute() member function takes "ParentImageHandle" as
> first
> > +//parameter, with type (EFI_HANDLE*).
> > +// 3. In the EdkShell implementation, SEnvExecute() implements the
> > +//Execute() member function. It passes "ParentImageHandle"
> correctly to
> > +//SEnvDoExecute().
> > +// 4. SEnvDoExecute() takes the (EFI_HANDLE*), and passes it directly
> > --
> > +//without de-referencing -- to the HandleProtocol() boot service.
> > +// 5. But HandleProtocol() takes an EFI_HANDLE.
> > +//
> > +// Therefore we must
> > +// - de-reference "ParentHandle" here, to mask the bug in
> > +// SEnvDoExecute(), and
> > +// - pass the resultant EFI_HANDLE as an (EFI_HANDLE*).
> > +//
> > +CmdStatus = (mEfiShellEnvironment2->Execute((EFI_HANDLE
> *)*ParentHandle,
> >CommandLine,
> >Output));
> > //
> >
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#48120): https://edk2.groups.io/g/devel/message/48120
Mute This Topic: https://groups.io/mt/34180236/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH 31/35] ShellPkg/UefiShellDebug1CommandsLib: fix ShellCloseFile() call
Reviewed-by: Jaben Carsey
Thanks
-Jaben
> -Original Message-
> From: Philippe Mathieu-Daudé [mailto:phi...@redhat.com]
> Sent: Monday, September 23, 2019 3:01 AM
> To: devel@edk2.groups.io; ler...@redhat.com
> Cc: Carsey, Jaben ; Ni, Ray ;
> Gao, Zhichao
> Subject: Re: [edk2-devel] [PATCH 31/35]
> ShellPkg/UefiShellDebug1CommandsLib: fix ShellCloseFile() call
>
> On 9/17/19 9:49 PM, Laszlo Ersek wrote:
> > In the FileBufferSave() function, we invoke ShellCloseFile() if "Directory
> > Can Not Be Saved".
> >
> > The ShellCloseFile() function takes a (SHELL_FILE_HANDLE*) parameter
> > called "FileHandle", and correctly passes the de-referenced (*FileHandle)
> > to EFI_SHELL_CLOSE_FILE, which takes a SHELL_FILE_HANDLE.
> >
> > However, FileBufferSave() passes SHELL_FILE_HANDLE to ShellCloseFile(),
> > not the expected (SHELL_FILE_HANDLE*). Correct it.
> >
> > This fixes an actual bug that has remained hidden for two reasons:
> >
> > - pointer-to-VOID converts from/to any pointer-to-object type silently,
> > - the bug is on an error path which has likely never fired in practice.
> >
> > Cc: Jaben Carsey
> > Cc: Ray Ni
> > Cc: Zhichao Gao
> > Signed-off-by: Laszlo Ersek
> > ---
> >
> > Notes:
> > tested: edit (saving a file)
> >
> > ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/FileBuffer.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git
> a/ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/FileBuffer.c
> b/ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/FileBuffer.c
> > index 464f9de38e52..fd324cc4a861 100644
> > --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/FileBuffer.c
> > +++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/FileBuffer.c
> > @@ -1462,7 +1462,7 @@ FileBufferSave (
> >
> > if (Info != NULL && Info->Attribute & EFI_FILE_DIRECTORY) {
> >StatusBarSetStatusString (L"Directory Can Not Be Saved");
> > - ShellCloseFile(FileHandle);
> > + ShellCloseFile ();
> >FreePool(Info);
> >return EFI_LOAD_ERROR;
> > }
> >
>
> Reviewed-by: Philippe Mathieu-Daude
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#47853): https://edk2.groups.io/g/devel/message/47853
Mute This Topic: https://groups.io/mt/34180234/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
[edk2-devel] [Patch v1] Maintainers.txt update for ShellPkg
removing myself from maintainer promoting Zhichao Cc: Ray Ni Cc: Zhichao Gao Cc: Mike Kinney Signed-off-by: Jaben Carsey --- Maintainers.txt | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/Maintainers.txt b/Maintainers.txt index 919baccc56..1dcc6c64ed 100644 --- a/Maintainers.txt +++ b/Maintainers.txt @@ -418,14 +418,13 @@ R: Chao Zhang ShellPkg F: ShellPkg/ W: https://github.com/tianocore/tianocore.github.io/wiki/ShellPkg -M: Jaben Carsey M: Ray Ni -R: Zhichao Gao +M: Zhichao Gao Maintainers for stable Shell binaries generation when need to publish Shell binaries with edk2 release: -M: Jaben Carsey (Ia32/X64) M: Ray Ni (Ia32/X64) +M: Zhichao Gao (Ia32/X64) M: Leif Lindholm(ARM/AArch64) M: Ard Biesheuvel (ARM/AArch64) -- 2.16.2.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#46175): https://edk2.groups.io/g/devel/message/46175 Mute This Topic: https://groups.io/mt/32982909/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH V2] ShellPkg/UefiShellDriver1CommandsLib: Make array big enough
Reviewed-by: Jaben Carsey Thanks -Jaben > -Original Message- > From: Augustine, Linson > Sent: Wednesday, August 14, 2019 1:41 AM > To: Gao, Zhichao ; devel@edk2.groups.io > Cc: Carsey, Jaben ; Ni, Ray ; > oleks...@ami.com > Subject: RE: [edk2-devel] [PATCH V2] > ShellPkg/UefiShellDriver1CommandsLib: Make array big enough > > Reviewed-by: Linson Augustine > > Regards, > -Linson > > -Original Message- > From: Gao, Zhichao > Sent: Wednesday, August 14, 2019 2:03 PM > To: devel@edk2.groups.io; Gao, Zhichao > Cc: Carsey, Jaben ; Ni, Ray ; > oleks...@ami.com; Augustine, Linson > Subject: RE: [edk2-devel] [PATCH V2] > ShellPkg/UefiShellDriver1CommandsLib: Make array big enough > > Ping again. > > Thanks, > Zhichao > > > -Original Message- > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > > Gao, Zhichao > > Sent: Friday, July 26, 2019 3:47 PM > > To: devel@edk2.groups.io > > Cc: Carsey, Jaben ; Ni, Ray > > ; oleks...@ami.com > > Subject: FW: [edk2-devel] [PATCH V2] > > ShellPkg/UefiShellDriver1CommandsLib: Make array big enough > > > > Ping. Please help to review it. > > > > Thanks, > > Zhichao > > > > -Original Message----- > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > > Gao, Zhichao > > Sent: Monday, July 22, 2019 2:58 PM > > To: devel@edk2.groups.io > > Cc: Carsey, Jaben ; Ni, Ray > > ; Oleksiy > > Subject: [edk2-devel] [PATCH V2] ShellPkg/UefiShellDriver1CommandsLib: > > Make array big enough > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1941 > > > > The two CHAR16 array ChildCountStr and DeviceCountStr is defined to > > hold the decimal string data of UINTN. The max of UINTN is > > 18446744073709551615 and it contain 20 characters. > > So make their size to 21 CHAR16s to hold the string data with a null- > > terminate. > > UnicodeValueToStringS regard the value input as INT64, and > > 21 CHARs is enough to hold the lowest value with minus '-'. > > Although the value shouldn't be such big. > > > > Cc: Jaben Carsey > > Cc: Ray Ni > > Cc: Oleksiy > > Signed-off-by: Zhichao Gao > > --- > > > > V2: > > Update the copyright. > > > > ShellPkg/Library/UefiShellDriver1CommandsLib/Drivers.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/ShellPkg/Library/UefiShellDriver1CommandsLib/Drivers.c > > b/ShellPkg/Library/UefiShellDriver1CommandsLib/Drivers.c > > index 794b737bd1..27cd278cf0 100644 > > --- a/ShellPkg/Library/UefiShellDriver1CommandsLib/Drivers.c > > +++ b/ShellPkg/Library/UefiShellDriver1CommandsLib/Drivers.c > > @@ -2,7 +2,7 @@ > >Main file for Drivers shell Driver1 function. > > > >(C) Copyright 2012-2015 Hewlett-Packard Development Company, > > L.P. > > - Copyright (c) 2010 - 2018, Intel Corporation. All rights > > reserved. > > + Copyright (c) 2010 - 2019, Intel Corporation. All rights > > + reserved. > >SPDX-License-Identifier: BSD-2-Clause-Patent > > > > **/ > > @@ -263,8 +263,8 @@ ShellCommandRunDrivers ( > >EFI_HANDLE *HandleWalker; > >UINTN ChildCount; > >UINTN DeviceCount; > > - CHAR16 ChildCountStr[3]; > > - CHAR16 DeviceCountStr[3]; > > + CHAR16 ChildCountStr[21]; > > + CHAR16 DeviceCountStr[21]; > >CHAR16 *Temp2; > >CONST CHAR16*FullDriverName; > >CHAR16 *TruncatedDriverName; > > -- > > 2.21.0.windows.1 > > > > > > > > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#45613): https://edk2.groups.io/g/devel/message/45613 Mute This Topic: https://groups.io/mt/32861764/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH 1/1] ShellPkg/UefiShellAcpiViewCommandLib: Remove the variable "Index"
Reviewed-by: Jaben Carsey
Thanks
-Jaben
> -Original Message-
> From: Gao, Zhichao
> Sent: Tuesday, August 13, 2019 8:37 PM
> To: Zhang, Shenglei ; devel@edk2.groups.io
> Cc: Carsey, Jaben ; Ni, Ray
> Subject: RE: [PATCH 1/1] ShellPkg/UefiShellAcpiViewCommandLib: Remove
> the variable "Index"
>
> Reviewed-by: Zhichao Gao
>
> Thanks,
> Zhichao
>
> > -Original Message-
> > From: Zhang, Shenglei
> > Sent: Wednesday, August 14, 2019 11:07 AM
> > To: devel@edk2.groups.io
> > Cc: Carsey, Jaben ; Ni, Ray ;
> > Gao, Zhichao
> > Subject: [PATCH 1/1] ShellPkg/UefiShellAcpiViewCommandLib: Remove
> the
> > variable "Index"
> >
> > In IortParser.c ,the variable Index is set but not used in function
> > DumpIortNodeNamedComponent. This will cause build failure when
> building
> > ShellPkg with GCC.
> >
> > Cc: Jaben Carsey
> > Cc: Ray Ni
> > Cc: Zhichao Gao
> > Signed-off-by: Shenglei Zhang
> > ---
> > .../UefiShellAcpiViewCommandLib/Parsers/Iort/IortParser.c | 2 --
> > 1 file changed, 2 deletions(-)
> >
> > diff --git
> >
> a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Iort/IortParser.c
> >
> b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Iort/IortParser.c
> > index 8912d415a755..f1cdb9ac01d8 100644
> > ---
> >
> a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Iort/IortParser.c
> > +++
> b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Iort/IortPars
> > +++ er.c
> > @@ -472,7 +472,6 @@ DumpIortNodeNamedComponent (
> >)
> > {
> >UINT32 Offset;
> > - UINT32 Index;
> >
> >Offset = ParseAcpi (
> > TRUE,
> > @@ -485,7 +484,6 @@ DumpIortNodeNamedComponent (
> >
> >// Estimate the Device Name length
> >PrintFieldName (2, L"Device Object Name");
> > - Index = 0;
> >
> >while ((*(Ptr + Offset) != 0) &&
> > (Offset < Length)) {
> > --
> > 2.18.0.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#45612): https://edk2.groups.io/g/devel/message/45612
Mute This Topic: https://groups.io/mt/32860379/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
[edk2-devel] [Patch v1] ShellPkg: update drivers command for more children
this allows for > 99 children Cc: ray ni Cc: linson augustine Cc: zhichao gao Signed-off-by: Jaben Carsey --- ShellPkg/Library/UefiShellDriver1CommandsLib/Drivers.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/ShellPkg/Library/UefiShellDriver1CommandsLib/Drivers.c b/ShellPkg/Library/UefiShellDriver1CommandsLib/Drivers.c index 794b737bd1..7d45f2fc40 100644 --- a/ShellPkg/Library/UefiShellDriver1CommandsLib/Drivers.c +++ b/ShellPkg/Library/UefiShellDriver1CommandsLib/Drivers.c @@ -2,7 +2,7 @@ Main file for Drivers shell Driver1 function. (C) Copyright 2012-2015 Hewlett-Packard Development Company, L.P. - Copyright (c) 2010 - 2018, Intel Corporation. All rights reserved. + Copyright (c) 2010 - 2019, Intel Corporation. All rights reserved. SPDX-License-Identifier: BSD-2-Clause-Patent **/ @@ -263,8 +263,8 @@ ShellCommandRunDrivers ( EFI_HANDLE *HandleWalker; UINTN ChildCount; UINTN DeviceCount; - CHAR16 ChildCountStr[3]; - CHAR16 DeviceCountStr[3]; + CHAR16 ChildCountStr[7]; + CHAR16 DeviceCountStr[7]; CHAR16 *Temp2; CONST CHAR16*FullDriverName; CHAR16 *TruncatedDriverName; -- 2.16.2.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#45568): https://edk2.groups.io/g/devel/message/45568 Mute This Topic: https://groups.io/mt/32853156/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v2 0/3] Fix warning message issues
Thanks. I had not checked each of the patches in the set, only the one CC'd to me and this one. Thanks -Jaben > -Original Message- > From: Zhang, Shenglei > Sent: Monday, August 12, 2019 5:53 PM > To: Carsey, Jaben ; devel@edk2.groups.io > Cc: Wang, Jian J ; Wu, Hao A > ; Ni, Ray ; Gao, Zhichao > ; Chiu, Chasel ; Desimone, > Nathaniel L ; Zeng, Star > > Subject: RE: [PATCH v2 0/3] Fix warning message issues > > Jaben: > > I add the v2 message below "---". And here is the link for v2 patch. > https://edk2.groups.io/g/devel/message/45398?p=,,,20,0,0,0::Created,,Mde > ModulePkg%3A+Add+missing+header+files+in+INF+files,20,2,0,32838103 > > Thanks, > Shenglei > > > -Original Message- > > From: Carsey, Jaben > > Sent: Monday, August 12, 2019 10:49 PM > > To: Zhang, Shenglei ; devel@edk2.groups.io > > Cc: Wang, Jian J ; Wu, Hao A > ; > > Ni, Ray ; Gao, Zhichao ; Chiu, > > Chasel ; Desimone, Nathaniel L > > ; Zeng, Star > > Subject: RE: [PATCH v2 0/3] Fix warning message issues > > > > What changed in v2? > > > > Thanks > > -Jaben > > > > > > > -----Original Message- > > > From: Zhang, Shenglei > > > Sent: Sunday, August 11, 2019 11:23 PM > > > To: devel@edk2.groups.io > > > Cc: Wang, Jian J ; Wu, Hao A > > > ; Carsey, Jaben ; Ni, > Ray > > > ; Gao, Zhichao ; Chiu, Chasel > > > ; Desimone, Nathaniel L > > > ; Zeng, Star > > > Subject: [PATCH v2 0/3] Fix warning message issues > > > > > > There are some header files used but not included in INF > > > files. This causes warings are generated when building the > > > packages. So now add them into INF files. > > > https://bugzilla.tianocore.org/show_bug.cgi?id=2036 > > > > > > Cc: Jian J Wang > > > Cc: Hao A Wu > > > Cc: Jaben Carsey > > > Cc: Ray Ni > > > Cc: Zhichao Gao > > > Cc: Chasel Chiu > > > Cc: Nate DeSimone > > > Cc: Star Zeng > > > Shenglei Zhang (3): > > > MdeModulePkg: Add missing header files in INF files > > > ShellPkg/UefiShellAcpiViewCommandLib: Add missing header files in INF > > > IntelFsp2Pkg/FspSecCore: Add missing header file in INF file > > > > > > IntelFsp2Pkg/FspSecCore/FspSecCoreS.inf | 3 ++- > > > MdeModulePkg/Universal/CapsulePei/CapsulePei.inf | 3 ++- > > > MdeModulePkg/Universal/CapsulePei/CapsuleX64.inf | 1 + > > > MdeModulePkg/Universal/EbcDxe/EbcDebuggerConfig.inf | 9 > > - > > > .../UefiShellAcpiViewCommandLib.inf | 2 ++ > > > 5 files changed, 15 insertions(+), 3 deletions(-) > > > > > > -- > > > 2.18.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#45474): https://edk2.groups.io/g/devel/message/45474 Mute This Topic: https://groups.io/mt/32838102/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v2 0/3] Fix warning message issues
What changed in v2? Thanks -Jaben > -Original Message- > From: Zhang, Shenglei > Sent: Sunday, August 11, 2019 11:23 PM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Wu, Hao A > ; Carsey, Jaben ; Ni, Ray > ; Gao, Zhichao ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Zeng, Star > Subject: [PATCH v2 0/3] Fix warning message issues > > There are some header files used but not included in INF > files. This causes warings are generated when building the > packages. So now add them into INF files. > https://bugzilla.tianocore.org/show_bug.cgi?id=2036 > > Cc: Jian J Wang > Cc: Hao A Wu > Cc: Jaben Carsey > Cc: Ray Ni > Cc: Zhichao Gao > Cc: Chasel Chiu > Cc: Nate DeSimone > Cc: Star Zeng > Shenglei Zhang (3): > MdeModulePkg: Add missing header files in INF files > ShellPkg/UefiShellAcpiViewCommandLib: Add missing header files in INF > IntelFsp2Pkg/FspSecCore: Add missing header file in INF file > > IntelFsp2Pkg/FspSecCore/FspSecCoreS.inf | 3 ++- > MdeModulePkg/Universal/CapsulePei/CapsulePei.inf | 3 ++- > MdeModulePkg/Universal/CapsulePei/CapsuleX64.inf | 1 + > MdeModulePkg/Universal/EbcDxe/EbcDebuggerConfig.inf | 9 - > .../UefiShellAcpiViewCommandLib.inf | 2 ++ > 5 files changed, 15 insertions(+), 3 deletions(-) > > -- > 2.18.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#45455): https://edk2.groups.io/g/devel/message/45455 Mute This Topic: https://groups.io/mt/32838102/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH] ShellPkg/UefiShellLevel2CommansLib: Pointer Resonse should be checked
Reviewed-by: Jaben Carsey
Thanks
-Jaben
> -Original Message-
> From: Gao, Zhichao
> Sent: Sunday, August 11, 2019 5:36 PM
> To: devel@edk2.groups.io
> Cc: Carsey, Jaben ; Ni, Ray
> Subject: [PATCH] ShellPkg/UefiShellLevel2CommansLib: Pointer Resonse
> should be checked
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2049
>
> ShellPkg\Library\UefiShellLevel2CommandsLib\Cp.c line 104 and
> ShellPkg\Library\UefiShellLevel2CommandsLib\Mv.c line 640, the
> pointer variable Response may be a NULL pointer. So we should
> make sure that it isn't NULL before dereference it.
>
> If Response is NULL that indicates a EFI_OUT_OF_RESOURCES
> error, directly return SHELL_ABORTED.
>
> Cc: Jaben Carsey
> Cc: Ray Ni
> Signed-off-by: Zhichao Gao
> ---
> ShellPkg/Library/UefiShellLevel2CommandsLib/Cp.c | 5 -
> ShellPkg/Library/UefiShellLevel2CommandsLib/Mv.c | 5 -
> 2 files changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/ShellPkg/Library/UefiShellLevel2CommandsLib/Cp.c
> b/ShellPkg/Library/UefiShellLevel2CommandsLib/Cp.c
> index 18b05b5803..4a2c2cfe64 100644
> --- a/ShellPkg/Library/UefiShellLevel2CommandsLib/Cp.c
> +++ b/ShellPkg/Library/UefiShellLevel2CommandsLib/Cp.c
> @@ -2,7 +2,7 @@
>Main file for cp shell level 2 function.
>
>(C) Copyright 2015 Hewlett-Packard Development Company, L.P.
> - Copyright (c) 2009 - 2018, Intel Corporation. All rights reserved.
> + Copyright (c) 2009 - 2019, Intel Corporation. All rights reserved.
>SPDX-License-Identifier: BSD-2-Clause-Patent
>
> **/
> @@ -101,6 +101,9 @@ CopySingleFile(
> // possibly return based on response
> //
> if (!SilentMode) {
> + if (Response == NULL) {
> +return SHELL_ABORTED;
> + }
>switch (*(SHELL_PROMPT_RESPONSE*)Response) {
> case ShellPromptResponseNo:
>//
> diff --git a/ShellPkg/Library/UefiShellLevel2CommandsLib/Mv.c
> b/ShellPkg/Library/UefiShellLevel2CommandsLib/Mv.c
> index 8c2852d7eb..f50c1e4c20 100644
> --- a/ShellPkg/Library/UefiShellLevel2CommandsLib/Mv.c
> +++ b/ShellPkg/Library/UefiShellLevel2CommandsLib/Mv.c
> @@ -2,7 +2,7 @@
>Main file for mv shell level 2 function.
>
>(C) Copyright 2013-2015 Hewlett-Packard Development Company, L.P.
> - Copyright (c) 2009 - 2018, Intel Corporation. All rights reserved.
> + Copyright (c) 2009 - 2019, Intel Corporation. All rights reserved.
>SPDX-License-Identifier: BSD-2-Clause-Patent
>
> **/
> @@ -637,6 +637,9 @@ ValidateAndMoveFiles(
>if (Response == NULL) {
> ShellPromptForResponseHii(ShellPromptResponseTypeYesNoAllCancel,
> STRING_TOKEN (STR_GEN_DEST_EXIST_OVR), gShellLevel2HiiHandle,
> );
>}
> + if (Response == NULL) {
> +return SHELL_ABORTED;
> + }
>switch (*(SHELL_PROMPT_RESPONSE*)Response) {
> case ShellPromptResponseNo:
>FreePool(Response);
> --
> 2.21.0.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#45453): https://edk2.groups.io/g/devel/message/45453
Mute This Topic: https://groups.io/mt/32835761/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH 2/3] ShellPkg/UefiShellAcpiViewCommandLib: Add missing header files in INF
Reviewed-by: Jaben Carsey Thanks -Jaben > -Original Message- > From: Gao, Zhichao > Sent: Thursday, August 08, 2019 1:59 AM > To: devel@edk2.groups.io; Zhang, Shenglei > Cc: Carsey, Jaben ; Ni, Ray > Subject: RE: [edk2-devel] [PATCH 2/3] > ShellPkg/UefiShellAcpiViewCommandLib: Add missing header files in INF > > Reviewed-by: Zhichao Gao > > Thanks, > Zhichao > > > -Original Message- > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > > Zhang, Shenglei > > Sent: Thursday, August 8, 2019 2:25 PM > > To: devel@edk2.groups.io > > Cc: Carsey, Jaben ; Ni, Ray ; > > Gao, Zhichao > > Subject: [edk2-devel] [PATCH 2/3] > ShellPkg/UefiShellAcpiViewCommandLib: > > Add missing header files in INF > > > > MadtParser.h and PpttParser.h are actually used but missing INF file, which > > will generate warning message when building this package. > > > > Cc: Jaben Carsey > > Cc: Ray Ni > > Cc: Zhichao Gao > > Signed-off-by: Shenglei Zhang > > --- > > .../UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.inf | 2 > ++ > > 1 file changed, 2 insertions(+) > > > > diff --git > > > a/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewComm > > andLib.inf > > > b/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewComm > > andLib.inf > > index e06e2082a197..1e2fa52b00a3 100644 > > --- > > > a/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewComm > > andLib.inf > > +++ > > > b/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewComm > > +++ andLib.inf > > @@ -43,6 +43,8 @@ [Sources.common] > >Parsers/Srat/SratParser.c > >Parsers/Ssdt/SsdtParser.c > >Parsers/Xsdt/XsdtParser.c > > + Parsers/Madt/MadtParser.h > > + Parsers/Pptt/PpttParser.h > > > > [Packages] > >MdePkg/MdePkg.dec > > -- > > 2.18.0.windows.1 > > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#45197): https://edk2.groups.io/g/devel/message/45197 Mute This Topic: https://groups.io/mt/32796056/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH] ShellPkg/UefiShellLevel2CommansLib: Pointer Resonse should be checked
That looks good, but I think it would be easier to just do the logic opposite.
Cant we just add the ~"if it is NULL, then return" and not have to change
anything else? No real need for else in that case since there is a return
statement...
Hand written pseudo-patch follows:
if (!SilentMode) {
+if (Response == NULL) {
+return SHELL_ABORTED;
+}
switch (*(SHELL_PROMPT_RESPONSE*)Response) {
Thanks
-Jaben
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Gao, Zhichao
> Sent: Wednesday, August 07, 2019 5:54 PM
> To: devel@edk2.groups.io
> Cc: Carsey, Jaben ; Ni, Ray
> Subject: [edk2-devel] [PATCH] ShellPkg/UefiShellLevel2CommansLib: Pointer
> Resonse should be checked
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2049
>
> ShellPkg\Library\UefiShellLevel2CommandsLib\Cp.c line 104 and
> ShellPkg\Library\UefiShellLevel2CommandsLib\Mv.c line 640, the
> pointer variable Response may be a NULL pointer. So we should
> make sure that it isn't NULL before dereference it.
>
> If Response is NULL that indicates a EFI_OUT_OF_RESOURCES
> error, directly return SHELL_ABORTED.
>
> Cc: Jaben Carsey
> Cc: Ray Ni
> Signed-off-by: Zhichao Gao
> ---
> .../Library/UefiShellLevel2CommandsLib/Cp.c | 42 ---
> .../Library/UefiShellLevel2CommandsLib/Mv.c | 52 ++-
> 2 files changed, 51 insertions(+), 43 deletions(-)
>
> diff --git a/ShellPkg/Library/UefiShellLevel2CommandsLib/Cp.c
> b/ShellPkg/Library/UefiShellLevel2CommandsLib/Cp.c
> index 18b05b5803..632d50229a 100644
> --- a/ShellPkg/Library/UefiShellLevel2CommandsLib/Cp.c
> +++ b/ShellPkg/Library/UefiShellLevel2CommandsLib/Cp.c
> @@ -2,7 +2,7 @@
>Main file for cp shell level 2 function.
>
>(C) Copyright 2015 Hewlett-Packard Development Company, L.P.
> - Copyright (c) 2009 - 2018, Intel Corporation. All rights reserved.
> + Copyright (c) 2009 - 2019, Intel Corporation. All rights reserved.
>SPDX-License-Identifier: BSD-2-Clause-Patent
>
> **/
> @@ -101,24 +101,28 @@ CopySingleFile(
> // possibly return based on response
> //
> if (!SilentMode) {
> - switch (*(SHELL_PROMPT_RESPONSE*)Response) {
> -case ShellPromptResponseNo:
> - //
> - // return success here so we dont stop the process
> - //
> - return (SHELL_SUCCESS);
> -case ShellPromptResponseCancel:
> - *Resp = Response;
> - //
> - // indicate to stop everything
> - //
> - return (SHELL_ABORTED);
> -case ShellPromptResponseAll:
> - *Resp = Response;
> -case ShellPromptResponseYes:
> - break;
> -default:
> - return SHELL_ABORTED;
> + if (Response != NULL) {
> +switch (*(SHELL_PROMPT_RESPONSE*)Response) {
> + case ShellPromptResponseNo:
> +//
> +// return success here so we dont stop the process
> +//
> +return (SHELL_SUCCESS);
> + case ShellPromptResponseCancel:
> +*Resp = Response;
> +//
> +// indicate to stop everything
> +//
> +return (SHELL_ABORTED);
> + case ShellPromptResponseAll:
> +*Resp = Response;
> + case ShellPromptResponseYes:
> +break;
> + default:
> +return SHELL_ABORTED;
> +}
> + } else {
> +return SHELL_ABORTED;
>}
> }
>}
> diff --git a/ShellPkg/Library/UefiShellLevel2CommandsLib/Mv.c
> b/ShellPkg/Library/UefiShellLevel2CommandsLib/Mv.c
> index 8c2852d7eb..2cfa588a8c 100644
> --- a/ShellPkg/Library/UefiShellLevel2CommandsLib/Mv.c
> +++ b/ShellPkg/Library/UefiShellLevel2CommandsLib/Mv.c
> @@ -2,7 +2,7 @@
>Main file for mv shell level 2 function.
>
>(C) Copyright 2013-2015 Hewlett-Packard Development Company, L.P.
> - Copyright (c) 2009 - 2018, Intel Corporation. All rights reserved.
> + Copyright (c) 2009 - 2019, Intel Corporation. All rights reserved.
>SPDX-License-Identifier: BSD-2-Clause-Patent
>
> **/
> @@ -637,29 +637,33 @@ ValidateAndMoveFiles(
>if (Response == NULL) {
> ShellPromptForResponseHii(ShellPromptResponseTypeYesNoAllCancel,
> STRING_TOKEN (STR_GEN_DEST_EXIST_OVR), gShellLevel2HiiHandle,
> );
>}
> - switch (*(SHELL_PROMPT_RESPONSE*)Response) {
> -case ShellPromptResponseNo:
> - FreePool(Response);
> - Response = NULL;
> - continue;
> -case ShellPromptResponseCancel:
> - *Resp = Res
Re: [edk2-devel] [Patch v3 0/2] ShellPkg: Fix IA32 build failure in acpiview
Reviewed-by: Jaben Carsey Thanks -Jaben > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Sami Mujawar > Sent: Monday, August 05, 2019 3:48 AM > To: devel@edk2.groups.io; Kinney, Michael D > Cc: Carsey, Jaben ; Ni, Ray ; > Gao, Zhichao > Subject: Re: [edk2-devel] [Patch v3 0/2] ShellPkg: Fix IA32 build failure in > acpiview > > For this patch series. > > Tested-by: Sami Mujawar > Reviewed-by: Sami Mujawar > > Regards, > > Sami Mujawar > > -Original Message- > From: devel@edk2.groups.io On Behalf Of Michael > D Kinney via Groups.Io > Sent: 03 August 2019 02:47 AM > To: devel@edk2.groups.io > Cc: Jaben Carsey ; Ray Ni ; > Zhichao Gao ; Sami Mujawar > > Subject: [edk2-devel] [Patch v3 0/2] ShellPkg: Fix IA32 build failure in > acpiview > > Use BaseLib MultuU64x64() to prevent intrinsics being added on IA32 builds. > Add acpiview to a version of the Shell that is build with ShellPkg.dsc to > catch > this type of issue in ShellPkg builds. > > Cc: Jaben Carsey > Cc: Ray Ni > Cc: Zhichao Gao > Cc: Sami Mujawar > Signed-off-by: Michael D Kinney > > Michael D Kinney (2): > ShellPkg/AcpiView: Fix IA32 link error > ShellPkg: Add shell with all commands integrated > > .../Parsers/Slit/SlitParser.c | 2 +- > ShellPkg/ShellPkg.dsc | 22 ++- > 2 files changed, 22 insertions(+), 2 deletions(-) > > -- > 2.21.0.windows.1 > > > > > IMPORTANT NOTICE: The contents of this email and any attachments are > confidential and may also be privileged. If you are not the intended > recipient, > please notify the sender immediately and do not disclose the contents to any > other person, use it for any purpose, or store or copy the information in any > medium. Thank you. > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#44914): https://edk2.groups.io/g/devel/message/44914 Mute This Topic: https://groups.io/mt/32697114/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v1 1/1] ShellPkg/UefiShellBcfgCommandLib: Fix '-opt' option
I think we can push this in now. Zhichao, Do you agree? If yes, can you prep this for merging? Thanks -Jaben > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Jonathan Watt > Sent: Friday, August 02, 2019 1:28 PM > To: devel@edk2.groups.io > Cc: tim.le...@insyde.com; Carsey, Jaben ; Gao, > Zhichao ; Ni, Ray ; Bi, Dandan > > Subject: Re: [edk2-devel] [PATCH v1 1/1] > ShellPkg/UefiShellBcfgCommandLib: Fix '-opt' option > > It's been three months now since I contributed the patch. Could someone > update > me on the progress on getting it landed? > > On 11/06/2019 22:53, Jonathan Watt wrote: > > Since I haven't contributed before I'm not sure what the timeline for these > > things generally is. It's been a month though. Can the patch be pushed > now? > > > > Regards, > > Jonathan > > > > On 08/05/2019 01:08, Tim Lewis wrote: > >> Yes, I would support it. Tim > >> > >> -Original Message- > >> From: Carsey, Jaben > >> Sent: Tuesday, May 7, 2019 5:00 PM > >> To: Jonathan Watt ; devel@edk2.groups.io; > tim.le...@insyde.com; Gao, Zhichao ; Ni, Ray > > >> Cc: Bi, Dandan > >> Subject: RE: [edk2-devel] [PATCH v1 1/1] > ShellPkg/UefiShellBcfgCommandLib: Fix '-opt' option > >> > >> Tim, > >> > >> Does this mean you would support such an errata? I would like to get the > spec to a place where the behavior is at least nailed down one way or the > other... > >> > >> -Jaben > >> > >>> -Original Message- > >>> From: Jonathan Watt [mailto:jw...@jwatt.org] > >>> Sent: Tuesday, May 7, 2019 2:08 PM > >>> To: devel@edk2.groups.io; tim.le...@insyde.com; Carsey, Jaben > >>> ; Gao, Zhichao ; Ni, > >>> Ray > >>> Cc: Bi, Dandan > >>> Subject: Re: [edk2-devel] [PATCH v1 1/1] > ShellPkg/UefiShellBcfgCommandLib: > >>> Fix '-opt' option > >>> Importance: High > >>> > >>> No apologies necessary! Raising compatibility concerns is very valid. > >>> As I said, I just wanted to provide some other considerations I saw to > >>> weigh in the decision. > >>> > >>> All the best, > >>> Jonathan > >>> > >>> On 07/05/2019 22:02, Tim Lewis wrote: > >>>> Jonathan -- > >>>> > >>>> My apologies. I jumped because we've been bitten by shell > "clarifications" > >>> in the past. > >>>> > >>>> As you've probably read in the other thread, it turns out that I > >>>> (we) actually > >>> did agree with your interpretation of the spec in our alternate > >>> implementation and have been using it that way for 2+ years. And it > >>> didn't cause us grief with our other product which does use an EDK2- > derived shell. > >>>> > >>>> Best regards, > >>>> Tim > >>>> > >>>> -Original Message- > >>>> From: devel@edk2.groups.io On Behalf Of > >>>> Jonathan Watt > >>>> Sent: Tuesday, May 7, 2019 1:51 PM > >>>> To: Tim Lewis ; 'Carsey, Jaben' > >>>> ; devel@edk2.groups.io; 'Gao, Zhichao' > >>>> ; 'Ni, Ray' > >>>> Cc: 'Bi, Dandan' > >>>> Subject: Re: [edk2-devel] [PATCH v1 1/1] > >>>> ShellPkg/UefiShellBcfgCommandLib: Fix '-opt' option > >>>> > >>>> Hi Tim, > >>>> > >>>> For context, I'm just some random guy who tripped over this issue on > >>>> his > >>> home workstation and thought he'd try and remove the footgun to save > >>> anyone else the same pain. I was specifically replying to the > >>> unconditional statement "It will break existing scripts." (not made by > >>> you) to provide what I hope was some qualification and balance to the > >>> face value of that statement, and to suggest some other things that > >>> should be considered. As far as deciding what the best resolution is, I'm > not qualified for that. > >>>> > >>>> I am curious about one thing though. The sentence you wrote that > >>>> ends > >>> with "that are implemented to the specification" sounds like you're > >>> saying making the proposed change would violate the specification. > >>> That does not seem to be the case from my reading, and my readi
Re: [edk2-devel] [Patch v2 2/2] ShellPkg: Add shell with all commands integrated
I thought with this change the DSC would build 2 images. The second image would
have the acpiview command and you could ignore that image for your purpose.
-Jaben
> -Original Message-
> From: Gao, Zhichao
> Sent: Thursday, August 1, 2019 10:36 PM
> To: devel@edk2.groups.io; Kinney, Michael D
> Cc: Carsey, Jaben ; Ni, Ray ;
> Sami Mujawar
> Subject: RE: [edk2-devel] [Patch v2 2/2] ShellPkg: Add shell with all
> commands integrated
>
> I used to use the shellpkg.dsc to build a shell.efi binary release.
> Full configuration of shell is fine. But the acpiview is under developing and
> the shell spec doesn't contain 'acpiview' yet.
> Is it OK to add an additional cmd that the spec isn't mentioned?
>
> Thanks,
> Zhichao
>
> > -Original Message-
> > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> > Michael D Kinney
> > Sent: Friday, August 2, 2019 4:56 AM
> > To: devel@edk2.groups.io
> > Cc: Carsey, Jaben ; Ni, Ray
> > ; Gao, Zhichao ; Sami
> Mujawar
> >
> > Subject: [edk2-devel] [Patch v2 2/2] ShellPkg: Add shell with all
> > commands integrated
> >
> > https://bugzilla.tianocore.org/show_bug.cgi?id=1970
> >
> > Update ShellPkg DSC file to build an extra version of the Shell with
> > all commands integrated. This verifies that the shell can build in
> > this max configuration.
> >
> > Cc: Jaben Carsey
> > Cc: Ray Ni
> > Cc: Zhichao Gao
> > Cc: Sami Mujawar
> > Signed-off-by: Michael D Kinney
> > ---
> > ShellPkg/ShellPkg.dsc | 22 +-
> > 1 file changed, 21 insertions(+), 1 deletion(-)
> >
> > diff --git a/ShellPkg/ShellPkg.dsc b/ShellPkg/ShellPkg.dsc index
> > 6a139b3b91..b2065dc028 100644
> > --- a/ShellPkg/ShellPkg.dsc
> > +++ b/ShellPkg/ShellPkg.dsc
> > @@ -1,7 +1,7 @@
> > ## @file
> > # Shell Package
> > #
> > -# Copyright (c) 2007 - 2018, Intel Corporation. All rights
> > reserved.
> > +# Copyright (c) 2007 - 2019, Intel Corporation. All rights
> > +reserved.
> > # Copyright (c) 2018, Arm Limited. All rights reserved. #
> > #SPDX-License-Identifier: BSD-2-Clause-Patent
> > @@ -115,6 +115,26 @@ [Components]
> > !endif #$(NO_SHELL_PROFILES)
> >}
> >
> > + #
> > + # Build a second version of the shell with all commands integrated
> > + # ShellPkg/Application/Shell/Shell.inf {
> > +
> > + FILE_GUID = EA4BB293-2D7F-4456-A681-1F22F42CD0BC
> > +
> > + gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE
> > +
> > +
> >
> NULL|ShellPkg/Library/UefiShellLevel2CommandsLib/UefiShellLevel2Comma
> > ndsLib.inf
> > +
> >
> NULL|ShellPkg/Library/UefiShellLevel1CommandsLib/UefiShellLevel1Comma
> > ndsLib.inf
> > +
> >
> NULL|ShellPkg/Library/UefiShellLevel3CommandsLib/UefiShellLevel3Comma
> > ndsLib.inf
> > +
> > NULL|ShellPkg/Library/UefiShellDriver1CommandsLib/UefiShellDriver1Com
> > mandsLib.inf
> > +
> > NULL|ShellPkg/Library/UefiShellInstall1CommandsLib/UefiShellInstall1Co
> > NULL|m
> > mandsLib.inf
> > +
> >
> NULL|ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1Com
> > mandsLib.inf
> > +
> > NULL|ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1
> > CommandsLib.inf
> > +
> > NULL|ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2
> > CommandsLib.inf
> > +
> > +
> >
> NULL|ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCo
> > m
> > + mandLib.inf
> > + }
> > +
> >
> >
> ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.
> > inf {
> >
> >gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE
> > --
> > 2.21.0.windows.1
> >
> >
> >
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#44862): https://edk2.groups.io/g/devel/message/44862
Mute This Topic: https://groups.io/mt/32683879/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [Patch v2 0/2] ShellPkg: Fix IA32 build failure in acpiview
Reviewed-by: Jaben Carsey Thanks -Jaben > -Original Message- > From: Kinney, Michael D > Sent: Thursday, August 01, 2019 1:56 PM > To: devel@edk2.groups.io > Cc: Carsey, Jaben ; Ni, Ray ; > Gao, Zhichao ; Sami Mujawar > > Subject: [Patch v2 0/2] ShellPkg: Fix IA32 build failure in acpiview > > Avoid 64-bit multiply operations to prevent intrinsics being added on IA32 > builds. Add acpiview to a version of the Shell that is build with > ShellPkg.dsc > to catch this type of issue in ShellPkg builds. > > Cc: Jaben Carsey > Cc: Ray Ni > Cc: Zhichao Gao > Cc: Sami Mujawar > Signed-off-by: Michael D Kinney > > Michael D Kinney (2): > ShellPkg/AcpiView: Fix IA32 link error > ShellPkg: Add shell with all commands integrated > > .../Parsers/Slit/SlitParser.c | 9 ++-- > ShellPkg/ShellPkg.dsc | 22 ++- > 2 files changed, 28 insertions(+), 3 deletions(-) > > -- > 2.21.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#44812): https://edk2.groups.io/g/devel/message/44812 Mute This Topic: https://groups.io/mt/32683878/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v1 0/6] Acpiview table parsers code style enhancements and refactoring
Reviewed-by: Jaben Carsey Thanks -Jaben > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Krzysztof Koch > Sent: Thursday, July 18, 2019 5:32 AM > To: devel@edk2.groups.io > Cc: Carsey, Jaben ; Ni, Ray ; > Gao, Zhichao ; sami.muja...@arm.com; > matteo.carl...@arm.com; n...@arm.com > Subject: [edk2-devel] [PATCH v1 0/6] Acpiview table parsers code style > enhancements and refactoring > > This set of patches consists of a number of changes which make the code > structure consistent across the existing ACPI table parsers. These are > all refactoring changes which do not modify the existing functionality > of the acpiview UEFI shell tool. > > Changes can be seen at: > https://github.com/KrzysztofKoch1/edk2/tree/612_acpiview_code_style_e > nhance_v1 > > Krzysztof Koch (6): > ShellPkg: acpiview: Allow passing buffer length to DumpGasStruct() > ShellPkg: acpiview: XSDT: Remove redundant ParseAcpi() call > ShellPkg: acpiview: RSDP: Make code consistent with other parsers > ShellPkg: acpiview: SRAT: Minor code style enhancements > ShellPkg: acpiview: MADT: Split structure length validation > ShellPkg: acpiview: IORT: Refactor PMCG node mapping count validation > > ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c | 26 > +--- > ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.h | 8 > +++-- > > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Dbg2/Dbg2Parser.c > | 2 +- > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Iort/IortParser.c | > 32 ++-- > > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Madt/MadtParser. > c | 30 +- > > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Rsdp/RsdpParser.c > | 11 +-- > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Srat/SratParser.c | > 3 +- > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Xsdt/XsdtParser.c > | 18 +++ > 8 files changed, 82 insertions(+), 48 deletions(-) > > -- > 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#43946): https://edk2.groups.io/g/devel/message/43946 Mute This Topic: https://groups.io/mt/32514378/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v1 0/8] Remove redundant forward declarations in acpiview
Reviewed-by: Jaben Carsey Thanks -Jaben > -Original Message- > From: Krzysztof Koch [mailto:krzysztof.k...@arm.com] > Sent: Thursday, July 18, 2019 3:05 AM > To: devel@edk2.groups.io > Cc: Carsey, Jaben ; Ni, Ray ; > Gao, Zhichao ; sami.muja...@arm.com; > matteo.carl...@arm.com; n...@arm.com > Subject: [PATCH v1 0/8] Remove redundant forward declarations in acpiview > > This patch series removes forward static function declarations in the > acpiview table parsers. After repositioning blocks of code, these forward > declarations are no longer needed and they increase the code size. > > What is more, some of the existing ACPI table parsers don't have these > duplicate declarations, so this set of patches makes the code structure > consistent across all acpiview parsers. > > Changes can be seen at: > https://github.com/KrzysztofKoch1/edk2/tree/612_remove_forward_decl_ > v1 > > Krzysztof Koch (8): > ShellPkg: acpiview: RSDP: Remove redundant forward declarations > ShellPkg: acpiview: FADT: Remove redundant forward declarations > ShellPkg: acpiview: SPCR: Remove redundant forward declaration > ShellPkg: acpiview: SRAT: Remove redundant forward declarations > ShellPkg: acpiview: MADT: Remove redundant forward declarations > ShellPkg: acpiview: IORT: Remove redundant forward declarations > ShellPkg: acpiview: GTDT: Remove redundant forward declarations > ShellPkg: acpiview: DBG2: Remove redundant forward declarations > > > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Dbg2/Dbg2Parser.c > | 62 +++--- > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Fadt/FadtParser.c > | 113 ++- > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Gtdt/GtdtParser.c > | 91 ++- > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Iort/IortParser.c | > 58 +++--- > > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Madt/MadtParser. > c | 118 > > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Rsdp/RsdpParser.c > | 116 +++ > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Spcr/SpcrParser.c > | 98 ++-- > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Srat/SratParser.c | > 64 +++ > 8 files changed, 236 insertions(+), 484 deletions(-) > > -- > 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#43945): https://edk2.groups.io/g/devel/message/43945 Mute This Topic: https://groups.io/mt/32513487/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH V2] ShellPkg/Type.c: Add value check before (LoopVar - 1)
Reviewed-by: Jaben Carsey
Thanks
-Jaben
> -Original Message-
> From: Gao, Zhichao
> Sent: Tuesday, July 16, 2019 2:12 AM
> To: devel@edk2.groups.io
> Cc: Carsey, Jaben ; Ni, Ray ;
> Andrew Fish
> Subject: [PATCH V2] ShellPkg/Type.c: Add value check before (LoopVar - 1)
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1964
>
> If the file begin with single line Feed ('\n'), then
> "AsciiChar == '\n' && ((CHAR8*)Buffer)[LoopVar-1] != '\r'"
> would cause a underflow. Add this condition
> "(AsciiChar == '\n' && LoopVar == 0)" before it to make sure
> (LoopVar - 1) would never encounter a underflow.
>
> Same change in Unicode section.
>
> Cc: Jaben Carsey
> Cc: Ray Ni
> Cc: Andrew Fish
> Signed-off-by: Zhichao Gao
> ---
> V2:
> 1. Update the copyright
> 2. Fix the same issue in unicode section
> 3. Fix typo
>
> .../Library/UefiShellLevel3CommandsLib/Type.c | 24 ++-
> 1 file changed, 13 insertions(+), 11 deletions(-)
>
> diff --git a/ShellPkg/Library/UefiShellLevel3CommandsLib/Type.c
> b/ShellPkg/Library/UefiShellLevel3CommandsLib/Type.c
> index 4efc0a8e24..f0aa57af3d 100644
> --- a/ShellPkg/Library/UefiShellLevel3CommandsLib/Type.c
> +++ b/ShellPkg/Library/UefiShellLevel3CommandsLib/Type.c
> @@ -2,7 +2,7 @@
>Main file for Type shell level 3 function.
>
>(C) Copyright 2013-2015 Hewlett-Packard Development Company, L.P.
> - Copyright (c) 2009 - 2018, Intel Corporation. All rights reserved.
> + Copyright (c) 2009 - 2019, Intel Corporation. All rights reserved.
>SPDX-License-Identifier: BSD-2-Clause-Patent
>
> **/
> @@ -78,12 +78,13 @@ TypeFileByHandle (
>// Allow Line Feed (LF) (0xA) & Carriage Return (CR) (0xD)
>// characters to be displayed as is.
>//
> - if (AsciiChar == '\n' && ((CHAR8*)Buffer)[LoopVar-1] != '\r') {
> + if ((AsciiChar == '\n' && LoopVar == 0) ||
> + (AsciiChar == '\n' && ((CHAR8*)Buffer)[LoopVar-1] != '\r')) {
> //
> -// In case Line Feed (0xA) is encountered & Carriage Return (0xD)
> -// was not the previous character, print CR and LF. This is
> because
> -// Shell 2.0 requires carriage return with line feed for
> displaying
> -// each new line from left.
> +// In case file begin with single line Feed or Line Feed (0xA) is
> +// encountered & Carriage Return (0xD) was not previous
> character,
> +// print CR and LF. This is because Shell 2.0 requires carriage
> +// return with line feed for displaying each new line from left.
> //
> ShellPrintEx (-1, -1, L"\r\n");
> continue;
> @@ -121,12 +122,13 @@ TypeFileByHandle (
>// Allow Line Feed (LF) (0xA) & Carriage Return (CR) (0xD)
>// characters to be displayed as is.
>//
> - if (Ucs2Char == '\n' && ((CHAR16*)Buffer)[LoopVar-1] != '\r') {
> + if ((Ucs2Char == '\n' && LoopVar == 0) ||
> + (Ucs2Char == '\n' && ((CHAR16*)Buffer)[LoopVar-1] != '\r')) {
> //
> -// In case Line Feed (0xA) is encountered & Carriage Return (0xD)
> -// was not the previous character, print CR and LF. This is
> because
> -// Shell 2.0 requires carriage return with line feed for
> displaying
> -// each new line from left.
> +// In case file begin with single line Feed or Line Feed (0xA) is
> +// encountered & Carriage Return (0xD) was not previous
> character,
> +// print CR and LF. This is because Shell 2.0 requires carriage
> +// return with line feed for displaying each new line from left.
> //
> ShellPrintEx (-1, -1, L"\r\n");
> continue;
> --
> 2.21.0.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#43808): https://edk2.groups.io/g/devel/message/43808
Mute This Topic: https://groups.io/mt/32488137/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH] ShellPkg/Type.c: Add value check before (LoopVar - 1)
Please remove the typo (there is an extra S after 'return'). This line:
// return Swith line feed for displaying each new line from left.
> -Original Message-
> From: Gao, Zhichao
> Sent: Monday, July 15, 2019 12:30 AM
> To: devel@edk2.groups.io
> Cc: Carsey, Jaben ; Ni, Ray ;
> Andrew Fish
> Subject: [PATCH] ShellPkg/Type.c: Add value check before (LoopVar - 1)
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1964
>
> If the file begin with single line Feed ('\n'), then
> "AsciiChar == '\n' && ((CHAR8*)Buffer)[LoopVar-1] != '\r'"
> would cause a underflow. Add this condition
> "(AsciiChar == '\n' && LoopVar == 0)" before it to make sure
> (LoopVar - 1) would never encounter a underflow.
>
> Cc: Jaben Carsey
> Cc: Ray Ni
> Cc: Andrew Fish
> Signed-off-by: Zhichao Gao
> ---
> ShellPkg/Library/UefiShellLevel3CommandsLib/Type.c | 11 ++-
> 1 file changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/ShellPkg/Library/UefiShellLevel3CommandsLib/Type.c
> b/ShellPkg/Library/UefiShellLevel3CommandsLib/Type.c
> index 4efc0a8e24..c1f670c713 100644
> --- a/ShellPkg/Library/UefiShellLevel3CommandsLib/Type.c
> +++ b/ShellPkg/Library/UefiShellLevel3CommandsLib/Type.c
> @@ -78,12 +78,13 @@ TypeFileByHandle (
>// Allow Line Feed (LF) (0xA) & Carriage Return (CR) (0xD)
>// characters to be displayed as is.
>//
> - if (AsciiChar == '\n' && ((CHAR8*)Buffer)[LoopVar-1] != '\r') {
> + if ((AsciiChar == '\n' && LoopVar == 0) ||
> + (AsciiChar == '\n' && ((CHAR8*)Buffer)[LoopVar-1] != '\r')) {
> //
> -// In case Line Feed (0xA) is encountered & Carriage Return (0xD)
> -// was not the previous character, print CR and LF. This is
> because
> -// Shell 2.0 requires carriage return with line feed for
> displaying
> -// each new line from left.
> +// In case file begin with single line Feed or Line Feed (0xA) is
> +// encountered & Carriage Return (0xD) was not previous
> character,
> +// print CR and LF. This is because Shell 2.0 requires carriage
> +// return Swith line feed for displaying each new line from left.
> //
> ShellPrintEx (-1, -1, L"\r\n");
> continue;
> --
> 2.21.0.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#43721): https://edk2.groups.io/g/devel/message/43721
Mute This Topic: https://groups.io/mt/32476115/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v1 01/11] ShellPkg: acpiview: FADT: Validate global pointers before use
I think it would be easier to see/review these changes logically if the
functional changes (1 and 3) were separate from the refactoring change (2).
Reviewed-by: Jaben Carsey
> -Original Message-
> From: Krzysztof Koch [mailto:krzysztof.k...@arm.com]
> Sent: Thursday, July 11, 2019 11:53 PM
> To: devel@edk2.groups.io
> Cc: Carsey, Jaben ; Ni, Ray ;
> Gao, Zhichao ; sami.muja...@arm.com;
> matteo.carl...@arm.com; n...@arm.com
> Subject: [PATCH v1 01/11] ShellPkg: acpiview: FADT: Validate global pointers
> before use
>
> 1. Check if the global pointer have been successfully updated before
> they are later used to control the parsing logic in the FADT acpiview
> parser.
>
> 2. Remove redundant forward function declarations by repositioning
> blocks of code.
>
> 3. Allow silencing ACPI table content validation errors which do not
> cause table parsing to fail.
>
> Signed-off-by: Krzysztof Koch
> ---
>
> Changes can be seen at:
> https://github.com/KrzysztofKoch1/edk2/commit/49cc41430775fb93205e302
> 590a7d31f080c3952
>
> Notes:
> v1:
> - improve the logic in the parser [Krzysztof]
>
> ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Fadt/FadtParser.c
> | 131
> 1 file changed, 51 insertions(+), 80 deletions(-)
>
> diff --git
> a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Fadt/FadtParser.
> c
> b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Fadt/FadtParser.
> c
> index
> cee7ee0770433da96d6042d2f5d687903f4b5495..600d3b16d7b22b61c1a1fd21
> ecb93f16c7f8fa1a 100644
> ---
> a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Fadt/FadtParser.
> c
> +++
> b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Fadt/FadtParser.
> c
> @@ -1,7 +1,7 @@
> /** @file
>FADT table parser
>
> - Copyright (c) 2016 - 2018, ARM Limited. All rights reserved.
> + Copyright (c) 2016 - 2019, ARM Limited. All rights reserved.
>SPDX-License-Identifier: BSD-2-Clause-Patent
>
>@par Reference(s):
> @@ -12,6 +12,7 @@
> #include
> #include "AcpiParser.h"
> #include "AcpiTableParser.h"
> +#include "AcpiView.h"
>
> // Local variables
> STATIC CONST UINT32* DsdtAddress;
> @@ -46,7 +47,17 @@ EFIAPI
> ValidateFirmwareCtrl (
>IN UINT8* Ptr,
>IN VOID* Context
> - );
> +)
> +{
> +#if defined (MDE_CPU_ARM) || defined (MDE_CPU_AARCH64)
> + if (*(UINT32*)Ptr != 0) {
> +IncrementErrorCount ();
> +Print (
> + L"\nERROR: Firmware Control must be zero for ARM platforms."
> +);
> + }
> +#endif
> +}
>
> /**
>This function validates the X_Firmware Control Field.
> @@ -61,7 +72,17 @@ EFIAPI
> ValidateXFirmwareCtrl (
>IN UINT8* Ptr,
>IN VOID* Context
> - );
> +)
> +{
> +#if defined (MDE_CPU_ARM) || defined (MDE_CPU_AARCH64)
> + if (*(UINT64*)Ptr != 0) {
> +IncrementErrorCount ();
> +Print (
> + L"\nERROR: X Firmware Control must be zero for ARM platforms."
> +);
> + }
> +#endif
> +}
>
> /**
>This function validates the flags.
> @@ -76,7 +97,17 @@ EFIAPI
> ValidateFlags (
>IN UINT8* Ptr,
>IN VOID* Context
> - );
> +)
> +{
> +#if defined (MDE_CPU_ARM) || defined (MDE_CPU_AARCH64)
> + if (((*(UINT32*)Ptr) & HW_REDUCED_ACPI) == 0) {
> +IncrementErrorCount ();
> +Print (
> + L"\nERROR: HW_REDUCED_ACPI flag must be set for ARM platforms."
> +);
> + }
> +#endif
> +}
>
> /**
>An ACPI_PARSER array describing the ACPI FADT Table.
> @@ -142,81 +173,6 @@ STATIC CONST ACPI_PARSER FadtParser[] = {
>{L"Hypervisor VendorIdentity", 8, 268, L"%lx", NULL, NULL, NULL, NULL}
> };
>
> -/**
> - This function validates the Firmware Control Field.
> -
> - @param [in] Ptr Pointer to the start of the field data.
> - @param [in] Context Pointer to context specific information e.g. this
> - could be a pointer to the ACPI table header.
> -**/
> -STATIC
> -VOID
> -EFIAPI
> -ValidateFirmwareCtrl (
> - IN UINT8* Ptr,
> - IN VOID* Context
> -)
> -{
> -#if defined (MDE_CPU_ARM) || defined (MDE_CPU_AARCH64)
> - if (*(UINT32*)Ptr != 0) {
> -IncrementErrorCount ();
> -Print (
> - L"\nERROR: Firmware Control must be zero for ARM platforms."
> -);
> - }
> -#endif
> -}
> -
> -/**
> - This function validates the X_Firmware Control Field.
> -
> - @param [in] Ptr Pointer to the start of the field data.
> - @param [in] Context Pointer to context specific information e.g. this
>
Re: [edk2-devel] [Patch] ShellPkg/AcpiView: Fix IA32 link error
Reviewed-by: Jaben Carsey
> -Original Message-
> From: Kinney, Michael D
> Sent: Wednesday, July 10, 2019 3:35 PM
> To: devel@edk2.groups.io
> Cc: Carsey, Jaben ; Ni, Ray ;
> Gao, Zhichao
> Subject: [Patch] ShellPkg/AcpiView: Fix IA32 link error
> Importance: High
>
> https://bugzilla.tianocore.org/show_bug.cgi?id=1970
>
> Update local variable in ParseAcpiSlot() to be UINT32
> instead of UINT64 to avoid 64-bit multiply operation
> in the SLIT_ELEMENT() macro.
>
> Cc: Jaben Carsey
> Cc: Ray Ni
> Cc: Zhichao Gao
> Signed-off-by: Michael D Kinney
> ---
> .../UefiShellAcpiViewCommandLib/Parsers/Slit/SlitParser.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git
> a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Slit/SlitParser.c
> b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Slit/SlitParser.c
> index 1f9dac66ee..af85c9aa1c 100644
> ---
> a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Slit/SlitParser.c
> +++
> b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Slit/SlitParser.c
> @@ -57,8 +57,8 @@ ParseAcpiSlit (
>)
> {
>UINT32 Offset;
> - UINT64 Count;
> - UINT64 Index;
> + UINT32 Count;
> + UINT32 Index;
>UINT64 LocalityCount;
>UINT8* LocalityPtr;
>CHAR16 Buffer[80]; // Used for AsciiName param of ParseAcpi
> --
> 2.21.0.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#43530): https://edk2.groups.io/g/devel/message/43530
Mute This Topic: https://groups.io/mt/32421790/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [Patch 0/2] BaseTools: Separate current CreateAsBuiltInf function into two
Reviewed-by: Jaben Carsey Much clearer code to see what's actually happening. > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Bob Feng > Sent: Sunday, June 23, 2019 6:51 PM > To: devel@edk2.groups.io > Subject: [edk2-devel] [Patch 0/2] BaseTools: Separate current > CreateAsBuiltInf function into two > > https://bugzilla.tianocore.org/show_bug.cgi?id=1932 > > In current implementation, there are 2 functions in CreateAsBuiltInf, > one is create asbuildinf, the other is update build cache. > They should be separated. > > Feng, Bob C (2): > BaseTools: refine CreateAsBuiltInf function > BaseTools: Move Build Cache related function out of CreateAsBuiltInf > > BaseTools/Source/Python/AutoGen/AutoGen.py | 73 > ++- > -- > BaseTools/Source/Python/build/build.py | 26 > ++ > 2 files changed, 60 insertions(+), 39 deletions(-) > > -- > 2.20.1.windows.1 > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#42751): https://edk2.groups.io/g/devel/message/42751 Mute This Topic: https://groups.io/mt/32187979/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v1 2/2] ShellPkg: acpiview: Update SRAT parser to ACPI 6.3
Reviewed-by: Jaben Carsey
I don't have access to a platform with ACPI 6.3 to do a test. Can someone do a
test and respond with tested-by if possible?
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Krzysztof Koch
> Sent: Wednesday, June 12, 2019 7:11 AM
> To: devel@edk2.groups.io
> Cc: Carsey, Jaben ; Ni, Ray ;
> Gao, Zhichao ; Kinney, Michael D
> ; Gao, Liming ;
> sami.muja...@arm.com; matteo.carl...@arm.com; Stephanie.Hughes-
> f...@arm.com; n...@arm.com
> Subject: [edk2-devel] [PATCH v1 2/2] ShellPkg: acpiview: Update SRAT parser
> to ACPI 6.3
> Importance: High
>
> Add support for parsing revision 3 of System Resource Affinity Table
> (SRAT).
>
> Decode and dump the new Generic Initiator Affinity Structure.
>
> Validate the Device Handle Type field inside the Generic Initiator
> Affinity Structure.
>
> Signed-off-by: Krzysztof Koch
> ---
>
> Changes can be seen at:
> https://github.com/KrzysztofKoch1/edk2/tree/582_acpiview_6_3_srat_v1
>
> Notes:
> v1:
> - dump and validate the Generic Initiator Affinity Struct [Krzysztof]
>
> ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c | 35
> ++-
> ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.h | 16
> ++
> ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Srat/SratParser.c |
> 256 +++-
> 3 files changed, 299 insertions(+), 8 deletions(-)
>
> diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c
> b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c
> index
> b5965507b498b9fa9bc4d3124b2285f509004c4f..60523936732f901317ee93d03f
> e06df1403f3695 100644
> --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c
> +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c
> @@ -1,7 +1,7 @@
> /** @file
>ACPI parser
>
> - Copyright (c) 2016 - 2018, ARM Limited. All rights reserved.
> + Copyright (c) 2016 - 2019, ARM Limited. All rights reserved.
>SPDX-License-Identifier: BSD-2-Clause-Patent
> **/
>
> @@ -401,6 +401,39 @@ Dump8Chars (
> );
> }
>
> +/**
> + This function traces 12 characters which can be optionally
> + formated using the format string if specified.
> +
> + If no format string is specified the Format must be NULL.
> +
> + @param [in] Format Optional format string for tracing the data.
> + @param [in] Ptr Pointer to the start of the buffer.
> +**/
> +VOID
> +EFIAPI
> +Dump12Chars (
> + IN CONST CHAR16* Format OPTIONAL,
> + IN UINT8* Ptr
> + )
> +{
> + Print (
> +(Format != NULL) ? Format : L"%c%c%c%c%c%c%c%c%c%c%c%c",
> +Ptr[0],
> +Ptr[1],
> +Ptr[2],
> +Ptr[3],
> +Ptr[4],
> +Ptr[5],
> +Ptr[6],
> +Ptr[7],
> +Ptr[8],
> +Ptr[9],
> +Ptr[10],
> +Ptr[11]
> +);
> +}
> +
> /**
>This function indents and prints the ACPI table Field Name.
>
> diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.h
> b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.h
> index
> 7657892d9fd2e2e14c6578611ff0cf1b6f6cd750..5b23ab6fa9bd2f87e034728787
> 2685a2f74622f3 100644
> --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.h
> +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.h
> @@ -184,6 +184,22 @@ Dump8Chars (
>IN UINT8*Ptr
>);
>
> +/**
> + This function traces 12 characters which can be optionally
> + formated using the format string if specified.
> +
> + If no format string is specified the Format must be NULL.
> +
> + @param [in] Format Optional format string for tracing the data.
> + @param [in] Ptr Pointer to the start of the buffer.
> +**/
> +VOID
> +EFIAPI
> +Dump12Chars (
> + IN CONST CHAR16* Format OPTIONAL,
> + IN UINT8* Ptr
> + );
> +
> /**
>This function indents and prints the ACPI table Field Name.
>
> diff --git
> a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Srat/SratParser.c
> b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Srat/SratParser.c
> index
> 075ff2a141a82b522e8aaedb7ad79249aaf5eaac..8c268a11454d13c9e278691d6
> 19a580c4c14c08e 100644
> ---
> a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Srat/SratParser.c
> +++
> b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Srat/SratParser.c
> @@ -1,11 +1,11 @@
> /** @file
>SRAT table parser
>
> - Copyright (c) 2016 - 2018, ARM Limited. All rights reserved.
> + Copyright (c) 2016 - 2019, ARM Limited. All rights reserved.
>SPDX-License-Identifier: BSD-2-Clause-Patent
>
Re: [edk2-devel] [patch] ShellPkg/Debug1CommandsLib: Fix bugs in func DisplaySysEventLogData
Pushed.
> -Original Message-
> From: Bi, Dandan
> Sent: Monday, June 10, 2019 5:52 PM
> To: devel@edk2.groups.io; oleks...@ami.com; Ni, Ray ;
> Carsey, Jaben
> Cc: Gao, Zhichao
> Subject: RE: [patch] ShellPkg/Debug1CommandsLib: Fix bugs in func
> DisplaySysEventLogData
> Importance: High
>
> Hi Ray and Jaben,
>
> Do you have any comments for this patch?
> If no, could you give the R-B and then help push the patch?
>
>
> Thanks,
> Dandan
>
> > -Original Message-
> > From: Gao, Zhichao
> > Sent: Wednesday, May 29, 2019 8:32 AM
> > To: Bi, Dandan ; devel@edk2.groups.io;
> > oleks...@ami.com
> > Cc: Carsey, Jaben ; Ni, Ray
> > Subject: RE: [patch] ShellPkg/Debug1CommandsLib: Fix bugs in func
> > DisplaySysEventLogData
> >
> > Reviewed-by: Zhichao Gao
> >
> > > -Original Message-
> > > From: Bi, Dandan
> > > Sent: Tuesday, May 28, 2019 10:25 AM
> > > To: devel@edk2.groups.io; oleks...@ami.com
> > > Cc: Carsey, Jaben ; Ni, Ray
> > > ; Gao, Zhichao
> > > Subject: [patch] ShellPkg/Debug1CommandsLib: Fix bugs in func
> > > DisplaySysEventLogData
> > >
> > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1498
> > >
> > > This patch fix following bugs in func DisplaySysEventLogData:
> > > 1. Log increment (Log = (LOG_RECORD_FORMAT *) (LogData + Offset);)
> > > should happened in the end of while loop, not in the very beginning.
> > > 2. DisplaySELTypes function should be used in while loop instead of
> > > DisplaySELVarDataFormatType.
> > >
> > > Cc: Jaben Carsey
> > > Cc: Ray Ni
> > > Cc: Zhichao Gao
> > > Signed-off-by: Dandan Bi
> > > ---
> > > .../SmbiosView/EventLogInfo.c | 20 +--
> > > 1 file changed, 14 insertions(+), 6 deletions(-)
> > >
> > > diff --git
> > >
> >
> a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/EventLogInf
> > > o.c
> > >
> >
> b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/EventLogInf
> > > o.c
> > > index b8adf438d3..984c178890 100644
> > > ---
> > >
> >
> a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/EventLogInf
> > > o.c
> > > +++
> > >
> >
> b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/EventLogInf
> > > +++ o.c
> > > @@ -1,9 +1,9 @@
> > > /** @file
> > >Module for clarifying the content of the smbios structure element info.
> > >
> > > - Copyright (c) 2005 - 2011, Intel Corporation. All rights reserved.
> > >
> > > + Copyright (c) 2005 - 2019, Intel Corporation. All rights reserved.
> > > +
> > >SPDX-License-Identifier: BSD-2-Clause-Patent
> > >
> > > **/
> > >
> > > #include "UefiShellDebug1CommandsLib.h"
> > > @@ -345,20 +345,16 @@ DisplaySysEventLogData (
> > >// Print Log info
> > >//
> > >Offset = 0;
> > >Log = (LOG_RECORD_FORMAT *) LogData;
> > >while (Log != NULL && Log->Type != END_OF_LOG && Offset <
> > > LogAreaLength) {
> > > -//
> > > -// Get a Event Log Record
> > > -//
> > > -Log = (LOG_RECORD_FORMAT *) (LogData + Offset);
> > >
> > > if (Log != NULL) {
> > >//
> > >// Display Event Log Record Information
> > >//
> > > - DisplaySELVarDataFormatType (Log->Type, SHOW_DETAIL);
> > > + DisplaySELTypes (Log->Type, SHOW_DETAIL);
> > >DisplaySELLogHeaderLen (Log->Length, SHOW_DETAIL);
> > >
> > >Offset += Log->Length;
> > >//
> > >// Display Log Header Date/Time Fields @@ -371,10 +367,14 @@
> > > DisplaySysEventLogData (
> > > Print (L"19");
> > >} else if (Log != NULL && Log->Year <= 79) {
> > > Print (L"20");
> > >} else {
> > > ShellPrintHiiEx(-1,-1,NULL,STRING_TOKEN
> > > (STR_SMBIOSVIEW_EVENTLOGINFO_ERROR), gShellDebug1HiiHandle);
> > > +//
> > > +// Get a Event Log Record
> > > +//
> > > +Log = (LOG_RECORD_FORMAT *) (LogData + Offset);
> > > continue;
> > >}
> > >
> > >ShellPrintHiiEx(-1,-1,NULL,
> > >
Re: [edk2-devel] [PATCH v1 1/1] ShellPkg/acpiview: GTDT updates for ACPI 6.3
Pushed as sufficient RB's were received.
> -Original Message-
> From: Gao, Zhichao
> Sent: Sunday, June 09, 2019 8:09 PM
> To: PierreGondois ; devel@edk2.groups.io
> Cc: Carsey, Jaben ; Ni, Ray ;
> sami.muja...@arm.com; matteo.carl...@arm.com; Stephanie.Hughes-
> f...@arm.com; n...@arm.com
> Subject: RE: [PATCH v1 1/1] ShellPkg/acpiview: GTDT updates for ACPI 6.3
> Importance: High
>
> Reviewed-by: Zhichao Gao
>
> I would collect the R-B and send to the maintainer to push.
>
> Thanks,
> Zhichao
>
> > -Original Message-
> > From: PierreGondois [mailto:pierre.gond...@arm.com]
> > Sent: Thursday, June 6, 2019 8:29 PM
> > To: devel@edk2.groups.io
> > Cc: Carsey, Jaben ; Ni, Ray ;
> > Gao, Zhichao ; sami.muja...@arm.com;
> > matteo.carl...@arm.com; stephanie.hughes-f...@arm.com;
> > pierre.gond...@arm.com; n...@arm.com
> > Subject: [PATCH v1 1/1] ShellPkg/acpiview: GTDT updates for ACPI 6.3
> >
> > From: Pierre Gondois
> >
> > The ACPI 6.3 specification introduces support to describe the ARMv8.1
> virtual
> > EL2 timers. This patch updates the GTDT parser of acpiview to decode the
> EL2
> > virtual timer fields.
> >
> > Signed-off-by: Pierre Gondois
> > ---
> >
> > The changes can be seen at:
> >
> https://github.com/PierreARM/edk2/tree/382_acpiview_gtdt_acpi6_3_upd
> > ate_v1
> >
> > Notes:
> > v1:
> > - GTDT updates for ACPI 6.3 [Pierre]
> >
> >
> ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Gtdt/GtdtParser.c
> > | 6 --
> > 1 file changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git
> >
> a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Gtdt/GtdtParser
> > .c
> >
> b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Gtdt/GtdtParser
> > .c
> > index
> >
> 1b7e56486c8fb98a8fe063ae5fa25d86500a58a9..3b05ff3015d4a3af62dd9fab05
> > 7c32369a456267 100644
> > ---
> >
> a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Gtdt/GtdtParser
> > .c
> > +++
> > b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Gtdt/GtdtPars
> > +++ er.c
> > @@ -5,7 +5,7 @@
> >SPDX-License-Identifier: BSD-2-Clause-Patent
> >
> >@par Reference(s):
> > -- ACPI 6.2 Specification - Errata A, September 2017
> > +- ACPI 6.3 Specification - January 2019
> >**/
> >
> > #include
> > @@ -77,7 +77,9 @@ STATIC CONST ACPI_PARSER GtdtParser[] = {
> >{L"Platform Timer Count", 4, 88, L"%d", NULL,
> > (VOID**), NULL, NULL},
> >{L"Platform Timer Offset", 4, 92, L"0x%x", NULL,
> > - (VOID**), NULL, NULL}
> > + (VOID**), NULL, NULL}, {L"Virtual EL2 Timer
> > + GSIV", 4, 96, L"0x%x", NULL, NULL, NULL, NULL}, {L"Virtual EL2 Timer
> > + Flags", 4, 100, L"0x%x", NULL, NULL, NULL, NULL}
> > };
> >
> > /**
> > --
> > 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#42128): https://edk2.groups.io/g/devel/message/42128
Mute This Topic: https://groups.io/mt/31950298/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [Patch 1/2] ShellPkg: Add NetworkPkg/NetworkPkg.dec as the package dependency
Netlib class definition and instance are both moving? Are these modules using MdeModulePkg for a different lib or can we remove it? > -Original Message- > From: Gao, Liming > Sent: Monday, May 20, 2019 6:09 AM > To: devel@edk2.groups.io > Cc: Gao, Zhichao ; Ni, Ray ; > Carsey, Jaben > Subject: [Patch 1/2] ShellPkg: Add NetworkPkg/NetworkPkg.dec as the > package dependency > Importance: High > > NetLib will be moved from MdeModulePkg and NetworkPkg. > So, the module that consumes NetLib need to depend on NetworkPkg.dec. > > Signed-off-by: Liming Gao > Cc: Zhichao Gao > Cc: Ray Ni > Cc: Jaben Carsey > --- > ShellPkg/DynamicCommand/TftpDynamicCommand/TftpApp.inf | 3 > ++- > > ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand. > inf | 3 ++- > .../UefiShellNetwork1CommandsLib/UefiShellNetwork1CommandsLib.inf > | 3 ++- > .../UefiShellNetwork2CommandsLib/UefiShellNetwork2CommandsLib.inf > | 3 ++- > 4 files changed, 8 insertions(+), 4 deletions(-) > > diff --git a/ShellPkg/DynamicCommand/TftpDynamicCommand/TftpApp.inf > b/ShellPkg/DynamicCommand/TftpDynamicCommand/TftpApp.inf > index 9d57e59c63..bc13c89a97 100644 > --- a/ShellPkg/DynamicCommand/TftpDynamicCommand/TftpApp.inf > +++ b/ShellPkg/DynamicCommand/TftpDynamicCommand/TftpApp.inf > @@ -1,7 +1,7 @@ > ## @file > # Provides Shell 'tftp' standalone application. > # > -# Copyright (c) 2010 - 2017, Intel Corporation. All rights reserved. > +# Copyright (c) 2010 - 2019, Intel Corporation. All rights reserved. > # Copyright (c) 2015, ARM Ltd. All rights reserved. > # > # SPDX-License-Identifier: BSD-2-Clause-Patent > @@ -31,6 +31,7 @@ [Packages] >MdePkg/MdePkg.dec >ShellPkg/ShellPkg.dec >MdeModulePkg/MdeModulePkg.dec > + NetworkPkg/NetworkPkg.dec > > [LibraryClasses] >MemoryAllocationLib > diff --git > a/ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicComman > d.inf > b/ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicComman > d.inf > index f23445102a..b0c8e8f84b 100644 > --- > a/ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicComman > d.inf > +++ > b/ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicComman > d.inf > @@ -1,7 +1,7 @@ > ## @file > # Provides Shell 'tftp' dynamic command. > # > -# Copyright (c) 2010 - 2017, Intel Corporation. All rights reserved. > +# Copyright (c) 2010 - 2019, Intel Corporation. All rights reserved. > # Copyright (c) 2015, ARM Ltd. All rights reserved. > # > # SPDX-License-Identifier: BSD-2-Clause-Patent > @@ -32,6 +32,7 @@ [Packages] >MdePkg/MdePkg.dec >ShellPkg/ShellPkg.dec >MdeModulePkg/MdeModulePkg.dec > + NetworkPkg/NetworkPkg.dec > > [LibraryClasses] >MemoryAllocationLib > diff --git > a/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1Com > mandsLib.inf > b/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1Com > mandsLib.inf > index 8054dc6f51..1e6ce63e3e 100644 > --- > a/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1Com > mandsLib.inf > +++ > b/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1Com > mandsLib.inf > @@ -1,7 +1,7 @@ > ## @file > # Provides shell network1 functions > # > -# Copyright (c) 2010 - 2018, Intel Corporation. All rights reserved. > +# Copyright (c) 2010 - 2019, Intel Corporation. All rights reserved. > # > # SPDX-License-Identifier: BSD-2-Clause-Patent > # > @@ -29,6 +29,7 @@ [Packages] >MdePkg/MdePkg.dec >ShellPkg/ShellPkg.dec >MdeModulePkg/MdeModulePkg.dec > + NetworkPkg/NetworkPkg.dec > > [LibraryClasses] >MemoryAllocationLib > diff --git > a/ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2Com > mandsLib.inf > b/ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2Com > mandsLib.inf > index a9ca31a310..9ffcf85248 100644 > --- > a/ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2Com > mandsLib.inf > +++ > b/ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2Com > mandsLib.inf > @@ -1,7 +1,7 @@ > ## @file > # Provides shell network2 functions > # > -# Copyright (c) 2016, Intel Corporation. All rights reserved. > +# Copyright (c) 2016 - 2019, Intel Corporation. All rights reserved. > # > # SPDX-License-Identifier: BSD-2-Clause-Patent > # > @@ -29,6 +29,7 @@ [Packages] >MdePkg/MdePkg.dec >ShellPkg/ShellPkg.dec >MdeModulePkg/MdeModulePkg.dec > + NetworkPkg/NetworkPkg.dec > > [LibraryClasses] >MemoryAllocationLib > -- > 2.13.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#41085): https://edk2.groups.io/g/devel/message/41085 Mute This Topic: https://groups.io/mt/31684909/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH] Maintainers.txt: Add 'Zhichao Gao' for ShellPkg review
Reviewed-by: Jaben Carsey > -Original Message- > From: Gao, Zhichao > Sent: Thursday, May 16, 2019 6:06 PM > To: devel@edk2.groups.io > Cc: Carsey, Jaben ; Ni, Ray ; > Gao, Liming > Subject: [PATCH] Maintainers.txt: Add 'Zhichao Gao' for ShellPkg review > Importance: High > > Add 'Zhichao Gao' as a reviewer for ShellPkg. > > Cc: Jaben Carsey > Cc: Ray Ni > Cc: Liming Gao > Signed-off-by: Zhichao Gao > --- > Maintainers.txt | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Maintainers.txt b/Maintainers.txt index 7315241b6e..6a5f5d6200 > 100644 > --- a/Maintainers.txt > +++ b/Maintainers.txt > @@ -219,6 +219,7 @@ ShellPkg > W: https://github.com/tianocore/tianocore.github.io/wiki/ShellPkg > M: Jaben Carsey > M: Ray Ni > +R: Zhichao Gao > > Maintainers for stable Shell binaries generation when need to publish Shell > binaries with edk2 release: > -- > 2.21.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#40846): https://edk2.groups.io/g/devel/message/40846 Mute This Topic: https://groups.io/mt/31650407/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH] BaseTools: Include headers not mentioned in inf are not hashed
Inline.
tldr: good answers.
If change list to set in name of set object:
Reviewed-by: jaben carsey
> -Original Message-
> From: Rodriguez, Christian
> Sent: Friday, May 10, 2019 8:28 AM
> To: Carsey, Jaben ; devel@edk2.groups.io
> Cc: Feng, Bob C ; Gao, Liming
> ; Zhu, Yonghong
> Subject: RE: [edk2-devel] [PATCH] BaseTools: Include headers not
> mentioned in inf are not hashed
> Importance: High
>
> Replies inline.
>
> >-----Original Message-
> >From: Carsey, Jaben
> >Sent: Thursday, May 9, 2019 4:39 PM
> >To: devel@edk2.groups.io; Rodriguez, Christian
> >
> >Cc: Feng, Bob C ; Gao, Liming
> >; Zhu, Yonghong
> >Subject: RE: [edk2-devel] [PATCH] BaseTools: Include headers not
> mentioned
> >in inf are not hashed
> >
> >Some questions inline.
> >
> >> -Original Message-
> >> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> >> Christian Rodriguez
> >> Sent: Thursday, May 09, 2019 2:27 PM
> >> To: devel@edk2.groups.io
> >> Cc: Feng, Bob C ; Gao, Liming
> >> ; Zhu, Yonghong
> >> Subject: [edk2-devel] [PATCH] BaseTools: Include headers not mentioned
> >> in inf are not hashed
> >>
> >> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1787
> >>
> >> Get a list of local header files that are not present in the MetaFile
> >> for this module. Add those local header files into the hashing
> >> algorithm for a module. If a local header file is not present in the
> >> MetaFile, the module will still build correctly though the hashing
> >> system didn't know about it before.
> >>
> >> Signed-off-by: Christian Rodriguez
> >> Cc: Bob Feng
> >> Cc: Liming Gao
> >> Cc: Yonghong Zhu
> >> ---
> >> BaseTools/Source/Python/AutoGen/AutoGen.py | 24
> >>
> >> 1 file changed, 24 insertions(+)
> >>
> >> diff --git a/BaseTools/Source/Python/AutoGen/AutoGen.py
> >> b/BaseTools/Source/Python/AutoGen/AutoGen.py
> >> index 31721a6f9f..bd282d3ec1 100644
> >> --- a/BaseTools/Source/Python/AutoGen/AutoGen.py
> >> +++ b/BaseTools/Source/Python/AutoGen/AutoGen.py
> >> @@ -4098,8 +4098,10 @@ class ModuleAutoGen(AutoGen):
> >> if self.Name in GlobalData.gModuleHash[self.Arch] and
> >> GlobalData.gBinCacheSource and self.AttemptModuleCacheCopy():
> >> return False
> >> m = hashlib.md5()
> >> +
> >> # Add Platform level hash
> >> m.update(GlobalData.gPlatformHash.encode('utf-8'))
> >> +
> >> # Add Package level hash
> >> if self.DependentPackageList:
> >> for Pkg in sorted(self.DependentPackageList, key=lambda x:
> >> x.PackageName):
> >> @@ -4118,14 +4120,36 @@ class ModuleAutoGen(AutoGen):
> >> Content = f.read()
> >> f.close()
> >> m.update(Content)
> >> +
> >> # Add Module's source files
> >> +localSourceFileList = set()
> >> if self.SourceFileList:
> >> for File in sorted(self.SourceFileList, key=lambda x: str(x)):
> >> +localSourceFileList.add(str(File))
> >> f = open(str(File), 'rb')
> >> Content = f.read()
> >> f.close()
> >> m.update(Content)
> >>
> >> +# Get a list of Module's local header files not included in
> >> metaFile
> >> +localHeaderList = set()
> >> +if self.SourceDir:
> >> +for root, dirs, files in os.walk(self.SourceDir):
> >> +for aFile in files:
> >> +filePath = os.path.join(self.WorkspaceDir,
> >> + os.path.join(root,
> >> aFile))
> >> +if not filePath.endswith(('.h', '.H')):
> >> +continue
> >> +if filePath not in localSourceFileList:
> >
> >Confused about localSourceFileList.
> >Why is it a set and named list?
> >Why not just use self.SourceFileList?
> >
> The naming convention could be better and I can address that in a different
> patch, if we decide to go forward with this idea overall.
> It should probably be named a set.
> The reason to using this new set is for a few reasons:
> 1. self.SourceFileList contains source file paths of class PathClass and not
> type
> str
>
Re: [edk2-devel] [PATCH v3 1/1] ShellPkg/CommandLib: avoid NULL derefence and memory leak
Reviewed-by: Jaben Carsey
Code change looks good visually.
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Heinrich Schuchardt
> Sent: Thursday, May 09, 2019 8:24 PM
> To: Gao, Zhichao
> Cc: devel @ edk2 . groups . io ; Carsey, Jaben
> ; Ni, Ray ; Leif Lindholm
> ; Gao, Liming ; Heinrich
> Schuchardt
> Subject: [edk2-devel] [PATCH v3 1/1] ShellPkg/CommandLib: avoid NULL
> derefence and memory leak
> Importance: High
>
> Since TianoCore EDK2 commit d65f2cea36d1 ("ShellPkg/CommandLib: Locate
> proper UnicodeCollation instance") in edk2 the UEFI Shell crashes if EFI
> variable PlatformLang is not defined due to dereferencing gUnicodeCollation
> gUnicodeCollation (= NULL) in ShellCommandRegisterCommandName().
>
> Furthermore CommandInit() is leaking PlatformLang if
> gUnicodeCollation != NULL.
>
> Close the memory leak and use the first UnicodeCollation instance if
> PlatfomLang is not defined.
>
> Fixes: d65f2cea36d1 ("ShellPkg/CommandLib: Locate proper
> UnicodeCollation
> instance")
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Heinrich Schuchardt
> Reviewed-by: Zhichao Gao
> ---
> v3
> resend as quoted-printable
> ---
> .../UefiShellCommandLib/UefiShellCommandLib.c | 20 +-
> -
> 1 file changed, 14 insertions(+), 6 deletions(-)
>
> diff --git a/ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.c
> b/ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.c
> index ddc4bb1567..e60279e5ac 100644
> --- a/ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.c
> +++ b/ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.c
> @@ -80,12 +80,10 @@ CommandInit(
>EFI_STATUS Status;
>
>CHAR8 *PlatformLang;
>
>
>
> - GetEfiGlobalVariable2 (EFI_PLATFORM_LANG_VARIABLE_NAME,
> (VOID**), NULL);
>
> - if (PlatformLang == NULL) {
>
> -return EFI_UNSUPPORTED;
>
> - }
>
> -
>
>if (gUnicodeCollation == NULL) {
>
> +
>
> +GetEfiGlobalVariable2 (EFI_PLATFORM_LANG_VARIABLE_NAME,
> (VOID**), NULL);
>
> +
>
> Status = gBS->LocateHandleBuffer (
>
> ByProtocol,
>
> ,
>
> @@ -113,6 +111,14 @@ CommandInit(
> continue;
>
>}
>
>
>
> + //
>
> + // Without clue provided use the first Unicode Collation2 protocol.
>
> + //
>
> + if (PlatformLang == NULL) {
>
> +gUnicodeCollation = Uc;
>
> +break;
>
> + }
>
> +
>
>//
>
>// Find the best matching matching language from the supported
> languages
>
>// of Unicode Collation2 protocol.
>
> @@ -132,7 +138,9 @@ CommandInit(
> if (Handles != NULL) {
>
>FreePool (Handles);
>
> }
>
> -FreePool (PlatformLang);
>
> +if (PlatformLang != NULL) {
>
> + FreePool (PlatformLang);
>
> +}
>
>}
>
>
>
>return (gUnicodeCollation == NULL) ? EFI_UNSUPPORTED : EFI_SUCCESS;
>
> --
> 2.20.1
>
>
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
>
> View/Reply Online (#40395): https://edk2.groups.io/g/devel/message/40395
> Mute This Topic: https://groups.io/mt/31573312/1760878
> Group Owner: devel+ow...@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub
> [jaben.car...@intel.com]
> -=-=-=-=-=-=
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#40439): https://edk2.groups.io/g/devel/message/40439
Mute This Topic: https://groups.io/mt/31573312/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH] BaseTools: Include headers not mentioned in inf are not hashed
Some questions inline.
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Christian Rodriguez
> Sent: Thursday, May 09, 2019 2:27 PM
> To: devel@edk2.groups.io
> Cc: Feng, Bob C ; Gao, Liming
> ; Zhu, Yonghong
> Subject: [edk2-devel] [PATCH] BaseTools: Include headers not mentioned in
> inf are not hashed
>
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1787
>
> Get a list of local header files that are not present in the
> MetaFile for this module. Add those local header files into
> the hashing algorithm for a module. If a local header file is
> not present in the MetaFile, the module will still build correctly
> though the hashing system didn't know about it before.
>
> Signed-off-by: Christian Rodriguez
> Cc: Bob Feng
> Cc: Liming Gao
> Cc: Yonghong Zhu
> ---
> BaseTools/Source/Python/AutoGen/AutoGen.py | 24
>
> 1 file changed, 24 insertions(+)
>
> diff --git a/BaseTools/Source/Python/AutoGen/AutoGen.py
> b/BaseTools/Source/Python/AutoGen/AutoGen.py
> index 31721a6f9f..bd282d3ec1 100644
> --- a/BaseTools/Source/Python/AutoGen/AutoGen.py
> +++ b/BaseTools/Source/Python/AutoGen/AutoGen.py
> @@ -4098,8 +4098,10 @@ class ModuleAutoGen(AutoGen):
> if self.Name in GlobalData.gModuleHash[self.Arch] and
> GlobalData.gBinCacheSource and self.AttemptModuleCacheCopy():
> return False
> m = hashlib.md5()
> +
> # Add Platform level hash
> m.update(GlobalData.gPlatformHash.encode('utf-8'))
> +
> # Add Package level hash
> if self.DependentPackageList:
> for Pkg in sorted(self.DependentPackageList, key=lambda x:
> x.PackageName):
> @@ -4118,14 +4120,36 @@ class ModuleAutoGen(AutoGen):
> Content = f.read()
> f.close()
> m.update(Content)
> +
> # Add Module's source files
> +localSourceFileList = set()
> if self.SourceFileList:
> for File in sorted(self.SourceFileList, key=lambda x: str(x)):
> +localSourceFileList.add(str(File))
> f = open(str(File), 'rb')
> Content = f.read()
> f.close()
> m.update(Content)
>
> +# Get a list of Module's local header files not included in metaFile
> +localHeaderList = set()
> +if self.SourceDir:
> +for root, dirs, files in os.walk(self.SourceDir):
> +for aFile in files:
> +filePath = os.path.join(self.WorkspaceDir,
> os.path.join(root,
> aFile))
> +if not filePath.endswith(('.h', '.H')):
> +continue
> +if filePath not in localSourceFileList:
Confused about localSourceFileList.
Why is it a set and named list?
Why not just use self.SourceFileList?
> +localHeaderList.add(filePath)
> +
> +# Add Module's local header files
> +localHeaderList = list(localHeaderList)
> +for File in sorted(localHeaderList):
> +f = open(str(File), 'rb')
> +Content = f.read()
Can you use 'with open(...) as...:' syntax to make sure the file is always
closed?
> +f.close()
> +m.update(Content)
> +
> ModuleHashFile = path.join(self.BuildDir, self.Name + ".hash")
> if self.Name not in GlobalData.gModuleHash[self.Arch]:
> GlobalData.gModuleHash[self.Arch][self.Name] = m.hexdigest()
> --
> 2.19.1.windows.1
>
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#40382): https://edk2.groups.io/g/devel/message/40382
Mute This Topic: https://groups.io/mt/31570019/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v1 1/1] ShellPkg/UefiShellBcfgCommandLib: Fix '-opt' option
Tim, Does this mean you would support such an errata? I would like to get the spec to a place where the behavior is at least nailed down one way or the other... -Jaben > -Original Message- > From: Jonathan Watt [mailto:jw...@jwatt.org] > Sent: Tuesday, May 7, 2019 2:08 PM > To: devel@edk2.groups.io; tim.le...@insyde.com; Carsey, Jaben > ; Gao, Zhichao ; Ni, Ray > > Cc: Bi, Dandan > Subject: Re: [edk2-devel] [PATCH v1 1/1] ShellPkg/UefiShellBcfgCommandLib: > Fix '-opt' option > Importance: High > > No apologies necessary! Raising compatibility concerns is very valid. As I > said, > I just wanted to provide some other considerations I saw to weigh in the > decision. > > All the best, > Jonathan > > On 07/05/2019 22:02, Tim Lewis wrote: > > Jonathan -- > > > > My apologies. I jumped because we've been bitten by shell "clarifications" > in the past. > > > > As you've probably read in the other thread, it turns out that I (we) > > actually > did agree with your interpretation of the spec in our alternate > implementation and have been using it that way for 2+ years. And it didn't > cause us grief with our other product which does use an EDK2-derived shell. > > > > Best regards, > > Tim > > > > -----Original Message- > > From: devel@edk2.groups.io On Behalf Of > > Jonathan Watt > > Sent: Tuesday, May 7, 2019 1:51 PM > > To: Tim Lewis ; 'Carsey, Jaben' > > ; devel@edk2.groups.io; 'Gao, Zhichao' > > ; 'Ni, Ray' > > Cc: 'Bi, Dandan' > > Subject: Re: [edk2-devel] [PATCH v1 1/1] > > ShellPkg/UefiShellBcfgCommandLib: Fix '-opt' option > > > > Hi Tim, > > > > For context, I'm just some random guy who tripped over this issue on his > home workstation and thought he'd try and remove the footgun to save > anyone else the same pain. I was specifically replying to the unconditional > statement "It will break existing scripts." (not made by you) to provide what > I > hope was some qualification and balance to the face value of that statement, > and to suggest some other things that should be considered. As far as > deciding what the best resolution is, I'm not qualified for that. > > > > I am curious about one thing though. The sentence you wrote that ends > with "that are implemented to the specification" sounds like you're saying > making the proposed change would violate the specification. That does not > seem to be the case from my reading, and my reading would be that it would > actually make it do what most people would expect from reading the > specification. > > > > Specifically, the usage block for bcfg in the specification says: > > > > Usage: > > bcfg driver|boot [dump [-v]] > > bcfg driver|boot [add # file "desc"] [addp # file “desc”] > > [addh # handle “desc”] > > bcfg driver|boot [rm #] > > bcfg driver|boot [mv # #] > > bcfg driver|boot [mod # “desc”] | [modf # file] | [modp # file] | > > [modh # handle] > > bcfg driver|boot [-opt # [[filename]|[”data”]] | > > [KeyData *]] > > > > It seems natural to assume from that that the "#" for all options is the > "same thing" and would be handled the same way. > > > > The comment for the -opt option does not indicate otherwise: > > > > -opt > > Modify the optional data associated with a driver or boot option. > > Followed either by the filename of the file which contains the > > binary data to be associated with the driver or boot option > > optional data, or else the quote-delimited data that will be > > associated with the driver or boot option optional data. > > > > In fact the use of the term "driver or boot option" for -opt and the other > options indicates that it is the same thing as for the other options (which > explicitly say that the "#" is a hexadecimal number), even if "#" isn't > described explicitly in this case. > > > > I'm glad to hear there are other implementations, because given the > disagreement over what the spec intends, it would be useful to compare > them and consider converging. > > > > Anyway, that's probably enough from me. :) > > > > Jonathan > > > > On 07/05/2019 21:04, Tim Lewis wrote: > >> Jonathan -- > >> > >> The bcfg command pre-dates the UEFI shell specification. I know of at > least two non-EDK2 implementations, including one maintained by my > company, that are implemented to the specification. S
Re: [edk2-devel] [PATCH v1 1/1] ShellPkg/UefiShellBcfgCommandLib: Fix '-opt' option
It will break existing scripts. Do you have such scripts in your environment dependent on this parameter? > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Tim Lewis > Sent: Tuesday, May 07, 2019 9:20 AM > To: devel@edk2.groups.io; Carsey, Jaben ; Gao, > Zhichao ; Ni, Ray ; > jw...@jwatt.org > Cc: Bi, Dandan > Subject: Re: [edk2-devel] [PATCH v1 1/1] > ShellPkg/UefiShellBcfgCommandLib: Fix '-opt' option > Importance: High > > The question is whether this will break compatibility with existing shell > scripts. In order to maintain that compatibility, it may be necessary to add > a new option rather than trying to update an existing one. > > Tim > > -Original Message----- > From: devel@edk2.groups.io On Behalf Of Carsey, > Jaben > Sent: Tuesday, May 7, 2019 7:36 AM > To: Gao, Zhichao ; devel@edk2.groups.io; Ni, Ray > ; jw...@jwatt.org > Cc: Bi, Dandan > Subject: Re: [edk2-devel] [PATCH v1 1/1] > ShellPkg/UefiShellBcfgCommandLib: > Fix '-opt' option > > Zhichao, > I can help submit errata for shell spec if needed. > > Per patch, > I agree. This looks good. > Reviewed-by: Jaben Carsey > > > > -Original Message- > > From: Gao, Zhichao > > Sent: Tuesday, May 07, 2019 2:52 AM > > To: devel@edk2.groups.io; Ni, Ray ; jw...@jwatt.org > > Cc: Carsey, Jaben ; Bi, Dandan > > > > Subject: RE: [edk2-devel] [PATCH v1 1/1] > > ShellPkg/UefiShellBcfgCommandLib: Fix '-opt' option > > Importance: High > > > > This patch looks good for me. > > Reviewed-by: Zhichao Gao > > > > But when I view the command in UEFI SHELL 2.2 spec: > > ... > > bcfg driver|boot [-opt # [[filename]|["data"]] | [KeyData > UnicodeChar>*]] > > ... > > -opt > > Modify the optional data associated with a driver or boot option. > > Followed either by the filename of the file which contains the binary > > data to be associated with the driver or boot option optional data, or > > else the quote- delimited data that will be associated with the driver > > or boot option optional data. > > ... > > > > This description lack the comment of '#' parameter and that may make > > the consumer confused. Usually consumers would regard it as the same > > in other option, such as ' bcfg driver|boot [rm #]'. The '#' is > > clearly descripted as a hexadecimal parameter: > > rm > > Remove an option. The # parameter lists the option number to remove in > > hexadecimal. > > > > So I think we should update the shell spec by the way. > > > > Thanks, > > Zhichao > > > > > -Original Message- > > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf > > > Of > > Ni, > > > Ray > > > Sent: Monday, May 6, 2019 10:02 PM > > > To: jw...@jwatt.org; devel@edk2.groups.io > > > Cc: Carsey, Jaben ; Bi, Dandan > > > > > > Subject: Re: [edk2-devel] [PATCH v1 1/1] > > ShellPkg/UefiShellBcfgCommandLib: > > > Fix '-opt' option > > > > > > Dandan, > > > Can you please help to review? > > > > > > Thanks, > > > Ray > > > > > > > -Original Message- > > > > From: jw...@jwatt.org [mailto:jw...@jwatt.org] > > > > Sent: Monday, May 6, 2019 9:03 PM > > > > To: devel@edk2.groups.io > > > > Cc: Carsey, Jaben ; Ni, Ray > > > > > > > > Subject: [PATCH v1 1/1] ShellPkg/UefiShellBcfgCommandLib: Fix '-opt' > > > > option > > > > > > > > From: Jonathan Watt > > > > > > > > For all other bcfg commands the "#" (option number) argument(s) > > > > are treated as hexedecimal values regardless of whether or not > > > > they are prefixed by "0x". This change fixes '-opt' to handle its "#" > > > > (option number) argument consistently with the other commands. > > > > > > > > Making this change removes a potential footgun whereby a user that > > > > has been using a number without a "0x" prefix with other bcfg > > > > commands finds that, on using that exact same number with '-opt', > > > > it has this time unexpectedly been interpreted as a decimal number > > > > and they have modified > > > > (corrupted) an unrelated load option. For example, a user may > > > > have been specifying "10" to other commands to have them act on > > > > the 16th option (beca
Re: [edk2-devel] [PATCH v1 1/1] ShellPkg/UefiShellBcfgCommandLib: Fix '-opt' option
Zhichao,
I can help submit errata for shell spec if needed.
Per patch,
I agree. This looks good.
Reviewed-by: Jaben Carsey
> -Original Message-
> From: Gao, Zhichao
> Sent: Tuesday, May 07, 2019 2:52 AM
> To: devel@edk2.groups.io; Ni, Ray ; jw...@jwatt.org
> Cc: Carsey, Jaben ; Bi, Dandan
>
> Subject: RE: [edk2-devel] [PATCH v1 1/1]
> ShellPkg/UefiShellBcfgCommandLib: Fix '-opt' option
> Importance: High
>
> This patch looks good for me.
> Reviewed-by: Zhichao Gao
>
> But when I view the command in UEFI SHELL 2.2 spec:
> ...
> bcfg driver|boot [-opt # [[filename]|["data"]] | [KeyData UnicodeChar>*]]
> ...
> -opt
> Modify the optional data associated with a driver or boot option. Followed
> either by the filename of the file which contains the binary data to be
> associated with the driver or boot option optional data, or else the quote-
> delimited data that will be associated with the driver or boot option optional
> data.
> ...
>
> This description lack the comment of '#' parameter and that may make the
> consumer confused. Usually consumers would regard it as the same in other
> option, such as ' bcfg driver|boot [rm #]'. The '#' is clearly descripted as a
> hexadecimal parameter:
> rm
> Remove an option. The # parameter lists the option number to remove in
> hexadecimal.
>
> So I think we should update the shell spec by the way.
>
> Thanks,
> Zhichao
>
> > -Original Message-
> > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Ni,
> > Ray
> > Sent: Monday, May 6, 2019 10:02 PM
> > To: jw...@jwatt.org; devel@edk2.groups.io
> > Cc: Carsey, Jaben ; Bi, Dandan
> >
> > Subject: Re: [edk2-devel] [PATCH v1 1/1]
> ShellPkg/UefiShellBcfgCommandLib:
> > Fix '-opt' option
> >
> > Dandan,
> > Can you please help to review?
> >
> > Thanks,
> > Ray
> >
> > > -Original Message-
> > > From: jw...@jwatt.org [mailto:jw...@jwatt.org]
> > > Sent: Monday, May 6, 2019 9:03 PM
> > > To: devel@edk2.groups.io
> > > Cc: Carsey, Jaben ; Ni, Ray
> > > Subject: [PATCH v1 1/1] ShellPkg/UefiShellBcfgCommandLib: Fix '-opt'
> > > option
> > >
> > > From: Jonathan Watt
> > >
> > > For all other bcfg commands the "#" (option number) argument(s) are
> > > treated as hexedecimal values regardless of whether or not they are
> > > prefixed by "0x". This change fixes '-opt' to handle its "#"
> > > (option number) argument consistently with the other commands.
> > >
> > > Making this change removes a potential footgun whereby a user that has
> > > been using a number without a "0x" prefix with other bcfg commands
> > > finds that, on using that exact same number with '-opt', it has this
> > > time unexpectedly been interpreted as a decimal number and they have
> > > modified
> > > (corrupted) an unrelated load option. For example, a user may have
> > > been specifying "10" to other commands to have them act on the 16th
> > > option (because simply "10", without any prefix, is how 'bcfg boot
> > > dump' displayed the option number for the 16th option). Unfortunately
> > > for them, if they also use '-opt' with "10" it would unexpectedly and
> > > inconsistently act on the 10th option.
> > >
> > > CC: Jaben Carsey
> > > CC: Ray Ni
> > > Signed-off-by: Jonathan Watt
> > > ---
> > > ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.c
> |
> > > 2
> > > +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git
> > >
> a/ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.c
> > >
> b/ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.c
> > > index d033c7c1dc59..e8b48b4990dd 100644
> > > ---
> > >
> a/ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.c
> > > +++
> > >
> b/ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.c
> > > @@ -1019,7 +1019,7 @@ BcfgAddOpt(
> > >//
> > >// Get the index of the variable we are changing.
> > >//
> > > - Status = ShellConvertStringToUint64(Walker, , FALSE,
> > > TRUE);
> > > + Status = ShellConvertStringToUint64(Walker, , TRUE,
> > > + TRUE);
> > >if (EFI_ERROR(Status) || (((UINT16)Intermediate) != Intermediate)
> > > || StrStr(Walker, L" ") == NULL || ((UINT16)Intermediate) >
> > > ((UINT16)OrderCount)) {
> > > ShellPrintHiiEx(-1, -1, NULL, STRING_TOKEN (STR_GEN_PARAM_INV),
> > > gShellBcfgHiiHandle, L"bcfg", L"Option Index");
> > > ShellStatus = SHELL_INVALID_PARAMETER;
> > > --
> > > 2.21.0
> >
> >
> >
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#40116): https://edk2.groups.io/g/devel/message/40116
Mute This Topic: https://groups.io/mt/31520134/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] Error building Python
Paulo, I would urge you to use the minpython instead of the AppPkg python. The minpython is a python 3 implementation vs. this 2.7 implementation. New development should not start on a version of python that is about to go officially EOL. That being said, I have not seed that error message before. Maybe Daryl has a better starting point. -Jaben > -Original Message- > From: Leif Lindholm [mailto:leif.lindh...@linaro.org] > Sent: Monday, April 29, 2019 9:54 AM > To: devel@edk2.groups.io; phlamo...@riseup.net > Cc: Daryl McDaniel ; Carsey, Jaben > > Subject: Re: [edk2-devel] Error building Python > Importance: High > > +AppPkg maintainers > > On Sun, Apr 28, 2019 at 09:25:28PM -0700, phlamo...@riseup.net wrote: > > I want to use python to prototype some UEFI applications, but the build > > is not working on my environment, im trying to build in a linux(debian) > > which have "gcc (Debian 6.3.0-18+deb9u1) 6.3.0 20170516" installed, the > > EDK2 is properly installed, i build other packages like OVMF and Mde*, > > at the first time i tried to build Python just uncommenting > > "AppPkg/Applications/Python/PythonCore.inf" the build stopped because > > some compiler warnings which are stopping the building bcause the flag > > -Werror, so i changed the file tools_def.txt to remove the -Werror flag, > > the warnings dont stopped the build, i probably should fix the warnings > > one by one, but when i tried to build again the build system stopped at > > target > > > '/root/projeto_final/src/edk2/Build/AppPkg/DEBUG_GCC5/X64/AppPkg/Ap > plications/Python/PythonCore/DEBUG/Python.dll', > > i will leave the entire error message following this message, let me > > know if i need to provide another/more information. > > > > -- > > pymath.obj (symbol from plugin): In function `_Py_get_387controlword': > > (.text+0x0): multiple definition of `copysign' > > s_copysign.obj (symbol from plugin):(.text+0x0): first defined here > > collect2: error: ld returned 1 exit status > > GNUmakefile:583: recipe for target > > > '/root/projeto_final/src/edk2/Build/AppPkg/DEBUG_GCC5/X64/AppPkg/Ap > plications/Python/PythonCore/DEBUG/Python.dll' > > failed > > make: *** > > > [/root/projeto_final/src/edk2/Build/AppPkg/DEBUG_GCC5/X64/AppPkg/Ap > plications/Python/PythonCore/DEBUG/Python.dll] > > Error 1 > > > > build.py... > > : error 7000: Failed to execute command > > make tbuild > > > [/root/projeto_final/src/edk2/Build/AppPkg/DEBUG_GCC5/X64/AppPkg/Ap > plications/Python/PythonCore] > > > > build.py... > > : error F002: Failed to build module > > > > /root/projeto_final/src/edk2/AppPkg/Applications/Python/PythonCore.inf > > [X64, GCC5, DEBUG] > > > > - Failed - > > Build end time: 06:56:21, Apr.28 2019 > > Build total time: 00:05:32 > > -- > > > > Thanks, > > Paulo Amorim > > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#39860): https://edk2.groups.io/g/devel/message/39860 Mute This Topic: https://groups.io/mt/31387171/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [edk2][edk2-libc/master V2]Request to add new edk2-libc repository
The 3 new commits look good. Reviewed-by: Jaben Carsey > -Original Message- > From: Kinney, Michael D > Sent: Thursday, April 25, 2019 5:56 PM > To: devel@edk2.groups.io; Kinney, Michael D > Cc: Carsey, Jaben ; Daryl McDaniel (edk2- > li...@mc2research.org) ; > leif.lindh...@linaro.org; Andrew Fish (af...@apple.com) > ; Laszlo Ersek > (ler...@redhat.com) > Subject: [edk2][edk2-libc/master V2]Request to add new edk2-libc repository > Importance: High > > Hello, > > New in V2 > = > * Add details to Readme.md on how the history for these > three packages was exported from the edk2 repository > using git filter-branch. > * Remove redundant content in edk2-libc Readme.md and > Maintainters.txt and instead point to content in edk2 > repository. > * Mark the sections of Maintainers.txt that need further > discussion as TBD. > * Update installation and build instructions in the > Readme.txt files in AppPkg and StdLib. > * Fix a warning in StdLib when building with VS2015. > > > There were no objections to the following RFC to add a new edk2-libc > repository. > > https://edk2.groups.io/g/devel/message/35211 > > I have entered the following Feature Request Bugzilla > > https://bugzilla.tianocore.org/show_bug.cgi?id=1734 > > I have posted a version of the edk2-libc repository for review at the > following > location. It includes all the history for the three packages from the edk2 > repository. > > https://github.com/mdkinney/edk2-libc/tree/master_V2 > > Please review this branch. There are 3 additional commits: > > * Update the Readme.md and Maintainers.txt that scopes them > to this new edk2-libc repository. > > https://github.com/mdkinney/edk2- > libc/commit/62cfdf929f15edba7f7bcbbdb01e4dc50d2c81a7 > > * Update Readme.txt in AppPkg and StdLib to describe how to > install both the edk2-libc repository and the edk2 > repository and set PACKAGES_PATH to support builds. > > https://github.com/mdkinney/edk2- > libc/commit/d004f93626b3bb962c24500db6ec7284db074c9a > > * Fix a minor issue that removes warnings when building > edk2-libc packages with VS2015 toolchains. > > https://github.com/mdkinney/edk2- > libc/commit/145d262e94182a6b4631e0b6df5bc5d67e209931 > > Best regards, > > Mike -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#39610): https://edk2.groups.io/g/devel/message/39610 Mute This Topic: https://groups.io/mt/31348602/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [patch] ShellBinPkg: Remove ShellBinPkg
Assuming Laszlo's comment is addressed. Reviewed-by: Jaben Carsey > -Original Message- > From: Bi, Dandan > Sent: Wednesday, April 17, 2019 6:12 PM > To: Laszlo Ersek ; Ard Biesheuvel > > Cc: edk2-devel-groups-io ; Carsey, Jaben > ; Ni, Ray ; Leif Lindholm > ; Gao, Liming > Subject: RE: [patch] ShellBinPkg: Remove ShellBinPkg > Importance: High > > Thank you all. > I will update the patch according to Laszlo's comments before commit the > patch. > > > Thanks, > Dandan > > -Original Message- > > From: Laszlo Ersek [mailto:ler...@redhat.com] > > Sent: Wednesday, April 17, 2019 6:53 PM > > To: Ard Biesheuvel ; Bi, Dandan > > > > Cc: edk2-devel-groups-io ; Carsey, Jaben > > ; Ni, Ray ; Leif Lindholm > > ; Gao, Liming > > Subject: Re: [patch] ShellBinPkg: Remove ShellBinPkg > > > > On 04/17/19 09:16, Ard Biesheuvel wrote: > > > On Tue, 16 Apr 2019 at 23:40, Dandan Bi wrote: > > >> > > >> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1675 > > >> > > >> Remove ShellBinPkg from edk2. > > >> If developers work on current edk2 master and still want to use > > >> Shell binary after this removal, they can get it from source code > > >> in the Assets part of edk2-stable201903 tag release page. > > >> And from next release (edk2-stable201905 tag), we will publish all > > >> Shell binaries to the according Assets part directly. > > >> edk2 release link: https://github.com/tianocore/edk2/releases > > >> > > >> Cc: Jaben Carsey > > >> Cc: Ray Ni > > >> Cc: Leif Lindholm > > >> Cc: Ard Biesheuvel > > >> Cc: Liming Gao > > >> Cc: Laszlo Ersek > > >> Signed-off-by: Dandan Bi > > > > > > Acked-by: Ard Biesheuvel > > > > > > BTW you can use the --no-binary option to git to omit the binary > > > diffs in the patch. Especially when deleting binaries, that saves a > > > lot of hassle dealing with a multimegabyte patch email. > > > > +1 > > > > For the patch, I have a request towards Dandan: regarding the line > > > > +Maintainers for stable Shell binaries generation when need to publish > > +Shell > > binaries with edk2 release: > > > > please: > > > > (1) wrap it with an 80-char margin, > > (2) please insert a blank line just above it. > > > > With those: > > > > Acked-by: Laszlo Ersek > > > > Thanks > > Laszlo -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#39381): https://edk2.groups.io/g/devel/message/39381 Mute This Topic: https://groups.io/mt/31209298/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [Patch] edk2: Remove AppPkg, StdLib, StdLibPrivateInternalFiles
Reviewed-by: Jaben Carsey > -Original Message- > From: Kinney, Michael D > Sent: Friday, April 19, 2019 5:17 PM > To: devel@edk2.groups.io > Cc: Carsey, Jaben ; Daryl McDaniel li...@mc2research.org> > Subject: [Patch] edk2: Remove AppPkg, StdLib, StdLibPrivateInternalFiles > Importance: High > > https://bugzilla.tianocore.org/show_bug.cgi?id=1734 > > Remove the following packages and move them to the new edk2-libc > repository > > * AppPkg > * StdLib > * StdLibPrivateInternalFiles > > Cc: Jaben Carsey > Cc: Daryl McDaniel > Signed-off-by: Michael D Kinney > --- > AppPkg > Maintainers.txt |10 - > Readme.md | 3 - > StdLib > StdLibPrivateInternalFiles > > > diff --git a/Maintainers.txt b/Maintainers.txt index 10c11b5dc5..a0f8d541d0 > 100644 > --- a/Maintainers.txt > +++ b/Maintainers.txt > @@ -63,11 +63,6 @@ M: Liming Gao > > EDK II Packages: > > -AppPkg > -W: https://github.com/tianocore/tianocore.github.io/wiki/AppPkg > -M: Daryl McDaniel > -M: Jaben Carsey > - > ArmPkg > W: https://github.com/tianocore/tianocore.github.io/wiki/ArmPkg > M: Leif Lindholm @@ -260,11 +255,6 @@ > SourceLevelDebugPkg > W: > https://github.com/tianocore/tianocore.github.io/wiki/SourceLevelDebugPkg > M: Hao Wu > > -StdLib, StdLibPrivateInternalFiles > -W: https://github.com/tianocore/tianocore.github.io/wiki/StdLib > -M: Daryl McDaniel > -M: Jaben Carsey > - > UefiCpuPkg > W: https://github.com/tianocore/tianocore.github.io/wiki/UefiCpuPkg > M: Eric Dong > diff --git a/Readme.md b/Readme.md > index 177d51972a..1feba16075 100644 > --- a/Readme.md > +++ b/Readme.md > @@ -6,9 +6,6 @@ for the UEFI and PI specifications from www.uefi.org. > The majority of the content in the EDK II open source project uses a [BSD-2- > Clause Plus Patent License](License.txt). The EDK II open source project > contains the following components that are covered by additional licenses: > -* [AppPkg/Applications/Python/Python- > 2.7.2/Tools/pybench](AppPkg/Applications/Python/Python- > 2.7.2/Tools/pybench/LICENSE) > -* [AppPkg/Applications/Python/Python- > 2.7.2](AppPkg/Applications/Python/Python-2.7.2/LICENSE) > -* [AppPkg/Applications/Python/Python- > 2.7.10](AppPkg/Applications/Python/Python-2.7.10/LICENSE) > * > [BaseTools/Source/C/BrotliCompress](BaseTools/Source/C/BrotliCompress/L > ICENSE) > * > [MdeModulePkg/Library/BrotliCustomDecompressLib](MdeModulePkg/Libra > ry/BrotliCustomDecompressLib/LICENSE) > * > [BaseTools/Source/C/LzmaCompress](BaseTools/Source/C/LzmaCompress/L > ZMA-SDK-README.txt) -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#39351): https://edk2.groups.io/g/devel/message/39351 Mute This Topic: https://groups.io/mt/31251276/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [edk2] [PATCH V3] Change EDK II to BSD+Patent License
The packages I am maintainer of look good to me. Reviewed-by: Jaben Carsey > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Michael D Kinney > Sent: Wednesday, April 03, 2019 4:42 PM > To: devel@edk2.groups.io; Kinney, Michael D > Subject: [edk2-devel] [edk2] [PATCH V3] Change EDK II to BSD+Patent > License > > Hello, > > New in V3 > = > * Update the base of the patch series from edk2-stable201903 to > 7ed72121b7 that is after the file add/remove freeze: > > https://lists.01.org/pipermail/edk2-devel/2019-April/038574.html > > * Replace copyright line in License.txt in root with a single copyright > for "TianoCore and contributors". > * Clarify commit message for changes to License.txt to state the text > differences are larger than expected due to differences in line breaks. > * There is one less patch in the series than V2 due to the retirement > of the EdkCompatibilityPkg. > * The git feature "git range-diff" can be used to compare the V2 and > V3 branches even though they have different bases. If you have both > the V2 and V3 branches in your local repo, you can use the following > command to see the changes. Most are due to the removal of .S files > in March. If you pipe through grep looking for "diff --git" you will > see the list of files with differences. > > git range-diff edk2-stable201903..Bug_1373_BsdPatentLicense_V2 > 7ed72121b7..Bug_1373_BsdPatentLicense_V3 > > New in V2 > = > * Remove Cc lines from commit messages > * Remove branch reference from commit messages > * Change license in 2 files missed in OvmfPkg > * Update OvmfPkg/License.txt to BSD+Patent as the default license > * Move the portions of Contributions.txt in the root of edk2 to > Readme.md in the root of edk2 that describe how to contribute > along with the commit message format. > * Add to Readme.md in the root of edk2 that Signed-off-by means that > the contributor certifies compliance to the Developer's Certificate > of Origin 1.1. https://developercertificate.org > = > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1373 > > This change is based on the following emails: > https://lists.01.org/pipermail/edk2-devel/2019-February/036260.html > https://lists.01.org/pipermail/edk2-devel/2018-October/030385.html > > RFCs with detailed process for the license change: > V3: https://lists.01.org/pipermail/edk2-devel/2019-March/038116.html > V2: https://lists.01.org/pipermail/edk2-devel/2019-March/037669.html > V1: https://lists.01.org/pipermail/edk2-devel/2019-March/037500.html > > I have posted the patch series for review on the following branch using > 7ed72121b7 as the base for the patch series. > > https://github.com/mdkinney/edk2/tree/Bug_1373_BsdPatentLicense_V3 > > The commits in patch series can be viewed here: > > > https://github.com/mdkinney/edk2/commits/Bug_1373_BsdPatentLicense_ > V3 > > The patch series has one patch per package along with a few patches > to update the license information in the root of the edk2 repository > as described in the RFC V3. > > Due to the size of the patch series, I prefer to not send the > patch emails. Instead, please perform code reviews using content > from the branch. > > All EDK II package maintainers and package reviewers should provide > review feedback for their packages. The critical part of the review > is: > 1) Any changes that cause build breaks or logic changes. These code >changes are intended to only modify license contents in comment >blocks. > 2) Any file that has been changed to BSD+Patent, but should remain >with the current license. > 3) Any file that that has not changed to BSD+Patent, but should be >changed to BSD+Patent. > > Feedback and Reviewed-by emails should identify the patch the feedback > applies using the patch summary listed below. The goal is to complete > all reviews to support the commit of these patches on April 9, 2019. > > eece5f8a6e edk2: Remove Contributions.txt and update Readme.md > 224dce1ae5 OvmfPkg: Change License.txt from 2-Clause BSD to BSD+Patent > f3cbc2ffc7 StdLibPrivateInternalFiles: Replace BSD License with BSD+Patent > License > 845b945044 StdLib: Replace BSD License with BSD+Patent License > e55c8532c9 AppPkg: Replace BSD License with BSD+Patent License > a6df2af909 Vlv2TbltDevicePkg: Replace BSD License with BSD+Patent License > 6360b3f3af Vlv2DeviceRefCodePkg: Replace BSD License with BSD+Patent > License > a67328cbb4 UefiCpuPkg: Replace BSD License with BSD+Patent License > 248d91c908 StandaloneMmPkg: Replace BSD License with BSD+Patent > License > 415927330c SourceLevelDebugPkg: Replace BSD License with BSD+Patent > License > 4cd6c3f31f SignedCapsulePkg: Replace BSD License with BSD+Patent License > 9ffa4947d3 ShellPkg: Replace BSD License with BSD+Patent License > fdb6510955 ShellBinPkg: Replace BSD License with BSD+Patent License > dc5f8d93d9 SecurityPkg:
