[edk2-devel] [PATCH v3 2/2] Add VS2019 Support on ToolSetup Batches

2019-09-19 Thread Cheng, Ching JenX
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2182 Inorder to support VS2019, we add VS2019 config process in Setup Batch Files, Because VS2019 and VS2017 could using same vswhere.exe to detect the InstallationPath, So we add the -version as the parameter of vswhere to get the correct

[edk2-devel] [PATCH v3 0/2] *** Add VS2019 Support ***

2019-09-19 Thread Cheng, Ching JenX
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2182 In order to support VS2019 on EDK2, the following patches was modified def and batch files 1. Add VS2019 x86/64 definitions on tools_def.template 2. Add VS2019 support on toolsetup batches, and add version check with command vswhere

[edk2-devel] [PATCH v3 1/2] Add VS2019 Toolchain def

2019-09-19 Thread Cheng, Ching JenX
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2182 In order to support VS2019, the first thing need to do is add 2019 toolchain on tools_def.template v2: add ARM/AARCH64/EBC Definitions, Combine VS2017_HOST and VS2019_HOST to VS_HOST Cc: Amy Chan Cc: Bob Feng Cc: Liming Gao

Re: [edk2-devel] [PATCH v2 2/2] Add VS2019 Support on ToolSetup Batches

2019-09-19 Thread Cheng, Ching JenX
Hi Liming, Ok, Thanks for your comments, I will prepare the patch V3 with your comments, Thanks, Best Regards, Allen > -Original Message- > From: Gao, Liming > Sent: Thursday, September 19, 2019 4:24 PM > To: Cheng, Ching JenX ; > devel@edk2.groups.io > Cc: Chan,

Re: [edk2-devel] [PATCH v2 0/2] *** Add VS2019 Support ***

2019-09-17 Thread Cheng, Ching JenX
Hi Liming, The VS2017 is still working fine with this changes, I have verified it with VS2019, VS2017 and VS2015 build, Thanks, Allen > -Original Message- > From: Gao, Liming > Sent: Tuesday, September 17, 2019 10:57 PM > To: devel@edk2.groups.io; Cheng, Ching JenX >

Re: [edk2-devel] [PATCH v2 0/2] *** Add VS2019 Support ***

2019-09-16 Thread Cheng, Ching JenX
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2182 In order to support VS2019 on EDK2, the following patches was modified def and batch files 1. Add VS2019 x86/64 definitions on tools_def.template 2. Add VS2019 support on toolsetup batches, and add version check with command vswhere

[edk2-devel] [PATCH v2 2/2] Add VS2019 Support on ToolSetup Batches

2019-09-16 Thread Cheng, Ching JenX
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2182 Inorder to support VS2019, we add VS2019 config process in Setup Batch Files, Because VS2019 and VS2017 could using same vswhere.exe to detect the InstallationPath, So we add the -version as the parameter of vswhere to get the correct

[edk2-devel] [PATCH v2 1/2] Add VS2019 Toolchain def

2019-09-16 Thread Cheng, Ching JenX
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2182 In order to support VS2019, the first thing need to do is add 2019 toolchain on tools_def.template v2: add ARM/AARCH64/EBC Definitions, Combine VS2017_HOST and VS2019_HOST to VS_HOST Cc: Amy Chan Cc: Bob Feng Cc: Liming Gao

[edk2-devel] [PATCH v2 0/2] *** Add VS2019 Support ***

2019-09-16 Thread Cheng, Ching JenX
In order to support VS2019 on EDK2, the following patches was modified def and batch files 1. Add VS2019 x86/64 definitions on tools_def.template 2. Add VS2019 support on toolsetup batches, and add version check with command vswhere Because VS2019 and VS2017 using the same vswhere to get

Re: [edk2-devel] [PATCH 0/2] *** Add VS2019 Support ***

2019-09-11 Thread Cheng, Ching JenX
From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Cheng, Ching JenX Sent: Wednesday, September 11, 2019 2:08 PM To: devel@edk2.groups.io Subject: [edk2-devel] [PATCH 0/2] *** Add VS2019 Support *** REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2182 In order to support

[edk2-devel] [PATCH 2/2] Add VS2019 Support on ToolSetup Batches

2019-09-11 Thread Cheng, Ching JenX
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2182 Inorder to support VS2019, we add VS2019 config process in Setup Batch Files, Because VS2019 and VS2017 could using same vswhere.exe to detect the InstallationPath, So we add the -version as the parameter of vswhere to get the correct

[edk2-devel] [PATCH 1/2] Add VS2019 Toolchain def

2019-09-11 Thread Cheng, Ching JenX
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2182 In order to support VS2019, the first thing need to do is add 2019 toolchain on tools_def.template Change-Id: Id52abdc9762cf06bb9a38bbfd1153608c878d839 Cc: Amy Chan Cc: Bob Feng Cc: Liming Gao Signed-off-by: Ching JenX Cheng ---

[edk2-devel] [PATCH 0/2] *** Add VS2019 Support ***

2019-09-11 Thread Cheng, Ching JenX
*** BLURB HERE *** Ching JenX Cheng (2): Add VS2019 Toolchain def Add VS2019 Support on ToolSetup Batches BaseTools/Conf/tools_def.template | 134 ++

[edk2-devel] [PATCH] Add VS2019 Toolchain def

2019-09-09 Thread Cheng, Ching JenX
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2182 In order to support VS2019, the first thing need to do is add 2019 toolchain on tools_def.template Change-Id: Id52abdc9762cf06bb9a38bbfd1153608c878d839 Cc: Amy Chan Cc: Bob Feng Cc: Liming Gao Signed-off-by: Ching JenX Cheng ---

[edk2-devel] [edk2-platforms: PATCH v2] Python run fail if env variable PYTHON_HOME is not set

2019-08-19 Thread Cheng, Ching JenX
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=2041 [PATCH v2] Update related files In Platform\Intel\MinPlatformPkg\Tools\Fsp\RebaseFspBinBaseAddress.py It will run another python code. But if the environment variable "PYTHON_HOME" is not exist and we didn't add any python's path to "PATH".

[edk2-devel] [PATCH] Python run fail if env variable PYTHON_HOME is not set

2019-08-19 Thread Cheng, Ching JenX
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=2041 In Platform\Intel\MinPlatformPkg\Tools\Fsp\RebaseFspBinBaseAddress.py It will run another python code. But if the environment variable "PYTHON_HOME" is not exist and we didn't add any python's path to "PATH". It will cause error because

[edk2-devel] [PATCH v2] * IntelFsp2Pkg: Improve FSP Python scripts to support 3.x.

2019-08-01 Thread Cheng, Ching JenX
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=2041 [PATCH v2] Update commit message for more detail description When running with Python 3.x and relying on GenCfgOpt.py to automatically assign UPD offsets, the script crashed because some float type variable not compatible with the

[edk2-devel] [PATCH] * IntelFsp2Pkg: Improve FSP Python scripts to support 3.x.

2019-08-01 Thread Cheng, Ching JenX
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=2041 Improve Python3.x support with IntelFsp2Pkg/Tools/GenCfgOpt.py, Base on <<, print('%x' % ) is only support for int, not float. Cc: Amy Chan Cc: Chasel Chiu Cc: Nate DeSimone Cc: Star Zeng Signed-off-by: Ching JenX Cheng ---