Re: [edk2-devel] [PATCH v6 0/3] IntelFsp2Pkg: Fsp T new ARCH UPD Support

2024-04-05 Thread Chiu, Chasel
Thanks for taking all the feedbacks and update patches. For the patch series: Reviewed-by: Chasel Chiu > -Original Message- > From: devel@edk2.groups.io On Behalf Of cbduggap > Sent: Friday, April 5, 2024 10:06 AM > To: devel@edk2.groups.io > Subject: [edk2-devel] [PATCH v6 0/3]

Re: [edk2-devel] [PATCH v5] IntelFsp2Pkg: Fsp T new ARCH UPD Support

2024-04-03 Thread Chiu, Chasel
mone, Nathaniel > L ; Chiu, Chasel ; > Duggapu, Chinni B > Subject: [edk2-devel] [PATCH v5] IntelFsp2Pkg: Fsp T new ARCH UPD Support > > Changes to support spec changes > > 1. Remove usage of Pcd. > 2. Change code to validate the Temporary Ram size input. > 3. Consume th

Re: [edk2-devel] [edk2-platforms V2 3/3] MinPlatformPkg: Sort ApicIdOrderTable by special rules

2024-04-02 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu Thanks, Chasel > -Original Message- > From: Tan, Dun > Sent: Sunday, March 31, 2024 11:04 PM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Lou, Yun ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Liming Gao ; > Dong, Eric > Subj

Re: [edk2-devel] [edk2-platforms V2 2/3] MinPlatformPkg: Get CoreType for all cores

2024-04-02 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu Thanks, Chasel > -Original Message- > From: Tan, Dun > Sent: Sunday, March 31, 2024 11:04 PM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Lou, Yun ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Liming Gao ; > Dong, Eric > Subj

Re: [edk2-devel] [edk2-platforms V2 1/3] MinPlatformPkg: Remove the global variable mForceX2ApicId

2024-04-02 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu Thanks, Chasel > -Original Message- > From: Tan, Dun > Sent: Sunday, March 31, 2024 11:04 PM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Lou, Yun ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Liming Gao ; > Dong, Eric > Subj

Re: [edk2-devel] [edk2-platforms V2] MinPlatformPkg: Corret AcpiProcessorUid in MADT

2024-04-02 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu Thanks, Chasel > -Original Message- > From: Tan, Dun > Sent: Sunday, March 31, 2024 11:00 PM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Lou, Yun ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Liming Gao ; > Dong, Eric >

Re: [edk2-devel] [edk2-platforms: PATCH v2] MinPlatformPkg: Add missed call to FreePool

2024-04-01 Thread Chiu, Chasel
Patch pushed: https://github.com/tianocore/edk2-platforms/commit/ce4b8e394077f7f10ace2c6e96767f676c000355 Thanks, Chasel > -Original Message- > From: Pabba, PhanindraX Babu > Sent: Wednesday, March 27, 2024 2:27 PM > To: devel@edk2.groups.io > Cc: Pabba, Phanind

Re: [edk2-devel] [edk2-platforms: PATCH v2] MinPlatformPkg: Add missed call to FreePool

2024-03-27 Thread Chiu, Chasel
Thanks Phanindra! Reviewed-by: Chasel Chiu > -Original Message- > From: Pabba, PhanindraX Babu > Sent: Wednesday, March 27, 2024 2:27 PM > To: devel@edk2.groups.io > Cc: Pabba, PhanindraX Babu ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Liming Gao ; > Dong

Re: [edk2-devel] [PATCH] IpmiFeaturePkg: Add missed call to FreePool

2024-03-25 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu Thanks, Chasel > -Original Message- > From: devel@edk2.groups.io On Behalf Of > phanindrax.babu.pa...@intel.com > Sent: Thursday, February 22, 2024 10:52 PM > To: devel@edk2.groups.io > Cc: Pabba, PhanindraX Babu ; Desimone, > Nathaniel L ; Liming Gao > >

Re: [edk2-devel] [PATCH v1] PurleyOpenBoardPkg/TiogaPass: Fix Build

2024-02-23 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu Thanks, Chasel > -Original Message- > From: Desimone, Nathaniel L > Sent: Friday, February 9, 2024 2:48 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel > Subject: [PATCH v1] PurleyOpenBoardPkg/TiogaPass: Fix Build > >

Re: [edk2-devel] [PATCH] MinPlatformPkg/PhatAcpiLib: Add to CoreDxeLib dsc

2024-02-23 Thread Chiu, Chasel
Patch merged: https://github.com/tianocore/edk2-platforms/commit/e19e5d583d204a2011cab42e7b669ed274d1a8fb Thanks, Chasel > -Original Message- > From: Clark-williams, Zachary > Sent: Tuesday, February 20, 2024 9:18 PM > To: devel@edk2.groups.io > Cc: Clark-williams,

Re: [edk2-devel] [PATCH] MinPlatformPkg/PhatAcpiLib: Add to CoreDxeLib dsc

2024-02-20 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu Thanks, Chasel > -Original Message- > From: Clark-williams, Zachary > Sent: Tuesday, February 20, 2024 9:18 PM > To: devel@edk2.groups.io > Cc: Clark-williams, Zachary ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Liming Gao ; > Dong,

Re: [edk2-devel] [PATCH] MinPlatformPkg/DxePhatLib: Add to CoreCommon dsc

2024-02-20 Thread Chiu, Chasel
e- > From: Clark-williams, Zachary > Sent: Tuesday, February 20, 2024 1:42 PM > To: devel@edk2.groups.io > Cc: Clark-williams, Zachary ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Liming Gao ; > Dong, Eric > Subject: [PATCH] MinPlatformPkg/DxePhatLib: Add to CoreCommon

Re: [edk2-devel] [PATCH 2/2] Update Maintainers for Intel packages

2024-02-20 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu Thanks, Chasel > -Original Message- > From: Haller, Nathaniel D > Sent: Friday, February 16, 2024 5:48 PM > To: devel@edk2.groups.io > Cc: Desimone, Nathaniel L ; Chiu, Chasel > > Subject: [PATCH 2/2] Update Maintainers for Intel

Re: [edk2-devel] [PATCH 1/2] Add maintainers for EaglestreamSiliconBinPkg and EaglestreamOpenBoardBinPkg

2024-02-20 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu Thanks, Chasel > -Original Message- > From: Haller, Nathaniel D > Sent: Friday, February 16, 2024 5:47 PM > To: devel@edk2.groups.io > Cc: Desimone, Nathaniel L ; Chiu, Chasel > > Subject: [PATCH 1/2] Add maintainers for Eag

Re: [edk2-devel] [PATCH v2] UefiPayloadPkg/Crypto: Support external Crypto drivers.

2024-01-25 Thread Chiu, Chasel
Thanks Gua! Reviewed-by: Chasel Chiu > -Original Message- > From: Guo, Gua > Sent: Wednesday, January 24, 2024 9:09 PM > To: devel@edk2.groups.io > Cc: Guo, Gua ; Chiu, Chasel ; > Dong, Guo ; Rhodes, Sean ; Lu, > James > Subject: [PATCH v2] UefiPayloadPkg/

Re: [edk2-devel] [PATCH v1] Platform/Intel: Specifies SmmCpuSyncLib instance

2023-12-21 Thread Chiu, Chasel
Patch merged: https://github.com/tianocore/edk2-platforms/commit/9c9a4821e0866f219f1d03ba24a6a433ea408223 Thanks, Chasel > -Original Message- > From: Wu, Jiaxin > Sent: Wednesday, December 20, 2023 7:42 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimo

Re: [edk2-devel] [PATCH v1] Platform/Intel: Specifies SmmCpuSyncLib instance

2023-12-21 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu Thanks, Chasel > -Original Message- > From: Wu, Jiaxin > Sent: Wednesday, December 20, 2023 7:42 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Kinney, Michael D > ; Gao, Liming ; Ni, > Ray > Subject

Re: [edk2-devel] [PATCH] [Patch V2]IntelFsp2Pkg\Tools\ConfigEditor: Added new USF config workstream.

2023-12-05 Thread Chiu, Chasel
ginal Message- > From: Soundara Pandian, Arun SuraX > Sent: Thursday, November 23, 2023 11:29 PM > To: devel@edk2.groups.io > Cc: Soundara Pandian, Arun SuraX ; > Chiu, Chasel ; Duggapu, Chinni B > ; Desimone, Nathaniel L > ; Ng, Ray Han Lim > ; Zeng, Star ; Kuo, Ted >

Re: [edk2-devel] [PATCH v1] MinPlatformPkg: Remove PeiDxeTpmPlatformHierarchyLib

2023-12-04 Thread Chiu, Chasel
Patch pushed: https://github.com/tianocore/edk2-platforms/commit/f446fff05003f69a4396b2ec375301ecb5f63a2a Thanks, Chasel > -Original Message- > From: Chiang, Chris > Sent: Monday, December 4, 2023 12:51 AM > To: devel@edk2.groups.io > Cc: Chiang, Chris ; Chiu, Chas

Re: [edk2-devel] [PATCH v1] MinPlatformPkg: Remove PeiDxeTpmPlatformHierarchyLib

2023-12-04 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu Thanks, Chasel > -Original Message- > From: Chiang, Chris > Sent: Monday, December 4, 2023 12:51 AM > To: devel@edk2.groups.io > Cc: Chiang, Chris ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Gao, Liming ; > Dong, Eric > Subject

Re: [edk2-devel] [edk2-platforms][PATCH v1] Intel-MinPlatform: Fix DxeCore Build Failures

2023-11-30 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu Thanks, Chasel > -Original Message- > From: Desimone, Nathaniel L > Sent: Thursday, November 30, 2023 4:06 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Ni, Ray ; > Chaganty, > Rangasai V ; Gao, Liming > ; Kinney, Michael D ;

Re: [edk2-devel] [PATCH v3 1/1] MdeModulePkg: Fix issue with ACPI table creation

2023-11-28 Thread Chiu, Chasel
Thanks for update! Change looks good to me. Acked-by: Chasel Chiu > -Original Message- > From: devel@edk2.groups.io On Behalf Of Dhaval > Sharma > Sent: Sunday, November 19, 2023 8:24 PM > To: devel@edk2.groups.io > Cc: Gao, Liming ; Liu, Zhiguang > ; Bi, Dandan > Subject:

Re: [edk2-devel] [edk2-platforms PATCH 1/2] WhitleyOpenBoardPkg: remove references

2023-11-27 Thread Chiu, Chasel
> -Original Message- > From: Pedro Falcato > Sent: Monday, November 27, 2023 3:14 PM > To: devel@edk2.groups.io; Chiu, Chasel > Cc: Laszlo Ersek ; Chaganty, Rangasai V > ; Desimone, Nathaniel L > > Subject: Re: [edk2-devel] [edk2-platforms PATCH 1/2] Whitl

Re: [edk2-devel] [edk2-platforms][PATCH v1] PurleyOpenBoardPkg/BoardMtOlympus: Fix Build

2023-11-27 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu Thanks, Chasel > -Original Message- > From: Desimone, Nathaniel L > Sent: Monday, November 27, 2023 5:04 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel > Subject: [edk2-platforms][PATCH v1] PurleyOpenBoardPkg/BoardMtOlympus: Fix &g

Re: [edk2-devel] [edk2-platforms][PATCH v1] PurleyOpenBoardPkg: Fix Build

2023-11-27 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu Thanks, Chasel > -Original Message- > From: Desimone, Nathaniel L > Sent: Monday, November 27, 2023 5:04 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel > Subject: [edk2-platforms][PATCH v1] PurleyOpenBoardPkg: Fix Build > > Adds

Re: [edk2-devel] [edk2-platforms][PATCH v1] MinPlatformPkg: Update PatchFv Tools for Python 3.x

2023-11-27 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu Thanks, Chasel > -Original Message- > From: Desimone, Nathaniel L > Sent: Monday, November 27, 2023 5:04 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Gao, Liming > ; Dong, Eric > Subject: [edk2-platforms][PATCH v1] MinPlatformPkg:

Re: [edk2-devel] [edk2-platforms][PATCH v1] MinPlatformPkg: Add edk2-platforms/Features to PACKAGES_PATH

2023-11-27 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu Thanks, Chasel > -Original Message- > From: Desimone, Nathaniel L > Sent: Monday, November 27, 2023 5:04 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Gao, Liming > ; Dong, Eric > Subject: [edk2-platforms][PATCH v1] Min

Re: [edk2-devel] [edk2-platforms][PATCH v1] PurleyOpenBoardPkg: Replace Python Interpreter Name

2023-11-27 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu Thanks, Chasel > -Original Message- > From: Desimone, Nathaniel L > Sent: Friday, November 17, 2023 10:36 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel > Subject: [edk2-platforms][PATCH v1] PurleyOpenBoardPkg: Replace Python

Re: [edk2-devel] [edk2-platforms][PATCH v1] WhitleyOpenBoardPkg: Replace Python Interpreter Name

2023-11-27 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu Thanks, Chasel > -Original Message- > From: Desimone, Nathaniel L > Sent: Friday, November 17, 2023 10:36 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel > Subject: [edk2-platforms][PATCH v1] WhitleyOpenBoardPkg: Replace Python

Re: [edk2-devel] [edk2-platforms][PATCH v1] MinPlatformPkg: Remove usage of PYTHON_HOME

2023-11-27 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu Thanks, Chasel > -Original Message- > From: Desimone, Nathaniel L > Sent: Friday, November 17, 2023 10:36 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Gao, Liming > ; Dong, Eric > Subject: [edk2-platforms][PATCH v1] MinPlat

Re: [edk2-devel] [edk2-platforms PATCH 1/2] WhitleyOpenBoardPkg: remove references

2023-11-27 Thread Chiu, Chasel
t; To: devel@edk2.groups.io; Chiu, Chasel > Cc: Chaganty, Rangasai V ; Desimone, Nathaniel > L > Subject: Re: [edk2-devel] [edk2-platforms PATCH 1/2] WhitleyOpenBoardPkg: > remove references > > Hi Chasel, > > On 11/21/23 03:17, Chiu, Chasel wrote: > > > >

Re: [edk2-devel] [edk2-platforms PATCH 1/2] WhitleyOpenBoardPkg: remove references

2023-11-20 Thread Chiu, Chasel
-platforms/blob/master/Platform/Intel/Readme.md Please let me know if any question. Thanks, Chasel > -Original Message- > From: Laszlo Ersek > Sent: Wednesday, November 15, 2023 3:51 AM > To: devel@edk2.groups.io; Chiu, Chasel > Cc: Chaganty, Rangasai V ; Desimone

Re: [edk2-devel] [PATCH v1] MinPlatformPkg: If BaseTools doesn't build, try a clean build

2023-11-17 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu Thanks, Chasel > -Original Message- > From: Desimone, Nathaniel L > Sent: Monday, September 25, 2023 5:47 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Isaac Oram > ; Gao, Liming ; Dong, > Eric > Subject: [PATCH v1] MinP

Re: [edk2-devel] [PATCH v2 1/1] MdeModulePkg: Fix issue with ACPI table creation

2023-11-17 Thread Chiu, Chasel
Hi Dhaval, Just a small feedback, the only difference will be TableToInstall between XDsdt and Dsdt, could we optimize the code flow to reduce duplicate lines? Thanks, Chasel > -Original Message- > From: devel@edk2.groups.io On Behalf Of Dhaval > Sharma > Sent: Friday, November 17,

Re: [edk2-devel] [edk2-platforms PATCH 1/2] WhitleyOpenBoardPkg: remove references

2023-11-09 Thread Chiu, Chasel
nty, Rangasai V ; Desimone, Nathaniel > L ; Chiu, Chasel > Subject: [edk2-devel] [edk2-platforms PATCH 1/2] WhitleyOpenBoardPkg: > remove references > > For removing "MdePkg/Include/IndustryStandard/LegacyBiosMpTable.h" from > edk2, first remove the edk2-platforms referen

Re: [edk2-devel] [PATCH] IntelFsp2Pkg\Tools\ConfigEditor: Added new USF config workstream support Config Edit utility addition/changes.

2023-11-08 Thread Chiu, Chasel
-patch -v2 -1) Thanks, Chasel > -Original Message- > From: Soundara Pandian, Arun SuraX > Sent: Tuesday, November 7, 2023 8:53 PM > To: devel@edk2.groups.io > Cc: Soundara Pandian, Arun SuraX ; > Chiu, Chasel ; Duggapu, Chinni B > ; Desimone, Nathaniel L > ;

Re: [edk2-devel] [PATCH v1] IntelFsp2Pkg: Add get and set FspSmmInit upd data pointer functions

2023-08-28 Thread Chiu, Chasel
merged: https://github.com/tianocore/edk2/commit/b1e558f6369fc85ae053e0c16ffcd600880fe78d Thanks, Chasel > -Original Message- > From: Zhang, Hongbin1 > Sent: Thursday, August 24, 2023 8:15 PM > To: devel@edk2.groups.io > Cc: Zhang, Hongbin1 ; Chiu, Chasel > ; Des

Re: [edk2-devel][PATCH v2] IntelFsp2Pkg: Support child FV in SplitFspBin.py

2023-08-28 Thread Chiu, Chasel
Merged: https://github.com/tianocore/edk2/commit/2c7fd32676272e22ed44fdfc8fa7e47f5c7a93b8 Thanks, Chasel > -Original Message- > From: Kuo, Ted > Sent: Thursday, July 20, 2023 3:20 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Zeng

Re: [edk2-devel] [PATCH v1] IntelFsp2Pkg: Add get and set FspSmmInit upd data pointer functions

2023-08-24 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu Thanks, Chasel > -Original Message- > From: Zhang, Hongbin1 > Sent: Thursday, August 24, 2023 8:15 PM > To: devel@edk2.groups.io > Cc: Zhang, Hongbin1 ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Duggapu, Chinni B > ; Ng, Ray Han Lim ;

Re: [edk2-devel] [PATCH] MinPlatformPkg: Remove IA32 in PeiFspWrapperPlatformLib

2023-07-26 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu Thanks, Chasel > -Original Message- > From: Hsueh, DoraX > Sent: Monday, July 24, 2023 2:43 AM > To: devel@edk2.groups.io > Cc: Hsueh, DoraX ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Oram, Isaac W ; > Gao, Liming ; Dong, Eric ; &g

Re: [edk2-devel][PATCH v2] IntelFsp2Pkg: Support child FV in SplitFspBin.py

2023-07-21 Thread Chiu, Chasel
Looks good to me. Thanks Ted! Reviewed-by: Chasel Chiu > -Original Message- > From: Kuo, Ted > Sent: Thursday, July 20, 2023 3:20 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Zeng, Star ; S, Ashraf > Ali ; Duggapu, Chinni

Re: [edk2-devel][PATCH v1] SplitFspBin.py cannot support FSP binary with child FV included

2023-07-19 Thread Chiu, Chasel
Hi Ted, One question below inline. Another minor feedback is the commit/patch subject format should be "Package: title" Thanks, Chasel > -Original Message- > From: Kuo, Ted > Sent: Tuesday, July 18, 2023 7:16 AM > To: devel@edk2.groups.io > Cc: Chiu, Chase

Re: [edk2-devel] [PATCH] IntelFsp2WrapperPkg: Get HobListPtr before calling the Multiphase FSPS

2023-06-25 Thread Chiu, Chasel
Patch merged: https://github.com/tianocore/edk2/commit/ac33eee8b83999ba591af04fe22e773cf8fc8193 Thanks, Chasel > -Original Message- > From: Aishwarya, KurugoduMelmatamX > > Sent: Sunday, June 11, 2023 10:24 PM > To: devel@edk2.groups.io > Cc: Aishwarya, Kurugodu

Re: [edk2-devel] Need help to add me to the edk-ii-maintainers and edk-ii-reviewers team

2023-06-20 Thread Chiu, Chasel
Hello, edk2 stewards, Could you please help this case? Thanks, Chasel From: devel@edk2.groups.io On Behalf Of cbduggap Sent: Sunday, June 18, 2023 10:28 PM To: devel@edk2.groups.io Subject: [edk2-devel] Need help to add me to the edk-ii-maintainers and edk-ii-reviewers team HI All I signed

Re: [edk2-devel] [PATCH] IntelFsp2WrapperPkg: Get HobListPtr before calling the Multiphase FSPS

2023-06-12 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu Thanks, Chasel > -Original Message- > From: Aishwarya, KurugoduMelmatamX > > Sent: Sunday, June 11, 2023 10:24 PM > To: devel@edk2.groups.io > Cc: Aishwarya, KurugoduMelmatamX > ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Duggapu

Re: [edk2-devel] [PATCH] Get HobListPtr before calling the Multiphase FSPS

2023-06-09 Thread Chiu, Chasel
> Cc: Aishwarya, KurugoduMelmatamX > ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Duggapu, Chinni B > ; Chen, Gang C ; Zeng, > Star ; Kuo, Ted ; S, Ashraf Ali > ; Mohapatra, Susovan > > Subject: [PATCH] Get HobListPtr before calling the Multiphase FSPS > > REF : htt

Re: [edk2-devel] [PATCH] MinPlatform: Add CpuPageTableLib required by CpuMpPeim

2023-06-01 Thread Chiu, Chasel
Patch merged: https://github.com/tianocore/edk2-platforms/commit/ce9ea07a8b56dc12165ca4f7e975d3b2f798881e Thanks, Chasel > -Original Message- > From: Ni, Ray > Sent: Wednesday, May 31, 2023 2:18 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L

Re: [edk2-devel] [PATCH] MinPlatform: Add CpuPageTableLib required by CpuMpPeim

2023-05-31 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu Thanks, Chasel > -Original Message- > From: Ni, Ray > Sent: Wednesday, May 31, 2023 2:18 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Oram, Isaac W ; > Gao, Liming ; Dong, Eric > Subject:

Re: [edk2-devel] [PATCH v10] MinPlatformPkg: Update HWSignature field in FACS

2023-05-30 Thread Chiu, Chasel
Patch merged: https://github.com/tianocore/edk2-platforms/commit/1a7bd150d39007bfb72c4727feda3184c23efe96 Thanks, Chasel > -Original Message- > From: Ke, VincentX > Sent: Tuesday, May 30, 2023 7:48 PM > To: devel@edk2.groups.io > Cc: Ke, VincentX ; Chiu, Chas

Re: [edk2-devel] [PATCH v9] MinPlatformPkg: Update HWSignature field in FACS

2023-05-30 Thread Chiu, Chasel
k2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Oram, Isaac W ; > Gao, Liming ; Dong, Eric > Subject: RE: [PATCH v9] MinPlatformPkg: Update HWSignature field in FACS > > Reviewed-by: Ankit Sinha > > Thank you, > Ankit > > > -Original Message-

Re: [edk2-devel] [PATCH 1/1] IntelFsp2Pkg/Library/BaseFspCommonLib: Fix OVERRUN Coverity issue

2023-05-29 Thread Chiu, Chasel
Patch merged: https://github.com/tianocore/edk2/commit/48c53994e649d51a388dc414944c9a9b717a1c3c Thanks, Chasel > -Original Message- > From: Ranbir Singh > Sent: Wednesday, May 17, 2023 11:29 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L

Re: [edk2-devel] [PATCH] IntelFsp2WrapperPkg: Fix ASSERT when FSP-S/M use FFS3

2023-05-29 Thread Chiu, Chasel
Patch merged: https://github.com/tianocore/edk2/commit/69e10f02111bf7e719237f05233abff4e50016fa Thanks, Chasel > -Original Message- > From: Tan, Ming > Sent: Sunday, May 21, 2023 11:13 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Duggapu, Chinni B >

Re: [edk2-devel] [PATCH 1/1] IntelFsp2Pkg/Library/BaseFspCommonLib: Fix OVERRUN Coverity issue

2023-05-29 Thread Chiu, Chasel
devel@edk2.groups.io; rsi...@ventanamicro.com > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Zeng, Star ; Ranbir > Singh > Subject: Re: [edk2-devel] [PATCH 1/1] IntelFsp2Pkg/Library/BaseFspCommonLib: > Fix OVERRUN Coverity issue > > On Thu, May 18, 2023 at 4:16 PM Ranbir Singh > wro

Re: [edk2-devel] [PATCH 4/6] MinPlatform/build_bios.py: Support performance enabled build

2023-05-24 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu Thanks, Chasel > -Original Message- > From: Ni, Ray > Sent: Wednesday, May 24, 2023 5:29 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Oram, Isaac W ; > Gao, Liming ; Dong, Eric > Subject:

Re: [edk2-devel] [edk2-platforms:PATCH v2] MinPlatformPkg: Fix SetLargeVariable fail issue

2023-05-24 Thread Chiu, Chasel
Patch merged: https://github.com/tianocore/edk2-platforms/commit/b71f2bda9e4fc183068eef5d1d90a631181a2506 Thanks, Chasel > -Original Message- > From: Shindo, Miki > Sent: Tuesday, May 23, 2023 5:44 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nath

Re: [edk2-devel] [edk2-platforms:PATCH v2] MinPlatformPkg: Fix SetLargeVariable fail issue

2023-05-23 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu mailto:chasel.c...@intel.com>> Thanks, Chasel From: Desimone, Nathaniel L Sent: Tuesday, May 23, 2023 5:59 PM To: Shindo, Miki ; devel@edk2.groups.io Cc: Chiu, Chasel ; Gao, Liming ; Dong, Eric ; Zhang, Xiaoqiang Subject: Re: [edk2-platforms:PA

Re: [edk2-devel] [PATCH] IntelFsp2WrapperPkg: Fix ASSERT when FSP-S/M use FFS3

2023-05-22 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu Thanks, Chasel > -Original Message- > From: Tan, Ming > Sent: Sunday, May 21, 2023 11:13 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Duggapu, Chinni B > > Subject: [PATCH] IntelFsp2WrapperPkg: Fix ASSERT when FSP-S/M use

Re: [edk2-devel] [PATCH 1/1] IntelFsp2Pkg/Library/BaseFspCommonLib: Fix OVERRUN Coverity issue

2023-05-18 Thread Chiu, Chasel
This fix looks good to me! Thanks Ranbir! Reviewed-by: Chasel Chiu > -Original Message- > From: Ranbir Singh > Sent: Wednesday, May 17, 2023 11:29 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Zeng, Star ; Ranbir > Singh

Re: [edk2-devel] [PATCH v3] MinPlatformPkg: Update ACPI 6.5 definition

2023-05-16 Thread Chiu, Chasel
Patch merged: https://github.com/tianocore/edk2-platforms/commit/3c8ea51b1285c983fa81806d75a924d87cc7e732 Thanks, Chasel > -Original Message- > From: Chen, Aryeh > Sent: Wednesday, May 10, 2023 8:58 PM > To: devel@edk2.groups.io > Cc: Chen, Aryeh ; Chiu, Chas

Re: [edk2-devel] [PATCH v1 0/1] Maintainers.txt: Update reviewers and maintainer for FdtLib

2023-05-15 Thread Chiu, Chasel
Thanks Liming! > -Original Message- > From: gaoliming > Sent: Sunday, May 14, 2023 6:01 PM > To: devel@edk2.groups.io; Chiu, Chasel ; Guo, Gua > > Cc: 'Andrew Fish' ; 'Leif Lindholm' > ; Kinney, Michael D > Subject: 回复: [edk2-devel] [PATCH v1 0/1] Maintaine

Re: [edk2-devel] [PATCH v1 0/1] Maintainers.txt: Update reviewers and maintainer for FdtLib

2023-05-12 Thread Chiu, Chasel
Hi Liming, PR has been updated with all RB: https://github.com/tianocore/edk2/pull/4389/commits Thanks, Chasel > -Original Message- > From: devel@edk2.groups.io On Behalf Of Chiu, Chasel > Sent: Friday, May 12, 2023 12:11 AM > To: devel@edk2.groups.io; Gao, Liming ; Guo,

Re: [edk2-devel] [PATCH v1 0/1] Maintainers.txt: Update reviewers and maintainer for FdtLib

2023-05-12 Thread Chiu, Chasel
Thanks Liming! > -Original Message- > From: devel@edk2.groups.io On Behalf Of gaoliming > via groups.io > Sent: Thursday, May 11, 2023 7:45 PM > To: Chiu, Chasel ; devel@edk2.groups.io; Guo, Gua > > Cc: 'Andrew Fish' ; 'Leif Lindholm' > ; Kinney, Michael D &g

Re: [edk2-devel] [PATCH v1 1/1] Maintainers.txt: Update reviewers and maintainers for FdtLib. Update reviewers and maintainers for FdtLib.

2023-05-11 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu Thanks, Chasel > -Original Message- > From: Guo, Gua > Sent: Thursday, May 11, 2023 7:11 PM > To: devel@edk2.groups.io > Cc: Guo, Gua ; Kinney, Michael D > ; Andrew Fish ; Leif Lindholm > ; Lin, Benny ; Chiu, Chasel > ; Lu, James

Re: [edk2-devel] [PATCH v1 0/1] Maintainers.txt: Update reviewers and maintainer for FdtLib

2023-05-11 Thread Chiu, Chasel
Hi Liming, We are considering this is a missing when merging FdtLib support earlier. Do we need to wait for Stewards approval for adding maintainers? Thanks, Chasel > -Original Message- > From: devel@edk2.groups.io On Behalf Of Guo, Gua > Sent: Thursday, May 11, 2023 7:31 PM > To:

Re: [edk2-devel] [PATCH v1 0/1] Maintainers.txt: Update reviewers and maintainer for FdtLib

2023-05-11 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: devel@edk2.groups.io On Behalf Of Guo, Gua > Sent: Thursday, May 11, 2023 7:11 PM > To: devel@edk2.groups.io > Cc: Guo, Gua > Subject: [edk2-devel] [PATCH v1 0/1] Maintainers.txt: Update reviewers and > maintainer for FdtLib > >

Re: [edk2-devel] [PATCH v9 0/5] Trace Hub debug library support

2023-05-10 Thread Chiu, Chasel
Hello Andrew Fish, Sorry that we seem to miss you from previous patch CC list mistakenly, please help to review this series about new submodule we are adding and let us know if any feedbacks. Thanks, Chasel > -Original Message- > From: devel@edk2.groups.io On Behalf Of Guo, Gua >

Re: [edk2-devel] [PATCH v5 0/4] MdePkg: Add MipiSysTLib library

2023-05-10 Thread Chiu, Chasel
Thanks a lot Mike for your detail reviewing and providing better implementation suggestions! > -Original Message- > From: devel@edk2.groups.io On Behalf Of Michael D > Kinney > Sent: Wednesday, May 10, 2023 9:00 AM > To: Guo, Gua ; devel@edk2.groups.io; Gao, Liming > > Cc: Kinney,

Re: [edk2-devel] [edk2-platforms][PATCH v4 1/1] MinPlatformPkg: Add FspNvsBuffer compression option

2023-05-10 Thread Chiu, Chasel
Patch merged: https://github.com/tianocore/edk2-platforms/commit/dbd802cd273ad1b51be46ca09a58a15e4b70863f Thanks, Chasel > -Original Message- > From: devel@edk2.groups.io On Behalf Of Michael > Kubacki > Sent: Wednesday, May 10, 2023 8:02 AM > To: devel@edk2.group

Re: [edk2-devel] [edk2-platforms][PATCH v4 1/1] MinPlatformPkg: Add FspNvsBuffer compression option

2023-05-10 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu Thanks, Chasel > -Original Message- > From: devel@edk2.groups.io On Behalf Of Michael > Kubacki > Sent: Wednesday, May 10, 2023 8:02 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Oram, Isaac W ; >

Re: [edk2-devel] [edk2-platforms][PATCH v3 1/1] MinPlatformPkg: Add FspNvsBuffer compression option

2023-05-10 Thread Chiu, Chasel
t; FspNvsBuffer compression option > > > Reviewed-by: Chasel Chiu > > Thanks, > Chasel > > > > > -Original Message- > > From: devel@edk2.groups.io On Behalf Of Michael > > Kubacki > > Sent: Tuesday, May 9, 2023 8:21 PM > > To: d

Re: [edk2-devel] [edk2-platforms][PATCH v3 1/1] MinPlatformPkg: Add FspNvsBuffer compression option

2023-05-09 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu Thanks, Chasel > -Original Message- > From: devel@edk2.groups.io On Behalf Of Michael > Kubacki > Sent: Tuesday, May 9, 2023 8:21 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Oram, Isaac W ; >

Re: [edk2-devel] [edk2-platforms:PATCH V1] MinPlatformPkg/SaveMemoryConfig: Support NVS Data compression.

2023-05-09 Thread Chiu, Chasel
Hi Michael, Please also add CompressLib to CoreCommonLib.dsc to prevent build failure from open source platforms. Thanks, Chasel > -Original Message- > From: Chiu, Chasel > Sent: Tuesday, May 9, 2023 12:30 PM > To: devel@edk2.groups.io; Kubacki, Michael ; > Michael

Re: [edk2-devel] [edk2-platforms:PATCH V1] MinPlatformPkg/SaveMemoryConfig: Support NVS Data compression.

2023-05-09 Thread Chiu, Chasel
backi via groups.io > Sent: Tuesday, May 9, 2023 12:18 PM > To: Chiu, Chasel ; Michael Kubacki > ; Gudla, Raghava ; > Oram, Isaac W ; devel@edk2.groups.io; Kinney, > Michael D > Cc: Desimone, Nathaniel L ; Chaganty, > Rangasai V > Subject: Re: [edk2-devel] [edk2-pla

Re: [edk2-devel] [edk2-platforms:PATCH V1] MinPlatformPkg/SaveMemoryConfig: Support NVS Data compression.

2023-05-09 Thread Chiu, Chasel
t; ; devel@edk2.groups.io; Kinney, Michael D > ; Chiu, Chasel > Cc: Desimone, Nathaniel L ; Kubacki, Michael > ; Chaganty, Rangasai V > > Subject: Re: [edk2-devel] [edk2-platforms:PATCH V1] > MinPlatformPkg/SaveMemoryConfig: Support NVS Data compression. > > Thanks for

Re: [edk2-devel] [edk2-platforms:PATCH V1] MinPlatformPkg/SaveMemoryConfig: Support NVS Data compression.

2023-05-08 Thread Chiu, Chasel
: Oram, Isaac W > Sent: Monday, May 8, 2023 12:15 PM > To: Gudla, Raghava ; devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Kubacki, Michael > ; Chaganty, Rangasai V > > Subject: RE: [edk2-platforms:PATCH V1] MinPlatformPkg/SaveMemoryConfig: >

Re: [edk2-devel] [PATCH v7 0/3] Support FDT library.

2023-05-05 Thread Chiu, Chasel
> -Original Message- > From: devel@edk2.groups.io On Behalf Of Chiu, Chasel > Sent: Thursday, May 4, 2023 4:48 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Kinney, Michael D > ; Gao, Liming ; Liu, > Zhiguang ; Sean Brogan > ; Michael Kubacki > ; Pedro Falcato ; >

Re: [edk2-devel] [PATCH v1] MinPlatformPkg: Update ACPI 6.5 definition

2023-05-04 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu Thanks, Chasel > -Original Message- > From: Chen, Aryeh > Sent: Thursday, May 4, 2023 10:11 AM > To: devel@edk2.groups.io > Cc: Chen, Aryeh ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Oram, Isaac W ; > Gao, Liming ; Dong, Eric ;

[edk2-devel] [PATCH v7 2/3] MdePkg: Support FDT library.

2023-05-04 Thread Chiu, Chasel
From: Benny Lin REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4392 Add FDT support in EDK2 by submodule 3rd party libfdt (https://github.com/devicetree-org/pylibfdt/tree/main/libfdt) and refer to LibcLib implementation by Pedro. Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu

[edk2-devel] [PATCH v7 3/3] .pytool: Support FDT library.

2023-05-04 Thread Chiu, Chasel
From: Benny Lin REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4392 Add FDT support in EDK2 by submodule 3rd party libfdt (https://github.com/devicetree-org/pylibfdt/tree/main/libfdt) Add RequiredSubmodule object for CI setting. Reviewed-by: Michael D Kinney Cc: Sean Brogan Cc: Michael

[edk2-devel] [PATCH v7 0/3] Support FDT library.

2023-05-04 Thread Chiu, Chasel
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4392 Add FDT support in EDK2 by submodule 3rd party libfdt (https://github.com/devicetree-org/pylibfdt/tree/main/libfdt) and refer to LibcLib implementation by Pedro. Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Cc: Sean Brogan Cc:

[edk2-devel] [PATCH v7 1/3] Tianocore: Support FDT library.

2023-05-04 Thread Chiu, Chasel
From: Benny Lin REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4392 Add FDT support in EDK2 by submodule 3rd party libfdt (https://github.com/devicetree-org/pylibfdt/tree/main/libfdt) Add submodule libfdt and update ReadMe for the licence. Reviewed-by: Leif Lindholm Reviewed-by: Michael

Re: [edk2-devel] [PATCH v6 2/3] MdePkg: Support FDT library.

2023-05-04 Thread Chiu, Chasel
Hi Mike, Please see my reply below inline. Thanks, Chasel > -Original Message- > From: devel@edk2.groups.io On Behalf Of Michael D > Kinney > Sent: Thursday, May 4, 2023 11:02 AM > To: Lin, Benny ; devel@edk2.groups.io > Cc: Gao, Liming ; Liu, Zhiguang > ; Pedro Falcato ; Kinney, >

Re: [edk2-devel] [PATCH] Maintainers.txt: Update for IntelFsp2Pkg and IntelFsp2WrapperPkg.

2023-05-04 Thread Chiu, Chasel
Patch merged: https://github.com/tianocore/edk2/commit/d992a05ade3d1bebc6e7a81aaf700286e0e217c8 Thanks, Chasel > -Original Message- > From: devel@edk2.groups.io On Behalf Of Chiu, Chasel > Sent: Monday, April 24, 2023 11:21 AM > To: devel@edk2.groups.io > Cc: Chiu, Ch

Re: [edk2-devel] [PATCH v3 2/3] MdePkg: Support FDT library.

2023-05-03 Thread Chiu, Chasel
hael D > Sent: Tuesday, May 2, 2023 10:39 PM > To: Chiu, Chasel ; devel@edk2.groups.io; > quic_llind...@quicinc.com > Cc: Lin, Benny ; Gao, Liming > ; Liu, Zhiguang ; Pedro > Falcato ; Kinney, Michael D > > Subject: RE: [edk2-devel] [PATCH v3 2/3] MdePkg: Support FDT library.

Re: [edk2-devel] [PATCH v3 2/3] MdePkg: Support FDT library.

2023-05-02 Thread Chiu, Chasel
) SwapBytes64 (x) > -Original Message- > From: devel@edk2.groups.io On Behalf Of Leif > Lindholm > Sent: Tuesday, May 2, 2023 4:42 AM > To: devel@edk2.groups.io; Chiu, Chasel ; Kinney, > Michael D > Cc: Lin, Benny ; Gao, Liming > ; Liu, Zhiguang ; Pedro > Fa

Re: [edk2-devel][edk2-platforms][PATCH V1 1/1] MinPlatformPkg/Build: Add standalone MM build rules

2023-05-02 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu Thanks, Chasel > -Original Message- > From: Oram, Isaac W > Sent: Wednesday, March 15, 2023 6:18 AM > To: devel@edk2.groups.io > Cc: Oram, Isaac W ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Gao, Liming ; > Dong, Eric > Subject:

Re: [edk2-devel][edk2-platforms][PATCH V1 1/1] WhitleyOpenBoardPkg/DSC: Restore AdvancedFeatures

2023-05-02 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu Thanks, Chasel > -Original Message- > From: Oram, Isaac W > Sent: Tuesday, March 7, 2023 4:16 PM > To: devel@edk2.groups.io > Cc: Oram, Isaac W ; Desimone, Nathaniel L > ; Chiu, Chasel > Subject: [edk2-devel][edk2-pl

Re: [edk2-devel] [PATCH v3 2/3] MdePkg: Support FDT library.

2023-05-01 Thread Chiu, Chasel
Hi Leif, Would you please share your ideas and respond Mike's question too? Thanks, Chasel > -Original Message- > From: devel@edk2.groups.io On Behalf Of Chiu, Chasel > Sent: Tuesday, April 25, 2023 10:22 PM > To: devel@edk2.groups.io; Kinney, Michael D ; > Leif Lind

Re: [edk2-devel] [PATCH v3 2/3] MdePkg: Support FDT library.

2023-04-25 Thread Chiu, Chasel
Hello, Since platform may also define other FDT structures, this EDK2 library may not be able to convert all the FDT structures to little endian. We might define a generic MACRO in library like CONVERT_FDT_DATA_TO_LITTLE_ENDIAN which can be used for all structure data, but it will be almost

[edk2-devel] [PATCH] Maintainers.txt: Update for IntelFsp2Pkg and IntelFsp2WrapperPkg.

2023-04-24 Thread Chiu, Chasel
Add more maintainers and reviewers for these 2 packages. Cc: Nate DeSimone Cc: Duggapu Chinni B Cc: Ray Han Lim Ng Cc: Chen Gang C Cc: Star Zeng Cc: Ted Kuo Cc: Ashraf Ali S Cc: Susovan Mohapatra Signed-off-by: Chasel Chiu --- Maintainers.txt | 10 ++ 1 file changed, 10

Re: [edk2-devel] [PATCH v3 2/3] MdePkg: Support FDT library.

2023-04-20 Thread Chiu, Chasel
Hi Mike, Thanks for bringing this good point! We would like to document that all FDT structure data are in *big endian* format and remove those SwapBytes MACROs from FdtLib.h It makes sense to handle this from library consumer side (consumer can define their own MACROs) because we cannot

Re: [edk2-devel] [PATCH v3] IntelFsp2Pkg/Tools: Enhance PathFv.py to patch Fd file directly

2023-04-18 Thread Chiu, Chasel
Patch merged: https://github.com/tianocore/edk2/commit/b16284e2a0011489f6e16dfcc6af7623c3cbaf0b Thanks, Chasel > -Original Message- > From: Duggapu, Chinni B > Sent: Sunday, April 16, 2023 9:23 PM > To: devel@edk2.groups.io > Cc: Duggapu, Chinni B ; Chiu, Chas

Re: [edk2-devel] [PATCH v3] IntelFsp2Pkg/Tools: Enhance PathFv.py to patch Fd file directly

2023-04-16 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu Thanks, Chasel > -Original Message- > From: Duggapu, Chinni B > Sent: Sunday, April 16, 2023 9:23 PM > To: devel@edk2.groups.io > Cc: Duggapu, Chinni B ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Zeng, Star ; Kuo, Ted > > Subje

Re: [edk2-devel] [PATCH v2] MinPlatformPkg: Add Pcd for FADT REVISION and MINOR REVISION to update FADT entries from board package.

2023-04-14 Thread Chiu, Chasel
Patch merged: https://github.com/tianocore/edk2-platforms/commit/3b7f82b61b552f5bdd415f1bf4ba2866a09ceac0 Thanks, Chasel > -Original Message- > From: Chen, Aryeh > Sent: Wednesday, April 12, 2023 9:27 AM > To: devel@edk2.groups.io > Cc: Chen, Aryeh ; Chiu, Chas

Re: [edk2-devel] [PATCH v2] IntelFsp2Pkg/Tools: Enhance PathFv.py to patch Fd file directly https://bugzilla.tianocore.org/show_bug.cgi?id=4412

2023-04-14 Thread Chiu, Chasel
Hi Chinni, Please help to correct patch format and make sure it can pass verification by BaseTools/Scripts/PatchCheck.py Thanks, Chasel > -Original Message- > From: Duggapu, Chinni B > Sent: Friday, April 14, 2023 1:34 AM > To: devel@edk2.groups.io > Cc: Chiu, Ch

Re: [edk2-devel] [PATCH v2] MinPlatformPkg: Add Pcd for FADT REVISION and MINOR REVISION to update FADT entries from board package.

2023-04-12 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu Thanks, Chasel > -Original Message- > From: Chen, Aryeh > Sent: Wednesday, April 12, 2023 9:27 AM > To: devel@edk2.groups.io > Cc: Chen, Aryeh ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Oram, Isaac W ; > Gao, Liming ; Dong, Er

Re: [edk2-devel] [PATCH v1] MinPlatformPkg: Add Pcd for FADT REVISION and MINOR REVISION to update FADT entries from board package.

2023-04-12 Thread Chiu, Chasel
Hi Aryeh, Please see below inline for comments. Thanks, Chasel > -Original Message- > From: Chen, Aryeh > Sent: Wednesday, April 12, 2023 4:20 AM > To: devel@edk2.groups.io > Cc: Chen, Aryeh ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Oram, Isaac W ; >

Re: [edk2-devel] [PATCH v4] IntelFsp2Pkg: LoadMicrocodeDefault() causing unnecessary delay.

2023-04-04 Thread Chiu, Chasel
Patch merged: https://github.com/tianocore/edk2/commit/7df447930c42addaf2cc0d32916141d95ded677e Thanks, Chasel > -Original Message- > From: devel@edk2.groups.io On Behalf Of Chiu, Chasel > Sent: Monday, April 3, 2023 11:34 AM > To: devel@edk2.groups.io > Cc: Chiu, Ch

Re: [edk2-devel] [PATCH] IntelFsp2Pkg: TempRamInit API should preserve EBX/RBX register.

2023-04-04 Thread Chiu, Chasel
Patch merged: https://github.com/tianocore/edk2/commit/af98f1fb0311d8e3cc52ab9fc544a8c8ff8f7546 Thanks, Chasel > -Original Message- > From: devel@edk2.groups.io On Behalf Of Chiu, Chasel > Sent: Friday, March 31, 2023 4:16 PM > To: devel@edk2.groups.io > Cc: Chiu, Ch

  1   2   3   4   5   6   7   8   9   10   >