Re: [edk2-devel] [PATCH] UefiCpuPkg: Adding a new TSC library by using CPUID(0x15) TSC leaf

2019-08-21 Thread Donald Kuo
Thanks Liming help :) Donald > -Original Message- > From: Gao, Liming > Sent: Wednesday, August 21, 2019 9:46 PM > To: Zeng, Star ; Kuo, Donald ; > devel@edk2.groups.io; ler...@redhat.com; Dong, Eric > > Cc: Ni, Ray ; Chan, Amy ; > Chaganty, Rangasai V ; Lai, Luke > ; Li, Kevin Y ; >

Re: [edk2-devel] [PATCH] UefiCpuPkg: Adding a new TSC library by using CPUID(0x15) TSC leaf

2019-08-20 Thread Donald Kuo
Hi Liming, Done. Patch is attached to https://bugzilla.tianocore.org/show_bug.cgi?id=1909 Another BZ to apply CpuTimerLib will be tracking on: https://bugzilla.tianocore.org/show_bug.cgi?id=2096 Thanks, Donald > -Original Message- > From: Gao, Liming > Sent: Tuesday, August 20, 2019

Re: [edk2-devel] [PATCH] UefiCpuPkg: Adding a new TSC library by using CPUID(0x15) TSC leaf

2019-08-19 Thread Donald Kuo
Thanks Laszlo help to review and great feedbacks. That we did miss to fulfil BZ. I had updated Bugzilla https://bugzilla.tianocore.org/show_bug.cgi?id=1909 for more documentation. As I know for the edk2-platforms should be consumed as KBL (7th Generation) platform in Client, and this feature

Re: [edk2-devel] [PATCH] UefiCpuPkg: Adding a new TSC library by using CPUID(0x15) TSC leaf

2019-08-16 Thread Donald Kuo
Hi Vitaly, UEFI Application does be another scope. And regards your question on “a way to dynamically determine the difference between Xeon client and server” … is not in current design-in, for long term goal we could consider if there is proper way to identify CPU SKU dynamically. Thanks for

[edk2-devel] [PATCH] UefiCpuPkg: Adding a new TSC library by using CPUID(0x15) TSC leaf

2019-08-15 Thread Donald Kuo
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1909 Cc: Ray Ni Cc: Star Zeng Cc: Eric Dong Cc: Amy Chan Cc: Rangasai V Chaganty Signed-off-by: Donald Kuo --- UefiCpuPkg/Library/CpuTimerLib/BaseCpuTimerLib.c | 41 +++ UefiCpuPkg/Library/CpuTimerLib/BaseCpuTimerLib.inf | 35

Re: [edk2-devel] [PATCH] UefiCpuPkg: Adding a new TSC library by using CPUID(0x15) TSC leaf

2019-08-15 Thread Donald Kuo
Hi Vitaly, Appreciated for reviewing very detail. And looks your captured some piece of code is older version. And should be ok, I do got your point. Item #1 - I do missed RegEax error handling in case for CpuidCoreClockCalculateTscFrequency () should return 0 and EFI_UNSUPPORTED.

Re: [edk2-devel] [PATCH] UefiCpuPkg: Adding a new TSC library by using CPUID(0x15) TSC leaf

2019-08-14 Thread Donald Kuo
> Chan, Amy ; Chaganty, Rangasai V > > > > > > Subject: RE: [edk2-devel] [PATCH] UefiCpuPkg: Adding a new TSC > > > library by using CPUID(0x15) TSC leaf > > > > > > Reviewed-by: Eric Dong > > > > > > > -Original Message- &

[edk2-devel] [PATCH] UefiCpuPkg: Adding a new TSC library by using CPUID(0x15) TSC leaf

2019-08-14 Thread Donald Kuo
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1909 Cc: Ray Ni Cc: Star Zeng Cc: Eric Dong Cc: Amy Chan Cc: Rangasai V Chaganty Signed-off-by: Donald Kuo --- UefiCpuPkg/Library/CpuTimerLib/BaseCpuTimerLib.c | 41 +++ UefiCpuPkg/Library/CpuTimerLib/BaseCpuTimerLib.inf | 35

Re: [edk2-devel] [PATCH] UefiCpuPkg: Adding a new TSC library by using CPUID(0x15) TSC leaf

2019-08-14 Thread Donald Kuo
Adding a new TSC library by > using CPUID(0x15) TSC leaf > > Reviewed-by: Eric Dong > > > -Original Message- > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > > Donald Kuo > > Sent: Tuesday, August 13, 2019 6:53 PM > > To: devel@e

[edk2-devel] [PATCH] UefiCpuPkg: Adding a new TSC library by using CPUID(0x15) TSC leaf

2019-08-13 Thread Donald Kuo
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1909 Cc: Ray Ni Cc: Star Zeng Cc: Eric Dong Cc: Amy Chan Cc: Rangasai V Chaganty Signed-off-by: Donald Kuo --- UefiCpuPkg/Library/CpuTimerLib/BaseCpuTimerLib.c | 41 +++ UefiCpuPkg/Library/CpuTimerLib/BaseCpuTimerLib.inf | 35

Re: [edk2-devel] [PATCH] UefiCpuPkg: Adding a new TSC library by using CPUID(0x15) TSC leaf

2019-08-12 Thread Donald Kuo
Rangasai V > > Subject: [PATCH] UefiCpuPkg: Adding a new TSC library by using > > CPUID(0x15) TSC leaf > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1909 > > > > Cc: Ray Ni > > Cc: Star Zeng > > Cc: Eric Dong > > Cc: Amy Cha

[edk2-devel] [PATCH] UefiCpuPkg: Adding a new TSC library by using CPUID(0x15) TSC leaf

2019-08-12 Thread Donald Kuo
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1909 Cc: Ray Ni Cc: Star Zeng Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Donald Kuo --- .../Library/BaseCpuTimerLib/BaseCpuTimerLib.c | 40 +++ .../Library/BaseCpuTimerLib/BaseCpuTimerLib.inf

[edk2-devel] [PATCH] UefiCpuPkg: Add new TimerLib for CPUID Leaf 0x15 Core Crystal Clock Frequency

2019-08-12 Thread Donald Kuo
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1909 Cc: Ray Ni Cc: Star Zeng Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Donald Kuo --- .../Library/BaseCpuTimerLib/BaseCpuTimerLib.c | 40 +++ .../Library/BaseCpuTimerLib/BaseCpuTimerLib.inf

[edk2-devel] [PATCH] UefiCpuPkg: Adding a new TSC library by using CPUID(0x15) TSC leaf

2019-08-12 Thread Donald Kuo
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1909 Cc: Ray Ni Cc: Star Zeng Cc: Eric Dong Signed-off-by: Donald Kuo --- .../Library/BaseCpuTimerLib/BaseCpuTimerLib.c | 40 +++ .../Library/BaseCpuTimerLib/BaseCpuTimerLib.inf| 35 +++ .../Library/BaseCpuTimerLib

[edk2-devel] [PATCH] UefiCpuPkg: Adding a new TSC library by using CPUID(0x15) TSC leaf

2019-08-12 Thread Donald Kuo
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1909 Cc: Ray Ni Cc: Star Zeng Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Donald Kuo --- .../Library/BaseCpuTimerLib/BaseCpuTimerLib.c | 40 +++ .../Library/BaseCpuTimerLib/BaseCpuTimerLib.inf

[edk2-devel] [PATCH] UefiCpuPkg: Adding a new TSC library by using CPUID(0x15) TSC leaf

2019-08-12 Thread Donald Kuo
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1909 Cc: Ray Ni Cc: Star Zeng Cc: Eric Dong Cc: Amy Chan Cc: Rangasai V Chaganty Signed-off-by: Donald Kuo --- .../Library/BaseCpuTimerLib/BaseCpuTimerLib.c | 40 +++ .../Library/BaseCpuTimerLib/BaseCpuTimerLib.inf| 35

[edk2-devel] [PATCH] UefiCpuPkg: Adding a new TSC library by using CPUID(0x15) TSC leaf

2019-08-12 Thread Donald Kuo
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1909 Cc: Ray Ni Cc: Star Zeng Cc: Eric Dong Cc: Amy Chan Cc: Rangasai V Chaganty Signed-off-by: Donald Kuo --- .../Library/BaseCpuTimerLib/BaseCpuTimerLib.c | 40 +++ .../Library/BaseCpuTimerLib/BaseCpuTimerLib.inf| 35

[edk2-devel] [PATCH] UefiCpuPkg: Adding a new TSC library by using CPUID(0x15) TSC leaf

2019-08-12 Thread Donald Kuo
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1909 Cc: Ray Ni Cc: Star Zeng Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Donald Kuo --- .../Library/BaseCpuTimerLib/BaseCpuTimerLib.c | 40 +++ .../Library/BaseCpuTimerLib/BaseCpuTimerLib.inf