Re: [edk2-devel] [PATCH 1/4] UefiCpuPkg/MpInitLib: honor the platform's boot CPU count in AP detection

2019-10-08 Thread Dong, Eric
Hi Laszlo, > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Laszlo Ersek > Sent: Tuesday, October 8, 2019 7:27 PM > To: edk2-devel-groups-io > Cc: Dong, Eric ; Igor Mammedov > ; Ni, Ray > Subject: [edk2-devel

Re: [edk2-devel] [edk2-platforms][PATCH V2 3/3] BoardModulePkg/FirmwareBootMediaInfoPei: Add module

2019-10-08 Thread Dong, Eric
Reviewed-by: Eric Dong > -Original Message- > From: Kubacki, Michael A > Sent: Saturday, October 5, 2019 1:29 AM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Gao, Liming > Subject: [edk2-platforms][PATCH V2 3/3] > BoardModulePkg/FirmwareBootMediaInfoPei: Add

Re: [edk2-devel] [edk2-platforms][PATCH V2 2/3] BoardModulePkg/FirmwareBootMediaInfoLib: Add library

2019-10-08 Thread Dong, Eric
Reviewed-by: Eric Dong > -Original Message- > From: Kubacki, Michael A > Sent: Saturday, October 5, 2019 1:29 AM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Gao, Liming > Subject: [edk2-platforms][PATCH V2 2/3] > BoardModulePkg/FirmwareBootMediaInfoLib: Add l

Re: [edk2-devel] [edk2-platforms][PATCH V1 2/3] BoardModulePkg/FirmwareBootMediaInfoLib: Add library

2019-10-08 Thread Dong, Eric
Reviewed-by: Eric Dong > -Original Message- > From: Kubacki, Michael A > Sent: Tuesday, October 1, 2019 9:16 AM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Gao, Liming > Subject: [edk2-platforms][PATCH V1 2/3] > BoardModulePkg/FirmwareBootMediaInfoLib: Add l

Re: [edk2-devel] [PATCH v3] MdeModulePkg: Enable/Disable S3BootScript dynamically.

2019-09-29 Thread Dong, Eric
Reviewed-by: Eric Dong > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Chiu, > Chasel > Sent: Friday, September 27, 2019 3:51 PM > To: devel@edk2.groups.io > Cc: Wu, Hao A ; Dong, Eric ; > Desimone, Nathaniel L ; Gao, Li

Re: [edk2-devel] [RFC PATCH v2 00/44] SEV-ES guest support

2019-09-23 Thread Dong, Eric
szlo Ersek > ; Ard Biesheuvel ; Kinney, > Michael D ; Gao, Liming > ; Dong, Eric ; Ni, Ray > ; Singh, Brijesh ; You, Benjamin > ; Bi, Dandan ; Dong, Guo > ; Wu, Hao A ; Wang, Jian J > ; Ma, Maurice > Subject: Re: [edk2-devel] [RFC PATCH v2 00/44] SEV-ES guest support > > On 9

Re: [edk2-devel] [Patch V3] UefiCpuPkg/CpuExceptionHandlerLib: Fix split lock

2019-09-20 Thread Dong, Eric
Reviewed-by: Eric Dong And pushed: SHA-1: f4c898f2b2db2819c519cdce05403d4ba0234979 Thanks, Eric > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of John > E Lofgren > Sent: Wednesday, September 18, 2019 11:43 PM > To: devel@edk2.groups.io >

Re: [edk2-devel] [PATCH 15/35] MdeModulePkg/PiSmmCore: make type punning consistent

2019-09-17 Thread Dong, Eric
Reviewed-by: Eric Dong > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Wednesday, September 18, 2019 3:49 AM > To: edk2-devel-groups-io > Cc: Dong, Eric ; Wu, Hao A ; > Wang, Jian J ; Ni, Ray > Subject: [PATCH 15/35] MdeModulePkg

Re: [edk2-devel] [Patch V2] UefiCpuPkg/CpuExceptionHandlerLib: Fix #AC split lock

2019-09-12 Thread Dong, Eric
Cc other reviewers. Reviewed-by: Eric Dong Thanks, Eric > -Original Message- > From: devel@edk2.groups.io On Behalf Of John E > Lofgren > Sent: Tuesday, September 10, 2019 2:41 AM > To: devel@edk2.groups.io > Subject: [edk2-devel] [Patch V2] UefiCpuPkg/CpuExceptionHandlerLib: Fix > #AC

[edk2-devel] [Patch v2] UefiCpuPkg/CpuDxe: clean up PAGE_TABLE_LIB_PAGING_CONTEXT usage.

2019-09-11 Thread Dong, Eric
V2 changes: Avoid use type case, use different file implementation. V1 changes: REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1039 Current implementation not checks system mode before using PAGE_TABLE_LIB_PAGING_CONTEXT.ContextData.X64 or PAGE_TABLE_LIB_PAGING_CONTEXT.ContextData.Ia32.

Re: [edk2-devel] [Patch] UefiCpuPkg/CpuDxe: clean up PAGE_TABLE_LIB_PAGING_CONTEXT usage.

2019-09-11 Thread Dong, Eric
Hi Laszlo, > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Wednesday, September 11, 2019 11:25 PM > To: Dong, Eric ; devel@edk2.groups.io > Cc: Ni, Ray > Subject: Re: [Patch] UefiCpuPkg/CpuDxe: clean up > PAGE_TABLE_LIB_PAGING_CONTEXT us

[edk2-devel] [Patch] UefiCpuPkg/CpuDxe: clean up PAGE_TABLE_LIB_PAGING_CONTEXT usage.

2019-09-10 Thread Dong, Eric
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1039 Current implementation not checks system mode before using PAGE_TABLE_LIB_PAGING_CONTEXT.ContextData.X64 or PAGE_TABLE_LIB_PAGING_CONTEXT.ContextData.Ia32. This patch check the mode before using the correct one. Cc: Ray Ni Cc: Laszlo

Re: [edk2-devel] [PATCH] UefiCpuPkg/PiSmmCpu: Enable 5L paging only when phy addr line > 48

2019-09-08 Thread Dong, Eric
Reviewed-by: Eric Dong > -Original Message- > From: Ni, Ray > Sent: Friday, September 6, 2019 6:19 AM > To: devel@edk2.groups.io > Cc: Gao, Liming ; Dong, Eric ; > Laszlo Ersek > Subject: [PATCH] UefiCpuPkg/PiSmmCpu: Enable 5L paging only when phy addr > line &g

Re: [edk2-devel] [PATCH v2] DebugFeaturePkg: Remove white space and update the ending format

2019-09-08 Thread Dong, Eric
Reviewed-by: Eric Dong > -Original Message- > From: Zhang, Shenglei > Sent: Saturday, September 7, 2019 1:16 AM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Gao, Liming > Subject: [PATCH v2] DebugFeaturePkg: Remove white space and update the > ending format &g

Re: [edk2-devel] [PATCH v2] BoardModulePkg/CmosAccessLib: Update the end of last line

2019-09-08 Thread Dong, Eric
Reviewed-by: Eric Dong > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Zhang, Shenglei > Sent: Saturday, September 7, 2019 1:16 AM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Gao, Liming > Subject: [edk2-devel] [PAT

Re: [edk2-devel] [PATCH] UefiCpuPkg/CpuExceptionHandlerLib: Fix #AC split lock

2019-09-08 Thread Dong, Eric
Hi John, Thanks for your explanation. I agree with your analysis. I think you can submit your next version patch. Thanks, Eric > -Original Message- > From: Lofgren, John E > Sent: Saturday, September 7, 2019 3:01 AM > To: Dong, Eric ; devel@edk2.groups.io > Cc: Ni, Ray

Re: [edk2-devel] [PATCH] UefiCpuPkg/CpuExceptionHandlerLib: Fix #AC split lock

2019-09-05 Thread Dong, Eric
Hi John, I'm not sure whether I understand the code correctly. If not, please correct me. 1. You change to the code to only exchange 32 bits(eax) instead of 64 bits(rax). After your change, how to handle the above 32 bits value (from bit 32 to bit 63)? 2. In this file, also have another two

Re: [edk2-devel] [patch] MdeModulePkg: Remove gEfiFormBrowserExProtocolGuid

2019-09-05 Thread Dong, Eric
Reviewed-by: Eric Dong > -Original Message- > From: Bi, Dandan > Sent: Thursday, September 5, 2019 12:54 PM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Gao, Liming > Subject: [patch] MdeModulePkg: Remove gEfiFormBrowserExProtocolGuid > > gEfiFormBrowserEx

Re: [edk2-devel] [PATCH v2] UefiCpuPkg: support single EFI_PEI_CORE_FV_LOCATION_PPI in PpiList

2019-09-05 Thread Dong, Eric
Reviewed-by: Eric Dong > -Original Message- > From: Chiu, Chasel > Sent: Thursday, September 5, 2019 12:27 PM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Ni, Ray ; Laszlo > Ersek > Subject: [PATCH v2] UefiCpuPkg: support single > EFI_PEI_CORE_FV_LOCATION_PPI in

Re: [edk2-devel] [PATCH] UefiCpuPkg: support single EFI_PEI_CORE_FV_LOCATION_PPI in PpiList

2019-09-04 Thread Dong, Eric
Hi Chasel, Thanks for your quick fix. Reviewed-by: Eric Dong Thanks, Eric > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Chiu, > Chasel > Sent: Wednesday, September 4, 2019 4:56 PM > To: devel@edk2.groups.io > Cc: Do

Re: [edk2-devel] [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: Race condition between APHandler's release of Busy spinlock and user-triggered SmmStartupThisAP's

2019-09-03 Thread Dong, Eric
Wednesday, September 4, 2019 12:56 AM > To: Nikodem, Damian ; devel@edk2.groups.io > Cc: Dong, Eric ; You, Benjamin > ; Laszlo Ersek ; Rusocki, > Krzysztof > Subject: RE: [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: Race condition between > APHandler's release of Busy spinlock and user-tri

Re: [edk2-devel] [Patch] UefiCpuPkg/SecCore: get AllSecPpiList after SecPlatformMain.

2019-08-29 Thread Dong, Eric
Ersek [mailto:ler...@redhat.com] > Sent: Thursday, August 29, 2019 8:37 PM > To: Dong, Eric ; devel@edk2.groups.io > Cc: Ni, Ray > Subject: Re: [Patch] UefiCpuPkg/SecCore: get AllSecPpiList after > SecPlatformMain. > > Hi Eric, > > On 08/28/19 08:50, Eric Dong wrote: > &

[edk2-devel] [Patch] UefiCpuPkg/SecCore: get AllSecPpiList after SecPlatformMain.

2019-08-28 Thread Dong, Eric
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2136 SecPlatformMain is a platform hook function which let platform does some update. Some platform may adjust SecCoreData->PeiTemporaryRamBase which caused former saved AllSecPpiList variable invalid. This patch update the logic to get

Re: [edk2-devel] [PATCH 5/5] UefiCpuPkg: Remove PcdCpuSmmStaticPageTable

2019-08-26 Thread Dong, Eric
Reviewed-by: Eric Dong > -Original Message- > From: Ni, Ray > Sent: Monday, August 26, 2019 6:45 AM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Yao, Jiewen ; > Laszlo Ersek > Subject: [PATCH 5/5] UefiCpuPkg: Remove PcdCpuSmmStaticPageTable > > PcdC

Re: [edk2-devel] [PATCH 4/5] UefiCpuPkg: Explain relationship between several SMM PCDs

2019-08-26 Thread Dong, Eric
Reviewed-by: Eric Dong > -Original Message- > From: Ni, Ray > Sent: Monday, August 26, 2019 6:45 AM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Yao, Jiewen ; > Laszlo Ersek > Subject: [PATCH 4/5] UefiCpuPkg: Explain relationship between several SMM > PCDs &

Re: [edk2-devel] [PATCH 3/5] UefiCpuPkg/PiSmmCpu: Restrict access per PcdCpuSmmRestrictedMemoryAccess

2019-08-26 Thread Dong, Eric
Reviewed-by: Eric Dong > -Original Message- > From: Ni, Ray > Sent: Monday, August 26, 2019 6:45 AM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Yao, Jiewen ; > Laszlo Ersek > Subject: [PATCH 3/5] UefiCpuPkg/PiSmmCpu: Restrict access per > PcdCpuSmmRestrictedM

Re: [edk2-devel] [PATCH 2/5] UefiCpuPkg/PiSmmCpu: Use new PCD PcdCpuSmmRestrictedMemoryAccess

2019-08-26 Thread Dong, Eric
Reviewed-by: Eric Dong > -Original Message- > From: Ni, Ray > Sent: Monday, August 26, 2019 6:45 AM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Yao, Jiewen ; > Laszlo Ersek > Subject: [PATCH 2/5] UefiCpuPkg/PiSmmCpu: Use new PCD > PcdCpuSmmRestrictedMemoryAcces

Re: [edk2-devel] [PATCH 1/5] UefiCpuPkg: Add PcdCpuSmmRestrictedMemoryAccess

2019-08-26 Thread Dong, Eric
Reviewed-by: Eric Dong > -Original Message- > From: Ni, Ray > Sent: Monday, August 26, 2019 6:45 AM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Yao, Jiewen ; > Laszlo Ersek > Subject: [PATCH 1/5] UefiCpuPkg: Add PcdCpuSmmRestrictedMemoryAccess > > The pa

Re: [edk2-devel] [PATCH] UefiCpuPkg: Adding a new TSC library by using CPUID(0x15) TSC leaf

2019-08-15 Thread Dong, Eric
Reviewed-by: Eric Dong > -Original Message- > From: Kuo, Donald > Sent: Thursday, August 15, 2019 5:11 PM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Zeng, Star ; Dong, Eric > ; Chan, Amy ; Chaganty, > Rangasai V > Subject: [PATCH] UefiCpuPkg: Adding a new TSC lib

Re: [edk2-devel] [PATCH 1/1] UefiCpuPkg/Cpuid: Add description for parameter LeafFunction

2019-08-15 Thread Dong, Eric
Reviewed-by: Eric Dong > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Zhang, Shenglei > Sent: Thursday, August 15, 2019 4:15 PM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Ni, Ray ; Laszlo > Ersek > Subject:

Re: [edk2-devel] [Patch v3 1/6] UefiCpuPkg/RegisterCpuFeaturesLib: Add "Test Then Write" Macros.

2019-08-15 Thread Dong, Eric
Hi Liming & Star, > -Original Message- > From: Gao, Liming > Sent: Friday, August 16, 2019 11:44 AM > To: Dong, Eric ; Zeng, Star ; > devel@edk2.groups.io > Cc: Ni, Ray ; Laszlo Ersek ; Yao, > Jiewen ; Kinney, Michael D > > Subject: RE: [Patch v3 1/6] Ue

[edk2-devel] [Patch v4 5/6] UefiCpuPkg/RegisterCpuFeaturesLib: Supports test then write new value logic.

2019-08-15 Thread Dong, Eric
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2040 Supports new logic which test current value before write new value. Only write new value when current value not same as new value. Signed-off-by: Eric Dong Cc: Ray Ni Acked-by: Laszlo Ersek --- .../CpuFeaturesInitialize.c

[edk2-devel] [Patch v4 3/6] UefiCpuPkg/PiSmmCpuDxeSmm: Supports test then write new value logic.

2019-08-15 Thread Dong, Eric
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2040 Supports new logic which test current value before write new value. Only write new value when current value not same as new value. Signed-off-by: Eric Dong Cc: Ray Ni Reviewed-by: Laszlo Ersek --- UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c | 29

[edk2-devel] [Patch v4 1/6] UefiCpuPkg/RegisterCpuFeaturesLib: Add "Test Then Write" Macros.

2019-08-15 Thread Dong, Eric
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2040 Add below new micros which test the current value before write the new value. Only write new value when current value not same as new value. CPU_REGISTER_TABLE_TEST_THEN_WRITE32 CPU_REGISTER_TABLE_TEST_THEN_WRITE64

[edk2-devel] [Patch v4 6/6] UefiCpuPkg/CpuCommonFeaturesLib: Use new macros.

2019-08-15 Thread Dong, Eric
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2040 Below code is current implementation: if (MsrRegister[ProcessorNumber].Bits.Lock == 0) { CPU_REGISTER_TABLE_WRITE_FIELD ( ProcessorNumber, Msr, MSR_IA32_FEATURE_CONTROL, MSR_IA32_FEATURE_CONTROL_REGISTER,

[edk2-devel] [Patch v4 2/6] UefiCpuPkg/PiSmmCpuDxeSmm: Combine CR read/write action.

2019-08-15 Thread Dong, Eric
Signed-off-by: Eric Dong Cc: Ray Ni Reviewed-by: Laszlo Ersek --- UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c | 104 ++ 1 file changed, 62 insertions(+), 42 deletions(-) diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c b/UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c index

[edk2-devel] [Patch v4 0/6] Add "test then write" mechanism

2019-08-15 Thread Dong, Eric
v4 changes: 1. Split Reserved field and use one byte as TestThenWrite field. v3 changes: 1. Avoid changing exist API CpuRegisterTableWrite, add new API CpuRegisterTableTestThenWrite which align new adds macros. Only 1/6 patch been changed in v3. V2 changes: 1. Split CR read/write action in to

[edk2-devel] [Patch v4 4/6] UefiCpuPkg/RegisterCpuFeaturesLib: Combine CR read/write action.

2019-08-15 Thread Dong, Eric
Signed-off-by: Eric Dong Cc: Ray Ni Acked-by: Laszlo Ersek --- .../CpuFeaturesInitialize.c | 110 ++ 1 file changed, 63 insertions(+), 47 deletions(-) diff --git a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/CpuFeaturesInitialize.c

Re: [edk2-devel] [Patch v3 1/6] UefiCpuPkg/RegisterCpuFeaturesLib: Add "Test Then Write" Macros.

2019-08-15 Thread Dong, Eric
> -Original Message- > From: Zeng, Star > Sent: Friday, August 16, 2019 10:08 AM > To: Dong, Eric ; devel@edk2.groups.io > Cc: Ni, Ray ; Laszlo Ersek ; Yao, > Jiewen ; Gao, Liming ; Kinney, > Michael D ; Zeng, Star > Subject: RE: [Patch v3 1/6] UefiCpuPkg/Reg

Re: [edk2-devel] [Patch v3 1/6] UefiCpuPkg/RegisterCpuFeaturesLib: Add "Test Then Write" Macros.

2019-08-15 Thread Dong, Eric
> -Original Message- > From: Zeng, Star > Sent: Friday, August 16, 2019 9:15 AM > To: Dong, Eric ; devel@edk2.groups.io > Cc: Ni, Ray ; Laszlo Ersek ; Zeng, > Star > Subject: RE: [Patch v3 1/6] UefiCpuPkg/RegisterCpuFeaturesLib: Add "Test > Then Write"

[edk2-devel] [Patch v3 6/6] UefiCpuPkg/CpuCommonFeaturesLib: Use new macros.

2019-08-14 Thread Dong, Eric
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2040 Below code is current implementation: if (MsrRegister[ProcessorNumber].Bits.Lock == 0) { CPU_REGISTER_TABLE_WRITE_FIELD ( ProcessorNumber, Msr, MSR_IA32_FEATURE_CONTROL, MSR_IA32_FEATURE_CONTROL_REGISTER,

[edk2-devel] [Patch v3 4/6] UefiCpuPkg/RegisterCpuFeaturesLib: Combine CR read/write action.

2019-08-14 Thread Dong, Eric
Signed-off-by: Eric Dong Cc: Ray Ni Acked-by: Laszlo Ersek --- .../CpuFeaturesInitialize.c | 110 ++ 1 file changed, 63 insertions(+), 47 deletions(-) diff --git a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/CpuFeaturesInitialize.c

[edk2-devel] [Patch v3 2/6] UefiCpuPkg/PiSmmCpuDxeSmm: Combine CR read/write action.

2019-08-14 Thread Dong, Eric
Signed-off-by: Eric Dong Cc: Ray Ni Reviewed-by: Laszlo Ersek --- UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c | 104 ++ 1 file changed, 62 insertions(+), 42 deletions(-) diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c b/UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c index

[edk2-devel] [Patch v3 0/6] Add "test then write" mechanism

2019-08-14 Thread Dong, Eric
v3 changes: 1. Avoid changing exist API CpuRegisterTableWrite, add new API CpuRegisterTableTestThenWrite which align new adds macros. Only 1/6 patch been changed in v3. V2 changes: 1. Split CR read/write action in to one discrete patch 2. Keep the old logic which continue the process if error

[edk2-devel] [Patch v3 1/6] UefiCpuPkg/RegisterCpuFeaturesLib: Add "Test Then Write" Macros.

2019-08-14 Thread Dong, Eric
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2040 Add below new micros which test the current value before write the new value. Only write new value when current value not same as new value. CPU_REGISTER_TABLE_TEST_THEN_WRITE32 CPU_REGISTER_TABLE_TEST_THEN_WRITE64

[edk2-devel] [Patch v3 3/6] UefiCpuPkg/PiSmmCpuDxeSmm: Supports test then write new value logic.

2019-08-14 Thread Dong, Eric
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2040 Supports new logic which test current value before write new value. Only write new value when current value not same as new value. Signed-off-by: Eric Dong Cc: Ray Ni Reviewed-by: Laszlo Ersek --- UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c | 29

[edk2-devel] [Patch v3 5/6] UefiCpuPkg/RegisterCpuFeaturesLib: Supports test then write new value logic.

2019-08-14 Thread Dong, Eric
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2040 Supports new logic which test current value before write new value. Only write new value when current value not same as new value. Signed-off-by: Eric Dong Cc: Ray Ni Acked-by: Laszlo Ersek --- .../CpuFeaturesInitialize.c

Re: [edk2-devel] [PATCH] UefiCpuPkg: Adding a new TSC library by using CPUID(0x15) TSC leaf

2019-08-14 Thread Dong, Eric
Reviewed-by: Eric Dong > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Donald Kuo > Sent: Tuesday, August 13, 2019 6:53 PM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Zeng, Star ; Dong, Eric > ; Chan, Amy ; Chaganty, &g

Re: [edk2-devel] [Patch v2 0/6] Add "test then write" mechanism.

2019-08-14 Thread Dong, Eric
Hi liming, This is a bug fix. It is required by 201908 stable tag. Thanks, Eric > -Original Message- > From: Gao, Liming > Sent: Wednesday, August 14, 2019 3:27 PM > To: devel@edk2.groups.io; Dong, Eric ; > ler...@redhat.com > Cc: Ni, Ray ; leif.lindh...@linaro.or

Re: [edk2-devel] [PATCH] UefiCpuPkg: Adding a new TSC library by using CPUID(0x15) TSC leaf

2019-08-12 Thread Dong, Eric
Hi Donald, Thanks for your explanation. In this case, Reviewed-by: Eric Dong Thanks, Eric > -Original Message- > From: Kuo, Donald > Sent: Tuesday, August 13, 2019 11:26 AM > To: Dong, Eric ; devel@edk2.groups.io > Cc: Ni, Ray ; Zeng, Star ; Chan, > Amy ; Ch

Re: [edk2-devel] [Patch v2 0/6] Add "test then write" mechanism.

2019-08-12 Thread Dong, Eric
Hi Laszlo, Yes, I already checked IA32 build. As Ray is leaving these days, can you help to review this serial? Thanks, Eric > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Laszlo Ersek > Sent: Monday, August 12, 2019 10:15 P

Re: [edk2-devel] [PATCH] UefiCpuPkg: Adding a new TSC library by using CPUID(0x15) TSC leaf

2019-08-12 Thread Dong, Eric
t; To: devel@edk2.groups.io > Cc: Ni, Ray ; Zeng, Star ; Dong, Eric > ; Chan, Amy ; Chaganty, > Rangasai V > Subject: [PATCH] UefiCpuPkg: Adding a new TSC library by using CPUID(0x15) > TSC leaf > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1909 > > Cc: Ray Ni

Re: [edk2-devel] [PATCH 1/1] MdeModulePkg/DxeIplPeim: Relocate the operation of PageMapLevel5Entry++

2019-08-12 Thread Dong, Eric
Agree with Dandan's comments. With that update, Reviewed-by: Eric Dong > -Original Message- > From: Bi, Dandan > Sent: Tuesday, August 13, 2019 10:04 AM > To: Zhang, Shenglei ; devel@edk2.groups.io > Cc: Gao, Liming ; Wu, Hao A ; > Laszlo Ersek ; Dong, Eric > Su

[edk2-devel] [Patch v2 3/6] UefiCpuPkg/PiSmmCpuDxeSmm: Supports test then write new value logic.

2019-08-12 Thread Dong, Eric
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2040 Supports new logic which test current value before write new value. Only write new value when current value not same as new value. Signed-off-by: Eric Dong Cc: Ray Ni Cc: Laszlo Ersek --- UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c | 29

[edk2-devel] [Patch v2 5/6] UefiCpuPkg/RegisterCpuFeaturesLib: Supports test then write new value logic.

2019-08-12 Thread Dong, Eric
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2040 Supports new logic which test current value before write new value. Only write new value when current value not same as new value. Signed-off-by: Eric Dong Cc: Ray Ni Cc: Laszlo Ersek --- .../CpuFeaturesInitialize.c |

[edk2-devel] [Patch v2 1/6] UefiCpuPkg/RegisterCpuFeaturesLib: Add "Test Then Write" Macros.

2019-08-12 Thread Dong, Eric
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2040 Add below new micros which test the current value before write the new value. Only write new value when current value not same as new value. CPU_REGISTER_TABLE_TEST_THEN_WRITE32 CPU_REGISTER_TABLE_TEST_THEN_WRITE64

[edk2-devel] [Patch v2 2/6] UefiCpuPkg/PiSmmCpuDxeSmm: Combine CR read/write action in one function.

2019-08-12 Thread Dong, Eric
Signed-off-by: Eric Dong Cc: Ray Ni Cc: Laszlo Ersek --- UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c | 106 ++ 1 file changed, 63 insertions(+), 43 deletions(-) diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c b/UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c index d8c6b19ead..b20992d5ab

[edk2-devel] [Patch v2 6/6] UefiCpuPkg/CpuCommonFeaturesLib: Use new macros.

2019-08-12 Thread Dong, Eric
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2040 Below code is current implementation: if (MsrRegister[ProcessorNumber].Bits.Lock == 0) { CPU_REGISTER_TABLE_WRITE_FIELD ( ProcessorNumber, Msr, MSR_IA32_FEATURE_CONTROL, MSR_IA32_FEATURE_CONTROL_REGISTER,

[edk2-devel] [Patch v2 0/6] Add "test then write" mechanism.

2019-08-12 Thread Dong, Eric
V2 changes: 1. Split CR read/write action in to one discrete patch 2. Keep the old logic which continue the process if error found. Below code is current implementation: if (MsrRegister[ProcessorNumber].Bits.Lock == 0) { CPU_REGISTER_TABLE_WRITE_FIELD ( ProcessorNumber, Msr,

[edk2-devel] [Patch v2 4/6] UefiCpuPkg/RegisterCpuFeaturesLib: Combine CR read/write action in one function.

2019-08-12 Thread Dong, Eric
Signed-off-by: Eric Dong Cc: Ray Ni Cc: Laszlo Ersek --- .../CpuFeaturesInitialize.c | 112 ++ 1 file changed, 64 insertions(+), 48 deletions(-) diff --git a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/CpuFeaturesInitialize.c

Re: [edk2-devel] [Patch 3/4] UefiCpuPkg/PiSmmCpuDxeSmm: Supports detect before set new value logic.

2019-08-12 Thread Dong, Eric
Hi Laszlo, > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Laszlo Ersek > Sent: Friday, August 9, 2019 11:31 PM > To: Dong, Eric ; devel@edk2.groups.io > Cc: Ni, Ray > Subject: Re: [edk2-devel] [Patch 3/4] Uefi

Re: [edk2-devel] [Patch 1/4] UefiCpuPkg/RegisterCpuFeaturesLib: Add "detect before set" Micros.

2019-08-12 Thread Dong, Eric
Hi Laszlo, Will fix it in my next version change. Thanks, Eric > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Friday, August 9, 2019 11:31 PM > To: Dong, Eric ; devel@edk2.groups.io > Cc: Ni, Ray > Subject: Re: [Patch 1/4] UefiCpuPkg/Regi

Re: [edk2-devel] [Patch 1/4] UefiCpuPkg/RegisterCpuFeaturesLib: Add "detect before set" Micros.

2019-08-12 Thread Dong, Eric
Hi Laszlo, > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Laszlo Ersek > Sent: Friday, August 9, 2019 11:14 PM > To: Dong, Eric ; devel@edk2.groups.io > Cc: Ni, Ray > Subject: Re: [edk2-devel] [Patch 1/4] UefiCpuPkg/R

[edk2-devel] [Patch 1/4] UefiCpuPkg/RegisterCpuFeaturesLib: Add "detect before set" Micros.

2019-08-09 Thread Dong, Eric
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2040 Add below new micros which test the current value before set the new value. Only set new value when current value not same as new value. CPU_REGISTER_TABLE_TEST_THEN_WRITE32 CPU_REGISTER_TABLE_TEST_THEN_WRITE64

[edk2-devel] [Patch 3/4] UefiCpuPkg/PiSmmCpuDxeSmm: Supports detect before set new value logic.

2019-08-09 Thread Dong, Eric
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2040 Supports new logic which detect current value before set new value. Only set new value when current value not same as new value. Signed-off-by: Eric Dong Cc: Ray Ni Cc: Laszlo Ersek --- UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c | 135

[edk2-devel] [Patch 0/4] Add "Test then Set" mechanism.

2019-08-09 Thread Dong, Eric
Below code is current implementation: if (MsrRegister[ProcessorNumber].Bits.Lock == 0) { CPU_REGISTER_TABLE_WRITE_FIELD ( ProcessorNumber, Msr, MSR_IA32_FEATURE_CONTROL, MSR_IA32_FEATURE_CONTROL_REGISTER, Bits.Lock, 1 ); } With below steps, the

[edk2-devel] [Patch 2/4] UefiCpuPkg/RegisterCpuFeaturesLib: Supports detect before set new value logic.

2019-08-09 Thread Dong, Eric
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2040 Supports new logic which detect current value before set new value. Only set new value when current value not same as new value. Signed-off-by: Eric Dong Cc: Ray Ni Cc: Laszlo Ersek --- .../CpuFeaturesInitialize.c |

[edk2-devel] [Patch 4/4] UefiCpuPkg/CpuCommonFeaturesLib: Use "Test then set" action.

2019-08-09 Thread Dong, Eric
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2040 Below code is current implementation: if (MsrRegister[ProcessorNumber].Bits.Lock == 0) { CPU_REGISTER_TABLE_WRITE_FIELD ( ProcessorNumber, Msr, MSR_IA32_FEATURE_CONTROL, MSR_IA32_FEATURE_CONTROL_REGISTER,

Re: [edk2-devel] [PATCH v2] UefiCpuPkg/PiSmmCpuDxeSmm: Fix coding style

2019-08-08 Thread Dong, Eric
Reviewed-by: Eric Dong > -Original Message- > From: Zhang, Shenglei > Sent: Thursday, August 8, 2019 3:55 PM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Ni, Ray ; Laszlo > Ersek > Subject: [PATCH v2] UefiCpuPkg/PiSmmCpuDxeSmm: Fix coding style > > 1. Up

[edk2-devel] [Patch 1/2] UefiCpuPkg/RegisterCpuFeaturesLib: Clean up useless parameter.

2019-08-08 Thread Dong, Eric
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2060 Remove the useless parameter. Signed-off-by: Eric Dong Cc: Ray Ni Cc: Laszlo Ersek --- UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeatures.h | 1 - .../Library/RegisterCpuFeaturesLib/RegisterCpuFeaturesLib.c | 1 - 2

[edk2-devel] [Patch 2/2] UefiCpuPkg/PiSmmCpuDxeSmm: Clean up useless parameter.

2019-08-08 Thread Dong, Eric
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2060 Remove the useless parameter. Signed-off-by: Eric Dong Cc: Ray Ni Cc: Laszlo Ersek --- UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c

[edk2-devel] [Patch 0/2] Clean up useless parmeter.

2019-08-08 Thread Dong, Eric
After commit 02031cfc920e ("UefiCpuPkg/PiSmmCpuDxeSmm: Remove debug message.", 2019-08-06), RegisterCpuFeaturesLib and PiSmmCpuDxeSmm are each left with a useless spinlock called "ConsoleLogLock". This patch serial remove this useless parameter. Eric Dong (2):

Re: [edk2-devel] [Patch v5 0/9] Support 5-level paging in DXE long mode

2019-08-08 Thread Dong, Eric
Please ignore this serial which error adds "Signed-off-by: Eric Dong.." tag by git tool. V6 serial has been send out. Thanks, Eric > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Dong, Eric > Sent: Thursday,

[edk2-devel] [Patch v6 9/9] UefiCpuPkg: Update code to include register definitions from MdePkg

2019-08-08 Thread Dong, Eric
From: "Ni, Ray" Signed-off-by: Ray Ni Reviewed-by: Eric Dong Regression-tested-by: Laszlo Ersek --- UefiCpuPkg/Application/Cpuid/Cpuid.c | 2 +- UefiCpuPkg/CpuDxe/CpuDxe.h| 4 ++-- UefiCpuPkg/CpuDxe/CpuPageTable.c

[edk2-devel] [Patch v6 2/9] UefiCpuPkg/MpInitLib: Enable 5-level paging for AP when BSP's enabled

2019-08-08 Thread Dong, Eric
From: "Ni, Ray" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2008 MpInitLib is the library that's responsible to wake up APs to provide MP PPI and Protocol services. The patch synchronizes BSP's CR4.LA57 to each AP's CR4.LA57. Without this change, AP may enter to GP fault when BSP's

[edk2-devel] [Patch v6 4/9] UefiCpuPkg/CpuDxe: Support parsing 5-level page table

2019-08-08 Thread Dong, Eric
From: "Ni, Ray" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2008 Signed-off-by: Ray Ni Reviewed-by: Eric Dong Regression-tested-by: Laszlo Ersek --- UefiCpuPkg/CpuDxe/CpuPageTable.c | 18 +- UefiCpuPkg/CpuDxe/CpuPageTable.h | 3 ++- 2 files changed, 19

[edk2-devel] [Patch v6 0/9] Support 5-level paging in DXE long mode

2019-08-08 Thread Dong, Eric
V6: Remove error added "Signed-off" tag added by git tool. V5: Correct the copyright time. Update print format code. v4: Move all files under UefiCpuPkg/Include/Register/ to MdePkg. NOTE: Changes like updating BaseLib.h to include Cpuid.h is not included. v3: Move

[edk2-devel] [Patch v6 3/9] UefiCpuPkg/CpuDxe: Remove unnecessary macros

2019-08-08 Thread Dong, Eric
From: "Ni, Ray" Today's code defines macros like CR0_PG, CR0_WP, CR4_PSE, CR4_PAE when checking whether individual bits are set in CR0 or CR4 register. The patch changes the code to use IA32_CR0 and IA32_CR4 structure defined in MdePkg/Include/Library/BaseLib.h so that the module local macros

[edk2-devel] [Patch v6 7/9] MdeModulePkg/DxeIpl: Create 5-level page table for long mode

2019-08-08 Thread Dong, Eric
From: "Ni, Ray" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2008 DxeIpl is responsible to create page table for DXE phase running either in long mode or in 32bit mode with certain protection mechanism enabled (refer to ToBuildPageTable()). The patch updates DxeIpl to create 5-level

[edk2-devel] [Patch v6 1/9] OvmfPkg/PlatformPei: Change referenced MSR name.

2019-08-08 Thread Dong, Eric
Change referenced MSR name to avoid later build failure. Signed-off-by: Eric Dong Cc: Laszlo Ersek Cc: Jordan Justen Cc: Ard Biesheuvel --- OvmfPkg/PlatformPei/FeatureControl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/OvmfPkg/PlatformPei/FeatureControl.c

[edk2-devel] [Patch v6 5/9] MdeModulePkg/DxeIpl: Introduce PCD PcdUse5LevelPageTable

2019-08-08 Thread Dong, Eric
From: "Ni, Ray" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2008 The PCD indicates if 5-Level Paging will be enabled in long mode. 5-Level Paging will not be enabled when the PCD is TRUE but CPU doesn't support 5-Level Paging. Signed-off-by: Ray Ni Reviewed-by: Eric Dong

[edk2-devel] [Patch v5 4/9] UefiCpuPkg/CpuDxe: Support parsing 5-level page table

2019-08-08 Thread Dong, Eric
From: "Ni, Ray" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2008 Signed-off-by: Ray Ni Reviewed-by: Eric Dong Regression-tested-by: Laszlo Ersek Signed-off-by: Eric Dong --- UefiCpuPkg/CpuDxe/CpuPageTable.c | 18 +- UefiCpuPkg/CpuDxe/CpuPageTable.h | 3 ++- 2 files

[edk2-devel] [Patch v5 0/9] Support 5-level paging in DXE long mode

2019-08-08 Thread Dong, Eric
V5: Correct the copyright time. Update print format code. v4: Move all files under UefiCpuPkg/Include/Register/ to MdePkg. NOTE: Changes like updating BaseLib.h to include Cpuid.h is not included. v3: Move UefiCpuPkg/Include/Register/Cpuid.h to MdePkg/Include/Register/Intel/

[edk2-devel] [Patch v5 2/9] UefiCpuPkg/MpInitLib: Enable 5-level paging for AP when BSP's enabled

2019-08-08 Thread Dong, Eric
From: "Ni, Ray" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2008 MpInitLib is the library that's responsible to wake up APs to provide MP PPI and Protocol services. The patch synchronizes BSP's CR4.LA57 to each AP's CR4.LA57. Without this change, AP may enter to GP fault when BSP's

[edk2-devel] [Patch v5 5/9] MdeModulePkg/DxeIpl: Introduce PCD PcdUse5LevelPageTable

2019-08-08 Thread Dong, Eric
From: "Ni, Ray" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2008 The PCD indicates if 5-Level Paging will be enabled in long mode. 5-Level Paging will not be enabled when the PCD is TRUE but CPU doesn't support 5-Level Paging. Signed-off-by: Ray Ni Reviewed-by: Eric Dong

[edk2-devel] [Patch v5 7/9] MdeModulePkg/DxeIpl: Create 5-level page table for long mode

2019-08-08 Thread Dong, Eric
From: "Ni, Ray" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2008 DxeIpl is responsible to create page table for DXE phase running either in long mode or in 32bit mode with certain protection mechanism enabled (refer to ToBuildPageTable()). The patch updates DxeIpl to create 5-level

[edk2-devel] [Patch v5 1/9] OvmfPkg/PlatformPei: Change referenced MSR name.

2019-08-08 Thread Dong, Eric
Change referenced MSR name to avoid later build failure. Signed-off-by: Eric Dong Cc: Laszlo Ersek Cc: Jordan Justen Cc: Ard Biesheuvel --- OvmfPkg/PlatformPei/FeatureControl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/OvmfPkg/PlatformPei/FeatureControl.c

[edk2-devel] [Patch v5 3/9] UefiCpuPkg/CpuDxe: Remove unnecessary macros

2019-08-08 Thread Dong, Eric
From: "Ni, Ray" Today's code defines macros like CR0_PG, CR0_WP, CR4_PSE, CR4_PAE when checking whether individual bits are set in CR0 or CR4 register. The patch changes the code to use IA32_CR0 and IA32_CR4 structure defined in MdePkg/Include/Library/BaseLib.h so that the module local macros

[edk2-devel] [Patch v5 9/9] UefiCpuPkg: Update code to include register definitions from MdePkg

2019-08-08 Thread Dong, Eric
From: "Ni, Ray" Signed-off-by: Ray Ni Reviewed-by: Eric Dong Regression-tested-by: Laszlo Ersek Signed-off-by: Eric Dong --- UefiCpuPkg/Application/Cpuid/Cpuid.c | 2 +- UefiCpuPkg/CpuDxe/CpuDxe.h| 4 ++-- UefiCpuPkg/CpuDxe/CpuPageTable.c

Re: [edk2-devel] [Patch v2 0/2] UefiCpuPkg: Remove debug message.

2019-08-07 Thread Dong, Eric
Hi Laszlo, Good catch, I will follow up to clean it. Thanks. Thanks, Eric > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Thursday, August 8, 2019 2:14 AM > To: Dong, Eric ; devel@edk2.groups.io > Cc: Ni, Ray > Subject: Re: [Patch v2 0/2]

[edk2-devel] [Patch v2 0/2] UefiCpuPkg: Remove debug message.

2019-08-05 Thread Dong, Eric
This debug message may be called by BSP and APs. It may caused ASSERT when APs call this debug code. In order to avoid system boot assert, Remove this debug message. Cc: Ray Ni Cc: Laszlo Ersek Eric Dong (2): UefiCpuPkg/RegisterCpuFeaturesLib: Remove debug message.

[edk2-devel] [Patch v2 1/2] UefiCpuPkg/RegisterCpuFeaturesLib: Remove debug message.

2019-08-05 Thread Dong, Eric
This debug message may be called by BSP and APs. It may caused ASSERT when APs call this debug code. In order to avoid system boot assert, Remove this debug message. Signed-off-by: Eric Dong Cc: Ray Ni Cc: Laszlo Ersek --- .../CpuFeaturesInitialize.c | 22

[edk2-devel] [Patch v2 2/2] UefiCpuPkg/PiSmmCpuDxeSmm: Remove debug message.

2019-08-05 Thread Dong, Eric
This debug message may be called by BSP and APs. It may caused ASSERT when APs call this debug code. In order to avoid system boot assert, Remove this debug message. Signed-off-by: Eric Dong Cc: Ray Ni Cc: Laszlo Ersek --- UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c | 22 +- 1 file

Re: [edk2-devel] [PATCH v2 1/1] UefiCpuPkg/PiSmmCpuDxeSmm: Make code consistent with comments

2019-08-02 Thread Dong, Eric
Reviewed-by: Eric Dong > -Original Message- > From: Zhang, Shenglei > Sent: Wednesday, July 31, 2019 11:38 AM > To: devel@edk2.groups.io > Cc: Zhang, Shenglei ; Dong, Eric > ; Ni, Ray ; Laszlo Ersek > > Subject: [PATCH v2 1/1] UefiCpuPkg/PiSmmCpuDxeSmm

Re: [edk2-devel] [PATCH v4 8/8] UefiCpuPkg: Update code to include register definitions from MdePkg

2019-08-01 Thread Dong, Eric
Ray, I found you miss to update copyright time for SmmStm.c file. With fix for this file, Reviewed-by: Eric Dong Thanks, Eric > -Original Message- > From: Ni, Ray > Sent: Thursday, August 1, 2019 5:59 PM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Laszlo Ersek >

Re: [edk2-devel] [PATCH v4 6/8] MdeModulePkg/DxeIpl: Create 5-level page table for long mode

2019-08-01 Thread Dong, Eric
Reviewed-by: Eric Dong > -Original Message- > From: Ni, Ray > Sent: Thursday, August 1, 2019 5:58 PM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Laszlo Ersek ; > Wu, Hao A ; Wang, Jian J > Subject: [PATCH v4 6/8] MdeModulePkg/DxeIpl: Create 5-level page table >

Re: [edk2-devel] [PATCH v4 5/8] MdePkg/Cpuid.h: Move Cpuid.h from UefiCpuPkg to MdePkg

2019-08-01 Thread Dong, Eric
, Eric > -Original Message- > From: Ni, Ray > Sent: Thursday, August 1, 2019 5:58 PM > To: devel@edk2.groups.io > Cc: Kinney, Michael D ; Gao, Liming > ; Dong, Eric ; Laszlo Ersek > > Subject: [PATCH v4 5/8] MdePkg/Cpuid.h: Move Cpuid.h from UefiCpuPkg to

Re: [edk2-devel] [PATCH v4 4/8] MdeModulePkg/DxeIpl: Introduce PCD PcdUse5LevelPageTable

2019-08-01 Thread Dong, Eric
Reviewed-by: Eric Dong > -Original Message- > From: Ni, Ray > Sent: Thursday, August 1, 2019 5:58 PM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Laszlo Ersek ; > Wu, Hao A ; Wang, Jian J > Subject: [PATCH v4 4/8] MdeModulePkg/DxeIpl: Introduce PCD > PcdUse

Re: [edk2-devel] [PATCH v4 3/8] UefiCpuPkg/CpuDxe: Support parsing 5-level page table

2019-08-01 Thread Dong, Eric
Reviewed-by: Eric Dong > -Original Message- > From: Ni, Ray > Sent: Thursday, August 1, 2019 5:58 PM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Laszlo Ersek > Subject: [PATCH v4 3/8] UefiCpuPkg/CpuDxe: Support parsing 5-level page > table > > REF: htt

Re: [edk2-devel] [PATCH v4 2/8] UefiCpuPkg/CpuDxe: Remove unnecessary macros

2019-08-01 Thread Dong, Eric
Reviewed-by: Eric Dong > -Original Message- > From: Ni, Ray > Sent: Thursday, August 1, 2019 5:58 PM > To: devel@edk2.groups.io > Cc: Yao, Jiewen ; Dong, Eric ; > Laszlo Ersek > Subject: [PATCH v4 2/8] UefiCpuPkg/CpuDxe: Remove unnecessary macros > > Today

  1   2   3   >