[edk2-devel] [edk2-staging][PATCH] BaseTools/Fmmt: Fix regression issue by b41fac8e

2020-07-20 Thread Feng, YunhuaX
Fix regression issue by b41fac8e Cc: Bob Feng Cc: Liming Gao Signed-off-by: Yunhua Feng --- .../Source/C/FMMT/FirmwareModuleManagement.c | 1 + BaseTools/Source/C/FMMT/FmmtLib.c | 20 +++ 2 files changed, 8 insertions(+), 13 deletions(-) diff --git

[edk2-devel] [PATCH] [edk2-staging]BaseTools/Fmmt: fix Some RAW encounter dead loop issue

2020-06-17 Thread Feng, YunhuaX
Some RAW ffs parse section for check UI section will encounter dead loop. Actually when FFS is raw FFS, not include UI section. Change-Id: I40e1cbb988bed30d8757008bad9074bc11eae135 Cc: Bob Feng Cc: Liming Gao Signed-off-by: Yunhua Feng --- BaseTools/Source/C/FMMT/FirmwareModuleManagement.c |

[edk2-devel] [PATCH] [edk2-staging]BaseTools/Fmmt: Replace FFS in FV include multiple GUID section

2020-06-04 Thread Feng, YunhuaX
Fmmt replace case like as below: One Fv include one GUID section, and the GUID section include multiple sub GUID section. This patch will support the replace case. Change-Id: I78f015e00f2b73e4e0e9ee36d03d24c697783a9c Cc: Bob Feng Cc: Liming Gao Signed-off-by: Yunhua Feng ---

Re: [edk2-devel] [edk2-staging][PATCH v2] BaseTools/Fmmt: Fix found the next FFS issue

2020-05-09 Thread Feng, YunhuaX
. -Original Message- From: Ni, Ray Sent: Saturday, May 9, 2020 4:28 PM To: Feng, YunhuaX ; devel@edk2.groups.io Cc: Gao, Liming ; Feng, Bob C Subject: RE: [edk2-staging][PATCH v2] BaseTools/Fmmt: Fix found the next FFS issue Yunhua, I understand that if the ffs size 0 should

[edk2-devel] [edk2-staging][PATCH v2] BaseTools/Fmmt: Fix found the next FFS issue

2020-05-09 Thread Feng, YunhuaX
if the ffs size is invalid, break the iteration and return NOT_FOUND. Cc: Ray Ni< ray...@intel.com> Cc: Bob Feng Cc: Liming Gao Change-Id: I9e320d6176af350ff208901209f3f6c89e4e1924 Signed-off-by: Yunhua Feng --- BaseTools/Source/C/FMMT/FmmtLib.c | 7 +++ 1 file changed, 7 insertions(+)

[edk2-devel] [PATCH] BaseTools/Fmmt: Fix found the next FFS issue

2020-05-09 Thread Feng, YunhuaX
if the ffs size is invalid, break the iteration and return NOT_FOUND. Cc: Ray Ni< ray...@intel.com> Cc: Bob Feng Cc: Liming Gao Change-Id: I9e320d6176af350ff208901209f3f6c89e4e1924 Signed-off-by: Yunhua Feng --- BaseTools/Source/C/FMMT/FmmtLib.c | 7 +++ 1 file changed, 7 insertions(+)

Re: [edk2-devel] [edk2-staging][PATCH] BaseTools/Fmmt: Fix found the next FFS issue

2020-05-08 Thread Feng, YunhuaX
Yes , you are right, the condition of break should think about Fv's erase policy, I will update this patch. Thank you -Original Message- From: devel@edk2.groups.io On Behalf Of Ni, Ray Sent: Saturday, May 9, 2020 11:28 AM To: Feng, YunhuaX ; devel@edk2.groups.io Cc: Feng, Bob C ; Gao

Re: [edk2-devel] [edk2-staging][PATCH] BaseTools/Fmmt: Fix found the next FFS issue

2020-05-08 Thread Feng, YunhuaX
]; EFI_FFS_FILE_STATE State; } EFI_FFS_FILE_HEADER -Original Message- From: Ni, Ray Sent: Saturday, May 9, 2020 10:46 AM To: devel@edk2.groups.io; Feng, YunhuaX Cc: Feng, Bob C ; Gao, Liming Subject: RE: [edk2-staging][PATCH] BaseTools/Fmmt: Fix found the next FFS issue Yunhua, Why the comparison

[edk2-devel] [edk2-staging][PATCH] BaseTools/Fmmt: Fix found the next FFS issue

2020-05-08 Thread Feng, YunhuaX
if found the next FFS size equal 0xFF, return NOT_FOUND Cc: Bob Feng Cc: Liming Gao Signed-off-by: Yunhua Feng --- BaseTools/Source/C/FMMT/FmmtLib.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/BaseTools/Source/C/FMMT/FmmtLib.c b/BaseTools/Source/C/FMMT/FmmtLib.c index

[edk2-devel] [PATCH v2] BaseTools: Fix parse PCD GUID expression issue

2020-05-08 Thread Feng, YunhuaX
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2686 The build tool will give an incorrect GUID value if the GUID includes character ' or " ASCII value. This patch is going to fix this issue. Cc: Bob Feng Cc: Liming Gao Signed-off-by: Yunhua Feng ---

[edk2-devel] [PATCH] BaseTools: Fix parse GUID expression issue

2020-05-05 Thread Feng, YunhuaX
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2686 some GUID include character ' or " ascii value, transfer to string will catch the wrong value. Cc: Bob Feng Cc: Liming Gao Signed-off-by: Yunhua Feng --- BaseTools/Source/Python/Common/Misc.py | 10 +- 1 file changed, 5

[edk2-devel] [edk2-staging][PATCH] BaseTools/FMMT: Fix FV add FFs issue

2020-04-20 Thread Feng, YunhuaX
when Fv not include any FFS, will encounter not enough space to add issue. Change-Id: Ie401f0edcf3f9b6bcae706a877b284e840f61fe9 Cc: Bob Feng Cc: Liming Gao Signed-off-by: Yunhua Feng --- BaseTools/Source/C/FMMT/FirmwareModuleManagement.c | 12 1 file changed, 12 insertions(+)

[edk2-devel] [edk2-staging][PATCH] BaseTools/FMMT: Correct the extract function help message

2020-04-17 Thread Feng, YunhuaX
Correct the extract function help message Cc: Bob Feng Cc: Liming Gao Signed-off-by: Yunhua Feng --- BaseTools/Source/C/FMMT/FirmwareModuleManagement.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/BaseTools/Source/C/FMMT/FirmwareModuleManagement.c

[edk2-devel] [edk2-staging][PATCH] BaseTools/Fmmt: Enhance for check input FD size

2020-04-02 Thread Feng, YunhuaX
Enhance for check input FD if empty file or not. Cc: Bob Feng Cc: Liming Gao Signed-off-by: Yunhua Feng --- BaseTools/Source/C/FMMT/FirmwareModuleManagement.c | 2 +- BaseTools/Source/C/FMMT/FmmtLib.c | 5 + 2 files changed, 6 insertions(+), 1 deletion(-) diff --git

[edk2-devel] [edk2-platforms][PATCH] Tools/FitGen: Update the UTILITY_MINOR_VERSION

2020-02-20 Thread Feng, YunhuaX
Update the UTILITY_MINOR_VERSION from 59 to 60 Cc: Bob Feng Cc: Liming Gao Signed-off-by: Yunhua Feng --- Silicon/Intel/Tools/FitGen/FitGen.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Silicon/Intel/Tools/FitGen/FitGen.h b/Silicon/Intel/Tools/FitGen/FitGen.h index

[edk2-devel] [PATCH] Tools/FitGen: Check the input file path before open it

2020-02-19 Thread Feng, YunhuaX
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2117 avoid path traversal attack check. Cc: Bob Feng Cc: Liming Gao Signed-off-by: Yunhua Feng --- Silicon/Intel/Tools/FitGen/FitGen.c | 47 + 1 file changed, 47 insertions(+) diff --git

[edk2-devel] [PATCH] [edk2-staging/FceFmmt]BaseTools: Support no UI section FFS

2020-02-12 Thread Feng, YunhuaX
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2521 1. If FFS file has no UI section, its FILE_GUID will be used as its name. FMMT tool -d/-a/-r option can be updated to support such FFS file. 2. -v option will print FILE_GUID if no UI section Cc: Bob Feng Cc: Liming Gao Signed-off-by: