Hi jian and xiaoyu, could you please help review this change. Original message From: "GuoMinJ via Groups.Io" Date: Wed, Feb 26, 2020, 10:24 AMTo: devel@edk2.groups.ioCc: GuoMinJ Subject: [edk2-devel] [PATCH] CryptoPkg: Check the type is data and Support other OID types.
Hi jiang, haocould you please help verify this change. Original message From: "GuoMinJ via Groups.Io" Date: Sat, Feb 22, 2020, 1:19 PMTo: devel@edk2.groups.ioCc: GuoMinJ Subject: [edk2-devel] [PATCH] MdeModulePkg/SmiHandlerProfileInfo: Overflowed Array Index
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2552
According to CryptoPkg.dsc, the library class only have HashApiLib, so i
think the BaseHashApiLib should be considered as base name rather than
library class.
Cc: Jian J Wang
Cc: Xiaoyu Lu
Signed-off-by: GuoMinJ
---
CryptoPkg/Library
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2552
DxeCryptLibConstructor have no comments for it, add comments for it.
Cc: Jian J Wang
Cc: Xiaoyu Lu
Signed-off-by: GuoMinJ
---
.../Library/BaseCryptLibOnProtocolPpi/DxeCryptLib.c | 9 +
1 file changed, 9 insertions(+)
diff
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2530
The Suite pointer is used before check if it is valid,
correct it to check the validation before use.
Cc: Michael D Kinney
Cc: Sean Brogan
Cc: Bret Barkelew
Signed-off-by: GuoMinJ
---
UnitTestFrameworkPkg/Library/UnitTestLib
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2531
AllocatePool may fail and BinData may be invalid, check
it before use.
Cc: Michael D Kinney
Cc: Liming Gao
Signed-off-by: GuoMinJ
---
MdePkg/Test/UnitTest/Library/BaseLib/Base64UnitTest.c | 3 +++
1 file changed, 3 insertions(+)
diff
https://bugzilla.tianocore.org/show_bug.cgi?id=2518
ECC need '.' character at the end of line.
Ray Ni
Rangasai V Chaganty
Signed-off-by: GuoMinJ
---
.../Intel/IntelSiliconPkg/Include/Library/ConfigBlockLib.h | 6 +++---
.../Library/BaseConfigBlockLib/BaseConfigBlockLib.c | 6
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2531
AllocatePool may fail and BinData may be invalid, check
it before use.
Cc: Michael D Kinney
Cc: Liming Gao
Signed-off-by: GuoMinJ
---
MdePkg/Test/UnitTest/Library/BaseLib/Base64UnitTest.c | 3 +++
1 file changed, 3 insertions(+)
diff
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2553
The comment haven't indicate the output attribute.
Cc: Eric Dong
Cc: Ray Ni
Cc: Laszlo Ersek
Signed-off-by: GuoMinJ
---
UefiCpuPkg/Library/MpInitLib/DxeMpLib.c | 2 +-
UefiCpuPkg/Library/MpInitLib/MpLib.h| 2 +-
UefiCpuPkg/Library
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2286
Token pointer may be NULL, it is should be check before use it.
Cc: Hao A Wu
Cc: Ray Ni
Signed-off-by: GuoMinJ
---
MdeModulePkg/Bus/Sd/SdDxe/SdBlockIo.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2539
Microsoft signtool supports creation of attached P7's with any OID payload
via the "/p7co" parameter. It is necessary to check the data before get
the string.
Signed-off-by: GuoMinJ
---
.../BaseCryptLib/Pk/CryptPkcs7VerifyBase
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2319
__debugbreak() in any application will terminate the application on
windows 10. add /debug option for debugging windows 10.
Signed-off-by: GuoMinJ
---
EmulatorPkg/Win/Host/WinHost.c | 30 ++
1 file changed, 30
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2552
Some issue is reported by ECC tool, correct it.
Signed-off-by: GuoMinJ
---
.../Library/BaseCryptLibOnProtocolPpi/DxeCryptLib.c | 9 +
CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.inf | 2 +-
2 files changed, 10
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2553
The comment haven't indicate the output attribute.
Signed-off-by: GuoMinJ
---
UefiCpuPkg/Library/MpInitLib/DxeMpLib.c | 2 +-
UefiCpuPkg/Library/MpInitLib/MpLib.h| 2 +-
UefiCpuPkg/Library/MpInitLib/PeiMpLib.c | 2 +-
3 files changed
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2286
Token pointer may be NULL, it is should be check before use it.
Signed-off-by: GuoMinJ
---
MdeModulePkg/Bus/Sd/SdDxe/SdBlockIo.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/MdeModulePkg/Bus/Sd/SdDxe
be off-by one than size of array, so when check
array, the max index should less than size of array.
Signed-off-by: GuoMinJ
---
.../SmiHandlerProfileInfo/SmiHandlerProfileInfo.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git
a/MdeModulePkg/Application
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2145
Replace the gEfiFormBrowserExProtocolGuid with
gEdkiiFormBrowserExProtocolGuid, remove the unnecessary declaration.
Signed-off-by: GuoMinJ
---
MdeModulePkg/Include/Protocol/FormBrowserEx.h | 1 -
MdeModulePkg/MdeModulePkg.ci.yaml
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2286
Token pointer may be NULL, it is should be check before use it.
Signed-off-by: GuoMinJ
---
MdeModulePkg/Bus/Sd/SdDxe/SdBlockIo.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/MdeModulePkg/Bus/Sd/SdDxe
be off-by one than size of array, so when check
array, the max index should less than size of array.
Signed-off-by: GuoMinJ
---
.../SmiHandlerProfileInfo/SmiHandlerProfileInfo.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git
a/MdeModulePkg/Application
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2272
Index should be off-by one than size of array, so when check
mUsbTypeString, the max index should less than size of array.
Signed-off-by: GuoMinJ
---
.../Application/SmiHandlerProfileInfo/SmiHandlerProfileInfo.c | 2 +-
1 file changed
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2535
The UINT_TEST_STATUS and FAILURE_TYPE have used 0 as status, so use 0 as
unknown is confused, remove it from array enumeration but keep it
location in the array.
Signed-off-by: GuoMinJ
---
.../Library/UnitTestResultReportLib
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2531
AllocatePool may fail and BinData may be invalid, check
it before use.
Signed-off-by: GuoMinJ
---
MdePkg/Test/UnitTest/Library/BaseLib/Base64UnitTest.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/MdePkg/Test/UnitTest/Library
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2530
The Suite pointer is used before check if it is valid,
correct it to check the validation before use.
Signed-off-by: GuoMinJ
---
UnitTestFrameworkPkg/Library/UnitTestLib/RunTests.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions
I agree with this comment.
Laszlo Ersek 于2020年2月17日周一 下午5:32写道：
> On 02/13/20 19:33, Philippe Mathieu-Daudé wrote:
> > On 2/13/20 7:29 PM, Philippe Mathieu-Daude wrote:
> >> Math expressions written in terms of SafeIntLib function calls
> >> are easily readable, making review trivial. Convert
I agree with this comment.
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#54572): https://edk2.groups.io/g/devel/message/54572
Mute This Topic: https://groups.io/mt/71248587/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe:
I agree with this comment.
Thanks.
Guomin
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#54570): https://edk2.groups.io/g/devel/message/54570
Mute This Topic: https://groups.io/mt/71248587/21656
Group Owner: devel+ow...@edk2.groups.io
https://bugzilla.tianocore.org/show_bug.cgi?id=2518
ECC need '.' character at the end of line.
Signed-off-by: GuoMinJ
---
.../Intel/IntelSiliconPkg/Include/Library/ConfigBlockLib.h | 6 +++---
.../Library/BaseConfigBlockLib/BaseConfigBlockLib.c | 6 +++---
2 files changed, 6
https://bugzilla.tianocore.org/show_bug.cgi?id=2515
Change the FmpDevicePkg to match the ECC check rule
Signed-off-by: GuoMinJ
---
FmpDevicePkg/FmpDxe/Dependency.c | 4 ++--
FmpDevicePkg/FmpDxe/Dependency.h | 2 +-
FmpDevicePkg/FmpDxe/FmpDxe.c | 2 +-
3 files changed, 4 insertions(+), 4
https://bugzilla.tianocore.org/show_bug.cgi?id=2515
Change the SecurityPkg to match the ECC check rule
Signed-off-by: GuoMinJ
---
SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c | 4 ++--
SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/SecurityPkg
https://bugzilla.tianocore.org/show_bug.cgi?id=2515
Change the MdeModulePkg to match the ECC check rule
Signed-off-by: GuoMinJ
---
MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c | 4 ++--
MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c | 2 +-
MdeModulePkg/MdeModulePkg.uni
30 matches
Mail list logo
