Re: [edk2-devel] [PATCH v1 1/1] ShellPkg/UefiShellBcfgCommandLib: Fix '-opt' option

2019-08-12 Thread Jonathan Watt
I see this landed last week. Many thanks to everyone for their input and for getting this landed. Jonathan On 05/08/2019 01:51, Gao, Zhichao wrote: > Agree. I would prepare this patch for push. > > Thanks, > Zhichao > >> -Original Message- >> From: Carsey, Jaben >> Sent: Saturday, Augus

Re: [edk2-devel] [PATCH v1 1/1] ShellPkg/UefiShellBcfgCommandLib: Fix '-opt' option

2019-08-02 Thread Jonathan Watt
It's been three months now since I contributed the patch. Could someone update me on the progress on getting it landed? On 11/06/2019 22:53, Jonathan Watt wrote: > Since I haven't contributed before I'm not sure what the timeline for these > things generally is. It's be

Re: [edk2-devel] [PATCH v1 1/1] ShellPkg/UefiShellBcfgCommandLib: Fix '-opt' option

2019-06-11 Thread Jonathan Watt
-- > From: Carsey, Jaben > Sent: Tuesday, May 7, 2019 5:00 PM > To: Jonathan Watt ; devel@edk2.groups.io; > tim.le...@insyde.com; Gao, Zhichao ; Ni, Ray > > Cc: Bi, Dandan > Subject: RE: [edk2-devel] [PATCH v1 1/1] ShellPkg/UefiShellBcfgCommandLib: > Fix '-opt' o

Re: [edk2-devel] [PATCH v1 1/1] ShellPkg/UefiShellBcfgCommandLib: Fix '-opt' option

2019-05-07 Thread Jonathan Watt
the specification you refer to that was used to > write the non-EDK2 implementations say about the -opt switch? > > Regards, > Jim > > -----Original Message- > From: devel@edk2.groups.io On Behalf Of Tim Lewis > Sent: Tuesday, May 7, 2019 3:04 PM > To: 'Jonathan W

Re: [edk2-devel] [PATCH v1 1/1] ShellPkg/UefiShellBcfgCommandLib: Fix '-opt' option

2019-05-07 Thread Jonathan Watt
rs. And it didn't > cause us grief with our other product which does use an EDK2-derived shell. > > Best regards, > Tim > > -----Original Message- > From: devel@edk2.groups.io On Behalf Of Jonathan Watt > Sent: Tuesday, May 7, 2019 1:51 PM > To: Tim Lewis ; &#

Re: [edk2-devel] [PATCH v1 1/1] ShellPkg/UefiShellBcfgCommandLib: Fix '-opt' option

2019-05-07 Thread Jonathan Watt
my company, that > are implemented to the specification. Server platforms that use the > "application" style boot options can regularly run over 10 options. > > I believe the better alternative is to add a new option in the specification > and leave the existing syntax for -o

Re: [edk2-devel] [PATCH v1 1/1] ShellPkg/UefiShellBcfgCommandLib: Fix '-opt' option

2019-05-07 Thread Jonathan Watt
to happen. On 07/05/2019 20:00, Jonathan Watt wrote: > There is potential for that, but it's not certain. For it to happen scripts > would need to be both omitting the "0x" prefix and be pass an option number > greater than 9. The fact this very unexpected inconsistency (w

Re: [edk2-devel] [PATCH v1 1/1] ShellPkg/UefiShellBcfgCommandLib: Fix '-opt' option

2019-05-07 Thread Jonathan Watt
gt; Zhichao >>> >>>> -Original Message- >>>> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf >>>> Of >>> Ni, >>>> Ray >>>> Sent: Monday, May 6, 2019 10:02 PM >>>> To: jw...@jwatt.org; dev

[edk2-devel] [PATCH v1 0/1] ShellPkg/UefiShellBcfgCommandLib: Fix '-opt' option number handling

2019-05-06 Thread Jonathan Watt
From: Jonathan Watt Fixes `bcfg boot -opt #` handling of the "#" option number to be consistent with the other commands. Removes a footgun that bit me and corrupted a different boot option than the one I meant to edit. https://github.com/jwatt/edk2/tree/bcfg_args_fix Jonath

[edk2-devel] [PATCH v1 1/1] ShellPkg/UefiShellBcfgCommandLib: Fix '-opt' option

2019-05-06 Thread Jonathan Watt
From: Jonathan Watt For all other bcfg commands the "#" (option number) argument(s) are treated as hexedecimal values regardless of whether or not they are prefixed by "0x". This change fixes '-opt' to handle its "#" (option number) argument consistent