Re: [edk2-devel] [Patch v2 00/11] New Cross OS tool chain CLANG9

2019-10-15 Thread Liming Gao
Fish ; Ni, Ray ; Ard Biesheuvel >; Wang, Jian J ; Wu, Hao >A ; Feng, Bob C ; Kinney, >Michael D >Subject: Re: [edk2-devel] [Patch v2 00/11] New Cross OS tool chain CLANG9 > >On 10/15/19 02:26, Liming Gao wrote: >> In v2, drop patch 12, and update commit message for

Re: [edk2-devel] [PATCH V4 00/10] UEFI Variable SMI Reduction

2019-10-14 Thread Liming Gao
ePendingUpdate flag is cleared > 3. Perform read from RuntimeCache > 4. Release RuntimeCacheReadLock > >Proposed FlushRuntimeCachePendingUpdate SMI >---- > 1. If RuntimeCachePendingUpdate flag is not set: > 1.a. Return > 2. Copy th

[edk2-devel] [Patch v2 09/11] CryptoPkg IntrinsicLib: Make _fltused always be used

2019-10-14 Thread Liming Gao
With this change, global variable _fltused will not be removed by LTO Signed-off-by: Liming Gao --- CryptoPkg/Library/IntrinsicLib/MemoryIntrinsics.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/CryptoPkg/Library/IntrinsicLib/MemoryIntrinsics.c b/CryptoPkg

[edk2-devel] [Patch v2 07/11] MdeModulePkg RegularExpressionDxe: Disable warning for CLANG9 tool chain

2019-10-14 Thread Liming Gao
Signed-off-by: Liming Gao --- MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf | 3 +++ 1 file changed, 3 insertions(+) diff --git a/MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf b/MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf

[edk2-devel] [Patch v2 03/11] BaseTools GenFw: Fix the issue to update the wrong size as SectionSize

2019-10-14 Thread Liming Gao
Signed-off-by: Liming Gao --- BaseTools/Source/C/GenFw/GenFw.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/BaseTools/Source/C/GenFw/GenFw.c b/BaseTools/Source/C/GenFw/GenFw.c index c99782b78e..d8d3360c24 100644 --- a/BaseTools/Source/C/GenFw/GenFw.c +++ b

[edk2-devel] [Patch v2 05/11] MdePkg BaseIoLibIntrinsic: Remove __inline__ attribute for IO functions

2019-10-14 Thread Liming Gao
__inline__ has no functional difference effect with the GCC48 / GCC49 / GCC5 toolchains, but it breaks the build with CLANG9. Remove __inline__. Signed-off-by: Liming Gao Acked-by: Laszlo Ersek --- MdePkg/Library/BaseIoLibIntrinsic/IoLibGcc.c | 6 -- 1 file changed, 6 deletions(-) diff

[edk2-devel] [Patch v2 01/11] BaseTools tools_def.template: Remove unnecessary $(DEST_DIR_DEBUG) path

2019-10-14 Thread Liming Gao
$(DEST_DIR_DEBUG) path is in Include directory. It is not required to be specified again. Signed-off-by: Liming Gao --- BaseTools/Conf/tools_def.template | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/BaseTools/Conf/tools_def.template b/BaseTools

[edk2-devel] [Patch v2 11/11] OvmfPkg: Enable CLANG9 tool chain

2019-10-14 Thread Liming Gao
1. Apply CLANG9 Linker option. 2. Exclude -mno-mmx -mno-sse compiler option for CLANG9 These two options will cause CLANG Linker crush. Signed-off-by: Liming Gao Reviewed-by: Laszlo Ersek --- OvmfPkg/OvmfPkgIa32.dsc| 4 +++- OvmfPkg/OvmfPkgIa32X64.dsc | 4 +++- OvmfPkg/OvmfPkgX64.dsc

[edk2-devel] [Patch v2 08/11] CryptoPkg: Append options to make CLANG9 tool chain pass build

2019-10-14 Thread Liming Gao
Disable warning reported from CLANG9. Signed-off-by: Liming Gao --- CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf| 1 + CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf | 1 + CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf | 1 + CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf

[edk2-devel] [Patch v2 10/11] EmulatorPkg: Enable CLANG9 tool chain

2019-10-14 Thread Liming Gao
1. Append CLANG CC and LINK flags to generate windows HOST. 2. Modify WinHost to move PCD getting in the late position Signed-off-by: Liming Gao --- EmulatorPkg/Win/Host/WinHost.c | 11 +++ EmulatorPkg/EmulatorPkg.dsc | 8 ++-- EmulatorPkg/EmulatorPkg.fdf | 2

[edk2-devel] [Patch v2 02/11] BaseTools tools_def: Add CLANG9 tool chain to directly generate PE image

2019-10-14 Thread Liming Gao
Signed-off-by: Liming Gao --- BaseTools/Conf/build_rule.template | 26 ++ BaseTools/Conf/tools_def.template | 102 + 2 files changed, 118 insertions(+), 10 deletions(-) diff --git a/BaseTools/Conf/build_rule.template b/BaseTools/Conf

[edk2-devel] [Patch v2 06/11] MdeModulePkg LzmaCustomDecompressLib: Update macro to be same in CLANG tool

2019-10-14 Thread Liming Gao
Define the same macro in the different OS. It can make CLANG generate the same image in the different host OS. Signed-off-by: Liming Gao --- MdeModulePkg/Library/LzmaCustomDecompressLib/Sdk/C/7zTypes.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MdeModulePkg/Library

[edk2-devel] [Patch v2 00/11] New Cross OS tool chain CLANG9

2019-10-14 Thread Liming Gao
Cc: Ard Biesheuvel Cc: Jian J Wang Cc: Hao A Wu Cc: Bob Feng Cc: Michael D Kinney Liming Gao (11): BaseTools tools_def.template: Remove unnecessary $(DEST_DIR_DEBUG) path BaseTools tools_def: Add CLANG9 tool chain to directly generate PE image BaseTools GenFw: Fix the i

[edk2-devel] [Patch v2 04/11] MdePkg Base.h: Add definition for CLANG9 tool chain

2019-10-14 Thread Liming Gao
CLANG9 tool chain defines __clang__ macro only, doesn't define __GNUC__ macro. But, it uses some same definitions with GCC. So, update base definition for CLANG9 tool chain. Signed-off-by: Liming Gao --- MdePkg/Include/Base.h | 6 +++--- MdePkg/Include/Ia32/ProcessorBind.h | 4

Re: [edk2-devel] [PATCH] Add support for FuSA ACM in FitGen tool

2019-10-14 Thread Liming Gao
t;A new FIT entry type (FIT Type 0x3) has been allocated for FuSa ACM. >FitGen tool is updated to add support for this FuSa ACM. > >Cc: Bob Feng >Cc: Liming Gao > >Signed-off-by: Sachin Agrawal >--- > Silicon/Intel/Tools/FitGen/FitGen.c | 82 >+++

Re: [edk2-devel] [PATCH 1/1] MdeModulePkg/BdsDxe: Fix calling PlatformBootManagerWaitCallback on 0

2019-10-14 Thread Liming Gao
apple.com >Subject: Re: [edk2-devel] [PATCH 1/1] MdeModulePkg/BdsDxe: Fix calling >PlatformBootManagerWaitCallback on 0 > >Hi Liming, > >On 10/12/19 03:44, Gao, Liming wrote: >> Reviewed-by: Liming Gao > >can you please add > > Ref: https://bugzilla.tianocore.org

Re: [edk2-devel] [Patch 11/12] OvmfPkg: Enable CLANG9 tool chain

2019-10-12 Thread Liming Gao
Laszlo: >-Original Message- >From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >Laszlo Ersek >Sent: Friday, October 11, 2019 5:37 PM >To: Gao, Liming >Cc: Andrew Fish ; devel@edk2.groups.io; Tom Lendacky > >Subject: Re: [edk2-devel] [Patch 11/12] OvmfPkg: Enable

Re: [edk2-devel] [RFC PATCH v2 38/44] UefiCpuPkg: Allow AP booting under SEV-ES

2019-10-12 Thread Liming Gao
Andrew: Can you give more detail on how to update nasm source code to put the 64bit absolute address from .text section to .data section? I will verify it. Now, the patching way doesn't support X64 SEC/PEI. This is a gab in XCODE tool chain. Thanks Liming From: devel@edk2.groups.io

Re: [edk2-devel] [Patch 05/12] MdePkg BaseIoLibIntrinsic: Remove __inline__ attribute for IO functions

2019-10-12 Thread Liming Gao
bute for IO functions > >On 2019-10-10 09:32:19, Laszlo Ersek wrote: >> Hi Liming, Andrew, >> >> On 10/10/19 14:32, Liming Gao wrote: >> > Laszlo: >> > >> >> -Original Message- >> >> From: Laszlo Ersek >> >> Sent

Re: [edk2-devel] [Patch 1/1] BaseTools: Fix a bug of genffs command generation

2019-10-12 Thread Liming Gao
. Reviewed-by: Liming Gao Thanks Liming >-Original Message- >From: Feng, Bob C >Sent: Friday, September 27, 2019 10:30 AM >To: devel@edk2.groups.io >Cc: Gao, Liming ; Feng, Bob C >Subject: [Patch 1/1] BaseTools: Fix a bug of genffs command generation > >REF: https:

Re: [edk2-devel] [PATCH 1/1] MdeModulePkg/BdsDxe: Fix calling PlatformBootManagerWaitCallback on 0

2019-10-11 Thread Liming Gao
Reviewed-by: Liming Gao >-Original Message- >From: Pete Batard [mailto:p...@akeo.ie] >Sent: Friday, October 11, 2019 11:44 PM >To: devel@edk2.groups.io >Cc: af...@apple.com; ler...@redhat.com; Gao, Liming >Subject: [PATCH 1/1] MdeModulePkg/B

Re: [edk2-devel] [Patch 11/12] OvmfPkg: Enable CLANG9 tool chain -

2019-10-10 Thread Liming Gao
chain - > >Hi Liming, > >On 10/10/19 14:18, Liming Gao wrote: >>> -Original Message- >>> From: devel@edk2.groups.io On Behalf Of Laszlo >Ersek >>> Sent: Thursday, October 10, 2019 3:35 PM >>> To: Andrew Fish ; Gao, Liming >>> Cc:

Re: [edk2-devel] [Patch 12/12] OvmfPkg SecMain: Add build option "-fno-omit-frame-pointer" for CLANG9 X64

2019-10-10 Thread Liming Gao
-frame-pointer" for CLANG9 X64 > >Hi Liming, > >On 10/10/19 16:08, Liming Gao wrote: >> Laszlo: >> Option (a) works. Jordan patch can fix this issue. >> Option (b) doesn't work. Even if disable optimization, CLANG doesn't >generate the code with push rbp

Re: [edk2-devel] [Patch 05/12] MdePkg BaseIoLibIntrinsic: Remove __inline__ attribute for IO functions

2019-10-10 Thread Liming Gao
oLibIntrinsic: Remove >__inline__ attribute for IO functions > >Hi Liming, Andrew, > >On 10/10/19 14:32, Liming Gao wrote: >> Laszlo: >> >>> -Original Message- >>> From: Laszlo Ersek >>> Sent: Wednesday, October 9, 2019 4:22 AM >>

Re: [edk2-devel] OVMF is crashing for me in master

2019-10-10 Thread Liming Gao
Andrew: I verify the change (2de1f611be06ded3a59726a4052a9039be7d459b MdeModulePkg/BdsDxe: Also call PlatformBootManagerWaitCallback on 0) in Emulator. It works, because PCD value is set to 10 in Emulator. Before this change, if TimeOut PCD is zero, BdsEntry doesn't call

Re: [edk2-devel] [Patch 12/12] OvmfPkg SecMain: Add build option "-fno-omit-frame-pointer" for CLANG9 X64

2019-10-10 Thread Liming Gao
ssue to add new CLANG9 tool chain. I will try to add CLANG9 tool chain patch without this change, and use BZ 2024 to track this issue. Thanks Liming > -Original Message- > From: devel@edk2.groups.io On Behalf Of Liming Gao > Sent: Tuesday, October 8, 2019 11:10 PM > To: Lasz

Re: [edk2-devel] [Patch 05/12] MdePkg BaseIoLibIntrinsic: Remove __inline__ attribute for IO functions

2019-10-10 Thread Liming Gao
Laszlo: > -Original Message- > From: Laszlo Ersek > Sent: Wednesday, October 9, 2019 4:22 AM > To: Gao, Liming ; devel@edk2.groups.io; af...@apple.com > Subject: Re: [edk2-devel] [Patch 05/12] MdePkg BaseIoLibIntrinsic: Remove > __inline__ attribute for IO functions > > On 10/08/19

Re: [edk2-devel] [Patch 11/12] OvmfPkg: Enable CLANG9 tool chain -

2019-10-10 Thread Liming Gao
> -Original Message- > From: devel@edk2.groups.io On Behalf Of Laszlo Ersek > Sent: Thursday, October 10, 2019 3:35 PM > To: Andrew Fish ; Gao, Liming > Cc: devel@edk2.groups.io > Subject: Re: [edk2-devel] [Patch 11/12] OvmfPkg: Enable CLANG9 tool chain - > > Hi Andrew, > > On

Re: [edk2-devel] [Patch 11/12] OvmfPkg: Enable CLANG9 tool chain

2019-10-09 Thread Liming Gao
Laszlo: > -Original Message- > From: Laszlo Ersek > Sent: Wednesday, October 9, 2019 9:44 PM > To: Andrew Fish ; devel@edk2.groups.io > Cc: Gao, Liming > Subject: Re: [edk2-devel] [Patch 11/12] OvmfPkg: Enable CLANG9 tool chain > > On 10/09/19 01:08, Andrew Fish wrote: > > > So I

Re: [edk2-devel] [PATCH edk2-platforms 3/6] Maintainers.txt: revamp file to machine-readable format

2019-10-09 Thread Liming Gao
t; Platform/Intel/Vlv2TbltDevicePkg > +F: Platform/Intel/Vlv2TbltDevicePkg/ > M: Zailiang Sun > M: Yi Qian > > Platform/Intel/AdvancedFeaturePkg > +F: Platform/Intel/AdvancedFeaturePkg/ > M: Michael Kubacki > M: Sai Chaganty > R: Liming Gao > &g

Re: [edk2-devel] Patch for Bug 2236 on Bugzilla

2019-10-09 Thread Liming Gao
Kenji: Please use git format-patch -1 to generate the patch, then use git send-email xxx.patch to send this patch to devel@edk2.groups.io Besides, is there the track in edk2 https://bugzilla.tianocore.org/? If no, can you submit one? Thanks Liming From:

Re: [edk2-devel] [Patch 12/12] OvmfPkg SecMain: Add build option "-fno-omit-frame-pointer" for CLANG9 X64

2019-10-08 Thread Liming Gao
tion > "-fno-omit-frame-pointer" for CLANG9 X64 > > + Jordan > > On 09/27/19 09:46, Liming Gao wrote: > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2024 > > > > Signed-off-by: Liming Gao > > --- > > OvmfPkg/Sec/SecMain.inf | 4 +

Re: [edk2-devel] [Patch 11/12] OvmfPkg: Enable CLANG9 tool chain

2019-10-08 Thread Liming Gao
Laszlo: > -Original Message- > From: Laszlo Ersek > Sent: Tuesday, October 1, 2019 4:42 AM > To: devel@edk2.groups.io; Gao, Liming > Subject: Re: [edk2-devel] [Patch 11/12] OvmfPkg: Enable CLANG9 tool chain > > Hi Liming, > > On 09/27/19 09:46, Liming Gao

Re: [edk2-devel] [Patch 05/12] MdePkg BaseIoLibIntrinsic: Remove __inline__ attribute for IO functions

2019-10-08 Thread Liming Gao
, 2019, at 3:35 PM, Laszlo Ersek mailto:ler...@redhat.com>> wrote: Hi Liming, On 09/27/19 09:46, Liming Gao wrote: __inline__ attribute will make the functions not be exposed as the library interface. It will cause CLANG9 compiler fail. Signed-off-by: Liming Gao mailto:liming@int

Re: [edk2-devel] [PATCH 1/1] MdeModulePkg/BdsDxe: Also call PlatformBootManagerWaitCallback on 0

2019-10-08 Thread Liming Gao
Push @2de1f611be06ded3a59726a4052a9039be7d459b > -Original Message- > From: devel@edk2.groups.io On Behalf Of Laszlo Ersek > Sent: Tuesday, October 1, 2019 7:12 AM > To: devel@edk2.groups.io; Ni, Ray ; p...@akeo.ie > Cc: Gao, Zhichao > Subject: Re: [edk2-devel] [PATCH 1/1]

Re: [edk2-devel] Problem with decompression on EDK2

2019-10-08 Thread Liming Gao
BaseTools VolInfo tool. Its input is the binary FvImage file. In the same directory, GuidedSectionTools.txt (built in the FV directory) should be here. Thanks Liming > -Original Message- > From: Loh, Tien Hock > Sent: Tuesday, October 1, 2019 10:34 AM > To: Gao, Liming ;

Re: [edk2-devel] [PATCH v2] MdePkg:Include: Update SmBios header file

2019-10-08 Thread Liming Gao
nd are a > prerequisite for the code destined to go in there. > > Best Regards, > > Leif > > On Tue, Oct 08, 2019 at 01:14:35AM +, Gao, Liming wrote: > > Abner: > > Thanks for your notice. I see the public SMBIOS 3.3.0. > > > > For this patch s

Re: [edk2-devel] [PATCH v5 0/3] Update to support SmBios 3.3.0

2019-10-08 Thread Liming Gao
Reviewed-by: Liming Gao > -Original Message- > From: devel@edk2.groups.io On Behalf Of Abner Chang > Sent: Tuesday, October 8, 2019 4:04 PM > To: devel@edk2.groups.io > Cc: abner.ch...@hpe.com > Subject: [edk2-devel] [PATCH v5 0/3] Update to support SmBios 3.3.0

Re: [edk2-devel] [PATCH v2] MdePkg:Include: Update SmBios header file

2019-10-07 Thread Liming Gao
Abner: Thanks for your notice. I see the public SMBIOS 3.3.0. For this patch set, I have two minor comments. For other part, Reviewed-by: Liming Gao 1) Please add BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2202 in the commit message. 2) The comment

[edk2-devel] Mike will be the back up maintainers for Edk2 packages when Chinese National Holiday (Oct.1 ~ Oct.7)

2019-09-30 Thread Liming Gao
Hi, all Some Edk2 package maintainers are in China. We will take Chinese National Holiday (Oct.1 ~ Oct.7). In this period, Michael D Kinney will be the backup maintainers for those Edk2 packages. Thanks for Mike great support. Thanks Liming -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive

Re: [edk2-devel] [PATCH 1/3] MdePkg/Include: correct Lasa in Tpm2Acpi.

2019-09-29 Thread Liming Gao
Reviewed-by: Liming Gao >-Original Message- >From: Yao, Jiewen >Sent: Sunday, September 29, 2019 2:16 PM >To: devel@edk2.groups.io >Cc: Kinney, Michael D ; Gao, Liming > >Subject: [PATCH 1/3] MdePkg/Include: correct Lasa in Tpm2Acpi. > >Correct Lasa accord

Re: [edk2-devel] [PATCH] BaseTools/LzmaCompress: Fix the option "d" dictionary size

2019-09-29 Thread Liming Gao
Reviewed-by: Liming Gao >-Original Message- >From: Zhang, Shenglei >Sent: Monday, September 30, 2019 11:52 AM >To: devel@edk2.groups.io >Cc: Feng, Bob C ; Gao, Liming >Subject: [PATCH] BaseTools/LzmaCompress: Fix the option "d" dictionary size > >The ra

Re: [edk2-devel] [PATCH v8 0/4] Add SCSI Support for Storage Security Command Protocol

2019-09-29 Thread Liming Gao
I have no other comments. Reviewed-by: Liming Gao >-Original Message- >From: Wu, Hao A >Sent: Sunday, September 29, 2019 3:31 PM >To: devel@edk2.groups.io; Zurcher, Christopher J >; Gao, Liming >Cc: Kinney, Michael D ; Yao, Jiewen >; Wang, Jian J >Subject: RE:

Re: [edk2-devel] [PATCH 1/1] MdeModulePkg/BdsDxe: Also call PlatformBootManagerWaitCallback on 0

2019-09-29 Thread Liming Gao
This change is good to me. I also verify it in Emulator platform. Reviewed-by: Liming Gao Thanks Liming >-Original Message- >From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >Laszlo Ersek >Sent: Friday, September 27, 2019 3:30 AM >To: devel@ed

Re: [edk2-devel] Problem with decompression on EDK2

2019-09-29 Thread Liming Gao
Tien Hock: The image is correct. It can be decompressed by lzma. When FD is loaded into 0x5, I suspect that the image data can't fully read. Then, the decompress will failure. FD image last valid byte offset is 0xC1B8F. Its value is 0x83. When FD base address is 0x5, this

Re: [edk2-devel] [Patch 09/12] CryptoPkg IntrinsicLib: Make _fltused always be used

2019-09-29 Thread Liming Gao
sage? > >+#if defined(__GNUC__) || defined(__clang__) >+ #define GLOBAL_USED __attribute__((used)) >+#else >+ #define GLOBAL_USED >+#endif > >> -----Original Message- >> From: devel@edk2.groups.io On Behalf Of Liming >Gao >> Sent: Friday, Septembe

Re: [edk2-devel] [Patch 1/1] BaseTools: Fix the lib order in static_library_files.lst

2019-09-28 Thread Liming Gao
Reviewed-by: Liming Gao >-Original Message- >From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >Bob Feng >Sent: Friday, September 27, 2019 7:35 PM >To: devel@edk2.groups.io >Cc: Gao, Liming ; dann frazier >; Feng, Bob C >Subject: [edk2-deve

Re: [edk2-devel] [Patch 1/1] BaseTools: Fix a bug of genffs command generation

2019-09-28 Thread Liming Gao
gt;It should be based on the OS type. > >Cc: Liming Gao >Signed-off-by: Bob Feng >--- > BaseTools/Source/Python/GenFds/GenFdsGlobalVariable.py | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > >diff --git a/BaseTools/Source/Python/GenFds/GenFdsGlobalVariable.py >

Re: [edk2-devel] [PATCH V2] MdeModulePkg/TerminalDxe: Enhance the arrow keys support

2019-09-27 Thread Liming Gao
send ESC [A through to ESC [D. Add this >> support for the new introduced terminal type. >> >> Cc: Jian J Wang >> Cc: Hao A Wu >> Cc: Ray Ni >> Cc: Liming Gao >> Signed-off-by: Zhichao Gao >> --- >> .../Universal/Console/Termina

[edk2-devel] [Patch 11/12] OvmfPkg: Enable CLANG9 tool chain

2019-09-27 Thread Liming Gao
1. Apply CLANG9 Linker option. 2. Add -mno-mmx -mno-sse compiler option Signed-off-by: Liming Gao --- OvmfPkg/OvmfPkgIa32.dsc| 4 +++- OvmfPkg/OvmfPkgIa32X64.dsc | 4 +++- OvmfPkg/OvmfPkgX64.dsc | 4 +++- 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/OvmfPkg/OvmfPkgIa32

[edk2-devel] [Patch 00/12] New Cross OS tool chain CLANG9

2019-09-27 Thread Liming Gao
Cc: Michael D Kinney Liming Gao (12): BaseTools tools_def.template: Remove unnecessary $(DEST_DIR_DEBUG) path BaseTools tools_def: Add CLANG9 tool chain to directly generate PE image BaseTools GenFw: Fix the issue to update the wrong size as SectionSize MdePkg Base.h: Add

[edk2-devel] [Patch 02/12] BaseTools tools_def: Add CLANG9 tool chain to directly generate PE image

2019-09-27 Thread Liming Gao
Signed-off-by: Liming Gao --- BaseTools/Conf/build_rule.template | 26 +-- BaseTools/Conf/tools_def.template | 102 + 2 files changed, 118 insertions(+), 10 deletions(-) diff --git a/BaseTools/Conf/build_rule.template b

[edk2-devel] [Patch 10/12] EmulatorPkg: Enable CLANG9 tool chain

2019-09-27 Thread Liming Gao
1. Append CLANG CC and LINK flags to generate windows HOST. 2. Modify WinHost to move PCD getting in the late position Signed-off-by: Liming Gao --- EmulatorPkg/Win/Host/WinHost.c | 11 +++ EmulatorPkg/EmulatorPkg.dsc | 8 ++-- EmulatorPkg/EmulatorPkg.fdf | 2

[edk2-devel] [Patch 03/12] BaseTools GenFw: Fix the issue to update the wrong size as SectionSize

2019-09-27 Thread Liming Gao
Signed-off-by: Liming Gao --- BaseTools/Source/C/GenFw/GenFw.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/BaseTools/Source/C/GenFw/GenFw.c b/BaseTools/Source/C/GenFw/GenFw.c index c99782b78e..d8d3360c24 100644 --- a/BaseTools/Source/C/GenFw/GenFw.c +++ b

[edk2-devel] [Patch 08/12] CryptoPkg: Append options to make CLANG9 tool chain pass build

2019-09-27 Thread Liming Gao
Disable warning reported from CLANG9. Signed-off-by: Liming Gao --- CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf| 1 + CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf | 1 + CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf | 1 + CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf

[edk2-devel] [Patch 06/12] MdeModulePkg LzmaCustomDecompressLib: Update macro to be same in CLANG tool

2019-09-27 Thread Liming Gao
Define the same macro in the different OS. It can make CLANG generate the same image in the different host OS. Signed-off-by: Liming Gao --- MdeModulePkg/Library/LzmaCustomDecompressLib/Sdk/C/7zTypes.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MdeModulePkg/Library

[edk2-devel] [Patch 12/12] OvmfPkg SecMain: Add build option "-fno-omit-frame-pointer" for CLANG9 X64

2019-09-27 Thread Liming Gao
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2024 Signed-off-by: Liming Gao --- OvmfPkg/Sec/SecMain.inf | 4 1 file changed, 4 insertions(+) diff --git a/OvmfPkg/Sec/SecMain.inf b/OvmfPkg/Sec/SecMain.inf index 63ba4cb555..cd765cac25 100644 --- a/OvmfPkg/Sec/SecMain.inf +++ b/OvmfPkg

[edk2-devel] [Patch 01/12] BaseTools tools_def.template: Remove unnecessary $(DEST_DIR_DEBUG) path

2019-09-27 Thread Liming Gao
$(DEST_DIR_DEBUG) path is in Include directory. It is not required to be specified again. Signed-off-by: Liming Gao --- BaseTools/Conf/tools_def.template | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/BaseTools/Conf/tools_def.template b/BaseTools

[edk2-devel] [Patch 04/12] MdePkg Base.h: Add definition for CLANG9 tool chain

2019-09-27 Thread Liming Gao
CLANG9 tool chain defines __clang__ macro only, doesn't define __GNUC__ macro. But, it uses some same definitions with GCC. So, update base definition for CLANG9 tool chain. Signed-off-by: Liming Gao --- MdePkg/Include/Base.h | 6 +++--- MdePkg/Include/Ia32/ProcessorBind.h | 4

[edk2-devel] [Patch 07/12] MdeModulePkg RegularExpressionDxe: Disable warning for CLANG9 tool chain

2019-09-27 Thread Liming Gao
Signed-off-by: Liming Gao --- MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf | 3 +++ 1 file changed, 3 insertions(+) diff --git a/MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf b/MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf

[edk2-devel] [Patch 09/12] CryptoPkg IntrinsicLib: Make _fltused always be used

2019-09-27 Thread Liming Gao
With this change, global variable _fltused will not be removed by LTO Signed-off-by: Liming Gao --- CryptoPkg/Library/IntrinsicLib/MemoryIntrinsics.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/CryptoPkg/Library/IntrinsicLib/MemoryIntrinsics.c b/CryptoPkg

[edk2-devel] [Patch 05/12] MdePkg BaseIoLibIntrinsic: Remove __inline__ attribute for IO functions

2019-09-27 Thread Liming Gao
__inline__ attribute will make the functions not be exposed as the library interface. It will cause CLANG9 compiler fail. Signed-off-by: Liming Gao --- MdePkg/Library/BaseIoLibIntrinsic/IoLibGcc.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/MdePkg/Library/BaseIoLibIntrinsic

[edk2-devel] [Patch v2] Maintainers.txt: Move ShellBin maintainers to EDK II Releases section

2019-09-26 Thread Liming Gao
ShellBinPkg is generated for each edk2 stable tag release. Cc: Andrew Fish Cc: Laszlo Ersek Cc: Leif Lindholm Cc: Michael D Kinney Signed-off-by: Liming Gao --- In v2, use real URL for edk2 release Maintainers.txt | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff

Re: [edk2-devel] [PATCH 1/1] BaseTools: use stdint.h for GCC ProcessorBind.h typedefs

2019-09-26 Thread Liming Gao
Reviewed-by: Liming Gao >-Original Message- >From: Leif Lindholm [mailto:leif.lindh...@linaro.org] >Sent: Friday, September 27, 2019 3:28 AM >To: devel@edk2.groups.io >Cc: Ard Biesheuvel ; Feng, Bob C >; Gao, Liming ; Laszlo Ersek > >Subject: [PATCH 1/1] BaseToo

Re: [edk2-devel] Problem with decompression on EDK2

2019-09-26 Thread Liming Gao
Can you share the generated FD image? I can help check whether it is generated correctly with compression. Thanks Liming >-Original Message- >From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >Laszlo Ersek >Sent: Friday, September 27, 2019 3:22 AM >To:

Re: [edk2-devel] [PATCH 2/4] MdeModulePkg/PiSmmCore: Fix typo in function name

2019-09-26 Thread Liming Gao
Reviewed-by: Liming Gao >-Original Message- >From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >Philippe Mathieu-Daudé >Sent: Thursday, September 26, 2019 8:05 PM >To: devel@edk2.groups.io >Cc: Philippe Mathieu-Daude ; Wang, Jian J >; Wu, Hao A ;

Re: [edk2-devel] [PATCH 1/4] MdeModulePkg DxeCore: Fix typo in function name

2019-09-26 Thread Liming Gao
Reviewed-by: Liming Gao >-Original Message- >From: Philippe Mathieu-Daude [mailto:phi...@redhat.com] >Sent: Thursday, September 26, 2019 8:05 PM >To: devel@edk2.groups.io >Cc: Philippe Mathieu-Daude ; Wang, Jian J >; Wu, Hao A ; Bi, Dandan >; Gao, Liming

Re: [edk2-devel] [PATCH] BaseTools:"--exclude" don't apply if parameter ends with separator

2019-09-26 Thread Liming Gao
Reviewed-by: Liming Gao > -Original Message- > From: Fan, ZhijuX > Sent: Thursday, September 19, 2019 3:45 PM > To: devel@edk2.groups.io > Cc: Gao, Liming ; Feng, Bob C > Subject: [PATCH] BaseTools:"--exclude" don't apply if parameter ends with

Re: [edk2-devel] [PATCH] MdeModulePkg/TerminalDxe: Enhance the arrow keys support

2019-09-25 Thread Liming Gao
h to ESC [D. > In application mode, arrow key would send ESC OA through to > ESC OD. > > Cc: Jian J Wang > Cc: Hao A Wu > Cc: Ray Ni > Cc: Liming Gao > Signed-off-by: Zhichao Gao > --- > .../Console/TerminalDxe/TerminalConIn.c | 46 --- > 1

Re: [edk2-devel] [Patch] Maintainers.txt: Move ShellBin maintainers to EDK II Releases section

2019-09-24 Thread Liming Gao
maintainers to EDK II >Releases section > >Hi Liming, > >On 09/24/19 03:19, Liming Gao wrote: >> ShellBinPkg is generated for each edk2 stable tag release. >> >> Cc: Andrew Fish >> Cc: Laszlo Ersek >> Cc: Leif Lindholm >> Cc: Michael

Re: [edk2-devel] [Patch] MdePkg Base.h: Define STATIC_ASSERT macro as empty for EBC arch

2019-09-24 Thread Liming Gao
D >Subject: Re: [edk2-devel] [Patch] MdePkg Base.h: Define STATIC_ASSERT >macro as empty for EBC arch > >On Tue, Sep 24, 2019 at 11:05:19PM +0800, Liming Gao wrote: >> EBC compiler doesn't support C11 static_assert macro. >> So, define STATIC_ASSERT as empty to pass EBC arch buil

Re: [edk2-devel] [Patch] Maintainers.txt: Move ShellBin maintainers to EDK II Releases section

2019-09-24 Thread Liming Gao
day, September 24, 2019 6:41 PM > >> To: devel@edk2.groups.io; Gao, Liming ; Leif > >> Lindholm > >> Cc: Andrew Fish ; Laszlo Ersek ; > >> Kinney, Michael D > >> Subject: Re: [edk2-devel] [Patch] Maintainers.txt: Move ShellBin > >> mai

Re: [edk2-devel] [Patch] Maintainers.txt: Move ShellBin maintainers to EDK II Releases section

2019-09-24 Thread Liming Gao
t; Subject: Re: [edk2-devel] [Patch] Maintainers.txt: Move ShellBin maintainers > to EDK II Releases section > > Hi Liming, > > On 9/24/19 3:19 AM, Liming Gao wrote: > > ShellBinPkg is generated for each edk2 stable tag release. > > > > Cc: Andrew Fish > >

[edk2-devel] [Patch] MdePkg Base.h: Define STATIC_ASSERT macro as empty for EBC arch

2019-09-24 Thread Liming Gao
EBC compiler doesn't support C11 static_assert macro. So, define STATIC_ASSERT as empty to pass EBC arch build. STATIC_ASSERT macro is introduced @204ae9da230ecbf0910c21acac7aa5d5e8cbb8d0 Cc: Michael D Kinney Signed-off-by: Liming Gao --- MdePkg/Include/Base.h | 5 - 1 file changed, 4

Re: [edk2-devel] [RFC] EDK II Continuous Integration Phase 1

2019-09-24 Thread Liming Gao
Mike: > -Original Message- > From: devel@edk2.groups.io On Behalf Of Michael D > Kinney > Sent: Tuesday, September 24, 2019 1:44 AM > To: Sean Brogan ; devel@edk2.groups.io; > r...@edk2.groups.io; Kinney, Michael D > > Cc: Bret Barkelew > Subject: Re: [edk2-devel] [RFC] EDK II

Re: [edk2-devel] [PATCH 0/3] Arm builds on Visual Studio

2019-09-23 Thread Liming Gao
Leif: >-Original Message- >From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Leif >Lindholm >Sent: Friday, September 20, 2019 4:27 AM >To: Laszlo Ersek >Cc: devel@edk2.groups.io; Gao, Liming ; Baptiste >Gerondeau ; ard.biesheu...@linaro.org; >Kinney, Michael D ;

[edk2-devel] [Patch] Maintainers.txt: Move ShellBin maintainers to EDK II Releases section

2019-09-23 Thread Liming Gao
ShellBinPkg is generated for each edk2 stable tag release. Cc: Andrew Fish Cc: Laszlo Ersek Cc: Leif Lindholm Cc: Michael D Kinney Signed-off-by: Liming Gao --- Maintainers.txt | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/Maintainers.txt b

Re: [edk2-devel] [PATCH v3 0/2] *** Add VS2019 Support ***

2019-09-23 Thread Liming Gao
Push 6b80310f34199d1f62e45e40fa902734735091fa..670c903a68f214463f12c0c9619c162a0f342518 You can update BZ 2182 and close it. Thanks Liming >-Original Message- >From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >Cheng, Ching JenX >Sent: Thursday, September 19, 2019

Re: [edk2-devel] [Patch] BaseTools: init DependencyHeaderFileSet for each MakeFile class

2019-09-23 Thread Liming Gao
Reviewed-by: Liming Gao > -Original Message- > From: Feng, Bob C > Sent: Thursday, September 19, 2019 10:57 AM > To: devel@edk2.groups.io > Cc: Gao, Liming ; Shi, Steven ; > Feng, Bob C > Subject: [Patch] BaseTools: init DependencyHeaderFileSet for each MakeF

Re: [edk2-devel] [Patch v1] Maintainers.txt update for ShellPkg

2019-09-20 Thread Liming Gao
I just push @d7bf973e43ad949706f936f61cd6be8e63ce136f > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Gao, > Zhichao > Sent: Friday, September 20, 2019 2:11 PM > To: Ni, Ray ; Carsey, Jaben ; > devel@edk2.groups.io > Cc: Kinney, Michael D ;

Re: [edk2-devel] [PATCH v4] BaseTools/LzmaCompress: Add two switches

2019-09-20 Thread Liming Gao
This version is good. Reviewed-by: Liming Gao > -Original Message- > From: Zhang, Shenglei > Sent: Friday, September 20, 2019 10:29 AM > To: devel@edk2.groups.io > Cc: Zhang, Shenglei ; Feng, Bob C > ; Gao, Liming > Subject: [PATCH v4] BaseTools/LzmaCompress: Add t

[edk2-devel] [Patch] Revert "BaseTools: Improve GetDependencyList function"

2019-09-20 Thread Liming Gao
This reverts commit bc9e4194cf3edaf9524c83098ba3f72008c70190. This change causes the dependent header files are missing in Makefile. It makes the incremental build not work. So, revert this change. Cc: Bob Feng Signed-off-by: Liming Gao --- BaseTools/Source/Python/AutoGen/GenMake.py | 29

Re: [edk2-devel] [Patch 1/3] BaseTools: Improve GetDependencyList function

2019-09-19 Thread Liming Gao
e header file via > re.findall in the whole header file. > > This patch is to pre-process the header file and > to feed the shorter string to re.findall. > > This patch is to improve GetDependencyList() efficiency > > Cc: Liming Gao > Signed-off-by: Bob Feng

Re: [edk2-devel] [PATCH v3] BaseTools/LzmaCompress: Add two switches

2019-09-19 Thread Liming Gao
hes > > From: "Zhang, Shenglei" > > As is requested in the BZ 2077, add two switches to support setting > compression mode and dictionary size. > (https://bugzilla.tianocore.org/show_bug.cgi?id=2077) > > Cc: Bob Feng > Cc: Liming Gao > Signe

Re: [edk2-devel] [PATCH] Edk2: Add Zhichao as the maintainer for shellbin relase

2019-09-19 Thread Liming Gao
aintainers.txt. I will send another patch for this change. Thanks Liming > > Best Regards, > > Leif > > > > 2) If Zhichao is now responsible for this, should Jaben and Ray still > > >be listed? > > > > > I think Jaben and Ray can be removed. >

Re: [edk2-devel] [PATCH 0/3] Arm builds on Visual Studio

2019-09-19 Thread Liming Gao
Leif: For this special case of the single patch to include the changes in cross packages, I include Laszlo, Fish and Mike for the discussion. Thanks Liming > -Original Message- > From: Leif Lindholm [mailto:leif.lindh...@linaro.org] > Sent: Thursday, September 19, 2019 5:45 PM > To:

Re: [edk2-devel] [PATCH] Edk2: Add Zhichao as the maintainer for shellbin relase

2019-09-19 Thread Liming Gao
the quarter stable tag. > 2) If Zhichao is now responsible for this, should Jaben and Ray still >be listed? > I think Jaben and Ray can be removed. Thanks Liming > Best Regards, > > Leif > > On Thu, Sep 19, 2019 at 05:58:16AM +, Gao, Liming wrote: > > Reviewed-by:

Re: [edk2-devel] [PATCH v2 2/2] Add VS2019 Support on ToolSetup Batches

2019-09-19 Thread Liming Gao
fig process >in Setup Batch Files, >Because VS2019 and VS2017 could using same vswhere.exe >to detect the InstallationPath, >So we add the -version as the parameter of vswhere >to get the correct VS2017/VS2019's InstallationPath > >Cc: Amy Chan >Cc: Bob Feng >Cc: Li

Re: [edk2-devel] [Patch] EmulatorPkg/TimerLib: Add missing GetTimeInNanoSecond function

2019-09-19 Thread Liming Gao
l ; Andrew Fish >; Ni, Ray ; Johnson >Subject: Re: [edk2-devel] [Patch] EmulatorPkg/TimerLib: Add missing >GetTimeInNanoSecond function > >On 2019-09-18 01:13:54, Liming Gao wrote: >> From: mjohn4 > >It looks like the author is not set properly. If you run "git log -1

Re: [edk2-devel] [PATCH 0/3] Arm builds on Visual Studio

2019-09-19 Thread Liming Gao
I add my comments. >-Original Message- >From: Baptiste Gerondeau [mailto:baptiste.gerond...@linaro.org] >Sent: Thursday, September 19, 2019 12:05 AM >To: devel@edk2.groups.io >Cc: ard.biesheu...@linaro.org; leif.lindh...@linaro.org; Kinney, Michael D >; Gao, Liming ; Zhang, >Shenglei ;

Re: [edk2-devel] [PATCH] Edk2: Add Zhichao as the maintainer for shellbin relase

2019-09-18 Thread Liming Gao
Reviewed-by: Liming Gao >-Original Message- >From: Gao, Zhichao >Sent: Thursday, September 19, 2019 1:46 PM >To: devel@edk2.groups.io >Cc: Andrew Fish ; Laszlo Ersek ; Leif >Lindholm ; Kinney, Michael D >; Ni, Ray ; Ard Biesheuvel >; Gao, Liming >Subject

Re: [edk2-devel] [PATCH v2] MdePkg:Include: Update SmBios header file

2019-09-18 Thread Liming Gao
er file > >Update SmBios header file to conform with SMBIOS v3.3.0. >The major update is to add definitions of SMBIOS Type 44h record. > >Signed-off-by: Abner Chang > >Cc: Michael D Kinney >Cc: Liming Gao >Cc: Leif Lindholm >Cc: Gilbert Chen >--- > MdeModulePkg/Md

Re: [edk2-devel] [PATCH V3 1/3] MdeModulePkg: Extend the support keyboard type of Terminal console

2019-09-18 Thread Liming Gao
> > >> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2186 >> > >> > A common terminal console software Putty support various types of >> > keyboard type, such as normal mode, Linux mode, Xterm R6, Vt400, >> > VT100+ and SCO. Refer to the l

Re: [edk2-devel] [PATCH 0/9] Various line ending and encoding fixes

2019-09-18 Thread Liming Gao
Reviewed-by: Liming Gao for the changes in BaseTools. >-Original Message- >From: Leif Lindholm [mailto:leif.lindh...@linaro.org] >Sent: Thursday, September 19, 2019 6:43 AM >To: devel@edk2.groups.io >Cc: Alexei Fedorov ; Ard Biesheuvel >; Feng, Bob C ; Wu, >Jiaxin

[edk2-devel] [Patch] EmulatorPkg/TimerLib: Add missing GetTimeInNanoSecond function

2019-09-18 Thread Liming Gao
From: mjohn4 Add GetTimeInNanoSecond, already declared in the TimerLib API, to EmulatorPkg implementations of TimerLib. Cc: Jordan Justen Cc: Andrew Fish Cc: Ray Ni Signed-off-by: Johnson, Michael --- .../Library/DxeCoreTimerLib/DxeCoreTimerLib.c | 45 -

Re: [edk2-devel] [PATCH v2 0/2] *** Add VS2019 Support ***

2019-09-18 Thread Liming Gao
That's good. I have no other comment. Reviewed-by: Liming Gao >-Original Message- >From: Cheng, Ching JenX >Sent: Wednesday, September 18, 2019 9:51 AM >To: Gao, Liming ; devel@edk2.groups.io >Subject: RE: [edk2-devel] [PATCH v2 0/2] *** Add VS2019 Support *

Re: [edk2-devel] [PATCH 17/35] MdePkg/DxeServicesLib: remove bogus cast

2019-09-17 Thread Liming Gao
Reviewed-by: Liming Gao >-Original Message- >From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >Laszlo Ersek >Sent: Wednesday, September 18, 2019 3:49 AM >To: edk2-devel-groups-io >Cc: Gao, Liming ; Kinney, Michael D > >Subject: [edk2-dev

Re: [edk2-devel] [PATCH v2 0/2] *** Add VS2019 Support ***

2019-09-17 Thread Liming Gao
Ching: The change is good. With this change, have you verified VS2017 tool chain? I want to make sure there is no impact on VS2017. Thanks Liming > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Cheng, > Ching JenX > Sent: Tuesday,

Re: [edk2-devel] [PATCH] MdePkg:Include: Update SmBios header file

2019-09-17 Thread Liming Gao
he > specification gets released we can take it into edk2. > > (After code review, a couple of minor comments below.) > > > The major update is to add definitions of SMBIOS Type 44h record. > > > > Signed-off-by: Abner Chang > > > > Cc: Michael D Kinne

Re: [edk2-devel] [PATCH V2 0/3] MdeModulePkg/TerminalConsole: Extend the support terminal types

2019-09-17 Thread Liming Gao
Leif: > -Original Message- > From: Leif Lindholm [mailto:leif.lindh...@linaro.org] > Sent: Tuesday, September 17, 2019 5:15 PM > To: devel@edk2.groups.io; Zhang, Shenglei > Cc: ard.biesheu...@linaro.org; Wang, Jian J ; Wu, Hao > A ; Ni, Ray ; > Laszlo Erse

  1   2   3   4   5   6   7   >