[edk2-devel] UEFI spec version in system table, shall we update it to 2.8?

2021-03-30 Thread Lin, Derek (HPS SW)
Hi, In UefiSpec.h, we define the UEFI version 2.7 in system table. #define EFI_2_70_SYSTEM_TABLE_REVISION (( 2 << 16 ) | ( 70 )) #define EFI_SYSTEM_TABLE_REVISION EFI_2_70_SYSTEM_TABLE_REVISION #define EFI_SPECIFICATION_VERSION EFI_SYSTEM_TABLE_REVISION #define EFI_RUNTIME_SERVICES_REVISION

Re: [edk2-devel] Conditionally Include FDF File

2020-04-20 Thread Lin, Derek (HPS SW)
I saw this issue too. The included file is always included no matter the condition is TRUE or FALSE. ``` !if FALSE !include abc.fdf !endif ``` -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#57597):

Re: [edk2-devel] Basetools fail without error message due to PCD type differs in architecture.

2020-04-07 Thread Lin, Derek (HPS SW)
or finding. Did you check the PCD build report when debugging? - Bret From: Lin, Derek (HPS SW) via groups.io<mailto:derek.lin2=hpe@groups.io> Sent: Sunday, April 5, 2020 7:55 PM To: devel@edk2.groups.io<mailto:devel@edk2.groups.io> Subject: [EXTERNAL] [edk2-devel] Basetools fail

[edk2-devel] Basetools fail without error message due to PCD type differs in architecture.

2020-04-05 Thread Lin, Derek (HPS SW)
We've found a Basetool issue. When a PCD is FixAtBuild at IA32 and Dynamic is at X64, there is no error message in this situation and it's very difficult to find the root cause. Here's example to see the issue: https://github.com/howdou/edk2/commit/333c5f33adc652308355ec100f7f385d552392fa I

[edk2-devel] [PATCH] EmulatorPkg: TimerLib QueryPerformance functions

2020-01-29 Thread Lin, Derek (HPS SW)
Implement QueryPerformanceCounter() and QueryPerformanceFrequency() for both Unix and Windows. This has been tested in both Unix and Windows in an application using TimerLib. Signed-off-by: Derek Lin Signed-off-by: Kitty Chen --- EmulatorPkg/Unix/Host/EmuThunk.c | 40

[edk2-devel] [PATCH] EmulatorPkg: Implement QueryPerformanceCounter()

2019-12-17 Thread Lin, Derek (HPS SW)
Implement QueryPerformanceCounter() for Emulator on both Unix and Windows. Signed-off-by: Derek Lin Signed-off-by: Kitty Chen --- EmulatorPkg/Unix/Host/EmuThunk.c | 6 -- EmulatorPkg/Win/Host/WinThunk.c | 7 ++- 2 files changed, 10 insertions(+), 3 deletions(-) diff --git

[edk2-devel] [PATCH] SecurityPkg: Fix TPM2 ACPI measurement.

2019-11-05 Thread Lin, Derek (HPS SW)
We have discussed in this thread. https://edk2.groups.io/g/devel/topic/32205028 Before the change, TPM FW upgrade will impact TPM2 ACPI PCR value because TPM2 ACPI HID include FW version. This change make the measurement before TPM2 HID fixup. So, after TPM FW upgrade, the ACPI PCR record

Re: [edk2-devel] [PATCH] BaseTools: Fix an incremental build issue caused by macro in #include

2019-10-16 Thread Lin, Derek (HPS SW)
Hi Phillippe, Yeah, I forgot to fill my example. Thanks for the catch. It is exactly as Bob mentioned, #include MACRO(xxx.h). There are silicon code use macro to separate definitions, and use the approach to reuse code. Like: #define PATH(x) // in platform 1 #define PATH(x) // in platform 2

[edk2-devel] [PATCH] BaseTools: Fix an incremental build issue caused by macro in #include

2019-10-16 Thread Lin, Derek (HPS SW)
When c/h file use macro after #include, for example, In this case, GenMake is not able to create a healthy dependency for the c file. GenMake used to add $(FORCE_REBUILD) dependency in the c file, this guarantee the c file is always compiled in incremental build. But, this function is broken since

Re: [edk2-devel] BaseTools --hash malfunction after migrate from stable201905 to stable201908

2019-09-27 Thread Lin, Derek (HPS SW)
Hi Steven, Thanks for the fix! I've tried your patch with a minor fix as attached. 1            2           3                4 Build Duration:        00:05:51  00:03:47  00:05:15  00:04:31 AutoGen Duration:  00:03:32  00:03:08  00:03:14  00:03:16 Make Duration:       00:01:50  00:00:16  00:01:29 

[edk2-devel] BaseTools --hash malfunction after migrate from stable201905 to stable201908

2019-09-20 Thread Lin, Derek (HPS SW)
Hi BaseTools experts, We saw the clean build performance improvement after updating from edk2-stable201905 to edk2-stable201908, which is promising. But we found the incremental build time increase 25%~35%, which is not good. We're building server platform. And we use --hash to speed up

Re: [edk2-devel] [PATCH] SecurityPkg: Don't Verify the enrolled PK in setup mode

2019-08-22 Thread Lin, Derek (HPS SW)
Hi Laszlo, Chao, Sorry for late response in this thread. I review Mantis#1983 and this discussion again. I agree with Laszlo. 1. UEFI spec 2.8 is not very clear about PK validation in Setup mode. 2. This patch only reduce the complexity of update PK process. Having a FeaturePCD to control this

[edk2-devel] Capsule PCI device firmware update, could capsule embedded driver override PCI option ROM driver?

2019-08-08 Thread Lin, Derek (HPS SW)
Hi, I have searched EDK2 devel discussion and Mantis but I couldn't find answer. Recently we found some PCI card vendor release capsule to update device firmware. Background: The PCI card has option ROM which provide FMP service. The capsule has a firmware payload and device driver which also

Re: [edk2-devel] [PATCH] SecurityPkg: Don't Verify the enrolled PK in setup mode

2019-07-04 Thread Lin, Derek (HPS SW)
Add SecurityPkg maintainers. Thanks, Derek From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of derek.l...@hpe.com Sent: Tuesday, July 2, 2019 1:25 PM To: devel@edk2.groups.io Subject: [edk2-devel] [PATCH] SecurityPkg: Don't Verify the enrolled PK in setup mode Patch is