[edk2-devel] [staging/edk2-ci]: Create branch to test EDK II CI concepts

2019-10-08 Thread Michael D Kinney
Hello, I am creating the edk2-ci branch in the edk2-staging repo to test out some of the concepts from the RFCs to add CI to the edk2 repo. https://edk2.groups.io/g/rfc/message/93 https://edk2.groups.io/g/rfc/message/96 Best regards, Mike -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive

Re: [edk2-devel] [PATCH 18/35] NetworkPkg/DxeNetLib: fix type typo in NetLibGetMacAddress()

2019-10-07 Thread Michael D Kinney
Laszlo, Reviewed-by: Michael D Kinney Mike > -Original Message- > From: devel@edk2.groups.io On > Behalf Of Laszlo Ersek > Sent: Tuesday, September 17, 2019 12:49 PM > To: edk2-devel-groups-io > Cc: Wu, Jiaxin ; Fu, Siyuan > > Subject: [edk2-devel] [P

Re: [edk2-devel] [PATCH v2 3/7] BaseTools: strip trailing whitespace

2019-10-04 Thread Michael D Kinney
y, > Michael D wrote: > > Leif, > > > > Reviewed-by: Michael D Kinney > > > > > I am covering for Liming and Bob this week, so you do > not have to wait > > for a review from them to push these changes. > > > > Mike > > > > > --

Re: [edk2-devel] [PATCH V2 7/9] MdeModulePkg/Variable: Add RT GetVariable() cache support

2019-10-03 Thread Michael D Kinney
- Maintained in > VariableSmmRuntimeDxe. Used to > > > service > > >Runtime Services GetVariable () and > GetNextVariableName () callers. > > > 2. "SMM Cache" - Maintained in VariableSmm to > service SMM GetVariable > > () > &

Re: [edk2-devel] [PATCH V1 1/1] BaseTools: Fix GenMake multi-workspace failure

2019-10-03 Thread Michael D Kinney
Hi Michael, Reviewed-by: Michael D Kinney This look really important. Do you want me to push today? Mike > -Original Message- > From: devel@edk2.groups.io On > Behalf Of Kubacki, Michael A > Sent: Tuesday, October 1, 2019 3:58 PM > To: devel@edk2.groups.io > Cc:

Re: [edk2-devel] [PATCH v2 3/7] BaseTools: strip trailing whitespace

2019-10-03 Thread Michael D Kinney
Leif, Reviewed-by: Michael D Kinney I am covering for Liming and Bob this week, so you do not have to wait for a review from them to push these changes. Mike > -Original Message- > From: devel@edk2.groups.io On > Behalf Of Leif Lindholm > Sent: Tuesday, October 1,

Re: [edk2-devel] [edk2-platforms] Remove ClevoOpenBoardPkg from Bugzilla

2019-10-02 Thread Michael D Kinney
Hi Michael, I have made ClevoOpenBoardPkg inactive. It is not longer an option when adding a new bug. Mike From: Kubacki, Michael A Sent: Tuesday, October 1, 2019 3:29 PM To: 'devel@edk2.groups.io' Cc: Kinney, Michael D ; Sinha, Ankit ; Desimone, Nathaniel L Subject: [edk2-platforms]

Re: [edk2-devel] Recent changes to EsrtFmp causing ASSERTs

2019-10-02 Thread Michael D Kinney
Jason, The only time the HardwareInstance is optional (and set to 0) is if the system can guarantee that there is at most one instance of the device in the system. This can only be guaranteed for an integrated device. Any devices that an end user can add/remove from the system through slots

Re: [edk2-devel] Recent changes to EsrtFmp causing ASSERTs

2019-10-01 Thread Michael D Kinney
Hi Jason, I believe the logic to check for uniqueness of FMP Descriptor is correct. The UEFI Spec has 2 structs with HardwareInstance. One is FMP Descriptor and the other is UEFI Capsule for FMP. The HardwareInstance in FMP must be unique and not 0 unless there is a guarantee there is only

Re: [edk2-devel] [edk2-platforms] Update Packages on Bugzilla

2019-09-26 Thread Michael D Kinney
Michael, Thank you for the reminder. I have added the 3 new components. Mike From: Kubacki, Michael A Sent: Monday, September 23, 2019 7:30 PM To: 'devel@edk2.groups.io' ; Kinney, Michael D Cc: Wei, David Y ; Agyeman, Prince Subject: RE: [edk2-platforms] Update Packages on Bugzilla Mike,

Re: [edk2-devel] [Patch] MdePkg Base.h: Define STATIC_ASSERT macro as empty for EBC arch

2019-09-24 Thread Michael D Kinney
Reviewed-by: Michael D Kinney > -Original Message- > From: Gao, Liming > Sent: Tuesday, September 24, 2019 5:38 PM > To: Leif Lindholm ; > devel@edk2.groups.io > Cc: Kinney, Michael D > Subject: RE: [edk2-devel] [Patch] MdePkg Base.h: Define > STATIC_ASSERT mac

Re: [edk2-devel] [RFC] EDK II Continuous Integration Phase 1

2019-09-23 Thread Michael D Kinney
based unit > tests can be > > compiled against individual modules and libraries and > run on the build > > agent (in this case, the Dev Ops build server). The > successful and > > failing test case results are collected and included > in the final > > build repor

Re: [edk2-devel] [RFC] EDK II Continuous Integration Phase 1

2019-09-19 Thread Michael D Kinney
a package to make sure > that there are no invalid Unicode characters that may > cause build errors in some character > sets/localizations. > > ## Next Steps > > * Receive community feedback on RFC. > * Determine where this phase makes sense given existing > RFCs from other Tia

Re: [edk2-devel] [RFC] EDK II Continuous Integration Phase 1

2019-09-19 Thread Michael D Kinney
ors in some character > sets/localizations. > > ## Next Steps > > * Receive community feedback on RFC. > * Determine where this phase makes sense given existing > RFCs from other TianoCore contributors. > * Optimize testing beharior. > * Only run a subset of tests on

Re: [edk2-rfc] [edk2-devel] [RFC] EDK II Continuous Integration Phase 1

2019-09-19 Thread Michael D Kinney
Sean, There may be many ways to improve the process and reduce the work maintainers perform. So these are ideas we can explore further going forward. I will add the concept of a non-maintainer opening the PR to the Wiki. In order to get the improvements to code quality from CI enabled as

Re: [edk2-devel] [RFC] EDK II Continuous Integration Phase 1

2019-09-19 Thread Michael D Kinney
comments. > > >-Original Message- > >From: r...@edk2.groups.io [mailto:r...@edk2.groups.io] > On Behalf Of > >Michael D Kinney > >Sent: Friday, August 30, 2019 4:23 AM > >To: devel@edk2.groups.io; r...@edk2.groups.io > >Subjec

[edk2-devel] [edk2-platforms Patch 2/2] Marvel: Convert UNI files from UTF-16 to UTF-8

2019-09-18 Thread Michael D Kinney
https://bugzilla.tianocore.org/show_bug.cgi?id=2199 Cc: Ard Biesheuvel Cc: Leif Lindholm Signed-off-by: Michael D Kinney --- .../Applications/EepromCmd/EepromCmd.uni | Bin 3558 -> 1778 bytes .../Applications/FirmwareUpdate/FUpdate.uni | Bin 3500 -> 1749 bytes .../Applications/S

[edk2-devel] [edk2-platforms Patch 0/2] Convert UNI files from UTF-16 to UTF-8

2019-09-18 Thread Michael D Kinney
will show the changes as text files. Cc: Ard Biesheuvel Cc: Leif Lindholm Signed-off-by: Michael D Kinney Michael D Kinney (2): Hisilicon: Convert UNI files from UTF-16 to UTF-8 Marvel: Convert UNI files from UTF-16 to UTF-8 .../BoardFeature2PHi1610Strings.uni | Bin 3538

[edk2-devel] [edk2-platforms Patch 1/2] Hisilicon: Convert UNI files from UTF-16 to UTF-8

2019-09-18 Thread Michael D Kinney
https://bugzilla.tianocore.org/show_bug.cgi?id=2199 Cc: Ard Biesheuvel Cc: Leif Lindholm Signed-off-by: Michael D Kinney --- .../BoardFeature2PHi1610Strings.uni | Bin 3538 -> 1780 bytes .../Type09/MiscSystemSlotDesignation.uni | Bin 826 -> 412 bytes 2 files chan

Re: [edk2-devel] [PATCH 7/9] ArmPkg: ArmScmiDxe - convert .h to UTF-8 from 8859-x

2019-09-18 Thread Michael D Kinney
Leif, We prefer ASCII only in source files. I have deleted or changed to an appropriate ASCII character when I have seen these types of special symbols. Mike > -Original Message- > From: devel@edk2.groups.io On > Behalf Of Leif Lindholm > Sent: Wednesday, September 18, 2019 3:43 PM >

Re: [edk2-devel] [PATCH 9/9] EmbeddedPkg: convert Lauterbach README.txt to UTF-8

2019-09-18 Thread Michael D Kinney
Leif, Since this is a readme file, perhaps those should be changed to `text` markdown style in an ASCII text file and rename the file to README.md so it is rendered correctly from the GitHub web view. Mike > -Original Message- > From: devel@edk2.groups.io On > Behalf Of Leif Lindholm >

Re: [edk2-devel] [PATCH 01/35] DO NOT APPLY: edk2: turn standard handle types into pointers to non-VOID

2019-09-18 Thread Michael D Kinney
> -Original Message- > From: Laszlo Ersek > Sent: Wednesday, September 18, 2019 1:42 AM > To: Andrew Fish ; Ni, Ray > > Cc: devel@edk2.groups.io; Achin Gupta > ; Anthony Perard > ; Ard Biesheuvel > ; You, Benjamin > ; Zhang, Chao B > ; Bi, Dandan > ; David Woodhouse > ; Dong, Eric > ;

Re: [edk2-devel] [PATCH 01/35] DO NOT APPLY: edk2: turn standard handle types into pointers to non-VOID

2019-09-17 Thread Michael D Kinney
gt;>> > >>>> replacing the spec mandated > >>>> > >>>> typedef VOID *EFI_FOOBAR_HANDLE; > >>>> > >>>> (For some types, such as: > >>>> > >>>> - EFI_ACPI_HANDLE, > >>>> - EFI_EV

Re: [edk2-devel] [PATCH edk2-CCSS 0/3] Coding Standards: add rule for documenting spurious variable assignments

2019-09-17 Thread Michael D Kinney
Series Reviewed-by: Michael D Kinney I also agree that the macros would be cleaner, easy to review, and and fewer lines of code without the comment block. If I objected previously, then I have also changed my mind. I agree we can go ahead and push the series in its current form and continue

Re: [edk2-devel] [RFC] EDK II Continuous Integration Phase 1

2019-08-29 Thread Michael D Kinney
y that they pass at each point > in the git history? > > Thanks > Michael > > On Thu, Aug 29, 2019 at 10:22 PM Michael D Kinney > wrote: > > > > Hello, > > > > This is a proposal for a first step towards > continuous integration for > > all Tian

[edk2-devel] [RFC] EDK II Continuous Integration Phase 1

2019-08-29 Thread Michael D Kinney
Hello, This is a proposal for a first step towards continuous integration for all TianoCore repositories to help improve to quality of commits and automate testing and release processes for all EDK II packages and platforms. This is based on work from a number of EDK II community members that

Re: [edk2-devel] [Patch][edk2-stable201908] BaseTools: Fixed regression issue for building !x86 builds

2019-08-28 Thread Michael D Kinney
Hi Bob, I agree this is a critical regression issue that must be fixed for the edk2-stable201908 release. Tested-by: Michael D Kinney Acked-by: Michael D Kinney Thanks, Mike > -Original Message- > From: Gao, Liming > Sent: Wednesday, August 28, 2019 8:22 AM > To: L

Re: [edk2-devel] [Patch][edk2-stable201908] BaseTools: fix an incremental build issue.

2019-08-28 Thread Michael D Kinney
Liming, I can no longer reproduce the issues I noted below. I agree this is a critical regression issue that must be fixed for the edk2-stable201908 release. Tested-by: Michael D Kinney Acked-by: Michael D Kinney Thanks, Mike > -Original Message- > From: Kinney, Michael D

Re: [edk2-devel] [Patch][edk2-stable201908] BaseTools: fix an incremental build issue.

2019-08-28 Thread Michael D Kinney
Liming, I set up a fresh environment and I now see the expected behavior when modifying INF files with this patch applied. I can not reproduce the issues I saw earlier today. I will continue to do some more testing before I provide a Tested-by. Mike -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links:

Re: [edk2-devel] [Patch][edk2-stable201908] BaseTools: fix an incremental build issue.

2019-08-28 Thread Michael D Kinney
Liming, This fix does not look complete to me. I applied this patch and used FatPkg as a test. I modified FatPkg/EnhancedFatDxe/Fat.inf removing Defines, Source files, Library Classes, GUID, Protocols, and PCDs and it never rebuilds the module. If I remove the BASE_NAME define, I get a stack

Re: [edk2-devel] [Patch][edk2-stable201908] BaseTools: fix an incremental build issue.

2019-08-28 Thread Michael D Kinney
Bob and Liming, What is an example test case that fails? Please add to BZ. We need this information to test that this fix resolves the issue. Mike > -Original Message- > From: Gao, Liming > Sent: Wednesday, August 28, 2019 8:26 AM > To: Feng, Bob C ; > devel@edk2.groups.io > Cc: Shi,

Re: [edk2-devel] [PATCH 1/1] MdeModulePkg: fix !x86 builds (more)

2019-08-27 Thread Michael D Kinney
Hao Wu, Please provide a patch to BaseTools to restore the previous behavior. We need that to review the complexity of the change to determine what to do. Without that information today, the release date of this stable tag is at risk. Mike > -Original Message- > From: Wu, Hao A >

Re: [edk2-devel] [PATCH 1/1] MdeModulePkg: fix !x86 builds (more)

2019-08-27 Thread Michael D Kinney
Leif, Looking at the DSC Spec in looks like the priority change from Aug 9 was to invert the priority 4 and priority 5 items: 1. associated with the INF file in the [Components] section 2. [LibraryClasses.$(Arch).$(MODULE_TYPE), LibraryClasses.$(Arch).$(MODULE_TYPE)] 3.

Re: [edk2-devel] [PATCH 1/1] MdeModulePkg: fix !x86 builds (more)

2019-08-27 Thread Michael D Kinney
Laszlo, Thanks for the analysis of the DSC Specification. It appears a behavior change was introduced with the following commit. https://github.com/tianocore/edk2/commit/e8449e1d8e3b40186eb16ff25242397cffb00a63 The new code follows the DSC Specification, but changes the library selection

Re: [edk2-devel] [PATCH] [edk2-stable201908] MdePkg/BluetoothLeConfig.h: Add type EfiBluetoothSmpPeerAddressList

2019-08-26 Thread Michael D Kinney
hSmpPeerAddressList > >> > >> To support auto-connection, > EFI_BLUETOOTH_LE_SMP_DATA_TYPE needs > >to > >> add a new data type EfiBluetoothSmpPeerAddressList > which associates > >> with a list of Bluetooth per address connected > before. > >&

Re: [edk2-devel] git submodule update --init --recursive

2019-08-26 Thread Michael D Kinney
Andrew, I agree the documentation for this should be in the same section as the clone requirements. This operation is not always required. Right now, if a platform does not use OpenSSL in CryptoPkg, then the submodule operation can be skipped. The documentation should let the developer know

Re: [edk2-devel] [Patch][edk2-stable201908 0/2] EmulatorPkg/Win/Host: Fix image unload regression

2019-08-26 Thread Michael D Kinney
26, 2019 12:32 PM > > To: Kinney, Michael D ; > > devel@edk2.groups.io > > Cc: Justen, Jordan L ; Ni, > Ray > > ; 'Andrew Fish' > > Subject: Re: [edk2-devel] [Patch][edk2-stable201908 > 0/2] > > EmulatorPkg/Win/Host: Fix image unload regression &g

Re: [edk2-rfc] [edk2-devel] CPU hotplug using SMM with QEMU+OVMF

2019-08-23 Thread Michael D Kinney
Hi Jiewen, If a hot add CPU needs to run any code before the first SMI, I would recommend is only executes code from a write protected FLASH range without a stack and then wait for the first SMI. For this OVMF use case, is any CPU init required before the first SMI? From Paolo's list of steps

Re: [edk2-rfc] [edk2-devel] CPU hotplug using SMM with QEMU+OVMF

2019-08-22 Thread Michael D Kinney
Paolo, I find the following links related to the discussions here along with one example feature called GENPROTRANGE. https://csrc.nist.gov/CSRC/media/Presentations/The-Whole-is-Greater/images-media/day1_trusted-computing_200-250.pdf

Re: [edk2-devel] Upcoming Event: TianoCore Bug Triage - APAC / NAMO - Thu, 08/22/2019 5:00pm-5:30pm #cal-reminder

2019-08-22 Thread Michael D Kinney
The zoom meeting started late, so please try to rejoin if you could not get in a few minutes ago. Mike From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] Sent: Thursday, August 22, 2019 4:45 PM To: devel@edk2.groups.io Subject: [edk2-devel] Upcoming Event: TianoCore Bug Triage - APAC /

Re: [edk2-rfc] [edk2-devel] CPU hotplug using SMM with QEMU+OVMF

2019-08-22 Thread Michael D Kinney
Paolo, It is my understanding that real HW hot plug uses the SDM defined methods. Meaning the initial SMI is to 3000:8000 and they rebase to TSEG in the first SMI. They must have chipset specific methods to protect 3000:8000 from DMA. Can we add a chipset feature to prevent DMA to 64KB range

Re: [edk2-rfc] [edk2-devel] CPU hotplug using SMM with QEMU+OVMF

2019-08-22 Thread Michael D Kinney
Laszlo, I believe all the code for the AP startup vector is already in edk2. It is a combination of the reset vector code in UefiCpuPkg/ResetVecor/Vtf0 and an IA32/X64 specific feature in the GenFv tool. It sets up a 4KB aligned location near 4GB which can be used to start an AP using

Re: [edk2-rfc] [edk2-devel] CPU hotplug using SMM with QEMU+OVMF

2019-08-22 Thread Michael D Kinney
Paolo, The SMBASE register is internal and cannot be directly accessed by any CPU. There is an SMBASE field that is member of the SMM Save State area and can only be modified from SMM and requires the execution of an RSM instruction from SMM for the SMBASE register to be updated from the

[edk2-devel] [Patch][edk2-stable201908 2/2] EmulatorPkg/Win/Host: Fix SecPrint() log line endings

2019-08-21 Thread Michael D Kinney
Update use of SecPrint() to consistently use \n\r for line endings to fix formatting issues in the debug log. Cc: Jordan Justen Cc: Ray Ni Cc: Andrew Fish Cc: Tim Lewis Signed-off-by: Michael D Kinney --- EmulatorPkg/Win/Host/WinHost.c | 26 +- 1 file changed, 13

[edk2-devel] [Patch][edk2-stable201908 0/2] EmulatorPkg/Win/Host: Fix image unload regression

2019-08-21 Thread Michael D Kinney
that supported unloading applications and drivers as well as loading the same application or driver multiple times. Cc: Jordan Justen Cc: Ray Ni Cc: Andrew Fish Cc: Tim Lewis Signed-off-by: Michael D Kinney Michael D Kinney (2): EmulatorPkg/Win/Host: Fix image unload regression EmulatorPkg/Win

[edk2-devel] [Patch][edk2-stable201908 1/2] EmulatorPkg/Win/Host: Fix image unload regression

2019-08-21 Thread Michael D Kinney
that supported unloading applications and drivers as well as loading the same application or driver multiple times. Cc: Jordan Justen Cc: Ray Ni Cc: Andrew Fish Cc: Tim Lewis Signed-off-by: Michael D Kinney --- EmulatorPkg/Win/Host/WinHost.c | 167 +++-- 1 file changed

Re: [edk2-devel] EmulatorPkg does not unload DLL after exit

2019-08-21 Thread Michael D Kinney
@edk2.groups.io; Kinney, Michael D ; af...@apple.com Subject: RE: [edk2-devel] EmulatorPkg does not unload DLL after exit Mike – Ok, it is bug 2104. From: devel@edk2.groups.io<mailto:devel@edk2.groups.io> mailto:devel@edk2.groups.io>> On Behalf Of Michael D Kinney Sent: Wednesda

Re: [edk2-devel] EmulatorPkg does not unload DLL after exit

2019-08-21 Thread Michael D Kinney
Tim, Thanks for the analysis. Looks like we need to fix PeCoffLoaderUnloadImageExtraAction() for winhost to unload the DLL to keep compatibility with Nt32. This is important for both apps and unloadable drivers. Please enter a BZ. This looks like a critical enough regression bug that we may

Re: [edk2-rfc] [edk2-devel] CPU hotplug using SMM with QEMU+OVMF

2019-08-21 Thread Michael D Kinney
Paolo, It makes sense to match real HW. That puts us back to the reset vector and handling the initial SMI at 3000:8000. That is all workable from a FW implementation perspective. It look like the only issue left is DMA. DMA protection of memory ranges is a chipset feature. For the current

Re: [edk2-rfc] [edk2-devel] CPU hotplug using SMM with QEMU+OVMF

2019-08-21 Thread Michael D Kinney
Could we have an initial SMBASE that is within TSEG. If we bring in hot plug CPUs one at a time, then initial SMBASE in TSEG can reprogram the SMBASE to the correct value for that CPU. Can we add a register to the hot plug controller that allows the BSP to set the initial SMBASE value for a

Re: [edk2-rfc] [edk2-devel] CPU hotplug using SMM with QEMU+OVMF

2019-08-21 Thread Michael D Kinney
Perhaps there is a way to avoid the 3000:8000 startup vector. If a CPU is added after a cold reset, it is already in a different state because one of the active CPUs needs to release it by interacting with the hot plug controller. Can the SMRR for CPUs in that state be pre-programmed to match

Re: [edk2-devel] Patch List for 201908 stable tag

2019-08-19 Thread Michael D Kinney
Ray, With your review, my vote is yes. Mike From: Ni, Ray Sent: Monday, August 19, 2019 4:06 PM To: devel@edk2.groups.io; Gao, Liming ; Laszlo Ersek (ler...@redhat.com) ; leif.lindh...@linaro.org; Kinney, Michael D ; af...@apple.com; Cetola, Stephano Subject: RE: [edk2-devel] Patch List for

Re: [edk2-devel] Patch List for 201908 stable tag

2019-08-19 Thread Michael D Kinney
> -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Friday, August 16, 2019 11:38 AM > To: Gao, Liming ; > leif.lindh...@linaro.org; Kinney, Michael D > ; af...@apple.com; Cetola, > Stephano > Cc: devel@edk2.groups.io; Shi, Steven > ; Kuo, Donald > ; Vitaly

Re: [edk2-devel] [edk2-platforms] Update Intel Packages on Bugzilla

2019-08-19 Thread Michael D Kinney
Done. Mike > -Original Message- > From: Kinney, Michael D > Sent: Monday, August 19, 2019 3:39 PM > To: Kubacki, Michael A ; > devel@edk2.groups.io; Kinney, Michael D > > Cc: Dong, Eric ; Gao, Liming > ; Bi, Dandan ; > Chiu, Chasel ; Desimone, Nathaniel > L ; Chaganty, Rangasai V > ;

Re: [edk2-devel] [edk2-platforms] Update Intel Packages on Bugzilla

2019-08-19 Thread Michael D Kinney
Michael, I agree. I will add these packages that have already been approved and added to edk2-platforms/master. Mike > -Original Message- > From: Kubacki, Michael A > Sent: Monday, August 19, 2019 2:57 PM > To: devel@edk2.groups.io > Cc: Kinney, Michael D ; > Dong, Eric ; Gao, Liming

Re: [edk2-devel] [Patch V5 00/11] EmulatorPkg: Fix VS20xx IA32 boot and simplify build config

2019-08-19 Thread Michael D Kinney
August 18, 2019 7:43 PM > To: Kinney, Michael D ; > devel@edk2.groups.io > Cc: Andrew Fish ; Ni, Ray > > Subject: Re: [Patch V5 00/11] EmulatorPkg: Fix VS20xx > IA32 boot and simplify build config > > On 2019-08-16 17:57:04, Michael D Kinney wrote: > > > >

Re: [edk2-devel] Patch List for 201908 stable tag

2019-08-16 Thread Michael D Kinney
Liming, I would like to include the following bug fixes to EmulatorPkg in the stable tag: https://edk2.groups.io/g/devel/message/45953 [edk2-devel] [Patch V5 00/11] EmulatorPkg: Fix VS20xx IA32 boot and simplify build config The first set of patches were sent for review on 8/1. Most of the

[edk2-devel] [Patch V5 11/11] BaseTools/tools_def.template: Add -gdwarf to XCODE5 X64

2019-08-16 Thread Michael D Kinney
From: Andrew Fish Add -gdwarf to XCODE5 X64 builds to generate symbols for source level debug using lldb. Cc: Jordan Justen Cc: Ray Ni Cc: Michael D Kinney Signed-off-by: Andrew Fish Reviewed-by: Michael D Kinney Tested-by: Andrew Fish --- BaseTools/Conf/tools_def.template | 4 ++-- 1

[edk2-devel] [Patch V5 05/11] EmulatorPkg/Unix/Host: Disable inline/optimizations

2019-08-16 Thread Michael D Kinney
Justen Cc: Andrew Fish Cc: Ray Ni Signed-off-by: Michael D Kinney Reviewed-by: Michael D Kinney Tested-by: Andrew Fish --- EmulatorPkg/Unix/Host/Host.c | 3 +++ EmulatorPkg/Unix/Host/Host.inf | 4 ++-- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/EmulatorPkg/Unix/Host/Host.c

[edk2-devel] [Patch V5 09/11] EmulatorPkg: Disable TftpDynamicCommand and LogoDxe for XCODE5

2019-08-16 Thread Michael D Kinney
bitmap in a PE/COFF resource section that is not supported by the XCODE5 tool chain, and the missing HII content causes the load of this module to ASSERT(). Cc: Jordan Justen Cc: Ray Ni Cc: Michael D Kinney Signed-off-by: Andrew Fish Reviewed-by: Michael D Kinney Tested-by: Andrew Fish

[edk2-devel] [Patch V5 07/11] EmulatorPkg/Unix/Host: Initialize field in BerkeleyPacketFilter.c

2019-08-16 Thread Michael D Kinney
From: Andrew Fish Initialize Private->ReadBuffer to NULL. Cc: Jordan Justen Cc: Ray Ni Cc: Michael D Kinney Signed-off-by: Andrew Fish Reviewed-by: Michael D Kinney Tested-by: Andrew Fish --- EmulatorPkg/Unix/Host/BerkeleyPacketFilter.c | 1 + 1 file changed, 1 insertion(+) diff --

[edk2-devel] [Patch V5 03/11] EmulatorPkg: Add -D DISABLE_NEW_DEPRECATED_INTERFACES

2019-08-16 Thread Michael D Kinney
Cc: Andrew Fish Cc: Ray Ni Signed-off-by: Michael D Kinney Reviewed-by: Hao A Wu Acked-by: Jordan Justen Tested-by: Andrew Fish --- EmulatorPkg/EmuBusDriverDxe/EmuBusDriverDxe.c | 9 +- EmulatorPkg/EmulatorPkg.dsc | 6 +- EmulatorPkg/FlashMapPei/FlashMapPei.c

[edk2-devel] [Patch V5 01/11] EmulatorPkg: Fix VS20xx IA32 boot failure

2019-08-16 Thread Michael D Kinney
can potentially cause a boot failure if this address specified by the PCD is already allocated in the user process. Cc: Jordan Justen Cc: Andrew Fish Cc: Ray Ni Signed-off-by: Michael D Kinney Reviewed-by: Hao A Wu Reviewed-by: Jordan Justen Tested-by: Andrew Fish --- EmulatorPkg

[edk2-devel] [Patch V5 02/11] EmulatorPkg: Remove UNIX_SEC_BUILD/WIN_SEC_BUILD

2019-08-16 Thread Michael D Kinney
environment. The Readme.md, BAT, and sh files are also updated to remove the use of these defines. Cc: Jordan Justen Cc: Andrew Fish Cc: Ray Ni Signed-off-by: Michael D Kinney Reviewed-by: Hao A Wu Reviewed-by: Jordan Justen Tested-by: Andrew Fish --- EmulatorPkg/EmulatorPkg.dsc

[edk2-devel] [Patch V5 06/11] EmulatorPkg: Fix XCODE5 lldb issues

2019-08-16 Thread Michael D Kinney
From: Andrew Fish Fix scripts to support lldb symbolic debugging when using XCODE5 tool chain. Cc: Jordan Justen Cc: Ray Ni Cc: Michael D Kinney Signed-off-by: Andrew Fish Reviewed-by: Michael D Kinney Tested-by: Andrew Fish --- EmulatorPkg/Unix/lldbefi.py | 8 +--- EmulatorPkg

[edk2-devel] [Patch V5 08/11] EmulatorPkg/Unix/Host: Remove debug code from BerkeleyPacketFilter.c

2019-08-16 Thread Michael D Kinney
From: Andrew Fish Remove old debug code that generates an exception. Cc: Jordan Justen Cc: Ray Ni Cc: Michael D Kinney Signed-off-by: Andrew Fish Reviewed-by: Michael D Kinney Tested-by: Andrew Fish --- EmulatorPkg/Unix/Host/BerkeleyPacketFilter.c | 4 1 file changed, 4 deletions

[edk2-devel] [Patch V5 10/11] EmulatorPkg/Sec: Change scope of PpiArray[10]

2019-08-16 Thread Michael D Kinney
is to move the declaration of PpiArray[10] to the beginning of the function, so it is scoped correctly for all references to this local variable and references to its location. Cc: Jordan Justen Cc: Ray Ni Cc: Michael D Kinney Signed-off-by: Andrew Fish Reviewed-by: Michael D Kinney Tested

[edk2-devel] [Patch V5 00/11] EmulatorPkg: Fix VS20xx IA32 boot and simplify build config

2019-08-16 Thread Michael D Kinney
VS20xx IA32 boot failure * Remove UNIX_SEC_BUILD/WIN_SEC_BUILD * Add -D DISABLE_NEW_DEPRECATED_INTERFACES Cc: Jordan Justen Cc: Andrew Fish Cc: Ray Ni Signed-off-by: Michael D Kinney Andrew Fish (7): EmulatorPkg/Unix/Host: Disable inline/optimizations EmulatorPkg: Fix XCODE5 lldb issues

[edk2-devel] [Patch V5 04/11] EmulatorPkg: Add support for NOOPT target

2019-08-16 Thread Michael D Kinney
Add NOOPT to BUILD_TARGETS in DSC file. Cc: Jordan Justen Cc: Andrew Fish Cc: Ray Ni Signed-off-by: Michael D Kinney Reviewed-by: Hao A Wu Reviewed-by: Jordan Justen Tested-by: Andrew Fish --- EmulatorPkg/EmulatorPkg.dsc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [edk2-devel] [Patch V4 06/10] EmulatorPkg: Fix XCODE5 lldb issues

2019-08-16 Thread Michael D Kinney
t; combinations listed > > above. > > > > https://dev.azure.com/mikekinney/edk2- > ci/_build/results?buildId=312 > > > > Mike > > > > > -----Original Message- > > > From: Justen, Jordan L > > > Sent: Friday, August 16, 2019 1

Re: [edk2-devel] [PATCH v2 1/1] MdePkg: Add STATIC_ASSERT macro

2019-08-16 Thread Michael D Kinney
Laszlo, I agree that better comments/documentation of STATIC_ASSERT() for EDK II usages is required. For example, EDK II defines the ASSERT() macro which is based on the standard C function assert(), but we still document it fully for EDK II usage. /** Macro that calls DebugAssert() if an

Re: [edk2-devel] [Patch V4 06/10] EmulatorPkg: Fix XCODE5 lldb issues

2019-08-16 Thread Michael D Kinney
; To: Kinney, Michael D ; > devel@edk2.groups.io > Cc: Ni, Ray ; Andrew Fish > > Subject: Re: [Patch V4 06/10] EmulatorPkg: Fix XCODE5 > lldb issues > > On 2019-08-15 19:14:33, Michael D Kinney wrote: > > Fix scripts to support lldb symbolic debugging when > using XCODE5

[edk2-devel] [Patch V4 05/10] EmulatorPkg/Unix/Host: Disable inline/optimizations

2019-08-15 Thread Michael D Kinney
Cc: Ray Ni Signed-off-by: Michael D Kinney --- EmulatorPkg/Unix/Host/Host.c | 3 +++ EmulatorPkg/Unix/Host/Host.inf | 4 ++-- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/EmulatorPkg/Unix/Host/Host.c b/EmulatorPkg/Unix/Host/Host.c index febfb1f44c..b431a4c2ed 100644

[edk2-devel] [Patch V4 03/10] EmulatorPkg: Add -D DISABLE_NEW_DEPRECATED_INTERFACES

2019-08-15 Thread Michael D Kinney
Cc: Andrew Fish Cc: Ray Ni Signed-off-by: Michael D Kinney Reviewed-by: Hao A Wu Acked-by: Jordan Justen --- EmulatorPkg/EmuBusDriverDxe/EmuBusDriverDxe.c | 9 +- EmulatorPkg/EmulatorPkg.dsc | 6 +- EmulatorPkg/FlashMapPei/FlashMapPei.c | 8 +- EmulatorPkg

[edk2-devel] [Patch V4 07/10] EmulatorPkg/Unix/Host: Fix BerkeleyPacketFilter.c issues

2019-08-15 Thread Michael D Kinney
* Fix uninitialized Private->ReadBuffer. * Remove old debug code that generates an exception. Cc: Jordan Justen Cc: Ray Ni Cc: Michael D Kinney Signed-off-by: Andrew Fish --- EmulatorPkg/Unix/Host/BerkeleyPacketFilter.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --

[edk2-devel] [Patch V4 01/10] EmulatorPkg: Fix VS20xx IA32 boot failure

2019-08-15 Thread Michael D Kinney
can potentially cause a boot failure if this address specified by the PCD is already allocated in the user process. Cc: Jordan Justen Cc: Andrew Fish Cc: Ray Ni Signed-off-by: Michael D Kinney Reviewed-by: Hao A Wu Reviewed-by: Jordan Justen --- EmulatorPkg/EmulatorPkg.dec | 4 ++-- 1 file

[edk2-devel] [Patch V4 09/10] EmulatorPkg/Sec: Change local variable scope for XCODE5

2019-08-15 Thread Michael D Kinney
of the function so the storage for this local variable is allocated for the entire lifetime of the function. Cc: Jordan Justen Cc: Ray Ni Cc: Michael D Kinney Signed-off-by: Andrew Fish --- EmulatorPkg/Sec/Sec.c | 16 +++- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git

[edk2-devel] [Patch V4 06/10] EmulatorPkg: Fix XCODE5 lldb issues

2019-08-15 Thread Michael D Kinney
Fix scripts to support lldb symbolic debugging when using XCODE5 tool chain. Cc: Jordan Justen Cc: Ray Ni Cc: Michael D Kinney Signed-off-by: Andrew Fish --- EmulatorPkg/Unix/lldbefi.py | 8 +--- EmulatorPkg/build.sh| 17 ++--- 2 files changed, 7 insertions(+), 18

[edk2-devel] [Patch V4 02/10] EmulatorPkg: Remove UNIX_SEC_BUILD/WIN_SEC_BUILD

2019-08-15 Thread Michael D Kinney
environment. The Readme.md, BAT, and sh files are also updated to remove the use of these defines. Cc: Jordan Justen Cc: Andrew Fish Cc: Ray Ni Signed-off-by: Michael D Kinney Reviewed-by: Hao A Wu Reviewed-by: Jordan Justen --- EmulatorPkg/EmulatorPkg.dsc| 26

[edk2-devel] [Patch V4 08/10] EmulatorPkg: Disable TftpDynamicCommand and LogoDxe for XCODE5

2019-08-15 Thread Michael D Kinney
resource section that is not supported by the XCODE5 tool chain, and the missing HII content causes the load of this module to ASSERT(). Cc: Jordan Justen Cc: Ray Ni Cc: Michael D Kinney Signed-off-by: Andrew Fish --- EmulatorPkg/EmulatorPkg.dsc | 4 EmulatorPkg/EmulatorPkg.fdf | 4

[edk2-devel] [Patch V4 00/10] EmulatorPkg: Fix VS20xx IA32 boot and simplify build config

2019-08-15 Thread Michael D Kinney
-off-by: Michael D Kinney Michael D Kinney (10): EmulatorPkg: Fix VS20xx IA32 boot failure EmulatorPkg: Remove UNIX_SEC_BUILD/WIN_SEC_BUILD EmulatorPkg: Add -D DISABLE_NEW_DEPRECATED_INTERFACES EmulatorPkg: Add support for NOOPT target EmulatorPkg/Unix/Host: Disable inline/optimizations

[edk2-devel] [Patch V4 10/10] BaseTools/tools_def.template: Add -gdwarf to XCODE5 X64

2019-08-15 Thread Michael D Kinney
Add -gdwarf to XCODE5 X64 builds to generate symbols for source level debug using lldb. Cc: Jordan Justen Cc: Ray Ni Cc: Michael D Kinney Signed-off-by: Andrew Fish --- BaseTools/Conf/tools_def.template | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/BaseTools/Conf

[edk2-devel] [Patch V4 04/10] EmulatorPkg: Add support for NOOPT target

2019-08-15 Thread Michael D Kinney
Add NOOPT to BUILD_TARGETS in DSC file. Cc: Jordan Justen Cc: Andrew Fish Cc: Ray Ni Signed-off-by: Michael D Kinney Reviewed-by: Hao A Wu Reviewed-by: Jordan Justen --- EmulatorPkg/EmulatorPkg.dsc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/EmulatorPkg

Re: [edk2-devel] [PATCH] UefiCpuPkg: Adding a new TSC library by using CPUID(0x15) TSC leaf

2019-08-15 Thread Michael D Kinney
Vitaly, When implementing a UEFI Application, if you want maximum compatibility, you should use UEFI Services/Protocols and minimize as many HW assumptions as possible. I understand, especially for accurate time and clock related services, the that the UEFI Specification defined

Re: [edk2-devel] [PATCH v2 1/1] MdePkg: Add STATIC_ASSERT macro

2019-08-15 Thread Michael D Kinney
Reviewed-by: Michael D Kinney Mike > -Original Message- > From: devel@edk2.groups.io > [mailto:devel@edk2.groups.io] On Behalf Of vit9696 via > Groups.Io > Sent: Tuesday, August 13, 2019 1:17 AM > To: devel@edk2.groups.io > Subject: [edk2-devel] [PATC

Re: [edk2-devel] [PATCH v2 1/1] MdePkg: Add STATIC_ASSERT macro

2019-08-14 Thread Michael D Kinney
Liming, I think a good candidate to demonstrate this feature are the checks made in MdePkg/Include/Base.h. The current implementation forces a divide by 0 in the C pre-processor to break the build. STATIC_ASSERT() would be a better way to do this. I would also remove unused externs from the

Re: [edk2-devel] [PATCH v1 0/1] Added GOP driver for DisplayLink-based Universal USB Docks to edk2-platforms

2019-08-14 Thread Michael D Kinney
Hi Andy, Thanks for the contribution. Is this patch for the edk2-platform repo? The email subject can help clarify the intended repo. Also, we prefer the patches to be provided inline instead of an attachment. You can use the 'git send-email' feature to do this. Here are a couple links to

Re: [edk2-devel] [Patch 1/1] BaseTools: Fix incremental build bug

2019-08-13 Thread Michael D Kinney
Bob, I have verified that the shell is rebuilt correctly when the number of NULL lib instances are changed. Tested-by: Michael D Kinney Mike > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] > On Behalf Of Bob Feng > Sent: Monday, August 12,

[edk2-devel] [Patch] Vlb2TbltDevicePkg: Add acpiview and IPv6 shell commands

2019-08-13 Thread Michael D Kinney
Update the integrated UEFI Shell to include the acpiview, ping6, and ifconfig6 commands. Cc: Zailiang Sun Cc: Gary Lin Signed-off-by: Michael D Kinney --- Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc | 2 ++ Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc | 2 ++ 2 files changed

Re: [edk2-devel] [Patch] MdeModulePkg DxeCore: Fix for missing MAT update

2019-08-12 Thread Michael D Kinney
> -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] > On Behalf Of Laszlo Ersek > Sent: Monday, August 12, 2019 9:24 AM > To: devel@edk2.groups.io; Gao, Liming > > Cc: Mike Turner ; Wang, Jian J > ; Wu, Hao A ; > Bi, Dandan > Subject: Re: [edk2-devel]

Re: [edk2-devel] [PATCH] MdePkg: Add STATIC_ASSERT macro

2019-08-12 Thread Michael D Kinney
Hi Vitaly, Thanks for the contribution. I see you are using _MSC_VER. The rest of Base.h uses _MSC_EXTENSIONs and only if that is defined is _MSC_VER used and _MSC_VER is only used if a specific version value check is required. What version of VS introduced this feature? We can define this

Re: [edk2-devel] [Patch V3 0/4] EmulatorPkg: Fix VS20xx IA32 boot and simplify build config

2019-08-09 Thread Michael D Kinney
Andrew Fish ; Ni, Ray > > Subject: Re: [edk2-devel] [Patch V3 0/4] EmulatorPkg: > Fix VS20xx IA32 boot and simplify build config > > On 2019-08-09 15:44:01, Michael D Kinney wrote: > > New in V3 > > == > > * Fix size value used in call to AsciiStrCpyS() in >

Re: [edk2-devel] [edk2-non-osi patch 0/1] Add UNDI ROM for SIMICS QSP Platform

2019-08-09 Thread Michael D Kinney
David, The file License.txt make a reference to the file IntelProprietaryLicense.txt, but I do not see that file in this patchset. For example, the content in Silicon/Intel/QuarkSocBinPkg has a License.txt file and the content in the path

[edk2-devel] [Patch V3 0/4] EmulatorPkg: Fix VS20xx IA32 boot and simplify build config

2019-08-09 Thread Michael D Kinney
Justen Cc: Andrew Fish Cc: Ray Ni Signed-off-by: Michael D Kinney Michael D Kinney (4): EmulatorPkg: Fix VS20xx IA32 boot failure EmulatorPkg: Remove UNIX_SEC_BUILD/WIN_SEC_BUILD EmulatorPkg: Add -D DISABLE_NEW_DEPRECATED_INTERFACES EmulatorPkg: Add support for NOOPT target EmulatorPkg

[edk2-devel] [Patch V3 3/4] EmulatorPkg: Add -D DISABLE_NEW_DEPRECATED_INTERFACES

2019-08-09 Thread Michael D Kinney
Cc: Andrew Fish Cc: Ray Ni Signed-off-by: Michael D Kinney Reviewed-by: Hao A Wu --- EmulatorPkg/EmuBusDriverDxe/EmuBusDriverDxe.c | 9 +- EmulatorPkg/EmulatorPkg.dsc | 6 +- EmulatorPkg/FlashMapPei/FlashMapPei.c | 8 +- EmulatorPkg/Library/SmbiosLib/SmbiosLib.c

[edk2-devel] [Patch V3 4/4] EmulatorPkg: Add support for NOOPT target

2019-08-09 Thread Michael D Kinney
Add NOOPT to BUILD_TARGETS in DSC file. Cc: Jordan Justen Cc: Andrew Fish Cc: Ray Ni Signed-off-by: Michael D Kinney --- EmulatorPkg/EmulatorPkg.dsc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/EmulatorPkg/EmulatorPkg.dsc b/EmulatorPkg/EmulatorPkg.dsc index 529adfe1fa

[edk2-devel] [Patch V3 2/4] EmulatorPkg: Remove UNIX_SEC_BUILD/WIN_SEC_BUILD

2019-08-09 Thread Michael D Kinney
environment. The Readme.md, BAT, and sh files are also updated to remove the use of these defines. Cc: Jordan Justen Cc: Andrew Fish Cc: Ray Ni Signed-off-by: Michael D Kinney Reviewed-by: Hao A Wu --- EmulatorPkg/EmulatorPkg.dsc| 26 +- EmulatorPkg/Readme.md

[edk2-devel] [Patch V3 1/4] EmulatorPkg: Fix VS20xx IA32 boot failure

2019-08-09 Thread Michael D Kinney
can potentially cause a boot failure if this address specified by the PCD is already allocated in the user process. Cc: Jordan Justen Cc: Andrew Fish Cc: Ray Ni Signed-off-by: Michael D Kinney Reviewed-by: Hao A Wu --- EmulatorPkg/EmulatorPkg.dec | 4 ++-- 1 file changed, 2 insertions(+), 2

Re: [edk2-devel] [Patch V2 3/3] EmulatorPkg: Add -D DISABLE_NEW_DEPRECATED_INTERFACES

2019-08-09 Thread Michael D Kinney
CATED_INTERFACES > > Hello Mike, > > With one typo mentioned below addressed, > Reviewed-by: Hao A Wu > > > > -Original Message- > > From: devel@edk2.groups.io > [mailto:devel@edk2.groups.io] On Behalf Of > > Michael D Kinney > > Sent: Thu

[edk2-devel] [Patch] Vlv2TbltDevicePkg/VlvPlatformInitDxe: Avoid memset instrinsic

2019-08-09 Thread Michael D Kinney
VS2017 builds for X64 are failing due to the use of the memset intrinsic. The local variable GopVersion is an array that is initialied in the declaration. Update to use ZeroMem() to intialize GopVersion. Cc: Zailiang Sun Cc: Gary Lin Signed-off-by: Michael D Kinney --- .../Intel

  1   2   3   4   5   >