Re: [edk2-devel] [PATCH v1 1/1] BaseTools: don't use WHOLEARCHIVE linker flag for VS2017 toolchain

2019-06-06 Thread Roman Agafonov
here is whether this behavior is really desired, and given the fact that WHOLEARCHIVE had been removed from VS2015 toolchain previously, I don't see a reason to use it with VS2017 too. Best regards, Roman From: Gao, Liming Sent: Wednesday, June 5, 2019 6:47 PM To: Roman Agafonov; devel@edk2

Re: [edk2-devel] [PATCH v1 1/1] BaseTools: don't use WHOLEARCHIVE linker flag for VS2017 toolchain

2019-06-04 Thread Roman Agafonov
/RELEASE_VS2015x86/X64/xgbe_atl.efi 68K     Build/xgbe_atl/RELEASE_VS2017/X64/xgbe_atl.efi Best regards, Roman From: Gao, Liming Sent: Tuesday, June 4, 2019 6:54 PM To: Roman Agafonov; devel@edk2.groups.io Cc: Feng, Bob C; Zhu, Yonghong Subject: RE: [PATCH v1 1/1] BaseTools: don't use WHOLEARCHIVE linker flag

[edk2-devel] [PATCH v1 1/1] BaseTools: don't use WHOLEARCHIVE linker flag for VS2017 toolchain

2019-06-04 Thread Roman Agafonov
believe it should not be used with VS2017 as well. Cc: Bob Feng Cc: Liming Gao Cc: Yonghong Zhu Signed-off-by: Roman Agafonov --- BaseTools/Conf/tools_def.template | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/BaseTools/Conf/tools_def.template b/BaseTools/Conf

[edk2-devel] [PATCH v1 0/1] BaseTools: don't use WHOLEARCHIVE linker flag for VS2017 toolchain

2019-06-04 Thread Roman Agafonov
This patch removes /WHOLEARCHIVE flag from VS2017 toolchain configuration to reduce the size of resulting binaries. GitHub branch: https://github.com/pcfist/edk2/tree/fix_vs2017_linker_config Roman Agafonov (1): BaseTools: don't use WHOLEARCHIVE linker flag for VS2017 toolchain BaseTools