from:"Supreeth Venkatesh"

[edk2-devel] [edk2-test] [PATCH v1 1/1] uefi-sct: Propose maintainers from AMD

2021-08-19 Thread Supreeth Venkatesh via groups.io

This patch proposes Carolyn Gjertsen as maintainer of edk2-test
repository and Supreeth Venkatesh as reviewer from AMD.

Signed-off-by: Supreeth Venkatesh 
---
 uefi-sct/Maintainers.txt | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/uefi-sct/Maintainers.txt b/uefi-sct/Maintainers.txt
index c93b83ec..a94255f0 100644
--- a/uefi-sct/Maintainers.txt
+++ b/uefi-sct/Maintainers.txt
@@ -41,10 +41,12 @@ UEFI-SCT:
 
 M: G Edhaya Chandran 
 M: Barton Gao 
+M: Carolyn Gjertsen 
 
 R: Samer El-Haj-Mahmoud 
 R: Eric Jin 
 R: Arvin Chen 
+R: Supreeth Venkatesh 
 
 General questions on UEFI-SCT with the subject [edk2-test] can be sent to
 L: edk2-devel 
-- 
2.25.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#79596): https://edk2.groups.io/g/devel/message/79596
Mute This Topic: https://groups.io/mt/85009511/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [edk2-test][PATCH v1 1/1] MiscRuntimeServices: Add statement to improve user experience.

2019-09-25 Thread Supreeth Venkatesh

For users, who operate the machine remotely through serial console on
some platforms, the test prompt message shown "System will shut down (or
cold reset) after 1  second..." is misleading, as the reset may not be
automatic.

This patch addresses the issue by adding a note "Note: On some
platforms, you may have to manually turn on the System again after few
seconds...".
This fixes bug 1623.
(https://bugzilla.tianocore.org/show_bug.cgi?id=1623)

Signed-off-by: Supreeth Venkatesh 
---
 .../BlackBoxTest/MiscRuntimeServicesBBTestFunction.c| 4 +++-
 .../BlackBoxTest/MiscRuntimeServicesBBTestStress.c  | 6 --
 2 files changed, 7 insertions(+), 3 deletions(-)

diff --git 
a/uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/MiscRuntimeServices/BlackBoxTest/MiscRuntimeServicesBBTestFunction.c
 
b/uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/MiscRuntimeServices/BlackBoxTest/MiscRuntimeServicesBBTestFunction.c
index 80e8297d..b4ebb806 100644
--- 
a/uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/MiscRuntimeServices/BlackBoxTest/MiscRuntimeServicesBBTestFunction.c
+++ 
b/uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/MiscRuntimeServices/BlackBoxTest/MiscRuntimeServicesBBTestFunction.c
@@ -371,7 +371,9 @@ BBTestResetSystemManualTest (
 // And the stall a second is required to make sure the recovery data has
 // been written into the storage device.
 //
-SctPrint (L"System will shut down (or cold reset) after 1 second...");
+SctPrint (L"System may shut down (or cold reset) after 1 second...");
+SctPrint (L"Note: On some platforms, you may have to manually turn\
+ on the System again after few seconds...");
 gtBS->Stall (100);
 
 OldTpl = gtBS->RaiseTPL (TplArray[Index]);
diff --git 
a/uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/MiscRuntimeServices/BlackBoxTest/MiscRuntimeServicesBBTestStress.c
 
b/uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/MiscRuntimeServices/BlackBoxTest/MiscRuntimeServicesBBTestStress.c
index 1ad732a0..ef0e1148 100644
--- 
a/uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/MiscRuntimeServices/BlackBoxTest/MiscRuntimeServicesBBTestStress.c
+++ 
b/uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/MiscRuntimeServices/BlackBoxTest/MiscRuntimeServicesBBTestStress.c
@@ -374,7 +374,9 @@ BBTestResetSystemManualStressTest (
   //
   // Print out some information to avoid the user thought it is an error
   //
-  SctPrint (L"System will shut down (or cold reset) after 1 second...");
+  SctPrint (L"System may shut down (or cold reset) after 1 second...");
+  SctPrint (L"Note: On some platforms, you may have to manually turn\
+   on the System again after few seconds...");
   gtBS->Stall (100);
 
   OldTpl = gtBS->RaiseTPL (TplArray[Index]);
@@ -404,4 +406,4 @@ ManualStressTestStep2:
   }
 
   return EFI_SUCCESS;
-}
\ No newline at end of file
+}
-- 
2.17.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#48055): https://edk2.groups.io/g/devel/message/48055
Mute This Topic: https://groups.io/mt/34293481/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [edk2-test][PATCH v1 1/1] SctPkg: Fix issue with the shell script

2019-09-25 Thread Supreeth Venkatesh

Fix unintended "space" characters that were added when
IhvFirmwareManagementBBTest.efi was checked-in.

Signed-off-by: Supreeth Venkatesh 
---
 uefi-sct/SctPkg/CommonGenFramework.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/uefi-sct/SctPkg/CommonGenFramework.sh 
b/uefi-sct/SctPkg/CommonGenFramework.sh
index 83045309..779a6a44 100755
--- a/uefi-sct/SctPkg/CommonGenFramework.sh
+++ b/uefi-sct/SctPkg/CommonGenFramework.sh
@@ -313,7 +313,7 @@ then
   cp $ProcessorType/IhvUsb2HcTest.efi$Framework/Test/ 
> NUL
   cp $ProcessorType/IhviScsiInitiatorNameBBTest.efi  $Framework/Test/ 
> NUL
   cp $ProcessorType/IhvStorageSecurityCommandBBTest.efi  $Framework/Test/ 
> NUL
-..cp $ProcessorType/IhvFirmwareManagementBBTest.efi  $Framework/Test/ 
> NUL
+  cp $ProcessorType/IhvFirmwareManagementBBTest.efi  $Framework/Test/ 
> NUL
   cp $ProcessorType/IhvHIIConfigAccessBBTest.efi $Framework/Test/ 
> NUL
 
   # *
-- 
2.17.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#48056): https://edk2.groups.io/g/devel/message/48056
Mute This Topic: https://groups.io/mt/34293484/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-test][Patch 3/3] uefi-sct/SctPkg: Add FMP test to IHV SCT binary package

2019-09-16 Thread Supreeth Venkatesh



Eric,

Can you commit it as well?

Thanks,
Supreeth

On Mon, 2019-09-16 at 02:27 -0500, Jin, Eric wrote:
> The series is reviewed. 
> Reviewed-by: Eric Jin 
> 
> -Original Message-
> From: devel@edk2.groups.io  On Behalf Of Eric
> Jin
> Sent: Wednesday, September 11, 2019 3:51 PM
> To: devel@edk2.groups.io
> Cc: shrishail patil ; Supreeth
> Venkatesh 
> Subject: [edk2-devel] [edk2-test][Patch 3/3] uefi-sct/SctPkg: Add FMP
> test to IHV SCT binary package
> 
> From: shrishail patil 
> 
> Cc: Supreeth Venkatesh 
> Cc: Eric Jin 
> Signed-off-by: shrishail patil 
> ---
>  uefi-sct/SctPkg/CommonGenFramework.bat | 3 ++-  uefi-
> sct/SctPkg/CommonGenFramework.sh  | 3 ++-
>  2 files changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/uefi-sct/SctPkg/CommonGenFramework.bat b/uefi-
> sct/SctPkg/CommonGenFramework.bat
> index 5c614eaa9a74..42aefa8fb479 100644
> --- a/uefi-sct/SctPkg/CommonGenFramework.bat
> +++ b/uefi-sct/SctPkg/CommonGenFramework.bat
> @@ -2,6 +2,7 @@
>  @REM  Copyright 2006 - 2017 Unified EFI, Inc.  @REM  Copyright
> (c) 2010 - 2018, Intel Corporation. All rights
> reserved.  @REM  (C) Copyright 2017 Hewlett Packard Enterprise
> Development LP
> +@REM  Copyright (c) 2019,Microchip Technology Inc.
>  @REM
>  @REM  This program and the accompanying materials  @REM  are
> licensed and made available under the terms and conditions of the BSD
> License
> @@ -279,7 +280,7 @@ rem  copy
> %ProcessorType%\IhvUsbHcTest.efi %Framework%\
> T
>copy
> %ProcessorType%\IhvUsb2HcTest.efi%Framework%\
> Test\ > NUL
>copy
> %ProcessorType%\IhviScsiInitiatorNameBBTest.efi  %Framework%\
> Test\ > NUL
>copy
> %ProcessorType%\IhvStorageSecurityCommandBBTest.efi  %Framework%\
> Test\ > NUL
> -  
> +  copy
> %ProcessorType%\IhvFirmwareManagementBBTest.efi  %Framework%\
> Test\ > NUL
>rem *
>rem Copy the UEFI 2.1 Test Cases for IHV
>rem *
> diff --git a/uefi-sct/SctPkg/CommonGenFramework.sh b/uefi-
> sct/SctPkg/CommonGenFramework.sh
> index c422034a6457..ed2b36aec42a 100755
> --- a/uefi-sct/SctPkg/CommonGenFramework.sh
> +++ b/uefi-sct/SctPkg/CommonGenFramework.sh
> @@ -4,6 +4,7 @@
>  #  Copyright (c) 2011 - 2019, ARM Ltd. All rights
> reserved.  #  Copyright (c) 2014 - 2018, Intel Corporation. All
> rights reserved.  #  (C) Copyright 2017 Hewlett Packard
> Enterprise Development LP
> +#  Copyright (c) 2019,Microchip Technology Inc.
>  #
>  #  This program and the accompanying materials  #  are licensed and
> made available under the terms and conditions of the BSD License @@
> -312,7 +313,7 @@ then
>cp
> $ProcessorType/IhvUsb2HcTest.efi$Framework/Te
> st/ > NUL
>cp
> $ProcessorType/IhviScsiInitiatorNameBBTest.efi  $Framework/Te
> st/ > NUL
>cp
> $ProcessorType/IhvStorageSecurityCommandBBTest.efi  $Framework/Te
> st/ > NUL
> -
> +..cp
> $ProcessorType/IhvFirmwareManagementBBTest.efi  $Framework/Te
> st/ > NUL
># *
># Copy the UEFI 2.1 Test Cases for IHV
># *
> --
> 2.20.0.windows.1
> 
> 
> 
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#47289): https://edk2.groups.io/g/devel/message/47289
Mute This Topic: https://groups.io/mt/34101064/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-test][Patch 3/3] uefi-sct/SctPkg: Add HiiConfigAccess to IHV SCT binary package

2019-09-16 Thread Supreeth Venkatesh



Eric,

Can you push this as well?

Thanks,
Supreeth
On Mon, 2019-09-16 at 02:25 -0500, Jin, Eric wrote:
> The series is reviewed. 
> Reviewed-by: Eric Jin 
> 
> -Original Message-
> From: devel@edk2.groups.io  On Behalf Of Eric
> Jin
> Sent: Thursday, September 12, 2019 11:04 AM
> To: devel@edk2.groups.io
> Cc: shrishail patil ; Supreeth
> Venkatesh 
> Subject: [edk2-devel] [edk2-test][Patch 3/3] uefi-sct/SctPkg: Add
> HiiConfigAccess to IHV SCT binary package
> 
> From: shrishail patil 
> 
> Cc: Supreeth Venkatesh 
> Cc: Eric Jin 
> Signed-off-by: shrishail patil 
> ---
>  uefi-sct/SctPkg/CommonGenFramework.bat | 4 +++-  uefi-
> sct/SctPkg/CommonGenFramework.sh  | 2 ++
>  2 files changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/uefi-sct/SctPkg/CommonGenFramework.bat b/uefi-
> sct/SctPkg/CommonGenFramework.bat
> index 5c614eaa9a74..d84cbf379fc9 100644
> --- a/uefi-sct/SctPkg/CommonGenFramework.bat
> +++ b/uefi-sct/SctPkg/CommonGenFramework.bat
> @@ -2,6 +2,7 @@
>  @REM  Copyright 2006 - 2017 Unified EFI, Inc.  @REM  Copyright
> (c) 2010 - 2018, Intel Corporation. All rights
> reserved.  @REM  (C) Copyright 2017 Hewlett Packard Enterprise
> Development LP
> +@REM  Copyright (c) 2019,Microchip Technology Inc.
>  @REM
>  @REM  This program and the accompanying materials  @REM  are
> licensed and made available under the terms and conditions of the BSD
> License
> @@ -279,7 +280,8 @@ rem  copy
> %ProcessorType%\IhvUsbHcTest.efi %Framework%\
> T
>copy
> %ProcessorType%\IhvUsb2HcTest.efi%Framework%\
> Test\ > NUL
>copy
> %ProcessorType%\IhviScsiInitiatorNameBBTest.efi  %Framework%\
> Test\ > NUL
>copy
> %ProcessorType%\IhvStorageSecurityCommandBBTest.efi  %Framework%\
> Test\ > NUL
> -  
> +  copy
> %ProcessorType%\IhvHIIConfigAccessBBTest.efi %Framework%\
> Test\ > NUL
> +
>rem *
>rem Copy the UEFI 2.1 Test Cases for IHV
>rem *
> diff --git a/uefi-sct/SctPkg/CommonGenFramework.sh b/uefi-
> sct/SctPkg/CommonGenFramework.sh
> index c422034a6457..7e15094d36f4 100755
> --- a/uefi-sct/SctPkg/CommonGenFramework.sh
> +++ b/uefi-sct/SctPkg/CommonGenFramework.sh
> @@ -4,6 +4,7 @@
>  #  Copyright (c) 2011 - 2019, ARM Ltd. All rights
> reserved.  #  Copyright (c) 2014 - 2018, Intel Corporation. All
> rights reserved.  #  (C) Copyright 2017 Hewlett Packard
> Enterprise Development LP
> +#  Copyright (c) 2019,Microchip Technology Inc.
>  #
>  #  This program and the accompanying materials  #  are licensed and
> made available under the terms and conditions of the BSD License @@
> -312,6 +313,7 @@ then
>cp
> $ProcessorType/IhvUsb2HcTest.efi$Framework/Te
> st/ > NUL
>cp
> $ProcessorType/IhviScsiInitiatorNameBBTest.efi  $Framework/Te
> st/ > NUL
>cp
> $ProcessorType/IhvStorageSecurityCommandBBTest.efi  $Framework/Te
> st/ > NUL
> +  cp
> $ProcessorType/IhvHIIConfigAccessBBTest.efi $Framework/Te
> st/ > NUL
>  
># *
># Copy the UEFI 2.1 Test Cases for IHV
> --
> 2.20.0.windows.1
> 
> 
> 
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#47288): https://edk2.groups.io/g/devel/message/47288
Mute This Topic: https://groups.io/mt/34111427/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-test][Patch V2 1/1] uefi-sct/SctPkg: Eliminate 2nd execution of ExitBootServices Test

2019-08-23 Thread Supreeth Venkatesh

On Fri, 2019-08-23 at 00:46 -0500, Eric Jin wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2098
> 
> In the ExitBootServices() test, after ExitBootServices() call, all
> boot services are forbidden. The original design is to save the
> return
> status value of ExitBootServices() in variable using variable service
> and reset, but this needs one additional execution of the test to
> retrieve the value from variable and this design was not
> straightforward
> from end user perspective.
> This patch enhances the test by leveraging RecoveryLib to restore
> execution after reset automatically, thus requiring only one
> execution.
> 
> Cc: Supreeth Venkatesh 
> Signed-off-by: Eric Jin 


Please re-order the statements like below to make it more clear since
ResetData is a just a pointer to Buffer Array which is statically
allocated to 1024 and ResetData is not being really initialized to
Reset Record after reading reset record, but to Buffer Array.
1. ResetData = (RESET_DATA *)Buffer;
2. RecoveryLib->ReadResetRecord(RecoveryLib, Size, Buffer);
while commiting it.

With that,
Reviewed-by: Supreeth Venkatesh 


> ---
>  uefi-
> sct/SctPkg/TestCase/UEFI/EFI/BootServices/ImageServices/BlackBoxTest/
> ImageBBTest.inf  |   3 ++-
>  uefi-
> sct/SctPkg/TestCase/UEFI/EFI/BootServices/ImageServices/BlackBoxTest/
> ImageBBTest.h|   9 -
>  uefi-
> sct/SctPkg/TestCase/UEFI/EFI/BootServices/ImageServices/BlackBoxTest/
> ImageBBTestConformance.c | 121
> +
> 
>  3 files changed, 115 insertions(+), 18 deletions(-)
> 
> diff --git a/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/BootServices/ImageServices/BlackBoxTest/
> ImageBBTest.inf b/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/BootServices/ImageServices/BlackBoxTest/
> ImageBBTest.inf
> index 49ad79915934..3de43a20e8a4 100644
> --- a/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/BootServices/ImageServices/BlackBoxTest/
> ImageBBTest.inf
> +++ b/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/BootServices/ImageServices/BlackBoxTest/
> ImageBBTest.inf
> @@ -1,7 +1,7 @@
>  ## @file
>  #
>  #  Copyright 2006 - 2012 Unified EFI, Inc.
> -#  Copyright (c) 2010 - 2012, Intel Corporation. All rights
> reserved.
> +#  Copyright (c) 2010 - 2019, Intel Corporation. All rights
> reserved.
>  #
>  #  This program and the accompanying materials
>  #  are licensed and made available under the terms and conditions of
> the BSD License
> @@ -53,4 +53,5 @@
>  
>  [Protocols]
>gEfiTestProfileLibraryGuid
> +  gEfiTestRecoveryLibraryGuid
>gBlackBoxEfiHIIPackageListProtocolGuid
> diff --git a/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/BootServices/ImageServices/BlackBoxTest/
> ImageBBTest.h b/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/BootServices/ImageServices/BlackBoxTest/
> ImageBBTest.h
> index b1c35fee7435..008584577ed1 100644
> --- a/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/BootServices/ImageServices/BlackBoxTest/
> ImageBBTest.h
> +++ b/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/BootServices/ImageServices/BlackBoxTest/
> ImageBBTest.h
> @@ -1,7 +1,7 @@
>  /** @file
>  
>Copyright 2006 - 2017 Unified EFI, Inc.
> -  Copyright (c) 2010 - 2017, Intel Corporation. All rights
> reserved.
> +  Copyright (c) 2010 - 2019, Intel Corporation. All rights
> reserved.
>  
>This program and the accompanying materials
>are licensed and made available under the terms and conditions of
> the BSD License
> @@ -35,6 +35,13 @@ Abstract:
>  #include EFI_PROTOCOL_DEFINITION (LoadFile)
>  
>  #include EFI_TEST_PROTOCOL_DEFINITION (TestProfileLibrary)
> +#include EFI_TEST_PROTOCOL_DEFINITION (TestRecoveryLibrary)
> +
> +typedef struct _RESET_DATA {
> +  UINTN   Step;
> +  UINTN   TplIndex;
> +  UINT32  RepeatTimes;
> +} RESET_DATA;
>  
>  #if (EFI_SPECIFICATION_VERSION >= 0x0002000A)
>  
> diff --git a/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/BootServices/ImageServices/BlackBoxTest/
> ImageBBTestConformance.c b/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/BootServices/ImageServices/BlackBoxTest/
> ImageBBTestConformance.c
> index 0a26d46847da..6ce1d2d72669 100644
> --- a/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/BootServices/ImageServices/BlackBoxTest/
> ImageBBTestConformance.c
> +++ b/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/BootServices/ImageServices/BlackBoxTest/
> ImageBBTestConformance.c
> @@ -1,7 +1,7 @@
>  /** @file
>  
>Copyright 2006 - 2016 Unified EFI, Inc.
> -  Copyright (c) 2010 - 2016, Intel Corporation. All rights
> reserved.
> +  Copyright (c) 2010 - 2019, Intel Corporation. All rights
> reserved.
>  
>This p

Re: [edk2-devel] [edk2-test][Patch 1/1] uefi-sct/SctPkg: Eliminate 2nd execution of ExitBootServices Test

2019-08-23 Thread Supreeth Venkatesh

On Thu, 2019-08-22 at 22:37 -0500, Jin, Eric wrote:
> Hi Supreeth,
> 
> > -Original Message-
> > From: Supreeth Venkatesh [mailto:supreeth.venkat...@arm.com]
> > Sent: Friday, August 23, 2019 2:43 AM
> > To: devel@edk2.groups.io; Jin, Eric 
> > Subject: Re: [edk2-devel] [edk2-test][Patch 1/1] uefi-sct/SctPkg:
> > Eliminate
> > 2nd execution of ExitBootServices Test
> > 
> > On Wed, 2019-08-21 at 20:50 -0500, Eric Jin via Groups.Io wrote:
> > > Hij Supreeth,
> > 
> > Hi Eric,
> > 
> > > 
> > > > -Original Message-
> > > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On
> > > > Behalf
> > > > Of Supreeth Venkatesh
> > > > Sent: Thursday, August 22, 2019 12:43 AM
> > > > To: Jin, Eric ; devel@edk2.groups.io
> > > > Subject: Re: [edk2-devel] [edk2-test][Patch 1/1] uefi-
> > > > sct/SctPkg:
> > > > Eliminate
> > > > 2nd execution of ExitBootServices Test
> > > > 
> > > > On Wed, 2019-08-21 at 01:24 -0500, Eric Jin wrote:
> > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2098
> > > > 
> > > > Please add the details of the patch to the commit message.
> > > > "In the ExitBootServices() test, after ExitBootServices() call,
> > > > all
> > > > boot services are forbidden. The original design is to save the
> > > > return status value of
> > > > ExitBootServices() in variable using variable service and
> > > > reset, but
> > > > this needs multiple execution of the test to retrieve the value
> > > > from
> > > > variable and this design was not straightforward from end user
> > > > perspective.
> > > > 
> > > 
> > > I would like to change "multiple execution" to "one additional
> > > execution"
> > > 
> > > > This patch enhances the test by leveraging RecoveryLib to
> > > > restore
> > > > execution
> > > > after reset automatically, thus requiring only one execution"
> > > > 
> > > 
> > > I am ok with this suggestion when I push the code to repo
> > 
> > Thanks.
> > 
> > > 
> > > > More comments inline...
> > > > 
> > > > > 
> > > > > Cc: Supreeth Venkatesh 
> > > > > Signed-off-by: Eric Jin 
> > > > > ---
> > > > >  uefi-
> > > > > sct/SctPkg/TestCase/UEFI/EFI/BootServices/ImageServices/Black
> > > > > BoxT
> > > > > est/
> > > > > ImageBBTest.inf  |  3 ++-
> > > > >  uefi-
> > > > > sct/SctPkg/TestCase/UEFI/EFI/BootServices/ImageServices/Black
> > > > > BoxT
> > > > > est/
> > > > > ImageBBTest.h|  9 -
> > > > >  uefi-
> > > > > sct/SctPkg/TestCase/UEFI/EFI/BootServices/ImageServices/Black
> > > > > BoxT
> > > > > est/
> > > > > ImageBBTestConformance.c | 98
> > > > > 
> > > > 
> > > > 
> > 
> > ++
> > > > +++
> > > > > ++---
> > > > >  3 files changed, 93 insertions(+), 17 deletions(-)
> > > > > 
> > > > > diff --git a/uefi-
> > > > > sct/SctPkg/TestCase/UEFI/EFI/BootServices/ImageServices/Black
> > > > > BoxT
> > > > > est/
> > > > > ImageBBTest.inf b/uefi-
> > > > > sct/SctPkg/TestCase/UEFI/EFI/BootServices/ImageServices/Black
> > > > > BoxT
> > > > > est/
> > > > > ImageBBTest.inf
> > > > > index 49ad79915934..3de43a20e8a4 100644
> > > > > --- a/uefi-
> > > > > sct/SctPkg/TestCase/UEFI/EFI/BootServices/ImageServices/Black
> > > > > BoxT
> > > > > est/
> > > > > ImageBBTest.inf
> > > > > +++ b/uefi-
> > > > > sct/SctPkg/TestCase/UEFI/EFI/BootServices/ImageServices/Black
> > > > > BoxT
> > > > > est/
> > > > > ImageBBTest.inf
> > > > > @@ -1,7 +1,7 @@
> > > > >  ## @file
> > > > >  #
> > > > >  #  Copyright 2006 - 2012 Unified EFI, Inc. -#  Copyright
> > > > > (c)
> > > > > 2

Re: [edk2-devel] [edk2-test][Patch 1/1] uefi-sct/SctPkg: Eliminate 2nd execution of ExitBootServices Test

2019-08-22 Thread Supreeth Venkatesh

On Wed, 2019-08-21 at 20:50 -0500, Eric Jin via Groups.Io wrote:
> Hij Supreeth,
Hi Eric,

> 
> > -Original Message-
> > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf
> > Of
> > Supreeth Venkatesh
> > Sent: Thursday, August 22, 2019 12:43 AM
> > To: Jin, Eric ; devel@edk2.groups.io
> > Subject: Re: [edk2-devel] [edk2-test][Patch 1/1] uefi-sct/SctPkg:
> > Eliminate
> > 2nd execution of ExitBootServices Test
> > 
> > On Wed, 2019-08-21 at 01:24 -0500, Eric Jin wrote:
> > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2098
> > 
> > Please add the details of the patch to the commit message.
> > "In the ExitBootServices() test, after ExitBootServices() call, all
> > boot services
> > are forbidden. The original design is to save the return status
> > value of
> > ExitBootServices() in variable using variable service and reset,
> > but this needs
> > multiple execution of the test to retrieve the value from variable
> > and this
> > design was not straightforward from end user perspective.
> > 
> 
> I would like to change "multiple execution" to "one additional
> execution" 
> 
> > This patch enhances the test by leveraging RecoveryLib to restore
> > execution
> > after reset automatically, thus requiring only one execution"
> > 
> 
> I am ok with this suggestion when I push the code to repo
Thanks.

> 
> > More comments inline...
> > 
> > > 
> > > Cc: Supreeth Venkatesh 
> > > Signed-off-by: Eric Jin 
> > > ---
> > >  uefi-
> > > sct/SctPkg/TestCase/UEFI/EFI/BootServices/ImageServices/BlackBoxT
> > > est/
> > > ImageBBTest.inf  |  3 ++-
> > >  uefi-
> > > sct/SctPkg/TestCase/UEFI/EFI/BootServices/ImageServices/BlackBoxT
> > > est/
> > > ImageBBTest.h|  9 -
> > >  uefi-
> > > sct/SctPkg/TestCase/UEFI/EFI/BootServices/ImageServices/BlackBoxT
> > > est/
> > > ImageBBTestConformance.c | 98
> > > 
> > 
> > ++
> > +++
> > > ++---
> > >  3 files changed, 93 insertions(+), 17 deletions(-)
> > > 
> > > diff --git a/uefi-
> > > sct/SctPkg/TestCase/UEFI/EFI/BootServices/ImageServices/BlackBoxT
> > > est/
> > > ImageBBTest.inf b/uefi-
> > > sct/SctPkg/TestCase/UEFI/EFI/BootServices/ImageServices/BlackBoxT
> > > est/
> > > ImageBBTest.inf
> > > index 49ad79915934..3de43a20e8a4 100644
> > > --- a/uefi-
> > > sct/SctPkg/TestCase/UEFI/EFI/BootServices/ImageServices/BlackBoxT
> > > est/
> > > ImageBBTest.inf
> > > +++ b/uefi-
> > > sct/SctPkg/TestCase/UEFI/EFI/BootServices/ImageServices/BlackBoxT
> > > est/
> > > ImageBBTest.inf
> > > @@ -1,7 +1,7 @@
> > >  ## @file
> > >  #
> > >  #  Copyright 2006 - 2012 Unified EFI, Inc. -#  Copyright (c)
> > > 2010
> > > - 2012, Intel Corporation. All rights reserved.
> > > +#  Copyright (c) 2010 - 2019, Intel Corporation. All rights
> > > reserved.
> > >  #
> > >  #  This program and the accompanying materials  #  are licensed
> > > and
> > > made available under the terms and conditions of the BSD License
> > > @@
> > > -53,4 +53,5 @@
> > > 
> > >  [Protocols]
> > >gEfiTestProfileLibraryGuid
> > > +  gEfiTestRecoveryLibraryGuid
> > >gBlackBoxEfiHIIPackageListProtocolGuid
> > > diff --git a/uefi-
> > > sct/SctPkg/TestCase/UEFI/EFI/BootServices/ImageServices/BlackBoxT
> > > est/
> > > ImageBBTest.h b/uefi-
> > > sct/SctPkg/TestCase/UEFI/EFI/BootServices/ImageServices/BlackBoxT
> > > est/
> > > ImageBBTest.h
> > > index b1c35fee7435..008584577ed1 100644
> > > --- a/uefi-
> > > sct/SctPkg/TestCase/UEFI/EFI/BootServices/ImageServices/BlackBoxT
> > > est/
> > > ImageBBTest.h
> > > +++ b/uefi-
> > > sct/SctPkg/TestCase/UEFI/EFI/BootServices/ImageServices/BlackBoxT
> > > est/
> > > ImageBBTest.h
> > > @@ -1,7 +1,7 @@
> > >  /** @file
> > > 
> > >Copyright 2006 - 2017 Unified EFI, Inc.
> > > -  Copyright (c) 2010 - 2017, Intel Corporation. All rights
> > > reserved.
> > > +  Copyright (c) 2010 - 2019, Intel Corporation. All rights
> > > reserved.
> > > 
> > >Th

Re: [edk2-devel] [edk2-test][Patch 1/1] uefi-sct/SctPkg: Eliminate 2nd execution of ExitBootServices Test

2019-08-21 Thread Supreeth Venkatesh

On Wed, 2019-08-21 at 01:24 -0500, Eric Jin wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2098
Please add the details of the patch to the commit message.
"In the ExitBootServices() test, after ExitBootServices() call, all
boot services are forbidden. The original design is to save the return
status value of ExitBootServices() in variable using variable service
and reset, but this needs multiple execution of the test to retrieve
the value from variable and this design was not straightforward from
end user perspective.

This patch enhances the test by leveraging RecoveryLib to restore
execution after reset automatically, thus requiring only one execution"

More comments inline...

> 
> Cc: Supreeth Venkatesh 
> Signed-off-by: Eric Jin 
> ---
>  uefi-
> sct/SctPkg/TestCase/UEFI/EFI/BootServices/ImageServices/BlackBoxTest/
> ImageBBTest.inf  |  3 ++-
>  uefi-
> sct/SctPkg/TestCase/UEFI/EFI/BootServices/ImageServices/BlackBoxTest/
> ImageBBTest.h|  9 -
>  uefi-
> sct/SctPkg/TestCase/UEFI/EFI/BootServices/ImageServices/BlackBoxTest/
> ImageBBTestConformance.c | 98
> +
> ++---
>  3 files changed, 93 insertions(+), 17 deletions(-)
> 
> diff --git a/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/BootServices/ImageServices/BlackBoxTest/
> ImageBBTest.inf b/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/BootServices/ImageServices/BlackBoxTest/
> ImageBBTest.inf
> index 49ad79915934..3de43a20e8a4 100644
> --- a/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/BootServices/ImageServices/BlackBoxTest/
> ImageBBTest.inf
> +++ b/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/BootServices/ImageServices/BlackBoxTest/
> ImageBBTest.inf
> @@ -1,7 +1,7 @@
>  ## @file
>  #
>  #  Copyright 2006 - 2012 Unified EFI, Inc.
> -#  Copyright (c) 2010 - 2012, Intel Corporation. All rights
> reserved.
> +#  Copyright (c) 2010 - 2019, Intel Corporation. All rights
> reserved.
>  #
>  #  This program and the accompanying materials
>  #  are licensed and made available under the terms and conditions of
> the BSD License
> @@ -53,4 +53,5 @@
>  
>  [Protocols]
>gEfiTestProfileLibraryGuid
> +  gEfiTestRecoveryLibraryGuid
>gBlackBoxEfiHIIPackageListProtocolGuid
> diff --git a/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/BootServices/ImageServices/BlackBoxTest/
> ImageBBTest.h b/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/BootServices/ImageServices/BlackBoxTest/
> ImageBBTest.h
> index b1c35fee7435..008584577ed1 100644
> --- a/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/BootServices/ImageServices/BlackBoxTest/
> ImageBBTest.h
> +++ b/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/BootServices/ImageServices/BlackBoxTest/
> ImageBBTest.h
> @@ -1,7 +1,7 @@
>  /** @file
>  
>Copyright 2006 - 2017 Unified EFI, Inc.
> -  Copyright (c) 2010 - 2017, Intel Corporation. All rights
> reserved.
> +  Copyright (c) 2010 - 2019, Intel Corporation. All rights
> reserved.
>  
>This program and the accompanying materials
>are licensed and made available under the terms and conditions of
> the BSD License
> @@ -35,6 +35,13 @@ Abstract:
>  #include EFI_PROTOCOL_DEFINITION (LoadFile)
>  
>  #include EFI_TEST_PROTOCOL_DEFINITION (TestProfileLibrary)
> +#include EFI_TEST_PROTOCOL_DEFINITION (TestRecoveryLibrary)
> +
> +typedef struct _RESET_DATA {
> +  UINTN   Step;
> +  UINTN   TplIndex;
> +  UINT32  RepeatTimes;
> +} RESET_DATA;
>  
>  #if (EFI_SPECIFICATION_VERSION >= 0x0002000A)
>  
> diff --git a/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/BootServices/ImageServices/BlackBoxTest/
> ImageBBTestConformance.c b/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/BootServices/ImageServices/BlackBoxTest/
> ImageBBTestConformance.c
> index 0a26d46847da..e90afe7ecae0 100644
> --- a/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/BootServices/ImageServices/BlackBoxTest/
> ImageBBTestConformance.c
> +++ b/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/BootServices/ImageServices/BlackBoxTest/
> ImageBBTestConformance.c
> @@ -1,7 +1,7 @@
>  /** @file
>  
>Copyright 2006 - 2016 Unified EFI, Inc.
> -  Copyright (c) 2010 - 2016, Intel Corporation. All rights
> reserved.
> +  Copyright (c) 2010 - 2019, Intel Corporation. All rights
> reserved.
>  
>This program and the accompanying materials
>are licensed and made available under the terms and conditions of
> the BSD License
> @@ -30,7 +30,8 @@ Abstract:
>  #define TEST_VENDOR1_GUID \
>{ 0xF6FAB04F, 0xACAF, 0x4af3, { 0xB9, 0xFA, 0xDC, 0xF9, 0x7F,
> 0xB4, 0x42, 0x6F } }
>  
> -#define MAX_BUFFER_SIZE  10
> +#define STATUS_BUFFER_SIZE   8
Why is the

Re: [edk2-devel] [edk2-test][Patch V2 2/2] uefi-sct/SctPkg: Fix gBlackBoxEfiSimplePointerProtocolGuid value

2019-08-21 Thread Supreeth Venkatesh

On Tue, 2019-08-20 at 20:36 -0500, Eric Jin wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1571
> 
> Cc: Supreeth Venkatesh 
> Signed-off-by: Eric Jin 

  Matches UEFI v2.7 Specification.
  Reviewed-by: Supreeth Venkatesh 
> ---
>  uefi-sct/SctPkg/UEFI/UEFI.dec | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/uefi-sct/SctPkg/UEFI/UEFI.dec b/uefi-
> sct/SctPkg/UEFI/UEFI.dec
> index c05fccdd9c10..e8f04e96f520 100644
> --- a/uefi-sct/SctPkg/UEFI/UEFI.dec
> +++ b/uefi-sct/SctPkg/UEFI/UEFI.dec
> @@ -164,7 +164,7 @@
>gBlackBoxEfiSerialIoProtocolGuid = { 0xBB25CF6F, 0xF1D4, 0x11D2, {
> 0x9A, 0x0C, 0x00, 0x90, 0x27, 0x3F, 0xC1, 0xFD }}
>gBlackBoxEfiSimpleFileSystemProtocolGuid = { 0x964e5b22, 0x6459,
> 0x11d2, { 0x8e, 0x39, 0x0, 0xa0, 0xc9, 0x69, 0x72, 0x3b }}
>gBlackBoxEfiSimpleNetworkProtocolGuid = { 0xA19832B9, 0xAC25,
> 0x11D3, { 0x9A, 0x2D, 0x00, 0x90, 0x27, 0x3F, 0xC1, 0x4D }}
> -  gBlackBoxEfiSimplePointerProtocolGuid = { 0xA19832B9, 0xAC25,
> 0x11D3, { 0x9A, 0x2D, 0x00, 0x90, 0x27, 0x3F, 0xC1, 0x4D }}
> +  gBlackBoxEfiSimplePointerProtocolGuid = { 0x31878c87, 0xb75,
> 0x11d5, { 0x9a, 0x4f, 0x00, 0x90, 0x27, 0x3f, 0xc1, 0x4d }}
>gBlackBoxEfiSimpleTextInProtocolGuid = { 0x387477c1, 0x69c7,
> 0x11d2, {0x8e, 0x39, 0x0, 0xa0, 0xc9, 0x69, 0x72, 0x3b }}
>gBlackBoxEfiSimpleTextInputExProtocolGuid = { 0xdd9e7534, 0x7762,
> 0x4698, { 0x8c, 0x14, 0xf5, 0x85, 0x17, 0xa6, 0x25, 0xaa }}
>gBlackBoxEfiSimpleTextOutProtocolGuid = { 0x387477C2, 0x69C7,
> 0x11D2, { 0x8E, 0x39, 0x00, 0xA0, 0xC9, 0x69, 0x72, 0x3B }}


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#46163): https://edk2.groups.io/g/devel/message/46163
Mute This Topic: https://groups.io/mt/32974102/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-test][Patch V2 1/2] uefi-sct/SctPkg: Convert EOL of UEFI.dec to CRLF

2019-08-21 Thread Supreeth Venkatesh

On Tue, 2019-08-20 at 20:36 -0500, Eric Jin wrote:
> Cc: Supreeth Venkatesh 
> Signed-off-by: Eric Jin 
Reviewed-by: Supreeth Venkatesh 

> ---
>  uefi-sct/SctPkg/UEFI/UEFI.dec | 206 +---
> --
>  1 file changed, 103 insertions(+), 103 deletions(-)
> 
> diff --git a/uefi-sct/SctPkg/UEFI/UEFI.dec b/uefi-
> sct/SctPkg/UEFI/UEFI.dec
> index bdf3323fc2da..c05fccdd9c10 100644
> --- a/uefi-sct/SctPkg/UEFI/UEFI.dec
> +++ b/uefi-sct/SctPkg/UEFI/UEFI.dec
> @@ -1,8 +1,8 @@
>  ## @file
>  #
>  #  Copyright 2004 - 2017 Unified EFI, Inc.
> -#  Copyright (c) 2014 - 2019, ARM Limited. All rights reserved.
> -#  Copyright (c) 2016 - 2018, Intel Corporation. All rights
> reserved.
> +#  Copyright (c) 2014 - 2019, ARM Limited. All rights reserved.
> +#  Copyright (c) 2016 - 2019, Intel Corporation. All rights
> reserved.
>  #  (C) Copyright 2017 Hewlett Packard Enterprise Development LP
>  #
>  #  This program and the accompanying materials
> @@ -44,25 +44,25 @@
>
>  
>  [Guids.common]
> -  gBlackBoxEfiFileInfoGuid = { 0x9576e92, 0x6d3f, 0x11d2, { 0x8e,
> 0x39, 0x0, 0xa0, 0xc9, 0x69, 0x72, 0x3b }}
> -  gBlackBoxEfiFileInfoIdGuid = { 0x9576e93, 0x6d3f, 0x11d2, { 0x8e,
> 0x39, 0x0, 0xa0, 0xc9, 0x69, 0x72, 0x3b }}
> +  gBlackBoxEfiFileInfoGuid = { 0x9576e92, 0x6d3f, 0x11d2, { 0x8e,
> 0x39, 0x0, 0xa0, 0xc9, 0x69, 0x72, 0x3b }}
> +  gBlackBoxEfiFileInfoIdGuid = { 0x9576e93, 0x6d3f, 0x11d2, { 0x8e,
> 0x39, 0x0, 0xa0, 0xc9, 0x69, 0x72, 0x3b }}
>gBlackBoxEfiFileSystemInfoGuid = { 0x09576E93, 0x6D3F, 0x11D2, {
> 0x8E, 0x39, 0x00, 0xA0, 0xC9, 0x69, 0x72, 0x3B }}
> -  gBlackBoxEfiFileSystemVolumeLabelInfoIdGuid = { 0xDB47D7D3,
> 0xFE81, 0x11d3, { 0x9A, 0x35, 0x00, 0x90, 0x27, 0x3F, 0xC1, 0x4D }}
> -  gBlackBoxEfiTcp4RegistryDataGuid = { 0x755B4303, 0xCAA5, 0x4481, {
> 0xB1, 0x3D, 0x07, 0xBE, 0x14, 0xD5, 0x4D, 0x3F }}
> -  gBlackBoxEfiTcp6RegistryDataGuid = { 0x80623540, 0x7B41, 0x4306, {
> 0x99, 0x87, 0x1B, 0xF6, 0xE5, 0xAD, 0x15, 0x3E }}
> +  gBlackBoxEfiFileSystemVolumeLabelInfoIdGuid = { 0xDB47D7D3,
> 0xFE81, 0x11d3, { 0x9A, 0x35, 0x00, 0x90, 0x27, 0x3F, 0xC1, 0x4D }}
> +  gBlackBoxEfiTcp4RegistryDataGuid = { 0x755B4303, 0xCAA5, 0x4481, {
> 0xB1, 0x3D, 0x07, 0xBE, 0x14, 0xD5, 0x4D, 0x3F }}
> +  gBlackBoxEfiTcp6RegistryDataGuid = { 0x80623540, 0x7B41, 0x4306, {
> 0x99, 0x87, 0x1B, 0xF6, 0xE5, 0xAD, 0x15, 0x3E }}
>gBlackBoxEfiPcAnsiGuid = { 0xE0C14753, 0xF9BE, 0x11D2, { 0x9A,
> 0x0C, 0x00, 0x90, 0x27, 0x3F, 0xC1, 0x4D }}
>gBlackBoxEfiVT100Guid = { 0xDFA66065, 0xB419, 0x11D3, { 0x9A,
> 0x2D, 0x00, 0x90, 0x27, 0x3F, 0xC1, 0x4D }}
>gBlackBoxEfiVT100PlusGuid = { 0x7BAEC70B, 0x57E0, 0x4C76, { 0x8E,
> 0x87, 0x2F, 0x9E, 0x28, 0x08, 0x83, 0x43 }}
>gBlackBoxEfiVTUTF8Guid = { 0xAD15A0D6, 0x8BEC, 0x4ACF, { 0xA0,
> 0x73, 0xD0, 0x1D, 0xE7, 0x7E, 0x2D, 0x88 }}
>  
> -  gBlackBoxEfiHash2AlgorithmSha1Guid = { 0x2ae9d80f, 0x3fb2, 0x4095,
> { 0xb7, 0xb1, 0xe9, 0x31, 0x57, 0xb9, 0x46, 0xb6 }}
> -  gBlackBoxEfiHash2AlgorithmSha224Guid = { 0x8df01a06, 0x9bd5,
> 0x4bf7, { 0xb0, 0x21, 0xdb, 0x4f, 0xd9, 0xcc, 0xf4, 0x5b }}
> -  gBlackBoxEfiHash2AlgorithmSha256Guid = { 0x51aa59de, 0xfdf2,
> 0x4ea3, { 0xbc, 0x63, 0x87, 0x5f, 0xb7, 0x84, 0x2e, 0xe9 }}
> -  gBlackBoxEfiHash2AlgorithmSha384Guid = { 0xefa96432, 0xde33,
> 0x4dd2, { 0xae, 0xe6, 0x32, 0x8c, 0x33, 0xdf, 0x77, 0x7a }}
> -  gBlackBoxEfiHash2AlgorithmSha512Guid = { 0xcaa4381e, 0x750c,
> 0x4770, { 0xb8, 0x70, 0x7a, 0x23, 0xb4, 0xe4, 0x21, 0x30 }}
> -  gBlackBoxEfiHash2AlgorithmMD5Guid = { 0xaf7c79c, 0x65b5, 0x4319, {
> 0xb0, 0xae, 0x44, 0xec, 0x48, 0x4e, 0x4a, 0xd7 }}
> -  gBlackBoxEfiHash2AlgorithmSha1NoPadGuid = { 0x24c5dc2f, 0x53e2,
> 0x40ca, { 0x9e, 0xd6, 0xa5, 0xd9, 0xa4, 0x9f, 0x46, 0x3b }}
> -  gBlackBoxEfiHash2AlgorithmSha256NoPadGuid = { 0x8628752a, 0x6cb7,
> 0x4814, { 0x96, 0xfc, 0x24, 0xa8, 0x15, 0xac, 0x22, 0x26 }}
> +  gBlackBoxEfiHash2AlgorithmSha1Guid = { 0x2ae9d80f, 0x3fb2, 0x4095,
> { 0xb7, 0xb1, 0xe9, 0x31, 0x57, 0xb9, 0x46, 0xb6 }}
> +  gBlackBoxEfiHash2AlgorithmSha224Guid = { 0x8df01a06, 0x9bd5,
> 0x4bf7, { 0xb0, 0x21, 0xdb, 0x4f, 0xd9, 0xcc, 0xf4, 0x5b }}
> +  gBlackBoxEfiHash2AlgorithmSha256Guid = { 0x51aa59de, 0xfdf2,
> 0x4ea3, { 0xbc, 0x63, 0x87, 0x5f, 0xb7, 0x84, 0x2e, 0xe9 }}
> +  gBlackBoxEfiHash2AlgorithmSha384Guid = { 0xefa96432, 0xde33,
> 0x4dd2, { 0xae, 0xe6, 0x32, 0x8c, 0x33, 0xdf, 0x77, 0x7a }}
> +  gBlackBoxEfiHash2AlgorithmSha512Guid = { 0xcaa4381e, 0x750c,
> 0x4770, { 0xb8, 0x70, 0x7a, 0x23, 0xb4, 0xe4, 0x21, 0x30 }}
> +  gBlackBoxEfiHash2AlgorithmMD5Guid = { 0xaf7c79c, 0x65b5, 0x4319, {
> 0xb0, 0xae, 0x44, 0xec, 0x48, 0x4e, 0x4a, 0xd7 }}
> +  gBlackBoxEfiHash2AlgorithmSha1NoPadGuid = { 0x24c5dc2f, 0x53e2,
> 0x40ca, { 0x9e, 0xd6, 0xa5, 0xd9, 0xa4,

Re: [edk2-devel] [edk2-test][Patch 1/1] uefi-sct/SctPkg: Fix the gBlackBoxEfiSimplePointerProtocolGuid value

2019-08-20 Thread Supreeth Venkatesh

Hi Eric,

Comments inline.

On Tue, 2019-08-20 at 00:07 -0500, Eric Jin wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1571
> Besides, EOL is converted to CRLF.
If you mix EOL conversion to CRLF and bug fix for
gBlackBoxEfiSimplePointerProtocolGuid, it is difficult to review the
actual change. Please split them into 2
1. EOL to CRLF conversion.
2. gBlackBoxEfiSimplePointerProtocolGuid change.
I have no other comments on this.

Thanks,
Supreeth

> 
> Cc: Supreeth Venkatesh 
> Signed-off-by: Eric Jin 
> ---
>  uefi-sct/SctPkg/UEFI/UEFI.dec | 206 +---
> --
>  1 file changed, 103 insertions(+), 103 deletions(-)
> 
> diff --git a/uefi-sct/SctPkg/UEFI/UEFI.dec b/uefi-
> sct/SctPkg/UEFI/UEFI.dec
> index bdf3323fc2da..e8f04e96f520 100644
> --- a/uefi-sct/SctPkg/UEFI/UEFI.dec
> +++ b/uefi-sct/SctPkg/UEFI/UEFI.dec
> @@ -1,8 +1,8 @@
>  ## @file
>  #
>  #  Copyright 2004 - 2017 Unified EFI, Inc.
> -#  Copyright (c) 2014 - 2019, ARM Limited. All rights reserved.
> -#  Copyright (c) 2016 - 2018, Intel Corporation. All rights
> reserved.
> +#  Copyright (c) 2014 - 2019, ARM Limited. All rights reserved.
> +#  Copyright (c) 2016 - 2019, Intel Corporation. All rights
> reserved.
>  #  (C) Copyright 2017 Hewlett Packard Enterprise Development LP
>  #
>  #  This program and the accompanying materials
> @@ -44,25 +44,25 @@
>
>  
>  [Guids.common]
> -  gBlackBoxEfiFileInfoGuid = { 0x9576e92, 0x6d3f, 0x11d2, { 0x8e,
> 0x39, 0x0, 0xa0, 0xc9, 0x69, 0x72, 0x3b }}
> -  gBlackBoxEfiFileInfoIdGuid = { 0x9576e93, 0x6d3f, 0x11d2, { 0x8e,
> 0x39, 0x0, 0xa0, 0xc9, 0x69, 0x72, 0x3b }}
> +  gBlackBoxEfiFileInfoGuid = { 0x9576e92, 0x6d3f, 0x11d2, { 0x8e,
> 0x39, 0x0, 0xa0, 0xc9, 0x69, 0x72, 0x3b }}
> +  gBlackBoxEfiFileInfoIdGuid = { 0x9576e93, 0x6d3f, 0x11d2, { 0x8e,
> 0x39, 0x0, 0xa0, 0xc9, 0x69, 0x72, 0x3b }}
>gBlackBoxEfiFileSystemInfoGuid = { 0x09576E93, 0x6D3F, 0x11D2, {
> 0x8E, 0x39, 0x00, 0xA0, 0xC9, 0x69, 0x72, 0x3B }}
> -  gBlackBoxEfiFileSystemVolumeLabelInfoIdGuid = { 0xDB47D7D3,
> 0xFE81, 0x11d3, { 0x9A, 0x35, 0x00, 0x90, 0x27, 0x3F, 0xC1, 0x4D }}
> -  gBlackBoxEfiTcp4RegistryDataGuid = { 0x755B4303, 0xCAA5, 0x4481, {
> 0xB1, 0x3D, 0x07, 0xBE, 0x14, 0xD5, 0x4D, 0x3F }}
> -  gBlackBoxEfiTcp6RegistryDataGuid = { 0x80623540, 0x7B41, 0x4306, {
> 0x99, 0x87, 0x1B, 0xF6, 0xE5, 0xAD, 0x15, 0x3E }}
> +  gBlackBoxEfiFileSystemVolumeLabelInfoIdGuid = { 0xDB47D7D3,
> 0xFE81, 0x11d3, { 0x9A, 0x35, 0x00, 0x90, 0x27, 0x3F, 0xC1, 0x4D }}
> +  gBlackBoxEfiTcp4RegistryDataGuid = { 0x755B4303, 0xCAA5, 0x4481, {
> 0xB1, 0x3D, 0x07, 0xBE, 0x14, 0xD5, 0x4D, 0x3F }}
> +  gBlackBoxEfiTcp6RegistryDataGuid = { 0x80623540, 0x7B41, 0x4306, {
> 0x99, 0x87, 0x1B, 0xF6, 0xE5, 0xAD, 0x15, 0x3E }}
>gBlackBoxEfiPcAnsiGuid = { 0xE0C14753, 0xF9BE, 0x11D2, { 0x9A,
> 0x0C, 0x00, 0x90, 0x27, 0x3F, 0xC1, 0x4D }}
>gBlackBoxEfiVT100Guid = { 0xDFA66065, 0xB419, 0x11D3, { 0x9A,
> 0x2D, 0x00, 0x90, 0x27, 0x3F, 0xC1, 0x4D }}
>gBlackBoxEfiVT100PlusGuid = { 0x7BAEC70B, 0x57E0, 0x4C76, { 0x8E,
> 0x87, 0x2F, 0x9E, 0x28, 0x08, 0x83, 0x43 }}
>gBlackBoxEfiVTUTF8Guid = { 0xAD15A0D6, 0x8BEC, 0x4ACF, { 0xA0,
> 0x73, 0xD0, 0x1D, 0xE7, 0x7E, 0x2D, 0x88 }}
>  
> -  gBlackBoxEfiHash2AlgorithmSha1Guid = { 0x2ae9d80f, 0x3fb2, 0x4095,
> { 0xb7, 0xb1, 0xe9, 0x31, 0x57, 0xb9, 0x46, 0xb6 }}
> -  gBlackBoxEfiHash2AlgorithmSha224Guid = { 0x8df01a06, 0x9bd5,
> 0x4bf7, { 0xb0, 0x21, 0xdb, 0x4f, 0xd9, 0xcc, 0xf4, 0x5b }}
> -  gBlackBoxEfiHash2AlgorithmSha256Guid = { 0x51aa59de, 0xfdf2,
> 0x4ea3, { 0xbc, 0x63, 0x87, 0x5f, 0xb7, 0x84, 0x2e, 0xe9 }}
> -  gBlackBoxEfiHash2AlgorithmSha384Guid = { 0xefa96432, 0xde33,
> 0x4dd2, { 0xae, 0xe6, 0x32, 0x8c, 0x33, 0xdf, 0x77, 0x7a }}
> -  gBlackBoxEfiHash2AlgorithmSha512Guid = { 0xcaa4381e, 0x750c,
> 0x4770, { 0xb8, 0x70, 0x7a, 0x23, 0xb4, 0xe4, 0x21, 0x30 }}
> -  gBlackBoxEfiHash2AlgorithmMD5Guid = { 0xaf7c79c, 0x65b5, 0x4319, {
> 0xb0, 0xae, 0x44, 0xec, 0x48, 0x4e, 0x4a, 0xd7 }}
> -  gBlackBoxEfiHash2AlgorithmSha1NoPadGuid = { 0x24c5dc2f, 0x53e2,
> 0x40ca, { 0x9e, 0xd6, 0xa5, 0xd9, 0xa4, 0x9f, 0x46, 0x3b }}
> -  gBlackBoxEfiHash2AlgorithmSha256NoPadGuid = { 0x8628752a, 0x6cb7,
> 0x4814, { 0x96, 0xfc, 0x24, 0xa8, 0x15, 0xac, 0x22, 0x26 }}
> +  gBlackBoxEfiHash2AlgorithmSha1Guid = { 0x2ae9d80f, 0x3fb2, 0x4095,
> { 0xb7, 0xb1, 0xe9, 0x31, 0x57, 0xb9, 0x46, 0xb6 }}
> +  gBlackBoxEfiHash2AlgorithmSha224Guid = { 0x8df01a06, 0x9bd5,
> 0x4bf7, { 0xb0, 0x21, 0xdb, 0x4f, 0xd9, 0xcc, 0xf4, 0x5b }}
> +  gBlackBoxEfiHash2AlgorithmSha256Guid = { 0x51aa59de, 0xfdf2,
> 0x4ea3, { 0xbc, 0x63, 0x87, 0x5f, 0xb7, 0x84, 0x2e, 0xe9 }}
> +  gBlackBoxEfiHash2AlgorithmSha384Guid = { 0xefa96432, 0xde33,
> 0x4dd2, { 0xae, 0xe6, 0x32, 0x8c, 0x33, 0xdf, 0

Re: [edk2-devel] [edk2-test][Patch 1/1] Library/SctLib: Remove Ipf source files from inf file

2019-06-14 Thread Supreeth Venkatesh

Reviewed-by: Supreeth Venkatesh 

-Original Message-
From: Eric Jin 
Sent: Friday, June 14, 2019 1:06 AM
To: devel@edk2.groups.io
Cc: Supreeth Venkatesh 
Subject: [edk2-test][Patch 1/1] Library/SctLib: Remove Ipf source files from 
inf file

Remove source and header files required for building Ipf library from inf file 
as edk2 (edk2-stable201905) has removed IPF support.

Cc: Supreeth Venkatesh 
Signed-off-by: Eric Jin 
---
 uefi-sct/SctPkg/Library/SctLib/SctLib.inf | 9 +
 1 file changed, 1 insertion(+), 8 deletions(-)

diff --git a/uefi-sct/SctPkg/Library/SctLib/SctLib.inf 
b/uefi-sct/SctPkg/Library/SctLib/SctLib.inf
index 6db9ae091cc3..ff6ce5796424 100644
--- a/uefi-sct/SctPkg/Library/SctLib/SctLib.inf
+++ b/uefi-sct/SctPkg/Library/SctLib/SctLib.inf
@@ -2,7 +2,7 @@
 #
 #  Copyright 2006 - 2016 Unified EFI, Inc.  #  Copyright (c) 2013 - 2014, 
ARM Ltd. All rights reserved. -#  Copyright (c) 2014 - 2016, Intel 
Corporation. All rights reserved.
+#  Copyright (c) 2014 - 2019, Intel Corporation. All rights
+reserved.
 #
 #  This program and the accompanying materials  #  are licensed and made 
available under the terms and conditions of the BSD License @@ -71,13 +71,6 @@
   ia32/MultU64x32.S | GCC
   ia32/DivU64x32.S | GCC

-[sources.ipf]
-  Ipf/SctLibPlat.h
-  Ipf/initplat.c
-  Ipf/salpal.c
-  Ipf/libsalpal.h
-  Math.c
-
 [sources.ebc]
   ebc/SctLibPlat.h
   ebc/EfiLibPlat.c
--
2.20.0.windows.1

IMPORTANT NOTICE: The contents of this email and any attachments are 
confidential and may also be privileged. If you are not the intended recipient, 
please notify the sender immediately and do not disclose the contents to any 
other person, use it for any purpose, or store or copy the information in any 
medium. Thank you.

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#42441): https://edk2.groups.io/g/devel/message/42441
Mute This Topic: https://groups.io/mt/32061168/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [edk2-test][PATCH v1 4/5] SctLib: Remove Ipf source files

2019-06-12 Thread Supreeth Venkatesh

Remove all files required for building Ipf Sct library as edk2
(edk2-stable201905) has removed IPF support.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Supreeth Venkatesh 
---
 uefi-sct/SctPkg/Library/SctLib/Ipf/PalApi.h   | 138 
 uefi-sct/SctPkg/Library/SctLib/Ipf/SalApi.h   | 728 --
 .../SctPkg/Library/SctLib/Ipf/SctLibPlat.h|  32 -
 uefi-sct/SctPkg/Library/SctLib/Ipf/initplat.c |  37 -
 .../SctPkg/Library/SctLib/Ipf/libsalpal.h |  87 ---
 uefi-sct/SctPkg/Library/SctLib/Ipf/salpal.c   | 297 ---
 6 files changed, 1319 deletions(-)
 delete mode 100644 uefi-sct/SctPkg/Library/SctLib/Ipf/PalApi.h
 delete mode 100644 uefi-sct/SctPkg/Library/SctLib/Ipf/SalApi.h
 delete mode 100644 uefi-sct/SctPkg/Library/SctLib/Ipf/SctLibPlat.h
 delete mode 100644 uefi-sct/SctPkg/Library/SctLib/Ipf/initplat.c
 delete mode 100644 uefi-sct/SctPkg/Library/SctLib/Ipf/libsalpal.h
 delete mode 100644 uefi-sct/SctPkg/Library/SctLib/Ipf/salpal.c

diff --git a/uefi-sct/SctPkg/Library/SctLib/Ipf/PalApi.h 
b/uefi-sct/SctPkg/Library/SctLib/Ipf/PalApi.h
deleted file mode 100644
index 4b21ffb7..
--- a/uefi-sct/SctPkg/Library/SctLib/Ipf/PalApi.h
+++ /dev/null
@@ -1,138 +0,0 @@
-/** @file
-
-  Copyright 2006 - 2010 Unified EFI, Inc.
-  Copyright (c) 2010, Intel Corporation. All rights reserved.
-
-  This program and the accompanying materials
-  are licensed and made available under the terms and conditions of the BSD 
License
-  which accompanies this distribution.  The full text of the license may be 
found at 
-  http://opensource.org/licenses/bsd-license.php
- 
-  THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
-  WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
- 
-**/
-/*++
-
-Module Name:
-
-  PalApi.h
-
-Abstract:
-
-  Main PAL API's defined in PAL specification. 
-
-
-Revision History:
-
---*/
-
-#ifndef _PALPROC_H
-#define _PALPROC_H
-
-//#include "Tiano.h"
-
-#define PAL_CACHE_FLUSH   0x0001
-#define PAL_CACHE_INFO0x0002
-#define PAL_CACHE_INIT0x0003
-#define PAL_CACHE_SUMMARY 0x0004
-#define PAL_MEM_ATTRIB0x0005
-#define PAL_PTCE_INFO 0x0006
-#define PAL_VM_INFO   0x0007
-#define PAL_VM_SUMMARY0x0008
-#define PAL_BUS_GET_FEATURES  0x0009
-#define PAL_BUS_SET_FEATURES  0x000a
-#define PAL_DEBUG_INFO0x000b
-#define PAL_FIXED_ADDR0x000c
-#define PAL_FREQ_BASE 0x000d
-#define PAL_FREQ_RATIOS   0x000e
-#define PAL_PERF_MON_INFO 0x000f
-#define PAL_PLATFORM_ADDR 0x0010
-#define PAL_PROC_GET_FEATURES 0x0011
-#define PAL_PROC_SET_FEATURES 0x0012
-#define PAL_RSE_INFO  0x0013
-#define PAL_VERSION   0x0014
-
-#define PAL_MC_CLEAR_LOG  0x0015
-#define PAL_MC_DRAIN  0x0016
-#define PAL_MC_EXPECTED   0x0017
-#define PAL_MC_DYNAMIC_STATE  0x0018
-#define PAL_MC_ERROR_INFO 0x0019
-#define PAL_MC_RESUME 0x001a
-#define PAL_MC_REGISTER_MEM   0x001b
-#define PAL_HALT  0x001c
-#define PAL_HALT_LIGHT0x001d
-#define PAL_COPY_INFO 0x001e
-#define PAL_SHUTDOWN  0x002c
-#define PAL_AUTH  0x0209
-#define PAL_SINGL_DISPERSAL   0x0226  // dec. 550
-#define PAL_HALT_INFO 0x0101
-#define PAL_CACHE_LINE_INIT   0x001f
-#define PAL_PMI_ENTRYPOINT0x0020
-#define PAL_ENTER_IA_32_ENV   0x0021
-#define PAL_VM_PAGE_SIZE  0x0022
-#define PAL_MEM_FOR_TEST  0x0025
-#define PAL_CACHE_PROT_INFO   0x0026
-
-#define PAL_COPY_PAL  0x0100
-#define PAL_CACHE_READ0x0103
-#define PAL_CACHE_WRITE   0x0104
-#define PAL_TEST_PROC 0x0102
-
-#define PAL_DEBUG_FEATURE 0x0063  // vp1
-typedef UINT64  EFI_PAL_STATUS;
-
-//
-//  Return values from PAL
-//
-typedef struct {
-  EFI_PAL_STATUS  Status; // register r8
-  UINT64  r9;
-  UINT64  r10;
-  UINT64  r11;
-} PAL_RETURN_REGS;
-
-//
-// PAL equates for other parameters.
-//
-#define PAL_SUCCESS 0x0
-#define PAL_CALL_ERROR  0xfffd
-#define PAL_CALL_UNIMPLEMENTED  0x
-#define PAL_CACHE_TYPE_I0x1
-#define PAL_CACHE_TYPE_D0x2
-#define PAL_CACHE_TYPE_I_AND_D  0x3
-#define PAL_CACHE_NO_INT0x0
-#define PAL_CACHE_INT   0x2
-//
-// #define PAL_CACHE_PLAT_ACK  0x4
-//
-#define PAL_CACHE_NO_PLAT_ACK   0x0
-#define PAL_CACHE_INVALIDATE0x1
-#define PAL_CACHE_NO_INVALIDATE 0x0
-#define PAL_CACHE_ALL_LEVELS- 0x1
-
-#define PAL_FEATURE_ENABLE  0x1
-#define PAL_ENABLE_BERR_BIT 63
-#define PAL_ENABLE_MCA_BINIT_BIT61
-#define PAL_ENABLE_CMCI_MCA_BIT 60
-#define PAL_CACHE_DISABLE_BIT   59
-#define PAL_DISABLE_COHERENCY_BIT   58
-
-#define PAL_DIS_BUS_DATA_ERR_CHECK_BIT  63
-#define PAL_DIS_BUS_ADDR_ERR_CHECK_

[edk2-devel] [edk2-test][PATCH v1 5/5] EasLib: Remove files required for building Ipf

2019-06-12 Thread Supreeth Venkatesh

Remove all files required for building Ipf Eas library as edk2
(edk2-stable201905) has removed IPF support.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Supreeth Venkatesh 
---
 .../Framework/ENTS/EasLib/Ipf/EntsLibPlat.h   |  55 --
 .../SCT/Framework/ENTS/EasLib/Ipf/InitPlat.c  |  54 --
 .../SCT/Framework/ENTS/EasLib/Ipf/LibSalPal.h | 182 -
 .../SCT/Framework/ENTS/EasLib/Ipf/PalApi.h| 137 
 .../SCT/Framework/ENTS/EasLib/Ipf/SalApi.h| 728 --
 .../SCT/Framework/ENTS/EasLib/Ipf/SalPal.c| 369 -
 6 files changed, 1525 deletions(-)
 delete mode 100644 
uefi-sct/SctPkg/TestInfrastructure/SCT/Framework/ENTS/EasLib/Ipf/EntsLibPlat.h
 delete mode 100644 
uefi-sct/SctPkg/TestInfrastructure/SCT/Framework/ENTS/EasLib/Ipf/InitPlat.c
 delete mode 100644 
uefi-sct/SctPkg/TestInfrastructure/SCT/Framework/ENTS/EasLib/Ipf/LibSalPal.h
 delete mode 100644 
uefi-sct/SctPkg/TestInfrastructure/SCT/Framework/ENTS/EasLib/Ipf/PalApi.h
 delete mode 100644 
uefi-sct/SctPkg/TestInfrastructure/SCT/Framework/ENTS/EasLib/Ipf/SalApi.h
 delete mode 100644 
uefi-sct/SctPkg/TestInfrastructure/SCT/Framework/ENTS/EasLib/Ipf/SalPal.c

diff --git 
a/uefi-sct/SctPkg/TestInfrastructure/SCT/Framework/ENTS/EasLib/Ipf/EntsLibPlat.h
 
b/uefi-sct/SctPkg/TestInfrastructure/SCT/Framework/ENTS/EasLib/Ipf/EntsLibPlat.h
deleted file mode 100644
index f0060614..
--- 
a/uefi-sct/SctPkg/TestInfrastructure/SCT/Framework/ENTS/EasLib/Ipf/EntsLibPlat.h
+++ /dev/null
@@ -1,55 +0,0 @@
-/** @file
-
-  Copyright 2006 - 2010 Unified EFI, Inc.
-  Copyright (c) 2010, Intel Corporation. All rights reserved.
-
-  This program and the accompanying materials
-  are licensed and made available under the terms and conditions of the BSD 
License
-  which accompanies this distribution.  The full text of the license may be 
found at 
-  http://opensource.org/licenses/bsd-license.php
- 
-  THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
-  WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
- 
-**/
-/*++
-
-Module Name:
-
-  EntsLibPlat.h
-
-Abstract:
-
-  IPF specific defines
-
---*/
-
-#ifndef _EFI_LIB_PLAT_H
-#define _EFI_LIB_PLAT_H
-
-#define MIN_ALIGNMENT_SIZE  8
-
-VOID
-EntsInitializeLibPlatform (
-  IN EFI_HANDLE   ImageHandle,
-  IN EFI_SYSTEM_TABLE *SystemTable
-  )
-/*++
-
-Routine Description:
-
-  Initialize platform.
-
-Arguments:
-
-  ImageHandle   - The image handle.
-  SystemTable   - The system table.
-
-Returns:
-
-  None.
-
---*/
-;
-
-#endif
diff --git 
a/uefi-sct/SctPkg/TestInfrastructure/SCT/Framework/ENTS/EasLib/Ipf/InitPlat.c 
b/uefi-sct/SctPkg/TestInfrastructure/SCT/Framework/ENTS/EasLib/Ipf/InitPlat.c
deleted file mode 100644
index fd62..
--- 
a/uefi-sct/SctPkg/TestInfrastructure/SCT/Framework/ENTS/EasLib/Ipf/InitPlat.c
+++ /dev/null
@@ -1,54 +0,0 @@
-/** @file
-
-  Copyright 2006 - 2010 Unified EFI, Inc.
-  Copyright (c) 2010, Intel Corporation. All rights reserved.
-
-  This program and the accompanying materials
-  are licensed and made available under the terms and conditions of the BSD 
License
-  which accompanies this distribution.  The full text of the license may be 
found at 
-  http://opensource.org/licenses/bsd-license.php
- 
-  THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
-  WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
- 
-**/
-/*++
-
-Module Name:
-
-  InitPlat.c
-
-Abstract:
-
-  Functions to make SAL and PAL proc calls
-
---*/
-
-#include "Efi.h"
-#include "EntsLibPlat.h"
-#include "LibSalPal.h"
-
-VOID
-EntsInitializeLibPlatform (
-  IN EFI_HANDLE   ImageHandle,
-  IN EFI_SYSTEM_TABLE *SystemTable
-  )
-/*++
-
-Routine Description:
-
-  Initialize platform.
-
-Arguments:
-
-  ImageHandle   - The image handle.
-  SystemTable   - The system table.
-
-Returns:
-
-  None.
-
---*/
-{
-  LibInitSalAndPalProc ();
-}
diff --git 
a/uefi-sct/SctPkg/TestInfrastructure/SCT/Framework/ENTS/EasLib/Ipf/LibSalPal.h 
b/uefi-sct/SctPkg/TestInfrastructure/SCT/Framework/ENTS/EasLib/Ipf/LibSalPal.h
deleted file mode 100644
index 78d96d59..
--- 
a/uefi-sct/SctPkg/TestInfrastructure/SCT/Framework/ENTS/EasLib/Ipf/LibSalPal.h
+++ /dev/null
@@ -1,182 +0,0 @@
-/** @file
-
-  Copyright 2006 - 2010 Unified EFI, Inc.
-  Copyright (c) 2010, Intel Corporation. All rights reserved.
-
-  This program and the accompanying materials
-  are licensed and made available under the terms and conditions of the BSD 
License
-  which accompanies this distribution.  The full text of the license may be 
found at 
-  http://opensource.org/licenses/bsd-license.php
- 
-  THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
-  WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
- 
-**/
-/*++
-
-Module Name:
-
-

[edk2-devel] [edk2-test][PATCH v1 3/5] Framework/EntsLib: Remove Ipf source files from inf file

2019-06-12 Thread Supreeth Venkatesh

Remove source and header files required for building Ipf library from
inf file as edk2 (edk2-stable201905) has removed IPF support.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Supreeth Venkatesh 
---
 .../SCT/Framework/ENTS/EasLib/EntsLib.inf  | 7 +--
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git 
a/uefi-sct/SctPkg/TestInfrastructure/SCT/Framework/ENTS/EasLib/EntsLib.inf 
b/uefi-sct/SctPkg/TestInfrastructure/SCT/Framework/ENTS/EasLib/EntsLib.inf
index c38c620a..23f12d1a 100644
--- a/uefi-sct/SctPkg/TestInfrastructure/SCT/Framework/ENTS/EasLib/EntsLib.inf
+++ b/uefi-sct/SctPkg/TestInfrastructure/SCT/Framework/ENTS/EasLib/EntsLib.inf
@@ -2,6 +2,7 @@
 #
 #  Copyright 2006 - 2012 Unified EFI, Inc.
 #  Copyright (c) 2010 - 2012, Intel Corporation. All rights reserved.
+#  Copyright (c) 2019, ARM Ltd. All rights reserved.
 #
 #  This program and the accompanying materials
 #  are licensed and made available under the terms and conditions of the BSD 
License
@@ -49,12 +50,6 @@
   Ia32/EntsLibPlat.h
   Ia32/InitPlat.c
 
-[sources.ipf]
-  Ipf/EntsLibPlat.h
-  Ipf/InitPlat.c
-  Ipf/SalPal.c
-  Ipf/LibSalPal.h
-
 [sources.ebc]
   Ebc/EntsLibPlat.h
   Ebc/EfiLibPlat.c
-- 
2.17.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#42309): https://edk2.groups.io/g/devel/message/42309
Mute This Topic: https://groups.io/mt/32045155/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [edk2-test][PATCH v1 1/5] Library/EntsLib: Remove references to SalSystemTable

2019-06-12 Thread Supreeth Venkatesh

Remove references to SalSystemTable and gtEfiSalSystemTableGuid as edk2
(edk2-stable201905) has removed IPF support.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Supreeth Venkatesh 
---
 uefi-sct/SctPkg/Include/Library/EntsLib.h | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/uefi-sct/SctPkg/Include/Library/EntsLib.h 
b/uefi-sct/SctPkg/Include/Library/EntsLib.h
index f7c03cf5..f29779c0 100644
--- a/uefi-sct/SctPkg/Include/Library/EntsLib.h
+++ b/uefi-sct/SctPkg/Include/Library/EntsLib.h
@@ -2,6 +2,7 @@
 
   Copyright 2006 - 2013 Unified EFI, Inc.
   Copyright (c) 2010 - 2013, Intel Corporation. All rights reserved.
+  Copyright (c) 2019, ARM Ltd. All rights reserved.
 
   This program and the accompanying materials
   are licensed and made available under the terms and conditions of the BSD 
License
@@ -69,7 +70,6 @@ Abstract:
 #include EFI_GUID_DEFINITION (Mps)
 #include EFI_GUID_DEFINITION (Acpi)
 #include EFI_GUID_DEFINITION (SmBios)
-#include EFI_GUID_DEFINITION (SalSystemTable)
 
 extern EFI_GUID gtEfiDevicePathProtocolGuid;
 extern EFI_GUID gtEfiLoadedImageProtocolGuid;
@@ -109,7 +109,6 @@ extern EFI_GUID gtEfiMpsTableGuid;
 extern EFI_GUID gtEfiAcpiTableGuid;
 extern EFI_GUID gtEfiAcpi20TableGuid;
 extern EFI_GUID gtEfiSMBIOSTableGuid;
-extern EFI_GUID gtEfiSalSystemTableGuid;
 
 //
 // Public read-only data in the EFI library
-- 
2.17.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#42307): https://edk2.groups.io/g/devel/message/42307
Mute This Topic: https://groups.io/mt/32045153/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [edk2-test][PATCH v1 2/5] Framework/ENTS: Remove reference to gtEfiSalSystemTableGuid

2019-06-12 Thread Supreeth Venkatesh

Remove references to gtEfiSalSystemTableGuid as edk2 (edk2-stable201905)
has removed IPF support.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Supreeth Venkatesh 
---
 .../TestInfrastructure/SCT/Framework/ENTS/EasLib/EntsLib.c  | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git 
a/uefi-sct/SctPkg/TestInfrastructure/SCT/Framework/ENTS/EasLib/EntsLib.c 
b/uefi-sct/SctPkg/TestInfrastructure/SCT/Framework/ENTS/EasLib/EntsLib.c
index 8c6c8c1d..63ca38f8 100644
--- a/uefi-sct/SctPkg/TestInfrastructure/SCT/Framework/ENTS/EasLib/EntsLib.c
+++ b/uefi-sct/SctPkg/TestInfrastructure/SCT/Framework/ENTS/EasLib/EntsLib.c
@@ -2,6 +2,7 @@
 
   Copyright 2006 - 2015 Unified EFI, Inc.
   Copyright (c) 2010 - 2015, Intel Corporation. All rights reserved.
+  Copyright (c) 2019, ARM Ltd. All rights reserved.
 
   This program and the accompanying materials
   are licensed and made available under the terms and conditions of the BSD 
License
@@ -118,7 +119,6 @@ EFI_GUIDgtEfiMpsTableGuid   = 
EFI_MPS_TABLE_GUID;
 EFI_GUIDgtEfiAcpiTableGuid  = EFI_ACPI_TABLE_GUID;
 EFI_GUIDgtEfiAcpi20TableGuid= 
EFI_ACPI_20_TABLE_GUID;
 EFI_GUIDgtEfiSMBIOSTableGuid= 
EFI_SMBIOS_TABLE_GUID;
-EFI_GUIDgtEfiSalSystemTableGuid = 
EFI_SAL_SYSTEM_TABLE_GUID;
 
 EFI_HANDLE  mImageHandle= NULL;
 EFI_DEVICE_PATH_PROTOCOL*gntDevicePath  = NULL;
-- 
2.17.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#42308): https://edk2.groups.io/g/devel/message/42308
Mute This Topic: https://groups.io/mt/32045154/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-test] [tianocore/edk2-test] Add Firmware Management Protocol and HII Config Access Protocol into IHVSCT. (#3)

2019-06-12 Thread Supreeth Venkatesh

Hello Shrishail,

Pull requests is no longer the way to get your change request into the new 
edk2-test repo.
Please send in “git format-patch” style patches to the 
devel@edk2.groups.io with the subject line 
containing [edk2-test].

Thanks,
Supreeth


From: shrishailp 
Sent: Sunday, May 26, 2019 11:05 PM
To: tianocore/edk2-test 
Cc: Subscribed 
Subject: [tianocore/edk2-test] Add Firmware Management Protocol and HII Config 
Access Protocol into IHVSCT. (#3)


Add Firmware Management Protocol and HII Config Access Protocol into IHVSCT.

Change-Id:
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Shrishail B Patil 
shrishail.pa...@microchip.com
Reviewed-by:


You can view, comment on, or merge this pull request online at:

  https://github.com/tianocore/edk2-test/pull/3

Commit Summary

  *   Adding FMP and HII Config Access protocol into IHVSCT

File Changes

  *   M 
uefi-sct/SctPkg/CommonGenFramework.bat
 (3)
  *   M 
uefi-sct/SctPkg/CommonGenFramework.sh
 (3)
  *   A 
uefi-sct/SctPkg/TestCase/UEFI/IHV/Protocol/FirmwareManagement/BlackBoxTest/FirmwareManagementBBTestConformance.c
 (3632)
  *   A 
uefi-sct/SctPkg/TestCase/UEFI/IHV/Protocol/FirmwareManagement/BlackBoxTest/FirmwareManagementBBTestFunction.c
 (891)
  *   A 
uefi-sct/SctPkg/TestCase/UEFI/IHV/Protocol/FirmwareManagement/BlackBoxTest/FirmwareManagementBBTestMain.c
 (228)
  *   A 
uefi-sct/SctPkg/TestCase/UEFI/IHV/Protocol/FirmwareManagement/BlackBoxTest/FirmwareManagementBBTestMain.h
 (223)
  *   A 
uefi-sct/SctPkg/TestCase/UEFI/IHV/Protocol/FirmwareManagement/BlackBoxTest/Guid.c
 (63)
  *   A 
uefi-sct/SctPkg/TestCase/UEFI/IHV/Protocol/FirmwareManagement/BlackBoxTest/Guid.h
 (153)
  *   A 
uefi-sct/SctPkg/TestCase/UEFI/IHV/Protocol/FirmwareManagement/BlackBoxTest/IhvFirmwareManagementBBTest.inf
 (52)
  *   A 
uefi-sct/SctPkg/TestCase/UEFI/IHV/Protocol/HIIConfigAccess/BlackBoxTest/Guid.c
 (46)
  *   A 
uefi-sct/SctPkg/TestCase/UEFI/IHV/Protocol/HIIConfigAccess/BlackBoxTest/Guid.h
 (109)
  *   A 
uefi-sct/SctPkg/TestCase/UEFI/IHV/Protocol/HIIConfigAccess/BlackBoxTest/HIIConfigAccessBBTestConformance.c
 (908)
  *   A 
uefi-sct/SctPkg/TestCase/UEFI/IHV/Protocol/HIIConfigAccess/BlackBoxTest/HIIConfigAccessBBTestFunction.c
 (606)
  *   A 
uefi-sct/SctPkg/TestCase/UEFI/IHV/Protocol/HIIConfigAccess/BlackBoxTest/HIIConfigAccessBBTestMain.c
 (655)
  *   A 
uefi-sct/SctPkg/TestCase/UEFI/IHV/Protocol/HIIConfigAccess/BlackBoxTest/HIIConfigAccessBBTestMain.h
 (168)
  *   A 
uefi-sct/SctPkg/TestCase/UEFI/IHV/Protocol/HIIConfigAccess/BlackBoxTest/IhvHIIConfigAccessBBTest.inf
 (55)
  *   M 
uefi-sct/SctPkg/UEFI/IHV_SCT.dsc
 (2)

Patch Links:

  *   https://github.com/tianocore/edk2-test/pull/3.patch
  *   https://github.com/tianocore/edk2-test/pull/3.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on 
GitHub,
 or mute the 
thread.

IMPORTANT NOTICE: The contents of this email and any attachments are 
confidential and may also be privileged. If you are not the intended recipient, 
please notify the sender immediately and do not disclose the contents to any 
other person, use it for any purpose, or store or copy the information in any 
medium. Thank you.

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#42305): https://edk2.groups.io/g/devel/message/42305
Mute This Topic: https://groups.io/mt/32044381/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]

Re: [edk2-devel] UEFI SCT Build Broken

2019-06-11 Thread Supreeth Venkatesh

Ashish,

We are working towards fixing the issue for the next SCT tag corresponding to 
edk2 tag.
Can you please let us know whether you are referring to edk2 tip or which edk2 
tag (edk2-stable201903)?

If possible, could you log a bug entry in bugzillafor edk2-test/SCT component?

Thanks,
Supreeth

From: Ashish Singhal 
Sent: Tuesday, June 11, 2019 12:18 PM
To: Supreeth Venkatesh ; Eric Jin 
; devel@edk2.groups.io
Subject: UEFI SCT Build Broken

Hello Eric/Supreeth,

With the latest edk2 tag, UEFI SCT tip build is broken. Seems like it needs 
Guid/SalSystemTable.h header file which is not in edk2 tree any more. Is a fix 
for this already being looked at?

Thanks
Ashish

This email message is for the sole use of the intended recipient(s) and may 
contain confidential information.  Any unauthorized review, use, disclosure or 
distribution is prohibited.  If you are not the intended recipient, please 
contact the sender by reply email and destroy all copies of the original 
message.

IMPORTANT NOTICE: The contents of this email and any attachments are 
confidential and may also be privileged. If you are not the intended recipient, 
please notify the sender immediately and do not disclose the contents to any 
other person, use it for any purpose, or store or copy the information in any 
medium. Thank you.

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#42224): https://edk2.groups.io/g/devel/message/42224
Mute This Topic: https://groups.io/mt/32030281/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel][edk2-test][PATCH V2] EFI/Protocol: Fix to use VENDOR_DEVICE_PATH to create the Debug port device node for DevicePath related protocol tests.

2019-05-08 Thread Supreeth Venkatesh

On Wed, 2019-05-08 at 10:02 +0800, Nick Wang wrote:
> Follow edk2 tree hash: 9343d0a1cd09544686b14dba5b428d7bc811f6b9 to
> use VENDOR_DEVICE_PATH to create the Debug port device node.
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Nick Wang 
Reviewed-by: Supreeth Venkatesh 

> ---
> .../DevicePathFromTextBBTestCoverage.c | 16 +++-
> .../BlackBoxTest/DevicePathToTextBBTestMain.c | 5 +++--
> uefi-sct/SctPkg/UEFI/Protocol/DevicePath.h | 15 +++
> 3 files changed, 25 insertions(+), 11 deletions(-)
> 
> diff --git a/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/DevicePathFromText/BlackBoxTest
> /DevicePathFromTextBBTestCoverage.c b/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/DevicePathFromText/BlackBoxTest
> /DevicePathFromTextBBTestCoverage.c
> index 96cd84fd..98187a62 100644
> --- a/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/DevicePathFromText/BlackBoxTest
> /DevicePathFromTextBBTestCoverage.c
> +++ b/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/DevicePathFromText/BlackBoxTest
> /DevicePathFromTextBBTestCoverage.c
> @@ -2,6 +2,7 @@
> 
> Copyright 2006 - 2017 Unified EFI, Inc.
> 
> Copyright (c) 2010 - 2018, Intel Corporation. All rights reserved.
> 
> + Copyright (c) 2019, Insyde Software Corp. All Rights Reserved.
> 
> 
> This program and the accompanying materials 
> are licensed and made available under the terms and conditions of the
> BSD License 
> @@ -1105,22 +1106,19 @@ CreateSASExDeviceNode (
> return (EFI_DEVICE_PATH_PROTOCOL *) SasEx; 
> } 
> 
> -#define DebugPortNodeType 3 
> -#define DebugPortNodeSubType 10 
> - 
> STATIC 
> EFI_DEVICE_PATH_PROTOCOL * 
> CreateDebugPortDeviceNode ( 
> IN CHAR16 *TextDeviceNode 
> ) 
> { 
> - VENDOR_DEFINED_MESSAGING_DEVICE_PATH *Vend; 
> + VENDOR_DEVICE_PATH *Vend; 
> 
> - Vend = (VENDOR_DEFINED_MESSAGING_DEVICE_PATH *) CreateDeviceNode ( 
> - DebugPortNodeType, 
> - DebugPortNodeSubType, 
> - sizeof(VENDOR_DEFINED_MESSAGING_DEVICE_PATH) 
> - ); 
> + Vend = (VENDOR_DEVICE_PATH *) CreateDeviceNode ( 
> + MESSAGING_DEVICE_PATH, 
> + MSG_VENDOR_DP, 
> + sizeof(VENDOR_DEVICE_PATH) 
> + ); 
> Vend->Guid = gBlackBoxEfiDebugPortProtocolGuid; 
> 
> return (EFI_DEVICE_PATH_PROTOCOL *) Vend; 
> diff --git a/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/DevicePathToText/BlackBoxTest/D
> evicePathToTextBBTestMain.c b/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/DevicePathToText/BlackBoxTest/D
> evicePathToTextBBTestMain.c
> index d0809776..32ce720d 100644
> --- a/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/DevicePathToText/BlackBoxTest/D
> evicePathToTextBBTestMain.c
> +++ b/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/DevicePathToText/BlackBoxTest/D
> evicePathToTextBBTestMain.c
> @@ -2,6 +2,7 @@
> 
> Copyright 2006 - 2017 Unified EFI, Inc.
> 
> Copyright (c) 2010 - 2019, Intel Corporation. All rights reserved.
> 
> + Copyright (c) 2019, Insyde Software Corp. All Rights Reserved.
> 
> 
> This program and the accompanying materials 
> are licensed and made available under the terms and conditions of the
> BSD License 
> @@ -1708,9 +1709,9 @@ BuildDebugPortDeviceNode (
> IN CHAR16 *TextDeviceNode 
> ) 
> { 
> - VENDOR_DEFINED_MESSAGING_DEVICE_PATH *Vend; 
> + VENDOR_DEVICE_PATH *Vend; 
> 
> - Vend = (VENDOR_DEFINED_MESSAGING_DEVICE_PATH *) CreateDeviceNode
> (0x3, 0x0a, sizeof (VENDOR_DEFINED_MESSAGING_DEVICE_PATH)); 
> + Vend = (VENDOR_DEVICE_PATH *) CreateDeviceNode
> (MESSAGING_DEVICE_PATH, MSG_VENDOR_DP, sizeof (VENDOR_DEVICE_PATH)); 
> 
> Vend->Guid = gBlackBoxEfiDebugPortProtocolGuid; 
> 
> diff --git a/uefi-sct/SctPkg/UEFI/Protocol/DevicePath.h b/uefi-
> sct/SctPkg/UEFI/Protocol/DevicePath.h
> index f69dc761..8bce7f14 100644
> --- a/uefi-sct/SctPkg/UEFI/Protocol/DevicePath.h
> +++ b/uefi-sct/SctPkg/UEFI/Protocol/DevicePath.h
> @@ -2,6 +2,7 @@
> 
> Copyright 2006 - 2017 Unified EFI, Inc.
> 
> Copyright (c) 2010 - 2018, Intel Corporation. All rights reserved.
> 
> + Copyright (c) 2019, Insyde Software Corp. All Rights Reserved.
> 
> 
> This program and the accompanying materials 
> are licensed and made available under the terms and conditions of the
> BSD License 
> @@ -502,6 +503,14 @@ typedef struct {
> // 
> } ACPI_ADR_DEVICE_PATH; 
> 
> + 
> +/// 
> +/// Messaging Device Paths. 
> +/// This Device Path is used to describe the connection of devices
> outside the resource domain of the 
> +/// system. This Device Path can describe physical messaging
> information like SCSI ID, or abstract 
> +/// information like networking protocol IP addresses. 
> +/// 
> +#define MESSAGING_DEVICE_PATH 0x03 
> /// 
&g

Re: [edk2-devel] [edk2-test] issue in writing SCT test case

2019-05-08 Thread Supreeth Venkatesh

+ devel@edk2.groups.io
Adding edk2-test to Subject line.

Did you add this test case details to 
SctPkg/Config/Data/Category.ini<https://github.com/UEFI/UEFI-SCT/commit/5505c33753eae52fcc905a53efd1c544e9a469ef#diff-2f7246867f748929d3fe092bf200970b>?


Also, John had created a script to generate a new UEFI-SCT test case template 
here:
https://github.com/UEFI/UEFI-SCT/commit/f143d6ab817a7b66d4396c9b419a04573766039e

Please check if it's useful for your purpose.

Thanks,
Supreeth
From: Meenakshi Aggarwal 
Sent: Tuesday, May 7, 2019 6:14 AM
To: Supreeth Venkatesh 
Subject: issue in writing SCT test case

Hi Supreeth,

We followed the  "UEFI SCT Case Writer's Guide" and  added a test case under 
Generic

$ls SctPkg/TestCase/UEFI/EFI/Generic/
EfiCompliant  ExeMode  NXP


$ ls -R /home/prakriti/SCT/edk2/SctPkg/TestCase/UEFI/EFI/Generic/NXP/
/home/prakriti/SCT/edk2/SctPkg/TestCase/UEFI/EFI/Generic/NXP/:
BlackBoxTest

/home/prakriti/SCT/edk2/SctPkg/TestCase/UEFI/EFI/Generic/NXP/BlackBoxTest:
Guid.c  Guid.h  NXPTestFunction.c  NXPTest.inf  NXPTestMain.c  NXPTestMain.h

But this NXPTest is not visible in SCT menu under GenericTest.

Please help.


Thanks,
Meenakshi
IMPORTANT NOTICE: The contents of this email and any attachments are 
confidential and may also be privileged. If you are not the intended recipient, 
please notify the sender immediately and do not disclose the contents to any 
other person, use it for any purpose, or store or copy the information in any 
medium. Thank you.

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#40215): https://edk2.groups.io/g/devel/message/40215
Mute This Topic: https://groups.io/mt/31547028/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-test]design/architecture document for sct-test,

2019-05-06 Thread Supreeth Venkatesh

Hi Udit,

There is a case specification and user guide documentation available here 
(inside documentation.zip):
http://www.uefi.org/sites/default/files/resources/UEFI2.6SCTII_Final_Release.zip

Thanks,
Supreeth

-Original Message-
From: Udit Kumar 
Sent: Monday, May 6, 2019 5:49 AM
To: Supreeth Venkatesh 
Subject: design/architecture document for sct-test,

Hi Supreeth
I was looking for some design/architecture document for sct-test, if available 
please forward

Thanks
Udit

IMPORTANT NOTICE: The contents of this email and any attachments are 
confidential and may also be privileged. If you are not the intended recipient, 
please notify the sender immediately and do not disclose the contents to any 
other person, use it for any purpose, or store or copy the information in any 
medium. Thank you.

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#40048): https://edk2.groups.io/g/devel/message/40048
Mute This Topic: https://groups.io/mt/31521567/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-test]Regarding using any shell command in SCT

2019-04-24 Thread Supreeth Venkatesh

Changing subject line to include [edk2-test].
+ Eric

Prakriti,
With the disclaimer that UEFI SCT is intended for testing against UEFI 
specification, I will try to answer your question in the way I interpreted it.

I am not sure whether you are asking how to test EFI_SHELL_PROTOCOL or is it 
related to a non uefi standard device interface you want to test?
Assuming it as the latter and with the limited information you mentioned about 
your requirement, I am assuming you will have a non-standard Protocol/Driver 
for your device and want to test those APIs.
With the above assumption, you can follow any of the standard test cases as 
reference for implementing your own test. Example below:
https://github.com/tianocore/edk2-test/tree/master/uefi-sct/SctPkg/TestCase/UEFI/IHV/Protocol/DeviceIo/BlackBoxTest

Eric can provide more information based on detailed explanation of your 
requirements.

Thanks,
Supreeth

From: Prakriti Chauhan 
Sent: Wednesday, April 24, 2019 4:28 AM
To: Supreeth Venkatesh ; devel@edk2.groups.io
Subject: Regarding using any shell command in SCT

Hi,



I want to test if my interface is working or not using SCT framework, like give 
IP address to interface and then run ping command.

Any pointers how can I achieve same?



Thanks,
Prakriti
IMPORTANT NOTICE: The contents of this email and any attachments are 
confidential and may also be privileged. If you are not the intended recipient, 
please notify the sender immediately and do not disclose the contents to any 
other person, use it for any purpose, or store or copy the information in any 
medium. Thank you.

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#39520): https://edk2.groups.io/g/devel/message/39520
Mute This Topic: https://groups.io/mt/31331918/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-test] Location of tests for vendor/edk2 specific protocols

2019-04-14 Thread Supreeth Venkatesh

+ Eric
Thanks Jeff for bringing this up.
As mentioned during our discussion on this topic briefly @ UEFI Plugfest 2019, 
I definitely like to see these non-standard protocol tests become part of test 
suite.
However, there has been no proposal yet, though there were proposals related to 
SBBR (Arm's Server Base Boot Requirements).

Currently, any new platform tests added have to be added to UEFI SCT 
description files and build scripts for it to be included as part of test suite.
May I request you to create Bugzilla Feature Request @ 
https://bugzilla.tianocore.org/ under "edk-test" product and "UEFI-SCT" 
component, as well expand on how you like this to be implemented?

Supreeth

From: devel@edk2.groups.io  On Behalf Of Jeff Brasen via 
Groups.Io
Sent: Friday, April 12, 2019 5:53 PM
To: devel@edk2.groups.io
Subject: [edk2-devel] [edk2-test] Location of tests for vendor/edk2 specific 
protocols


Now that we have the edk2-test repo with the SCT infrastructure, has there been 
any thought for where tests that use this for non-standardized protocols should 
live? My initial thought is along with the protocols in edk2/edk2-platforms. 
For example if you had Silicon/NVIDIA/Include/Procotol/x.h you would have 
Silicon/NVIDIA/TestCase/x/ for this. Has there been any thoughts/plans on this?

Thanks,
Jeff


This email message is for the sole use of the intended recipient(s) and may 
contain confidential information.  Any unauthorized review, use, disclosure or 
distribution is prohibited.  If you are not the intended recipient, please 
contact the sender by reply email and destroy all copies of the original 
message.


IMPORTANT NOTICE: The contents of this email and any attachments are 
confidential and may also be privileged. If you are not the intended recipient, 
please notify the sender immediately and do not disclose the contents to any 
other person, use it for any purpose, or store or copy the information in any 
medium. Thank you.

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#39005): https://edk2.groups.io/g/devel/message/39005
Mute This Topic: https://groups.io/mt/31070030/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [edk2-test] [PATCH v1 1/1] uefi-sct: Propose maintainers from AMD

[edk2-devel] [edk2-test][PATCH v1 1/1] MiscRuntimeServices: Add statement to improve user experience.

[edk2-devel] [edk2-test][PATCH v1 1/1] SctPkg: Fix issue with the shell script

Re: [edk2-devel] [edk2-test][Patch 3/3] uefi-sct/SctPkg: Add FMP test to IHV SCT binary package

Re: [edk2-devel] [edk2-test][Patch 3/3] uefi-sct/SctPkg: Add HiiConfigAccess to IHV SCT binary package

Re: [edk2-devel] [edk2-test][Patch V2 1/1] uefi-sct/SctPkg: Eliminate 2nd execution of ExitBootServices Test

Re: [edk2-devel] [edk2-test][Patch 1/1] uefi-sct/SctPkg: Eliminate 2nd execution of ExitBootServices Test

Re: [edk2-devel] [edk2-test][Patch 1/1] uefi-sct/SctPkg: Eliminate 2nd execution of ExitBootServices Test

Re: [edk2-devel] [edk2-test][Patch 1/1] uefi-sct/SctPkg: Eliminate 2nd execution of ExitBootServices Test

Re: [edk2-devel] [edk2-test][Patch V2 2/2] uefi-sct/SctPkg: Fix gBlackBoxEfiSimplePointerProtocolGuid value

Re: [edk2-devel] [edk2-test][Patch V2 1/2] uefi-sct/SctPkg: Convert EOL of UEFI.dec to CRLF

Re: [edk2-devel] [edk2-test][Patch 1/1] uefi-sct/SctPkg: Fix the gBlackBoxEfiSimplePointerProtocolGuid value

Re: [edk2-devel] [edk2-test][Patch 1/1] Library/SctLib: Remove Ipf source files from inf file

[edk2-devel] [edk2-test][PATCH v1 4/5] SctLib: Remove Ipf source files

[edk2-devel] [edk2-test][PATCH v1 5/5] EasLib: Remove files required for building Ipf

[edk2-devel] [edk2-test][PATCH v1 3/5] Framework/EntsLib: Remove Ipf source files from inf file

[edk2-devel] [edk2-test][PATCH v1 1/5] Library/EntsLib: Remove references to SalSystemTable

[edk2-devel] [edk2-test][PATCH v1 2/5] Framework/ENTS: Remove reference to gtEfiSalSystemTableGuid

Re: [edk2-devel] [edk2-test] [tianocore/edk2-test] Add Firmware Management Protocol and HII Config Access Protocol into IHVSCT. (#3)

Re: [edk2-devel] UEFI SCT Build Broken

Re: [edk2-devel][edk2-test][PATCH V2] EFI/Protocol: Fix to use VENDOR_DEVICE_PATH to create the Debug port device node for DevicePath related protocol tests.

Re: [edk2-devel] [edk2-test] issue in writing SCT test case

Re: [edk2-devel] [edk2-test]design/architecture document for sct-test,

Re: [edk2-devel] [edk2-test]Regarding using any shell command in SCT

Re: [edk2-devel] [edk2-test] Location of tests for vendor/edk2 specific protocols

25 matches

Site Navigation

Mail list logo

Footer information