Reviewed-by: Star Zeng
-Original Message-
From: Wu, Jiaxin
Sent: Monday, April 29, 2024 1:32 PM
To: devel@edk2.groups.io
Cc: Ni, Ray ; Zeng, Star ; Gerd Hoffmann
; Kumar, Rahul R
Subject: [PATCH v1] UefiCpuPkg/Library: Cleanup debug message in LmceSupport
ProcessorNumber 0
Reviewed-by: Star Zeng to this series.
-Original Message-
From: Lou, Yun
Sent: Sunday, April 14, 2024 11:24 PM
To: devel@edk2.groups.io
Cc: Lou, Yun ; Liu, Zhiguang ; Bi,
Dandan ; Zeng, Star ; Gao, Zhichao
; Lin, Benny ; Guo, Gua
; Kinney, Michael D ; Liming Gao
Subject: [PATCH v1
Thank you Laszlo.
Is ler...@redhat.com still reachable for now ?
-Original Message-
From: devel@edk2.groups.io On Behalf Of gaoliming via
groups.io
Sent: Monday, March 11, 2024 8:22 AM
To: devel@edk2.groups.io; pedro.falc...@gmail.com; ler...@redhat.com
Cc: Kinney, Michael D ;
Reviewed-by: Star Zeng
-Original Message-
From: devel@edk2.groups.io On Behalf Of Laszlo Ersek
Sent: Thursday, March 7, 2024 5:10 AM
To: edk2-devel-groups-io
Cc: S, Ashraf Ali ; Chiu, Chasel
; Duggapu, Chinni B ;
Desimone, Nathaniel L ; Zeng, Star
; Mohapatra, Susovan ; Kuo,
Ted
Reviewed-by: Star Zeng to this series.
-Original Message-
From: gaoliming
Sent: Monday, February 26, 2024 9:32 PM
To: devel@edk2.groups.io; Lou, Yun
Cc: Liu, Zhiguang ; Bi, Dandan ;
Zeng, Star ; Gao, Zhichao ; Lin,
Benny ; Guo, Gua ; Kinney, Michael D
Subject: 回复: [edk2-devel
To: devel@edk2.groups.io; Bhargava, Avinash
Cc: Liu, Zhiguang ; Bi, Dandan ;
Zeng, Star ; Gao, Zhichao
Subject: 回复: [edk2-devel] [PATCH v1 1/1]
MdePkg/Include/IndustryStandard/SmBios.h: Add New Intel Processor family for
SMBIOS Type 4 from SMBIOS 3.7.0
Avi:
The change is good. Reviewed
Liming,
Need your help to review and merge this patch series after the code freeze.
Thanks,
Star
-Original Message-
From: devel@edk2.groups.io On Behalf Of Zeng, Star
Sent: Friday, August 18, 2023 7:34 PM
To: Gao, Liming ; devel@edk2.groups.io; Cuevas
Farfan, Eduardo
Cc: Kinney
Got it, thanks Liming. So we need wait until 2023-08-25, then you can help
merge the patches.
-Original Message-
From: gaoliming
Sent: Friday, August 18, 2023 3:03 PM
To: devel@edk2.groups.io; Zeng, Star ; Cuevas Farfan,
Eduardo
Cc: Kinney, Michael D ; Liu, Zhiguang
; Gao, Zhichao
I have given review to both patches and Zhichao has given review to ShellPkg
patch.
Liming, need your help to review and merge the patches.
Thanks,
Star
-Original Message-
From: devel@edk2.groups.io On Behalf Of Eduardo Cuevas
Farfan
Sent: Friday, August 11, 2023 12:32 AM
To:
Reviewed-by: Star Zeng
-Original Message-
From: devel@edk2.groups.io On Behalf Of Eduardo Cuevas
Farfan
Sent: Friday, August 11, 2023 12:32 AM
To: devel@edk2.groups.io
Cc: Cuevas Farfan, Eduardo
Subject: [edk2-devel] [PATCH V2 2/2] ShellPkg: Add ProcessorUpgradeSocket
definitions
Reviewed-by: Star Zeng
-Original Message-
From: devel@edk2.groups.io On Behalf Of Eduardo Cuevas
Farfan
Sent: Friday, August 11, 2023 12:32 AM
To: devel@edk2.groups.io
Cc: Cuevas Farfan, Eduardo
Subject: [edk2-devel] [PATCH V2 1/2] MdePkg: Add ProcessorUpgradeSocket
definitions from
There is typo definitios -> definitions in subject.
Please correct it.
Cc maintainers.
Thanks,
Star
-Original Message-
From: devel@edk2.groups.io On Behalf Of Eduardo Cuevas
Farfan
Sent: Wednesday, August 9, 2023 11:03 AM
To: devel@edk2.groups.io
Cc: Cuevas Farfan, Eduardo
Subject:
There is typo definitios -> definitions in subject.
Please correct it.
Cc maintainers.
Thanks,
Star
-Original Message-
From: devel@edk2.groups.io On Behalf Of Eduardo Cuevas
Farfan
Sent: Wednesday, August 9, 2023 11:03 AM
To: devel@edk2.groups.io
Cc: Cuevas Farfan, Eduardo
Subject:
Minor comment " to indicate whether to broadcast INIT-SIPI-SIPI or SIPI" -> "
to broadcast INIT-SIPI-SIPI for first time AP wakeup" or similar.
Thanks,
Star
-Original Message-
From: Xie, Yuanhao
Sent: Friday, July 28, 2023 1:24 PM
To: Zeng, Star
Cc: Dong, Eric ;
AP wakeup" or
similar.
Thanks,
Star
-Original Message-
From: Xie, Yuanhao
Sent: Friday, July 28, 2023 1:24 PM
To: Zeng, Star
Cc: Dong, Eric ; Ni, Ray ; Kumar, Rahul
R ; Gerd Hoffmann ;
devel@edk2.groups.io
Subject: RE: [Patch V4 2/4] UefiCpuPkg: Add PcdFirstTimeWakeUpAPsBySipi
Hi S
Do we really want to mention OVMF specifically in UefiCpuPkg.dec PCD definition
?
Those comments may be better to be in OVMF dsc PCD override.
-Original Message-
From: devel@edk2.groups.io On Behalf Of Ni, Ray
Sent: Friday, July 21, 2023 11:52 AM
To: Xie, Yuanhao ; devel@edk2.groups.io
Reviewed-by: Star Zeng
-Original Message-
From: Wu, Jiaxin
Sent: Monday, March 13, 2023 3:04 PM
To: devel@edk2.groups.io
Cc: Dong, Eric ; Ni, Ray ; Zeng, Star
; Laszlo Ersek ; Gerd Hoffmann
Subject: [PATCH v1] UefiCpuPkg/PiSmmCpuDxeSmm: Fix S3 failure in SmmRestoreCpu
REF: https
Reviewed-by: Star Zeng with typo defination -> definition
fixed in commit message.
-Original Message-
From: Chaganty, Rangasai V
Sent: Friday, March 10, 2023 8:27 AM
To: S, Ashraf Ali ; devel@edk2.groups.io
Cc: Chiu, Chasel ; Desimone, Nathaniel L
; Zeng, Star
Subject: RE: [PA
Reviewed-by: Star Zeng
-Original Message-
From: Liu, Zhiguang
Sent: Tuesday, March 7, 2023 2:32 PM
To: devel@edk2.groups.io
Cc: Liu, Zhiguang ; Dong, Eric ;
Ni, Ray ; Kumar, Rahul R ; Gerd
Hoffmann ; Zeng, Star ; Mike Maslenkin
Subject: [PATCH v2] UefiCpuPkg: Calculate
BTW, look like wrong Bugzilla ID is used in commit message, please correct it
when merging the patch.
-Original Message-
From: devel@edk2.groups.io On Behalf Of Zeng, Star
Sent: Monday, March 6, 2023 6:35 PM
To: devel@edk2.groups.io; Liu, Zhiguang
Cc: Dong, Eric ; Ni, Ray ; Kumar
Reviewed-by: Star Zeng
-Original Message-
From: devel@edk2.groups.io On Behalf Of Zhiguang Liu
Sent: Thursday, March 2, 2023 9:27 AM
To: devel@edk2.groups.io
Cc: Liu, Zhiguang ; Dong, Eric ;
Ni, Ray ; Kumar, Rahul R ; Gerd
Hoffmann
Subject: [edk2-devel] [PATCH] UefiCpuPkg: Calculate
Reviewed-by: Star Zeng
-Original Message-
From: devel@edk2.groups.io On Behalf Of Zhiguang Liu
Sent: Wednesday, January 4, 2023 1:41 PM
To: devel@edk2.groups.io
Cc: Liu, Zhiguang ; Ni, Ray ; Kumar,
Rahul R ; Dong, Eric
Subject: [edk2-devel] [PATCH] UefiCpuPkg: Fix SMM code hangs when
Thanks Ray.
-Original Message-
From: Ni, Ray
Sent: Tuesday, December 13, 2022 5:05 PM
To: Zeng, Star ; devel@edk2.groups.io; Wu, Jiaxin
; Guenzel, Robert
Subject: RE: [edk2-devel] [PATCH] UefiCpuPkg: Bug fix in 5LPage handling
Star,
It has been merged last week.
> -Origi
Hi,
When could the patch be merged ?
Thanks,
Star
-Original Message-
From: devel@edk2.groups.io On Behalf Of Wu, Jiaxin
Sent: Wednesday, November 30, 2022 8:47 AM
To: devel@edk2.groups.io; Ni, Ray ; Guenzel, Robert
Subject: Re: [edk2-devel] [PATCH] UefiCpuPkg: Bug fix in 5LPage
Reviewed-by: Star Zeng
-Original Message-
From: Kuo, Ted
Sent: Thursday, September 15, 2022 9:16 PM
To: devel@edk2.groups.io
Cc: Chiu, Chasel ; Desimone, Nathaniel L
; Zeng, Star ; S, Ashraf
Ali ; Duggapu, Chinni B
Subject: [edk2-devel][PATCH v1] IntelFsp2Pkg: NvsBufferPtr
Reviewed-by: Star Zeng
-Original Message-
From: Chiu, Chasel
Sent: Monday, August 15, 2022 2:23 PM
To: devel@edk2.groups.io
Cc: Chiu, Chasel ; Desimone, Nathaniel L
; Zeng, Star
Subject: [PATCH v2] IntelFsp2Pkg: FSPM_ARCH2_UPD mismatching bug.
REF: https://bugzilla.tianocore.org
Use Block->Next instead of Pool->Head->Next, otherwise the for loop
will be not able to come out.
It will also match with the UsbHcFreeMemPool() in EhciPei.
Cc: Hao A Wu
Cc: Ray Ni
Cc: Zhikai Sun
Signed-off-by: Star Zeng
---
MdeModulePkg/Bus/Pci/XhciPei/UsbHcMem.c | 2 +-
1 file changed, 1
Reviewed-by: Star Zeng
-Original Message-
From: Chiu, Chasel
Sent: Friday, July 29, 2022 10:57 AM
To: devel@edk2.groups.io
Cc: Chiu, Chasel ; Desimone, Nathaniel L
; Zeng, Star
Subject: [PATCH] IntelFsp2Pkg: Fix GenCfgOpt bug for FSPI_UPD support.
REF: https://bugzilla.tianocore.org
Reviewed-by: Star Zeng
-Original Message-
From: Chiu, Chasel
Sent: Thursday, July 28, 2022 1:15 PM
To: devel@edk2.groups.io
Cc: Chiu, Chasel ; Desimone, Nathaniel L
; Zeng, Star
Subject: [PATCH v2] IntelFsp2Pkg: FSPI_UPD is not mandatory.
REF: https://bugzilla.tianocore.org
The spec looks wrong to me.
Thanks,
Star
-Original Message-
From: Chiu, Chasel
Sent: Thursday, July 21, 2022 11:16 AM
To: Zeng, Star ; devel@edk2.groups.io
Cc: Desimone, Nathaniel L
Subject: RE: [PATCH v3] IntelFsp2Pkg: Add FSPI_ARCH_UPD.
Hi Star, this is following current
, Chasel ; Desimone, Nathaniel L
; Zeng, Star
Subject: [PATCH v3] IntelFsp2Pkg: Add FSPI_ARCH_UPD.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3993
Adding the missing FSPI_ARCH_UPD, FSP_GLOBAL_DATA_VERSION bumpping up,
and some comments for clarification.
Also fixed a bug in SplitFspBin.py
. Personally, I do not think it is right
way to remove the check.
Thanks,
Star
From: Lean Sheng Tan
Sent: Tuesday, May 17, 2022 7:58 PM
To: devel@edk2.groups.io; Wu, Hao A
Cc: Zeng, Star ; Gao, Liming ;
Rhodes, Sean
Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/FaultTolerantWriteDxe: Don't
Hi,
After
https://github.com/tianocore/edk2/pull/2269/commits/c6c83f98fabbe3e58bc0579bade3a807c93dd690,
no consumer to PcdSevEsIsEnabled anymore.
Shouldn't PcdSevEsIsEnabled be removed from UefiCpuPkg?
Thanks,
Star
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to
Yu,
You have sent this patch series for many times, so you should update v1 to vX
accordingly. Just a reminder.
Thanks,
Star
-Original Message-
From: Pu, Yu
Sent: Monday, April 11, 2022 5:46 PM
To: devel@edk2.groups.io
Cc: Pu, Yu ; Chiu, Chasel ; Desimone,
Nathaniel L ; Zeng, Star
Personally, you'd better to split this one patch to two, one is for MdePkg and
another is for ShellPkg.
Also cc MdePkg and ShellPkg maintainers.
Thanks,
Star
-Original Message-
From: Ke, Bo-ChangX
Sent: Friday, April 8, 2022 1:55 PM
To: devel@edk2.groups.io
Cc: Bi, Dandan ; Zeng, Star
26 AM
To: devel@edk2.groups.io
Cc: Bi, Dandan ; Zeng, Star
Subject: [PATCH] ShellPkg: Update smbiosview type 41 with SMBIOS 3.5 fields
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3900
update smbiosview type 41 related fileds.
Signed-off-by: Bo Chang Ke
Cc: Dandan Bi
Cc: Star Zeng
Reviewed-by: Star Zeng
-Original Message-
From: Chiu, Chasel
Sent: Wednesday, April 6, 2022 11:42 AM
To: Pu, Yu ; devel@edk2.groups.io
Cc: Desimone, Nathaniel L ; Zeng, Star
Subject: RE: [PATCH v1 1/6] IntelFsp2Pkg: Add CpuLib to module INFs that depend
on UefiCpuLib
Thanks Yu
Reviewed-by: Star Zeng
-Original Message-
From: Chiu, Chasel
Sent: Wednesday, April 6, 2022 11:42 AM
To: Pu, Yu ; devel@edk2.groups.io
Cc: Desimone, Nathaniel L ; Zeng, Star
Subject: RE: [PATCH v1 2/6] IntelFsp2WrapperPkg: Add CpuLib to module INFs that
depend on UefiCpuLib
Reviewed-by: Star Zeng
-Original Message-
From: Kinney, Michael D
Sent: Saturday, January 22, 2022 9:41 AM
To: devel@edk2.groups.io
Cc: Wu, Hao A ; Ni, Ray ; Zeng, Star
Subject: [Patch 1/1] MdeModulePkg/Bus/Pci/PciBusDxe: Support platform PCI ROM
override
REF: https
Reviewed-by: Star Zeng
-Original Message-
From: Chiu, Chasel
Sent: 2021年12月28日 18:58
To: devel@edk2.groups.io
Cc: Chiu, Chasel ; Ma, Maurice ;
Desimone, Nathaniel L ; Zeng, Star
Subject: [PATCH] IntelFsp2Pkg/FspSecCore: ExtendedImageRevision was not printed.
REF: https
Reviewed-by: Star Zeng
-Original Message-
From: devel@edk2.groups.io On Behalf Of Chiu, Chasel
Sent: Tuesday, December 21, 2021 8:40 AM
To: devel@edk2.groups.io
Cc: Chiu, Chasel ; Desimone, Nathaniel L
; Zeng, Star ; Ni, Ray
; S, Ashraf Ali
Subject: [edk2-devel] [PATCH
which will be only ready/connected at
BDS phase, right?
Thanks,
Star
-Original Message-
From: Wu, Hao A
Sent: 2021年12月15日 13:43
To: Jeff Brasen ; devel@edk2.groups.io; Kinney, Michael D
; Gao, Liming ; Zeng,
Star
Cc: Ni, Ray
Subject: RE: [PATCH] MdeModulePkg/ScsiDisk: Change TPL
: Desimone, Nathaniel L ; Zeng, Star
; Kuo, Ted ; Duggapu, Chinni B
; Chaganty, Rangasai V
; Solanki, Digant H
; V, Sangeetha ; Ni, Ray
Subject: RE: [PATCH v8] IntelFsp2WrapperPkg : FSPM/S UPD data address based on
Build Type
Thanks Ashraf!
Reviewed-by: Chasel Chiu
> -Original Mess
Cc: Maurice Ma
Cc: Nate DeSimone
Cc: Chasel Chiu
Signed-off-by: Star Zeng
---
IntelFsp2Pkg/Tools/SplitFspBin.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/IntelFsp2Pkg/Tools/SplitFspBin.py
b/IntelFsp2Pkg/Tools/SplitFspBin.py
index 24272e82af88..c3165dd4ae69 100644
Reviewed-by: Star Zeng
-Original Message-
From: Chiu, Chasel
Sent: Tuesday, October 26, 2021 4:06 PM
To: devel@edk2.groups.io
Cc: Chiu, Chasel ; Ma, Maurice ;
Desimone, Nathaniel L ; Zeng, Star
Subject: [PATCH] IntelFsp2Pkg/SplitFspBin.py: adopt FSP 2.3 specification.
REF: https
This patch follows new Intel SDM to define CPUID.(EAX=7,ECX=0):EDX[30].
Signed-off-by: Star Zeng
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhiguang Liu
Cc: Ray Ni
---
MdePkg/Include/Register/Intel/Cpuid.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
Thanks Liming for the review.
Help push the patches if no other feedback is received.
Star
-Original Message-
From: devel@edk2.groups.io On Behalf Of gaoliming
Sent: 2021年9月28日 13:31
To: devel@edk2.groups.io; Zeng, Star
Subject: 回复: [edk2-devel] [PATCH V2 0/2] Add
To: Zeng, Star ; devel@edk2.groups.io
Cc: gaolim...@byosoft.com.cn; Kinney, Michael D ;
Liu, Zhiguang ; Gao, Zhichao
Subject: RE: [edk2-devel] [PATCH] MdePkg,ShellPkg: Add
ProcessorUpgradeSocketLGA4677 from SMBIOS 3.5.0
Star,
It might be better to split the patch to two patches.
one is to change
This patch adds ProcessorUpgradeSocketLGA4677 definition into Smbios.h
from SMBIOS 3.5.0.
It also adds ProcessorUpgradeSocketLGA4189 and ProcessorUpgradeSocketLGA1200
definitions into from SMBIOS 3.4.0.
Signed-off-by: Star Zeng
---
MdePkg/Include/IndustryStandard/SmBios.h | 7 +--
1 file
This patch adds entry into QueryTable.c for ProcessorUpgradeSocketLGA4677
from SMBIOS 3.5.0.
It also adds entries into QueryTable.c for ProcessorUpgradeSocketLGA4189
and ProcessorUpgradeSocketLGA1200 from SMBIOS 3.4.0.
Signed-off-by: Star Zeng
---
.../SmbiosView/QueryTable.c
V2: Split patches for packages.
Star Zeng (2):
MdePkg: Add ProcessorUpgradeSocketLGA4677 from SMBIOS 3.5.0
ShellPkg: Support ProcessorUpgradeSocketLGA4677 from SMBIOS 3.5.0
MdePkg/Include/IndustryStandard/SmBios.h | 7 +--
.../SmbiosView/QueryTable.c|
+ Maintainers and Reviewers
-Original Message-
From: devel@edk2.groups.io On Behalf Of Zeng, Star
Sent: 2021年9月28日 10:04
To: devel@edk2.groups.io
Cc: Zeng, Star
Subject: [edk2-devel] [PATCH] MdePkg,ShellPkg: Add
ProcessorUpgradeSocketLGA4677 from SMBIOS 3.5.0
This patch adds
This patch adds ProcessorUpgradeSocketLGA4677 definition into Smbios.h
from SMBIOS 3.5.0 and entry into QueryTable.c.
It also adds ProcessorUpgradeSocketLGA4189 and ProcessorUpgradeSocketLGA1200
into from SMBIOS 3.4.0 and entries into QueryTable.c.
Signed-off-by: Star Zeng
---
Typo "ignored" to "not ignored".
-Original Message-
From: devel@edk2.groups.io On Behalf Of Zeng, Star
Sent: 2021年9月27日 18:36
To: S, Ashraf Ali ; Chiu, Chasel
; devel@edk2.groups.io
Cc: Desimone, Nathaniel L ; Kuo, Ted
; Duggapu, Chinni B ; Chaganty,
Rangasai V
;= MAX_UINT32) {
PcdSet32S (PcdFspmUpdDataAddress, (UINT32) Address);
} else {
PcdSet64S (PcdFspmUpdDataAddress64, (UINT64) Address);
}
}
-Original Message-
From: S, Ashraf Ali
Sent: 2021年9月27日 18:16
To: Zeng, Star ; Chiu, Chasel ;
devel@edk2.groups.io
Cc: Desimone, Nathaniel
);
}
}
Thanks,
Star
-Original Message-
From: Chiu, Chasel
Sent: Monday, September 27, 2021 9:10 AM
To: S, Ashraf Ali ; devel@edk2.groups.io
Cc: Desimone, Nathaniel L ; Zeng, Star
; Kuo, Ted ; Duggapu, Chinni B
; Chaganty, Rangasai V
; Solanki, Digant H
; V, Sangeetha ; Ni, Ray
Subject: RE
I'd like to also say thank you Laszlo.
Star
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Laszlo
> Ersek
> Sent: Friday, July 9, 2021 7:58 PM
> To: Ard Biesheuvel
> Cc: edk2-devel-groups-io ; Andrew Fish
> ; Ard Biesheuvel ; Dong,
> Eric ; Justen, Jordan L ;
> Leif
Sent: 2021年6月19日 18:56
To: Zeng, Star ; Yao, Jiewen ;
devel@edk2.groups.io
Subject: [edk2-devel] Possibly incorrect size in memory profile structure
Good day,
I have a question regarding a part of the memory profiling code. Namely this
piece of code [1] introduced storing the PDB file name among
Just like to give my RB: Reviewed-by: Star Zeng
Please also get the RB from maintainer.
Thanks,
Star
-Original Message-
From: devel@edk2.groups.io On Behalf Of PierreGondois
Sent: 2021年6月2日 6:05
To: devel@edk2.groups.io; Bi, Dandan ;
gaolim...@byosoft.com.cn; Kinney, Michael D ;
In C1e.c, the MSR_FEATURE_CONFIG is better to be corrected to
MSR_NEHALEM_POWER_CTL.
Thanks,
Star
-Original Message-
From: devel@edk2.groups.io On Behalf Of Ni, Ray
Sent: Tuesday, June 1, 2021 11:25 PM
To: Li, Daoxiang ; devel@edk2.groups.io
Cc: Dong, Eric ; Laszlo Ersek ; Kumar,
age-
> From: Lou, Yun
> Sent: Thursday, April 15, 2021 2:49 PM
> To: devel@edk2.groups.io
> Cc: Lou, Yun ; Chiu, Chasel
> ; Desimone, Nathaniel L
> ; Zeng, Star ;
> Ni, Ray
> Subject: [PATCH v2] IntelFsp2WrapperPkg: Remove microcode related PCDs
>
> REF: https://bugzi
Hi All,
Do you think it worth or not to also update MpFuncs.nasm in
Edk2\UefiCpuPkg\PiSmmCpuDxeSmm?
Thanks,
Star
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Ni, Ray
> Sent: Thursday, February 4, 2021 10:59 AM
> To: devel@edk2.groups.io
> Cc: Laszlo Ersek ; Dong,
> -Original Message-
> From: Ni, Ray
> Sent: Tuesday, January 26, 2021 10:26 AM
> To: Laszlo Ersek ; Zeng, Star ;
> Kinney, Michael D ; devel@edk2.groups.io
> Cc: Dong, Eric ; Kumar, Rahul1
>
> Subject: RE: [edk2-devel] [Patch 1/1] UefiCpuPkg/Library/MpInitLib: Fi
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Laszlo
> Ersek
> Sent: Tuesday, January 26, 2021 5:18 AM
> To: Zeng, Star ; Ni, Ray ; Kinney,
> Michael D ; devel@edk2.groups.io
> Cc: Dong, Eric ; Kumar, Rahul1
>
> Subject: Re: [edk2-devel] [Pa
> -Original Message-
> From: Ni, Ray
> Sent: Monday, January 25, 2021 4:53 PM
> To: Zeng, Star ; Kinney, Michael D
> ; devel@edk2.groups.io
> Cc: Dong, Eric ; Laszlo Ersek ;
> Kumar, Rahul1
> Subject: RE: [edk2-devel] [Patch 1/1] UefiCpuPkg/Library/MpInitLib: Fix AP
inal Message-
> From: Kinney, Michael D
> Sent: Monday, January 25, 2021 1:16 PM
> To: Zeng, Star ; devel@edk2.groups.io; Kinney,
> Michael D
> Cc: Dong, Eric ; Ni, Ray ; Laszlo
> Ersek ; Kumar, Rahul1
> Subject: RE: [edk2-devel] [Patch 1/1] UefiCpuPkg/Library/MpInitLib
Does
https://github.com/tianocore/edk2/blob/master/UefiCpuPkg/Library/MpInitLib/MpLib.c#L909
(also decrements NumApsExecuting) also need be handled?
Thanks,
Star
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Michael
> D Kinney
> Sent: Saturday, January 23, 2021 1:10
> -Original Message-
> From: Laszlo Ersek
> Sent: Thursday, January 21, 2021 10:38 PM
> To: devel@edk2.groups.io; Zeng, Star
> Cc: Dong, Eric ; Ni, Ray
> Subject: Re: [edk2-devel] [PATCH] UefiCpuPkg RegisterCpuFeaturesLib:
> NumberOfCpus may be uninitialized
>
&
> -Original Message-
> From: Laszlo Ersek
> Sent: Thursday, January 21, 2021 9:48 PM
> To: devel@edk2.groups.io; Zeng, Star
> Cc: Dong, Eric ; Ni, Ray
> Subject: Re: [edk2-devel] [PATCH] UefiCpuPkg RegisterCpuFeaturesLib:
> NumberOfCpus may be uninitialized
>
&
NumberOfCpus local variable in GetAcpiCpuData will be uninitialized
when CpuS3DataDxe runs before DxeRegisterCpuFeaturesLib (linked by
CpuFeaturesDxe) because there is no code to initialize it at
(AcpiCpuData != NULL) execution path.
The issue is exposed after
Series Reviewed-by: Star Zeng
> -Original Message-
> From: Laszlo Ersek
> Sent: Tuesday, January 19, 2021 11:55 PM
> To: edk2-devel-groups-io
> Cc: Ard Biesheuvel ; Dong, Eric
> ; Justen, Jordan L ;
> Philippe Mathieu-Daudé ; Kumar, Rahul1
> ; Ni, Ray ; Zeng, S
A little surprised by "Average time taken to find CpuCrystalFrequencyHob: about
2000 ns".
It depends on the hob is built early or late?
Seemingly, NanoSecondDelay() will always have some deviation.
Thanks,
Star
-Original Message-
From: devel@edk2.groups.io On Behalf Of Laszlo Ersek
Reviewed-by: Star Zeng
-Original Message-
From: Chiu, Chasel
Sent: Wednesday, September 16, 2020 8:21 PM
To: devel@edk2.groups.io; gaolim...@byosoft.com.cn
Cc: Desimone, Nathaniel L ; Zeng, Star
Subject: RE: [edk2-devel] [PATCH] IntelFsp2Pkg GenCfgOpt.py: Initialize
IncLines
Reviewed-by: Star Zeng
-Original Message-
From: devel@edk2.groups.io On Behalf Of Gao, Zhichao
Sent: 2020年8月3日 14:05
To: devel@edk2.groups.io
Cc: Gao, Zhichao ; Wang, Jian J ;
Wu, Hao A ; Gao, Liming ; Ni, Ray
; Bi, Dandan ; Zeng, Star
Subject: [edk2-devel] [PATCH V3
Reviewed-by: Star Zeng with the copyright year correction.
> -Original Message-
> From: Desimone, Nathaniel L
> Sent: Thursday, June 11, 2020 4:35 AM
> To: Chiu, Chasel ; devel@edk2.groups.io
> Cc: Ma, Maurice ; Zeng, Star
> Subject: RE: [PATCH] IntelFsp2Pkg: Add
No need to resend new patch, you can go ahead with Nate's review after the
correction.
> -Original Message-
> From: Chiu, Chasel
> Sent: Wednesday, May 20, 2020 12:25 PM
> To: Zeng, Star ; Desimone, Nathaniel L
> ; devel@edk2.groups.io
> Cc: Ma, Maurice
>
equilivant is a typo?
> -Original Message-
> From: Desimone, Nathaniel L
> Sent: Wednesday, May 20, 2020 12:12 PM
> To: Chiu, Chasel ; devel@edk2.groups.io
> Cc: Ma, Maurice ; Zeng, Star
> Subject: RE: [PATCH] IntelFsp2Pkg: Add FunctionParametePtr to
> FspGlob
Reviewed-by: Star Zeng
> -Original Message-
> From: Desimone, Nathaniel L
> Sent: Friday, May 1, 2020 5:59 AM
> To: devel@edk2.groups.io; Chiu, Chasel
> Cc: Ma, Maurice ; Zeng, Star
> Subject: RE: [edk2-devel] [PATCH] IntelFsp2Pkg: Support Multi-Phase silico
Reviewed-by: Star Zeng
> -Original Message-
> From: Dong, Eric
> Sent: Friday, April 10, 2020 11:00 AM
> To: Ray Ni ; devel@edk2.groups.io
> Cc: Ni, Ray ; Zeng, Star
> Subject: RE: [PATCH v3] UefiCpuPkg/PiSmmCpuDxeSmm: Improve the
> performance of GetFreeToken()
&
Your time is super fast.
> -Original Message-
> From: Ni, Ray
> Sent: Friday, April 10, 2020 10:50 AM
> To: Dong, Eric ; Ray Ni
> ; devel@edk2.groups.io
> Cc: Zeng, Star
> Subject: RE: [PATCH v2] UefiCpuPkg/PiSmmCpuDxeSmm: Improve the
> performance of GetFr
> -Original Message-
> From: Wu, Hao A
> Sent: Tuesday, March 24, 2020 3:12 PM
> To: Zeng, Star ; devel@edk2.groups.io
> Cc: Dong, Eric ; Ni, Ray ; Laszlo
> Ersek ; Kinney, Michael D
> ; Brian J . Johnson
> Subject: RE: [edk2-devel] [PATCH v2] UefiCpuPk
.groups.io
> Cc: Wu, Hao A ; Dong, Eric ; Ni,
> Ray ; Laszlo Ersek ; Kinney, Michael
> D ; Zeng, Star ; Brian J .
> Johnson
> Subject: [edk2-devel] [PATCH v2] UefiCpuPkg/MpInitLib DXE: Add PCD to
> control AP status check interval
>
> REF:https://bugzilla.tianocore.o
: devel@edk2.groups.io; Zeng, Star
> Cc: Ni, Ray ; Laszlo Ersek
> Subject: RE: [edk2-devel] [PATCH V2] UefiCpuPkg RegisterCpuFeaturesLib:
> Match data type and format specifier
>
> Reviewed-by: Eric Dong
>
> -Original Message-
> From: devel@edk2.groups.io On Be
Reviewed-by: Star Zeng
> -Original Message-
> From: Chiu, Chasel
> Sent: Monday, February 10, 2020 11:53 AM
> To: devel@edk2.groups.io
> Cc: Ma, Maurice ; Desimone, Nathaniel L
> ; Zeng, Star
> Subject: [PATCH 0/2] IntelFsp2Pkg: Coverity scan flags issues
>
> -Original Message-
> From: Laszlo Ersek
> Sent: Monday, February 3, 2020 9:23 PM
> To: Zeng, Star ; devel@edk2.groups.io
> Cc: Dong, Eric ; Ni, Ray
> Subject: Re: [PATCH] UefiCpuPkg RegisterCpuFeaturesLib: Use %08x to print
> CacheControl Index
>
> On 02/03
Sorry, the title is incorrect. Please see the thread with title " [PATCH V2]
UefiCpuPkg RegisterCpuFeaturesLib: Match data type and format specifier"
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Zeng,
> Star
> Sent: Tuesday, February 4, 2020 2:
Sorry, the title is incorrect. Please see the thread with title " [PATCH V2]
UefiCpuPkg RegisterCpuFeaturesLib: Match data type and format specifier"
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Zeng,
> Star
> Sent: Tuesday, February 4, 2020 3:
Match data type and format specifier for printing.
1. Type cast ProcessorNumber and FeatureIndex to UINT32
as %d only expects a UINT32.
2. Use %08x instead of %08lx for CacheControl to print Index
as it is UINT32 type.
3. Use %016lx instead of %08lx for MemoryMapped to print
(Index |
Match data type and format specifier for printing.
1. Type cast ProcessorNumber and FeatureIndex to UINT32
as %d only expects a UINT32.
2. Use %08x instead of %08lx for CacheControl to print Index
as it is UINT32 type.
3. Use %016lx instead of %08lx for MemoryMapped to print
(Index |
Match data type and format specifier for printing.
1. Type cast ProcessorNumber and FeatureIndex to UINT32
as %d only expects a UINT32.
2. Use %08x instead of %08lx for CacheControl to print Index
as it is UINT32 type.
3. Use %016lx instead of %08lx for MemoryMapped to print
(Index |
> -Original Message-
> From: Laszlo Ersek
> Sent: Monday, February 3, 2020 4:47 PM
> To: Zeng, Star ; devel@edk2.groups.io
> Cc: Dong, Eric ; Ni, Ray
> Subject: Re: [PATCH] UefiCpuPkg RegisterCpuFeaturesLib: Use %08x to print
> CacheControl Index
>
> Hello S
Got the point.
With the typo fixed, Reviewed-by: Star Zeng
> -Original Message-
> From: Ni, Ray
> Sent: Thursday, January 2, 2020 11:15 AM
> To: Zeng, Star ; Ray Ni
> ; devel@edk2.groups.io
> Cc: Dong, Eric ; Kinney, Michael D
>
> Subject: RE: [PATCH v2 3/
> -Original Message-
> From: Yao, Jiewen
> Sent: Thursday, January 2, 2020 10:16 PM
> To: Zeng, Star ; devel@edk2.groups.io
> Cc: Wang, Jian J ; Wu, Hao A ;
> Bi, Dandan
> Subject: RE: [PATCH 5/6] MdeModulePkg/Smbios: Add TCG PFP rev 105
> support.
>
&g
Minor comments.
> -Original Message-
> From: Yao, Jiewen
> Sent: Tuesday, December 31, 2019 2:44 PM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J ; Wu, Hao A ;
> Bi, Dandan ; Zeng, Star
> Subject: [PATCH 5/6] MdeModulePkg/Smbios: Add TCG PFP rev 105 sup
Reviewed-by: Star Zeng
> -Original Message-
> From: Yao, Jiewen
> Sent: Tuesday, December 31, 2019 2:44 PM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J ; Wu, Hao A ;
> Bi, Dandan ; Zeng, Star
> Subject: [PATCH 3/6] MdeModulePkg/Smbios: Done measure Smbios
>
Some feedback added.
> -Original Message-
> From: Ray Ni [mailto:niru...@users.noreply.github.com]
> Sent: Tuesday, November 26, 2019 2:16 PM
> To: devel@edk2.groups.io
> Cc: Ni, Ray ; Dong, Eric ; Zeng, Star
> ; Kinney, Michael D
> Subject: [PATCH v2 3/3]
Minor comment added.
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Ray Ni
> Sent: Tuesday, November 26, 2019 2:16 PM
> To: devel@edk2.groups.io
> Cc: Ni, Ray ; Dong, Eric
> Subject: [edk2-devel] [PATCH v2 2/3]
Reviewed-by: Star Zeng
-Original Message-
From: Ray Ni [mailto:niru...@users.noreply.github.com]
Sent: Tuesday, November 26, 2019 2:16 PM
To: devel@edk2.groups.io
Cc: Ni, Ray ; Dong, Eric ; Zeng, Star
Subject: [PATCH v2 1/3] UefiCpuPkg/RegisterCpuFeaturesLib: Delete
CPU_FEATURE_
Thank you. Reviewed-by: Star Zeng
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Philippe
> Mathieu-Daudé
> Sent: Friday, December 6, 2019 7:26 PM
> To: devel@edk2.groups.io
> Cc: Philippe Mathieu-Daude ; Zeng, Star
>
> Subject: [edk2-devel] [PA
Reviewed-by: Star Zeng
-Original Message-
From: Philippe Mathieu-Daude [mailto:phi...@redhat.com]
Sent: Wednesday, December 4, 2019 12:15 AM
To: devel@edk2.groups.io
Cc: Antoine Coeur ; Chiu, Chasel ;
Desimone, Nathaniel L ; Zeng, Star
; Philippe Mathieu-Daude
Subject: [PATCH 10/79
1 - 100 of 157 matches
Mail list logo
