Re: [edk2-devel] [PATCH v2] UefiCpuPkg: support single EFI_PEI_CORE_FV_LOCATION_PPI in PpiList

2019-09-04 Thread Zeng, Star
Reviewed-by: Star Zeng > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Chiu, Chasel > Sent: Thursday, September 5, 2019 12:27 PM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Ni, Ray ; Laszlo > Ersek > Subject: [edk2-devel] [PATCH v2]

Re: [edk2-devel] [PATCH] IntelFsp2WrapperPkg: Remove unneeded MdeModulePkg dependency

2019-09-03 Thread Zeng, Star
Reviewed-by: Star Zeng > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Ni, > Ray > Sent: Wednesday, September 4, 2019 2:18 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Zeng, Star > Subj

Re: [edk2-devel] [PATCH 0/2] move PcdRealTimeClockUpdateTimeout from MdeModulePkg to PcAtChipsetPkg

2019-08-27 Thread Zeng, Star
Both XXXPkg.uni need to be updated as the PCD movement. With that, Reviewed-by: Star Zeng Thanks, Star > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Ni, > Ray > Sent: Wednesday, August 28, 2019 7:27 AM > To: devel@edk2.groups.io > Subject:

Re: [edk2-devel] [PATCH] IntelFsp2Pkg/FspSecCore: Remove unneeded MdeModulePkg dependency

2019-08-27 Thread Zeng, Star
Reviewed-by: Star Zeng > -Original Message- > From: Ni, Ray > Sent: Wednesday, August 28, 2019 6:41 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Zeng, Star > Subject: [PATCH] IntelFsp2Pkg/FspSecCore: Remove unneeded > MdeModulePk

Re: [edk2-devel] [PATCH v2] IntelSiliconPkg/Feature Implement SmmAccess

2019-08-27 Thread Zeng, Star
Include new library and driver to IntelSiliconPkg.dsc for building coverage? In SmmAccessLib.h, it still refers the _PEI_SMM_ACCESS_PPI definition from MdeModulePkg? And need have _EFI prefix for _PEI_MASTER_BOOT_MODE_PEIM_PPI and _PEI_PERMANENT_MEMORY_INSTALLED_PPI? In PeiSmmAccessLib.inf, the

Re: [edk2-devel] [PATCH] UefiCpuPkg: Adding a new TSC library by using CPUID(0x15) TSC leaf

2019-08-20 Thread Zeng, Star
d: > Thanks for your update. If no other comment, I will help push this patch > tomorrow. > > Thanks > Liming > > -Original Message- > > From: Kuo, Donald > > Sent: Tuesday, August 20, 2019 3:22 PM > > To: Gao, Liming ; devel@edk2.groups.io; > >

Re: [edk2-devel] [Patch v3 1/6] UefiCpuPkg/RegisterCpuFeaturesLib: Add "Test Then Write" Macros.

2019-08-15 Thread Zeng, Star
> -Original Message- > From: Dong, Eric > Sent: Friday, August 16, 2019 9:27 AM > To: Zeng, Star ; devel@edk2.groups.io > Cc: Ni, Ray ; Laszlo Ersek > Subject: RE: [Patch v3 1/6] UefiCpuPkg/RegisterCpuFeaturesLib: Add "Test > Then Write" Macro

Re: [edk2-devel] [Patch v3 1/6] UefiCpuPkg/RegisterCpuFeaturesLib: Add "Test Then Write" Macros.

2019-08-15 Thread Zeng, Star
> -Original Message- > From: Dong, Eric > Sent: Thursday, August 15, 2019 10:51 AM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Laszlo Ersek ; Zeng, > Star > Subject: [Patch v3 1/6] UefiCpuPkg/RegisterCpuFeaturesLib: Add "Test Then > W

Re: [edk2-devel] [PATCH] UefiCpuPkg: Adding a new TSC library by using CPUID(0x15) TSC leaf

2019-08-12 Thread Zeng, Star
Some comments below. > -Original Message- > From: Kuo, Donald > Sent: Monday, August 12, 2019 1:57 PM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Zeng, Star ; Dong, Eric > > Subject: [PATCH] UefiCpuPkg: Adding a new TSC library by using CPUID(0x15) >

[edk2-devel] [PATCH] SourceLevelDebugPkg DebugCommLibUsb3: Address NULL ptr dereference case

2019-08-08 Thread Zeng, Star
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2051 Original code GetConfigTable for AddrPtr first, if failed, InstalConfigTable with allocated AddrPtr. So the AddrPtr should not be NULL and the NULL pointer dereference case should be false positive. This patch is just to address the case

Re: [edk2-devel] [PATCH 3/3] IntelFsp2Pkg/FspSecCore: Add missing header file in INF file

2019-08-08 Thread Zeng, Star
Same with Chasel. Reviewed-by: Star Zeng . > -Original Message- > From: Chiu, Chasel > Sent: Thursday, August 8, 2019 2:59 PM > To: Zhang, Shenglei ; devel@edk2.groups.io > Cc: Desimone, Nathaniel L ; Zeng, Star > > Subject: RE: [PATCH 3/3] IntelFsp2Pkg/FspSecCor

Re: [edk2-devel] [PATCH v1] MdeModulePkg/Variable/RuntimeDxe: Not copy SMM pointers in comm buffer

2019-08-06 Thread Zeng, Star
The DstInfoEntry is better to have identifer [out] instead of [in]? Thanks, Star > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Wu, > Hao A > Sent: Tuesday, August 6, 2019 3:19 PM > To: devel@edk2.groups.io > Cc: Wu, Hao A ; Gao, Liming ; >

Re: [edk2-devel] [PATCH] IntelFsp2Pkg: PeiService pointer not reset to 0 in SecMain

2019-07-25 Thread Zeng, Star
> -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Chiu, Chasel > Sent: Thursday, July 25, 2019 11:51 PM > To: devel@edk2.groups.io > Cc: Desimone, Nathaniel L ; Zeng, Star > > Subject: [edk2-devel] [PATCH] IntelFsp

Re: [edk2-devel] [PATCH v2 1/1] Maintainers.txt: Fine-grained review ownership for MdeModulePkg

2019-07-17 Thread Zeng, Star
Reviewed-by: Star Zeng for my part. > -Original Message- > From: Wu, Hao A > Sent: Thursday, July 18, 2019 9:19 AM > To: devel@edk2.groups.io > Cc: Wu, Hao A ; Andrew Fish ; > Laszlo Ersek ; Leif Lindholm ; > Kinney, Michael D ; Bi, Dandan > ; Dong, Eric ; Ga

Re: [edk2-devel] [Patch v3 2/2] UefiCpuPkg/RegisterCpuFeaturesLib: avoid use dynamic PCD.

2019-07-16 Thread Zeng, Star
Reviewed-by: Star Zeng > -Original Message- > From: Dong, Eric > Sent: Wednesday, July 17, 2019 9:59 AM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Ni, Ray ; Laszlo > Ersek ; Kumar, Chandana C > ; Zeng, Star > Subject: [Patch v3 2/2] UefiCpuPkg/RegisterC

[edk2-devel] [PATCH] UefiCpuPkg DxeRegisterCpuFeaturesLib: Fix VS2012 build failure

2019-07-16 Thread Zeng, Star
The new VS2012 build failure is caused by 7a0df26. xxx\registercpufeatureslib\dxeregistercpufeatureslib.c(258) : warning C4701: potentially uninitialized local variable 'MpEvent' used It is a false positive alarm. MpEvent is assigned at line 238 and will be used at line 258, both lines are

Re: [edk2-devel] [PATCH] UefiCpuPkg CpuCommonFeaturesLib: Enhance Ppin code

2019-07-16 Thread Zeng, Star
Eric, Thanks for the comments. Attach the updated patch, and you may help push it if it is ok. Thanks, Star > -Original Message- > From: Dong, Eric > Sent: Tuesday, July 16, 2019 3:24 PM > To: Zeng, Star ; devel@edk2.groups.io > Cc: Laszlo Ersek ; Ni, Ray ; Kumar, &g

Re: [edk2-devel] [Patch v2 2/2] UefiCpuPkg/RegisterCpuFeaturesLib: avoid use dynamic PCD.

2019-07-15 Thread Zeng, Star
; From: Dong, Eric > Sent: Monday, July 15, 2019 3:01 PM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Laszlo Ersek ; Kumar, > Chandana C ; Zeng, Star > > Subject: [Patch v2 2/2] UefiCpuPkg/RegisterCpuFeaturesLib: avoid use > dynamic PCD. > > REF: https://bugzilla.t

Re: [edk2-devel] [Patch 2/2] UefiCpuPkg/Library/RegisterCpuFeaturesLib: avoid use dynamic PCD.

2019-07-12 Thread Zeng, Star
4 comments are added inline. > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Dong, Eric > Sent: Friday, July 12, 2019 9:53 AM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Laszlo Ersek ; Kumar, > Chandana C ; Zeng, Star >

Re: [edk2-devel] [Patch 1/2] UefiCpuPkg/RegisterCpuFeaturesLib: Avoid AP calls gBS service.

2019-07-12 Thread Zeng, Star
Some minor comments inline. > -Original Message- > From: Dong, Eric > Sent: Friday, July 12, 2019 9:53 AM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Laszlo Ersek ; Kumar, > Chandana C ; Zeng, Star > > Subject: [Patch 1/2] UefiCpuPkg/RegisterCpuFeaturesLib: Avoi

[edk2-devel] [PATCH] UefiCpuPkg CpuCommonFeaturesLib: Enhance Ppin code

2019-07-12 Thread Zeng, Star
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1961 Enhance Ppin code to enable and unlock for TRUE State, and disable and lock for FALSE State. Note: enable and lock could not be set both. Cc: Laszlo Ersek Cc: Eric Dong Cc: Ray Ni Cc: Chandana Kumar Cc: Kevin Li Signed-off-by: Star Zeng

[edk2-devel] [PATCH] UefiCpuPkg RegisterCpuFeaturesLib: Fix an ASSERTION issue

2019-07-10 Thread Zeng, Star
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1968 We met assertion like below, it happens when there is only one processor. ASSERT_EFI_ERROR (Status = Not started) ASSERT [CpuFeaturesDxe] X:\XXX\XXX\RegisterCpuFeaturesLib\ DxeRegisterCpuFeaturesLib.c(149): !EFI_ERROR (Status) The code

Re: [edk2-devel] [PATCH] IntelFsp2Pkg: Fix various typos

2019-07-07 Thread Zeng, Star
Reviewed-by: Star Zeng > -Original Message- > From: Antoine Cœur [mailto:co...@gmx.fr] > Sent: Friday, July 5, 2019 10:17 PM > To: devel@edk2.groups.io; Desimone, Nathaniel L > ; Zeng, Star ; Chiu, > Chasel > Cc: Antoine Cœur > Subject: [PATCH] IntelFsp2Pkg: Fi

Re: [edk2-devel] [PATCH v2] IntelFsp2Pkg: FSP Python scripts to support 3.x.

2019-07-01 Thread Zeng, Star
Reviewed-by: Star Zeng . Thanks, Star -Original Message- From: Chiu, Chasel Sent: Monday, July 1, 2019 2:20 PM To: devel@edk2.groups.io Cc: Ma, Maurice ; Desimone, Nathaniel L ; Zeng, Star Subject: [PATCH v2] IntelFsp2Pkg: FSP Python scripts to support 3.x. https

Re: [edk2-devel] [Patch] MdeModulePkg/PiSmmCore: Use unique structure signatures

2019-06-28 Thread Zeng, Star
Good idea. Reviewed-by: Star Zeng . Thanks, Star > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Michael D Kinney > Sent: Saturday, June 29, 2019 4:19 AM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Wu, Hao A ; >

Re: [edk2-devel] [PATCH] IntelFsp2Pkg: FSP Python scripts to support 3.x.

2019-06-27 Thread Zeng, Star
devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Chiu, Chasel Sent: Monday, June 24, 2019 10:35 PM To: devel@edk2.groups.io Cc: Ma, Maurice ; Desimone, Nathaniel L ; Zeng, Star Subject: [edk2-devel] [PATCH] IntelFsp2Pkg: FSP Python scripts to support 3.x. https://bugzilla.tianocore.org/

[edk2-devel] [PATCH] MdeModulePkg SmbiosMeasurementDxe: Add Type4 Voltage field to blacklist

2019-06-27 Thread Zeng, Star
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1922 The Type4 Voltage field may be various. So this patch adds it into the blacklist. Signed-off-by: Star Zeng Cc: Jian J Wang Cc: Hao A Wu Cc: Ray Ni Cc: Donald Kuo Cc: Chasel Chiu ---

Re: [edk2-devel] [PATCH 0/4] Remove S3Lib and RecoveryLib

2019-06-21 Thread Zeng, Star
Removed-by: Star Zeng to the series. > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Zhang, Shenglei > Sent: Friday, June 21, 2019 11:00 AM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Wu, Hao A ; > Ni, Ray ; Zen

Re: [edk2-devel] [PATCH v2] IntelFsp2Pkg: add TempRamExitPpi.h.

2019-06-16 Thread Zeng, Star
Reviewed-by: Star Zeng -Original Message- From: Chiu, Chasel Sent: Monday, June 17, 2019 10:42 AM To: devel@edk2.groups.io Cc: Desimone, Nathaniel L ; Zeng, Star Subject: [PATCH v2] IntelFsp2Pkg: add TempRamExitPpi.h. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1883 Add

Re: [edk2-devel] [PATCH] IntelFsp2Pkg: add TempRamExitPpi.h.

2019-06-16 Thread Zeng, Star
And the 'Ppi' postfix seems not needed in the file name. Thanks, Star > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Zeng, Star > Sent: Sunday, June 16, 2019 9:11 PM > To: Chiu, Chasel ; devel@edk2.groups.io > Cc: Des

Re: [edk2-devel] [PATCH] IntelFsp2Pkg: add TempRamExitPpi.h.

2019-06-16 Thread Zeng, Star
Temporary memory exit. 2. The gFspTempRamExitPpiGuid should be added into IntelFsp2Pkg.dec, right? Thanks, Star > -Original Message- > From: Chiu, Chasel > Sent: Friday, June 14, 2019 5:56 PM > To: devel@edk2.groups.io > Cc: Desimone, Nathaniel L ; Zeng, Star >

[edk2-devel] [PATCH V2] UefiCpuPkg RegisterCpuFeaturesLib.h: Fix typo 'STRICK' to 'STRIKE'

2019-06-10 Thread Zeng, Star
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1642 This patch fixes typo in CPU_FEATURE_THREE_STRICK_COUNTER. CPU_FEATURE_THREE_STRICK_COUNTER -> CPU_FEATURE_THREE_STRIKE_COUNTER Cc: Laszlo Ersek Cc: Eric Dong Cc: Ray Ni Cc: Chandana Kumar Cc: Kevin Li Signed-off-by: Star Zeng

[edk2-devel] [PATCH] UefiCpuPkg RegisterCpuFeaturesLib.h: Fix typo 'STRICK' to 'STRIKE'

2019-06-10 Thread Zeng, Star
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1642 This patch fixed typo in CPU_FEATURE_THREE_STRICK_COUNTER. CPU_FEATURE_THREE_STRICK_COUNTER -> CPU_FEATURE_THREE_STRIKE_COUNTER Cc: Laszlo Ersek Cc: Eric Dong Cc: Ray Ni Cc: Chandana Kumar Cc: Kevin Li Signed-off-by: Star Zeng ---

Re: [edk2-devel] [RFC] Proposal to move IntelSiliconPkg from edk2 repo to edk2-platforms repo

2019-06-05 Thread Zeng, Star
Just curious about where the IntelSiliconPkg will be put in edk2-platforms repo? Thanks, Star From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Chaganty, Rangasai V Sent: Wednesday, May 22, 2019 3:13 PM To: devel@edk2.groups.io Cc: Kinney, Michael D ; Ni, Ray Subject:

Re: [edk2-devel] [Patch V2] EmulatorPkg: don't diaplay the cpu current speed

2019-06-05 Thread Zeng, Star
> -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Laszlo Ersek > Sent: Wednesday, June 5, 2019 4:03 PM > To: Ni, Ray ; Gao, Liming ; > ard.biesheu...@linaro.org; Leif Lindholm ; Kinney, > Michael D ; Liu, Zhiguang > ; Justen, Jordan L ; > Andrew

Re: [edk2-devel] [PATCH 0/2] Fix GP fault issue and enhance code about ProcTrace

2019-06-03 Thread Zeng, Star
Laszlo, > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Monday, June 3, 2019 8:03 PM > To: Zeng, Star > Cc: Dong, Eric ; Ni, Ray ; Kumar, > Chandana C ; Li, Kevin Y > ; edk2-devel-groups-io > Subject: Re: [PATCH 0/2] Fix GP fault issu

Re: [edk2-devel] [PATCH 0/4] Define SERIAL_DXE_FILE_GUID only once

2019-06-01 Thread Zeng, Star
devel-groups-io ; Anthony PERARD > > Cc: Wang, Jian J ; Ni, Ray ; Zeng, > Star ; Wu, Hao A ; Julien Grall > ; Leif Lindholm ; Laszlo > Ersek > Subject: Re: [edk2-devel] [PATCH 0/4] Define SERIAL_DXE_FILE_GUID only > once > > On Wed, 29 May 2019 at 13:37, Anthony PERARD >

[edk2-devel] [PATCH 1/2] UefiCpuPkg CpuCommFeaturesLib: Disable TraceEn at the beginning

2019-06-01 Thread Zeng, Star
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1809 Current code disables TraceEn at the end of ProcTraceInitialize(), then there will be much memory allocated even when ProcTrace feature is disabled. This patch updates code to disable TraceEn and return at the beginning of

[edk2-devel] [PATCH 2/2] UefiCpuPkg CpuCommFeaturesLib: Fix GP fault issue about ProcTrace

2019-06-01 Thread Zeng, Star
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1808 In current code, the values of TopaEntryPtr->Uint64 for TopaTable and the values of OutputBaseReg.Uint64 and OutputMaskPtrsReg.Uint64 to register table write for RTIT_OUTPUT_BASE and RTIT_OUTPUT_MASK_PTRS are not been initialized in whole.

[edk2-devel] [PATCH 0/2] Fix GP fault issue and enhance code about ProcTrace

2019-06-01 Thread Zeng, Star
This patch series mainly fixes GP fault issue about ProcTrace for https://bugzilla.tianocore.org/show_bug.cgi?id=1808. It aslo enhances code about ProcTrace for https://bugzilla.tianocore.org/show_bug.cgi?id=1809. Please check the individual patches for detail. Cc: Laszlo Ersek Cc: Eric Dong

[edk2-devel] [PATCH 2/2] UefiCpuPkg CpuCommFeaturesLib: Fix GP fault issue about ProcTrace

2019-06-01 Thread Zeng, Star
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1808 In current code, the values of TopaEntryPtr->Uint64 for TopaTable and the values of OutputBaseReg.Uint64 and OutputMaskPtrsReg.Uint64 to register table write for RTIT_OUTPUT_BASE and RTIT_OUTPUT_MASK_PTRS are not been initialized in whole.

[edk2-devel] [PATCH 0/2] Fix GP fault issue and enhance code about ProcTrace

2019-06-01 Thread Zeng, Star
This patch series mainly fixes GP fault issue about ProcTrace for https://bugzilla.tianocore.org/show_bug.cgi?id=1808. It aslo enhances code about ProcTrace for https://bugzilla.tianocore.org/show_bug.cgi?id=1809. Please check the individual patches for detail. Cc: Laszlo Ersek Cc: Eric Dong

[edk2-devel] [PATCH 1/2] UefiCpuPkg CpuCommFeaturesLib: Disable TraceEn at the beginning

2019-06-01 Thread Zeng, Star
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1809 Current code disables TraceEn at the end of ProcTraceInitialize(), then there will be much memory allocated even when ProcTrace feature is disabled. This patch updates code to disable TraceEn and return at the beginning of

Re: [edk2-devel] [PATCH v2] IntelFsp2Pkg/SplitFspBin.py: Support rebasing 1.x binary.

2019-05-30 Thread Zeng, Star
Reviewed-by: Star Zeng -Original Message- From: Chiu, Chasel Sent: Thursday, May 30, 2019 12:58 PM To: devel@edk2.groups.io Cc: Ma, Maurice ; Desimone, Nathaniel L ; Zeng, Star Subject: [PATCH v2] IntelFsp2Pkg/SplitFspBin.py: Support rebasing 1.x binary. REF: https

Re: [edk2-devel] [PATCH] IntelFsp2Pkg/FspSplitBin.py: Support rebasing 1.x binary.

2019-05-29 Thread Zeng, Star
Shouldn't the SplitFspBinUserManual.md also be updated? Thanks, Star > -Original Message- > From: Chiu, Chasel > Sent: Wednesday, May 29, 2019 10:33 PM > To: devel@edk2.groups.io > Cc: Ma, Maurice ; Desimone, Nathaniel L > ; Zeng, Star > Subject: [PATCH] IntelF

Re: [edk2-devel] [PATCH V2] UefiCpuPkg CpuCommFeaturesLib: Fix ASSERT if LMCE is supported

2019-05-22 Thread Zeng, Star
Laszlo, > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Wednesday, May 22, 2019 6:32 PM > To: devel@edk2.groups.io; Zeng, Star > Cc: Dong, Eric ; Ni, Ray ; Kumar, > Chandana C ; Li, Kevin Y > > Subject: Re: [edk2-deve

[edk2-devel] [PATCH V2] UefiCpuPkg CpuCommFeaturesLib: Fix ASSERT if LMCE is supported

2019-05-22 Thread Zeng, Star
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1829 There will be ASSERT if LMCE is supported as below. DXE_ASSERT!: [CpuFeaturesDxe] XXX\UefiCpuPkg\Library\CpuCommonFeaturesLib\MachineCheck.c (342): ConfigData != ((void *) 0) The code should get Config Data and

[edk2-devel] [PATCH] UefiCpuPkg CpuCommFeaturesLib: Fix ASSERT if LMCE is supported

2019-05-21 Thread Zeng, Star
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1829 There will be ASSERT if LMCE is supported as below. DXE_ASSERT!: [CpuFeaturesDxe] XXX\UefiCpuPkg\Library\CpuCommonFeaturesLib\MachineCheck.c (342): ConfigData != ((void *) 0) The code should get Config Data and

[edk2-devel] [PATCH V2] UefiCpuPkg CpuCommFeaturesLib: Reduce to set MSR_IA32_CLOCK_MODULATION

2019-05-21 Thread Zeng, Star
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1810 This patch covers two problems. 1. Current code gets CPUID_THERMAL_POWER_MANAGEMENT in ClockModulationInitialize() and uses its ECMD bit for all processors. But ClockModulationInitialize() is only executed by BSP, that means the bit is just

Re: [edk2-devel] [edk2] [PATCH] IntelSiliconPkg VTdDxe: a question about the source code

2019-05-19 Thread Zeng, Star
about this. You may submit Bugzilla at https://bugzilla.tianocore.org if you wait. Thanks, Star From: Jerry Zhou(BJ-RD) [mailto:jerryz...@zhaoxin.com] Sent: Monday, May 13, 2019 7:28 PM To: Zeng, Star ; edk2-de...@lists.01.org; devel@edk2.groups.io Cc: Yao, Jiewen ; Ni, Ray Subject: 答复: [edk2

[edk2-devel] [PATCH] UefiCpuPkg CpuCommFeaturesLib: Reduce to set MSR_IA32_CLOCK_MODULATION

2019-05-18 Thread Zeng, Star
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1810 This patch covers two problems. 1. Current code gets CPUID_THERMAL_POWER_MANAGEMENT in ClockModulationInitialize() and uses its ECMD bit for all processors. But ClockModulationInitialize() is only executed by BSP, that means the bit is just

Re: [edk2-devel] [PATCH] UefiCpuPkg CpuCommonFeaturesLib: Remove CPU generation check

2019-05-17 Thread Zeng, Star
Thanks for the understanding to all of you. Star > -Original Message- > From: Ni, Ray > Sent: Friday, May 17, 2019 9:11 PM > To: Zeng, Star ; devel@edk2.groups.io; > ler...@redhat.com > Cc: Dong, Eric ; Kumar, Chandana C > ; Li, Kevin Y > Subject: RE: [edk2-d

Re: [edk2-devel] [PATCH] UefiCpuPkg CpuCommonFeaturesLib: Remove CPU generation check

2019-05-16 Thread Zeng, Star
; Sent: Friday, May 17, 2019 9:04 AM > To: Zeng, Star ; devel@edk2.groups.io; > ler...@redhat.com > Cc: Dong, Eric ; Kumar, Chandana C > > Subject: RE: [edk2-devel] [PATCH] UefiCpuPkg CpuCommonFeaturesLib: > Remove CPU generation check > > Star, > I think the disc

Re: [edk2-devel] [PATCH] UefiCpuPkg CpuCommonFeaturesLib: Remove CPU generation check

2019-05-16 Thread Zeng, Star
Laszlo, > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Laszlo Ersek > Sent: Thursday, May 16, 2019 9:06 PM > To: Zeng, Star ; devel@edk2.groups.io > Cc: Dong, Eric ; Ni, Ray ; Kumar, > Chandana C > Subject:

[edk2-devel] [PATCH] UefiCpuPkg CpuCommonFeaturesLib: Remove CPU generation check

2019-05-16 Thread Zeng, Star
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1679 The checking to CpuInfo->CpuIdVersionInfoEcx.Bits.AESNI is enough, the checking to CPU generation could be removed, then the code could be reused by more platforms. Cc: Laszlo Ersek Cc: Eric Dong Cc: Ruiyu Ni Cc: Chandana Kumar

Re: [edk2-devel] [PATCH] IntelFsp2WrapperPkg/FspsWrapperPeim: Fix coding style.

2019-04-22 Thread Zeng, Star
Reviewed-by: Star Zeng -Original Message- From: Chiu, Chasel Sent: Monday, April 22, 2019 6:12 PM To: devel@edk2.groups.io Cc: Desimone, Nathaniel L ; Zeng, Star Subject: [PATCH] IntelFsp2WrapperPkg/FspsWrapperPeim: Fix coding style. REF: https://bugzilla.tianocore.org/show_bug.cgi

Re: [edk2-devel] [PATCH v2] IntelFsp2WrapperPkg: Perform post FSP-S process.

2019-04-15 Thread Zeng, Star
: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Zeng, Star > Subject: [PATCH v2] IntelFsp2WrapperPkg: Perform post FSP-S process. > > From: "Chasel, Chiu" > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1716 > > In API mode F

Re: [edk2-devel] [PATCH] IntelFsp2WrapperPkg: Perform post FSP-S process.

2019-04-14 Thread Zeng, Star
Minor comment inline. > -Original Message- > From: Chiu, Chasel > Sent: Friday, April 12, 2019 11:02 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Zeng, Star > Subject: [PATCH] IntelFsp2WrapperPkg: Perform post FSP-S process. >