Re: [edk2-devel] [PATCH 1/2] BaseTools: Change CLANGPDB target to reduce image size

2020-03-24 Thread Vitaly Cheptsov via Groups.Io
Hello,

While I can imagine this landing as an absolutely last effort resort, at the 
moment the problem is unclear and unjustified. Do not rush with this patch 
please and proceed with the discussion in BZ.

Best wishes,
Vitaly 

> 24 марта 2020 г., в 09:20, Zhiguang Liu  написал(а):
> 
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2628
> 
> Using target i686-unknown-windows will generate smaller IA32 FV.
> 
> CC: Vitaly Cheptsov 
> CC: Liming Gao 
> CC: Bob Feng 
> Signed-off-by: Zhiguang Liu 
> ---
> BaseTools/Conf/tools_def.template | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/BaseTools/Conf/tools_def.template 
> b/BaseTools/Conf/tools_def.template
> index 2b17d3b297..3d6f6b4b4c 100755
> --- a/BaseTools/Conf/tools_def.template
> +++ b/BaseTools/Conf/tools_def.template
> @@ -2755,7 +2755,7 @@ RELEASE_CLANG38_AARCH64_DLINK_FLAGS = 
> DEF(CLANG38_AARCH64_DLINK_FLAGS) -flto -Wl
> DEFINE CLANGPDB_IA32_PREFIX  = ENV(CLANG_BIN)
> DEFINE CLANGPDB_X64_PREFIX   = ENV(CLANG_BIN)
> 
> -DEFINE CLANGPDB_IA32_TARGET  = -target i686-unknown-windows-gnu
> +DEFINE CLANGPDB_IA32_TARGET  = -target i686-unknown-windows
> DEFINE CLANGPDB_X64_TARGET   = -target x86_64-unknown-windows-gnu
> 
> DEFINE CLANGPDB_WARNING_OVERRIDES= -Wno-parentheses-equality 
> -Wno-tautological-compare -Wno-tautological-constant-out-of-range-compare 
> -Wno-empty-body -Wno-unused-const-variable -Wno-varargs 
> -Wno-unknown-warning-option -Wno-microsoft-enum-forward-reference
> --
> 2.25.1.windows.1
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#56128): https://edk2.groups.io/g/devel/message/56128
Mute This Topic: https://groups.io/mt/72512013/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



signature.asc
Description: OpenPGP digital signature


[edk2-devel] [PATCH 1/2] BaseTools: Change CLANGPDB target to reduce image size

2020-03-24 Thread Zhiguang Liu
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2628

Using target i686-unknown-windows will generate smaller IA32 FV.

CC: Vitaly Cheptsov 
CC: Liming Gao 
CC: Bob Feng 
Signed-off-by: Zhiguang Liu 
---
 BaseTools/Conf/tools_def.template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/BaseTools/Conf/tools_def.template 
b/BaseTools/Conf/tools_def.template
index 2b17d3b297..3d6f6b4b4c 100755
--- a/BaseTools/Conf/tools_def.template
+++ b/BaseTools/Conf/tools_def.template
@@ -2755,7 +2755,7 @@ RELEASE_CLANG38_AARCH64_DLINK_FLAGS = 
DEF(CLANG38_AARCH64_DLINK_FLAGS) -flto -Wl
 DEFINE CLANGPDB_IA32_PREFIX  = ENV(CLANG_BIN)
 DEFINE CLANGPDB_X64_PREFIX   = ENV(CLANG_BIN)
 
-DEFINE CLANGPDB_IA32_TARGET  = -target i686-unknown-windows-gnu
+DEFINE CLANGPDB_IA32_TARGET  = -target i686-unknown-windows
 DEFINE CLANGPDB_X64_TARGET   = -target x86_64-unknown-windows-gnu
 
 DEFINE CLANGPDB_WARNING_OVERRIDES= -Wno-parentheses-equality 
-Wno-tautological-compare -Wno-tautological-constant-out-of-range-compare 
-Wno-empty-body -Wno-unused-const-variable -Wno-varargs 
-Wno-unknown-warning-option -Wno-microsoft-enum-forward-reference
-- 
2.25.1.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#56127): https://edk2.groups.io/g/devel/message/56127
Mute This Topic: https://groups.io/mt/72512013/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-