Merged as f69888ada859..35bca3ca71c0
Thanks.
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119355): https://edk2.groups.io/g/devel/message/119355
Mute This Topic: https://groups.io/mt/106365450/21656
Group
Other than my comments for patch 14 and 15 (the changes for which I will fix
locally before merging), this patch series looks good to me.
For this series,
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
Hi Sahil,
I will drop the loop before merging the changes.
Other than that this patch looks good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
From: Sahil Kaushal
Date: Wednesday 29 May 2024 at 12:51
To: Sami Mujawar , "devel@edk2.groups.io"
Cc: Ard Biesheuvel , Leif Lindholm
Hi Sami,
Thank you for reviewing the patch.
You are right. The do-while loop is redundant and hence can be removed.
Thanks,
Sahil
From: Sami Mujawar
Date: Wednesday, 29 May 2024 at 5:06 PM
To: Sahil Kaushal , devel@edk2.groups.io
Cc: Ard Biesheuvel , Leif Lindholm
, nd
Subject: Re:
Hi Sahil,
There is a typo in one of the macro names, see my comment inline marked [SAMI].
I will fix that up before merging.
Other than that, this patch looks good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 29/05/2024, 09:56, "Sahil Kaushal" mailto:sahil.kaus...@arm.com>>
Hi Sahil,
Please find my feedback inline marked [SAMI].
Regards,
Sami Mujawar
On 29/05/2024, 09:56, "Sahil Kaushal" mailto:sahil.kaus...@arm.com>> wrote:
From: sahil mailto:sa...@arm.com>>
In N1Sdp platform, the SoC is connected to IOFPGA which has a
Cadence Quad SPI (QSPI) controller.
[AMD Official Use Only - AMD Internal Distribution Only]
Reviewed-by: Abner Chang
> -Original Message-
> From: Abdul Lateef Attar
> Sent: Tuesday, May 28, 2024 10:08 PM
> To: devel@edk2.groups.io
> Cc: Attar, AbdulLateef (Abdul Lateef) ; Chang,
> Abner ; Grimes, Paul
> Subject:
[AMD Official Use Only - AMD Internal Distribution Only]
Reviewed-by: Abner Chang
> -Original Message-
> From: Abdul Lateef Attar
> Sent: Tuesday, May 28, 2024 10:08 PM
> To: devel@edk2.groups.io
> Cc: Attar, AbdulLateef (Abdul Lateef) ; Chang,
> Abner ; Grimes, Paul
> Subject:
[AMD Official Use Only - AMD Internal Distribution Only]
Reviewed-by: Abner Chang
> -Original Message-
> From: Abdul Lateef Attar
> Sent: Tuesday, May 28, 2024 10:08 PM
> To: devel@edk2.groups.io
> Cc: Attar, AbdulLateef (Abdul Lateef) ; Chang,
> Abner ; Grimes, Paul
> Subject:
From: sahil
This driver enables Fault Tolerant Write protocol, which provides
fault tolerant write capability for block devices.
Signed-off-by: sahil
---
Platform/ARM/N1Sdp/N1SdpPlatform.dsc | 5 +
Platform/ARM/N1Sdp/N1SdpPlatform.fdf | 1 +
2 files changed, 6 insertions(+)
diff --git
From: sahil
Enable persistent storage on QSPI flash device.
Signed-off-by: sahil
---
Platform/ARM/N1Sdp/N1SdpPlatform.dsc | 19 ++-
Platform/ARM/N1Sdp/N1SdpPlatform.fdf | 2 ++
2 files changed, 16 insertions(+), 5 deletions(-)
diff --git
From: sahil
In N1Sdp platform, the SoC is connected to IOFPGA which has a
Cadence Quad SPI (QSPI) controller. This QSPI controller manages
the flash chip device via QSPI bus.
This patch adds CadenceQspiNorFlashDeviceLib which is used to
manage and access the above configuration.
Signed-off-by:
From: sahil
Add NOR flash library, this library provides APIs for getting the list
of NOR flash devices on the platform.
This flash is shared between AP core and System Control Processor. The
lower addresses are used to store SCP and AP boot images and higher
addresses will be used for variable
From: sahil
Enable SCP QSPI flash region access by adding it in the PlatformLibMem.
This flash is shared between AP core and System Control Processor. The
lower addresses are used to store SCP and AP boot images and higher
addresses will be used for variable storage.
Signed-off-by: sahil
---
From: sahil
This patch adds an optional functionality in NorFlashDxe to fetch and
print NOR Flash information from NorFlashInfoLib using its JEDEC ID.
NOR Flash libraries will implement a function "NorFlashReadID" which
will fetch and return JEDEC ID. This JEDEC ID can be then printed
along
From: sahil
This patch adds error_handler1 and error_handler2 labels in
NorFlashCreateInstance() function to handle the cleanup.
error_handler1: Frees just the Instance structure as the
ShadowBuffer is not allocated yet.
error_handler2: Frees both Instance and Instance->ShadowBuffer.
From: sahil
This variable holds the QSPI controller's base address.
It is defined in ARM.dec as well with the default value of 0x0.
In case a platform is not using it, they can just ignore this
variable and the default value of 0x0 will be propogated and
the variable will not be used.
From: sahil
NorFlashDeviceLib can be used to provide implementations of different
NOR Flash to NorFlashDxe, i.e. NorFlashDxe links with NorFlashDeviceLib
and the platforms can specify their respective NorFlashDeviceLib
instances.
This patch adds the following major changes:
1. Adds changes in
From: sahil
This patch implements functions to interact with P30 NOR Flash.
The code is taken from Platform/ARM/Drivers/NorFlashDxe/NorFlash.c
file.
Signed-off-by: sahil
---
Platform/ARM/Library/P30NorFlashDeviceLib/P30NorFlashDeviceLib.inf | 35 +
From: sahil
NorFlashDeviceLib can be used to provide implementations of different
NOR Flash to NorFlashDxe, i.e. NorFlashDxe links with NorFlashDeviceLib
and the platforms can specify their respective NorFlashDeviceLib
instances.
This patch splits NorFlash.h and moves out the function
From: sahil
This patch makes local functions not being used outside
NorFlash.c STATIC.
Also, NorFlashWriteBuffer() is specific to a particular
flash implementation and need not be implemented by
other NOR flash device IPs.
Signed-off-by: sahil
---
Platform/ARM/Drivers/NorFlashDxe/NorFlash.h |
From: sahil
This patch removes NorFlashReadCfiData() and NorFlashWrite()
prototypes from NorFlash.h as these are not implemented or
used anywhere in NorFlashDxe driver.
Signed-off-by: sahil
---
Platform/ARM/Drivers/NorFlashDxe/NorFlash.h | 17 -
1 file changed, 17 deletions(-)
From: sahil
Refactoring done in this patch has two major parts:
1. Moving out NorFlashUnlockAndEraseSingleBlock and
NorFlashWriteFullBlock functions from NorFlashDxe.c and
NorFlashStandaloneMm.c to NorFlash.c files.
2. At the same time, we are adding NorFlashLock and NorFlashUnlock
functions
From: sahil
This patch splits NorFlash.h and adds NorFlashCommon.h which
will have all the flash independent functions and macros.
Whereas all the flash specific functions will be in NorFlash.h
header file.
Signed-off-by: sahil
---
Platform/ARM/Drivers/NorFlashDxe/NorFlashDxe.inf |
From: sahil
Moving this function from NorFlash.c to NorFlashDxe.c as it is not
dependent on any particular flash implementation.
Signed-off-by: sahil
---
Platform/ARM/Drivers/NorFlashDxe/NorFlash.h| 14 +++
Platform/ARM/Drivers/NorFlashDxe/NorFlash.c| 44
From: sahil
Moving these functions from NorFlash.c to NorFlashBlockIoDxe.c as
they are not dependent on any particular flash implementation.
Signed-off-by: sahil
---
Platform/ARM/Drivers/NorFlashDxe/NorFlash.c | 129
From: sahil
This patch series adds the following changes:
1. Splits the NorFlashDxe driver to introduce a NorFlashDeviceLib that
implements the specifics for the respective flash. This will allow us
to plug different libraries implementing functionality of various NOR
Flash. The flash specific
Implements SmmCorePlatformHookLib library for AMD platform.
Cc: Abner Chang
Cc: Paul Grimes
Signed-off-by: Abdul Lateef Attar
---
.../AMD/AmdPlatformPkg/AmdPlatformPkg.dec | 5 +
.../AMD/AmdPlatformPkg/AmdPlatformPkg.dsc | 6 +
.../Library/AmdSmmCorePlatformHookLib.h | 68
Register a smm core platform hook handler for SPI device,
using AMD SmmCorePlatformHookLib library.
This platform hook saves the SPI host controller state.
Cc: Abner Chang
Cc: Paul Grimes
Signed-off-by: Abdul Lateef Attar
---
.../AMD/AmdPlatformPkg/AmdPlatformPkg.dec | 3 +
Removes unused gBoardBdsBootFromDevicePathProtocolGuid protocol,
and its corresponding code changes.
Adds missing Pcd/SmbiosPcd.h file.
Cc: Abner Chang
Cc: Paul Grimes
Signed-off-by: Abdul Lateef Attar
---
.../AmdPlatformPkg/Include/Pcd/SmbiosPcd.h| 58
PR: https://github.com/tianocore/edk2-platforms/pull/148
Fix the build failure for SmbiosDxe driver by removing
unused protocol.
Adds PCD defines for smbios.
Adds SPI supporting libraries.
Cc: Abner Chang
Cc: Paul Grimes
Abdul Lateef Attar (3):
AmdPlatformPkg: Removes unused
[AMD Official Use Only - AMD Internal Distribution Only]
This patch set was reviewed on GitHub PR.
Hi Abdul, please go ahead to push this patch.
Thanks!
Reviewed-by: Abner Chang
> -Original Message-
> From: Abdul Lateef Attar
> Sent: Tuesday, May 28, 2024 11:28 AM
> To:
Fix windows VC compilattion warning for AcpiCommon driver.
Cc: Paul Grimes
Cc: Abner Chang
Signed-off-by: Abdul Lateef Attar
---
.../AMD/AmdPlatformPkg/Universal/Acpi/AcpiCommon/PciSsdt.c| 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
PR: https://github.com/tianocore/edk2-platforms/pull/146
Cc: Paul Grimes
Cc: Abner Chang
Abdul Lateef Attar (2):
AmdPlatformPkg: Corrects file path of LogoDxe driver
AmdPlatformPkg: Fix windows VC compilation warning
.../Universal/Acpi/AcpiCommon/PciSsdt.c | 4 +-
Removes extra directory.
Cc: Paul Grimes
Cc: Abner Chang
Signed-off-by: Abdul Lateef Attar
---
.../LogoDxe/{LogoDxe => }/JpegLogo.idf| 0
.../LogoDxe/{LogoDxe => }/JpegLogoDxe.inf | 0
.../Universal/LogoDxe/{LogoDxe => }/Logo.bmp | Bin
The transition now is simpler and more streamlined than what is
described there. I'll update the project to reflect the current state so
it can serve as a reference and guide related work in the future.
Thanks,
Michael
On 5/24/2024 8:20 AM, Rebecca Cran wrote:
There's a GitHub Project for
There's a GitHub Project for this at
https://github.com/orgs/tianocore/projects/5 which it looks like Michael
Kubacki created last year. I suspect it's obsolete though, since it
looks like the tasks haven't been updated recently.
--
Rebecca Cran
On 5/1/24 11:43 AM, Michael D Kinney wrote:
Reviewed-by: Abdul Lateef Attar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119205): https://edk2.groups.io/g/devel/message/119205
Mute This Topic: https://groups.io/mt/106257080/21656
Group Owner: devel+ow...@edk2.groups.io
Reviewed-by: Abdul Lateef Attar (
abdullateef.at...@amd.com )
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119204): https://edk2.groups.io/g/devel/message/119204
Mute This Topic: https://groups.io/mt/106257082/21656
Group Owner:
ups.io ; michael.d.kin...@intel.com
; Chang, Abner
Cc: Leif Lindholm
Subject: Re: [edk2-devel] [edk2-platforms][PATCH 3/3] edk2-platform/Maintainer:
Add entries for AMD packages
Caution: This message originated from an External Source. Use proper caution
when opening attachments, clicking links, or resp
[AMD Official Use Only - AMD Internal Distribution Only]
Thanks for the up-stream, Abner.
Looks good to me.
Reviewed-by: Paul Grimes
From: Yao, Ken
Sent: Thursday, May 23, 2024 1:30:48 AM
To: Zhai, MingXin (Duke) ; Chang, Abner
; devel@edk2.groups.io
Cc:
Reviewed-by: Abdul Lateef Attar
On 23-05-2024 21:57, Michael D Kinney via groups.io wrote:
Caution: This message originated from an External Source. Use proper caution
when opening attachments, clicking links, or responding.
Reviewed-by: Michael D Kinney
-Original Message-
Reviewed-by: Michael D Kinney
> -Original Message-
> From: abner.ch...@amd.com
> Sent: Wednesday, May 22, 2024 9:12 PM
> To: devel@edk2.groups.io
> Cc: Leif Lindholm ; Kinney, Michael D
>
> Subject: [edk2-platforms][PATCH 3/3] edk2-platform/Maintainer: Add entries
> for AMD packages
>
Hi Sahil,
I cannot apply your patches cleanly. Can you share a github branch with your
patches, please?
Regards,
Sami Mujawar
On 23/05/2024, 11:56, "Sahil Kaushal" mailto:sahil.kaus...@arm.com>> wrote:
From: sahil mailto:sa...@arm.com>>
Moving these functions from NorFlash.c to
Hi Sahil,
Thank you for this patch.
I have a minor suggession marked inline as [SAMI].
Otherwise this patch looks good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 23/05/2024 11:55 am, Sahil Kaushal wrote:
From: sahil
This patch adds error_handler1 and error_handler2 labels
[AMD Official Use Only - AMD Internal Distribution Only]
[AMD Official Use Only - AMD Internal Distribution Only]
Thanks Abner for the up-stream.
Looks good to me.
Reviewed-by: Ken Yao
-Original Message-
From: Zhai, MingXin (Duke)
Sent: Thursday, May 23, 2024 3:47 PM
To: Chang, Abner
From: sahil
This driver enables Fault Tolerant Write protocol, which provides
fault tolerant write capability for block devices.
Signed-off-by: sahil
---
Platform/ARM/N1Sdp/N1SdpPlatform.dsc | 5 +
Platform/ARM/N1Sdp/N1SdpPlatform.fdf | 1 +
2 files changed, 6 insertions(+)
diff --git
From: sahil
Enable persistent storage on QSPI flash device.
Signed-off-by: sahil
---
Platform/ARM/N1Sdp/N1SdpPlatform.dsc | 19 ++-
Platform/ARM/N1Sdp/N1SdpPlatform.fdf | 2 ++
2 files changed, 16 insertions(+), 5 deletions(-)
diff --git
From: sahil
In N1Sdp platform, the SoC is connected to IOFPGA which has a
Cadence Quad SPI (QSPI) controller. This QSPI controller manages
the flash chip device via QSPI bus.
This patch adds CadenceQspiNorFlashDeviceLib which is used to
manage and access the above configuration.
Signed-off-by:
From: sahil
Add NOR flash library, this library provides APIs for getting the list
of NOR flash devices on the platform.
This flash is shared between AP core and System Control Processor. The
lower addresses are used to store SCP and AP boot images and higher
addresses will be used for variable
From: sahil
Enable SCP QSPI flash region access by adding it in the PlatformLibMem.
This flash is shared between AP core and System Control Processor. The
lower addresses are used to store SCP and AP boot images and higher
addresses will be used for variable storage.
Signed-off-by: sahil
---
From: sahil
This patch adds an optional functionality in NorFlashDxe to fetch and
print NOR Flash information from NorFlashInfoLib using its JEDEC ID.
NOR Flash libraries will implement a function "NorFlashReadID" which
will fetch and return JEDEC ID. This JEDEC ID can be then printed
along
From: sahil
This patch adds error_handler1 and error_handler2 labels in
NorFlashCreateInstance() function to handle the cleanup.
error_handler1: Frees just the Instance structure as the
ShadowBuffer is not allocated yet.
error_handler2: Frees both Instance and Instance->ShadowBuffer.
From: sahil
This variable holds the QSPI controller's base address.
It is defined in ARM.dec as well with the default value of 0x0.
In case a platform is not using it, they can just ignore this
variable and the default value of 0x0 will be propogated and
the variable will not be used.
From: sahil
NorFlashDeviceLib can be used to provide implementations of different
NOR Flash to NorFlashDxe, i.e. NorFlashDxe links with NorFlashDeviceLib
and the platforms can specify their respective NorFlashDeviceLib
instances.
This patch adds the following major changes:
1. Adds changes in
From: sahil
This patch implements functions to interact with P30 NOR Flash.
The code is taken from Platform/ARM/Drivers/NorFlashDxe/NorFlash.c
file.
Signed-off-by: sahil
---
Platform/ARM/Library/P30NorFlashDeviceLib/P30NorFlashDeviceLib.inf | 35 +
From: sahil
NorFlashDeviceLib can be used to provide implementations of different
NOR Flash to NorFlashDxe, i.e. NorFlashDxe links with NorFlashDeviceLib
and the platforms can specify their respective NorFlashDeviceLib
instances.
This patch splits NorFlash.h and moves out the function
From: sahil
This patch makes local functions not being used outside
NorFlash.c STATIC.
Also, NorFlashWriteBuffer() is specific to a particular
flash implementation and need not be implemented by
other NOR flash device IPs.
Signed-off-by: sahil
---
Platform/ARM/Drivers/NorFlashDxe/NorFlash.h |
From: sahil
This patch removes NorFlashReadCfiData() and NorFlashWrite()
prototypes from NorFlash.h as these are not implemented or
used anywhere in NorFlashDxe driver.
Signed-off-by: sahil
---
Platform/ARM/Drivers/NorFlashDxe/NorFlash.h | 17 -
1 file changed, 17 deletions(-)
From: sahil
Refactoring done in this patch has two major parts:
1. Moving out NorFlashUnlockAndEraseSingleBlock and
NorFlashWriteFullBlock functions from NorFlashDxe.c and
NorFlashStandaloneMm.c to NorFlash.c files.
2. At the same time, we are adding NorFlashLock and NorFlashUnlock
functions
From: sahil
This patch splits NorFlash.h and adds NorFlashCommon.h which
will have all the flash independent functions and macros.
Whereas all the flash specific functions will be in NorFlash.h
header file.
Signed-off-by: sahil
---
Platform/ARM/Drivers/NorFlashDxe/NorFlashDxe.inf |
From: sahil
Moving this function from NorFlash.c to NorFlashDxe.c as it is not
dependent on any particular flash implementation.
Signed-off-by: sahil
---
Platform/ARM/Drivers/NorFlashDxe/NorFlash.h| 14 +++
Platform/ARM/Drivers/NorFlashDxe/NorFlash.c| 44
From: sahil
Moving these functions from NorFlash.c to NorFlashBlockIoDxe.c as
they are not dependent on any particular flash implementation.
Signed-off-by: sahil
---
Platform/ARM/Drivers/NorFlashDxe/NorFlash.c | 129
From: sahil
This patch series adds the following changes:
1. Splits the NorFlashDxe driver to introduce a NorFlashDeviceLib that
implements the specifics for the respective flash. This will allow us
to plug different libraries implementing functionality of various NOR
Flash. The flash specific
[AMD Official Use Only - AMD Internal Distribution Only]
Thanks Abner for the up-stream.
Looks good to me.
-Original Message-
From: Chang, Abner
Sent: Thursday, May 23, 2024 12:12 PM
To: devel@edk2.groups.io
Cc: Grimes, Paul ; Attar, AbdulLateef (Abdul Lateef)
; Fu, Igniculus ; Yao,
[AMD Official Use Only - AMD Internal Distribution Only]
Thanks Abner for the up-stream.
Looks good to me.
Reviewed-by: Eric Xing
> -Original Message-
> From: Chang, Abner
> Sent: Thursday, May 23, 2024 12:12 PM
> To: devel@edk2.groups.io
> Cc: Grimes, Paul ; Attar, AbdulLateef
From: Abner Chang
Cc: Paul Grimes
Cc: Abdul Lateef Attar
Cc: Igniculus Fu
Cc: Ken Yao
Cc: Eric Xing
Cc: Duke Zhai
Signed-off-by: Abner Chang
---
Platform/AMD/Readme.md | 64 --
1 file changed, 49 insertions(+), 15 deletions(-)
diff --git
From: Abner Chang
Signed-off-by: Abner Chang
Cc: Leif Lindholm
Cc: Michael D Kinney
---
Maintainers.txt | 14 +-
1 file changed, 13 insertions(+), 1 deletion(-)
diff --git a/Maintainers.txt b/Maintainers.txt
index 877620a1b0..af688c3813 100644
--- a/Maintainers.txt
+++
Adds SMBIOS common driver which generates various
tables for AMD platforms.
Cc: Paul Grimes
Reviewed-by: Abner Chang
Signed-off-by: Abdul Lateef Attar
---
.../AMD/AmdPlatformPkg/AmdPlatformPkg.dec | 61 +
.../AMD/AmdPlatformPkg/AmdPlatformPkg.dsc | 3 +-
[AMD Official Use Only - AMD Internal Distribution Only]
Reviewed-by: Abner Chang
> -Original Message-
> From: Abdul Lateef Attar
> Sent: Monday, May 20, 2024 9:50 PM
> To: devel@edk2.groups.io
> Cc: Attar, AbdulLateef (Abdul Lateef) ; Chang,
> Abner ; Grimes, Paul
> Subject:
PeiBoardInitPreMemLib library provides board-specific
initialization functions for the PEI phase.
Cc: Abner Chang
Cc: Paul Grimes
Signed-off-by: Abdul Lateef Attar
---
.../AMD/AmdMinBoardPkg/AmdMinBoardPkg.dec | 8 +
.../AMD/AmdMinBoardPkg/AmdMinBoardPkg.dsc | 5 +
[AMD Official Use Only - AMD Internal Distribution Only]
Already reviewed internally.
Reviewed-by: Abner Chang
> -Original Message-
> From: Abdul Lateef Attar
> Sent: Monday, May 20, 2024 6:24 PM
> To: devel@edk2.groups.io
> Cc: Attar, AbdulLateef (Abdul Lateef) ; Chang,
> Abner ;
Adds SMBIOS common driver which generates various
tables for AMD platforms.
Cc: Abner Chang
Cc: Paul Grimes
Signed-off-by: Abdul Lateef Attar
---
.../AMD/AmdPlatformPkg/AmdPlatformPkg.dec | 63 -
.../AMD/AmdPlatformPkg/AmdPlatformPkg.dsc | 3 +-
PeiBoardInitPreMemLib library provides board-specific
initialization functions for the PEI phase.
Cc: Abner Chang
Cc: Paul Grimes
Signed-off-by: Abdul Lateef Attar
---
.../AMD/AmdMinBoardPkg/AmdMinBoardPkg.dec | 8 +
.../AMD/AmdMinBoardPkg/AmdMinBoardPkg.dsc | 5 +
PR: https://github.com/tianocore/edk2-platforms/pull/144
V2 delta changes:
Updated the "AmdMinBoardPkg: Implement BoardInitLib for PEI phase" PATCH
with correct .dec and .dsc file.
Cc: Paul Grimes
Cc: Abner Chang
Abdul Lateef Attar (5):
AmdMinBoardPkg: Uncrustify PciHotPlug module
Changes looks good.
Reviewed-by: Jayaprakash N
Regards,
JP
-Original Message-
From: R, Vishal
Sent: Friday, May 17, 2024 12:08 PM
To: devel@edk2.groups.io
Cc: R, Vishal ; Rebecca Cran ; Kinney,
Michael D ; Jayaprakash, N
Subject: [edk2-libc Patch 1/1] edk2-libc: Add cpuid_ex API to
Hi Abner,
It' hard to say actually. I don't spend full-time for open-source work.
But I will try to complete it within 2 weeks or sooner.
Most of Ampere Altra drivers including IPMI SSIF are living at
https://github.com/AmpereComputing/edk2-platforms. The effort now is to
port to be
Hi Nickle,
Please see my comments inline...
P/s: I just realized that I can not test this protocol without IPMI SSIF
to be compatible with ManageabilityPkg framework.
On 5/15/2024 10:06 PM, Nickle Wang wrote:
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4773
This change implements
Ramirez
> Subject: RE: [EXTERNAL] RE: [edk2-devel] [edk2-redfish-client][PATCH]
> RedfishClientPkg: introduce RedfishBootstrapAccountDxe
>
> External email: Use caution opening links or attachments
>
>
> We can have some protocol where all Redfish clients register saying
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4749
This commit adds cpuid_ex function to edk2module to provide capability
to execute cpuid instruction on specific cpu.
This feature was requested via BZ 4749
Cc: Rebecca Cran
Cc: Michael D Kinney
Cc: Jayaprakash N
Signed-off-by: Vishal R
This commit adds cpuid_ex function to edk2module to provide capability
to execute cpuid instruction on specific cpu.
This feature was requested via BZ 4749
Vishal R (1):
edk2-libc: Add cpuid_ex API to execute CPUID instructions on specific
CPU
.../PyMod-3.6.8/Modules/edk2module.c
the account.
Thank you,
Igor
-Original Message-
From: Nickle Wang
Sent: Wednesday, May 15, 2024 11:10 PM
To: Chang, Abner ; Igor Kulchytskyy ;
devel@edk2.groups.io
Cc: Nick Ramirez
Subject: RE: [EXTERNAL] RE: [edk2-devel] [edk2-redfish-client][PATCH]
RedfishClientPkg: introduce
Attar, AbdulLateef (Abdul Lateef)
> ; Tinh Nguyen
>
> Subject: Re: [edk2-devel] [edk2-platforms][PATCH] ManageabilityPkg: add
> support for the phosphor ipmi blob transfer protocol
>
> Caution: This message originated from an External Source. Use proper caution
> w
On 5/16/2024 3:44 PM, Chang, Abner wrote:
[AMD Official Use Only - AMD Internal Distribution Only]
Hi Nhi,
Are you using SSIF as the transport interface based on the ManabeabilityPkg
framework? If yes, will you contribute that driver?
yes, we are. I will need to update the SSIF driver to be
4 4:40 PM
> To: devel@edk2.groups.io; nick...@nvidia.com; Chang, Abner
> ; Rebecca Cran
> Cc: Isaac Oram ; Attar, AbdulLateef (Abdul Lateef)
> ; Tinh Nguyen
>
> Subject: Re: [edk2-devel] [edk2-platforms][PATCH] ManageabilityPkg: add
> support for the phosphor ipmi blob
in this version of patch set.
Thanks,
Nickle
-Original Message-
From: Nhi Pham
Sent: Tuesday, May 14, 2024 10:26 AM
To: Nickle Wang ; devel@edk2.groups.io;
abner.ch...@amd.com; Rebecca Cran
Cc: Isaac Oram ; Attar, AbdulLateef (Abdul Lateef)
; Tinh Nguyen
Subject: Re: [edk2-devel] [edk2-platforms
Redfish design in system.
Regards,
Nickle
> -Original Message-
> From: Chang, Abner
> Sent: Thursday, May 16, 2024 10:41 AM
> To: Nickle Wang ; Igor Kulchytskyy ;
> devel@edk2.groups.io
> Cc: Nick Ramirez
> Subject: RE: [EXTERNAL] RE: [edk2-devel] [edk2-redfish-client][
; Cc: Nick Ramirez
> Subject: RE: [EXTERNAL] RE: [edk2-devel] [edk2-redfish-client][PATCH]
> RedfishClientPkg: introduce RedfishBootstrapAccountDxe
>
> [AMD Official Use Only - General]
>
> Caution: This message originated from an External Source. Use proper caution
> when opening att
vel@edk2.groups.io
> Cc: Nick Ramirez
> Subject: RE: [EXTERNAL] RE: [edk2-devel] [edk2-redfish-client][PATCH]
> RedfishClientPkg: introduce RedfishBootstrapAccountDxe
>
> External email: Use caution opening links or attachments
>
>
> [AMD Official Use Only - General]
>
&
> -Original Message-
> From: Igor Kulchytskyy
> Sent: Wednesday, May 15, 2024 11:02 PM
> To: Nickle Wang ; devel@edk2.groups.io; Chang, Abner
>
> Cc: Nick Ramirez
> Subject: RE: [EXTERNAL] RE: [edk2-devel] [edk2-redfish-client][PATCH]
> Red
Reviewed-by: Chao Li
Thanks,
Chao
On 2024/5/15 17:47, Xianglai Li wrote:
QemuFwCfgLibMmio has been removed,
using the latest FwCfgLib to fix compilation errors
Cc: Bibo Mao
Cc: Chao Li
Cc: Gerd Hoffmann
Signed-off-by: Xianglai Li
---
Platform/Loongson/LoongArchQemuPkg/Loongson.dsc | 6
10:26 AM
> To: Nickle Wang ; devel@edk2.groups.io;
> abner.ch...@amd.com; Rebecca Cran
> Cc: Isaac Oram ; Attar, AbdulLateef (Abdul Lateef)
> ; Tinh Nguyen
>
> Subject: Re: [edk2-devel] [edk2-platforms][PATCH] ManageabilityPkg: add
> support for the phosphor ipmi blob transfer pro
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4773
This change implements the blob transfer protocol used in OpenBmc
documented here: https://github.com/openbmc/phosphor-ipmi-blobs
Signed-off-by: Nick Ramirez
Co-authored-by: Nickle Wang
Cc: Abner Chang
Cc: Abdul Lateef Attar
Cc: Tinh
To: devel@edk2.groups.io; abner.ch...@amd.com; Igor Kulchytskyy
Cc: Nick Ramirez
Subject: [EXTERNAL] RE: [edk2-devel] [edk2-redfish-client][PATCH]
RedfishClientPkg: introduce RedfishBootstrapAccountDxe
**CAUTION: The e-mail below is from an external source. Please exercise caution
before opening
QemuFwCfgLibMmio has been removed,
using the latest FwCfgLib to fix compilation errors
Cc: Bibo Mao
Cc: Chao Li
Cc: Gerd Hoffmann
Signed-off-by: Xianglai Li
---
Platform/Loongson/LoongArchQemuPkg/Loongson.dsc | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git
Doug:
Thanks for your clarification. For the changes in MdePkg and EmulatorPkg, I
have no comments. Reviewed-by: Liming Gao
Thanks
Liming
发件人: Doug Flick via groups.io
发送时间: 2024年5月10日 2:26
收件人: gaoliming ; devel@edk2.groups.io
主题: Re: [edk2-devel] 回复: [edk2-devel][edk2-stable202405
Michael D
> Subject: 回复: [edk2-devel][edk2-stable202405][PATCH] MdeModulePkg: Potential
> UINT32 overflow in S3 ResumeCount
>
> Reviewed-by: Liming Gao
>
> This is a security fix. So, I think it should catch this stable tag 202405
>
> Thanks
> Liming
> > ---
Of Chang, Abner
> via groups.io
> Sent: Tuesday, April 23, 2024 3:42 PM
> To: Nickle Wang ; Igor Kulchytskyy ;
> devel@edk2.groups.io
> Cc: Nick Ramirez
> Subject: Re: [edk2-devel] [edk2-redfish-client][PATCH] RedfishClientPkg:
> introduce RedfishBootstrapAccountDxe
>
-Introduce RedfishBootstrapAccountDxe to delete bootstrap
account from /redfish/v1/AccountService/Accounts after BIOS
finished all Redfish jobs. The bootstrap account won't be
available to other application. So deleting bootstrap account
helps to release resource at BMC.
- After bootstrap account
Sent: Monday, May 13, 2024 5:02 PM
To: devel@edk2.groups.io; abner.ch...@amd.com; Nickle Wang
; Rebecca Cran
Cc: Isaac Oram ; Attar, AbdulLateef (Abdul Lateef)
; Tinh Nguyen
Subject: Re: [edk2-devel] [edk2-platforms][PATCH] ManageabilityPkg: add
support for the phosphor ipmi blob transfer
1 - 100 of 12063 matches
Mail list logo
