Re: [edk2-devel] [edk2-platform patch 7/7] Platform/Intel: Add build option for SIMICS QSP Platform
Thanks David. No more comments for this patch. > -Original Message- > From: Wei, David Y > Sent: Friday, August 23, 2019 10:06 AM > To: Kubacki, Michael A ; > devel@edk2.groups.io > Cc: Wu, Hao A ; Gao, Liming ; > Sinha, Ankit ; Agyeman, Prince > ; Desimone, Nathaniel L > ; Kinney, Michael D > > Subject: RE: [edk2-platform patch 7/7] Platform/Intel: Add build option for > SIMICS QSP Platform > > Hi Mike, > Please see the updates online below. Please let me know if you have any > more comments. > > Thanks > David > > -Original Message- > From: Kubacki, Michael A > Sent: Monday, August 19, 2019 6:05 PM > To: Wei, David Y ; devel@edk2.groups.io > Cc: Wu, Hao A ; Gao, Liming ; > Sinha, Ankit ; Agyeman, Prince > ; Desimone, Nathaniel L > ; Kinney, Michael D > > Subject: RE: [edk2-platform patch 7/7] Platform/Intel: Add build option for > SIMICS QSP Platform > > You will need to resolve a conflict in build.cfg. When you do so, please keep > the boards under [PLATFORMS] in lexicographically ascending order for ease > of maintenance. > Ydwei: done > > -Original Message- > > From: Wei, David Y > > Sent: Friday, August 9, 2019 3:47 PM > > To: devel@edk2.groups.io > > Cc: Wu, Hao A ; Gao, Liming > > ; Sinha, Ankit ; Agyeman, > > Prince ; Kubacki, Michael A > > ; Desimone, Nathaniel L > > ; Kinney, Michael D > > > > Subject: [edk2-platform patch 7/7] Platform/Intel: Add build option > > for SIMICS QSP Platform > > > > Add build option in build script for SIMICS QSP Platform > > > > Cc: Hao Wu > > Cc: Liming Gao > > Cc: Ankit Sinha > > Cc: Agyeman Prince > > Cc: Kubacki Michael A > > Cc: Nate DeSimone > > Cc: Michael D Kinney > > Contributed-under: TianoCore Contribution Agreement 1.0 > > > > Signed-off-by: David Wei > > --- > > Platform/Intel/build.cfg | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/Platform/Intel/build.cfg b/Platform/Intel/build.cfg index > > fc6e4fe824..2ebe09a632 100644 > > --- a/Platform/Intel/build.cfg > > +++ b/Platform/Intel/build.cfg > > @@ -54,3 +54,5 @@ NUMBER_OF_PROCESSORS = 0 > > KabylakeRvp3 = KabylakeOpenBoardPkg/KabylakeRvp3/build_config.cfg > > N1xxWU = ClevoOpenBoardPkg/N1xxWU/build_config.cfg > > BoardMtOlympus = > PurleyOpenBoardPkg/BoardMtOlympus/build_config.cfg > > +WhiskeylakeURvp = > > +WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/build_config.cfg > > +BoardX58ICH10 = SimicsOpenBoardPkg/BoardX58ICH10/build_config.cfg > > -- > > 2.16.2.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#46383): https://edk2.groups.io/g/devel/message/46383 Mute This Topic: https://groups.io/mt/32816101/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [edk2-platform patch 7/7] Platform/Intel: Add build option for SIMICS QSP Platform
Hi Mike, Please see the updates online below. Please let me know if you have any more comments. Thanks David -Original Message- From: Kubacki, Michael A Sent: Monday, August 19, 2019 6:05 PM To: Wei, David Y ; devel@edk2.groups.io Cc: Wu, Hao A ; Gao, Liming ; Sinha, Ankit ; Agyeman, Prince ; Desimone, Nathaniel L ; Kinney, Michael D Subject: RE: [edk2-platform patch 7/7] Platform/Intel: Add build option for SIMICS QSP Platform You will need to resolve a conflict in build.cfg. When you do so, please keep the boards under [PLATFORMS] in lexicographically ascending order for ease of maintenance. Ydwei: done > -Original Message- > From: Wei, David Y > Sent: Friday, August 9, 2019 3:47 PM > To: devel@edk2.groups.io > Cc: Wu, Hao A ; Gao, Liming > ; Sinha, Ankit ; Agyeman, > Prince ; Kubacki, Michael A > ; Desimone, Nathaniel L > ; Kinney, Michael D > > Subject: [edk2-platform patch 7/7] Platform/Intel: Add build option > for SIMICS QSP Platform > > Add build option in build script for SIMICS QSP Platform > > Cc: Hao Wu > Cc: Liming Gao > Cc: Ankit Sinha > Cc: Agyeman Prince > Cc: Kubacki Michael A > Cc: Nate DeSimone > Cc: Michael D Kinney > Contributed-under: TianoCore Contribution Agreement 1.0 > > Signed-off-by: David Wei > --- > Platform/Intel/build.cfg | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Platform/Intel/build.cfg b/Platform/Intel/build.cfg index > fc6e4fe824..2ebe09a632 100644 > --- a/Platform/Intel/build.cfg > +++ b/Platform/Intel/build.cfg > @@ -54,3 +54,5 @@ NUMBER_OF_PROCESSORS = 0 > KabylakeRvp3 = KabylakeOpenBoardPkg/KabylakeRvp3/build_config.cfg > N1xxWU = ClevoOpenBoardPkg/N1xxWU/build_config.cfg > BoardMtOlympus = PurleyOpenBoardPkg/BoardMtOlympus/build_config.cfg > +WhiskeylakeURvp = > +WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/build_config.cfg > +BoardX58ICH10 = SimicsOpenBoardPkg/BoardX58ICH10/build_config.cfg > -- > 2.16.2.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#46314): https://edk2.groups.io/g/devel/message/46314 Mute This Topic: https://groups.io/mt/32816101/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [edk2-platform patch 7/7] Platform/Intel: Add build option for SIMICS QSP Platform
You will need to resolve a conflict in build.cfg. When you do so, please keep the boards under [PLATFORMS] in lexicographically ascending order for ease of maintenance. > -Original Message- > From: Wei, David Y > Sent: Friday, August 9, 2019 3:47 PM > To: devel@edk2.groups.io > Cc: Wu, Hao A ; Gao, Liming ; > Sinha, Ankit ; Agyeman, Prince > ; Kubacki, Michael A > ; Desimone, Nathaniel L > ; Kinney, Michael D > > Subject: [edk2-platform patch 7/7] Platform/Intel: Add build option for SIMICS > QSP Platform > > Add build option in build script for SIMICS QSP Platform > > Cc: Hao Wu > Cc: Liming Gao > Cc: Ankit Sinha > Cc: Agyeman Prince > Cc: Kubacki Michael A > Cc: Nate DeSimone > Cc: Michael D Kinney > Contributed-under: TianoCore Contribution Agreement 1.0 > > Signed-off-by: David Wei > --- > Platform/Intel/build.cfg | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Platform/Intel/build.cfg b/Platform/Intel/build.cfg index > fc6e4fe824..2ebe09a632 100644 > --- a/Platform/Intel/build.cfg > +++ b/Platform/Intel/build.cfg > @@ -54,3 +54,5 @@ NUMBER_OF_PROCESSORS = 0 > KabylakeRvp3 = KabylakeOpenBoardPkg/KabylakeRvp3/build_config.cfg > N1xxWU = ClevoOpenBoardPkg/N1xxWU/build_config.cfg > BoardMtOlympus = PurleyOpenBoardPkg/BoardMtOlympus/build_config.cfg > +WhiskeylakeURvp = > +WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/build_config.cfg > +BoardX58ICH10 = SimicsOpenBoardPkg/BoardX58ICH10/build_config.cfg > -- > 2.16.2.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#46069): https://edk2.groups.io/g/devel/message/46069 Mute This Topic: https://groups.io/mt/32816101/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [edk2-platform patch 7/7] Platform/Intel: Add build option for SIMICS QSP Platform
Hi David, This patch no longer applies cleanly on the latest edk2-platforms master branch. In addition to addressing the review feedback I previously sent, please rebase your patch. Thanks, Nate -Original Message- From: Wei, David Y Sent: Friday, August 9, 2019 3:47 PM To: devel@edk2.groups.io Cc: Wu, Hao A ; Gao, Liming ; Sinha, Ankit ; Agyeman, Prince ; Kubacki, Michael A ; Desimone, Nathaniel L ; Kinney, Michael D Subject: [edk2-platform patch 7/7] Platform/Intel: Add build option for SIMICS QSP Platform Add build option in build script for SIMICS QSP Platform Cc: Hao Wu Cc: Liming Gao Cc: Ankit Sinha Cc: Agyeman Prince Cc: Kubacki Michael A Cc: Nate DeSimone Cc: Michael D Kinney Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: David Wei --- Platform/Intel/build.cfg | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Platform/Intel/build.cfg b/Platform/Intel/build.cfg index fc6e4fe824..2ebe09a632 100644 --- a/Platform/Intel/build.cfg +++ b/Platform/Intel/build.cfg @@ -54,3 +54,5 @@ NUMBER_OF_PROCESSORS = 0 KabylakeRvp3 = KabylakeOpenBoardPkg/KabylakeRvp3/build_config.cfg N1xxWU = ClevoOpenBoardPkg/N1xxWU/build_config.cfg BoardMtOlympus = PurleyOpenBoardPkg/BoardMtOlympus/build_config.cfg +WhiskeylakeURvp = +WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/build_config.cfg +BoardX58ICH10 = SimicsOpenBoardPkg/BoardX58ICH10/build_config.cfg -- 2.16.2.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#46059): https://edk2.groups.io/g/devel/message/46059 Mute This Topic: https://groups.io/mt/32816101/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [edk2-platform patch 7/7] Platform/Intel: Add build option for SIMICS QSP Platform
Hi David, Here are my comments: 1. Please remove " Contributed-under: TianoCore Contribution Agreement 1.0" from your commit message as it is no longer needed. 2. Please don't add this entry: WhiskeylakeURvp = WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/build_config.cfg WhiskeylakeOpenBoardPkg does not exist yet, and it will be coming from a separate patch series. 3. Please rename BoardX58ICH10 to follow Pascal casing: BoardX58Ich10 4. Please update edk2-platforms/Platform/Intel/Readme.md to add SimicsOpenBoardPkg to the Board Support list. Other than that, looks good! Please send an updated patch. Thanks, Nate -Original Message- From: Wei, David Y Sent: Friday, August 9, 2019 3:47 PM To: devel@edk2.groups.io Cc: Wu, Hao A ; Gao, Liming ; Sinha, Ankit ; Agyeman, Prince ; Kubacki, Michael A ; Desimone, Nathaniel L ; Kinney, Michael D Subject: [edk2-platform patch 7/7] Platform/Intel: Add build option for SIMICS QSP Platform Add build option in build script for SIMICS QSP Platform Cc: Hao Wu Cc: Liming Gao Cc: Ankit Sinha Cc: Agyeman Prince Cc: Kubacki Michael A Cc: Nate DeSimone Cc: Michael D Kinney Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: David Wei --- Platform/Intel/build.cfg | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Platform/Intel/build.cfg b/Platform/Intel/build.cfg index fc6e4fe824..2ebe09a632 100644 --- a/Platform/Intel/build.cfg +++ b/Platform/Intel/build.cfg @@ -54,3 +54,5 @@ NUMBER_OF_PROCESSORS = 0 KabylakeRvp3 = KabylakeOpenBoardPkg/KabylakeRvp3/build_config.cfg N1xxWU = ClevoOpenBoardPkg/N1xxWU/build_config.cfg BoardMtOlympus = PurleyOpenBoardPkg/BoardMtOlympus/build_config.cfg +WhiskeylakeURvp = +WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/build_config.cfg +BoardX58ICH10 = SimicsOpenBoardPkg/BoardX58ICH10/build_config.cfg -- 2.16.2.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#45748): https://edk2.groups.io/g/devel/message/45748 Mute This Topic: https://groups.io/mt/32816101/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
