Re: [edk2-devel] [PATCH] BaseTools/PatchCheck.py: Add LicenseCheck

2020-04-28 Thread Leif Lindholm
On Tue, Apr 28, 2020 at 15:59:48 +0200, Laszlo Ersek wrote: > On 04/24/20 18:25, Leif Lindholm wrote: > > On Fri, Apr 24, 2020 at 18:13:58 +0200, Laszlo Ersek wrote: > >> On 04/22/20 18:01, Liming Gao wrote: > >>> Mike: > >>> The checker purpose is to make sure the correct license be used for

Re: [edk2-devel] [PATCH] BaseTools/PatchCheck.py: Add LicenseCheck

2020-04-24 Thread Leif Lindholm
On Fri, Apr 24, 2020 at 18:13:58 +0200, Laszlo Ersek wrote: > On 04/22/20 18:01, Liming Gao wrote: > > Mike: > > The checker purpose is to make sure the correct license be used for new > > added file. If the file has the different license, it should be reviewed > > carefully. > > > > I

Re: [edk2-devel] [PATCH] BaseTools/PatchCheck.py: Add LicenseCheck

2020-04-24 Thread Laszlo Ersek
>> From: Kinney, Michael D >> Sent: Wednesday, April 22, 2020 11:41 PM >> To: devel@edk2.groups.io; Gao, Liming ; Zhang, >> Shenglei ; Kinney, Michael D >> >> Cc: Feng, Bob C >> Subject: RE: [edk2-devel] [PATCH] BaseTools/PatchCheck.py: Add LicenseCheck &

Re: [edk2-devel] [PATCH] BaseTools/PatchCheck.py: Add LicenseCheck

2020-04-22 Thread Liming Gao
ng, Shenglei > ; Kinney, Michael D > > Cc: Feng, Bob C > Subject: RE: [edk2-devel] [PATCH] BaseTools/PatchCheck.py: Add LicenseCheck > > Hi Liming, > > I do not see this change checking that the license is in a proper > SPDX Identifier statement? > >

Re: [edk2-devel] [PATCH] BaseTools/PatchCheck.py: Add LicenseCheck

2020-04-22 Thread Michael D Kinney
of PatchCheck.py is clearly defined. Thanks, Mike > -Original Message- > From: devel@edk2.groups.io On > Behalf Of Liming Gao > Sent: Wednesday, April 22, 2020 12:02 AM > To: Zhang, Shenglei ; > devel@edk2.groups.io > Cc: Feng, Bob C > Subject: Re: [edk2-de

Re: [edk2-devel] [PATCH] BaseTools/PatchCheck.py: Add LicenseCheck

2020-04-22 Thread Liming Gao
Shenglei: Please submit BZ to describe it. The license should be BSD-2-Clause-Patent. Thanks Liming > -Original Message- > From: Zhang, Shenglei > Sent: Wednesday, April 22, 2020 2:57 PM > To: devel@edk2.groups.io > Cc: Feng, Bob C ; Gao, Liming > Subject: [PATCH]

[edk2-devel] [PATCH] BaseTools/PatchCheck.py: Add LicenseCheck

2020-04-22 Thread Zhang, Shenglei
For files to be added to the tree, this feature will check whether it has BSD license. Cc: Bob Feng Cc: Liming Gao Signed-off-by: Shenglei Zhang --- BaseTools/Scripts/PatchCheck.py | 52 - 1 file changed, 51 insertions(+), 1 deletion(-) diff --git