Re: [edk2-devel] [PATCH] BaseTools: Library hashing fix and optimization for --hash feature

2019-05-16 Thread Bob Feng
Hi Christian, +# Return a Boolean based on if can skip by hash, either from memory or from IO. +if self.Name not in GlobalData.gBuildHashSkipTracking[self.Arch]: +# If hashes are the same, SaveFileOnChange() will return False. +GlobalData.gBuildHashSkipTrac

[edk2-devel] [PATCH] BaseTools: Library hashing fix and optimization for --hash feature

2019-05-14 Thread Christian Rodriguez
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1788 Library hashing is now supported by the --hash feature. The --hash feature implementation assumed that the hashing could be done in place once per module, but that isn't true for libraries due to the fact that they are built as dependencies. S