Re: [edk2-devel] [PATCH] Fix indentation in edksetup.sh SetupPython3

2019-06-30 Thread Liming Gao
ijuX >Subject: Re: [edk2-devel] [PATCH] Fix indentation in edksetup.sh >SetupPython3 > >On 6/28/19 2:04 AM, Liming Gao wrote: >> The change is good. Reviewed-by: Liming Gao >> >> I suggest you run this script in Linux and double confirm. > > >I've tested

Re: [edk2-devel] [PATCH] Fix indentation in edksetup.sh SetupPython3

2019-06-28 Thread rebecca
On 6/28/19 2:04 AM, Liming Gao wrote: The change is good. Reviewed-by: Liming Gao I suggest you run this script in Linux and double confirm. I've tested it on openSUSE Tumbleweed 20190626 and verified it still works, by building OVMF. I tested both with and without PYTHON3_ENABLE=TRUE

Re: [edk2-devel] [PATCH] Fix indentation in edksetup.sh SetupPython3

2019-06-27 Thread Liming Gao
To: devel@edk2.groups.io; Feng, Bob C ; Gao, Liming > ; Fan, ZhijuX > Cc: Rebecca Cran > Subject: [edk2-devel] [PATCH] Fix indentation in edksetup.sh SetupPython3 > > Signed-off-by: Rebecca Cran > --- > edksetup.sh | 40 > 1 file

[edk2-devel] [PATCH] Fix indentation in edksetup.sh SetupPython3

2019-06-26 Thread rebecca
Signed-off-by: Rebecca Cran --- edksetup.sh | 40 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/edksetup.sh b/edksetup.sh index c7b2e1e201..61e988035f 100755 --- a/edksetup.sh +++ b/edksetup.sh @@ -108,27 +108,27 @@ function SetupEnv()