Re: [edk2-devel] [PATCH] UefiCpuPkg CpuCommonFeaturesLib: Enhance Ppin code

2019-07-16 Thread Dong, Eric
Done SHA-1: 84a459472075d94963463bffaa5dc6eee47f14c3 * UefiCpuPkg CpuCommonFeaturesLib: Enhance Ppin code BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1961 Enhance Ppin code to enable and unlock for TRUE State, and disable and lock for FALSE State. Note: enable and lock could not be set bo

Re: [edk2-devel] [PATCH] UefiCpuPkg CpuCommonFeaturesLib: Enhance Ppin code

2019-07-16 Thread Zeng, Star
Eric, Thanks for the comments. Attach the updated patch, and you may help push it if it is ok. Thanks, Star > -Original Message- > From: Dong, Eric > Sent: Tuesday, July 16, 2019 3:24 PM > To: Zeng, Star ; devel@edk2.groups.io > Cc: Laszlo Ersek ; Ni, Ray ; Kumar, > Chandana C ; Li, Kev

Re: [edk2-devel] [PATCH] UefiCpuPkg CpuCommonFeaturesLib: Enhance Ppin code

2019-07-16 Thread Dong, Eric
Hi Star, Suggest to add some code comments for the behavior, detail see the inline comments. with these comments, Reviewed-by: Eric Dong Thanks, Eric > -Original Message- > From: Zeng, Star > Sent: Friday, July 12, 2019 6:13 PM > To: devel@edk2.groups.io > Cc: Zeng, Star ; Laszlo Ersek

Re: [edk2-devel] [PATCH] UefiCpuPkg CpuCommonFeaturesLib: Enhance Ppin code

2019-07-15 Thread Ni, Ray
Chandana C ; Li, Kevin Y > > Subject: [edk2-devel] [PATCH] UefiCpuPkg CpuCommonFeaturesLib: > Enhance Ppin code > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1961 > Enhance Ppin code to enable and unlock for TRUE State, and disable and lock > for FALSE State. > Note

Re: [edk2-devel] [PATCH] UefiCpuPkg CpuCommonFeaturesLib: Enhance Ppin code

2019-07-12 Thread Laszlo Ersek
On 07/12/19 12:12, Star Zeng wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1961 > Enhance Ppin code to enable and unlock for TRUE State, > and disable and lock for FALSE State. > Note: enable and lock could not be set both. > > Cc: Laszlo Ersek > Cc: Eric Dong > Cc: Ray Ni > Cc: C

[edk2-devel] [PATCH] UefiCpuPkg CpuCommonFeaturesLib: Enhance Ppin code

2019-07-12 Thread Zeng, Star
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1961 Enhance Ppin code to enable and unlock for TRUE State, and disable and lock for FALSE State. Note: enable and lock could not be set both. Cc: Laszlo Ersek Cc: Eric Dong Cc: Ray Ni Cc: Chandana Kumar Cc: Kevin Li Signed-off-by: Star Zeng