Re: [edk2-devel] [PATCH 0/3] BaseTools: Add a script to use with 'git-send-email --cc-cmd'

2019-10-16 Thread Stefan Hajnoczi
On Wed, Oct 16, 2019 at 06:50:29PM +0200, Philippe Mathieu-Daudé wrote: > On 10/16/19 5:18 PM, Leif Lindholm wrote: > > For this reason *I* would not use said script, but I'm not going to > > say we shouldn't have it. I will say it shouldn't be enabled by > > default by SetupGit.py though. > >

Re: [edk2-devel] [PATCH 0/3] BaseTools: Add a script to use with 'git-send-email --cc-cmd'

2019-10-16 Thread Philippe Mathieu-Daudé
On 10/16/19 5:18 PM, Leif Lindholm wrote: Hi Phil, This is definitely a manual step that could do with automation, so many thanks for having a go. ...But, I have a few reservations regarding the actual solution. First of all, doing it as a .sh means it will not work for those developers

Re: [edk2-devel] [PATCH 0/3] BaseTools: Add a script to use with 'git-send-email --cc-cmd'

2019-10-16 Thread Leif Lindholm
Hi Phil, This is definitely a manual step that could do with automation, so many thanks for having a go. ...But, I have a few reservations regarding the actual solution. First of all, doing it as a .sh means it will not work for those developers working primarily with Visual Studio. Rewriting it

Re: [edk2-devel] [PATCH 0/3] BaseTools: Add a script to use with 'git-send-email --cc-cmd'

2019-10-16 Thread Laszlo Ersek
Hi Phil, On 10/16/19 16:09, Philippe Mathieu-Daude wrote: > Hi, > > This series contains trivial fixes to the GetMaintainer.py script, > then adds a new script which allow git-send-email to automatically > fills the email addresses relevant to each patch, using the new > Maintainer.txt format

[edk2-devel] [PATCH 0/3] BaseTools: Add a script to use with 'git-send-email --cc-cmd'

2019-10-16 Thread Philippe Mathieu-Daudé
Hi, This series contains trivial fixes to the GetMaintainer.py script, then adds a new script which allow git-send-email to automatically fills the email addresses relevant to each patch, using the new Maintainer.txt format (with the GetMaintainer.py script). I sent this series adding: