Re: [edk2-devel] [PATCH 0/4] Arm, ArmPlatform, Crypto, Embedded: list internal headers in [Sources]

2019-07-25 Thread Laszlo Ersek
On 07/24/19 19:00, Leif Lindholm wrote: > On Wed, Jul 24, 2019 at 03:17:56PM +, Gao, Liming wrote: >>> Would it be feasible to update the --hash functionality to make use of >>> the include dependencies extracted from the source files? (Clearly, we >>> know when the source files change, so we

Re: [edk2-devel] [PATCH 0/4] Arm, ArmPlatform, Crypto, Embedded: list internal headers in [Sources]

2019-07-24 Thread Leif Lindholm
On Wed, Jul 24, 2019 at 03:17:56PM +, Gao, Liming wrote: > > Would it be feasible to update the --hash functionality to make use of > > the include dependencies extracted from the source files? (Clearly, we > > know when the source files change, so we would also know when we would > > need to

Re: [edk2-devel] [PATCH 0/4] Arm, ArmPlatform, Crypto, Embedded: list internal headers in [Sources]

2019-07-24 Thread Liming Gao
Wang, Jian J ; Ye, Ting > > Subject: Re: [edk2-devel] [PATCH 0/4] Arm, ArmPlatform, Crypto, Embedded: > list internal headers in [Sources] > > On Tue, Jul 23, 2019 at 01:02:42PM +, Gao, Liming wrote: > > > > > I am just not pleased with the issue > > > >

Re: [edk2-devel] [PATCH 0/4] Arm, ArmPlatform, Crypto, Embedded: list internal headers in [Sources]

2019-07-23 Thread Laszlo Ersek
On 07/23/19 14:19, Leif Lindholm wrote: > On Tue, Jul 23, 2019 at 01:54:54PM +0200, Laszlo Ersek wrote: I wasn't annoyed at the feature itself -- if it helps developers catch unlisted headers as soon as incomplete INF files are introduced, then it's not a bad feature IMO. >>> >>> I

Re: [edk2-devel] [PATCH 0/4] Arm, ArmPlatform, Crypto, Embedded: list internal headers in [Sources]

2019-07-23 Thread Leif Lindholm
On Tue, Jul 23, 2019 at 01:02:42PM +, Gao, Liming wrote: > > > > I am just not pleased with the issue > > > > bringing this to the fore is caused by the new caching feature using a > > > > different mechanism for tracking header file dependencies than the > > > > primary build process. > > > >

Re: [edk2-devel] [PATCH 0/4] Arm, ArmPlatform, Crypto, Embedded: list internal headers in [Sources]

2019-07-23 Thread Liming Gao
Ye, Ting > Subject: Re: [edk2-devel] [PATCH 0/4] Arm, ArmPlatform, Crypto, Embedded: > list internal headers in [Sources] > > On Tue, Jul 23, 2019 at 01:54:54PM +0200, Laszlo Ersek wrote: > > >> I wasn't annoyed at the feature itself -- if it helps developers catch > &g

Re: [edk2-devel] [PATCH 0/4] Arm, ArmPlatform, Crypto, Embedded: list internal headers in [Sources]

2019-07-23 Thread Leif Lindholm
On Tue, Jul 23, 2019 at 01:54:54PM +0200, Laszlo Ersek wrote: > >> I wasn't annoyed at the feature itself -- if it helps developers catch > >> unlisted headers as soon as incomplete INF files are introduced, then > >> it's not a bad feature IMO. > > > > I agree that the optional nature of whether

Re: [edk2-devel] [PATCH 0/4] Arm, ArmPlatform, Crypto, Embedded: list internal headers in [Sources]

2019-07-23 Thread Laszlo Ersek
On 07/23/19 11:06, Leif Lindholm wrote: > On Tue, Jul 23, 2019 at 12:56:23AM +0200, Laszlo Ersek wrote: >> Hi Mike, >> >> On 07/22/19 20:47, Michael D Kinney wrote: >>> We could consider checking for these type of issues in >>> the ECC tool instead of build and make it an error from >>> ECC

Re: [edk2-devel] [PATCH 0/4] Arm, ArmPlatform, Crypto, Embedded: list internal headers in [Sources]

2019-07-23 Thread Leif Lindholm
On Tue, Jul 23, 2019 at 12:56:23AM +0200, Laszlo Ersek wrote: > Hi Mike, > > On 07/22/19 20:47, Michael D Kinney wrote: > > We could consider checking for these type of issues in > > the ECC tool instead of build and make it an error from > > ECC instead of a warning. > > I'm sorry, my reply to

Re: [edk2-devel] [PATCH 0/4] Arm, ArmPlatform, Crypto, Embedded: list internal headers in [Sources]

2019-07-22 Thread Laszlo Ersek
2.groups.io] >> On Behalf Of Laszlo Ersek >> Sent: Monday, July 22, 2019 10:33 AM >> To: Leif Lindholm >> Cc: edk2-devel-groups-io ; Ard >> Biesheuvel ; Wang, Jian J >> ; Ye, Ting >> Subject: Re: [edk2-devel] [PATCH 0/4] Arm, ArmPlatform, >> Crypto, Embedd

Re: [edk2-devel] [PATCH 0/4] Arm, ArmPlatform, Crypto, Embedded: list internal headers in [Sources]

2019-07-22 Thread Michael D Kinney
019 10:33 AM > To: Leif Lindholm > Cc: edk2-devel-groups-io ; Ard > Biesheuvel ; Wang, Jian J > ; Ye, Ting > Subject: Re: [edk2-devel] [PATCH 0/4] Arm, ArmPlatform, > Crypto, Embedded: list internal headers in [Sources] > > On 07/22/19 12:37, Leif Lindholm wrote: > >

Re: [edk2-devel] [PATCH 0/4] Arm, ArmPlatform, Crypto, Embedded: list internal headers in [Sources]

2019-07-22 Thread Laszlo Ersek
On 07/22/19 12:37, Leif Lindholm wrote: > On Fri, Jul 19, 2019 at 06:43:15PM +0200, Laszlo Ersek wrote: >> Repo: https://github.com/lersek/edk2.git >> Branch: internal_hdrs >> >> The BaseTools build feature introduced for TianoCore#1804 / in commit >> 1fa6699e6cd4 ("BaseTools: Add a checking for

Re: [edk2-devel] [PATCH 0/4] Arm, ArmPlatform, Crypto, Embedded: list internal headers in [Sources]

2019-07-22 Thread Leif Lindholm
On Fri, Jul 19, 2019 at 06:43:15PM +0200, Laszlo Ersek wrote: > Repo: https://github.com/lersek/edk2.git > Branch: internal_hdrs > > The BaseTools build feature introduced for TianoCore#1804 / in commit > 1fa6699e6cd4 ("BaseTools: Add a checking for Sources section in INF > file", 2019-06-10)

[edk2-devel] [PATCH 0/4] Arm, ArmPlatform, Crypto, Embedded: list internal headers in [Sources]

2019-07-19 Thread Laszlo Ersek
Repo: https://github.com/lersek/edk2.git Branch: internal_hdrs The BaseTools build feature introduced for TianoCore#1804 / in commit 1fa6699e6cd4 ("BaseTools: Add a checking for Sources section in INF file", 2019-06-10) logs some (non-fatal) warnings about unlisted internal header files. List