Re: [edk2-devel] [PATCH 0/4] Define SERIAL_DXE_FILE_GUID only once

2019-06-06 Thread Anthony PERARD
> > So, ultimately, we are asking Anthony to: > > > > (1) please introduce the new GUID as > > EDKII_SERIAL_VENDOR_GUID and gEdkiiSerialVendorGuid, > > Yes. > > > > > (2) please append another patch to this series, > > replacing EFI_CALLER_ID_GUID -- and the comment! -- with > > EDKII_SERIAL_VE

Re: [edk2-devel] [PATCH 0/4] Define SERIAL_DXE_FILE_GUID only once

2019-06-03 Thread Michael D Kinney
el > ; Zeng, Star > ; Wu, Hao A ; > Julien Grall ; Leif Lindholm > > Subject: Re: [edk2-devel] [PATCH 0/4] Define > SERIAL_DXE_FILE_GUID only once > > On 06/03/19 16:50, Kinney, Michael D wrote: > > Laszlo, > > > > We can keep compatibility. > >

Re: [edk2-devel] [PATCH 0/4] Define SERIAL_DXE_FILE_GUID only once

2019-06-03 Thread Laszlo Ersek
om >> Cc: Wang, Jian J ; Ni, Ray >> ; Ard Biesheuvel >> ; Zeng, Star >> ; Wu, Hao A ; >> Julien Grall ; Leif Lindholm >> >> Subject: Re: [edk2-devel] [PATCH 0/4] Define >> SERIAL_DXE_FILE_GUID only once >> >> On 06/01/19 19:00, Kinney, Mi

Re: [edk2-devel] [PATCH 0/4] Define SERIAL_DXE_FILE_GUID only once

2019-06-03 Thread Michael D Kinney
; Zeng, Star > ; Wu, Hao A ; > Julien Grall ; Leif Lindholm > > Subject: Re: [edk2-devel] [PATCH 0/4] Define > SERIAL_DXE_FILE_GUID only once > > On 06/01/19 19:00, Kinney, Michael D wrote: > > Anthony, > > > > I am curious. I agree that a GUID can be defined

Re: [edk2-devel] [PATCH 0/4] Define SERIAL_DXE_FILE_GUID only once

2019-06-03 Thread Laszlo Ersek
riginal Message- >> From: devel@edk2.groups.io >> [mailto:devel@edk2.groups.io] On Behalf Of Anthony >> PERARD >> Sent: Wednesday, May 29, 2019 4:37 AM >> To: devel@edk2.groups.io >> Cc: Wang, Jian J ; Ni, Ray >> ; Ard Biesheuvel >> ; Zeng, Star

Re: [edk2-devel] [PATCH 0/4] Define SERIAL_DXE_FILE_GUID only once

2019-06-03 Thread Anthony PERARD
On Sat, Jun 01, 2019 at 05:00:37PM +, Kinney, Michael D wrote: > I am curious. I agree that a GUID can be defined in DEC file and > in an include file that is used as a Vendor GUID in a device path. > > Is there any reason that the FILE_GUID for the module needs to be > the same GUID value?

Re: [edk2-devel] [PATCH 0/4] Define SERIAL_DXE_FILE_GUID only once

2019-06-01 Thread Michael D Kinney
dnesday, May 29, 2019 4:37 AM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Ni, Ray > ; Ard Biesheuvel > ; Zeng, Star > ; Wu, Hao A ; > Julien Grall ; Leif Lindholm > ; Laszlo Ersek > ; Anthony PERARD > > Subject: [edk2-devel] [PATCH 0/4] Define > SERIAL_DXE_FILE_GU

Re: [edk2-devel] [PATCH 0/4] Define SERIAL_DXE_FILE_GUID only once

2019-06-01 Thread Zeng, Star
devel-groups-io ; Anthony PERARD > > Cc: Wang, Jian J ; Ni, Ray ; Zeng, > Star ; Wu, Hao A ; Julien Grall > ; Leif Lindholm ; Laszlo > Ersek > Subject: Re: [edk2-devel] [PATCH 0/4] Define SERIAL_DXE_FILE_GUID only > once > > On Wed, 29 May 2019 at 13:37, Anthony PERARD >

Re: [edk2-devel] [PATCH 0/4] Define SERIAL_DXE_FILE_GUID only once

2019-05-31 Thread Ard Biesheuvel
On Wed, 29 May 2019 at 13:37, Anthony PERARD wrote: > > The macro SERIAL_DXE_FILE_GUID is already been defined twice and the GUID is > been used once without defining the macro. This patch series define the macro > in MdeModulePkg where the SerialDxe is, and replace all other use by this new > one

[edk2-devel] [PATCH 0/4] Define SERIAL_DXE_FILE_GUID only once

2019-05-29 Thread Anthony PERARD
The macro SERIAL_DXE_FILE_GUID is already been defined twice and the GUID is been used once without defining the macro. This patch series define the macro in MdeModulePkg where the SerialDxe is, and replace all other use by this new one. Note that I haven't build/test those changes, but I have tes