Re: [edk2-devel] [PATCH 00/35] edk2: clean up the usage of standardized (VOID*) typedefs

2019-10-09 Thread Laszlo Ersek
On 10/09/19 01:49, Laszlo Ersek wrote: > On 09/17/19 21:49, Laszlo Ersek wrote: >> Repository: https://github.com/lersek/edk2.git >> Branch: voidptr >> >> The UEFI / PI / Shell specifications define a number of standard types >> as pointers to VOID. This is arguably a design mistake; those

Re: [edk2-devel] [PATCH 00/35] edk2: clean up the usage of standardized (VOID*) typedefs

2019-10-08 Thread Laszlo Ersek
On 09/17/19 21:49, Laszlo Ersek wrote: > Repository: https://github.com/lersek/edk2.git > Branch: voidptr > > The UEFI / PI / Shell specifications define a number of standard types > as pointers to VOID. This is arguably a design mistake; those types > should have been pointers to distinct

Re: [edk2-devel] [PATCH 00/35] edk2: clean up the usage of standardized (VOID*) typedefs

2019-09-25 Thread Laszlo Ersek
(snipping liberally) On 09/25/19 10:13, Marvin Häuser wrote: > Am 24.09.2019 um 22:26 schrieb Laszlo Ersek: >> I'm opposed to enforcing the strict aliasing rules, even though in >> all code that I write, I either try to conform to them, or at least I >> seek to be fully conscious of breaking

Re: [edk2-devel] [PATCH 00/35] edk2: clean up the usage of standardized (VOID*) typedefs

2019-09-25 Thread Marvin Häuser
Thanks for your input. Due to a misconception of union casts (or accesses, really), multiple points were rendered infeasible. I suppose the main point left I'd like some attention towards is alignment, and of course the misdesigned prototypes (CONST). Comments inline. Thanks and regards,

Re: [edk2-devel] [PATCH 00/35] edk2: clean up the usage of standardized (VOID*) typedefs

2019-09-23 Thread Marvin Häuser
Good day, Thank you, Laszlo, for your ambition to introduce stricter code style enforcements. Sorry to "hijack" the actual topic (I did not CC anyone on purpose, as this is mostly a separate topic and I'd like a quick comment first), but this seems like a good occasion to mention another few

Re: [edk2-devel] [PATCH 00/35] edk2: clean up the usage of standardized (VOID*) typedefs

2019-09-18 Thread Wu, Hao A
: [edk2-devel] [PATCH 00/35] edk2: clean up the usage of > standardized (VOID*) typedefs > > Repository: https://github.com/lersek/edk2.git > Branch: voidptr > > The UEFI / PI / Shell specifications define a number of standard types > as pointers to VOID. This is arg

[edk2-devel] [PATCH 00/35] edk2: clean up the usage of standardized (VOID*) typedefs

2019-09-17 Thread Laszlo Ersek
Repository: https://github.com/lersek/edk2.git Branch: voidptr The UEFI / PI / Shell specifications define a number of standard types as pointers to VOID. This is arguably a design mistake; those types should have been pointers to distinct incomplete union or structure types. Here's why: