Re: [edk2-devel] [PATCH 01/35] DO NOT APPLY: edk2: turn standard handle types into pointers to non-VOID

2019-09-18 Thread Laszlo Ersek
On 09/18/19 17:55, Andrew Fish wrote: > > >> On Sep 18, 2019, at 1:41 AM, Laszlo Ersek wrote: >> >> On 09/17/19 22:22, Andrew Fish wrote: >>> >>> On Sep 17, 2019, at 1:06 PM, Ni, Ray wrote: Laszlo, Thank you very much for this work. They are quite helpful to detect

Re: [edk2-devel] [PATCH 01/35] DO NOT APPLY: edk2: turn standard handle types into pointers to non-VOID

2019-09-18 Thread Laszlo Ersek
On 09/18/19 17:16, Kinney, Michael D wrote: >> -Original Message- >> From: Laszlo Ersek >> However, if we wanted to allow new projects to #define >> STRICTER_UEFI_TYPES as their normal mode of operation >> (and not just for a sanity check in CI), then we'd have >> to update the UEFI spec

Re: [edk2-devel] [PATCH 01/35] DO NOT APPLY: edk2: turn standard handle types into pointers to non-VOID

2019-09-18 Thread Leif Lindholm
On Wed, Sep 18, 2019 at 08:55:42AM -0700, Andrew Fish via Groups.Io wrote: > >> #ifndef STRICTER_UEFI_TYPES > >> typedef VOID*EFI_PEI_FV_HANDLE; > >> #else > >> struct EFI_PEI_FV_OBJECT; > >> typedef struct EFI_PEI_FV_OBJECT *EFI_PEI_FV_HANDLE; > >> #endif > > > > Technically, this would work

Re: [edk2-devel] [PATCH 01/35] DO NOT APPLY: edk2: turn standard handle types into pointers to non-VOID

2019-09-18 Thread Andrew Fish via Groups.Io
> On Sep 18, 2019, at 1:41 AM, Laszlo Ersek wrote: > > On 09/17/19 22:22, Andrew Fish wrote: >> >> >>> On Sep 17, 2019, at 1:06 PM, Ni, Ray wrote: >>> >>> Laszlo, >>> Thank you very much for this work. >>> They are quite helpful to detect potential issues. >>> >>> But without this

Re: [edk2-devel] [PATCH 01/35] DO NOT APPLY: edk2: turn standard handle types into pointers to non-VOID

2019-09-18 Thread Michael D Kinney
eth Venkatesh > ; Gao, Zhichao > > Subject: Re: [edk2-devel] [PATCH 01/35] DO NOT APPLY: > edk2: turn standard handle types into pointers to non- > VOID > > On 09/17/19 22:22, Andrew Fish wrote: > > > > > >> On Sep 17, 2019, at 1:06 PM, Ni, Ray &g

Re: [edk2-devel] [PATCH 01/35] DO NOT APPLY: edk2: turn standard handle types into pointers to non-VOID

2019-09-18 Thread Laszlo Ersek
On 09/17/19 22:22, Andrew Fish wrote: > > >> On Sep 17, 2019, at 1:06 PM, Ni, Ray wrote: >> >> Laszlo, >> Thank you very much for this work. >> They are quite helpful to detect potential issues. >> >> But without this specific patch being checked in, future break will still >> happen. >> I

Re: [edk2-devel] [PATCH 01/35] DO NOT APPLY: edk2: turn standard handle types into pointers to non-VOID

2019-09-18 Thread Laszlo Ersek
gt;> Ard Biesheuvel ; You, Benjamin >> ; Zhang, Chao B >> ; Bi, Dandan ; David Woodhouse >> ; Dong, Eric >> ; Dong, Guo ; Wu, Hao A >> ; Carsey, Jaben >> ; Wang, Jian J ; Wu, Jiaxin >> ; Yao, Jiewen >> ; Justen, Jordan L ; Julien >> Grall ; Leif Lin

Re: [edk2-devel] [PATCH 01/35] DO NOT APPLY: edk2: turn standard handle types into pointers to non-VOID

2019-09-17 Thread Michael D Kinney
if > >> > >> Thanks, > >> > >> Andrew Fish > >> > >>> Thanks, > >>> Ray > >>> > >>> > >>>> -Original Message- > >>>> From: devel@edk2.groups.io > On Behalf Of > >>

Re: [edk2-devel] [PATCH 01/35] DO NOT APPLY: edk2: turn standard handle types into pointers to non-VOID

2019-09-17 Thread Andrew Fish via Groups.Io
c ; Dong, Guo >> ; Wu, Hao A >> ; Carsey, Jaben ; Wang, Jian J >> ; Wu, Jiaxin >> ; Yao, Jiewen ; Justen, Jordan L >> ; Julien Grall >> ; Leif Lindholm ; Gao, >> Liming ; Ma, Maurice >> ; Kinney, Michael D ; Fu, >> Siyuan ; Supreeth >> Ven

Re: [edk2-devel] [PATCH 01/35] DO NOT APPLY: edk2: turn standard handle types into pointers to non-VOID

2019-09-17 Thread Ni, Ray
nthony Perard > ; > >> Ard Biesheuvel ; You, Benjamin > >> ; Zhang, Chao B > >> ; Bi, Dandan ; David > >> Woodhouse ; Dong, > Eric > >> ; Dong, Guo ; Wu, Hao A > >> ; Carsey, Jaben > >> ; Wang, Jian J ; Wu, Jiaxin > >&g

Re: [edk2-devel] [PATCH 01/35] DO NOT APPLY: edk2: turn standard handle types into pointers to non-VOID

2019-09-17 Thread Andrew Fish via Groups.Io
> ; Gao, Liming ; Ma, Maurice >> ; Kinney, Michael >> D ; Ni, Ray ; Fu, Siyuan >> ; Supreeth Venkatesh >> ; Gao, Zhichao >> Subject: [edk2-devel] [PATCH 01/35] DO NOT APPLY: edk2: turn standard handle >> types into pointers to non-VOID >> >> Unfort

Re: [edk2-devel] [PATCH 01/35] DO NOT APPLY: edk2: turn standard handle types into pointers to non-VOID

2019-09-17 Thread Ni, Ray
> Grall ; Leif Lindholm > ; Gao, Liming ; Ma, Maurice > ; Kinney, Michael > D ; Ni, Ray ; Fu, Siyuan > ; Supreeth Venkatesh > ; Gao, Zhichao > Subject: [edk2-devel] [PATCH 01/35] DO NOT APPLY: edk2: turn standard handle > types into pointers to non-VOID > >

[edk2-devel] [PATCH 01/35] DO NOT APPLY: edk2: turn standard handle types into pointers to non-VOID

2019-09-17 Thread Laszlo Ersek
Unfortunately, the UEFI / PI / Shell specs define a number of handle types as pointers to VOID. This is a design mistake; those types should have been pointers to incomplete union or structure types. Any pointer-to-object type converts implicitly to, and from, pointer-to-void, which prevents