Re: [edk2-devel] [PATCH 1/1] BaseTools/Conf/tools_def: Fix linking using CLANGDWARF_IA32

2023-04-05 Thread Rebecca Cran
Pushed as https://github.com/tianocore/edk2/commit/2bb693894920e634153275bea60278a9f192a8ef -- Rebecca Cran On 4/5/23 11:15 AM, Rebecca Cran wrote: Reviewed-by: Rebecca Cran On 3/30/23 3:48 AM, Patrick Rudolph wrote: The clang toolchain might default to fPIE/fPIC, which prevents lld

Re: [edk2-devel] [PATCH 1/1] BaseTools/Conf/tools_def: Fix linking using CLANGDWARF_IA32

2023-04-05 Thread Rebecca Cran
Reviewed-by: Rebecca Cran On 3/30/23 3:48 AM, Patrick Rudolph wrote: The clang toolchain might default to fPIE/fPIC, which prevents lld from linking the objects into a binary. Specify -fno-pie -fno-pic as done on GCC to fix linking. Test: Building the Universal Payload using the command

Re: [edk2-devel] [PATCH 1/1] BaseTools/Conf/tools_def: Fix linking using CLANGDWARF_IA32

2023-04-04 Thread Sheng Lean Tan
Can anyone help to review this? -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#102481): https://edk2.groups.io/g/devel/message/102481 Mute This Topic: https://groups.io/mt/97947217/21656 Group Owner: devel+ow...@edk2.groups.io

[edk2-devel] [PATCH 1/1] BaseTools/Conf/tools_def: Fix linking using CLANGDWARF_IA32

2023-03-30 Thread Patrick Rudolph
The clang toolchain might default to fPIE/fPIC, which prevents lld from linking the objects into a binary. Specify -fno-pie -fno-pic as done on GCC to fix linking. Test: Building the Universal Payload using the command 'python UefiPayloadPkg/UniversalPayloadBuild.py -a IA32' actually works.