Re: [edk2-devel] [PATCH 1/1] BaseTools: Switch to GNU mode for CLANGPDB

2020-02-12 Thread Vitaly Cheptsov via Groups.Io
; > Thanks > > Liming > > From: devel@edk2.groups.io On Behalf Of Vitaly > Cheptsov via Groups.Io > Sent: Wednesday, February 12, 2020 4:08 PM > To: Liu, Zhiguang > Cc: devel@edk2.groups.io; Gao, Liming ; Shi, Steven > > Subject: Re: [edk2-devel] [PATCH 1/1]

Re: [edk2-devel] [PATCH 1/1] BaseTools: Switch to GNU mode for CLANGPDB

2020-02-12 Thread Liming Gao
:08 PM To: Liu, Zhiguang Cc: devel@edk2.groups.io; Gao, Liming ; Shi, Steven Subject: Re: [edk2-devel] [PATCH 1/1] BaseTools: Switch to GNU mode for CLANGPDB Liu, Thanks for explanation, it does make sense now. As for no need to -DNO_MSABI_VA_FUNCS I agree, but it will not make much difference

Re: [edk2-devel] [PATCH 1/1] BaseTools: Switch to GNU mode for CLANGPDB

2020-02-12 Thread Vitaly Cheptsov via Groups.Io
; Sent: Tuesday, February 11, 2020 3:09 PM > To: Gao, Liming mailto:liming@intel.com>>; Liu, > Zhiguang mailto:zhiguang@intel.com>>; Shi, > Steven mailto:steven@intel.com>> > Cc: devel@edk2.groups.io <mailto:devel@edk2.groups.io> > Subje

Re: [edk2-devel] [PATCH 1/1] BaseTools: Switch to GNU mode for CLANGPDB

2020-02-11 Thread Zhiguang Liu
y 11, 2020 1:34 PM To: vit9696 mailto:vit9...@protonmail.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io> Subject: Re: [edk2-devel] [PATCH 1/1] BaseTools: Switch to GNU mode for CLANGPDB Reviewed-by: Liming Gao mailto:liming@intel.com>> From: vit9696 mailto:vit9...@protonm

Re: [edk2-devel] [PATCH 1/1] BaseTools: Switch to GNU mode for CLANGPDB

2020-02-10 Thread Vitaly Cheptsov via Groups.Io
rom: devel@edk2.groups.io <mailto:devel@edk2.groups.io> > mailto:devel@edk2.groups.io>> On Behalf Of Liming Gao > Sent: Tuesday, February 11, 2020 1:34 PM > To: vit9696 mailto:vit9...@protonmail.com>>; > devel@edk2.groups.io <mailto:devel@edk2.groups.i

Re: [edk2-devel] [PATCH 1/1] BaseTools: Switch to GNU mode for CLANGPDB

2020-02-10 Thread Liming Gao
l Message- > From: devel@edk2.groups.io<mailto:devel@edk2.groups.io> > mailto:devel@edk2.groups.io>> On Behalf Of Vitaly > Cheptsov via Groups.Io > Sent: Monday, February 10, 2020 6:59 PM > To: devel@edk2.groups.io<mailto:devel@edk2.groups.io> > Subject: [edk2-

Re: [edk2-devel] [PATCH 1/1] BaseTools: Switch to GNU mode for CLANGPDB

2020-02-10 Thread Liming Gao
Reviewed-by: Liming Gao From: vit9696 Sent: Tuesday, February 11, 2020 3:23 AM To: Gao, Liming ; devel@edk2.groups.io Subject: RE: [edk2-devel] [PATCH 1/1] BaseTools: Switch to GNU mode for CLANGPDB Liming, We did run several of our projects based on EDK II in X64 mode, DEBUG, RELEASE, NOOPT

Re: [edk2-devel] [PATCH 1/1] BaseTools: Switch to GNU mode for CLANGPDB

2020-02-10 Thread Vitaly Cheptsov via Groups.Io
eptsov via Groups.Io >> Sent: Monday, February 10, 2020 6:59 PM >> To: devel@edk2.groups.io >> Subject: [edk2-devel] [PATCH 1/1] BaseTools: Switch to GNU mode for CLANGPDB >> >> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2397 >> >> Signed-off-by: Vit

Re: [edk2-devel] [PATCH 1/1] BaseTools: Switch to GNU mode for CLANGPDB

2020-02-10 Thread Liming Gao
February 10, 2020 6:59 PM > To: devel@edk2.groups.io > Subject: [edk2-devel] [PATCH 1/1] BaseTools: Switch to GNU mode for CLANGPDB > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2397 > > Signed-off-by: Vitaly Cheptsov > --- > BaseTools/Conf/tools_def.temp

[edk2-devel] [PATCH 1/1] BaseTools: Switch to GNU mode for CLANGPDB

2020-02-10 Thread Vitaly Cheptsov via Groups.Io
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2397 Signed-off-by: Vitaly Cheptsov --- BaseTools/Conf/tools_def.template | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/BaseTools/Conf/tools_def.template b/BaseTools/Conf/tools_def.template index